]> granicus.if.org Git - postgresql/commit
Fix escaping in generated recovery.conf file.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 20 May 2013 16:34:27 +0000 (19:34 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 20 May 2013 16:41:45 +0000 (19:41 +0300)
commit30b5ede7157e34e77c7914b8ecfd55aa8da6edc3
treeecf04e12f05ad09c6790798d493f07f817c5dd63
parent2af0971f35a4a7b87312b83782d9bb0cc6a40ad0
Fix escaping in generated recovery.conf file.

In the primary_conninfo line that "pg_basebackup -R" generates, single
quotes in parameter values need to be escaped into \\'; the libpq parser
requires the quotes to be escaped into \', and recovery.conf parser requires
the \ to be escaped into \\.

Also, don't quote parameter values unnecessarily, to make the connection
string prettier. Most options in a libpq connection string don't need
quoting.

Reported by Hari Babu, closer analysis by Zoltan Boszormenyi, although I
didn't use his patch.
src/bin/pg_basebackup/pg_basebackup.c