]> granicus.if.org Git - postgresql/commit
Improve handling of INT_MIN / -1 and related cases.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 19 Nov 2012 17:24:25 +0000 (12:24 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 19 Nov 2012 17:24:25 +0000 (12:24 -0500)
commit1f7cb5c30983752ff8de833de30afcaee63536d0
tree9a26c3aab4d7475fa1217f0327f19254e9a99a95
parent644a0a6379afc00803dd89ffe8416514f5dfc217
Improve handling of INT_MIN / -1 and related cases.

Some platforms throw an exception for this division, rather than returning
a necessarily-overflowed result.  Since we were testing for overflow after
the fact, an exception isn't nice.  We can avoid the problem by treating
division by -1 as negation.

Add some regression tests so that we'll find out if any compilers try to
optimize away the overflow check conditions.

This ought to be back-patched, but I'm going to see what the buildfarm
reports about the regression tests first.

Per discussion with Xi Wang, though this is different from the patch he
submitted.
src/backend/utils/adt/int.c
src/backend/utils/adt/int8.c
src/test/regress/expected/int2.out
src/test/regress/expected/int4.out
src/test/regress/expected/int8-exp-three-digits.out
src/test/regress/expected/int8.out
src/test/regress/sql/int2.sql
src/test/regress/sql/int4.sql
src/test/regress/sql/int8.sql