]> granicus.if.org Git - postgresql/commit
Fix pg_upgrade for oid removal.
authorAndres Freund <andres@anarazel.de>
Mon, 26 Nov 2018 22:20:36 +0000 (14:20 -0800)
committerAndres Freund <andres@anarazel.de>
Mon, 26 Nov 2018 22:37:08 +0000 (14:37 -0800)
commit12a53c732cedf83f70106b5605a5003c2000d7f4
tree2eb0b80070c669cc20cb9ce1f4d6b0eb6e5e9a05
parent70d7e507ef9d380bd46345e984f069207de5e24e
Fix pg_upgrade for oid removal.

pg_upgrade previously copied pg_largeobject_metadata over from the old
cluster. That doesn't work, because the table has oids before
578b229718. I missed that.

As most pieces of metadata for large objects already were dumped as
DDL (except for comments overwritten by pg_upgrade, due to the copy of
pg_largeobject_metadata) it seems reasonable to just also dump grants
for large objects.  If we ever consider this a relevant performance
problem, we'd need to fix the rest of the already emitted DDL
too.

There's still an open discussion about whether we'll want to force a
specific ordering for the dumped objects, as currently
pg_largeobjects_metadata potentially has a different ordering
before/after pg_upgrade, which can make automated testing a bit
harder.

Reported-By: Andrew Dunstan
Author: Andres Freund
Discussion: https://postgr.es/m/91a8a980-41bc-412b-fba2-2ba71a141c2b@2ndQuadrant.com
src/bin/pg_dump/pg_dump.c
src/bin/pg_dump/t/002_pg_dump.pl
src/bin/pg_upgrade/info.c
src/bin/pg_upgrade/pg_upgrade.c