]> granicus.if.org Git - postgresql/commit
Fix order of arguments to SubTransSetParent().
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 23 Apr 2017 17:10:57 +0000 (13:10 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 23 Apr 2017 17:11:06 +0000 (13:11 -0400)
commit0874d4f3e183757ba15a4b3f3bf563e0393dd9c2
treec471030146e4c4633895a3e1fd93f2c64d45c8e2
parent33f3bbc6d37dde23f02cb1f73753791fb9e6c4a8
Fix order of arguments to SubTransSetParent().

ProcessTwoPhaseBuffer (formerly StandbyRecoverPreparedTransactions)
mixed up the parent and child XIDs when calling SubTransSetParent to
record the transactions' relationship in pg_subtrans.

Remarkably, analysis by Simon Riggs suggests that this doesn't lead to
visible problems (at least, not in non-Assert builds).  That might
explain why we'd not noticed it before.  Nonetheless, it's surely wrong.

This code was born broken, so back-patch to all supported branches.

Discussion: https://postgr.es/m/20110.1492905318@sss.pgh.pa.us
src/backend/access/transam/twophase.c