]> granicus.if.org Git - postgresql/commit
Change floating-point output format for improved performance.
authorAndrew Gierth <rhodiumtoad@postgresql.org>
Wed, 13 Feb 2019 15:20:33 +0000 (15:20 +0000)
committerAndrew Gierth <rhodiumtoad@postgresql.org>
Wed, 13 Feb 2019 15:20:33 +0000 (15:20 +0000)
commit02ddd499322ab6f2f0d58692955dc9633c2150fc
tree5ffd77a8fc083c1e64c7b84dc5249bef61c7fc4b
parentf397e08599a3c3c08b3af3b318c531db5882f57d
Change floating-point output format for improved performance.

Previously, floating-point output was done by rounding to a specific
decimal precision; by default, to 6 or 15 decimal digits (losing
information) or as requested using extra_float_digits. Drivers that
wanted exact float values, and applications like pg_dump that must
preserve values exactly, set extra_float_digits=3 (or sometimes 2 for
historical reasons, though this isn't enough for float4).

Unfortunately, decimal rounded output is slow enough to become a
noticable bottleneck when dealing with large result sets or COPY of
large tables when many floating-point values are involved.

Floating-point output can be done much faster when the output is not
rounded to a specific decimal length, but rather is chosen as the
shortest decimal representation that is closer to the original float
value than to any other value representable in the same precision. The
recently published Ryu algorithm by Ulf Adams is both relatively
simple and remarkably fast.

Accordingly, change float4out/float8out to output shortest decimal
representations if extra_float_digits is greater than 0, and make that
the new default. Applications that need rounded output can set
extra_float_digits back to 0 or below, and take the resulting
performance hit.

We make one concession to portability for systems with buggy
floating-point input: we do not output decimal values that fall
exactly halfway between adjacent representable binary values (which
would rely on the reader doing round-to-nearest-even correctly). This
is known to be a problem at least for VS2013 on Windows.

Our version of the Ryu code originates from
https://github.com/ulfjack/ryu/ at commit c9c3fb1979, but with the
following (significant) modifications:

 - Output format is changed to use fixed-point notation for small
   exponents, as printf would, and also to use lowercase 'e', a
   minimum of 2 exponent digits, and a mandatory sign on the exponent,
   to keep the formatting as close as possible to previous output.

 - The output of exact midpoint values is disabled as noted above.

 - The integer fast-path code is changed somewhat (since we have
   fixed-point output and the upstream did not).

 - Our project style has been largely applied to the code with the
   exception of C99 declaration-after-statement, which has been
   retained as an exception to our present policy.

 - Most of upstream's debugging and conditionals are removed, and we
   use our own configure tests to determine things like uint128
   availability.

Changing the float output format obviously affects a number of
regression tests. This patch uses an explicit setting of
extra_float_digits=0 for test output that is not expected to be
exactly reproducible (e.g. due to numerical instability or differing
algorithms for transcendental functions).

Conversions from floats to numeric are unchanged by this patch. These
may appear in index expressions and it is not yet clear whether any
change should be made, so that can be left for another day.

This patch assumes that the only supported floating point format is
now IEEE format, and the documentation is updated to reflect that.

Code by me, adapting the work of Ulf Adams and other contributors.

References:
https://dl.acm.org/citation.cfm?id=3192369

Reviewed-by: Tom Lane, Andres Freund, Donald Dong
Discussion: https://postgr.es/m/87r2el1bx6.fsf@news-spur.riddles.org.uk
50 files changed:
configure
configure.in
contrib/btree_gist/expected/float4.out
contrib/btree_gist/expected/float8.out
contrib/cube/expected/cube.out
contrib/cube/expected/cube_sci.out
contrib/cube/sql/cube.sql
contrib/pg_trgm/expected/pg_strict_word_trgm.out
contrib/pg_trgm/expected/pg_trgm.out
contrib/pg_trgm/expected/pg_word_trgm.out
contrib/pg_trgm/sql/pg_strict_word_trgm.sql
contrib/pg_trgm/sql/pg_trgm.sql
contrib/pg_trgm/sql/pg_word_trgm.sql
contrib/seg/expected/seg.out
doc/src/sgml/config.sgml
doc/src/sgml/datatype.sgml
src/Makefile.global.in
src/backend/utils/adt/float.c
src/backend/utils/misc/guc.c
src/backend/utils/misc/postgresql.conf.sample
src/common/Makefile
src/common/d2s.c [new file with mode: 0644]
src/common/d2s_full_table.h [new file with mode: 0644]
src/common/d2s_intrinsics.h [new file with mode: 0644]
src/common/digit_table.h [new file with mode: 0644]
src/common/f2s.c [new file with mode: 0644]
src/common/ryu_common.h [new file with mode: 0644]
src/include/common/shortest_dec.h [new file with mode: 0644]
src/test/regress/expected/aggregates.out
src/test/regress/expected/circle.out
src/test/regress/expected/float4-misrounded-input.out
src/test/regress/expected/float4.out
src/test/regress/expected/float8-small-is-zero.out
src/test/regress/expected/float8.out
src/test/regress/expected/int8.out
src/test/regress/expected/jsonb.out
src/test/regress/expected/line.out
src/test/regress/expected/point.out
src/test/regress/expected/rules.out
src/test/regress/expected/tsearch.out
src/test/regress/expected/tstypes.out
src/test/regress/expected/updatable_views.out
src/test/regress/expected/window.out
src/test/regress/sql/aggregates.sql
src/test/regress/sql/circle.sql
src/test/regress/sql/float4.sql
src/test/regress/sql/float8.sql
src/test/regress/sql/point.sql
src/test/regress/sql/updatable_views.sql
src/tools/msvc/Mkvcbuild.pm