]> granicus.if.org Git - postgresql/commit
Improve division of labor between execParallel.c and nodeGather[Merge].c.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 1 Sep 2017 21:38:54 +0000 (17:38 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 1 Sep 2017 21:38:54 +0000 (17:38 -0400)
commit01edb5c7fc3bcf6aea15f2b3be36189b52ad9d1a
treeecdc6beba03ff3b1e032bdbcf16c63eff081c544
parentf2fe1cbef11c5fc962e338c8523667314faa6d89
Improve division of labor between execParallel.c and nodeGather[Merge].c.

Move the responsibility for creating/destroying TupleQueueReaders into
execParallel.c, to avoid duplicative coding in nodeGather.c and
nodeGatherMerge.c.  Also, instead of having DestroyTupleQueueReader do
shm_mq_detach, do it in the caller (which is now only ExecParallelFinish).
This means execParallel.c does both the attaching and detaching of the
tuple-queue-reader shm_mqs, which seems less weird than the previous
arrangement.

These changes also eliminate a vestigial memory leak (of the pei->tqueue
array).  It's now demonstrable that rescans of Gather or GatherMerge don't
leak memory.

Discussion: https://postgr.es/m/8670.1504192177@sss.pgh.pa.us
src/backend/executor/execParallel.c
src/backend/executor/nodeGather.c
src/backend/executor/nodeGatherMerge.c
src/backend/executor/tqueue.c
src/include/executor/execParallel.h