]> granicus.if.org Git - postgresql/commit
Avoid the use of a separate spinlock to protect a LWLock's wait queue.
authorAndres Freund <andres@anarazel.de>
Mon, 11 Apr 2016 03:12:32 +0000 (20:12 -0700)
committerAndres Freund <andres@anarazel.de>
Mon, 11 Apr 2016 03:12:32 +0000 (20:12 -0700)
commit008608b9d51061b1f598c197477b3dc7be9c4a64
treea2284092fb36b8e7fd9d8f412fc6da4ee4c8fad2
parent48354581a49c30f5757c203415aa8412d85b0f70
Avoid the use of a separate spinlock to protect a LWLock's wait queue.

Previously we used a spinlock, in adition to the atomically manipulated
->state field, to protect the wait queue. But it's pretty simple to
instead perform the locking using a flag in state.

Due to 6150a1b0 BufferDescs, on platforms (like PPC) with > 1 byte
spinlocks, increased their size above 64byte. As 64 bytes are the size
we pad allocated BufferDescs to, this can increase false sharing;
causing performance problems in turn. Together with the previous commit
this reduces the size to <= 64 bytes on all common platforms.

Author: Andres Freund
Discussion: CAA4eK1+ZeB8PMwwktf+3bRS0Pt4Ux6Rs6Aom0uip8c6shJWmyg@mail.gmail.com
    20160327121858.zrmrjegmji2ymnvr@alap3.anarazel.de
src/backend/storage/lmgr/lwlock.c
src/include/storage/lwlock.h