add the tag writer to the built examples

And remove dead code.

CI: split general/libmatroska configure arguments

CI: simplify workflow names

CI: only build desktop builds with XP targets

If it can do XP (that we need for VLC 3), it can do Win10 that we also test in
UWP builds.

CI: add separate UWP target

It requires less targets

CI: build macos on multiple architectures

So we may spot differences/warnings/issues on both platforms.

CI: build Windows on multiple architectures

So we have a platform building on 32 bits and on arm.

CI: don't build C++ with any compiler extension

Use -std=c++14 instead of -std=gnu++14 so we can tell when using improper C++.

CI: use an extended map for the Static/Dynamic matrix option

test8: initialize all element levels

Fixes a warning/error with VS2022

KaxSemantic: update with latest spectool (using clean enum text)

Merge remote-tracking branch 'origin/safe-access'

Merge remote-tracking branch 'origin/test-build-examples'

Merge remote-tracking branch 'neheb/clang'

Merge remote-tracking branch 'neheb/clng'

CI: build test examples

This will help find linking issues and incompatible changes.

add an option to build example code

Off by default.

apply _CRT_SECURE_NO_WARNINGS on all Windows targets

That includes clang-cl. It will have no downside effect on mingw64 builds.

fix test00 compilation

fix test8 compilation

use GetEndPosition() to seek to the end of a Virtual element

avoid using protected member variables

If libebml is compiled in strict mode, these fields can't be accessed, but we
can still access them with the proper methods.

use push_back

This is a vector. No need for iterators.

Signed-off-by: Rosen Penev <rosenp@gmail.com>

remove const reference operators

They do the same as the non const ones.

Signed-off-by: Rosen Penev <rosenp@gmail.com>

clang-tidy: remove non const operator

Found with readability-make-member-function-const

Signed-off-by: Rosen Penev <rosenp@gmail.com>

find_if conversion

Signed-off-by: Rosen Penev <rosenp@gmail.com>

Merge remote-tracking branch 'origin/int-literal'

Merge remote-tracking branch 'origin/svn-tag'

replace EBML_PRETTYLONGINT with proper C++ integer literal

The suffix l/L and ll/LL can/should be used:
https://en.cppreference.com/w/cpp/language/integer_literal

This is equivalent to the previous code with gcc/clang. Theoretically it should
be used to write in a long( long) and for uint64_t values we should use
UINT64_C().

remove empty matroska/c headers

We're not going to make a C wrapper for libmatroska.

remove code marked as OLD

It's never compiled by anyone.

move libmatroska_t.h type definitions in KaxTypes.h

use std::size_t instead of size_t

They are supposed to be the same but it's more C++ friendly.

use standard C++ integer types instead of old libebml ones

remove confusing SVN version tag

The version text doesn't match the code anymore.

don't use local include pathes to find libebml headers

use EbmlTypes.h instead of libebml_t.h

require libEBML 2.0.0 or newer

libEBML currently installs the cmake module config with "COMPATIBILITY
SameMajorVersion", meaning we cannot request "version 1.4.3 or 2.0.0
or newer" in libMatroska. As libEBML 2.0.0 is an API-breaking change
anyway, it libMatroska should not pretend to continue working with <
2.0.0 anyway.

CI: use better names for static/dynamic jobs

Action: build static and dynamic libraries on Windows

allow selecting the DLL vs static library build more

This is often done in CMake projects to show the option to the user.

fix mistaken reference

The static cast clarifies this is a pointer.

Signed-off-by: Rosen Penev <rosenp@gmail.com>

replace auto&& with const ref

auto&& is universal in that it evaluates to const and non const
references. Probably clearer to use regular ones.

Signed-off-by: Rosen Penev <rosenp@gmail.com>

nullptr + const changes

Remove nullptr comparison. Just use bool.

Signed-off-by: Rosen Penev <rosenp@gmail.com>

simplify return

Signed-off-by: Rosen Penev <rosenp@gmail.com>

clang-tidy: don't use else after return

Less indentation.

Signed-off-by: Rosen Penev <rosenp@gmail.com>

manually convert some loops to range ones

further simplify

Signed-off-by: Rosen Penev <rosenp@gmail.com>

manual find_if conversion

Signed-off-by: Rosen Penev <rosenp@gmail.com>

SonarLint: misc fixes

auto fixes were mostly to supress const pointer warnings

Some for range loop conversions that it saw through.

Signed-off-by: Rosen Penev <rosenp@gmail.com>

clang-tidy: avoid some implicit conversions

Found by adding explicit for various operators

Signed-off-by: Rosen Penev <rosenp@gmail.com>

bump soname to 8 due to ABI-breaking changes & bump version number

libEBML needed an soname bump due to being compiled in C++14,
therefore libMatroska cannot stay on the same soname either. See
https://github.com/Matroska-Org/libebml/issues/104

NEWS: add version number & release date

remove unnecessary references

Pointers are already used.

Signed-off-by: Rosen Penev <rosenp@gmail.com>

clang-tidy: do the same for pointers

Signed-off-by: Rosen Penev <rosenp@gmail.com>

clang-tidy: add const

Found with misc-const-correctness

Also manually simplified several any_of/find_if calls.

Also added manual auto with static_cast

Signed-off-by: Rosen Penev <rosenp@gmail.com>

clang-tidy: remove redundant init

Found with modernize-use-default-member-init

Signed-off-by: Rosen Penev <rosenp@gmail.com>

clang-tidy: remove redundant dereferences

Found with readability-redundant-function-ptr-dereference

Signed-off-by: Rosen Penev <rosenp@gmail.com>

CI: add a basic compilation test

It needs to build libebml first.

Revert "KaxSemantic: update with latest spectool (using C++-style enums)"

This reverts commit 829c6d7ea24213d5320a1cc87f4660cf8f43d602.

KaxSemantic: update with latest spectool (using C++-style enums)

bump version number to v1.7.0

Even though the number had already been bumped to 1.6.4 after the last
release, all the changes in this release might need adjustments in the
applications using them for writing files, even though the libraries
should still be API and ABI backwards compatible.

update NEWS

bump libEBML version requirement to v1.4.3

cosmetics: restore alignment/indentation

Merge remote-tracking branch 'neheb/2'

style: use override specifier in auto-generated code

KaxSemantic: fix invalid element ID for KaxEmphasis

See https://github.com/ietf-wg-cellar/matroska-specification/pull/673

KaxSemantic: re-enable KaxClusterPosition

Existing tools use that element.

See https://github.com/ietf-wg-cellar/matroska-specification/pull/670

KaxSemantic: add KaxEditionDisplay elements

Added in https://github.com/ietf-wg-cellar/matroska-specification/pull/606

KaxSemantic: add KaxChapterSkipType chapter element

Added in https://github.com/ietf-wg-cellar/matroska-specification/pull/318

KaxSemantic: add KaxEmphasis audio element

Add in https://github.com/ietf-wg-cellar/matroska-specification/pull/659

Merge branch 'c++14'

KaxSemantic.cpp: make KaxChapters allowed multiple times

It should be unique but it's a 'recurring' elements which might be copied
multiple times in the same parent.

See https://github.com/ietf-wg-cellar/matroska-specification/pull/438

KaxSemantic: reorder elements to match the code generation and EBML Schema

Affected elements:
* KaxChapterTranslateID
* KaxChapterTranslateEditionUID
* KaxChapterTranslateCodec

* KaxBlockAdditional
* KaxBlockAddID

* KaxTrackTranslateTrackID
* KaxTrackTranslateEditionUID
* KaxTrackTranslateCodec

KaxSemantic: mark OldStereoMode as supported

It exists in Matroska v1 and v2 but we don't allow writing it as it's deprecated.

KaxSemantic: add TagDefaultBogus

The infamous libavformat TagDefault bogus value.

See https://github.com/ietf-wg-cellar/matroska-specification/commit/31ce1cb593ed044d3e57b5a7258bef8c988be352

KaxSemantic.cpp: remove the default value of some new TrackEntry elements

See https://github.com/ietf-wg-cellar/matroska-specification/commit/4dbdf03f04798584085b34236a750681c7d4a1a5

KaxSemantic.cpp: remove the KaxCueBlockNumber default value

See https://github.com/ietf-wg-cellar/matroska-specification/commit/e5b6f222d5480d3bf4546222b38cce0c77cdf58a

KaxSemantic.cpp: make KaxVideoDisplayUnit elements mandatory

See https://github.com/ietf-wg-cellar/matroska-specification/commit/22d23716f2ba61234449d5c5de509ecc14b37f76

KaxSemantic.cpp: make Video\Colour elements mandatory

See https://github.com/ietf-wg-cellar/matroska-specification/commit/37b176e9fd11a201fcaa0223348adea78f2115d2

KaxSemantic.cpp: make Video\Colour elements mandatory

See https://github.com/ietf-wg-cellar/matroska-specification/commit/3609e0d1ec5449d2c5b46d80363abd27d8943dbc

KaxSemantic.cpp: make KaxEditionFlagOrdered mandatory

See https://github.com/ietf-wg-cellar/matroska-specification/commit/3082e56020bfd220efc26100180a449aa55bc2f8

KaxSemantic.cpp: make KaxVideoAlphaMode mandatory

See https://github.com/ietf-wg-cellar/matroska-specification/commit/5aa6c928caac5300b0ab1a65522e9be31710b2b0

KaxSemantic.cpp: make StereoMode mandatory

See https://github.com/ietf-wg-cellar/matroska-specification/commit/a096476f40ffa77ba26ce44fa259f04998bcd2fc

KaxSemantic.cpp: make TrackLanguage elements mandatory

See https://github.com/ietf-wg-cellar/matroska-specification/commit/c98127cb523138c81be35c348f4dee70c3aa4c9e

KaxSemantic.cpp: make some elements mandatory

* CodecDelay: nothing to add/remove to track timestamps
* PixelCropXXX: no cropping by default
* CueCodecState
* Tag\Targets\TargetTypeValue: **tag is not usable without this value**

See https://github.com/ietf-wg-cellar/matroska-specification/commit/f81cb9d339574ce2b00faa288cd466908e31b797

KaxSemantic: make more elements deprecated

* KaxClusterSilentTracks
* KaxClusterSilentTrackNumber
* KaxSlices
* KaxSliceLaceNumber
* KaxReferenceFrame
* KaxReferenceOffset
* KaxReferenceTimeCode
* KaxTrackTimecodeScale
* KaxCodecDecodeAll
* KaxVideoAspectRatio
* KaxTrickTrackUID
* KaxTrickTrackSegmentUID
* KaxTrickTrackFlag
* KaxTrickMasterTrackUID
* KaxTrickMasterTrackSegmentUID
* KaxContentSignature
* KaxContentSigKeyID
* KaxContentSigAlgo
* KaxContentSigHashAlgo
* KaxClusterPosition

KaxSemantic.h: add enum values from the specs with documentation

This provides some useful source for anyone parsing Matroska files.
The enum names are the same as in libmatroska2 (mkclean/mkvalidator).

The documentation doesn't look great but it still gives useful inline
information.

use the libebml namespace directly

There hasn't been a case where there's no namespace in a long time.

use the libmatroska namespace directly

No need to hide it behind a macro anymore. The macro is kept for existing
external code still using it.

remove unknown NO_NAMESPACE define

use emplace_back

Signed-off-by: Rosen Penev <rosenp@gmail.com>

clang-tidy: default member init

Signed-off-by: Rosen Penev <rosenp@gmail.com>

clang-tidy: C++ casts

Signed-off-by: Rosen Penev <rosenp@gmail.com>

clang-tidy: default init variables

Found with modernize-use-default-member-init

Signed-off-by: Rosen Penev <rosenp@gmail.com>

clang-tidy: use auto

Found with modernize-use-auto

Signed-off-by: Rosen Penev <rosenp@gmail.com>

clang-tidy: use default

Found with modernize-use-equals-default

Signed-off-by: Rosen Penev <rosenp@gmail.com>

clang-tidy: use nullptr

Signed-off-by: Rosen Penev <rosenp@gmail.com>

clang-tidy: add missing override

Signed-off-by: Rosen Penev <rosenp@gmail.com>