Steven R. Loomis [Mon, 22 Feb 2021 18:13:27 +0000 (12:13 -0600)]
ICU-20233 tool: improvements to commit checker for CLDR
- improve checks for CLDR resolutions
- update batch fetch from 50 to 100
- do not show no-commit tickets under illegal-state
- add navigation
- use numeric IDs for status, resolution, types with constants
(S_, R_, I_)
fix bugs from CLDR-14224
- do not show not-in-query issues as open
- cache single-issue queries
- give information on each problem as to what it is
- put 'review' in a separate section (not counted in Problems)
- more detailed fix info under each issue
- fix section headings, always show component, add nocopyright option
- sort open issues by componnent
- sort the 'review' list
ICU-20444:
- exclude (via git-cherry) any commits already cherry picked to the branch.
- used a workaround to https://github.com/gitpython-developers/GitPython/issues/846
that seemed to work well,
- warn about issues with excluded commits
CLDR-14524:
- Exclude "Obsolete" from requiring commits
gnrunge [Tue, 16 Mar 2021 23:32:07 +0000 (16:32 -0700)]
ICU-21520 Fixes typo in name of test data file; removes a regex that
evaluates to the empty string and the result files are missing the
perf test name as a result. E.g. '_Mar_16_155820.html' instead of
'unisetperf_Mar_16_155820.html'.
Not obvious why the regex was even created since it doesn't seem
necessary because the name of the caller doesn't require additional
parsing. The rpaticular code is from 2002, maybe changes in Perl
account for the issue(?)
Yoshito Umaoka [Mon, 15 Mar 2021 04:33:27 +0000 (00:33 -0400)]
ICU-21480 BRS69 ICU4J API signature file
- Supplied missing API comment to com.ibm.icu.nubmer.Precision#trailingZeroDisplay(TrailingZeroDisplay)
- Generated API signature file for ICU4J 69.1 and added to the repository
- Delete ICU4J 59 API signature file
- Deleted unused icu4j/eclipse-build/build.properties. The folder eclipse-build was deleted, but someone worked on ICU version seemed to add it back again. Delete it again.
gnrunge [Fri, 19 Feb 2021 22:00:18 +0000 (14:00 -0800)]
ICU-21323 Automates the uconfig variation BRS tasks. The test
subsequently sets each of the UCONFIG_NO_XXX flags to '1' (exceptions apply)
and runs the ICU4C unit tests and the header test. Afterwards all
UCONFIG_NO_XXX flags are set to '1' and unit tests and header test
are executed.
To allow concurrent execution and reduce total run time, the script provides
the option to execute only the unit tests or only the header test.
ICU-21323 Split the uconfig.h variation test into two to reduce
execution time. One test now tests the variations with unit tests, the
other tests with header test.
Execution time now ranges between 45 and 58 minutes.
Yoshito Umaoka [Mon, 8 Mar 2021 17:53:45 +0000 (12:53 -0500)]
ICU-21207 Remove unnecessary reflection call
The test code was written long time ago. Java 1.3 TimeZone did not have getDSTSavings() method. The test code compares DST saving of Lord_Howe between ICU and JDK, and calling getDSTSavings() through reflection for 1.3 compatibility. This is no longer necessary and replaced with regular method call.
Yoshito Umaoka [Mon, 8 Mar 2021 07:58:20 +0000 (02:58 -0500)]
ICU-21507 Removing unused class initializer code
ICUDebug seemed to check Java version whether it's 1.4 or higher. The code referencing the version is already gone. We also no longer support Java 1.3 runtime since long time ago. Remove the unused code checking Java version.
Andy Heninger [Sat, 14 Nov 2020 07:04:10 +0000 (23:04 -0800)]
ICU-21346 Update user guide section on initialization.
This change is narrowly focused on the initialization and cleanup / termination
of ICU. The whole user-guide section (file) needs to be reviewed for out-of-date
information, but not as part of this change.
gnrunge [Thu, 18 Feb 2021 00:29:19 +0000 (16:29 -0800)]
ICU-21487 Moves performance test data files from the icu-data repository
to the icu repository. Added Unicode copyright notice to those files
that only have the IBM copyright notice.
A complimentary PR will remove data from the icu-data repository.
ICU-21487 Adds pure test data files which have no copyright notice to the
exemption list.
Andy Heninger [Sat, 13 Feb 2021 21:28:10 +0000 (13:28 -0800)]
ICU-21492 Fix regex compile assertion failure.
A regex pattern containing nested look-behind blocks could trigger an assertion
failure during pattern compilation. The problem was caused by an off-by-one
error in the code that computes an upper bound on the match length, needed
because look-behind expressions are constrained to not have unbounded match
length.
Nested look-behind blocks come into play because, when computing the maximum
match length of an outer block, any inner look-behind blocks are skipped over -
they do not directly contribute to the length matched by the outer block. The
problem was in the code that skips over these nested look-behind blocks.
Markus Scherer [Wed, 17 Feb 2021 00:09:18 +0000 (16:09 -0800)]
ICU-13702 add missing API functions
and fix a bug in Java UnicodeSet.retain(String) which added the string even if the set did not contain it before,
and some drive-by API doc fixes/clarifications