Merge pull request #231 from nmeum/makeinfo

configure: check for makeinfo instead of tex for documentation

configure: check for makeinfo instead of tex for documentation

While upgrading the Alpine Linux check package to 0.13.0 I noticed that
documentation files were no longer installed, even though they were
installed successfully previously.

After investigating this for a while I noticed that this seems to be due
to an incorrect fix for #206. In #206 the issue reporter complains that
the build fails if texinfo is not installed, the fix in #212 checks for
tex instead of makeinfo though. makeinfo is the command used by the
implicit gnu make rule to generate info pages.

Merge pull request #225 from mikkoi/fix-c-standard-to-c99

Fix c standard to c99

Merge branch 'master' into fix-c-standard-to-c99

Merge pull request #230 from libcheck/post-0.13

Update after 0.13

Fix typo in NEWS

Restore development header in NEWS

Update index.html for 0.13.0 release

Merge pull request #224 from libcheck/pre-v0.13

Update NEWS for v0.13

Change C++ style comments to C style

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add missing include for waitpid()

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Fix required C standard from C90 to C99

We are using C99 features, such as anonymous variadic macros and
mixed declarations and code.

Besides, we are using POSIX extensions (fork, etc.), so there is
(probably?) no point in forcing the use of the old ANSI C89 / ISO C90.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Merge branch 'master' into pre-v0.13

Update hash and date for 0.13.0 release in NEWS

Update NEWS with additional changes

Merge pull request #228 from mikkoi/fix-forced-build-type

Remove the forcing of the CMake build type

Merge branch 'master' into fix-forced-build-type

Merge pull request #227 from mikkoi/support-cmake-package-registry

Support CMake package registry

Merge branch 'master' into support-cmake-package-registry

Merge pull request #226 from mikkoi/fix-wrong-library-filename

Fix wrong library filename (in Windows)

Remove the forcing of the CMake build type

* Do not force the build type to be Debug.
* This actually didn't work because the variable was not declated CACHE.
* Append /cmake dir to CMAKE_MODULE_PATH instead of replacing the
  previous content.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Update NEWS

Add header check_stdint.h to public headers

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add support for CMake User Package Registry

The registries are especially useful to help projects find packages
in non-standard install locations or directly in their own build trees.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Correct wrong Win dynamic library name

Change from checkStatic to checkDynamic.
Was erroneously "checkStatic".

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add comments about library creation

Why we create both static and shared type of library?

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Merge pull request #221 from mikkoi/more-todo

Add more items to TODO

Merge branch 'master' into more-todo

Merge pull request #220 from mikkoi/so-for-visual-studio

Shared Library for Visual Studio

Add more items to TODO

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Remove unneeded include()

Already included in the project root CMakeLists.txt

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add option ENABLE_MEMORY_LEAKING_TESTS

Removing the set(MEMORY_LEAKING_TESTS_ENABLED) which
had no effect on the build.

The new CMake build option uses verb-first structure
(do something on something: e.g. ENABLE/BUILD) like other build
options. The definition itself is "MEMORY_LEAKING_TESTS_ENABLED"
and only enabled in the tests/ subdirectory.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Correct indentation

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Truncate PROJECT_VERSION to three components

For compatibility with the Autotools build which only
uses three parts: major, minor and patch.

CMake allows four components in version numbering:
major, minor, patch and tweak.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add variable VERSION to pkgconfig/check.pc configuration

File check.pc.in is shared with Autotools and CMake build.

File uses variable 'VERSION'.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Remove the needless resetting of PROJECT_VERSION

Variable PROJECT_VERSION was not yet in use when check_stdint.h configuration was updated.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add target shared library to CMake build

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add better explanation for '#define CK_DLL_EXP'

Remove MSVC specific dllexport

Target check is specifically a static library

Change definition CK_DLL_EXP from global to target specific

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add libcompat code directly to libcheck

We have tried to statically link the built libcompat into built libcheck
in CMake without success. With autotools (libtool et.al.) this is
most likely very easy but there is no support on Windows.
So instead of building libcompat separately
we incorporate the necessary parts of libcompat code
directly into libcheck when building libcheck.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Start using GNUInstallDirs in every CMake install()

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Merge pull request #209 from mikkoi/fix-small-issues-2

Fix small issues 2

Merge branch 'master' into fix-small-issues-2

Improve check_stdint.h creation in CMake

Will not convert m4/ax_create_stdint_h.m4 to CMake.
Make the resulting check_stdint.h similar to the old one
(as much as is possible).

GNU Autotools build is untouched. It continues to use m4 macro
and generates check_stdint.h from scratch.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Merge pull request #212 from mikkoi/is-makeinfo-required

configure: optional build documentation

Add param @ONLY to CMake configure_file()

Restrict variable replacement to references of the form @VAR@.
This is useful for configuring scripts that also use ${VAR} syntax.
Adding @ONLY is precautionary action to prevent future bugs.

Attn. cmake/config.h.in contains ${VAR} in #cmakedefine clauses!

How to use CMake variable substitution.

Wrong:

    #if @HAVE_FORK@
        [..]
    #endif

Because this will result as:

    #if 1
        [..]
    #endif

Better:

    /* Imported CMake variables created during build. */
    #cmakedefine HAVE_FORK 1

    #ifdef HAVE_FORK
        [..]
    #endif

Because this will result as:

    /* Imported CMake variables created during build. */
    #define HAVE_FORK 1

    #ifdef HAVE_FORK
        [..]
    #endif

Or:

    /* Imported CMake variables created during build. */
    /* #undef HAVE_FORK */
    [..]

This is more readable. Now we know which decision actually
was taken.

If you need to pass the parameter to the definition,
it is just as easy:

    /* Imported CMake variables created during build. */
    #cmakedefine CORRECT_SIZE @CORRECT_SIZE@

    #if CORRECT_SIZE >= 20
        [..]
    #endif

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Remove non-CMake style option CHECK_ENABLE_TESTS

It is a CMake best practice to include file 'CTest'
in the project main file and then use option
'BUILD_TESTING' (defined in 'CTest') to enable or disable
building the tests. BUILD_TESTING is ON by default.

https://cmake.org/cmake/help/v3.9/module/CTest.html?highlight=build_testing
https://cmake.org/cmake/help/v3.9/command/add_test.html?highlight=build_testing

Option CHECK_ENABLE_TESTS is deprecated.
Because it is on by default, deprecation warning is only shown
to user when user explicitly turns CHECK_ENABLE_TESTS off.

Suggesting to remove the option by release 0.15.0.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Fix missing macro undefinition

If we don't undefine the macro, it will enter the user's namespace.
This macro is only for our internal use.
Otherwise it would have the "CK_" prefix.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add pkgconfig/check.pc file generation to CMake

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Reindent CMake file to 2 chars indentation

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add missing header file when HAVE_FORK

Function _exit(int) is included in unistd.h. Also fork() is here.
Functions exit(int) (C89) and _Exit(int) (C99) are in stdlib.h.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add HAVE_UNISTD_H  to CMake and config.h.in

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add 'cmake --version' to Travis script

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Merge branch 'master' into is-makeinfo-required

Merge pull request #219 from mikkoi/fix-macro-definition

Fix missing macro undefinition

Add alarm.c to the build

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Remove support for old CMake version

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add command 'cmake --version' to appveyor builds

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Create variables PROJECT_VERSION_*

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add tags DESCRIPTION and LANGUAGES to project()

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Raise minimum CMake version to 3.9

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Fix missing macro undefinition

If we don't undefine the macro, it will enter the user's namespace.
This macro is only for our internal use.
Otherwise it would have the "CK_" prefix.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Merge branch 'master' into is-makeinfo-required

Merge pull request #218 from mikkoi/improve-gcc-version-at-least

Improve macro GCC_VERSION_AT_LEAST(major, minor)

Merge branch 'master' into improve-gcc-version-at-least

Merge pull request #213 from mikkoi/fix-small-issues-3

Fix some issues that came up with Travis updating to Clang 7

Improve macro GCC_VERSION_AT_LEAST(major, minor)

Use also the patch number. Arguments: major, minor, pathch.

Issue #214 https://github.com/libcheck/check/issues/214

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add issue #206 to NEWS

https://github.com/libcheck/check/issues/206

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

configure: optional build documentation, travis

Tweak Travis build to support the new `./configure` switch.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

configure: optional build documentation, output

Add more output when running `./configure`.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

configure: optional build documentation

Fix issue https://github.com/libcheck/check/issues/206

Applied an uncommitted patch by Branden Archer.
https://sourceforge.net/p/check/bugs/101/

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Fix indentation

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Remove useless if clause.

warning: comparison of constant -1 with expression of type
'clockid_t' is always false [-Wtautological-constant-out-of-range-compare]

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add more info to AUTHORS

Initialize buffer to ensure it is empty

snprintf.c:918:31: warning: The left operand of '!=' is a garbage value
        for (strln = 0; value[strln] != '\0' &&
                        ~~~~~~~~~~~~ ^

Move "#include <string.h>" from testing related code to main code
because memset(3) depends on <string.h>.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Fix declaration of extern int errno

if HAVE_VSNPRINTF is declared, <errno.h> is not included.
So we need to declare it ourselves.

Error (Travis SCAN_BUILD=YES):
libtool: compile:  /usr/local/clang-7.0.0/bin/../libexec/ccc-analyzer -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wextra -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wno-variadic-macros -Wimport -Wfatal-errors -Wformat=2 -Winit-self -Wmissing-include-dirs -Wswitch-default -Wunknown-pragmas -MT snprintf.lo -MD -MP -MF .deps/snprintf.Tpo -c snprintf.c  -fPIC -DPIC -o .libs/snprintf.o
764snprintf.c:487:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
extern int errno;
^

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@inoviagroup.se>

Fix indentation

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Fix warnings by flag -Wswitch-default

E.g.
check_print.c:114:13: warning: switch missing default case [-Wswitch-default]
             switch (next)
             ^

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Merge pull request #204 from mikkoi/add-checkmk-to-cmake

Add checkmk to cmake

Make checkmk installable

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add issue #196 to NEWS

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Add Mikko Koivunalho to AUTHORS (contributor)

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Increase version to 0.13.0

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Merge pull request #198 from mikkoi/fix-cmake-project-name

Fix bug with CMake project variable

Fix bug with CMake project variable

"
I tried to embed the check source code into my project in a "3rdparty" folder. Turns out that the build fails because of the usage of CMAKE_PROJECT_NAME instead of PROJECT_NAME in the check CMakeLists.txt

CMAKE_PROJECT_NAME is the name of the topmost project, that is in my case my own project.
Changing to PROJECT_NAME worked fine.
"

https://github.com/libcheck/check/issues/194

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Merge pull request #189 from mikkoi/improve-test_mem_leaks

Fix script to work from any path and to take argument

Merge branch 'master' into improve-test_mem_leaks

Merge pull request #193 from mikkoi/fix-todo-indentation

Realign TODO indentations

Fix script to work from any path and to take argument

Signed-off-by: Mikko Koivunalho <mikko.koivunalho@iki.fi>

Merge branch 'master' into fix-todo-indentation

Merge pull request #191 from mikkoi/fix-signed-comparison

Change type from signed int to size_t

Merge branch 'master' into fix-signed-comparison

Merge pull request #190 from mikkoi/fix-abbreviations

Eliminate abbreviations like nf for number_failed

Merge branch 'master' into fix-abbreviations

Merge pull request #192 from mikkoi/fix-function-definition

Fix int main() function to "int main(void)"

Merge branch 'master' into fix-function-definition

Merge pull request #185 from mikkoi/improve-import

Improve import to CMake projects

Realign TODO indentations

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>

Fix int main() function to "int main(void)"

check_mem_leaks.c:35:5: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 int main ()
     ^~~~