]> granicus.if.org Git - libvpx/log
libvpx
4 years agosupport visual studio 2019 (vs16)
Johann [Tue, 29 Oct 2019 17:19:43 +0000 (13:19 -0400)]
support visual studio 2019 (vs16)

Fixed: 1633
Change-Id: I7dd2b4873aeb548c7f9ebf7025baf15a8e65c68f

4 years agoremove old visual studio remnants
Johann [Tue, 29 Oct 2019 17:08:06 +0000 (13:08 -0400)]
remove old visual studio remnants

The oldest supported Visual Studio version has been vs14
since 539dc7649f67ec10097b3c8eb2c0073f0d0571ce.

Clean up scripts and remove dead code.

Change-Id: I6db5b053a55d7656275d3d48e35d672c8ce22067

4 years agoAdd get_arf_layers()
angiebird [Thu, 24 Oct 2019 00:21:52 +0000 (17:21 -0700)]
Add get_arf_layers()

Change-Id: Ibde94f52235a37e122e6a548d71cb230e7b28368

4 years agoUse RANGE in get_gop_coding_frame_num
angiebird [Wed, 23 Oct 2019 23:49:55 +0000 (16:49 -0700)]
Use RANGE in get_gop_coding_frame_num

Change-Id: Iae804fccd7cca180eef9e6664de70f0930ee2e94

4 years agoAdd get_gf_interval_active_range()
angiebird [Wed, 23 Oct 2019 23:36:08 +0000 (16:36 -0700)]
Add get_gf_interval_active_range()

Change-Id: I94f3b93a932f351b6c9743932238d7ede2938462

4 years agoMerge "remove clang flag for integer sanitizer testing"
Hien Ho [Fri, 25 Oct 2019 16:24:23 +0000 (16:24 +0000)]
Merge "remove clang flag for integer sanitizer testing"

4 years agoMerge changes I309357fd,I0d170956,I5c7fc771,I6ebb023a,I1f6ef8c6, ...
Angie Chiang [Thu, 24 Oct 2019 20:25:05 +0000 (20:25 +0000)]
Merge changes I309357fd,I0d170956,I5c7fc771,I6ebb023a,I1f6ef8c6, ...

* changes:
  Make gop size independent from kf_zeromotion_pct
  Add get_frames_to_next_key()
  Rename i by frames_to_key in find_next_key_frame
  Remove input_stats when decide frames_to_key
  Remove twopass param from test_candidate_kf
  Pass first_pass_info/show_idx to test_candidate_kf
  Refactor test_candidate_kf()
  Decide the key frame directly when auto_key is off
  Remove detect_transition_to_still()
  Change the interface of find_next_key_frame

4 years agoremove clang flag for integer sanitizer testing
Hien Ho [Thu, 24 Oct 2019 18:00:18 +0000 (11:00 -0700)]
remove clang flag for integer sanitizer testing

BUG=webm:1615

Change-Id: Idfc86722e744d0c71ad47e284afb9cf9b8474473

4 years agoMerge "vpx_dsp/x86/avg_intrin_sse2: fix int sanitizer warnings"
Hien Ho [Thu, 24 Oct 2019 16:39:52 +0000 (16:39 +0000)]
Merge "vpx_dsp/x86/avg_intrin_sse2: fix int sanitizer warnings"

4 years agoMerge "vpx_int_pro_col_sse2: use unaligned loads"
James Zern [Thu, 24 Oct 2019 06:36:38 +0000 (06:36 +0000)]
Merge "vpx_int_pro_col_sse2: use unaligned loads"

4 years agovpx_dsp/x86/avg_intrin_sse2: fix int sanitizer warnings
Hien Ho [Tue, 1 Oct 2019 22:38:25 +0000 (15:38 -0700)]
vpx_dsp/x86/avg_intrin_sse2: fix int sanitizer warnings

Unit Test: VP9/AqSegmentTest. VP9/CpuSpeedTest, AVX2/Loop8Test6Param

implicit conversion from type 'int' of value 59741 (32-bit, signed) to
type 'int16_t' (aka 'short') changed the value to -5795 (16-bit, signed)

BUG=webm:1615

Change-Id: I2e5b688a97c3caa29d4b8a817b95a4986b81a562

4 years agoMerge "simplify darwin autodetection"
Johann Koenig [Wed, 23 Oct 2019 20:22:11 +0000 (20:22 +0000)]
Merge "simplify darwin autodetection"

4 years agoMerge "add darwin18 target"
Johann Koenig [Wed, 23 Oct 2019 19:23:55 +0000 (19:23 +0000)]
Merge "add darwin18 target"

4 years agosimplify darwin autodetection
Johann [Wed, 23 Oct 2019 18:17:57 +0000 (14:17 -0400)]
simplify darwin autodetection

Use sed to extract tgt_os

Change-Id: I2f7cd290102a2b591c6ae6e40766918b55abff10

4 years agoadd darwin18 target
Johann [Wed, 23 Oct 2019 17:50:31 +0000 (13:50 -0400)]
add darwin18 target

Fix autodetection on MacOS 10.14. Without this it defaults
to generic-gnu

Change-Id: I19cd4a9f2fb106dff16ab5e38821a5f374add59c

4 years agouse a compile time constant for kDataAlignment
Johann [Wed, 23 Oct 2019 14:52:38 +0000 (10:52 -0400)]
use a compile time constant for kDataAlignment

const or constexpr should be sufficient for this use but older
versions of gcc fail to expand DECLARE_ALIGNED correctly. Work
around this by using an enum.

Fixed: webm:1660
Change-Id: Ifa4f7585417760f90f9fb28332152019de9f8169

4 years agovpx_int_pro_col_sse2: use unaligned loads
James Zern [Wed, 23 Oct 2019 02:56:31 +0000 (19:56 -0700)]
vpx_int_pro_col_sse2: use unaligned loads

this fixes a segfault when scaling is enabled; in some cases depending
on the ratio offsets may become odd.

vpx_int_pro_row_sse2 was updated previously, though the reason wasn't
listed:
54eda13f8 Apply fast motion search to golden reference frame

BUG=webm:1600

Change-Id: I8d5e105d876d8cf917919da301fce362adffab95

4 years agoMake gop size independent from kf_zeromotion_pct
angiebird [Tue, 22 Oct 2019 22:16:21 +0000 (15:16 -0700)]
Make gop size independent from kf_zeromotion_pct

Change-Id: I309357fd0e008d10b974c9d2603d0712e1aa0bcd

4 years agoAdd get_frames_to_next_key()
angiebird [Tue, 22 Oct 2019 02:13:51 +0000 (19:13 -0700)]
Add get_frames_to_next_key()

Change-Id: I0d1709562bf96648fbaf2a0dce2dc23b9d2b81f1

4 years agoRename i by frames_to_key in find_next_key_frame
angiebird [Tue, 22 Oct 2019 01:49:21 +0000 (18:49 -0700)]
Rename i by frames_to_key in find_next_key_frame

Change-Id: I5c7fc771f0852d3b9e8b30be34097b13dfbc2513

4 years agoMerge "vpx_dsp/inv_txfm: fix int sanitizer warnings"
Hien Ho [Wed, 23 Oct 2019 00:22:43 +0000 (00:22 +0000)]
Merge "vpx_dsp/inv_txfm: fix int sanitizer warnings"

4 years agoRemove input_stats when decide frames_to_key
angiebird [Tue, 22 Oct 2019 01:32:57 +0000 (18:32 -0700)]
Remove input_stats when decide frames_to_key

Also remove the corresponding reset_fpf_position

Change-Id: I6ebb023a38627785ff19e161bfe7bbef797fc710

4 years agoMerge changes I00697e9a,I9dfc2ba3,I73619051,Ib4d37667
Angie Chiang [Tue, 22 Oct 2019 18:17:51 +0000 (18:17 +0000)]
Merge changes I00697e9a,I9dfc2ba3,I73619051,Ib4d37667

* changes:
  Refactor kf_group_err in find_next_key_frame
  Simplify the logics in find_next_key_frame
  Add get_gop_coding_frame_num()
  Localize zero_motion_accumulator

4 years agoRemove twopass param from test_candidate_kf
angiebird [Tue, 22 Oct 2019 01:18:16 +0000 (18:18 -0700)]
Remove twopass param from test_candidate_kf

Change-Id: I1f6ef8c6d453177e3b48c95434b66480ee19f91d

4 years agoPass first_pass_info/show_idx to test_candidate_kf
angiebird [Tue, 22 Oct 2019 01:04:49 +0000 (18:04 -0700)]
Pass first_pass_info/show_idx to test_candidate_kf

Change-Id: I5c18de464be9981236f95c62391258c4963e469b

4 years agoRefactor test_candidate_kf()
angiebird [Tue, 22 Oct 2019 00:56:54 +0000 (17:56 -0700)]
Refactor test_candidate_kf()

Replace detect_flash() by detect_flash_from_frame_stats()

Change-Id: Ia4eca1ca553fdb2f4f63ff6f683c79d92fc52556

4 years agoDecide the key frame directly when auto_key is off
angiebird [Tue, 22 Oct 2019 00:20:17 +0000 (17:20 -0700)]
Decide the key frame directly when auto_key is off

Change-Id: I41d107558a8b1d31ef3b263ecc0ec1e1d91c8f7e

4 years agoRemove detect_transition_to_still()
angiebird [Tue, 22 Oct 2019 00:09:11 +0000 (17:09 -0700)]
Remove detect_transition_to_still()

Change-Id: I877f55355fc85d67f46bb76e521a19d35d76df09

4 years agoChange the interface of find_next_key_frame
angiebird [Mon, 21 Oct 2019 23:51:27 +0000 (16:51 -0700)]
Change the interface of find_next_key_frame

Change-Id: I9c25cbac2953755efa9fd72f59149f26513d1977

4 years agoRefactor kf_group_err in find_next_key_frame
angiebird [Mon, 21 Oct 2019 23:07:28 +0000 (16:07 -0700)]
Refactor kf_group_err in find_next_key_frame

Move the computation out of the while loop.

Change-Id: I00697e9a16d5d597c63e5d9895e4ae00efc7a2df

4 years agoSimplify the logics in find_next_key_frame
angiebird [Mon, 21 Oct 2019 22:23:46 +0000 (15:23 -0700)]
Simplify the logics in find_next_key_frame

Since the while loop's condition already check
rc->frames_to_key < cpi->oxcf.key_freq,
it impossible to have "frames_to_key >= 2 * cpi->oxcf.key_freq"
and "frames_to_key > cpi->oxcf.key_freq".

Hence, these logics are removed.

Change-Id: I9dfc2ba36e1012718c857fc710036e2d30acd3b8

4 years agoAdd get_gop_coding_frame_num()
angiebird [Mon, 21 Oct 2019 18:44:36 +0000 (11:44 -0700)]
Add get_gop_coding_frame_num()

This function will decide number of coding frames and whether to
use altref

Change-Id: I736190512ea92ce5387600712bd0e250ad7cb44c

4 years agoMerge "Fix AVX-512 capability detection"
Johann Koenig [Mon, 21 Oct 2019 18:24:31 +0000 (18:24 +0000)]
Merge "Fix AVX-512 capability detection"

4 years agoMerge changes I2acc7d6b,I560dccfc,I3fb23f5c,Ifa24a501
Angie Chiang [Fri, 18 Oct 2019 19:19:06 +0000 (19:19 +0000)]
Merge changes I2acc7d6b,I560dccfc,I3fb23f5c,Ifa24a501

* changes:
  Rename num_show_frames by num_coding_frames
  Use compute_arf_boost() in define_gf_group()
  Localize av_err mean_mod_score in define_gf_group
  Move code of deciding gop size into brackets

4 years agoFix AVX-512 capability detection
Birk Magnussen [Wed, 16 Oct 2019 22:11:26 +0000 (00:11 +0200)]
Fix AVX-512 capability detection

When Checking for AVX Support, only the CPU's Capabilities and YMM
Register support by the OS were queried. In case of AVX-512, that is
insufficient, and ZMM Register support by the OS needs querying,
otherwise the OS will raise an Illegal Operation Exception if the CPU
is capable of AVX-512 but the OS is not.

Change-Id: I3444b19156d5743841de96cecbdaac19cc3f2b3f

4 years agoLocalize zero_motion_accumulator
angiebird [Wed, 16 Oct 2019 20:50:02 +0000 (13:50 -0700)]
Localize zero_motion_accumulator

Change-Id: Ib4d37667c217cb06e6941de7b3204ba71b880396

4 years agoRename num_show_frames by num_coding_frames
angiebird [Tue, 15 Oct 2019 22:00:29 +0000 (15:00 -0700)]
Rename num_show_frames by num_coding_frames

Change-Id: I2acc7d6bde2ec2fae4460869663db1e8f6c576fe

4 years agoUse compute_arf_boost() in define_gf_group()
angiebird [Tue, 15 Oct 2019 21:41:07 +0000 (14:41 -0700)]
Use compute_arf_boost() in define_gf_group()

Remove reset_fpf_position() because
compute_arf_boost does not count on twopass->stats_in

Change-Id: I560dccfcc4a2cbaa8e78a493a070a416465db4a9

4 years agoMerge changes I1d71908a,Id1b41c3b,I07722c81,I31cf7889
Angie Chiang [Wed, 16 Oct 2019 18:32:19 +0000 (18:32 +0000)]
Merge changes I1d71908a,Id1b41c3b,I07722c81,I31cf7889

* changes:
  Localize last_loop_decay_rate
  Make get_zero_mtion_factor avoid using cpi
  Add check_transition_to_still()
  Add compute_arf_boost()

4 years agoLocalize av_err mean_mod_score in define_gf_group
angiebird [Mon, 14 Oct 2019 22:05:03 +0000 (15:05 -0700)]
Localize av_err mean_mod_score in define_gf_group

Change-Id: I3fb23f5c8df1c3276b663a32556ca800b7ba2ade

4 years agoLocalize last_loop_decay_rate
angiebird [Mon, 14 Oct 2019 18:54:53 +0000 (11:54 -0700)]
Localize last_loop_decay_rate

Change-Id: I1d71908a79ff494c4fb32dab0dc881f7a70bd519

4 years agoMove code of deciding gop size into brackets
angiebird [Mon, 14 Oct 2019 19:34:55 +0000 (12:34 -0700)]
Move code of deciding gop size into brackets

Identify the internal params used for deciding gop size

Change-Id: Ifa24a501952e06e5779a4fd2050dd486083cfa4c

4 years agoMake get_zero_mtion_factor avoid using cpi
angiebird [Mon, 14 Oct 2019 18:51:36 +0000 (11:51 -0700)]
Make get_zero_mtion_factor avoid using cpi

Change-Id: Id1b41c3b77a7eae6c2934efbff2608094ee7b3c5

4 years agoAdd check_transition_to_still()
angiebird [Mon, 14 Oct 2019 18:32:18 +0000 (11:32 -0700)]
Add check_transition_to_still()

The behavior is the same as that of detect_transition_still,
only we void using cpi and twopass->stats_in

Change-Id: I07722c817d98d8e4991a0a883235a582db8b5c3c

4 years agoAdd compute_arf_boost()
angiebird [Mon, 14 Oct 2019 17:43:29 +0000 (10:43 -0700)]
Add compute_arf_boost()

It's behavior is the same as that of calc_arf_boost()
But, we avoid using cpi and twopass->stats_in

Change-Id: I31cf7889abf43effcca9004a9d55f4b424ce388a

4 years agoMerge "vp8/decoder/decodeframe: fix int sanitizer warnings"
Hien Ho [Mon, 14 Oct 2019 17:18:08 +0000 (17:18 +0000)]
Merge "vp8/decoder/decodeframe: fix int sanitizer warnings"

4 years agoCorrect the num_frams of fps_init_first_pass_info
angiebird [Sat, 12 Oct 2019 01:49:27 +0000 (18:49 -0700)]
Correct the num_frams of fps_init_first_pass_info

Note the last packet is cumulative first pass stats.
So the number of frames is packet number minus one

Change-Id: I5f617e7eeb63d17204beaaeb6422902ec076caeb

4 years agoSimplify the logics of computing gf_group_err etc
angiebird [Sat, 12 Oct 2019 00:05:15 +0000 (17:05 -0700)]
Simplify the logics of computing gf_group_err etc

Move the logics of computing
gf_group_err, gf_group_raw_error, gf_group_noise,
gf_group_skip_pct, gf_group_inactive_zone_rowsa,
gf_group_inter, gf_group_motion
into one for loop

The behavior stays the same.

Change-Id: Idbc338a88469bf7a2786c831880e8aba8ed4feb5

4 years agoAdd calc_norm_frame_score()
angiebird [Fri, 11 Oct 2019 23:43:47 +0000 (16:43 -0700)]
Add calc_norm_frame_score()

The behavior is the same as calculate_norm_frame_score(),
but we avoid use cpi.

Change-Id: I3400abcdd02e041eb3b1ebf402b40b97df00d6f4

4 years agoRemove mod_frame_err in define_gf_group
angiebird [Fri, 11 Oct 2019 23:25:33 +0000 (16:25 -0700)]
Remove mod_frame_err in define_gf_group

Change-Id: I3cefcc797e8756c9d3256321679784a356fc1946

4 years agoSimplify the if clause in define_gf_group
angiebird [Fri, 11 Oct 2019 23:11:23 +0000 (16:11 -0700)]
Simplify the if clause in define_gf_group

Change-Id: I70a06a4f48c5a215831d8b6e918eebc3041ef65a

4 years agoRefactor calc_frame_boost()
angiebird [Thu, 10 Oct 2019 00:59:56 +0000 (17:59 -0700)]
Refactor calc_frame_boost()

Replace detect_flash() by detect_flash_from_frame_stats()

Change-Id: I31862820926b5167ff70cebe2009c04aa745a019

4 years agoAdd first_pass_info in TWO_PASS
angiebird [Thu, 10 Oct 2019 00:47:49 +0000 (17:47 -0700)]
Add first_pass_info in TWO_PASS

This is part of the change aims at replacing
stats_in/stats_in_start/stats_in_end by first_pass_info.

Change-Id: Ibcd2a08e57cb749fe68996f33fe3a5e7f92b1758

4 years agoRefactor get_prediction_decay_rate()
angiebird [Wed, 9 Oct 2019 22:24:11 +0000 (15:24 -0700)]
Refactor get_prediction_decay_rate()

Replace cpi by frame_info
Rename next_frame by frame_stats

Change-Id: I909f01ce724aac13030931970fba8b7b3f4d0080

4 years agoReplace cpi by frame_info in get_sr_decay_rate()
angiebird [Wed, 9 Oct 2019 22:20:51 +0000 (15:20 -0700)]
Replace cpi by frame_info in get_sr_decay_rate()

Change-Id: I8ed925edb12345042cf3e446095b4ad4acfa11c4

4 years agoChange the interface of calc_frame_boost
angiebird [Wed, 9 Oct 2019 22:08:45 +0000 (15:08 -0700)]
Change the interface of calc_frame_boost

Replace cpi by frame_info and avg_frame_qindex

Change-Id: Ie63526ac9942acf75cc416fcaa0a169838b23322

4 years agoUse frame_info in calculate_active_area
angiebird [Wed, 9 Oct 2019 21:50:54 +0000 (14:50 -0700)]
Use frame_info in calculate_active_area

Change-Id: I16049bef4aee54c915dc5cf181111c5a334b5eaf

4 years agoAdd FRAME_INFO into VP9_COMP
angiebird [Wed, 9 Oct 2019 21:42:57 +0000 (14:42 -0700)]
Add FRAME_INFO into VP9_COMP

Change-Id: Ibc804f2420113010013c04dc005b02dfebdfda8a

4 years agoAdd detect_flash_from_frame_stats()
angiebird [Wed, 9 Oct 2019 01:02:27 +0000 (18:02 -0700)]
Add detect_flash_from_frame_stats()

Change-Id: I06a64b45045334cf9563d27e154a3b8095ad80a3

4 years agovp9: fix non bitexact when reuse_inter_pred is 0.
Jerome Jiang [Fri, 4 Oct 2019 18:46:24 +0000 (11:46 -0700)]
vp9: fix non bitexact when reuse_inter_pred is 0.

when the best filter selected is not EIGHTTAP_SMOOTH, and
reuse_inter_pred is 0, pred buffer was not pointing to the right place.

Change-Id: I5b519fedd2d892bf140879faa74b463a161e253b

4 years agovpx_dsp/inv_txfm: fix int sanitizer warnings
Hien Ho [Fri, 4 Oct 2019 20:01:32 +0000 (13:01 -0700)]
vpx_dsp/inv_txfm: fix int sanitizer warnings

with vp9-highbitdepth off.
Unit Test:  SSE2/Trans16x16DCT , VP9/LevelTest.TestTargetLevel20Large, VP9/CpuSpeedTest

implicit conversion from type 'int32_t' (aka 'int') of value -32851
(32-bit, signed) to type 'tran_low_t' (aka 'short') changed the value to
32685 (16-bit, signed)

BUG=webm:1615
BUG=webm:1647

Change-Id: I9ef064dc9ac734379628565ff6505b0876984123

4 years agoMerge "vp9/common/vp9_reconinter: fix int sanitizer warnings"
Hien Ho [Fri, 4 Oct 2019 15:53:02 +0000 (15:53 +0000)]
Merge "vp9/common/vp9_reconinter: fix int sanitizer warnings"

4 years agovp8/decoder/decodeframe: fix int sanitizer warnings
Hien Ho [Thu, 3 Oct 2019 19:15:14 +0000 (12:15 -0700)]
vp8/decoder/decodeframe: fix int sanitizer warnings

Unit test: VP8/InvalidFileTest
implicit conversion from type 'int' of value -45844 (32-bit, signed) to
type 'short' changed the value to 19692 (16-bit, signed)

 BUG=webm:1615
 BUG=webm:1644

Change-Id: Id5d470f706d68e24f7a1e689526c9ecd3a8e8db8

4 years agoMerge "vpx_dsp/quantize: fix int sanitizer warnings"
Hien Ho [Thu, 3 Oct 2019 23:34:20 +0000 (23:34 +0000)]
Merge "vpx_dsp/quantize: fix int sanitizer warnings"

4 years agovp9/common/vp9_reconinter: fix int sanitizer warnings
Hien Ho [Thu, 3 Oct 2019 18:56:27 +0000 (11:56 -0700)]
vp9/common/vp9_reconinter: fix int sanitizer warnings

Unit Test: VP9/InvalidFileTest
implicit conversion from type 'int' of value -65536 (32-bit, signed) to
type 'int16_t' (aka 'short') changed the value to 0 (16-bit, signed)

BUG=webm:1615
BUG=webm:1645

Change-Id: I4ce0c6abf8b5bf43ee43e958ad75d9fa28b23eee

4 years agovpx_dsp/quantize: fix int sanitizer warnings
Hien Ho [Tue, 1 Oct 2019 22:50:29 +0000 (15:50 -0700)]
vpx_dsp/quantize: fix int sanitizer warnings

From unit test: AVX/VP9QuantizeTest; SSSE3/VP9QuantizeTest ...
implicit conversion from type 'int' of value -139812 (32-bit, signed)
to type 'tran_low_t' (aka 'short') changed the value to -8740 (16-bit,
 signed)

BUG=webm:1615

Change-Id: I730946ac6c7a250dcbcfd8a2712c0f1150ddb4fd

4 years agovp9/decoder/vp9_detokenize: fix int sanitizer warnings
Hien Ho [Tue, 1 Oct 2019 23:36:56 +0000 (16:36 -0700)]
vp9/decoder/vp9_detokenize: fix int sanitizer warnings

From unit test: VP9MultiThreaded/InvalidFileTest
implicit conversion from type 'int' of value 83144 (32-bit, signed) to
type 'tran_low_t' (aka 'short') changed the value to 17608 (16-bit,
 signed)

 BUG=webm:1615
 BUG=webm:1648

Change-Id: I4170494c328596ace66432c8563c55f31745cf76

4 years agoMerge "namespace ARCH_* defines"
James Zern [Mon, 30 Sep 2019 21:53:34 +0000 (21:53 +0000)]
Merge "namespace ARCH_* defines"

4 years agonamespace ARCH_* defines
James Zern [Sat, 28 Sep 2019 20:12:49 +0000 (13:12 -0700)]
namespace ARCH_* defines

this prevents redefinition warnings if a toolchain sets one

BUG=b/117240165

Change-Id: Ib5d8c303cd05b4dbcc8d42c71ecfcba8f6d7b90c

4 years agoFix python3 format issue
Jerome Jiang [Sat, 28 Sep 2019 00:11:51 +0000 (17:11 -0700)]
Fix python3 format issue

Change-Id: If0fed04c8682baee82efbdf5b4f90bcc8e8ac102

4 years agoMerge "vp9-rtc: Fix to speed 4 for real-time mode"
Marco Paniconi [Tue, 24 Sep 2019 15:18:42 +0000 (15:18 +0000)]
Merge "vp9-rtc: Fix to speed 4 for real-time mode"

4 years agovp9-rtc: Fix to speed 4 for real-time mode
Marco Paniconi [Fri, 20 Sep 2019 22:36:38 +0000 (15:36 -0700)]
vp9-rtc: Fix to speed 4 for real-time mode

Fix some speed feature settings for speed 4
in real-time mode.

Use rd pickmode (i.e.,nonrd_pick_mode=0), but
use variance partitioning. Allow aq-mode=3 to
work at speed 4 and modify some other speed settings.
This makes it much faster than the current speed 4,
and still better quality than speed 5.

Change-Id: I94ec43ccac022030a75b5a528703be0c37f9a35c

4 years agoMerge "Remove USE_PQSORT and CHANGE_MV_SEARCH_ORDER"
Angie Chiang [Fri, 20 Sep 2019 22:52:11 +0000 (22:52 +0000)]
Merge "Remove USE_PQSORT and CHANGE_MV_SEARCH_ORDER"

4 years agoRemove USE_PQSORT and CHANGE_MV_SEARCH_ORDER
Angie Chiang [Thu, 19 Sep 2019 21:22:37 +0000 (14:22 -0700)]
Remove USE_PQSORT and CHANGE_MV_SEARCH_ORDER

Remove the feature_score related code to simplify the code.
The feature_score is incorporated in get_local_structure and will
be integrated in later.
The current non_greedy_mv performances are
lowres: -0.239% midres: -0.569% hdres: -0.365%

Change-Id: Ida28bb1baff6932f1c28b24d371a35a1546fa7e9

4 years agovp9-svc: Fix to forced key frame for spatial layers
Marco Paniconi [Fri, 20 Sep 2019 15:45:04 +0000 (08:45 -0700)]
vp9-svc: Fix to forced key frame for spatial layers

Condition to disallow key frames on spatial
enhancement layers should be based on the
first_spatial_layer_to_encode, which need not be
layer 0.

Change-Id: If6bc67568151c38c9c98290e5838a23b3ab18e8a

4 years agoMerge "Remove redundant comment"
Angie Chiang [Thu, 19 Sep 2019 17:47:07 +0000 (17:47 +0000)]
Merge "Remove redundant comment"

4 years agoRemove redundant comment
Angie Chiang [Wed, 18 Sep 2019 22:02:52 +0000 (15:02 -0700)]
Remove redundant comment

Change-Id: I2020d21701ec7a7b018c4063918232098124d033

4 years agoMerge "Move vp9_alloc_motion_field_info"
Angie Chiang [Wed, 18 Sep 2019 21:52:06 +0000 (21:52 +0000)]
Merge "Move vp9_alloc_motion_field_info"

4 years agoMove vp9_alloc_motion_field_info
Angie Chiang [Wed, 18 Sep 2019 01:11:01 +0000 (18:11 -0700)]
Move vp9_alloc_motion_field_info

Move vp9_alloc_motion_field_info out of init_tpl_buffer, so that
vp9_alloc_motion_field_info will be called even though there is
not alternate reference frame.

This fix the crash with shields_720p50 at bitrate 2000

Change-Id: If2877e8d0b8a834556be12d239b7b58ad1fc8c73

4 years agoFix msan on svc tests.
Jerome Jiang [Fri, 13 Sep 2019 22:20:42 +0000 (15:20 -0700)]
Fix msan on svc tests.

BUG=b/140939146

Change-Id: Ib3e714f01c58fc0452c7e1adfc8fd3f1d9f8e0a0

4 years agoMerge "vp9_quantize_sse2: quiet clang-7 integer sanitizer warning"
James Zern [Wed, 11 Sep 2019 18:19:07 +0000 (18:19 +0000)]
Merge "vp9_quantize_sse2: quiet clang-7 integer sanitizer warning"

4 years agovpx_clear_system_state after drop due to overshoot
Jerome Jiang [Tue, 10 Sep 2019 23:42:32 +0000 (16:42 -0700)]
vpx_clear_system_state after drop due to overshoot

BUG=999780

Change-Id: I096fdc22812eab22a38a33135c0cbe60a6e64add

4 years agovp9_quantize_sse2: quiet clang-7 integer sanitizer warning
James Zern [Tue, 10 Sep 2019 22:48:04 +0000 (15:48 -0700)]
vp9_quantize_sse2: quiet clang-7 integer sanitizer warning

nzflag is used as a boolean, it doesn't need to be a sized type, int is
enough (and _mm_movemask_epi8 returns one)

fixes:
vp9_quantize_sse2.c:136:16: implicit conversion from type
'int' of value 65535 (32-bit, signed) to type 'int16_t' (aka 'short')
changed the value to -1 (16-bit, signed)

BUG=webm:1649

Change-Id: I0e3f5278af49d84760f3dfb607f28099cf02f21d

4 years agovp9-svc: Add new frame drop mode for SVC
Marco Paniconi [Fri, 30 Aug 2019 17:58:15 +0000 (10:58 -0700)]
vp9-svc: Add new frame drop mode for SVC

add SVC framedrop mode: Lower spatial layers
are constrained to drop if current spatial layer
needs to drop.

No change in behavior to other existing modes.

Change-Id: I2d37959caf8c4b453b405904831b550367f716ba

4 years agoMerge "Don't generate mv refs that won't be used"
James Zern [Fri, 6 Sep 2019 08:00:46 +0000 (08:00 +0000)]
Merge "Don't generate mv refs that won't be used"

4 years agoMerge "Upload Motion Field Estimation Unit Test Files"
Angie Chiang [Tue, 3 Sep 2019 18:23:23 +0000 (18:23 +0000)]
Merge "Upload Motion Field Estimation Unit Test Files"

4 years agoReport failure of vp9_alloc_motion_field_info
Angie Chiang [Fri, 30 Aug 2019 23:20:36 +0000 (16:20 -0700)]
Report failure of vp9_alloc_motion_field_info

Change-Id: I87f2a8dbf4e89b1cc8526307e82812aea6ac137e

4 years agoUpload Motion Field Estimation Unit Test Files
Dan Zhu [Fri, 30 Aug 2019 20:20:46 +0000 (13:20 -0700)]
Upload Motion Field Estimation Unit Test Files

Change-Id: Ia8f9e9dca562183ff188cd29dfc7ba3435d77900

4 years agoFree set_mv properly
Angie Chiang [Fri, 30 Aug 2019 01:30:40 +0000 (18:30 -0700)]
Free set_mv properly

Change-Id: I9b1830dc16189678121c860e0493ed8b04c512a8

4 years agoDon't generate mv refs that won't be used
Alex Converse [Fri, 28 Jun 2019 19:26:20 +0000 (12:26 -0700)]
Don't generate mv refs that won't be used

Spends 25% less time in dec_find_mv_refs for
grass_1_1280X768_fr30_bd8_sub8X8_l31.webm saving 0.7% overall.

Change-Id: I658bb5d6dd8ac82a568c7823dea3f4947ad7ed73

4 years agoMerge "Move motion field from TplDepFrame to MotionField"
Angie Chiang [Thu, 29 Aug 2019 00:35:27 +0000 (00:35 +0000)]
Merge "Move motion field from TplDepFrame to MotionField"

4 years agoMerge "Add resize test for smaller width bigger size."
Jerome Jiang [Wed, 28 Aug 2019 23:41:13 +0000 (23:41 +0000)]
Merge "Add resize test for smaller width bigger size."

4 years agoMerge "vpx_dsp/x86/highbd_idct4x4_add_sse2: fix int sanitizer warnings"
Hien Ho [Wed, 28 Aug 2019 20:41:16 +0000 (20:41 +0000)]
Merge "vpx_dsp/x86/highbd_idct4x4_add_sse2: fix int sanitizer warnings"

4 years agoMove motion field from TplDepFrame to MotionField
Angie Chiang [Fri, 23 Aug 2019 00:55:19 +0000 (17:55 -0700)]
Move motion field from TplDepFrame to MotionField

Replace get_pyramid_mv by vp9_motion_field_mi_get_mv.

The goal is to modularize motion field related operations.

Change-Id: I33084e680567ab106659ba9389cc4b507b893c69

4 years agoMerge changes I0fad9437,I79fcb1fd,I93660044
Angie Chiang [Wed, 28 Aug 2019 20:38:20 +0000 (20:38 +0000)]
Merge changes I0fad9437,I79fcb1fd,I93660044

* changes:
  Add MACRO MAX_INTER_REF_FRAMES
  Add motion_filed_info in VP9_COMP
  Add free_tpl_buffer

4 years agoAdd resize test for smaller width bigger size.
Jerome Jiang [Wed, 28 Aug 2019 17:22:04 +0000 (10:22 -0700)]
Add resize test for smaller width bigger size.

Stack trace is the same as that in the bug.

BUG=webm:1642

Change-Id: I9d88c18a40af8df4a679727620070b13f1606f14

4 years agovpx_dsp/x86/highbd_idct4x4_add_sse2: fix int sanitizer warnings
Hien Ho [Wed, 28 Aug 2019 18:18:01 +0000 (11:18 -0700)]
vpx_dsp/x86/highbd_idct4x4_add_sse2: fix int sanitizer warnings

implicit conversion from type 'int' of value 49161 (32-bit, signed) to
type 'int16_t' (aka 'short') changed the value to -16375 (16-bit,
signed)

BUG=webm:1615

Change-Id: I3f18283609ac2ce365202a63ef61a47eb00c155b

4 years agoMerge "vp8/encoder/vp8_quantize: fix int sanitizer warnings"
Hien Ho [Wed, 28 Aug 2019 16:28:41 +0000 (16:28 +0000)]
Merge "vp8/encoder/vp8_quantize: fix int sanitizer warnings"

4 years agoAdd MACRO MAX_INTER_REF_FRAMES
Angie Chiang [Wed, 21 Aug 2019 23:04:40 +0000 (16:04 -0700)]
Add MACRO MAX_INTER_REF_FRAMES

Use MAX_INTER_REF_FRAMES wheneve it's suitable

Change-Id: I0fad94371a6600099313685cbe38faebb44178c4

4 years agoAdd motion_filed_info in VP9_COMP
Angie Chiang [Wed, 21 Aug 2019 22:49:13 +0000 (15:49 -0700)]
Add motion_filed_info in VP9_COMP

Call vp9_alloc_motion_field_info and
vp9_free_motion_field_info properly

Change-Id: I79fcb1fd37ee5e95bf7febb728480583ebd5a065