Richard Russon [Thu, 16 Nov 2017 01:37:37 +0000 (01:37 +0000)]
rename string functions
Richard Russon [Thu, 16 Nov 2017 01:37:19 +0000 (01:37 +0000)]
rename sha1 functions
Richard Russon [Thu, 16 Nov 2017 01:36:55 +0000 (01:36 +0000)]
rename memory functions
Richard Russon [Thu, 16 Nov 2017 01:36:39 +0000 (01:36 +0000)]
rename md5 functions
Richard Russon [Thu, 16 Nov 2017 02:30:25 +0000 (02:30 +0000)]
rename mbyte functions
Richard Russon [Thu, 16 Nov 2017 01:36:21 +0000 (01:36 +0000)]
rename mapping functions
Richard Russon [Thu, 16 Nov 2017 02:22:46 +0000 (02:22 +0000)]
rename list functions
Richard Russon [Thu, 16 Nov 2017 01:36:11 +0000 (01:36 +0000)]
rename hash functions
Richard Russon [Thu, 16 Nov 2017 02:07:04 +0000 (02:07 +0000)]
rename file functions
Richard Russon [Thu, 16 Nov 2017 01:34:42 +0000 (01:34 +0000)]
rename date functions
Richard Russon [Thu, 16 Nov 2017 02:49:14 +0000 (02:49 +0000)]
rename buffer functions
Richard Russon [Thu, 16 Nov 2017 01:34:03 +0000 (01:34 +0000)]
rename base64 functions
Richard Russon [Thu, 16 Nov 2017 00:54:03 +0000 (00:54 +0000)]
rename lib to mutt
Richard Russon [Wed, 15 Nov 2017 23:57:37 +0000 (23:57 +0000)]
merge: upstream fixes (mutt/default)
* Note which ssl config vars are GnuTLS or OpenSSL only
* Add message count to $move quadoption prompt
* Add %R (number of read messages) for $status_format
* Updated French translation
* Add $change_folder_next option to control mailbox suggestion order
* Fix $smart_wrap to not be disabled by whitespace-prefixed lines
* Remove useless else branch in the $smart_wrap code
Kevin McCarthy [Wed, 15 Nov 2017 22:53:24 +0000 (14:53 -0800)]
Remove useless else branch in the $smart_wrap code. (see #3857)
Thanks to Vincent Lefèvre for noticing the nested else was redundant,
since buf_ptr is already set to "buf + cnt" after the format_line()
call.
This allows us to merge the inner and outer if statement, resulting in
simpler code.
Kevin McCarthy [Wed, 15 Nov 2017 22:53:19 +0000 (14:53 -0800)]
Fix $smart_wrap to not be disabled by whitespace-prefixed lines. (closes #3857)
changeset:
737102af74eb fixed a folded header display issue with $smart_wrap
by disabling $smart_wrap for lines beginning with whitespace.
Unfortunately, this turns off smart wrapping in the body of an email
too, even when the line has other whitespace breaks in it.
An earlier commit, changeset:
125076e0fdfa added an infinite loop fix
when MUTT_PAGER_NSKIP is set, by disabling the smart_wrap if the space
backtracking went to the beginning of the line. That is, a line
beginning with 1+ whitespace followed by a single long word.
Extend this second commit by always disabling the smart_wrap in that
case, not just when MUTT_PAGER_NSKIP is set. This also solves the
folded header issue without other side effects.
Kevin McCarthy [Sat, 11 Nov 2017 23:49:15 +0000 (15:49 -0800)]
Add $change_folder_next option to control mailbox suggestion order.
This patch is out of the Gentoo package maintained by Fabian Groffen.
From the link below, it appears the original author was Simon Burge.
I made some minor changes to get it to apply correctly, and cleaned up
the documentation a bit.
Original patch description:
This patch brings back the original behaviour of change-folder, which
some people find more useful. It suggests the next folder in your
mailboxes list that has new mail measured from the current folder,
instead of the first folder from your mailboxes list in any case. This
prevents starvation of folders defined at the back of your list ;)
See discussion: http://thread.gmane.org/gmane.mail.mutt.devel/12457
Vincent Lefevre [Sat, 11 Nov 2017 18:13:40 +0000 (19:13 +0100)]
Updated French translation.
Vincent Lefevre [Sat, 11 Nov 2017 17:59:31 +0000 (18:59 +0100)]
Add %R (number of read messages) for $status_format.
Kevin McCarthy [Fri, 10 Nov 2017 21:06:43 +0000 (13:06 -0800)]
Add message count to $move quadoption prompt.
Display the number of messages that will be moved in the quadoption
prompt, which might prove helpful for some people.
Thank you to Daan van Rossum for suggesting the improvement.
Kevin McCarthy [Wed, 8 Nov 2017 20:57:50 +0000 (12:57 -0800)]
Note which ssl config vars are GnuTLS or OpenSSL only. (closes #3781)
It was not obvious that the ssl_ca_certificates_file was only for
GnuTLS, or that the ssl_usesystemcerts was only for OpenSSL.
Richard Russon [Wed, 15 Nov 2017 22:37:54 +0000 (22:37 +0000)]
merge: library moves/improvements
* build: rename headers.c to header.c
* build: move *_free functions
* doxygen: add custom layout
* lib: tidy headers
* lib: move NLS magic to message.c
* lib: move function to file.c
* lib: move functions to string.c
* lib: move function to list.c
* lib: move functions to mbyte.c
Richard Russon [Wed, 15 Nov 2017 21:36:54 +0000 (21:36 +0000)]
merge: add <edit-or-view-raw-message>
* Rename OP_EDIT_MESSAGE to OP_EDIT_RAW_MESSAGE
* neomutt-syntax.vim: Add highlight rules for new functions
* doc: Document new mutt functions in manual
* editmsg.c: Implement mutt_view_message() function
* Add `<{edit,edit-or-view,view}-raw-message>` functions
Reis Radomil [Wed, 15 Nov 2017 20:53:03 +0000 (21:53 +0100)]
Add `<{edit,edit-or-view,view}-raw-message>` functions
Add mutt-functions `<edit-raw-message>`, `<edit-or-view-raw-message>`
and `<view-raw-message>`.
`<view-raw-message>` is a binding for the C-function
`mutt_view_message()`, which opens the raw message as a read-only file
in an external editor.
`<edit-or-view-raw-message>` is a dispatcher function: If the mailbox
is writable then this is the same as `<edit-raw-message>`, otherwise it
is the same as `<view-raw-message>`.
`<edit-raw-message>` is a synonym for `<edit>` whose name coherent with
the naming scheme of the other two functions introduced.
Change default key binding of `e` from `edit` to
`edit-or-view-raw-message`. This allows viewing the raw message in an
external editor also in read-only mailboxes.
Reis Radomil [Wed, 15 Nov 2017 20:53:03 +0000 (21:53 +0100)]
editmsg.c: Implement mutt_view_message() function
Add mutt_view_message() function, which opens the selected message or
the tagged messages as a read-only file in an external editor. This
function is similar to mutt_edit_message() but does not allow modifying
the message.
A usage scenario might be to view the message source code in an editor.
Note: This patch only adds C functions. It does not add any mutt-functions.
Reis Radomil [Wed, 15 Nov 2017 20:53:03 +0000 (21:53 +0100)]
doc: Document new mutt functions in manual
Document the new mutt functions `edit-or-view-raw-message` and
`view-raw-message`.
Amend description of `edit` function to mention the two new functions.
Reis Radomil [Wed, 15 Nov 2017 20:53:03 +0000 (21:53 +0100)]
neomutt-syntax.vim: Add highlight rules for new functions
Add syntax rules for the new functions `edit-or-view-raw-message` and
`view-raw-message`.
Reis Radomil [Wed, 15 Nov 2017 20:52:14 +0000 (21:52 +0100)]
Rename OP_EDIT_MESSAGE to OP_EDIT_RAW_MESSAGE
This brings the constant name in line with the description of its
corresponding mutt-function and paves the way for a coherent name scheme
in the upcoming 'edit-raw-message' family of mutt-functions.
Richard Russon [Wed, 15 Nov 2017 15:46:30 +0000 (15:46 +0000)]
merge: small coverity fixes
* fix typos
* fix leak in mutt_select_file()
* fix leak in mutt_compose_attachment()
* highlight preproc-like variable
* add pointer checks to gpgme
* check retval of REGCOMP()
* check retval of strtok()
* check retval of mutt_save_attachment()
* check retval of mutt_account_get{user,pass,login}()
* check retval of mutt_system()
Richard Russon [Mon, 13 Nov 2017 13:16:32 +0000 (13:16 +0000)]
check retval of mutt_system()
`mutt_system()` returns int, so check accordingly.
Also, make sure we log if any calls fail.
Richard Russon [Mon, 13 Nov 2017 12:58:07 +0000 (12:58 +0000)]
check retval of mutt_account_get{user,pass,login}()
Functions `mutt_account_getuser()`, `mutt_account_getpass()` and
`mutt_account_getlogin()` all return int, so check accordingly.
Also, make sure we log if any calls fail.
Richard Russon [Mon, 13 Nov 2017 02:23:25 +0000 (02:23 +0000)]
check retval of mutt_save_attachment()
Richard Russon [Mon, 13 Nov 2017 01:57:37 +0000 (01:57 +0000)]
check retval of strtok()
Richard Russon [Sun, 12 Nov 2017 23:58:17 +0000 (23:58 +0000)]
check retval of REGCOMP()
`REGCOMP()` wraps `regcomp()` which returns int.
Richard Russon [Mon, 13 Nov 2017 11:42:45 +0000 (11:42 +0000)]
add pointer checks to gpgme
Richard Russon [Mon, 13 Nov 2017 02:39:04 +0000 (02:39 +0000)]
highlight preproc-like variable
`allow_skip` is only set in one place in a `#ifdef`d block.
This effectively makes it a preprocessor condition.
By changing its name to capitals we let Coverity know how we're using
the variable.
Richard Russon [Mon, 13 Nov 2017 01:36:08 +0000 (01:36 +0000)]
fix leak in mutt_compose_attachment()
Move the `mutt_free_body()` before the two `goto bailout`s.
Richard Russon [Mon, 13 Nov 2017 00:39:27 +0000 (00:39 +0000)]
fix leak in mutt_select_file()
Richard Russon [Tue, 14 Nov 2017 00:39:58 +0000 (00:39 +0000)]
fix typos
Pietro Cerutti [Tue, 14 Nov 2017 15:39:47 +0000 (15:39 +0000)]
Make sure objects are not compiled before git_ver.h is generated
Richard Russon [Sat, 11 Nov 2017 23:40:23 +0000 (23:40 +0000)]
autosetup: expand --everything in `neomutt -v`
Richard Russon [Sun, 12 Nov 2017 02:26:13 +0000 (02:26 +0000)]
doxygen: document parameter functions
Richard Russon [Sun, 12 Nov 2017 02:22:06 +0000 (02:22 +0000)]
doxygen: document envelope functions
Richard Russon [Sun, 12 Nov 2017 02:20:43 +0000 (02:20 +0000)]
doxygen: document address functions
Richard Russon [Sat, 11 Nov 2017 23:20:57 +0000 (23:20 +0000)]
docs: add a sentence to quasi-delete docs
Pietro Cerutti [Thu, 9 Nov 2017 17:03:52 +0000 (17:03 +0000)]
Cleanup "SSL is unavailable" error in mutt_conn_find
- Remove the sleep
- Be more informative about the failed connection
Issue #934
Pietro Cerutti [Thu, 9 Nov 2017 08:50:52 +0000 (08:50 +0000)]
Sanitize mutt_copy_message* APIs
Richard Russon [Tue, 7 Nov 2017 15:11:18 +0000 (15:11 +0000)]
rename public functions with a leading underscore
Richard Russon [Tue, 7 Nov 2017 15:11:14 +0000 (15:11 +0000)]
rename static functions with a leading underscore
Edward Betts [Thu, 9 Nov 2017 09:38:53 +0000 (09:38 +0000)]
Correct spelling mistakes.
Richard Russon [Wed, 8 Nov 2017 16:47:29 +0000 (16:47 +0000)]
doc: display_filter escape sequence
Issue #897
Richard Russon [Wed, 1 Nov 2017 05:14:22 +0000 (05:14 +0000)]
fix: drop capability aliases
`CapabilityAliases` was a list of alternative names (just one) for IMAP
capability strings. This isn't necessary. We can put the strings in
`Capabilities` and fix the enumeration.
```c
enum ImapCaps
{
...
X_GM_EXT1,
X_GM_ALT1 = X_GM_EXT1,
...
};
```
Richard Russon [Wed, 1 Nov 2017 05:13:59 +0000 (05:13 +0000)]
bug: imap gmail search
The order of strings in Capabilities should match the enums in ImapCaps.
Pietro Cerutti [Wed, 8 Nov 2017 12:01:30 +0000 (12:01 +0000)]
Do not turn CRLF into LF when dealing with transfer-encoding=base64 (#920)
Fixes #722
Pietro Cerutti [Wed, 8 Nov 2017 12:01:21 +0000 (12:01 +0000)]
Check that OpenSSL md5 supports -r before using it (#915)
* Check that OpenSSL md5 supports -r before using it
Fixes #914
* Remove unused variable assignment
Fixes #914
Richard Russon [Tue, 7 Nov 2017 14:40:35 +0000 (14:40 +0000)]
merge: trivial code fixes/changes
* move test to the right place
* Remove unnecessary semicolon
* build: fix shadow variable warning
* refactor malloc/calloc
* ignore temporary build files
* fix copyright messages
* fix plain unsigned
* unused prototypes, whitespace
* Standardise spelling s/RfC/RFC/
* alias drop self
Richard Russon [Sat, 4 Nov 2017 14:31:54 +0000 (14:31 +0000)]
alias drop self
struct Alias began:
```c
struct Alias
{
struct Alias *self; /* XXX - ugly hack */
...
```
There didn't seem to be any reason for this pointer.
The two places that allocate a new Alias, immediately set the self
pointer to the object. No users of `self` test it first.
Richard Russon [Thu, 2 Nov 2017 14:29:21 +0000 (14:29 +0000)]
Standardise spelling s/RfC/RFC/
Richard Russon [Wed, 1 Nov 2017 04:24:02 +0000 (04:24 +0000)]
unused prototypes, whitespace
Richard Russon [Wed, 1 Nov 2017 02:29:43 +0000 (02:29 +0000)]
fix plain unsigned
Be specific. Replace `unsigned` with `unsigned int`.
Richard Russon [Wed, 1 Nov 2017 02:24:50 +0000 (02:24 +0000)]
fix copyright messages
Richard Russon [Sat, 28 Oct 2017 15:19:48 +0000 (16:19 +0100)]
ignore temporary build files
Richard Russon [Thu, 26 Oct 2017 15:32:41 +0000 (16:32 +0100)]
refactor malloc/calloc
Replace a malloc() and repeated memset()s with a single calloc().
Richard Russon [Thu, 26 Oct 2017 14:44:52 +0000 (15:44 +0100)]
build: fix shadow variable warning
Richard Russon [Tue, 24 Oct 2017 16:01:46 +0000 (17:01 +0100)]
Remove unnecessary semicolon
Richard Russon [Mon, 23 Oct 2017 11:37:19 +0000 (12:37 +0100)]
move test to the right place
Pietro Cerutti [Mon, 6 Nov 2017 13:54:25 +0000 (13:54 +0000)]
Respect --with-ssl path (#917)
Fixes #916
Richard Russon [Mon, 6 Nov 2017 13:19:57 +0000 (13:19 +0000)]
autosetup: fix check for missing sendmail
If sendmail wasn't on the path, then configure.autosetup defined
SENDMAIL=false
Pietro Cerutti [Mon, 6 Nov 2017 12:32:52 +0000 (12:32 +0000)]
Define NCURSES_WIDECHAR to require wide-char support from ncurses (#908)
See https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg00634.html
for a discussion. This might be a solution for #589.
Pietro Cerutti [Sun, 5 Nov 2017 16:14:31 +0000 (16:14 +0000)]
Fix wrong extern declaration of globals in conn/conn_globals.h (#919)
* Revert "Move definition of conn/globals.h back into globals.h (#912)"
This reverts commit
fe03e2b126ca899f6fdd8276125bef3c66b6aef4.
* Fix wrong extern definition of globals in conn/conn_globals.h
Issue #918
Pietro Cerutti [Sun, 5 Nov 2017 12:42:55 +0000 (12:42 +0000)]
Move definition of conn/globals.h back into globals.h (#912)
Fixed #907
Pietro Cerutti [Sun, 5 Nov 2017 12:42:43 +0000 (12:42 +0000)]
Make sure Url is initialized even when u->scheme == U_UNKNOWN (#911)
Fixed #910
Richard Russon [Wed, 1 Nov 2017 04:28:47 +0000 (04:28 +0000)]
lib: move functions to mbyte.c
Richard Russon [Tue, 7 Nov 2017 22:28:13 +0000 (22:28 +0000)]
lib: move function to list.c
Richard Russon [Wed, 1 Nov 2017 04:39:07 +0000 (04:39 +0000)]
lib: move functions to string.c
Richard Russon [Wed, 1 Nov 2017 02:50:26 +0000 (02:50 +0000)]
lib: move function to file.c
Richard Russon [Wed, 1 Nov 2017 02:44:53 +0000 (02:44 +0000)]
lib: move NLS magic to message.c
Richard Russon [Thu, 2 Nov 2017 17:59:17 +0000 (17:59 +0000)]
lib: tidy headers
Pietro Cerutti [Mon, 30 Oct 2017 15:44:04 +0000 (15:44 +0000)]
Enhance ifdef feature to support my_ vars (#906)
* Enhance ifdef feature to support my_ vars
Issue #905
* Use myvar_get, do not reinvent the wheel
Issue #905
Pietro Cerutti [Mon, 30 Oct 2017 09:22:15 +0000 (09:22 +0000)]
Fix build, apply clang-format
Richard Russon [Fri, 27 Oct 2017 16:34:13 +0000 (17:34 +0100)]
fix build for RHEL6
RHEL6 doesn't have the function sasl_client_done().
Richard Russon [Sat, 28 Oct 2017 16:19:31 +0000 (17:19 +0100)]
Add comment blocks to ~60 functions
Richard Russon [Sat, 28 Oct 2017 14:24:44 +0000 (15:24 +0100)]
build: Create a Connection Library (libconn)
There are no changes to the code, just rearrangements of functions.
Richard Russon [Sat, 28 Oct 2017 03:42:53 +0000 (04:42 +0100)]
merge: Document 70 IMAP functions
There are no code changes in this set.
* rearrange functions
* rename static functions
* fix some types
* comment blocks
Richard Russon [Mon, 23 Oct 2017 13:47:37 +0000 (14:47 +0100)]
comment blocks
Richard Russon [Tue, 24 Oct 2017 18:08:08 +0000 (19:08 +0100)]
fix some types
Richard Russon [Mon, 23 Oct 2017 13:46:09 +0000 (14:46 +0100)]
rename static functions
Richard Russon [Mon, 23 Oct 2017 13:39:53 +0000 (14:39 +0100)]
rearrange functions
No code changes
Static functions first
General public functions
Mailbox functions
Richard Russon [Fri, 27 Oct 2017 15:22:21 +0000 (16:22 +0100)]
NeoMutt 2017-10-27
Richard Russon [Fri, 27 Oct 2017 13:22:43 +0000 (14:22 +0100)]
update translations
Richard Russon [Fri, 27 Oct 2017 13:18:23 +0000 (14:18 +0100)]
clang-format
Richard Russon [Fri, 27 Oct 2017 13:03:00 +0000 (14:03 +0100)]
update mailmap
Richard Russon [Fri, 27 Oct 2017 12:49:48 +0000 (13:49 +0100)]
docs: update credits
Richard Russon [Fri, 27 Oct 2017 12:46:24 +0000 (13:46 +0100)]
update changelog
Richard Russon [Fri, 27 Oct 2017 12:13:28 +0000 (13:13 +0100)]
version 2017-10-27
Pietro Cerutti [Thu, 26 Oct 2017 16:08:41 +0000 (17:08 +0100)]
Wrap dirname(3) inside a mutt_dirname() function
* Wrap dirname(3) inside a mutt_dirname() function
This new function, opposite to the original dirname(3), does not modify
its argument and can be passed a const char * argument. This means that
callers mustn't copy their strings before calling dirname anymore.
Richard Russon [Thu, 26 Oct 2017 16:06:34 +0000 (17:06 +0100)]
autosetup: check for sys_siglist[]
Mehdi ABAAKOUK [Wed, 25 Oct 2017 16:10:53 +0000 (18:10 +0200)]
url: make notmuch query string parser generic (#812)
* Notmuch: remove custom UriTag linked list
Use STAILQ helper for UriTag linked list.
* url: make notmuch query string parser generic
Enhance the url.c to handle query strings.
This permits to remove the notmuch custom url parser.
* url: always parse query string
This removes url_parse_with_qs methods.
* fix some problems
- double free in nm_normalize_uri()
- set path to NULL in url_parse()
If we're setting all the other members, we should set the path too
- tidy some doxygen docs
* notmuch: remove useless starting / from db_filename
Richard Russon [Wed, 25 Oct 2017 15:56:21 +0000 (16:56 +0100)]
build: --enable-everything includes lua (#868)
Fixes #855
Pietro Cerutti [Wed, 25 Oct 2017 15:51:46 +0000 (16:51 +0100)]
Do not use CPPFLAGS / CFLAGS together with CC_FOR_BUILD (#882)
* Do not use CPPFLAGS / CFLAGS together with CC_FOR_BUILD
* Restore -std=c99 when building makedoc
* Make sure host-independent CFLAGS are passed to CC_FOR_BUILD
* Let CC_FOR_BUILD carry CFLAGS_FOR_BUILD, there's no reason to split them