]> granicus.if.org Git - neomutt/log
neomutt
5 years agodocs: color/uncolor 1864/head
Richard Russon [Fri, 4 Oct 2019 17:59:41 +0000 (18:59 +0100)]
docs: color/uncolor

5 years agosort symbols
Richard Russon [Fri, 4 Oct 2019 11:41:11 +0000 (12:41 +0100)]
sort symbols

5 years agocolour notifications
Richard Russon [Fri, 4 Oct 2019 10:41:00 +0000 (11:41 +0100)]
colour notifications

5 years agoimplement more uncolor commands
Richard Russon [Fri, 4 Oct 2019 10:39:40 +0000 (11:39 +0100)]
implement more uncolor commands

5 years agodeglobalise Colors
Richard Russon [Fri, 4 Oct 2019 01:48:12 +0000 (02:48 +0100)]
deglobalise Colors

5 years agomove mutt_colors_free
Richard Russon [Fri, 4 Oct 2019 01:28:05 +0000 (02:28 +0100)]
move mutt_colors_free

5 years agomove color_line_new
Richard Russon [Fri, 4 Oct 2019 01:26:53 +0000 (02:26 +0100)]
move color_line_new

5 years agoinitialise lists
Richard Russon [Fri, 4 Oct 2019 01:25:59 +0000 (02:25 +0100)]
initialise lists

5 years agomove parse_object
Richard Russon [Fri, 4 Oct 2019 01:23:36 +0000 (02:23 +0100)]
move parse_object

5 years agomove mutt_color_free
Richard Russon [Fri, 4 Oct 2019 01:21:59 +0000 (02:21 +0100)]
move mutt_color_free

5 years agoencapsulate color_list
Richard Russon [Fri, 4 Oct 2019 01:19:18 +0000 (02:19 +0100)]
encapsulate color_list

5 years agoencapsulate quoted
Richard Russon [Fri, 4 Oct 2019 01:17:34 +0000 (02:17 +0100)]
encapsulate quoted

5 years agoencapsulate defs
Richard Russon [Fri, 4 Oct 2019 01:10:17 +0000 (02:10 +0100)]
encapsulate defs

5 years agofix max quote depth
Richard Russon [Fri, 4 Oct 2019 00:50:00 +0000 (01:50 +0100)]
fix max quote depth

5 years agoencapsulate all the colours
Richard Russon [Fri, 4 Oct 2019 00:37:14 +0000 (01:37 +0100)]
encapsulate all the colours

5 years agodo_uncolor change param to retval
Richard Russon [Thu, 3 Oct 2019 23:09:15 +0000 (00:09 +0100)]
do_uncolor change param to retval

5 years agorename/move function
Richard Russon [Thu, 3 Oct 2019 23:00:38 +0000 (00:00 +0100)]
rename/move function

5 years agotidy code
Richard Russon [Thu, 3 Oct 2019 22:10:08 +0000 (23:10 +0100)]
tidy code

5 years agoconvert retval to CommandResult
Richard Russon [Thu, 3 Oct 2019 22:09:57 +0000 (23:09 +0100)]
convert retval to CommandResult

5 years agorename vars
Richard Russon [Thu, 3 Oct 2019 22:04:18 +0000 (23:04 +0100)]
rename vars

5 years agotidy whitespace
Richard Russon [Thu, 3 Oct 2019 22:01:37 +0000 (23:01 +0100)]
tidy whitespace

5 years agorename and reorder color constants
Richard Russon [Thu, 3 Oct 2019 18:15:30 +0000 (19:15 +0100)]
rename and reorder color constants

5 years agoLet reply_to take precedence over C_ReplySelf 1863/head
Pietro Cerutti [Mon, 30 Sep 2019 15:59:39 +0000 (15:59 +0000)]
Let reply_to take precedence over C_ReplySelf

5 years agomerge: upstream refactoring
Richard Russon [Tue, 8 Oct 2019 22:34:59 +0000 (23:34 +0100)]
merge: upstream refactoring

 * Re-enable and cleanup format-flowed space stuffing
 * Remove manual note about space-stuffing only once
 * Reuse the static space_stuff function for unstuffing
 * Convert crypt-gpgme to use struct Buffer for tempfiles
 * Convert crypt_extract_keys and signed handler to use buffers
 * Convert edit_one_message() to use buffer pool
 * Convert run_decode_and_handler() to use buffer pool
 * Convert hcache db4 lockfile to buffer
 * Convert hcache_open to use buffer pool
 * Fix built-in pager checks for help and attachments
 * Convert mutt_edit_headers() to use buffer pool
 * Convert mutt_help() to use buffer for tempfile
 * Convert save-hook and fcc-hook to use buffer pool internally
 * Fix mutt_write_mime_body() application/pgp-encrypted handling
 * Convert imap_open_new_message() to use buffer pool
 * Convert imap fetch_new and fetch_message tempfiles to buffer pool
 * Convert imap_cachepath() and callers to use buffers
 * Convert parse_path_(un)list to use buffer pool for path
 * Convert start_debug() to use buffer pool

5 years agoConvert start_debug() to use buffer pool
Kevin McCarthy [Tue, 8 Oct 2019 07:22:27 +0000 (15:22 +0800)]
Convert start_debug() to use buffer pool

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert parse_path_(un)list to use buffer pool for path
Kevin McCarthy [Tue, 8 Oct 2019 05:07:40 +0000 (13:07 +0800)]
Convert parse_path_(un)list to use buffer pool for path

Don't use the buf parameter to avoid stretching it out, as it's used
for the entire rc parsing, and typically just holds command names.

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert imap_cachepath() and callers to use buffers
Kevin McCarthy [Tue, 8 Oct 2019 03:24:38 +0000 (11:24 +0800)]
Convert imap_cachepath() and callers to use buffers

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert imap fetch_new and fetch_message tempfiles to buffer pool
Kevin McCarthy [Mon, 7 Oct 2019 02:39:44 +0000 (10:39 +0800)]
Convert imap fetch_new and fetch_message tempfiles to buffer pool

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert imap_open_new_message() to use buffer pool
Kevin McCarthy [Mon, 7 Oct 2019 01:55:39 +0000 (09:55 +0800)]
Convert imap_open_new_message() to use buffer pool

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoFix mutt_write_mime_body() application/pgp-encrypted handling
Kevin McCarthy [Tue, 10 Sep 2019 01:32:59 +0000 (18:32 -0700)]
Fix mutt_write_mime_body() application/pgp-encrypted handling

It would blindly overwrite any attachment with that type, as if it
were the version label part of a multipart/encrypted message.

However attachments with extenstion .gpg are labeled that type if
$mime_type_query_command is set to "xdg-mime query filetype".  This
would cause the attachment to be overwritten too.

Add a check for a missing body->filename, which should only be the
case for the manually constructed part.

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert save-hook and fcc-hook to use buffer pool internally
Kevin McCarthy [Sun, 6 Oct 2019 08:32:42 +0000 (16:32 +0800)]
Convert save-hook and fcc-hook to use buffer pool internally

The hook parameters still need to be converted, but I'm working
towards it slowly.

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert mutt_help() to use buffer for tempfile
Kevin McCarthy [Sat, 5 Oct 2019 05:59:57 +0000 (13:59 +0800)]
Convert mutt_help() to use buffer for tempfile

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert mutt_edit_headers() to use buffer pool
Kevin McCarthy [Sat, 5 Oct 2019 05:52:50 +0000 (13:52 +0800)]
Convert mutt_edit_headers() to use buffer pool

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoFix built-in pager checks for help and attachments
Kevin McCarthy [Fri, 4 Oct 2019 07:29:03 +0000 (15:29 +0800)]
Fix built-in pager checks for help and attachments

Mutt uses the built-in pager when $pager is unset too.  Fix a few
checks to also handle that case.

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert hcache_open to use buffer pool
Kevin McCarthy [Sat, 28 Sep 2019 01:12:27 +0000 (18:12 -0700)]
Convert hcache_open to use buffer pool

Change the namer function and mutt_hcache_per_folder to operate on a
buffer parameter.

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert hcache db4 lockfile to buffer
Kevin McCarthy [Fri, 27 Sep 2019 22:46:49 +0000 (15:46 -0700)]
Convert hcache db4 lockfile to buffer

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert run_decode_and_handler() to use buffer pool
Kevin McCarthy [Fri, 27 Sep 2019 21:42:45 +0000 (14:42 -0700)]
Convert run_decode_and_handler() to use buffer pool

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert edit_one_message() to use buffer pool
Kevin McCarthy [Fri, 27 Sep 2019 21:28:01 +0000 (14:28 -0700)]
Convert edit_one_message() to use buffer pool

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert crypt_extract_keys and signed handler to use buffers
Kevin McCarthy [Thu, 26 Sep 2019 01:44:50 +0000 (18:44 -0700)]
Convert crypt_extract_keys and signed handler to use buffers

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert crypt-gpgme to use struct Buffer for tempfiles
Kevin McCarthy [Wed, 25 Sep 2019 22:28:30 +0000 (15:28 -0700)]
Convert crypt-gpgme to use struct Buffer for tempfiles

Use the pool where possible, but when the function calls other
long-running functions (such as mutt_body_handler() or
mutt_do_pager()), allocate the buffer.

smime_gpgme_decrypt_mime() was not freeing the "cur" struct Body generated on
error.  Add a call to mutt_free_body(cur) in the error handling.

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoReuse the static space_stuff function for unstuffing
Kevin McCarthy [Sun, 1 Sep 2019 20:25:06 +0000 (13:25 -0700)]
Reuse the static space_stuff function for unstuffing

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoRemove manual note about space-stuffing only once
Kevin McCarthy [Sat, 31 Aug 2019 21:17:22 +0000 (14:17 -0700)]
Remove manual note about space-stuffing only once

Stuffing is now performed each time.

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoRe-enable and cleanup format-flowed space stuffing
Kevin McCarthy [Sat, 31 Aug 2019 20:37:16 +0000 (13:37 -0700)]
Re-enable and cleanup format-flowed space stuffing

Commit 04cb5bde tried to fix re-stuffing a postponed message more than
once, but unfortunately broke the normal case of composing a new
message.  So actually, space-stuffing has been turned off the past 7
years.

Move format=flowed parameter setting below the standard message
pre-processing block.  It shouldn't be performed for draft-files even
with $resume_draft_files set.  Moving out of the block makes that
clearer.

Create mutt_rfc3676_space_(un)stuff() functions, which check the
content type and stuff/unstuff apprpropriately.  Note that the
stuff/unstuff does not depend on $text_flowed, which is only in charge
of setting the format=flowed parameter.  This parameter can also come
from resumed/resent/draft messages and should still be respected.

Add unstuffing to mutt_prepare_template().  This is called by
postponed, resent, and draft files.  This will prevent double-stuffing
in those cases.

Unstuff/restuff around editing the message in the compose menu, to
keep everything transparent to the user.  I originally put the
stuffing *after* the compose menu, but previewing the messages in the
compose menu did not work properly in that case.  It's cleaner this
way too.

Change the stuff/unstuff functions to preserve the original
hdr->content->filename.  The "hack" previously used would interact
poorly with editable body files (mutt -i -E).  Fortunately space
stuffing was pretty much disabled except in unusual cases before.

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agofix: broken index_format
Richard Russon [Mon, 7 Oct 2019 12:07:26 +0000 (13:07 +0100)]
fix: broken index_format

A chance alignment made enum symbol MT_COLOR_INDEX_NUMBER equal to 37
(ASCII %).  This was causing problems when inserting colour codes into
the index_format string.

5 years agobuild: fix autosetup warning
Zero King [Sat, 5 Oct 2019 07:00:15 +0000 (07:00 +0000)]
build: fix autosetup warning

5 years agoadd: log warnings
Richard Russon [Wed, 2 Oct 2019 14:20:32 +0000 (15:20 +0100)]
add: log warnings

Distinguish between errors and warnings in the log and displayed on screen.

  color warning brightyellow default

5 years agoinit.h fix cast
Richard Russon [Fri, 4 Oct 2019 00:09:28 +0000 (01:09 +0100)]
init.h fix cast

5 years agotidy do...while loops
Richard Russon [Thu, 3 Oct 2019 01:30:33 +0000 (02:30 +0100)]
tidy do...while loops

5 years agofix crash on exit
Richard Russon [Wed, 2 Oct 2019 22:58:32 +0000 (23:58 +0100)]
fix crash on exit

Even if mx_mbox_open() fails, the Mailbox might still have an Account.

5 years agodocs: update list of colours
Richard Russon [Wed, 2 Oct 2019 00:50:36 +0000 (01:50 +0100)]
docs: update list of colours

Update the list of objects that can be coloured and give examples for
each category.

5 years agomerge: upstream refactoring
Richard Russon [Tue, 1 Oct 2019 10:48:33 +0000 (11:48 +0100)]
merge: upstream refactoring

 * Properly revert on an autocrypt postpone failure
 * Fix memory leak when attaching messages
 * Convert bcache to use buffer pools
 * Convert mutt_complete() to use the buffer pool
 * Convert compose check_attachments() to use buffer pool
 * Fix mutt_save_message() "enter_fname()" to use buffer version
 * Create mutt_buffer_get_field()
 * Convert buffer callers of mutt_get_field() to use buffer version
 * Convert compose menu fname variable to buffer
 * Convert compress setup_paths() to use buffer
 * Fix memory leak in compose write-fcc function
 * buffer: tidy checks for empty Buffers

5 years agobuffer: tidy checks for empty Buffers 1856/head
Richard Russon [Tue, 1 Oct 2019 10:33:09 +0000 (11:33 +0100)]
buffer: tidy checks for empty Buffers

5 years agoFix memory leak in compose write-fcc function
Kevin McCarthy [Sun, 22 Sep 2019 22:59:27 +0000 (15:59 -0700)]
Fix memory leak in compose write-fcc function

The outer multipart was not being freed after writing.

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert compress setup_paths() to use buffer
Kevin McCarthy [Sun, 22 Sep 2019 22:58:58 +0000 (15:58 -0700)]
Convert compress setup_paths() to use buffer

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert compose menu fname variable to buffer
Kevin McCarthy [Sun, 22 Sep 2019 21:38:03 +0000 (14:38 -0700)]
Convert compose menu fname variable to buffer

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert buffer callers of mutt_get_field() to use buffer version
Kevin McCarthy [Sun, 22 Sep 2019 21:16:56 +0000 (14:16 -0700)]
Convert buffer callers of mutt_get_field() to use buffer version

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoCreate mutt_buffer_get_field()
Kevin McCarthy [Sun, 22 Sep 2019 21:11:43 +0000 (14:11 -0700)]
Create mutt_buffer_get_field()

This will reduce the buffer->dptr fiddling all over the place into one
spot until mutt_enter_string() can be converted.

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoFix mutt_save_message() "enter_fname()" to use buffer version
Kevin McCarthy [Sun, 22 Sep 2019 01:34:51 +0000 (18:34 -0700)]
Fix mutt_save_message() "enter_fname()" to use buffer version

Commit be632f11 converted this function to use the buffer pool, but
accidentally used the non-buffer prompt when there was already a
buffer-converted version.

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert compose check_attachments() to use buffer pool
Kevin McCarthy [Sun, 22 Sep 2019 02:41:28 +0000 (19:41 -0700)]
Convert compose check_attachments() to use buffer pool

Modify error message so that the filename comes last, to prevent a
long path from hiding the error message or prompt.

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert mutt_complete() to use the buffer pool
Kevin McCarthy [Fri, 20 Sep 2019 01:52:24 +0000 (18:52 -0700)]
Convert mutt_complete() to use the buffer pool

Add helper functions mutt_buffer_substrcpy() and
mutt_buffer_concatn_path().

Remove mutt_concatn_path() because mutt_complete() was the only
caller.

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoConvert bcache to use buffer pools
Kevin McCarthy [Fri, 6 Sep 2019 23:14:08 +0000 (16:14 -0700)]
Convert bcache to use buffer pools

Co-authored-by: Richard Russon <rich@flatcap.org>
5 years agoFix memory leak when attaching messages
Kevin McCarthy [Mon, 2 Sep 2019 02:10:23 +0000 (19:10 -0700)]
Fix memory leak when attaching messages

Setting actx->idx[]->content->parts to NULL causes a memory leak,
because message attachments store a BODY there that needs to be freed.

I looked through the various use cases of ci_send_message() and
actually believe content->parts will be NULL for all other cases
except message attachments.  From the comment added to
delete_attachment():

  Other ci_send_message() message constructors are careful to free
  any body->parts, removing depth:
   - mutt_prepare_template() used by postponed, resent, and draft files
   - mutt_copy_body() used by the recvattach menu and $forward_attachments.

  I believe it is safe to completely remove the "content->parts =
  NULL" statement.  But for safety, am doing so only for the case
  it must be avoided: message attachments.

Co-authored-by: Austin Ray <austin@austinray.io>
5 years agoProperly revert on an autocrypt postpone failure
Kevin McCarthy [Sat, 31 Aug 2019 20:36:28 +0000 (13:36 -0700)]
Properly revert on an autocrypt postpone failure

Co-authored-by: Austin Ray <austin@austinray.io>
5 years agomerge: fix new mail behaviour
Richard Russon [Tue, 1 Oct 2019 10:13:08 +0000 (11:13 +0100)]
merge: fix new mail behaviour

Fix a number of regressions to do with new mail.

 * fix: mbox_check_stats() retvals
 * fix mbox's handling of new mail
 * fix <change-folder> when $change_folder_next is set
 * fix sidebar colour for 'new' mailboxes
 * change check_stats() to return number of new emails

5 years agochange check_stats() to return number of new emails 1859/head
Richard Russon [Tue, 1 Oct 2019 10:09:42 +0000 (11:09 +0100)]
change check_stats() to return number of new emails

5 years agofix sidebar colour for 'new' mailboxes
Richard Russon [Wed, 25 Sep 2019 12:04:05 +0000 (13:04 +0100)]
fix sidebar colour for 'new' mailboxes

This depends on the new-ness of a Mailbox, not the presence of new
emails.

5 years agofix <change-folder> when $change_folder_next is set
Richard Russon [Wed, 25 Sep 2019 12:30:22 +0000 (13:30 +0100)]
fix <change-folder> when $change_folder_next is set

5 years agofix mbox's handling of new mail
Richard Russon [Thu, 12 Sep 2019 17:05:57 +0000 (18:05 +0100)]
fix mbox's handling of new mail

`Mailbox.has_new` is tied to the timestamp of an mbox, not its count of
new mail.  Visiting a Mailbox will clear the flag, touch(1) the file.

Whether the new emails get changed to old emails depends on $mark_old.

5 years agofix: mbox_check_stats() retvals
Richard Russon [Wed, 11 Sep 2019 13:31:08 +0000 (14:31 +0100)]
fix: mbox_check_stats() retvals

Change mbox_check_stats() to clearly show when a Mailbox has new mail.
Return:
 * -1 Error
 *  0 Success, no new mail
 *  1 Success, some new mail

A bug was introduced when mbox_check_stats() was created that caused
'mbox' Mailboxes to always appear as if they had new mail.

5 years agodrop unused variable
Richard Russon [Sat, 28 Sep 2019 16:07:33 +0000 (17:07 +0100)]
drop unused variable

'suffix' hasn't been used since the iconv code was stripped out.

5 years agoinitialise gpgme pointers
Richard Russon [Sat, 28 Sep 2019 16:04:42 +0000 (17:04 +0100)]
initialise gpgme pointers

These typedef'd types are all pointers, so initialise them to NULL.

5 years agodoxy: tidy wrapper comments
Richard Russon [Wed, 25 Sep 2019 13:57:19 +0000 (14:57 +0100)]
doxy: tidy wrapper comments

5 years agowindow: fix clear_screen
Richard Russon [Mon, 30 Sep 2019 12:51:43 +0000 (13:51 +0100)]
window: fix clear_screen

The compose screen wasn't being cleared properly by just `clearok()`.

5 years agobuild: WIFEXITED is defined in sys/wait.h
Pietro Cerutti [Mon, 30 Sep 2019 12:08:44 +0000 (12:08 +0000)]
build: WIFEXITED is defined in sys/wait.h

5 years agomerge: refactor use of curses
Richard Russon [Mon, 30 Sep 2019 11:43:11 +0000 (12:43 +0100)]
merge: refactor use of curses

Tidy:
 * eliminate curses from Progress Bar
 * move colour definitions to color.h
 * tidy naming of color functions
 * move KeyEvent out of mutt_curses.h

Refactor:
 * SET_COLOR() to mutt_curses_set_color()
 * NORMAL_COLOR() to mutt_curses_set_color()
 * ATTR_SET() to mutt_curses_set_attr()
 * curs_set() to mutt_curses_set_cursor()
 * beep() to mutt_beep()
 * addch() to mutt_window_addch()
 * addnstr() to mutt_window_addnstr()
 * addstr() to mutt_window_addstr()
 * clrtobot() to mutt_window_clrtobot()
 * move() to mutt_window_move_abs()
 * printw() to mutt_window_printf()
 * mutt_window_mvaddstr()
 * clearok() to mutt_window_clear_screen()
 * mutt_window_getxy() to mutt_window_get_coords()

5 years agorefactor: mutt_window_getxy() to mutt_window_get_coords() 1860/head
Richard Russon [Fri, 27 Sep 2019 23:18:02 +0000 (00:18 +0100)]
refactor: mutt_window_getxy() to mutt_window_get_coords()

Encapsulate a curses function to reduce dependencies.

5 years agorefactor: clearok() to mutt_window_clear_screen()
Richard Russon [Fri, 27 Sep 2019 23:09:17 +0000 (00:09 +0100)]
refactor: clearok() to mutt_window_clear_screen()

Encapsulate a curses function to reduce dependencies.

5 years agorefactor: mutt_window_mvaddstr()
Richard Russon [Fri, 27 Sep 2019 15:57:03 +0000 (16:57 +0100)]
refactor: mutt_window_mvaddstr()

Encapsulate a curses function to reduce dependencies.

5 years agorefactor: printw() to mutt_window_printf()
Richard Russon [Fri, 27 Sep 2019 15:22:13 +0000 (16:22 +0100)]
refactor: printw() to mutt_window_printf()

Encapsulate a curses function to reduce dependencies.

5 years agorefactor: move() to mutt_window_move_abs()
Richard Russon [Fri, 27 Sep 2019 15:03:52 +0000 (16:03 +0100)]
refactor: move() to mutt_window_move_abs()

Encapsulate a curses function to reduce dependencies.
This function works with absolute screen coordinates rather than coords
based on a MuttWindow.  This function should be eliminated soon.

5 years agorefactor: clrtobot() to mutt_window_clrtobot()
Richard Russon [Fri, 27 Sep 2019 14:52:57 +0000 (15:52 +0100)]
refactor: clrtobot() to mutt_window_clrtobot()

Encapsulate a curses function to reduce dependencies.

5 years agorefactor: addstr() to mutt_window_addstr()
Richard Russon [Fri, 27 Sep 2019 14:45:06 +0000 (15:45 +0100)]
refactor: addstr() to mutt_window_addstr()

Encapsulate a curses function to reduce dependencies.

5 years agorefactor: addnstr() to mutt_window_addnstr()
Richard Russon [Fri, 27 Sep 2019 14:36:19 +0000 (15:36 +0100)]
refactor: addnstr() to mutt_window_addnstr()

Encapsulate a curses function to reduce dependencies.

5 years agorefactor: addch() to mutt_window_addch()
Richard Russon [Fri, 27 Sep 2019 14:27:39 +0000 (15:27 +0100)]
refactor: addch() to mutt_window_addch()

Encapsulate a curses function to reduce dependencies.

5 years agorefactor: beep() to mutt_beep()
Richard Russon [Fri, 27 Sep 2019 13:30:53 +0000 (14:30 +0100)]
refactor: beep() to mutt_beep()

Encapsulate a curses function to reduce dependencies.

5 years agorefactor: curs_set() to mutt_curses_set_cursor()
Richard Russon [Fri, 27 Sep 2019 13:21:46 +0000 (14:21 +0100)]
refactor: curs_set() to mutt_curses_set_cursor()

Encapsulate a curses function to reduce dependencies.

5 years agorefactor: ATTR_SET() to mutt_curses_set_attr()
Richard Russon [Fri, 27 Sep 2019 12:57:35 +0000 (13:57 +0100)]
refactor: ATTR_SET() to mutt_curses_set_attr()

Encapsulate a curses function to reduce dependencies.

5 years agorefactor: NORMAL_COLOR() to mutt_curses_set_color()
Richard Russon [Fri, 27 Sep 2019 12:51:34 +0000 (13:51 +0100)]
refactor: NORMAL_COLOR() to mutt_curses_set_color()

Encapsulate a curses function to reduce dependencies.

5 years agorefactor: SET_COLOR() to mutt_curses_set_color()
Richard Russon [Fri, 27 Sep 2019 12:49:29 +0000 (13:49 +0100)]
refactor: SET_COLOR() to mutt_curses_set_color()

Encapsulate a curses function to reduce dependencies.

5 years agorefactor: move KeyEvent out of mutt_curses.h
Richard Russon [Fri, 27 Sep 2019 12:16:15 +0000 (13:16 +0100)]
refactor: move KeyEvent out of mutt_curses.h

KeyEvent doesn't belong in mutt_curses.h.

5 years agorefactor: tidy naming of color functions
Richard Russon [Fri, 27 Sep 2019 11:37:23 +0000 (12:37 +0100)]
refactor: tidy naming of color functions

Tidy colour functions for consistency.

5 years agorefactor: move colour definitions to color.h
Richard Russon [Fri, 27 Sep 2019 11:29:19 +0000 (12:29 +0100)]
refactor: move colour definitions to color.h

The colour defines and structures don't depend on curses.

5 years agorefactor: eliminate curses from Progress Bar
Richard Russon [Fri, 27 Sep 2019 23:18:37 +0000 (00:18 +0100)]
refactor: eliminate curses from Progress Bar

Change the Progress Bar to use the MuttMessageWindow rather than writing
to absolute screen coordinates.

5 years agoiwyu: backtrace
Richard Russon [Tue, 24 Sep 2019 10:31:40 +0000 (11:31 +0100)]
iwyu: backtrace

5 years agoclang-format
Richard Russon [Mon, 23 Sep 2019 16:55:42 +0000 (17:55 +0100)]
clang-format

5 years agoUnclobber mutt_parse headers 1851/head
Pietro Cerutti [Thu, 12 Sep 2019 13:38:31 +0000 (13:38 +0000)]
Unclobber mutt_parse headers

5 years agoRecurse into subparts when counting attachments
Pietro Cerutti [Thu, 12 Sep 2019 12:52:41 +0000 (12:52 +0000)]
Recurse into subparts when counting attachments

Fixes #1782

5 years agofix empty buffer
Richard Russon [Sat, 21 Sep 2019 18:17:34 +0000 (19:17 +0100)]
fix empty buffer

5 years agomerge: fix coverity defects
Richard Russon [Sat, 21 Sep 2019 17:15:03 +0000 (18:15 +0100)]
merge: fix coverity defects

 * config: expand flags typedef
 * fix Slist usage
 * nntp: check pointers
 * fix pointer checks in generate_body()
 * fix leak in imap_parse_path()
 * fix leak in mutt_attach_mail_sender()
 * fix pointer checks in rfc2047_decode()
 * check the buffer in enriched_putwc()
 * fix var type in text_enriched_handler()
 * check retval of mutt_str_atoui()
 * check the buffer in enriched_puts()
 * ensure that the buffer always exists in mutt_buffer_alloc()

5 years agoensure that the buffer always exists in mutt_buffer_alloc()
Richard Russon [Fri, 20 Sep 2019 13:08:50 +0000 (14:08 +0100)]
ensure that the buffer always exists in mutt_buffer_alloc()