]> granicus.if.org Git - neomutt/log
neomutt
6 years agoadded: :bind, :macro interactive commands 1548/head
Victor Fernandes [Wed, 23 Jan 2019 16:58:45 +0000 (17:58 +0100)]
added: :bind, :macro interactive commands

Display all the active bindings/macros.

Issue #162

6 years agonotmuch: delegate msg_open_new to maildir backend 1547/head
Austin Ray [Thu, 24 Jan 2019 00:45:01 +0000 (19:45 -0500)]
notmuch: delegate msg_open_new to maildir backend

Notmuch delegates several functions to the maildir backend since they
are connected. This commit delegates the notmuch msg_open_new() to the
maildir backend's implementation.

The primary benefit is being able to delete attachments from emails.
Previously, if an attachment was marked for deletion then it was
impossible to exit a virtual mailbox since a write operation could not
complete. This bug has been in Neomutt for a while.

Fixes #673

6 years agoReplace integer parameters with booleans 1564/head
Richard Russon [Sat, 16 Feb 2019 19:56:00 +0000 (19:56 +0000)]
Replace integer parameters with booleans

Several methods used integer parameters to represent boolean values;
replacement with a boolean improves readability.

Affects function/macro(s):
 - mutt_emails_set_flag()
 - mutt_thread_set_flag()
 - mutt_set_flag()

6 years agomerge: refactor/tidy mutt_enter_string_full()
Richard Russon [Tue, 19 Feb 2019 00:48:12 +0000 (00:48 +0000)]
merge: refactor/tidy mutt_enter_string_full()

 * boolify variables
 * use NUL rather than zero
 * reduce scope of variables
 * tidy mutt_enter_string_full()

6 years agotidy mutt_enter_string_full() 1565/head
Richard Russon [Sun, 17 Feb 2019 17:09:19 +0000 (17:09 +0000)]
tidy mutt_enter_string_full()

6 years agoreduce scope of variables
Richard Russon [Sun, 17 Feb 2019 16:53:46 +0000 (16:53 +0000)]
reduce scope of variables

6 years agouse NUL rather than zero
Richard Russon [Sun, 17 Feb 2019 16:17:52 +0000 (16:17 +0000)]
use NUL rather than zero

6 years agoboolify variables
Richard Russon [Sun, 17 Feb 2019 16:16:00 +0000 (16:16 +0000)]
boolify variables

6 years agomerge: refactor/tidy mutt_compose_menu()
Richard Russon [Tue, 19 Feb 2019 00:46:58 +0000 (00:46 +0000)]
merge: refactor/tidy mutt_compose_menu()

 * reduce scope of variables
 * boolify variables
 * fix scoping
 * merge non-overlapping buffer use
 * use NUL rather than zero
 * var scope
 * tidy mutt_compose_menu()

6 years agotidy mutt_compose_menu() 1568/head
Richard Russon [Sun, 17 Feb 2019 14:25:54 +0000 (14:25 +0000)]
tidy mutt_compose_menu()

6 years agovar scope
Richard Russon [Sun, 17 Feb 2019 14:25:30 +0000 (14:25 +0000)]
var scope

6 years agouse NUL rather than zero
Richard Russon [Sun, 17 Feb 2019 13:30:06 +0000 (13:30 +0000)]
use NUL rather than zero

6 years agomerge non-overlapping buffer use
Richard Russon [Sun, 17 Feb 2019 13:27:10 +0000 (13:27 +0000)]
merge non-overlapping buffer use

`buf` and `fname` were never used at the same time, so just use one
temporary buffer.

6 years agofix scoping
Richard Russon [Sun, 17 Feb 2019 13:13:12 +0000 (13:13 +0000)]
fix scoping

- move some }s
- return early, where possible

6 years agoboolify variables
Richard Russon [Sun, 17 Feb 2019 13:07:20 +0000 (13:07 +0000)]
boolify variables

6 years agoreduce scope of variables
Richard Russon [Sun, 17 Feb 2019 12:58:17 +0000 (12:58 +0000)]
reduce scope of variables

6 years agomerge: refactor/tidy mutt_select_file()
Richard Russon [Tue, 19 Feb 2019 00:45:50 +0000 (00:45 +0000)]
merge: refactor/tidy mutt_select_file()

 * use NUL rather than zero
 * boolify variables
 * separate op
 * reduce scope of variables
 * tidy mutt_select_file()

6 years agotidy mutt_select_file() 1566/head
Richard Russon [Sun, 17 Feb 2019 16:00:51 +0000 (16:00 +0000)]
tidy mutt_select_file()

6 years agoreduce scope of variables
Richard Russon [Sun, 17 Feb 2019 15:34:30 +0000 (15:34 +0000)]
reduce scope of variables

6 years agoseparate op
Richard Russon [Sun, 17 Feb 2019 15:47:59 +0000 (15:47 +0000)]
separate op

6 years agoboolify variables
Richard Russon [Sun, 17 Feb 2019 15:34:22 +0000 (15:34 +0000)]
boolify variables

6 years agouse NUL rather than zero
Richard Russon [Sun, 17 Feb 2019 15:33:42 +0000 (15:33 +0000)]
use NUL rather than zero

6 years agomerge: refactor/tidy mutt_pager()
Richard Russon [Tue, 19 Feb 2019 00:44:27 +0000 (00:44 +0000)]
merge: refactor/tidy mutt_pager()

 * reduce scope of loop variables
 * reduce scope of variables
 * tidy mutt_pager()

6 years agotidy mutt_pager() 1563/head
Richard Russon [Sat, 16 Feb 2019 16:35:29 +0000 (16:35 +0000)]
tidy mutt_pager()

6 years agoreduce scope of variables
Richard Russon [Sat, 16 Feb 2019 16:34:51 +0000 (16:34 +0000)]
reduce scope of variables

6 years agoreduce scope of loop variables
Richard Russon [Sat, 16 Feb 2019 16:11:56 +0000 (16:11 +0000)]
reduce scope of loop variables

6 years agomerge: refactor/tidy mutt_index_menu()
Richard Russon [Tue, 19 Feb 2019 00:43:19 +0000 (00:43 +0000)]
merge: refactor/tidy mutt_index_menu()

 * refactor index's check macros
 * reduce scope of loop variables
 * reduce scope of variables
 * tidy mutt_index_menu()

6 years agotidy mutt_index_menu() 1560/head
Richard Russon [Sat, 16 Feb 2019 16:50:03 +0000 (16:50 +0000)]
tidy mutt_index_menu()

6 years agoreduce scope of variables
Richard Russon [Thu, 14 Feb 2019 02:20:46 +0000 (02:20 +0000)]
reduce scope of variables

6 years agoreduce scope of loop variables
Richard Russon [Thu, 14 Feb 2019 02:12:33 +0000 (02:12 +0000)]
reduce scope of loop variables

6 years agorefactor index's check macros
Richard Russon [Tue, 12 Feb 2019 22:31:40 +0000 (22:31 +0000)]
refactor index's check macros

6 years agoupdate list of translatable files
Richard Russon [Tue, 12 Feb 2019 21:36:41 +0000 (21:36 +0000)]
update list of translatable files

[ci skip]

6 years agomerge: trivial code fixes
Richard Russon [Sat, 16 Feb 2019 15:50:10 +0000 (15:50 +0000)]
merge: trivial code fixes

 * boolify Score->exact
 * boolify is_reply()
 * boolify do_locales
 * boolify exact
 * boolify imap_set_flags()
 * doxy: fix typo
 * comp_mbox_close: swap if clauses
 * fix sprintf specifiers
 * fix lgtm alerts

6 years agofix lgtm alerts 1562/head
Richard Russon [Sat, 16 Feb 2019 00:35:04 +0000 (00:35 +0000)]
fix lgtm alerts

Each of the removed tests was redundant.

6 years agofix sprintf specifiers
Richard Russon [Fri, 15 Feb 2019 23:23:35 +0000 (23:23 +0000)]
fix sprintf specifiers

6 years agocomp_mbox_close: swap if clauses
Richard Russon [Fri, 15 Feb 2019 23:14:48 +0000 (23:14 +0000)]
comp_mbox_close: swap if clauses

6 years agodoxy: fix typo
Richard Russon [Fri, 15 Feb 2019 23:07:24 +0000 (23:07 +0000)]
doxy: fix typo

6 years agoboolify imap_set_flags()
Richard Russon [Fri, 15 Feb 2019 23:09:08 +0000 (23:09 +0000)]
boolify imap_set_flags()

6 years agoboolify exact
Richard Russon [Sat, 16 Feb 2019 12:45:22 +0000 (12:45 +0000)]
boolify exact

6 years agoboolify do_locales
Richard Russon [Sat, 16 Feb 2019 12:44:13 +0000 (12:44 +0000)]
boolify do_locales

6 years agoboolify is_reply()
Richard Russon [Fri, 15 Feb 2019 23:07:02 +0000 (23:07 +0000)]
boolify is_reply()

6 years agoboolify Score->exact
Richard Russon [Fri, 15 Feb 2019 23:04:32 +0000 (23:04 +0000)]
boolify Score->exact

6 years agolgtm: add config
Richard Russon [Sat, 16 Feb 2019 13:38:11 +0000 (13:38 +0000)]
lgtm: add config

6 years agofix mailbox size
Richard Russon [Wed, 13 Feb 2019 13:51:18 +0000 (13:51 +0000)]
fix mailbox size

When re-opening a mailbox, the size wasn't being reset.

6 years agomerge: trivial code fixes
Richard Russon [Fri, 8 Feb 2019 20:25:16 +0000 (20:25 +0000)]
merge: trivial code fixes

 * fix spelling
 * compare integers against 0
 * standardise naming in B64Context
 * standardise naming in ComposeRedrawData
 * standardise naming in FgetConv
 * standardise naming in Group
 * standardise naming in ImapHeader
 * standardise naming in MailboxNode
 * standardise naming in Pattern
 * standardise naming in SslSockData
 * standardise naming in Pager
 * simplify bitfields in Mailbox
 * simplify bitfields in ImapAccountData
 * simplify bitfields in smtp
 * drop bitfields
 * doxy: mark all out-params
 * tidy mutt_folder_hook
 * index.c move data
 * tidy reopen_mailbox
 * doxy: add comment blocks
 * iwyu
 * boolify variables
 * doxy: fix typo
 * fix param names
 * rename pop_adata_get
 * eliminate asymmetric quotes
 * reduce variable scope

6 years agoreduce variable scope
Richard Russon [Fri, 8 Feb 2019 19:55:42 +0000 (19:55 +0000)]
reduce variable scope

6 years agoeliminate asymmetric quotes
Richard Russon [Fri, 8 Feb 2019 19:46:05 +0000 (19:46 +0000)]
eliminate asymmetric quotes

6 years agorename pop_adata_get
Richard Russon [Fri, 8 Feb 2019 19:25:29 +0000 (19:25 +0000)]
rename pop_adata_get

6 years agofix param names
Richard Russon [Fri, 8 Feb 2019 19:17:27 +0000 (19:17 +0000)]
fix param names

6 years agodoxy: fix typo
Richard Russon [Fri, 8 Feb 2019 19:15:05 +0000 (19:15 +0000)]
doxy: fix typo

6 years agoboolify variables
Richard Russon [Fri, 8 Feb 2019 19:15:00 +0000 (19:15 +0000)]
boolify variables

6 years agoiwyu
Richard Russon [Wed, 9 Jan 2019 23:18:47 +0000 (23:18 +0000)]
iwyu

6 years agodoxy: add comment blocks
Richard Russon [Tue, 5 Feb 2019 20:28:40 +0000 (20:28 +0000)]
doxy: add comment blocks

6 years agotidy reopen_mailbox
Richard Russon [Fri, 18 Jan 2019 02:39:58 +0000 (02:39 +0000)]
tidy reopen_mailbox

6 years agoindex.c move data
Richard Russon [Fri, 18 Jan 2019 02:32:41 +0000 (02:32 +0000)]
index.c move data

6 years agotidy mutt_folder_hook
Richard Russon [Fri, 18 Jan 2019 02:30:43 +0000 (02:30 +0000)]
tidy mutt_folder_hook

6 years agodoxy: mark all out-params
Richard Russon [Mon, 4 Feb 2019 02:31:47 +0000 (02:31 +0000)]
doxy: mark all out-params

6 years agodrop bitfields
Richard Russon [Mon, 21 Jan 2019 23:34:47 +0000 (23:34 +0000)]
drop bitfields

6 years agosimplify bitfields in smtp
Richard Russon [Mon, 21 Jan 2019 23:31:59 +0000 (23:31 +0000)]
simplify bitfields in smtp

6 years agosimplify bitfields in ImapAccountData
Richard Russon [Mon, 21 Jan 2019 23:21:10 +0000 (23:21 +0000)]
simplify bitfields in ImapAccountData

6 years agosimplify bitfields in Mailbox
Richard Russon [Mon, 21 Jan 2019 22:52:26 +0000 (22:52 +0000)]
simplify bitfields in Mailbox

6 years agostandardise naming in Pager
Richard Russon [Fri, 18 Jan 2019 02:14:15 +0000 (02:14 +0000)]
standardise naming in Pager

6 years agostandardise naming in SslSockData
Richard Russon [Fri, 18 Jan 2019 02:12:13 +0000 (02:12 +0000)]
standardise naming in SslSockData

6 years agostandardise naming in Pattern
Richard Russon [Fri, 18 Jan 2019 02:09:51 +0000 (02:09 +0000)]
standardise naming in Pattern

6 years agostandardise naming in MailboxNode
Richard Russon [Fri, 18 Jan 2019 02:07:17 +0000 (02:07 +0000)]
standardise naming in MailboxNode

6 years agostandardise naming in ImapHeader
Richard Russon [Fri, 18 Jan 2019 02:01:21 +0000 (02:01 +0000)]
standardise naming in ImapHeader

6 years agostandardise naming in Group
Richard Russon [Fri, 18 Jan 2019 01:52:15 +0000 (01:52 +0000)]
standardise naming in Group

6 years agostandardise naming in FgetConv
Richard Russon [Fri, 18 Jan 2019 01:47:49 +0000 (01:47 +0000)]
standardise naming in FgetConv

6 years agostandardise naming in ComposeRedrawData
Richard Russon [Fri, 18 Jan 2019 01:44:47 +0000 (01:44 +0000)]
standardise naming in ComposeRedrawData

6 years agostandardise naming in B64Context
Richard Russon [Fri, 18 Jan 2019 01:43:16 +0000 (01:43 +0000)]
standardise naming in B64Context

6 years agocompare integers against 0
Richard Russon [Thu, 17 Jan 2019 19:58:57 +0000 (19:58 +0000)]
compare integers against 0

6 years agofix spelling
Richard Russon [Tue, 5 Feb 2019 17:55:56 +0000 (17:55 +0000)]
fix spelling

6 years agomerge: more Context elimination
Richard Russon [Fri, 8 Feb 2019 16:35:52 +0000 (16:35 +0000)]
merge: more Context elimination

 * add EmailList for tagged Emails
 * refactor edit_or_view_one_message
 * mutt_ev_message: factor out Context
 * bounce_message: factor out Context
 * mutt_check_traditional_pgp: factor out Context
 * crypt_extract_keys_from_messages: factor out Context
 * mutt_link_threads: factor out Context
 * mutt_label_message: factor out Context
 * pipe_msg: add Mailbox param
 * pipe_message: factor out Context
 * mutt_save_message: factor out Context
 * mutt_change_flag: factor out Context
 * ci_send_message: factor Context out of mutt_make_string()
 * ci_send_message: factor out Context
 * ci_send_message: factor Context out of dependents
 * mutt_mailbox_check: factor out Context
 * mx_mbox_sync
 * add mx_path_resolve()
 * mx_mbox_open: drop path param
 * factor out PostContext
 * tidy code
 * tidy Email variables
 * move parse_mailboxes()

6 years agomove parse_mailboxes()
Richard Russon [Sun, 20 Jan 2019 16:46:19 +0000 (16:46 +0000)]
move parse_mailboxes()

This function has dependencies on Context and inotify().

6 years agotidy Email variables
Richard Russon [Sat, 19 Jan 2019 16:53:56 +0000 (16:53 +0000)]
tidy Email variables

6 years agotidy code
Richard Russon [Sat, 19 Jan 2019 15:52:39 +0000 (15:52 +0000)]
tidy code

Non-functional changes

6 years agofactor out PostContext
Richard Russon [Sat, 19 Jan 2019 16:19:08 +0000 (16:19 +0000)]
factor out PostContext

6 years agomx_mbox_open: drop path param
Richard Russon [Sat, 5 Jan 2019 12:50:27 +0000 (12:50 +0000)]
mx_mbox_open: drop path param

6 years agoadd mx_path_resolve()
Richard Russon [Fri, 28 Dec 2018 14:51:34 +0000 (14:51 +0000)]
add mx_path_resolve()

6 years agomx_mbox_sync
Richard Russon [Sun, 13 Jan 2019 15:39:26 +0000 (15:39 +0000)]
mx_mbox_sync

6 years agomutt_mailbox_check: factor out Context
Richard Russon [Sun, 13 Jan 2019 15:05:15 +0000 (15:05 +0000)]
mutt_mailbox_check: factor out Context

6 years agoci_send_message: factor Context out of dependents
Richard Russon [Sat, 12 Jan 2019 00:34:23 +0000 (00:34 +0000)]
ci_send_message: factor Context out of dependents

6 years agoci_send_message: factor out Context
Richard Russon [Fri, 11 Jan 2019 21:51:53 +0000 (21:51 +0000)]
ci_send_message: factor out Context

6 years agoci_send_message: factor Context out of mutt_make_string()
Richard Russon [Fri, 11 Jan 2019 14:30:09 +0000 (14:30 +0000)]
ci_send_message: factor Context out of mutt_make_string()

6 years agomutt_change_flag: factor out Context
Richard Russon [Fri, 11 Jan 2019 11:58:51 +0000 (11:58 +0000)]
mutt_change_flag: factor out Context

6 years agomutt_save_message: factor out Context
Richard Russon [Fri, 11 Jan 2019 10:51:12 +0000 (10:51 +0000)]
mutt_save_message: factor out Context

6 years agopipe_message: factor out Context
Richard Russon [Fri, 11 Jan 2019 01:56:56 +0000 (01:56 +0000)]
pipe_message: factor out Context

6 years agopipe_msg: add Mailbox param
Richard Russon [Thu, 10 Jan 2019 20:48:30 +0000 (20:48 +0000)]
pipe_msg: add Mailbox param

6 years agomutt_label_message: factor out Context
Richard Russon [Thu, 10 Jan 2019 15:49:22 +0000 (15:49 +0000)]
mutt_label_message: factor out Context

6 years agomutt_link_threads: factor out Context
Richard Russon [Thu, 10 Jan 2019 15:27:30 +0000 (15:27 +0000)]
mutt_link_threads: factor out Context

6 years agocrypt_extract_keys_from_messages: factor out Context
Richard Russon [Thu, 10 Jan 2019 14:51:13 +0000 (14:51 +0000)]
crypt_extract_keys_from_messages: factor out Context

6 years agomutt_check_traditional_pgp: factor out Context
Richard Russon [Thu, 10 Jan 2019 14:26:15 +0000 (14:26 +0000)]
mutt_check_traditional_pgp: factor out Context

6 years agobounce_message: factor out Context
Richard Russon [Tue, 8 Jan 2019 18:21:02 +0000 (18:21 +0000)]
bounce_message: factor out Context

6 years agomutt_ev_message: factor out Context
Richard Russon [Thu, 10 Jan 2019 13:44:17 +0000 (13:44 +0000)]
mutt_ev_message: factor out Context

6 years agorefactor edit_or_view_one_message
Richard Russon [Thu, 10 Jan 2019 13:40:05 +0000 (13:40 +0000)]
refactor edit_or_view_one_message

6 years agoadd EmailList for tagged Emails
Richard Russon [Mon, 31 Dec 2018 16:21:20 +0000 (16:21 +0000)]
add EmailList for tagged Emails

6 years agoMap SASL loglevels to neomutt loglevels
Ian Zimmerman [Thu, 7 Feb 2019 21:38:08 +0000 (13:38 -0800)]
Map SASL loglevels to neomutt loglevels

6 years agofixed: sort_browser attribute modified after sorting
Victor Fernandes [Sat, 2 Feb 2019 19:37:31 +0000 (20:37 +0100)]
fixed: sort_browser attribute modified after sorting

sort_browser has modified after calling browser_sort,
which means the first time sort is called it uses the old
sort method instead of the new one.

Fixes #1551

6 years agosplit up 'update' and 'resort' notifications
Richard Russon [Thu, 24 Jan 2019 02:04:30 +0000 (02:04 +0000)]
split up 'update' and 'resort' notifications

Fixes #1546

6 years agofix: crash with short attachment name
Pietro Cerutti [Wed, 23 Jan 2019 12:10:57 +0000 (12:10 +0000)]
fix: crash with short attachment name