]> granicus.if.org Git - handbrake/log
handbrake
7 years agonlmeans: fix prefilter passthru 1.0.x
John Stebbins [Tue, 30 May 2017 21:41:16 +0000 (14:41 -0700)]
nlmeans: fix prefilter passthru

This is an error that crept in when making nlmeans multithreaded

(cherry picked from commit 29a49a83a61885141d0062a850cee3cb90106f20)

7 years agopreset: Fix surround audio bitrate for general presets.
Bradley Sepos [Sun, 21 May 2017 19:32:06 +0000 (15:32 -0400)]
preset: Fix surround audio bitrate for general presets.

Was supposed to be 640 when converting a non-AC3 source track.

(cherry picked from commit e22fbb1a0faa3513dfdfbdd796f31c03df6e86bb)

7 years agoencavcodecaudio: work around lame bug
John Stebbins [Thu, 11 May 2017 20:17:51 +0000 (13:17 -0700)]
encavcodecaudio: work around lame bug

On windows builds, there is an upstream bug in the lame
encoder that causes an extra output packet that has the same
timestamp as the second to last packet.  This causes an error
during muxing. Drop the packet with the duplicate timestamp.

Fixes https://github.com/HandBrake/HandBrake/issues/726

(cherry picked from commit 7f17f5c08129a39da12352828d6ec145dc448261)

7 years agoWinGui: Fix an issue with long chapters causing scans to fail to complete. Fixes...
sr55 [Tue, 2 May 2017 19:37:20 +0000 (20:37 +0100)]
WinGui: Fix an issue with long chapters causing scans to fail to complete. Fixes #713

7 years agoWinGui: Bump version to 1.0.8
sr55 [Sat, 29 Apr 2017 18:33:46 +0000 (19:33 +0100)]
WinGui: Bump version to 1.0.8

7 years agoWinGui: Save file before committing :( #695
sr55 [Sat, 29 Apr 2017 18:32:50 +0000 (19:32 +0100)]
WinGui:  Save file before committing :(  #695

7 years agoWinGui: Fix a possible exception when cancelling and rescanning a source that would...
sr55 [Sun, 16 Apr 2017 09:59:40 +0000 (10:59 +0100)]
WinGui: Fix a possible exception when cancelling and rescanning a source that would cause it to never complete the second time. Fixes #671

7 years agoWinGui: Change to the queue duplicate detection. It currently filters by "Waiting...
sr55 [Sat, 29 Apr 2017 18:28:12 +0000 (19:28 +0100)]
WinGui: Change to the queue duplicate detection. It currently filters by "Waiting" tasks. This now extends that to "In Progress".  "Completed/Error" will continue to allow jobs to be added to the queue. Fixes #695

7 years agoWinGui: Change a message box to an error window when exceptions occur in setting...
sr55 [Sat, 29 Apr 2017 17:27:20 +0000 (18:27 +0100)]
WinGui:  Change a message box to an error window when exceptions occur in setting the destination.

7 years agoscripts: Update to mingw-w64-build 2.3.2.
Bradley Sepos [Fri, 28 Apr 2017 23:20:32 +0000 (19:20 -0400)]
scripts: Update to mingw-w64-build 2.3.2.

(cherry picked from commit 7724e874eb3f59818fca238316fbbe6751f71290)

7 years agostream: fix chapter marker durations
John Stebbins [Fri, 28 Apr 2017 17:29:54 +0000 (10:29 -0700)]
stream: fix chapter marker durations

libav isn't guaranteed to set AVChapter.end.  So don't use it.  Use
AVChapter.start instead.

(cherry picked from commit e590bf7c94592b4351e57db5f66fedb7e7e8e3af)

7 years agoFixed IRC link in README.markdown (#712)
aaronjeline [Thu, 27 Apr 2017 19:13:07 +0000 (15:13 -0400)]
Fixed IRC link in README.markdown (#712)

* Fixed IRC link in README.markdown

(cherry picked from commit 7c4534a272025a74f598f9b8ea48df25f9bf9637)

7 years agoWinGui: Fix for 1.0.x for previous cherry pick.
sr55 [Sun, 23 Apr 2017 18:57:43 +0000 (19:57 +0100)]
WinGui: Fix for 1.0.x for previous cherry pick.

7 years agoWinGui: Change the default behaviour for the WinGui to automatically use fallback...
sr55 [Wed, 22 Mar 2017 21:16:21 +0000 (21:16 +0000)]
WinGui: Change the default behaviour for the WinGui to automatically use fallback track in situations where the selected passthru is not valid.   The UI will by default select the fallback now.  Fixes #646

7 years agoMacGui: NSUUID is not available on 10.7, replace it with CFUUIDRef
Damiano Galassi [Fri, 21 Apr 2017 11:47:20 +0000 (13:47 +0200)]
MacGui: NSUUID is not available on 10.7, replace it with CFUUIDRef

(cherry picked from commit bc092457f1409c7d014bbdd3fbd65db0340244bf)

7 years agoLinGui: fix POTFILE list
John Stebbins [Wed, 19 Apr 2017 17:27:23 +0000 (10:27 -0700)]
LinGui: fix POTFILE list

When I changed a file name I forgot to change this list.
This list is used to generate the translation template file.

(cherry picked from commit 1cbd2f5a33ee8efadf6377da55bd6cb33a31608b)

7 years agoavfilter: fix handling of bad settings
John Stebbins [Fri, 14 Apr 2017 23:13:38 +0000 (17:13 -0600)]
avfilter: fix handling of bad settings

After encountering a bad setting, it was removing all filters starting
with the one with bad settings.

(cherry picked from commit a0fefdaf374c7e7b0bbf58482b86bac03d673a7c)

7 years agopreset: fix audio settings when samplerate == auto
Damiano Galassi [Fri, 14 Apr 2017 16:38:45 +0000 (18:38 +0200)]
preset: fix audio settings when samplerate == auto

(cherry picked from commit 568aa3826cd15afc375c2f8ba3d9649dfcecaddc)

7 years agoMacGui: fix auto mixdown.
Damiano Galassi [Thu, 13 Apr 2017 06:10:15 +0000 (08:10 +0200)]
MacGui: fix auto mixdown.

(cherry picked from commit e568d96f313009f5dd32bd850a48b9ac1a37a56b)

7 years agopreset: fix sanitizing audio settings when samplerate != Auto
John Stebbins [Wed, 12 Apr 2017 19:22:24 +0000 (13:22 -0600)]
preset: fix sanitizing audio settings when samplerate != Auto

The samplerate was incorrectly copied to the job as a string instead of
an int which caused invalid sanitizing of audio settings.

(cherry picked from commit 9a22ae2b2715b088cd936ba5e7d700ee4fbea096)

7 years agolibav: fix h264 decode error
John Stebbins [Tue, 11 Apr 2017 19:25:51 +0000 (13:25 -0600)]
libav: fix h264 decode error

Fixes https://github.com/HandBrake/HandBrake/issues/602

(cherry picked from commit 420f90fe9efdb44049f783f93f6378f7785e532d)

7 years agoscan: enable HBTF_NO_IDR when not enough previews found
John Stebbins [Tue, 11 Apr 2017 18:23:56 +0000 (12:23 -0600)]
scan: enable HBTF_NO_IDR when not enough previews found

Setting this flag signals to libav to not wait for IDR or recovery
points before returning frames to us.  Some videos have neither IDRs or
recovery points, so this fixes transcoding such video.

Fixes https://github.com/HandBrake/HandBrake/issues/456

(cherry picked from commit 7e346baaa3ce8df0b03ab64ce78434aa68a8b5d3)

7 years agoUpdate NEWS.markdown for HandBrake 1.0.7 release. 1.0.7
Bradley Sepos [Sun, 9 Apr 2017 20:23:36 +0000 (16:23 -0400)]
Update NEWS.markdown for HandBrake 1.0.7 release.

Really.

(cherry picked from commit 43b9078916d7f12fd853e28e9574f93fb24e68d9)

7 years agoWinGui: Remove fonts directory from installer.
sr55 [Sun, 26 Mar 2017 11:19:05 +0000 (12:19 +0100)]
WinGui: Remove fonts directory from installer.

7 years agoWinGui: Version 1.0.7
sr55 [Sun, 9 Apr 2017 20:22:42 +0000 (21:22 +0100)]
WinGui: Version 1.0.7

7 years agoUpdate NEWS.markdown for 1.0.6 release. 1.0.6
Bradley Sepos [Sun, 9 Apr 2017 20:01:06 +0000 (16:01 -0400)]
Update NEWS.markdown for 1.0.6 release.

Hopefully.

(cherry picked from commit b55ce7b569ff1ec3702a5962bb15eded2777ebba)

7 years agoBuild: Fix to the build scripts to no longer include font directory in mingw builds...
sr55 [Fri, 24 Mar 2017 21:05:20 +0000 (21:05 +0000)]
Build: Fix to the build scripts to no longer include font directory in mingw builds. It's no longer needed.

7 years agoUpdate NEWS.markdown for 1.0.5 release. 1.0.5
Bradley Sepos [Sun, 9 Apr 2017 19:14:52 +0000 (15:14 -0400)]
Update NEWS.markdown for 1.0.5 release.

(cherry picked from commit 2c9e2022ba8f286eea226fc9ae4054fba33e509a)

7 years agoHarfBuzz: disable Fontconfig (#609)
Oleg Oshmyan [Fri, 10 Mar 2017 19:54:32 +0000 (21:54 +0200)]
HarfBuzz: disable Fontconfig (#609)

HarfBuzz uses Fontconfig only in command-line utilities, which we don't need.
(cherry picked from commit 1f6c91c00be0f8f47de1d5c77b945ad6ecd50ec5)

7 years agoWinGui: Bump Version numbers to 1.0.5
sr55 [Sun, 9 Apr 2017 19:03:41 +0000 (20:03 +0100)]
WinGui: Bump Version numbers to 1.0.5

7 years agoRemove Fontconfig on Windows (#610)
Oleg Oshmyan [Sun, 12 Mar 2017 16:31:36 +0000 (18:31 +0200)]
Remove Fontconfig on Windows (#610)

* Remove Fontconfig on Windows

Let libass use its DirectWrite font provider backend instead of Fontconfig.
This eliminates Fontconfig's font cache generation delay that occurred
at the start of an encode after a system font was (un)installed or when
HandBrake was installed and used to burn text subtitles for the first time.

* Remove LibHB's dependency on Fontconfig when it's not used

(cherry picked from commit bd78a82b032a48d9f382c56ddc72529a047c0893)

7 years agodisable fontconfig on macOS
Damiano Galassi [Wed, 18 Jan 2017 09:47:13 +0000 (10:47 +0100)]
disable fontconfig on macOS

(cherry picked from commit 81550230adc2359d7ec4f5cff6a5c960b7df7e6e)

7 years agoLinGui: add Ubuntu Zesty nightly builds 1.0.4
John Stebbins [Sun, 9 Apr 2017 18:11:23 +0000 (12:11 -0600)]
LinGui: add Ubuntu Zesty nightly builds

(cherry picked from commit 183e0c71691453e39f1908562532c645161f6a30)

7 years agoUpdate NEWS.markdown for 1.0.4 release.
Bradley Sepos [Sun, 9 Apr 2017 17:55:47 +0000 (13:55 -0400)]
Update NEWS.markdown for 1.0.4 release.

(cherry picked from commit 4607c3d2720c1337085b1d641fa4d16601ed71c3)

7 years agoFix raw video timestamps
John Stebbins [Sun, 9 Apr 2017 16:33:26 +0000 (10:33 -0600)]
Fix raw video timestamps

Raw video has no timestamps. But we drop frames in sync that have no
timestamps.  So detect raw video and extrapolate timestamps from
framerate.

(cherry picked from commit 3b080f5c7d5c1aa8ac80a37a8adb5db0a60b6aae)

7 years agoscripts: Update to mingw-w64-build 2.3.1.
Bradley Sepos [Wed, 29 Mar 2017 20:24:22 +0000 (16:24 -0400)]
scripts: Update to mingw-w64-build 2.3.1.

Resolves an issue building libgmp on newer Linux distros with hardened GCC.

(cherry picked from commit 9884aa1ddc93450504ff59652c1265b35190aba3)

7 years agoLinGui: fix application of SRT offset
John Stebbins [Wed, 29 Mar 2017 16:44:51 +0000 (10:44 -0600)]
LinGui: fix application of SRT offset

(cherry picked from commit b5714363107a3ee189c92931d5687a19f48f6d95)

7 years agoCLI: don't override preset subtitle burn defaults...
John Stebbins [Wed, 22 Mar 2017 18:24:03 +0000 (11:24 -0700)]
CLI: don't override preset subtitle burn defaults...

Unless user explicitly overrides with command line options

(cherry picked from commit 21aceef60d6dcdd5f523fbae21357c666b9d7f6d)

7 years agoActually set Fontconfig configuration path (#611)
Oleg Oshmyan [Fri, 10 Mar 2017 19:53:33 +0000 (21:53 +0200)]
Actually set Fontconfig configuration path (#611)

Option --with-fcpath does not exist and never did.
We had a patch that added it, but the patch has been removed.
Use the standard option instead.
(cherry picked from commit abe8b106dc881aa1e7e0c6f0b57f21795b98afa3)

7 years agoqsv: fixing variable re-use (#627)
maximd33 [Tue, 14 Mar 2017 23:22:31 +0000 (00:22 +0100)]
qsv: fixing variable re-use (#627)

Closes #625.

(cherry picked from commit 3354623c7f59e95b88d769b9e62fff28ff857b9a)

7 years agoopencl: cleaning more leaks (#628)
maximd33 [Tue, 14 Mar 2017 23:20:29 +0000 (00:20 +0100)]
opencl: cleaning more leaks (#628)

opencl: cleaning more leaks
(cherry picked from commit b9c8213164cb018bd3abab41d3f424e8c444d68e)

7 years agoLinGui: fix audio copy mask updates
John Stebbins [Sun, 12 Mar 2017 19:50:25 +0000 (13:50 -0600)]
LinGui: fix audio copy mask updates

Updates to the mask would not be applied till it was saved to a preset

(cherry picked from commit 35cf0e22cd51157e249414e824b2cc66151104d4)

7 years agotext subs: use generic font family names (#614)
John Stebbins [Fri, 10 Mar 2017 19:47:50 +0000 (12:47 -0700)]
text subs: use generic font family names (#614)

* text subs: use generic font family names

Allows the platform more flexibility in choosing the "best" font for the
platform.

* rendersub: make font configurable per platform

Use Lucida Console for mono font on windows since it chooses ugly,
difficult to read Courier New when using monospace family name.

(cherry picked from commit 65e24973e7deff59f93caabd1d561c8d0d2e9163)

7 years agoLinGui: Update translations
John Stebbins [Sun, 12 Mar 2017 17:17:16 +0000 (11:17 -0600)]
LinGui: Update translations

New translations come from transifex HandBrake 1.0.0 project.
https://ataaw.transifex.com/victorr2007/handbrake-100/

7 years agoopencl: fixing more resource leaks
maxd [Fri, 10 Mar 2017 10:03:57 +0000 (11:03 +0100)]
opencl: fixing more resource leaks

(cherry picked from commit 69231c990576f34c14054a6f81b09b5a445d1b47)

7 years agoLinGui: fix video preset slider updates
John Stebbins [Thu, 9 Mar 2017 19:39:47 +0000 (12:39 -0700)]
LinGui: fix video preset slider updates

Fixes https://github.com/HandBrake/HandBrake/issues/621

(cherry picked from commit 6c8979904ca729d086b7ccebd6b4f5cabd31149d)

7 years agoopencl: Fix resource leak.
maxd [Wed, 8 Mar 2017 19:08:32 +0000 (20:08 +0100)]
opencl: Fix resource leak.

Closes #617 and closes #618.

(cherry picked from commit 27c5b91e916e51c0d44dc0fd111feca43a4ea481)

7 years agolibav: a more robust fix for aac encoder crash
John Stebbins [Wed, 8 Mar 2017 16:31:14 +0000 (09:31 -0700)]
libav: a more robust fix for aac encoder crash

(cherry picked from commit acf986e8df2e8084f50d684a0aa98329f8c77cab)

7 years agoWinGui: Another fix to WhenDone. Should reset when the main window opens, not when...
sr55 [Mon, 23 Jan 2017 21:00:15 +0000 (21:00 +0000)]
WinGui: Another fix to WhenDone. Should reset when the main window opens, not when preferences opens.

7 years agosync: fix small video dejitter error
John Stebbins [Fri, 3 Mar 2017 21:19:36 +0000 (14:19 -0700)]
sync: fix small video dejitter error

This very small error snowballs into a crash in x264 :-p

If the amount of jitter on the first frame in the queue was small
(about 1 tick) then jitter would not be removed from that frame.
This extra tick of jitter can appear on different frames depending
on when frame arrives and how much has been queued.  This very small
amount of randomness lead to problems in the VFR filter.  A frame
duration difference as small as 1 tick can lead to an extra frame
getting duplicated when doing CFR.  When doing 2 pass encoding, this
extra frame causes x264 to crash at the end of the 2nd pass.

(cherry picked from commit 31d0389758bd506a6c349d85c0d3191880d0dea4)

7 years agolibav: simplify patch for corrupt raw video
John Stebbins [Wed, 1 Mar 2017 15:00:15 +0000 (08:00 -0700)]
libav: simplify patch for corrupt raw video

(cherry picked from commit a7d96f24f2c8df6b1092d4376c436e6d63514bdb)

7 years agowork: set orig_vrate correctly
John Stebbins [Tue, 28 Feb 2017 21:59:06 +0000 (14:59 -0700)]
work: set orig_vrate correctly

It was getting set to the title's rate instead of the rate that the
filter chain sets.

An incorrect vrate causes x265 rate control breakage.

Fixes https://github.com/HandBrake/HandBrake/issues/600

(cherry picked from commit 872aee88cd477d082a36124e83205689999d2527)

7 years agoWinGui: Bump version number to 1.0.4
sr55 [Mon, 27 Feb 2017 19:25:06 +0000 (19:25 +0000)]
WinGui: Bump version number to 1.0.4

7 years agolibav: gracefully handle a broken AVI index
John Stebbins [Mon, 27 Feb 2017 19:01:35 +0000 (12:01 -0700)]
libav: gracefully handle a broken AVI index

Fixes https://github.com/HandBrake/HandBrake/issues/439

(cherry picked from commit 40b86f9ad509db29be0babb335e96f62b0b1c230)

7 years agolibav: fix rawvideo in mkv corruption
John Stebbins [Sun, 26 Feb 2017 23:39:59 +0000 (16:39 -0700)]
libav: fix rawvideo in mkv corruption

fixes https://github.com/HandBrake/HandBrake/issues/128

(cherry picked from commit b2f8318069349d161d8c0f1afcb753f5513a3794)

7 years agoRevise NEWS.markdown for 1.0.3. 1.0.3
Bradley Sepos [Sat, 25 Feb 2017 20:56:07 +0000 (15:56 -0500)]
Revise NEWS.markdown for 1.0.3.

(cherry picked from commit e634da436b20fe05dba4fdfd8389cf11f40bdc8d)

7 years agoUpdate NEWS
sr55 [Sat, 25 Feb 2017 18:33:35 +0000 (18:33 +0000)]
Update NEWS

7 years agoaudio_resample: fix mapping of mono to single channel (#593)
John Stebbins [Fri, 24 Feb 2017 17:28:33 +0000 (10:28 -0700)]
audio_resample: fix mapping of mono to single channel (#593)

* audio_resample: fix mapping of mono to single channel

libav's mixer code can't map single channel layouts to other single
channel layouts. And we were asking it to map e.g. front left to front
center because out MONO mixdown == libav front center.  So when we
request MONO and the source is any single channel, change our output
layout to match the input.

fixes
https://forum.handbrake.fr/viewtopic.php?f=12&t=36016&sid=c5993fa7375792a940152c8adda19a54

* Incorporate Rodeo's suggestions

* fix grammar

(cherry picked from commit b7882e031c91817da3d69df9968656904c4f9640)

7 years agolibav: fix latm aac decoder hang
John Stebbins [Fri, 24 Feb 2017 00:39:06 +0000 (17:39 -0700)]
libav: fix latm aac decoder hang

Don't return EAGAIN from decoders.

When waiting for codec parameters, the decoder returned EAGAIN which was
meant to be interpreted as "send more data". But the new libav decoder
API changed the definition of EAGAIN to mean "send the same packet
again".  So hang.

(cherry picked from commit d1333595bc9ffb3b2445bc7cf530ff6c86eceb38)

7 years agolibav: fix reading wmv larger than 2G
John Stebbins [Fri, 24 Feb 2017 00:09:23 +0000 (17:09 -0700)]
libav: fix reading wmv larger than 2G

fixes https://github.com/HandBrake/HandBrake/issues/587

(cherry picked from commit bc86d4239a196237c920dbd824b44f4122a935a7)

7 years agolibav: fix crash when encoding aac at high bitrate
John Stebbins [Thu, 23 Feb 2017 22:49:25 +0000 (15:49 -0700)]
libav: fix crash when encoding aac at high bitrate

Fixes https://github.com/HandBrake/HandBrake/issues/510

7 years agoencx265: fix compiler warning
John Stebbins [Wed, 22 Feb 2017 22:17:34 +0000 (15:17 -0700)]
encx265: fix compiler warning

(cherry picked from commit 6aebad79439a64738db685bd9c7c442493e49233)

7 years agoencx265: fix 2 pass encoding when framerate is wrong
John Stebbins [Wed, 22 Feb 2017 20:33:16 +0000 (13:33 -0700)]
encx265: fix 2 pass encoding when framerate is wrong

x265 expects the framerate specified to be the same for both passes. So
we must set the same value even when we compute that the actual
framerate differs from what the file's header says.

(cherry picked from commit ac73d24c799292fd6493ef1ce83816fa35c24a6d)

7 years agolibav: fix mkv seek crash
John Stebbins [Tue, 21 Feb 2017 22:38:53 +0000 (15:38 -0700)]
libav: fix mkv seek crash

Remove hopelessly broken code that attempted to rewind the seek point to
a position in the file where subtitles in every subtitle track after
the seek time are after the computed position.

(cherry picked from commit 380059d4d8cf245e3667a5c92159f7b294d682ac)

7 years agoopencl: better release of OpenCL context to avoid more leaks
maxd [Thu, 9 Feb 2017 20:04:59 +0000 (21:04 +0100)]
opencl: better release of OpenCL context to avoid more leaks

(cherry picked from commit 514fc4f4ac4312d25680c1fd6c4eab25c5b2551a)

7 years agoopencl: fixing leaks for clBuffers
maxd [Sat, 4 Feb 2017 19:31:31 +0000 (20:31 +0100)]
opencl: fixing leaks for clBuffers

(cherry picked from commit 1ec4c4a4930f49d9d2ae9ca7d76b24cfe267c136)

7 years agopreset: fix application of anamorphic "Off"
John Stebbins [Sun, 19 Feb 2017 15:36:20 +0000 (08:36 -0700)]
preset: fix application of anamorphic "Off"

(cherry picked from commit 429b5d5941bd8f60bc9fa6d74cc23d526c3ef1fa)

7 years agosync: fix sync problem with delayed streams
John Stebbins [Sat, 18 Feb 2017 21:11:17 +0000 (14:11 -0700)]
sync: fix sync problem with delayed streams

If a stream is delayed by a large amount and the first timestamp from
the stream is AV_NOPTS_VALUE, sync assumed a 0 timestamp which caused
loss of sync.  Drop the buffer instead.

(cherry picked from commit 6fec4838373fd50520a2499ff143c50e5d323f9f)

7 years agoFixed Botton to Bottom
supachris28 [Sun, 12 Feb 2017 16:36:26 +0000 (16:36 +0000)]
Fixed Botton to Bottom

7 years agoWinGui: Fix a logic error in 8vs10bit video encoder detection in the advanced view.
sr55 [Fri, 17 Feb 2017 19:11:19 +0000 (19:11 +0000)]
WinGui: Fix a logic error in 8vs10bit video encoder detection in the advanced view.

7 years agolibav: fix mp4 edit list A/V sync properly
John Stebbins [Wed, 15 Feb 2017 19:22:48 +0000 (12:22 -0700)]
libav: fix mp4 edit list A/V sync properly

(cherry picked from commit 7196e488673c9bfa8f6a626121379885665bd886)

7 years agolibav: fix failure to scan wmv file
John Stebbins [Wed, 15 Feb 2017 17:37:02 +0000 (10:37 -0700)]
libav: fix failure to scan wmv file

Fixes problem reported here
https://forum.handbrake.fr/viewtopic.php?f=11&t=35690

Also possibly related
https://github.com/HandBrake/HandBrake/issues/466
https://github.com/HandBrake/HandBrake/issues/495

(cherry picked from commit 396249d1e7231b961fc3fe53b2f25743a832f3b6)

7 years agolibav: fix crash when scanning wmv file
John Stebbins [Wed, 15 Feb 2017 17:29:39 +0000 (10:29 -0700)]
libav: fix crash when scanning wmv file

Fixes crash reported here
https://forum.handbrake.fr/viewtopic.php?f=11&t=35690

Does not fix scan problem, but follow-up commit will.

Also possibly related
https://github.com/HandBrake/HandBrake/issues/466
https://github.com/HandBrake/HandBrake/issues/495

(cherry picked from commit 05f743e784fe69e2950d32e8ac177c34a2f3e5c8)

7 years agolibav: fix mp4 audio sync problem
John Stebbins [Fri, 10 Feb 2017 18:26:59 +0000 (11:26 -0700)]
libav: fix mp4 audio sync problem

Initial CTS (composition offset) was essentially getting added twice to
the computed PTS

Fixes https://github.com/HandBrake/HandBrake/issues/568

Here's a description of how mp4 timestamps work and what is going wrong
for the curious.

Terminology:
pts = presentation timestamp, when a frame is displayed
dts = decode timestamp, when a frame is decoded
cts = composition offset, pts - dts
empty edit = defines the pts of the first frame in an mp4 track

mp4 timestamps are computed from 3 primary values that are in the mp4
stream.

    An "empty edit" in the track edit list
    per frame duration
    per frame cts

Here's where things get messy. How do you compute pts(N) and dts(N) for
some frame N from only the above 3 values in the mp4 file?

    empty edit == pts(0) and is read from the mp4 file (EDTS table)
    duration(N) is read from the mp4 file (STTS table)
    cts(N) is read from the mp4 file (CTTS table)

We know cts(0) = pts(0) - dts(0) by definition of cts
And cts(0) and pts(0) are known since they can be read from the mp4 file

This is the step libav gets wrong!
Therefore we can compute dts(0) = pts(0) - cts(0).
libav computes dts(0) = pts(0) which shifts all frames by cts(0)

After that dts(N) = dts(0) + duration(0) + ... + duration(N-1)
And finally pts(N) = dts(N) + cts(N)

(cherry picked from commit 88343d5a0ee9969071bb8a263dab0e0a66c4c8ff)

7 years agoLinGui: fix crash when changing video encoders
John Stebbins [Fri, 10 Feb 2017 17:53:11 +0000 (10:53 -0700)]
LinGui: fix crash when changing video encoders

Attempt to access invalid encoder preset index accesses invalid memory

(cherry picked from commit 62439a3e43484ed0ae9e7ecd01b7b19760cdfd2f)

7 years agoWinGui: Fix Tape, Sprite and HighMotion Denoise Tunes. #571
sr55 [Thu, 9 Feb 2017 18:54:21 +0000 (18:54 +0000)]
WinGui: Fix Tape, Sprite and HighMotion Denoise Tunes. #571

7 years agolibhb: fix Bob + CFR Same As Source + 2 Pass encode
John Stebbins [Thu, 9 Feb 2017 17:23:19 +0000 (10:23 -0700)]
libhb: fix Bob + CFR Same As Source + 2 Pass encode

The bob filter predicts the resulting output framerate as 2 * input
framerate.  So during 2 pass encoding, we must adjust the framerate with
the knows 1st pass values *after* any predictions made by filters.

Fixes https://github.com/HandBrake/HandBrake/issues/556

(cherry picked from commit 6674825664c4847c74ccc99ef35a0c85f2df9eb8)

7 years agolibav: fix h.264 initial recovery point detection
John Stebbins [Thu, 9 Feb 2017 16:29:16 +0000 (09:29 -0700)]
libav: fix h.264 initial recovery point detection

Initial GOP of video was dropped during decode.
Fixes https://github.com/HandBrake/HandBrake/issues/520

(cherry picked from commit 9dfe1373a9d1cb37843f3ffbe88fd63b630026c6)

7 years agoWinGui: Allow Title Specific Scan for DVD / Bluray Discs. Fixes #559
sr55 [Mon, 6 Feb 2017 19:50:25 +0000 (19:50 +0000)]
WinGui: Allow Title Specific Scan for DVD / Bluray Discs. Fixes #559

7 years agoUpdating NEWS file
sr55 [Sat, 4 Feb 2017 16:06:10 +0000 (16:06 +0000)]
Updating NEWS file

7 years agoqsv: Allocate planes contiguously.
maxd [Tue, 31 Jan 2017 09:35:37 +0000 (10:35 +0100)]
qsv: Allocate planes contiguously.

Better performance and less prone to crashing.

Fixes #540 and closes #558.

(cherry picked from commit 6aa1b40aead1653b39c93195aed4e920b6b0fcc9)

7 years agoLinGui: fix widget focus problem
John Stebbins [Sun, 29 Jan 2017 18:30:38 +0000 (11:30 -0700)]
LinGui: fix widget focus problem

(cherry picked from commit 56aca27e29c3e20dd67c8539dc5be9e4d1fc50b3)

7 years agopreset: fix behavior of AudioSecondaryEncoderMode
John Stebbins [Sun, 29 Jan 2017 17:21:02 +0000 (10:21 -0700)]
preset: fix behavior of AudioSecondaryEncoderMode

When true, this is meant to use the secondary encoder only for the first
selected audio track.  It was completely broken :(

(cherry picked from commit d03ffb0aa349145ebea8bf314f94f55f3f1ba370)

8 years agoWinGui: Adding missing Tape and Sprite Denoise Tunes #544
sr55 [Wed, 25 Jan 2017 19:17:42 +0000 (19:17 +0000)]
WinGui: Adding missing Tape and Sprite Denoise Tunes #544

8 years agoencca_aac: Fix initial start time
John Stebbins [Wed, 25 Jan 2017 18:47:15 +0000 (11:47 -0700)]
encca_aac: Fix initial start time

encca_aac assumed the first packet start time is 0 which is no longer
the case.  We now use edit lists to adjust non-zero start times.

(cherry picked from commit 33e6780967a14c876d0f329ea1c637e6b0f75a92)

8 years agoMacGui: select the right title when editing a queue job, libhb avoids rescanning...
Damiano Galassi [Wed, 25 Jan 2017 09:43:59 +0000 (10:43 +0100)]
MacGui: select the right title when editing a queue job, libhb avoids rescanning if the same file/folder is loaded.

(cherry picked from commit 79c33c0ca996311224bbd3719c85238a3358cb5e)

8 years agoLinGui: clear extra options when video codec changes
John Stebbins [Tue, 24 Jan 2017 22:44:03 +0000 (15:44 -0700)]
LinGui: clear extra options when video codec changes

Some valid options (e.g. vp9 qmin=0) can crash some libav encoders (mpeg4).

(cherry picked from commit 4334419b4adbc78648608ad4076de8005f4c4f27)

8 years agoWinGui: Always use iso639 for srt language code rather than name. #541
sr55 [Tue, 24 Jan 2017 19:12:46 +0000 (19:12 +0000)]
WinGui: Always use iso639 for srt language code rather than name.  #541

8 years agodecavcodec: fix avcodec_open failure upon bad extradata
John Stebbins [Tue, 24 Jan 2017 18:01:48 +0000 (11:01 -0700)]
decavcodec: fix avcodec_open failure upon bad extradata

If extradata is improperly parsed, avcodec_open may fail.  Keep trying
avcodec_open as long as there is more data to parse.

Fixes https://github.com/HandBrake/HandBrake/issues/542

(cherry picked from commit ca1dcccd09b5dfac93829d46fd6c7c9711898b77)

8 years agodecavcodec: fix crash in decavcodecvInfo
John Stebbins [Tue, 24 Jan 2017 17:59:58 +0000 (10:59 -0700)]
decavcodec: fix crash in decavcodecvInfo

If avcodec_open fails, pv->context->codec is NULL, but work->info may
still be called by scan.

(cherry picked from commit 4425691a0fd57b30360d39df3bdeebb9cc9b577f)

8 years agoWinGui: Bump version to 1.0.3 for the future release.
sr55 [Sun, 22 Jan 2017 17:53:40 +0000 (17:53 +0000)]
WinGui: Bump version to 1.0.3 for the future release.

8 years agoRevise and extend NEWS.markdown for 1.0.2. 1.0.2
Bradley Sepos [Sun, 22 Jan 2017 16:46:32 +0000 (11:46 -0500)]
Revise and extend NEWS.markdown for 1.0.2.

(cherry picked from commit 2880072077b1341627ae19c606b8ab1ad71313f6)

8 years agoWinGui: Fix an issue with QueueEdit not restoring PointToPoint settings correctly.
sr55 [Sun, 22 Jan 2017 16:12:52 +0000 (16:12 +0000)]
WinGui: Fix an issue with QueueEdit not restoring PointToPoint settings correctly.

8 years agoMacGui: lower the minimum disk space to ~2GB for now.
Damiano Galassi [Sun, 22 Jan 2017 11:59:47 +0000 (12:59 +0100)]
MacGui: lower the minimum disk space to ~2GB for now.

8 years agoMacGui: reload the queue outline view action column when an encode is done (the one...
Damiano Galassi [Thu, 19 Jan 2017 14:01:20 +0000 (15:01 +0100)]
MacGui: reload the queue outline view action column when an encode is done (the one with the x or the show in finder icon)

(cherry picked from commit 40ec4ebaa2958b2549125dd525b6fcb2bd595d69)

8 years agodvdread: Don't ignore errors from UDFReadBlocks
John Stebbins [Sat, 21 Jan 2017 21:39:24 +0000 (13:39 -0800)]
dvdread: Don't ignore errors from UDFReadBlocks

Fixes https://github.com/HandBrake/HandBrake/issues/535

(cherry picked from commit d95c6c272d277f4d507c82d5a909f42566cfbb66)

8 years agolibhb: force title rescan after completing a job encode (#488)
John Stebbins [Mon, 16 Jan 2017 22:54:13 +0000 (14:54 -0800)]
libhb: force title rescan after completing a job encode (#488)

Fixes https://forum.handbrake.fr/viewtopic.php?f=12&t=35583
(cherry picked from commit 922db9bec26e1def4c8ba60afb2147cc06ec524d)

8 years agoWinGui: Set a min height on the queue selection window.
sr55 [Sat, 21 Jan 2017 20:14:51 +0000 (20:14 +0000)]
WinGui: Set a min height on the queue selection window.

8 years agocli: Adding hb_opencl_set_enable when --use-opencl is set. #496
sr55 [Sun, 15 Jan 2017 20:16:51 +0000 (20:16 +0000)]
cli:  Adding hb_opencl_set_enable when --use-opencl is set. #496

8 years agoWinGui: Pause on Low Diskspace is for local drives only. Disabling check for UNC...
sr55 [Sun, 15 Jan 2017 18:22:48 +0000 (18:22 +0000)]
WinGui: Pause on Low Diskspace is for local drives only. Disabling check for UNC paths. #527