]> granicus.if.org Git - graphviz/log
graphviz
8 years agoRemove HAVE_CONFIG_H check
Erwin Janssen [Sat, 17 Sep 2016 23:34:38 +0000 (01:34 +0200)]
Remove HAVE_CONFIG_H check

config.h should always be included, a build without it never happens.
The checks on Linux always succeed, because autotools automatically
defines HAVE_CONFIG_H on all the Makefiles. On Windows this is not the
case. Removing all the checks revealed that multiple projects did not
include config.h because HAVE_CONFIG_H wasn't defined. This was the case
for at least the following projects:
- acyclic
- bcomps
- ccomps
- dijkstra
- ingraphs
- gc
- gml2gv
- graphml2gv
- gv2gml
- gvcolor
- gvgen
- mm2gv
- nop
- pathplan
- rbtree
- sccmap
- topfish
- tred

Added `windows\include` to the additional include directories and adding
some library paths solves some, but not all problems that emerged when the
check was removed and some code actually got compiled that wasn't compiled
before.

8 years agoMerge pull request #1159 from ErwinJanssen/fix/travis-build
John Ellson [Wed, 14 Sep 2016 15:43:00 +0000 (11:43 -0400)]
Merge pull request #1159 from ErwinJanssen/fix/travis-build

Update Criterion submodule to fix Travis build

8 years agoUpdate Criterion submodule to fix Travis build
Erwin Janssen [Wed, 14 Sep 2016 15:20:33 +0000 (17:20 +0200)]
Update Criterion submodule to fix Travis build

For some reason the Travis build fails when pulling the Criterion submodule. Updating the submodule resolves this issue.

8 years agoRe-added -lstdc++ to fix build breakage
John Ellson [Wed, 14 Sep 2016 13:45:11 +0000 (09:45 -0400)]
Re-added -lstdc++ to fix build breakage

8 years agoMerge pull request #1157 from ErwinJanssen/fix-cast-warning
John Ellson [Wed, 14 Sep 2016 13:30:22 +0000 (09:30 -0400)]
Merge pull request #1157 from ErwinJanssen/fix-cast-warning

Use `strcmp` in instead of `gvrender_comparestr`.

8 years agoMerge pull request #1156 from ErwinJanssen/travis-centos
John Ellson [Wed, 14 Sep 2016 13:26:54 +0000 (09:26 -0400)]
Merge pull request #1156 from ErwinJanssen/travis-centos

Add build on CentOS 7 to Travis

8 years agoChange cast of strcmp in bsearch.
Erwin Janssen [Fri, 9 Sep 2016 22:02:58 +0000 (00:02 +0200)]
Change cast of strcmp in bsearch.

Casting `strcmp` to `__compar_fn_t` doesn't work on Windows, the build
fails. Instead, cast `strcmp` to the required function type:
`(int(*)(const void*, const void*)`

8 years agoUse `strcmp` in instead of `gvrender_comparestr`.
Erwin Janssen [Fri, 9 Sep 2016 01:19:19 +0000 (03:19 +0200)]
Use `strcmp` in instead of `gvrender_comparestr`.

`bsearch` is used in this function to find a string in a string array. It's not needed to pass the address of `tok` to the function, because `tok` is already a pointer. `gvrender_comparestr` should then cast the values to `(const char)` instead of `*(char**)`, because `s1` and `s2` are strings, not pointers to a string. With this change the function only calls `strcmp`, so passing `strcmp` to `bsearch` has the same effect and `gvrender_comparestr` can be removed.
This gets rid of all the `-Wcast-qual` warnings as well.

8 years agoTravis: Add build on CentOS 7 using Docker.
Erwin Janssen [Thu, 8 Sep 2016 17:03:57 +0000 (19:03 +0200)]
Travis: Add build on CentOS 7 using Docker.

There are now two environments, one where the variable DOCKER_BUILD is true and one where it is false. False means a normal build on the Travis build image, true means docker will be used to run a build on a CentOS 7 image. The setup of the CentOS 7 image is done in the Dockerfile in `ci/centos7`. It takes a clean CentOS 7 image and installs the required build utilities and dependencies for a minimal build.

8 years agoAdded error checking to ci/build_and_test.sh
Erwin Janssen [Thu, 8 Sep 2016 16:03:32 +0000 (18:03 +0200)]
Added error checking to ci/build_and_test.sh

Instead of executing all command even if some fail, stop when a command fails and print an error message.

8 years agoRemoved `-lstdc++` from Makefiles
Erwin Janssen [Thu, 8 Sep 2016 12:23:55 +0000 (14:23 +0200)]
Removed `-lstdc++` from Makefiles

This flag causes errors in the Docker build. Removing it still results in a succesfull build and the previous changelogs indicate that this flag should be removed.

8 years agoUse `build_and_test.sh` script in Travis build.
Erwin Janssen [Thu, 8 Sep 2016 12:00:51 +0000 (14:00 +0200)]
Use `build_and_test.sh` script in Travis build.

This script makes it easier to add multiple platforms using docker.

8 years agorevert change - not right untagged-a22228c7bd6ed4c2a8f9
John Ellson [Thu, 8 Sep 2016 04:13:48 +0000 (00:13 -0400)]
revert change - not right

8 years agodrop some strange casts to cllean up some warnings untagged-88f8affbb29485590ece
John Ellson [Wed, 7 Sep 2016 23:44:14 +0000 (19:44 -0400)]
drop some strange casts to cllean up some warnings

8 years agoMerge pull request #1155 from ErwinJanssen/windows-release untagged-897b348e31e4e52e8698
John Ellson [Wed, 7 Sep 2016 23:19:26 +0000 (19:19 -0400)]
Merge pull request #1155 from ErwinJanssen/windows-release

Various improvements to Windows build

8 years agoMerge pull request #1154 from ErwinJanssen/refactor-sign-conversion
John Ellson [Wed, 7 Sep 2016 23:18:31 +0000 (19:18 -0400)]
Merge pull request #1154 from ErwinJanssen/refactor-sign-conversion

Resolve some conversion warnings

8 years agoAppveyor: split build into two jobs.
Erwin Janssen [Tue, 6 Sep 2016 14:06:23 +0000 (16:06 +0200)]
Appveyor: split build into two jobs.

Split the build into two jobs: one for Release and one for Debug.

8 years agoWindows: added gdiplus to build.
Erwin Janssen [Tue, 6 Sep 2016 14:00:12 +0000 (16:00 +0200)]
Windows: added gdiplus to build.

The gdiplus Visual Studio project was previously removed, but now added
again and cleaned in the same way as the other projects.

8 years agoWindows: Use $(Configuration) in output directory
Erwin Janssen [Tue, 6 Sep 2016 12:33:45 +0000 (14:33 +0200)]
Windows: Use $(Configuration) in output directory

Instead of using the name of the configuration (Debug or Release), use the
variable that contains this value.

8 years agoRemoved `QCoreApplication::UnicodeUTF8` arguments
Erwin Janssen [Tue, 6 Sep 2016 11:01:51 +0000 (13:01 +0200)]
Removed `QCoreApplication::UnicodeUTF8` arguments

From the Qt documentation (http://wiki.qt.io/Transition_from_Qt_4.x_to_Qt5#QCoreApplication::UnicodeUTF8_is_deprecated):

QCoreApplication::UnicodeUTF8 is deprecated

This enum type used to define the 8-bit encoding of character string arguments to translate(). This enum is now obsolete and UTF-8 will be used in all cases. So remove all instances of QCoreApplication::UnicodeUTF8.

8 years agoIn gvedit, replaced `toAscii()` with `toLatin()`
Erwin Janssen [Tue, 6 Sep 2016 10:54:33 +0000 (12:54 +0200)]
In gvedit, replaced `toAscii()` with `toLatin()`

From the Qt documentation
(http://wiki.qt.io/Transition_from_Qt_4.x_to_Qt5#toAscii.28.29_and_fromAscii.28.29_Methods_are_deprecated):

toAscii() and fromAscii() Methods are deprecated

Replace all instances of

```
fromAscii()
toAscii()
```

to

```
fromLatin1()
toLatin1()
```

8 years agoWindows: added ccomps to build
Erwin Janssen [Tue, 30 Aug 2016 18:26:19 +0000 (20:26 +0200)]
Windows: added ccomps to build

The ccomps Visual Studio project was previously removed, but now added
again and cleaned in the same way as the other projects.

8 years agoRemoved windows/libann
Erwin Janssen [Mon, 29 Aug 2016 21:24:45 +0000 (23:24 +0200)]
Removed windows/libann

This folder only contained a project file, no code. Also, lib ANN is
included in windows\dependencies\ANN.

8 years agoResolved "macro redefinition" warnings.
Erwin Janssen [Mon, 29 Aug 2016 20:16:59 +0000 (22:16 +0200)]
Resolved "macro redefinition" warnings.

On Windows, the Linux build does not throw this warning, the warning C4005
"macro redefinition" is thrown several hundered times. Most of these could
be prepended by an `#undef`, this resolves the warning.

8 years agoWindows: Generate no debug information for Release.
Erwin Janssen [Mon, 29 Aug 2016 12:17:13 +0000 (14:17 +0200)]
Windows: Generate no debug information for Release.

The Release configuration doesn't shouldn't contain debug information,
because this is going to be released to the general public.

8 years agoWindows: set <DebugInformationFormat> to default.
Erwin Janssen [Mon, 29 Aug 2016 11:54:08 +0000 (13:54 +0200)]
Windows: set <DebugInformationFormat> to default.

Set the <DebugInformationFormat> to default for the release configuration.
The value it had (Zi) is the same as the default value, so the
<DebugInformationFormat> can be safely removed.

8 years agoAppveyor: Add Debug build and artifact.
Erwin Janssen [Mon, 29 Aug 2016 11:14:50 +0000 (13:14 +0200)]
Appveyor: Add Debug build and artifact.

Run both a Release and a Debug build create artifacts for both
configurations.

8 years agoWindows: Change release output directory
Erwin Janssen [Mon, 29 Aug 2016 11:11:51 +0000 (13:11 +0200)]
Windows: Change release output directory

Use $(SolutionDir)Release\Graphviz\bin\ instead of
$(SolutionDir)Graphviz\bin\. This is more consistent and allows for an
easier artifact selection on Appveyor.

8 years agoshapes.c: Initialize `pointf p` variable.
Erwin Janssen [Mon, 29 Aug 2016 10:22:09 +0000 (12:22 +0200)]
shapes.c: Initialize `pointf p` variable.

Because this variable was used uninitialized, it caused a runtime error on
Windows.

8 years agoWindows: enabled Debug build for all projects.
Erwin Janssen [Mon, 29 Aug 2016 10:00:52 +0000 (12:00 +0200)]
Windows: enabled Debug build for all projects.

Not all project would build when using the Debug configuration, and some
projects had conflicting settings that didn't allow a Debug build. Both
are fixed.

8 years agoAppveyor: produce two artifacts
Erwin Janssen [Thu, 25 Aug 2016 18:01:16 +0000 (20:01 +0200)]
Appveyor: produce two artifacts

Produce two artifacts: one with all the files that are generated during
the build (PDB files for debug, etc.) and one without. The last one is
most suited as a release.

8 years agoAppveyor: Fix typo in appveyor.yml.
Erwin Janssen [Thu, 25 Aug 2016 17:57:18 +0000 (19:57 +0200)]
Appveyor: Fix typo in appveyor.yml.

Added a missing 'p' to .zip file.

8 years agoWindows: Remove <LinkIncremental> from vmalloc.
Erwin Janssen [Thu, 25 Aug 2016 14:03:24 +0000 (16:03 +0200)]
Windows: Remove <LinkIncremental> from vmalloc.

The Debug configuration still had the <LinkIncremental> property.

8 years agoWindows: Removed false <RandomizedBaseAddress>
Erwin Janssen [Thu, 25 Aug 2016 13:25:31 +0000 (15:25 +0200)]
Windows: Removed false <RandomizedBaseAddress>

Some project had <RandomizedBaseAddress> set to false. Setting this to
false disables ASLR which is a nice security feature. These options are
removed because the default value for <RandomizedBaseAddress> is true.

8 years agoAppveyor: Reduce empty lines appveyor.yml
Erwin Janssen [Thu, 25 Aug 2016 12:13:01 +0000 (14:13 +0200)]
Appveyor: Reduce empty lines appveyor.yml

8 years agoWindows: dependencies copied on post-build step.
Erwin Janssen [Thu, 25 Aug 2016 11:24:05 +0000 (13:24 +0200)]
Windows: dependencies copied on post-build step.

Dependencies (DLLs from 3rd parties) are copied on the post-build step to
the Graphviz\bin folder.

8 years agoWindows: clean additional library directories
Erwin Janssen [Wed, 24 Aug 2016 19:33:19 +0000 (21:33 +0200)]
Windows: clean additional library directories

Removed unused and used `$(OutDir)` instead of
`$(SolutionDir)Graphviz\bin\` for release and
`$(SolutionDir)Debug\Graphviz\bin\` for debug.

8 years agoWindows: clean additional include directories.
Erwin Janssen [Tue, 23 Aug 2016 13:45:42 +0000 (15:45 +0200)]
Windows: clean additional include directories.

Removed unused include directories and reordered the remaining.

8 years agoWindows: Removed <LinkIncremental> property
Erwin Janssen [Tue, 23 Aug 2016 11:42:57 +0000 (13:42 +0200)]
Windows: Removed <LinkIncremental> property

With the current configuration, this property is ignored, so using the
default value is fine.

8 years agoWindows: Redefined intermediate build directories.
Erwin Janssen [Tue, 23 Aug 2016 01:22:14 +0000 (03:22 +0200)]
Windows: Redefined intermediate build directories.

Specifying the configuration name as intermediate build directory is not
needed. The default behavior is the same, so it can be safely removed.

For the projects in cmd/tools, $(Configuration)\ can be used instead of
the actual configuration name.

8 years agoAppveyor: Reduce build output noise.
Erwin Janssen [Tue, 23 Aug 2016 00:58:58 +0000 (02:58 +0200)]
Appveyor: Reduce build output noise.

Before the build, delete the file "C:\Program Files
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets",
Otherwise several "target does not exist and will be ignored" messages are
printed.

8 years agoWindows: Compiling with /MT instead of /MD
Erwin Janssen [Tue, 23 Aug 2016 00:40:24 +0000 (02:40 +0200)]
Windows: Compiling with /MT instead of /MD

On a release build, compile all projects with /MT instead of /MD. This
means that required system libraries are staticly linked instead, so no
DLL is needed. Before this change, the user was required to install the
SDK, this is no longer the case.

The only exception is gvplugin_gd. This can't be compiled with /MT,
because it's dependency libgd is compiled with /MD.

8 years agoIgnoring Visual Studio Code user folder.
Erwin Janssen [Tue, 23 Aug 2016 00:39:10 +0000 (02:39 +0200)]
Ignoring Visual Studio Code user folder.

8 years agoWindows: Disable warning C4996
Erwin Janssen [Mon, 22 Aug 2016 23:46:08 +0000 (01:46 +0200)]
Windows: Disable warning C4996

Disable MSVC warning C4996. This warning mostly fires on completely valid
code and fixing this warning compromises code portability, while the code
quality isn't improved substantially.

8 years agoAdd documentation on json output. untagged-d1db4ad9a9fa8595330a
Emden R. Gansner [Mon, 5 Sep 2016 20:35:47 +0000 (16:35 -0400)]
Add documentation on json output.

8 years agoMerge branch 'master' of https://github.com/ellson/graphviz untagged-153418532a1b01559b57
Emden Gansner [Sat, 3 Sep 2016 17:19:09 +0000 (13:19 -0400)]
Merge branch 'master' of https://github.com/ellson/graphviz

8 years agoFix bug in SparseMatrix_copy tries to copy a pattern matrix which does
Emden Gansner [Sat, 3 Sep 2016 17:05:16 +0000 (13:05 -0400)]
Fix bug in SparseMatrix_copy tries to copy a pattern matrix which does
have values.

If a matrix is constructed using _from_coordinate_arrays, it calls
from_coordinate_arrays_internal with SUM_REPEATED_ALL. The latter function then
calls sum_repeated_entries. This causes values to be added to the array

Later, if the matrix is passed to make_undirected, this calls symmetrize,
which may call _copy. If _copy uses _new, the new array will use the input
array's type (pattern) and not create memory values, causing the memcpy to fail.

8 years agoResolved 24 warnings in tclpathplan.c
Erwin Janssen [Thu, 1 Sep 2016 20:54:03 +0000 (22:54 +0200)]
Resolved 24 warnings in tclpathplan.c

Changed the type of some local variables from `int` to `size_t`.

8 years agoResolved 14 warnings in labels.c
Erwin Janssen [Thu, 1 Sep 2016 20:36:54 +0000 (22:36 +0200)]
Resolved 14 warnings in labels.c

Some field could be made a `size_t` instead of an `int`.
The cast now matches the type of the assigned variable.

8 years agoResolve one -Wsign-conversion in htmltable.c
Erwin Janssen [Thu, 1 Sep 2016 20:12:21 +0000 (22:12 +0200)]
Resolve one -Wsign-conversion in htmltable.c

The local variable `cnt` could be made of type `size_t`.

8 years agoResolve 7 -Wconversion warnings in htmllex.c
Erwin Janssen [Thu, 1 Sep 2016 19:38:20 +0000 (21:38 +0200)]
Resolve 7 -Wconversion warnings in htmllex.c

The return value of `toupper` can be safely cast to a char, as long as the input of `toupper` is actually a char.

8 years agoResolve 7 warnings in colxlate.c
Erwin Janssen [Thu, 1 Sep 2016 19:18:16 +0000 (21:18 +0200)]
Resolve 7 warnings in colxlate.c

In three function, the type of two local variables could safely be changed to `size_t`.

8 years agoResolved two warnings in arrows.c
Erwin Janssen [Thu, 1 Sep 2016 18:01:01 +0000 (20:01 +0200)]
Resolved two warnings in arrows.c

The local variable `namelen` is always positive, so the type `size_t` could be used.

8 years agoResolved one -Wsign-conversion in cvt.c
Erwin Janssen [Thu, 1 Sep 2016 17:26:25 +0000 (19:26 +0200)]
Resolved one -Wsign-conversion in cvt.c

There are multiple -Wsign-conversion warnings, but only one could be resolved without analysing or changing more than a few lines of code.

8 years agoResolved four -Wsign-conversion in rec.c
Erwin Janssen [Thu, 1 Sep 2016 17:09:30 +0000 (19:09 +0200)]
Resolved four -Wsign-conversion in rec.c

`arg_rec_size` is always positive, so it can be an unsigned integer.

8 years agoResolve four warnings in grammar.y
Erwin Janssen [Thu, 1 Sep 2016 16:41:48 +0000 (18:41 +0200)]
Resolve four warnings in grammar.y

Setting the proper type for `len` resolved them.

8 years agoResolve one Wsign-conversion in attr.c
Erwin Janssen [Thu, 1 Sep 2016 13:05:09 +0000 (15:05 +0200)]
Resolve one Wsign-conversion in attr.c

This cast that resolves this warning does not change the sign of `sz`, because the if statement above it makes sure it isn't a negative number.

8 years agoResolve three Wsign-conversion in agxbuf.c
Erwin Janssen [Thu, 1 Sep 2016 12:55:19 +0000 (14:55 +0200)]
Resolve three Wsign-conversion in agxbuf.c

These three warnings could be resolved without making functional changes in the code. Also initialized the three local variables in this function to zero.

8 years agoconvert 'unsigned long' to 'uint64_t' for Windows portability untagged-4bd8dcccfa75989e4d17
John Ellson [Tue, 23 Aug 2016 14:45:02 +0000 (10:45 -0400)]
convert 'unsigned long' to 'uint64_t' for Windows portability

8 years agoMerge pull request #1151 from arjamizo/master untagged-5b049c6cdfd083f5dbf2
John Ellson [Mon, 22 Aug 2016 23:49:46 +0000 (19:49 -0400)]
Merge pull request #1151 from arjamizo/master

fix typo TB->BT in docs:shapes

8 years agofix typo TB->BT in docs:shapes
arjamizo [Mon, 22 Aug 2016 14:43:27 +0000 (16:43 +0200)]
fix typo TB->BT in docs:shapes

8 years agoReplace cluster with subgraph, as the output will also reflect non-cluster untagged-f6bbc5576feb1e03c4b8
Emden R. Gansner [Fri, 19 Aug 2016 11:04:25 +0000 (07:04 -0400)]
Replace cluster with subgraph, as the output will also reflect non-cluster
subgraphs.

8 years agoAdd schema for dot output in json format. untagged-0dc7cf263f66ae1825bb
Emden R. Gansner [Thu, 18 Aug 2016 00:36:28 +0000 (20:36 -0400)]
Add schema for dot output in json format.

8 years agoMerge pull request #1150 from ErwinJanssen/configure-ac untagged-1bc5df88610db337fc67
John Ellson [Wed, 17 Aug 2016 13:11:10 +0000 (09:11 -0400)]
Merge pull request #1150 from ErwinJanssen/configure-ac

Removed POSIX version flag from configure.ac

8 years agoRemoved POSIX version flag from configure.ac
Erwin Janssen [Wed, 17 Aug 2016 11:31:02 +0000 (13:31 +0200)]
Removed POSIX version flag from configure.ac

With the new way of enabling C99 (`AC_PROG_CC_C99` instead of `-std=c99`) this flag is no longer needed for a successfull compilation.

8 years agoel5 breakage, need , in dist target, but not in install target untagged-383680da5ca9da9f5250
John Ellson [Tue, 16 Aug 2016 17:18:55 +0000 (13:18 -0400)]
el5 breakage, need ,  in dist target, but not in install target

8 years agoremove -D_POSIX_C_SOURCE=200112L as it breaks ./configure test for php.h untagged-d177ed11e0540b07902a
John Ellson [Tue, 16 Aug 2016 16:03:03 +0000 (12:03 -0400)]
remove -D_POSIX_C_SOURCE=200112L as it breaks ./configure test for php.h

8 years agoMerge branch 'master' of github.com:/ellson/graphviz untagged-95487e465cf6bdb4c605
John Ellson [Mon, 15 Aug 2016 20:21:54 +0000 (16:21 -0400)]
Merge branch 'master' of github.com:/ellson/graphviz

8 years agodisable php in fedora24 till we can work out what broke
John Ellson [Mon, 15 Aug 2016 20:21:38 +0000 (16:21 -0400)]
disable php in fedora24 till we can work out what broke

8 years agotry updating php includedirs to match php-config --includes
John Ellson [Mon, 15 Aug 2016 20:21:02 +0000 (16:21 -0400)]
try updating php includedirs to match php-config --includes

8 years ago build manpages unconditionally on Travis hsost
John Ellson [Mon, 15 Aug 2016 18:12:35 +0000 (14:12 -0400)]
 build manpages unconditionally on Travis hsost

8 years agoMerge pull request #1149 from ErwinJanssen/improve-travis untagged-950e8f23afa87abe4973
John Ellson [Sat, 13 Aug 2016 16:55:44 +0000 (12:55 -0400)]
Merge pull request #1149 from ErwinJanssen/improve-travis

Improve Travis + deploy make dist results

8 years agoSmall formatting change. untagged-0aac90e5c2817176609d
Emden Gansner [Sat, 13 Aug 2016 12:51:45 +0000 (08:51 -0400)]
Small formatting change.

8 years agoEdges attached to a cluster were not getting assigned an index number. untagged-c6ce5b1f17878d776124
Emden Gansner [Fri, 12 Aug 2016 21:18:29 +0000 (17:18 -0400)]
Edges attached to a cluster were not getting assigned an index number.

8 years agoquote as it contains spaces when No untagged-1aed90cbe517038de3a0
John Ellson [Wed, 10 Aug 2016 19:00:14 +0000 (15:00 -0400)]
quote  as it contains spaces when No

8 years agosuppress "unused parameter" warning during ./configure
John Ellson [Wed, 10 Aug 2016 18:55:19 +0000 (14:55 -0400)]
suppress "unused parameter" warning during ./configure

8 years agoTravis: deploy result of `make dist`
Erwin Janssen [Wed, 10 Aug 2016 09:13:40 +0000 (11:13 +0200)]
Travis: deploy result of `make dist`

Every commit will still result in a new untagged release on Github, but the results of `make dist` will now be attached to these releases.

8 years agoTravis: clean build steps.
Erwin Janssen [Wed, 10 Aug 2016 08:37:12 +0000 (10:37 +0200)]
Travis: clean build steps.

Because the results of `make install` when using a prefix aren't binaries suitable to be released, some build steps can either be removed or simpified.

8 years agoTravis: color gcc output
Erwin Janssen [Wed, 10 Aug 2016 08:12:25 +0000 (10:12 +0200)]
Travis: color gcc output

Use colorgcc to add color to the output of gcc. This improves readability and makes it easier to find warnings.

8 years agoMerge pull request #1148 from ErwinJanssen/unit-test untagged-27ff95768eb6958bcef7
John Ellson [Tue, 9 Aug 2016 15:52:33 +0000 (11:52 -0400)]
Merge pull request #1148 from ErwinJanssen/unit-test

Introduction unit test for current commnand line behavior

8 years agoTests added for current behaviour command line.
Erwin Janssen [Mon, 8 Aug 2016 13:49:04 +0000 (15:49 +0200)]
Tests added for current behaviour command line.

This commit adds some tests that "document" the current behavior of the command line interface. When refactoring command line interface (like the parsing code), the observable behavior of the command line interface should stay the same, this is to ensure backwards compatibility. These tests are a start, it covers some basic command line operations (printing the version and usage), but show some interesting things. Mainly that the order of the flags is very important.

- `dot -Vrandom` prints the version, but `dot -randomV` causes an error.
- `dot -?V` prints the usage, but `dot -V?` prints the version.

While it may be desirable to change this, when refactoring this behavior should stay the same. Changing the existing interface should be done in Graphviz 3.

8 years agoTravis: Install Criterion
Erwin Janssen [Mon, 8 Aug 2016 10:08:42 +0000 (12:08 +0200)]
Travis: Install Criterion

Adds the installation of Criterion to the `install` step in the Travis configuration. A submodule is used so changes in the Criterion repository can't break the build. A submodule points to a specific commit.

8 years agoSimple unit test added.
Erwin Janssen [Mon, 8 Aug 2016 09:59:34 +0000 (11:59 +0200)]
Simple unit test added.

This unit test serves to validate the configuration and installation of the Criterion unit testing framework. This test will only be compiled and run if Criterion is installed.

8 years agoCheck for unit test framework in configure.ac
Erwin Janssen [Mon, 8 Aug 2016 09:21:55 +0000 (11:21 +0200)]
Check for unit test framework in configure.ac

Criterion is a unit testing framework for C and C++ and it's C99 compatible. It allows for fast test writing because, unlike a lot of other C unit test frameworks, it doesn't require a lot of boilerplate code.

This check in configure.ac checks if Criterion is installed on the system.

8 years agoMerge pull request #1147 from GadgetSteve/master untagged-cf3150dc2db96b5bb4d6
John Ellson [Mon, 1 Aug 2016 04:07:57 +0000 (00:07 -0400)]
Merge pull request #1147 from GadgetSteve/master

Changed README.md reference github for documentation.

8 years agoChanges to README.md to reference github for documentation
Steve Barnes [Sun, 31 Jul 2016 14:18:21 +0000 (15:18 +0100)]
Changes to README.md to reference github for documentation

Adresses #88 and #77.

8 years agoMerge pull request #3 from ellson/master
Steve (Gadget) Barnes [Sun, 31 Jul 2016 13:55:43 +0000 (14:55 +0100)]
Merge pull request #3 from ellson/master

Sync with master

8 years agosome -W flags not available on centos[56] untagged-749ecd6837d5c822253e
John Ellson [Wed, 27 Jul 2016 08:21:31 +0000 (04:21 -0400)]
some -W flags not available on centos[56]

8 years agoFix bug in printing error message about graphs with loops or multiedges; note port... untagged-282a92de118059697b67
Emden Gansner [Tue, 26 Jul 2016 16:23:16 +0000 (12:23 -0400)]
Fix bug in printing error message about graphs with loops or multiedges; note port restriction in
man page.

8 years agocgraph is not a configure option these days untagged-3443de97cd58035a8aea
John Ellson [Tue, 26 Jul 2016 00:39:50 +0000 (20:39 -0400)]
cgraph is not a configure option these days

8 years agoimprove handling of extra warnings if C99 available
John Ellson [Tue, 26 Jul 2016 00:37:54 +0000 (20:37 -0400)]
improve handling of extra warnings if C99 available

8 years agomore incompatible warning switches untagged-f5823de05291db506275
John Ellson [Mon, 25 Jul 2016 21:15:06 +0000 (17:15 -0400)]
more incompatible warning switches

8 years ago-Wtrampolines -Wdouble-promotion - cause errors on older (centos[56]) compilers
John Ellson [Mon, 25 Jul 2016 21:06:48 +0000 (17:06 -0400)]
-Wtrampolines -Wdouble-promotion  - cause errors on older (centos[56]) compilers

8 years agoMerge pull request #1145 from ErwinJanssen/refactor untagged-9ee5934fa10f12b4043f
John Ellson [Fri, 22 Jul 2016 18:54:51 +0000 (14:54 -0400)]
Merge pull request #1145 from ErwinJanssen/refactor

Enable C99, enable more warnings and solve some warnings.

8 years agoadd missing layers support in -Tsvgz device untagged-1d58b621a7287e0b0a25
John Ellson [Fri, 22 Jul 2016 14:47:02 +0000 (10:47 -0400)]
add missing layers support in -Tsvgz device

8 years agoFixed Wundef warnings in various files in sfio.
Erwin Janssen [Tue, 12 Jul 2016 13:21:43 +0000 (15:21 +0200)]
Fixed Wundef warnings in various files in sfio.

The fixed header files are included in multiple locations, causing a reducution of around 2000 Wundef warnings after these changes.

8 years agoFixed various Wundef warnings.
Erwin Janssen [Mon, 11 Jul 2016 22:45:09 +0000 (00:45 +0200)]
Fixed various Wundef warnings.

8 years agoSurrounded _BLD_cdt with defined() in cdt.h.
Erwin Janssen [Mon, 11 Jul 2016 20:27:33 +0000 (22:27 +0200)]
Surrounded _BLD_cdt with defined() in cdt.h.

This solves hundreds of Wundef warnings.

8 years agoSurrounded _PACKAGE_ast with defined() where needed.
Erwin Janssen [Mon, 11 Jul 2016 19:14:18 +0000 (21:14 +0200)]
Surrounded _PACKAGE_ast with defined() where needed.

This solves more than a thousend Wundef warnings.

8 years agoFixed Wundef warnings in ast_common.h.in
Erwin Janssen [Mon, 11 Jul 2016 18:38:39 +0000 (20:38 +0200)]
Fixed Wundef warnings in ast_common.h.in

There were several Wundef warnings in ast_common.h.in. Because this file is included in a lot of other files, these warnings showed up often. This change fixed 1119 warnings in total.