jbrjake [Sun, 23 Mar 2008 20:18:08 +0000 (20:18 +0000)]
CLI:
- If title->detected_interlacing is true, mention it in the non-verbose scan output
- Fixes a minor VFR bug that got the filter chain order wrong if other filters than detelecine were applied.
jbrjake [Sun, 23 Mar 2008 19:53:39 +0000 (19:53 +0000)]
= Adds an hb_detect_comb() function that indicates whether or not a frame shows interlacing artifacts.
- Utilitizes that function in scan.c to analyze the preview frames
- Sets a new title->detected_interlacing variable to true if half or more previews show combing, and warns the user in the log.
jbrjake [Sat, 22 Mar 2008 14:33:09 +0000 (14:33 +0000)]
Makes snapshots the default build method for both make and jam. To build a regular release with jam, use "./configure --release". To build a regular release with make, use "make all".
jbrjake [Sat, 22 Mar 2008 00:16:22 +0000 (00:16 +0000)]
"If one would give me six lines written by the hand of the most honest man, I would find something in them to have him hanged."
- Banishes libdvdcss, removing DVD decryption from HandBrake's binaries.
- For decrypttion, the MacGui and Mac CLI now will load at runtime VLC's dynamic library of dvdcss if the media player's available on the user's system.
- Linux users can build with a statically linked lib of dvdcss by using ./configure --libdvdcss, which will download it from a remote third party (videolan.org).
jbrjake [Thu, 20 Mar 2008 16:27:20 +0000 (16:27 +0000)]
Reverts r1254, so ffmpeg-in-avi again reports as DivX 5. Giving it the "correct" codes was a problem for lame Windows media players and didn't help the CrackBerry user who requested it. Moral of the story? Greet user requests with skepticism.
van [Thu, 20 Mar 2008 05:28:36 +0000 (05:28 +0000)]
Fix two of my stupid bugs that prevented using the queue with transport streams:
- keep a cache of the pid/substream id mappings from each scan rather than assuming an encode will immediately follow a scan (there will be lots of scans followed by lots of encodes when the queue is used).
- rewrite a few things to get rid of static variables. hb_ts_stream_decode is called by both scan & reader and they're in different threads. All the working storage & state has to either be in the stream struct or on the stack so it's private to the calling thread or it gets corrupted when doing a scan in the middle of an encode.
sr55 [Wed, 19 Mar 2008 22:06:07 +0000 (22:06 +0000)]
WinGui:
- Fixed a bug in the startup init sequence. H264 window needed to be generated before the presets were init'd.
- Setup the tab markers for the h264 tab
sr55 [Wed, 19 Mar 2008 21:29:22 +0000 (21:29 +0000)]
WinGui:
- The x264 tab has been replaced by a completely new panel with widgets for many of the available x264 options. It operates in a similar way to the macgui's panel. (It however will not disable widgets based on selections on other widgets yet(like the macgui does) this will come later when the bugs have been worked out.
jbrjake [Wed, 19 Mar 2008 18:34:36 +0000 (18:34 +0000)]
- Method for generating snapshot builds marked with the svn revision by using ./configure --snapshot; ./jam
- Targets for generating snapshot Mac universal binaries by using make snapshot and packaging Mac snapshot releases
- Sets the current date for HB_BUILD in jam
- Sets the Mac .plist version and build based on the jam/make config
- Bumps the version number to 0.9.3
dynaflash [Mon, 17 Mar 2008 15:09:39 +0000 (15:09 +0000)]
MacGui: Write version info the the activity log and activity window
- writes the Handbrake version number and build number to the activity window and log text file upon startup (this no longer occured out of libhb once we updated the update system to Sparkle)
- Add writing the version info upon clearing of either the log file or the window, this way we have version info from users even if they have cleared the top of the logs.
sr55 [Sun, 16 Mar 2008 16:50:29 +0000 (16:50 +0000)]
WinGui:
- When selecting a destination, The audio encoder selection dropdown now repopulates with only compatible encoders (based on file container)
- Misc other changes
van [Sun, 16 Mar 2008 06:13:33 +0000 (06:13 +0000)]
Should have removed this as part of the r1341 checkin - we now add silence based only on gaps in the timestamp sequence. The heuristic of looking at what fifos are full or empty can misbehave based on random variation in the thread scheduling.
van [Sat, 15 Mar 2008 08:02:08 +0000 (08:02 +0000)]
- Add mpeg2 "Standard Target Decoder" clock recovery to the low level mpeg stream reader so we don't have to guess about the clock in sync.
- Since sync now has a fairly reliable clock, make it just trim excess audio or video and fill holes so that we maintain cross media sync.
- Redo the TS-to-PS transmuxing code to work on smaller units so that we can reliably convert the TS clock (PCR) to a PS clock (SCR).
van [Sat, 15 Mar 2008 07:54:22 +0000 (07:54 +0000)]
minor bug fix: AC3 passthru audio frames with no pts were getting a bogus start and stop time which caused bad things to happen later on in sync.c. Move up the code that generates a pts for non-passthru frames so that it applies to both.
sr55 [Fri, 14 Mar 2008 19:47:17 +0000 (19:47 +0000)]
WinGui:
- Users can now have their own presets appear in the presets bar. They can both add and remove their own presets.
- Anamorphic option is now a dropdown menu like the macgui.
- Video tab re-arrange to be consistant with the macgui.
- Video Framerate dropdown: Changed Automatic to Same as soure (same as the macgui)
sr55 [Fri, 14 Mar 2008 15:52:04 +0000 (15:52 +0000)]
WinGui:
- Added warning about UNC file paths
- Removed the generate presets.dat function on start-up. (It wasn't really needed)
- Changed a few tooltips
- Switched back to .Net version 2
jbrjake [Wed, 12 Mar 2008 17:31:39 +0000 (17:31 +0000)]
MacGui: When selecting one x264 option disables another (like turning off CABAC disables trellis), remove the disabled option from the string and fade the widget out of view with an animation proxy.
dynaflash [Fri, 7 Mar 2008 20:05:46 +0000 (20:05 +0000)]
MacGui: Clean up some formatting and errant comments left over from some of the snippets I robbed out of HBQueueController on the drag and drop preset commit. :)
dynaflash [Fri, 7 Mar 2008 19:43:17 +0000 (19:43 +0000)]
MacGui: Initial implementation of drag and drop in the presets drawer.
- Allows drag and drop arrangement of custom user presets
- Does not allow reordering of built in presets.
- Sorting of presets now done only by type ie. built in and custom user.
- Provides functionality for future nested presets and drag and drop arranging.
- Subclasses the presets outline view for better control over drag and drop behavior
jbrjake [Fri, 7 Mar 2008 15:28:52 +0000 (15:28 +0000)]
Applies Dark_Shikari's Variable Adaptive Quantization patch v0.48 to libhb's copy of libx264. This major change to x264 drastically reduces blockiness on flat parts of the picture as well as blurring. It is on by default; to disable it, add "aq-strength=0" to your x264 options string. For now, it's only applied to jam builds. Make will come later.
sr55 [Fri, 7 Mar 2008 00:07:31 +0000 (00:07 +0000)]
WinGui:
- Fixed small localization issue in the query parser in regard to -q option.
- Changed update checker so if it fails on the startup update scan, it'll fail silently instead of displaying an error message behind the startup screen.
dynaflash [Thu, 6 Mar 2008 15:04:31 +0000 (15:04 +0000)]
MacGui: Presets - change the cursor highlighted color of the preset name to black, so when changing the name, you can see the letters. The old white made it almost impossible.... duh!
dynaflash [Thu, 6 Mar 2008 14:56:32 +0000 (14:56 +0000)]
MacGui: Fix issue where renaming a preset does not reflect the new name immediately in the preset drawer
- call [fPresetsOutlineView reloadData];
- use "-sortPresets" method instead of sorting it in its own method
dynaflash [Thu, 6 Mar 2008 13:57:37 +0000 (13:57 +0000)]
MacGui: move the presets sorting into a new method "-sortPresets" so it can be done independently of adding a preset in preparation for drag and drop preset arranging capability.
dynaflash [Thu, 6 Mar 2008 13:53:15 +0000 (13:53 +0000)]
MacGui: Increase the preset drawer max width and content view width by 60 px. This still leaves us 1024 width compatible and allows more room for longer preset names, vertical scroller as well as the disclosure triangles for nested presets.
dynaflash [Wed, 5 Mar 2008 14:29:45 +0000 (14:29 +0000)]
MacGui: Fix issue where prepareJob was not sensing MKV in the Format popup correctly.
- Takes care of the no mkv chapter issues reported here: http://forum.handbrake.fr/viewtopic.php?f=12&t=5120
- Thanks for the diagnostic testing and bringing it to our attention simoncoul !
van [Sun, 2 Mar 2008 09:18:19 +0000 (09:18 +0000)]
DVB teletext streams and ATSC AC3 audio streams use the same code points. If we misclassify teletext as audio we'll die early in the encode while trying to find an AC3 sync frame. So, if we don't find a sync frame after searching a megabyte of the stream decide it's not AC3, delete the audio entry & keep going.
Problem & test case from ncbp http://forum.handbrake.fr/viewtopic.php?p=29137#p29137.
van [Sun, 2 Mar 2008 05:15:56 +0000 (05:15 +0000)]
Don't crash just because some dvd title uses an illegal pgn number.
(Fixes bug reported in http://forum.handbrake.fr/viewtopic.php?p=28767&sid=23308d0c02b70fceb54db71b0d0f2660#p28767).
van [Sat, 1 Mar 2008 20:19:20 +0000 (20:19 +0000)]
Oops - left in a mistake from an intermediate version. We want aspect ratio from all previews but crop from only frame two (otherwise we'll crop down to nothing if there's a preview with a lot of black).
van [Fri, 29 Feb 2008 18:33:45 +0000 (18:33 +0000)]
Don't crash while scanning when we can't get previews for some title.
- if we get no previews for some title, ignore the title
- use the most common aspect ratio found from our 10 previews rather than just the aspect of preview 2 (otherwise we'll crash in hb_fix_aspect if we don't get preview 2).
- check parameters in hb_fix_aspect so we don't divide by zero.
van [Fri, 29 Feb 2008 18:24:46 +0000 (18:24 +0000)]
It's a good idea to have a buffer for every pid you decide to decode.
Max buffers was 1/4 max streams. This makes it same as max streams.
(Fixes crash reported by ncbp at http://forum.handbrake.fr/viewtopic.php?p=28899&sid=0c89bb9c9aed7eee51c294f25ac61e99#p28899)
dynaflash [Wed, 27 Feb 2008 16:32:15 +0000 (16:32 +0000)]
Adds Dark_Shikari's vbv 1 pass patch for x264
- While not optimal by any means according to Dark_Shikari over at x264, it definitely seems to help with the borked I frames we have been seeing using vbv 1 pass over x264 standard vbv.
- Rumors are that a more comprehensive fix is in the works for x264. But who wants to hold their breath. HB presets rely on vbv too much to have squashed I frames in the meantime.
eddyg [Tue, 26 Feb 2008 00:51:49 +0000 (00:51 +0000)]
Set an minimum subtitle display time of three seconds *or* until the next subtitle is displayed. This makes subtitles easier to read for the slow readers or for the DVD authors why display the subtitles for too short a period (e.g. only display the subtitles during the talking in a fast speaking tongue).
van [Mon, 25 Feb 2008 06:39:42 +0000 (06:39 +0000)]
Don't allow negative durations. These shouldn't happen but occasionally do due to upstream bugs. Replace them with a small positive duration so the mp4 file will be playable.
van [Mon, 25 Feb 2008 06:35:41 +0000 (06:35 +0000)]
Work-around for xvid crash - dct coeff tables are being loaded with SSE 'load aligned' instructions which require 16-byte alignment but either nasm or the loader is ignoring the .rodata section alignment request. Since .rodata is in the text section which is correctly aligned, pad the text section so it's 16-byte aligned which will cause the following data to be correctly aligned.
sr55 [Sun, 24 Feb 2008 18:40:27 +0000 (18:40 +0000)]
WinGui:
- Fixed bug where the chapter markers csv filename renamed the same for every item on the queue. This meant the same chapter names got added to each encode when in fact, each encode should have had a separate file.
- Disabled development expiry code.
dynaflash [Thu, 21 Feb 2008 14:33:01 +0000 (14:33 +0000)]
MacGui: Un-Banish the 64 bit mp4 checkbox from the Siberia known as the preferences now that we have a device and a preset designed specifically for 64 bit mp4's.
- Don't say it jbrjake :)
dynaflash [Thu, 21 Feb 2008 13:47:09 +0000 (13:47 +0000)]
MacGui: Fix and issue for auto adding the .m4v file extension for the aac + ac3 encoder for mp4 where reselecting mp4 format would reset the extension back to .mp4 and not .m4v
- Moves this to a new method called codecsPopUpChanged: so it is easier to call form multiple methods
dynaflash [Thu, 21 Feb 2008 13:20:21 +0000 (13:20 +0000)]
MacGui: Fix issue where canceling the open source window, then re opening it and selecting a source or cancelling is could cause a crash.
- Patch courtesy of Xeri
sr55 [Wed, 20 Feb 2008 16:36:09 +0000 (16:36 +0000)]
WinGui: minor bug fixes.
- Queue window now allows selection of queued items on the whole panel, not just the left side of the panel.
- Fixed a few rouge extensions not getting changed correctly when selecting a preset. (may need to revisit this for psp preset)
- When using AAC+AC3 use m4v if mp4 is currently on the extension.
- Fixed the user defaults not setting video / audio encode properly.
jbrjake [Mon, 18 Feb 2008 23:01:33 +0000 (23:01 +0000)]
Use 64-bit MP4 containers for the AppleTV preset, in case the 2500kb/s video and 448kb/s AC3 and 160kb/s AAC push the file size over 4 gigs for long movies.
sr55 [Mon, 18 Feb 2008 17:43:31 +0000 (17:43 +0000)]
WinGui:
- Fixed issue with iPod Atom displaying an error with the new presets when switching from a preset with ipod atom to one without.
- Fixed the CLI preset grab during startup. This wasn't working.
dynaflash [Mon, 18 Feb 2008 15:59:12 +0000 (15:59 +0000)]
MacGui: Make sure that mp4's using ac3 passthru whether by itself or in combination with aac use the .m4v file extension as otherwise quicktime will not play it at all.
jbrjake [Sun, 17 Feb 2008 06:15:29 +0000 (06:15 +0000)]
Signal anamorphic in the MP4 container though the pixel aspect atom as well as the transformation matrix. This allows anamorphic on the iPhone and iPod Touch. One day, if Apple fixes a QuickTime Player bug, the only way to get it to display right in QuickTime might be to remove the transformation matrix the AppleTV still depends upon. It's a gamble. Oh well.
jbrjake [Sun, 17 Feb 2008 06:09:18 +0000 (06:09 +0000)]
Msc OS Contrib Binaries ++ to 0022, bringing to make builds the wonders of AC3-in-MP4, multi-track audio and anamorphic for the iPhone, and a fresh copy of libx264 with the vbv 2-pass patch applied.
dynaflash [Sat, 16 Feb 2008 22:49:08 +0000 (22:49 +0000)]
MacGui: Change aac/ ac3 hybrid to utilize the codecs popup and only offer one mixdown for each additional choice.
- adds AVC h.264 / AAC + AC3 Audio and AVC h.264 / AC3
- First corresponds to the dpl2 + ac3 passthru mixdown
- Second corresponds to the AC3 pass thru mixdown
jbrjake [Sat, 16 Feb 2008 16:10:18 +0000 (16:10 +0000)]
Mcdeint is broken, so avoid using it as a deinterlacer. No more "Slowest," "Slow" becomes yadif without spatial checks, "Slower" becomes yadif with spatial checks.
jbrjake [Sat, 16 Feb 2008 15:15:52 +0000 (15:15 +0000)]
Wires up the CLI for doing AAC and AC3 at the same time, with a new audio encoder value, aac+ac3. Allows up to 4 source tracks to be selected, all are handled the same way. (Track-by-track audio configuration waits for 0.9.3.)
projects / handbrake / log