]> granicus.if.org Git - postgresql/log
postgresql
13 years agoFix untranslatable assembly of libpq connection failure message
Peter Eisentraut [Thu, 19 May 2011 19:56:53 +0000 (22:56 +0300)]
Fix untranslatable assembly of libpq connection failure message

Even though this only affects the insertion of a parenthesized word,
it's unwise to assume that parentheses can pass through untranslated.
And in any case, the new version is clearer in the code and for
translators.

13 years agoUpdate config.guess and config.sub
Peter Eisentraut [Thu, 19 May 2011 19:14:56 +0000 (22:14 +0300)]
Update config.guess and config.sub

13 years agoConsistent spacing for lengthy error messages
Peter Eisentraut [Thu, 19 May 2011 18:36:57 +0000 (21:36 +0300)]
Consistent spacing for lengthy error messages

Also, we removed the display of the current value of
max_connections/MaxBackends from some messages earlier, because it was
confusing, so do that in the remaining one as well.

13 years agoAdd example for replication in pg_hba.conf
Magnus Hagander [Thu, 19 May 2011 18:03:15 +0000 (14:03 -0400)]
Add example for replication in pg_hba.conf

Selena Deckelmann

13 years agoFix race condition in CheckTargetForConflictsIn.
Robert Haas [Thu, 19 May 2011 16:11:05 +0000 (12:11 -0400)]
Fix race condition in CheckTargetForConflictsIn.

Dan Ports

13 years agoFix declaration of $_TD in "strict" trigger functions
Alvaro Herrera [Thu, 19 May 2011 03:56:18 +0000 (23:56 -0400)]
Fix declaration of $_TD in "strict" trigger functions

This was broken in commit ef19dc6d39dd2490ff61489da55d95d6941140bf by
the Bunce/Hunsaker/Dunstan team, which moved the declaration from
plperl_create_sub to plperl_call_perl_trigger_func.  This doesn't
actually work because the validator code would not find the variable
declared; and even if you manage to get past the validator, it still
doesn't work because get_sv("_TD", GV_ADD) doesn't have the expected
effect.  The only reason this got beyond testing is that it only fails
in strict mode.

We need to declare it as a global just like %_SHARED; it is simpler than
trying to actually do what the patch initially intended, and is said to
have the same performance benefit.

As a more serious issue, fix $_TD not being properly local()ized,
meaning nested trigger functions would clobber $_TD.

Alex Hunsaker, per test report from Greg Mullane

13 years agoReplace strdup() with pstrdup(), to avoid leaking memory.
Heikki Linnakangas [Thu, 19 May 2011 02:30:24 +0000 (22:30 -0400)]
Replace strdup() with pstrdup(), to avoid leaking memory.

It's been like this since the seg module was introduced, so backpatch to
8.2 which is the oldest supported version.

13 years agoIn pg_upgrade, clean up handling of invalid directory specification by
Bruce Momjian [Thu, 19 May 2011 02:22:40 +0000 (22:22 -0400)]
In pg_upgrade, clean up handling of invalid directory specification by
checking the stat() errno value more strictly.

13 years agoImprove pg_upgrade error reporting if the bin or data directories do not
Bruce Momjian [Wed, 18 May 2011 22:36:52 +0000 (18:36 -0400)]
Improve pg_upgrade error reporting if the bin or data directories do not
exist or are not directories.

13 years agoRemove obsolete comment
Peter Eisentraut [Wed, 18 May 2011 22:19:57 +0000 (01:19 +0300)]
Remove obsolete comment

13 years agoSpell checking and markup refinement
Peter Eisentraut [Wed, 18 May 2011 22:14:45 +0000 (01:14 +0300)]
Spell checking and markup refinement

13 years ago/contrib/foo -> contrib/foo
Peter Eisentraut [Wed, 18 May 2011 21:30:31 +0000 (00:30 +0300)]
/contrib/foo -> contrib/foo

Since contrib is a relative directory specification, a leading slash
is inappropriate.

13 years agoImprove pg_upgrade X_OK comment.
Bruce Momjian [Wed, 18 May 2011 16:25:34 +0000 (12:25 -0400)]
Improve pg_upgrade X_OK comment.

13 years agoFix pg_upgrade build problem on Windows when using X_OK access
Bruce Momjian [Wed, 18 May 2011 16:13:37 +0000 (12:13 -0400)]
Fix pg_upgrade build problem on Windows when using X_OK access
permission check on the current directory.

13 years agoFix pg_dump's handling of extension-member casts and languages.
Tom Lane [Mon, 16 May 2011 20:41:52 +0000 (16:41 -0400)]
Fix pg_dump's handling of extension-member casts and languages.

pg_dump has some heuristic rules for whether to dump casts and procedural
languages, since it's not all that easy to distinguish built-in ones from
user-defined ones.  However, we should not apply those rules to objects
that belong to an extension, but just use the perfectly well-defined rules
for what to do with extension member objects.  Otherwise we might
mistakenly lose extension member objects during a binary upgrade (which is
the only time that we'd want to dump extension members).

13 years agoUpdate pg_upgrade directory check error message.
Bruce Momjian [Mon, 16 May 2011 16:32:36 +0000 (12:32 -0400)]
Update pg_upgrade directory check error message.

13 years agoRemove redundant privilege doc sentences.
Bruce Momjian [Mon, 16 May 2011 15:22:25 +0000 (11:22 -0400)]
Remove redundant privilege doc sentences.

13 years agoAdd pg_upgrade check to make sure the user has full access permission in
Bruce Momjian [Mon, 16 May 2011 15:01:29 +0000 (11:01 -0400)]
Add pg_upgrade check to make sure the user has full access permission in
the current directory;  if not, throw an error.

13 years agoAllow pg_upgrade to honor libpq environment variables. Add 'local'
Bruce Momjian [Mon, 16 May 2011 14:46:52 +0000 (10:46 -0400)]
Allow pg_upgrade to honor libpq environment variables.  Add 'local'
checks for PGHOST and PGHOSTADDR.

13 years agoQuote isolationtester command name so Windows will not think dot is the command.
Andrew Dunstan [Mon, 16 May 2011 03:42:12 +0000 (23:42 -0400)]
Quote isolationtester command name so Windows will not think dot is the command.

13 years agoAdd required psqldir setting for isolation checks.
Andrew Dunstan [Mon, 16 May 2011 03:12:36 +0000 (23:12 -0400)]
Add required psqldir setting for isolation checks.

13 years agoFix bad macro call noticed by MSVC compiler.
Andrew Dunstan [Sun, 15 May 2011 22:45:26 +0000 (18:45 -0400)]
Fix bad macro call noticed by MSVC compiler.

13 years agoAdd missing check function lookup.
Andrew Dunstan [Sun, 15 May 2011 22:03:19 +0000 (18:03 -0400)]
Add missing check function lookup.

13 years agoBuild and run isolation test programs under MSVC.
Andrew Dunstan [Sun, 15 May 2011 21:55:05 +0000 (17:55 -0400)]
Build and run isolation test programs under MSVC.

13 years agoMore cleanup of FOREIGN TABLE permissions handling.
Robert Haas [Fri, 13 May 2011 19:47:31 +0000 (15:47 -0400)]
More cleanup of FOREIGN TABLE permissions handling.

This commit fixes psql, pg_dump, and the information schema to be
consistent with the backend changes which I made as part of commit
be90032e0d1cf473bdd99aee94218218f59f29f1, and also includes a
related documentation tweak.

Shigeru Hanada, with slight adjustment.

13 years agoKill stray "not".
Robert Haas [Thu, 12 May 2011 21:10:30 +0000 (17:10 -0400)]
Kill stray "not".

13 years agoFix write-past-buffer-end in ldapServiceLookup().
Tom Lane [Thu, 12 May 2011 15:56:38 +0000 (11:56 -0400)]
Fix write-past-buffer-end in ldapServiceLookup().

The code to assemble ldap_get_values_len's output into a single string
wrote the terminating null one byte past where it should.  Fix that,
and make some other cosmetic adjustments to make the code a trifle more
readable and more in line with usual Postgres coding style.

Also, free the "result" string when done with it, to avoid a permanent
memory leak.

Bug report and patch by Albe Laurenz, cosmetic adjustments by me.

13 years agoFix assorted typos
Alvaro Herrera [Wed, 2 Feb 2011 00:07:42 +0000 (19:07 -0500)]
Fix assorted typos

13 years agoSplit PGC_S_DEFAULT into two values, for true boot_val vs computed default.
Tom Lane [Wed, 11 May 2011 23:57:38 +0000 (19:57 -0400)]
Split PGC_S_DEFAULT into two values, for true boot_val vs computed default.

Failure to distinguish these cases is the real cause behind the recent
reports of Windows builds crashing on 'infinity'::timestamp, which was
directly due to failure to establish a value of timezone_abbreviations
in postmaster child processes.  The postmaster had the desired value,
but write_one_nondefault_variable() didn't transmit it to backends.

To fix that, invent a new value PGC_S_DYNAMIC_DEFAULT, and be sure to use
that or PGC_S_ENV_VAR (as appropriate) for "default" settings that are
computed during initialization.  (We need both because there's at least
one variable that could receive a value from either source.)

This commit also fixes ProcessConfigFile's failure to restore the correct
default value for certain GUC variables if they are set in postgresql.conf
and then removed/commented out of the file.  We have to recompute and
reinstall the value for any GUC variable that could have received a value
from PGC_S_DYNAMIC_DEFAULT or PGC_S_ENV_VAR sources, and there were a
number of oversights.  (That whole thing is a crock that needs to be
redesigned, but not today.)

However, I intentionally didn't make it work "exactly right" for the cases
of timezone and log_timezone.  The exactly right behavior would involve
running select_default_timezone, which we'd have to do independently in
each postgres process, causing the whole database to become entirely
unresponsive for as much as several seconds.  That didn't seem like a good
idea, especially since the variable's removal from postgresql.conf might be
just an accidental edit.  Instead the behavior is to adopt the previously
active setting as if it were default.

Note that this patch creates an ABI break for extensions that use any of
the PGC_S_XXX constants; they'll need to be recompiled.

13 years agoClean up parsing of CREATE TRIGGER's argument list.
Tom Lane [Wed, 11 May 2011 18:43:01 +0000 (14:43 -0400)]
Clean up parsing of CREATE TRIGGER's argument list.

Use ColLabel in place of ColId, so that reserved words are accepted as if
they were not reserved.  Also, remove BCONST and XCONST, which were never
documented as allowed.  Allowing those exposes to users an implementation
detail, namely the format in which the lexer outputs such constants, that
seems unwise to expose.

No documentation change needed, since this just makes the code act more
like you'd expect from reading the CREATE TRIGGER man page.

Per complaint from Szymon Guz and subsequent discussion.

13 years agoShut down WAL receiver if it's still running at end of recovery. We used to
Heikki Linnakangas [Wed, 11 May 2011 09:46:08 +0000 (12:46 +0300)]
Shut down WAL receiver if it's still running at end of recovery. We used to
just check that it's not running and PANIC if it was, but that can rightfully
happen if recovery stops at recovery target.

13 years agoBe more explicit about the meaning of the change in standard_conforming_strings.
Tom Lane [Wed, 11 May 2011 03:44:33 +0000 (23:44 -0400)]
Be more explicit about the meaning of the change in standard_conforming_strings.

13 years agoMention "backslash" escape processing change in 9.1 release notes.
Bruce Momjian [Wed, 11 May 2011 00:56:44 +0000 (20:56 -0400)]
Mention "backslash" escape processing change in 9.1 release notes.

13 years agoPrevent datebsearch() from crashing on base == NULL && nel == 0.
Tom Lane [Wed, 11 May 2011 00:36:22 +0000 (20:36 -0400)]
Prevent datebsearch() from crashing on base == NULL && nel == 0.

Normally nel == 0 works okay because the initial value of "last" will be
less than "base"; but if "base" is zero then the calculation wraps around
and we have a very large (unsigned) value for "last", so that the loop can
be entered and we get a SIGSEGV on a bogus pointer.

This is certainly the proximate cause of the recent reports of Windows
builds crashing on 'infinity'::timestamp --- evidently, they're either not
setting an active timezonetktbl, or setting an empty one.  It's not yet
clear to me why it's only happening on Windows and not happening on any
buildfarm member.  But even if that's due to some bug elsewhere, it seems
wise for this function to not choke on the powerup values of
timezonetktbl/sztimezonetktbl.

I also changed the copy of this code in ecpglib, although I am not sure
whether it's exposed to a similar hazard.

Per report and stack trace from Richard Broersma.

13 years agoFor create/dropdb, only connect once to the server since we now have a
Bruce Momjian [Tue, 10 May 2011 23:44:15 +0000 (19:44 -0400)]
For create/dropdb, only connect once to the server since we now have a
shared description table for pg_database comments.

Also update comments about database name selection.

13 years agoAdd some punctuation
Peter Eisentraut [Tue, 10 May 2011 19:37:50 +0000 (22:37 +0300)]
Add some punctuation

13 years agoPut options in more alphabetical order
Peter Eisentraut [Tue, 10 May 2011 19:37:22 +0000 (22:37 +0300)]
Put options in more alphabetical order

13 years agoPut options help in alphabetical order
Peter Eisentraut [Tue, 10 May 2011 18:48:07 +0000 (21:48 +0300)]
Put options help in alphabetical order

13 years agoFormat pg_upgrade --version in line with conventions
Peter Eisentraut [Tue, 10 May 2011 18:40:29 +0000 (21:40 +0300)]
Format pg_upgrade --version in line with conventions

13 years agoAdd bug report line to pg_upgrade --help output
Peter Eisentraut [Tue, 10 May 2011 18:37:55 +0000 (21:37 +0300)]
Add bug report line to pg_upgrade --help output

13 years agoPut pg_test_fsync --help and --version output in line with conventions
Peter Eisentraut [Tue, 10 May 2011 18:34:26 +0000 (21:34 +0300)]
Put pg_test_fsync --help and --version output in line with conventions

Foremost, it should go to stdout.

13 years agoAdjust documentation with respect to "unknown" timezone setting.
Tom Lane [Tue, 10 May 2011 17:48:40 +0000 (13:48 -0400)]
Adjust documentation with respect to "unknown" timezone setting.

The recent cleanup of GUC assign hooks got rid of the kludge of using
"unknown" as a magic value for timezone and log_timezone.  But I forgot
to update the documentation to match, as noted by Martin Pitt.

13 years agoBe more wary in initdb's creation of platform-dependent collations.
Tom Lane [Tue, 10 May 2011 16:08:47 +0000 (12:08 -0400)]
Be more wary in initdb's creation of platform-dependent collations.

Discard any collation aliases that match the built-in pg_collation entries
(ie, "default", "C", "POSIX").  Such aliases would be refused by a CREATE
COLLATION command, but since initdb is injecting them via a simple INSERT,
it has to make the corresponding check for itself.  Per Martin Pitt's
report of funny behavior in a machine that had a bogus "C.UTF-8" locale.

Also, use E'' syntax for the output of escape_quotes, as per its header
comment.

13 years agoIn pg_upgrade, remove suggestion of setting pg_hba.conf to 'trust', now
Bruce Momjian [Tue, 10 May 2011 14:42:43 +0000 (10:42 -0400)]
In pg_upgrade, remove suggestion of setting pg_hba.conf to 'trust', now
that we report the libpq connection failure string.  Per suggestion from
Robert Haas.

13 years agoDocumentation cleanup for the possible values of the datatype 'boolean'.
Bruce Momjian [Tue, 10 May 2011 03:25:16 +0000 (23:25 -0400)]
Documentation cleanup for the possible values of the datatype 'boolean'.

13 years agoUpdate documentation to state there is three-value logic, not
Bruce Momjian [Tue, 10 May 2011 01:04:18 +0000 (21:04 -0400)]
Update documentation to state there is three-value logic, not
three-value boolean logic.

Backpatch to 9.0.X since we just got another bug report about this
today.

13 years agoRemove "make check" target in src/test/isolation/Makefile.
Tom Lane [Mon, 9 May 2011 15:00:30 +0000 (11:00 -0400)]
Remove "make check" target in src/test/isolation/Makefile.

This doesn't work as expected because the isolationtester program requires
libpq to already be installed.  While it works when you've already installed
libpq, having to already have done "make install" defeats most of the point
of a check with a temp installation.  And there are weird corner cases if
the dynamic linker picks up an old libpq.so from system library directories.
Remove the target (or more precisely, make it print a helpful message) so
people don't expect the case to work.

13 years agoIn pg_upgrade, add status message about superuser check.
Bruce Momjian [Mon, 9 May 2011 12:55:36 +0000 (08:55 -0400)]
In pg_upgrade, add status message about superuser check.

13 years agoAdd C comment about the fact that the autovacuum limit can go backwards
Bruce Momjian [Mon, 9 May 2011 03:59:31 +0000 (23:59 -0400)]
Add C comment about the fact that the autovacuum limit can go backwards
by 3, but that is it OK.

13 years agoFix some portability issues in isolation regression test driver.
Tom Lane [Sun, 8 May 2011 23:44:12 +0000 (19:44 -0400)]
Fix some portability issues in isolation regression test driver.

Remove random system #includes in favor of using postgres_fe.h.  (The
alternative to that is letting this module grow its own configuration
testing ability...)

Also fix the "make clean" target to actually clean things up.

Per local testing.

13 years agoAdd C comment why client encoding can be set in pg_upgrade.
Bruce Momjian [Sun, 8 May 2011 02:30:35 +0000 (22:30 -0400)]
Add C comment why client encoding can be set in pg_upgrade.

13 years agoAdd xreflabels to /contrib manuals so links appear correct. Also update
Bruce Momjian [Sun, 8 May 2011 02:29:20 +0000 (22:29 -0400)]
Add xreflabels to /contrib manuals so links appear correct.  Also update
README.links to explain xref properly.

13 years agoAdd missing documention connecting word.
Bruce Momjian [Sat, 7 May 2011 18:31:00 +0000 (14:31 -0400)]
Add missing documention connecting word.

13 years agoIn pg_upgrade, report non-super-user username in error message.
Bruce Momjian [Sat, 7 May 2011 16:17:21 +0000 (12:17 -0400)]
In pg_upgrade, report non-super-user username in error message.

13 years agoCheck that the pg_upgrade user specified is a super-user.
Bruce Momjian [Sat, 7 May 2011 12:55:13 +0000 (08:55 -0400)]
Check that the pg_upgrade user specified is a super-user.

Also report the error message when the post-pg_ctl connection fails.

Per private bug report from EnterpriseDB.

13 years agoAdd comment about memory reordering to PredicateLockTupleRowVersionLink.
Robert Haas [Sat, 7 May 2011 01:53:55 +0000 (21:53 -0400)]
Add comment about memory reordering to PredicateLockTupleRowVersionLink.

Dan Ports, per head-scratching from Simon Riggs and myself.

13 years agoAdjust pg_upgrade FATAL error messages to have consistent newlines.
Bruce Momjian [Sat, 7 May 2011 01:47:12 +0000 (21:47 -0400)]
Adjust pg_upgrade FATAL error messages to have consistent newlines.

Also adjust some error message capitalization for consistency.

13 years agoFix typos in SECURITY LABEL documentation.
Robert Haas [Sat, 7 May 2011 01:18:18 +0000 (21:18 -0400)]
Fix typos in SECURITY LABEL documentation.

KaiGai Kohei

13 years agoImprove compiler string shown in version()
Peter Eisentraut [Fri, 6 May 2011 19:14:53 +0000 (22:14 +0300)]
Improve compiler string shown in version()

With some compilers such as Clang and ICC emulating GCC, using a
version string of the form "GCC $version" can be quite misleading.
Also, a great while ago, the version output from gcc --version started
including the string "gcc", so it is redundant to repeat that.  In
order to support ancient GCC versions, we now prefix the result with
"GCC " only if the version output does not start with a letter.

13 years agoMove RegisterPredicateLockingXid() call to a safer place.
Tom Lane [Fri, 6 May 2011 16:57:28 +0000 (12:57 -0400)]
Move RegisterPredicateLockingXid() call to a safer place.

The SSI patch inserted a call of RegisterPredicateLockingXid into
GetNewTransactionId, which was a bad idea on a couple of grounds.  First,
it's not necessary to hold XidGenLock while manipulating that shared
memory, and doing so is bad because XidGenLock is a high-contention lock
that should be held for as short a time as possible.  (Not to mention that
it adds an entirely unnecessary deadlock hazard, since we must take
SerializableXactHashLock as well.)  Second, the specific place where it was
put was between extending CLOG and advancing nextXid, which could result in
unpleasant behavior in case of a failure there.  Pull the call out to
AssignTransactionId, which is much safer and arguably better from a
modularity standpoint too.

There is more work to do to clean up the failure-before-advancing-nextXid
issue, but that is a separate change that will need to be back-patched.
So for the moment I just want to make GetNewTransactionId look the same as
it did in prior versions.

13 years agoRemove precedence labeling of keywords TRUE, FALSE, UNKNOWN, and ZONE.
Tom Lane [Fri, 6 May 2011 00:38:52 +0000 (20:38 -0400)]
Remove precedence labeling of keywords TRUE, FALSE, UNKNOWN, and ZONE.

These were labeled with precedences just to avoid attaching explicit
precedences to the productions in which they were the last terminal symbol.
Since a terminal symbol precedence marking can affect many other things
too, it seems like better practice to attach precedence labels to the
productions, and not mark the terminal symbols.

Ideally we'd also remove the precedence attached to NULL_P, but it turns
out that we are actually depending on that having a precedence higher than
POSTFIXOP, else we get a shift/reduce conflict for postfix operators in
b_expr.  (Which more or less proves my point about these markings having a
high risk of unexpected consequences.)  For the moment, move NULL_P into
the set of keywords grouped with IDENT, so that at least it will act
similarly to non-keywords; and document the interaction.

13 years agoUnbreak the regression tests from my previous commit
Magnus Hagander [Thu, 5 May 2011 21:00:31 +0000 (23:00 +0200)]
Unbreak the regression tests from my previous commit

13 years agoImprove pg_archivecleanup and pg_standby --help output
Peter Eisentraut [Thu, 5 May 2011 20:11:51 +0000 (23:11 +0300)]
Improve pg_archivecleanup and pg_standby --help output

For consistency with other tools, put the options before further usage
information.

In pg_standby, remove the supposedly deprecated -l option from the
given example invocation.

13 years agoImprove formatting of pg_upgrade --help output
Peter Eisentraut [Thu, 5 May 2011 19:56:06 +0000 (22:56 +0300)]
Improve formatting of pg_upgrade --help output

13 years agoClarify error message when attempting to create index on foreign table
Magnus Hagander [Thu, 5 May 2011 19:47:42 +0000 (21:47 +0200)]
Clarify error message when attempting to create index on foreign table

Instead of just saying "is not a table", specifically state that
indexes aren't supported on *foreign* tables.

13 years agoImprove style of generate_history.pl Perl script.
Bruce Momjian [Thu, 5 May 2011 16:48:48 +0000 (12:48 -0400)]
Improve style of generate_history.pl Perl script.

13 years agoInclude unary plus in the Operator Precedence table.
Tom Lane [Wed, 4 May 2011 19:02:34 +0000 (15:02 -0400)]
Include unary plus in the Operator Precedence table.

Per gripe from Grzegorz Szpetkowski.

Also, change the subsection heading from "Lexical Precedence" (which is
a contradiction in terms) to "Operator Precedence".

13 years agoRemove redundant port number check
Peter Eisentraut [Wed, 4 May 2011 18:02:02 +0000 (21:02 +0300)]
Remove redundant port number check

pg_basebackup doesn't need to police the format of port numbers.
libpq already does that.

13 years agoMessage style cleanup
Peter Eisentraut [Wed, 4 May 2011 17:56:52 +0000 (20:56 +0300)]
Message style cleanup

13 years agoFix alignment of --help output
Peter Eisentraut [Wed, 4 May 2011 17:29:40 +0000 (20:29 +0300)]
Fix alignment of --help output

Tabs replaced by spaces.

13 years agoLink some tables into the surrounding text by their id
Peter Eisentraut [Wed, 4 May 2011 17:24:07 +0000 (20:24 +0300)]
Link some tables into the surrounding text by their id

13 years agoUpdate obsolete mention of Sequoia, now known as Tungsten
Alvaro Herrera [Tue, 3 May 2011 14:35:17 +0000 (11:35 -0300)]
Update obsolete mention of Sequoia, now known as Tungsten

Per http://joomla.aws.continuent.com/community/lab-projects/sequoia

Greg Smith

13 years agoImprove description of read/write traffic scalability
Alvaro Herrera [Tue, 3 May 2011 14:34:27 +0000 (11:34 -0300)]
Improve description of read/write traffic scalability

Greg Smith, after a suggestion of James Bruce

13 years agoAdd ID attribute to some sect2's missing it
Alvaro Herrera [Mon, 2 May 2011 22:13:49 +0000 (19:13 -0300)]
Add ID attribute to some sect2's missing it

David Fetter

13 years agoFix pull_up_sublinks' failure to handle nested pull-up opportunities.
Tom Lane [Mon, 2 May 2011 19:56:36 +0000 (15:56 -0400)]
Fix pull_up_sublinks' failure to handle nested pull-up opportunities.

After finding an EXISTS or ANY sub-select that can be converted to a
semi-join or anti-join, we should recurse into the body of the sub-select.
This allows cases such as EXISTS-within-EXISTS to be optimized properly.
The original coding would leave the lower sub-select as a SubLink, which
is no better and often worse than what we can do with a join.  Per example
from Wayne Conrad.

Back-patch to 8.4.  There is a related issue in older versions' handling
of pull_up_IN_clauses, but they're lame enough anyway about the whole area
that it seems not worth the extra work to try to fix.

13 years agoUpdate some ALTER USER cross-references to ALTER ROLE
Alvaro Herrera [Mon, 2 May 2011 16:40:24 +0000 (13:40 -0300)]
Update some ALTER USER cross-references to ALTER ROLE

Greg Smith

13 years agoSmall cleanup of spacing in verbatim DocBook elements
Peter Eisentraut [Mon, 2 May 2011 16:19:48 +0000 (19:19 +0300)]
Small cleanup of spacing in verbatim DocBook elements

13 years agoImprove aset.c's space management in contexts with small maxBlockSize.
Tom Lane [Mon, 2 May 2011 16:08:08 +0000 (12:08 -0400)]
Improve aset.c's space management in contexts with small maxBlockSize.

The previous coding would allow requests up to half of maxBlockSize to be
treated as "chunks", but when that actually did happen, we'd waste nearly
half of the space in the malloc block containing the chunk, if no smaller
requests came along to fill it.  Avoid this scenario by limiting the
maximum size of a chunk to 1/8th maxBlockSize, so that we can waste no more
than 1/8th of the allocated space.  This will not change the behavior at
all for the default context size parameters (with large maxBlockSize),
but it will change the behavior when using ALLOCSET_SMALL_MAXSIZE.

In particular, there's no longer a need for spell.c to be overly concerned
about the request size parameters it uses, so remove a rather unhelpful
comment about that.

Merlin Moncure, per an idea of Tom Lane's

13 years agoCatch errors in for loop in makefile
Peter Eisentraut [Sun, 1 May 2011 21:43:06 +0000 (00:43 +0300)]
Catch errors in for loop in makefile

Add "|| exit" so that the rule aborts when a command fails.

13 years agoRewrite installation makefile rules without for loops
Peter Eisentraut [Sun, 1 May 2011 21:37:07 +0000 (00:37 +0300)]
Rewrite installation makefile rules without for loops

install-sh can install multiple files at once, so for loops are not
necessary.  This was already changed for the rest of the code some
time ago, but pgxs.mk was apparently forgotten, and the obsolete
coding style has now been copied to the PLs as well.

This also fixes the problem that the for loops in question did not
catch errors.

13 years agoMake CLUSTER lock the old table's toast table before copying data.
Tom Lane [Sun, 1 May 2011 21:57:33 +0000 (17:57 -0400)]
Make CLUSTER lock the old table's toast table before copying data.

We must lock out autovacuuming of the old toast table before computing the
OldestXmin horizon we will use.  Otherwise, autovacuum could start on the
toast table later, compute a later OldestXmin horizon, and remove as DEAD
toast tuples that we still need (because we think their parent tuples are
only RECENTLY_DEAD).  Per further thought about bug #5998.

13 years agoLowercase status labels in pg_stat_replication view.
Bruce Momjian [Sat, 30 Apr 2011 02:20:14 +0000 (22:20 -0400)]
Lowercase status labels in pg_stat_replication view.

13 years agoRemove special case for xmin == xmax in HeapTupleSatisfiesVacuum().
Tom Lane [Fri, 29 Apr 2011 20:29:42 +0000 (16:29 -0400)]
Remove special case for xmin == xmax in HeapTupleSatisfiesVacuum().

VACUUM was willing to remove a committed-dead tuple immediately if it was
deleted by the same transaction that inserted it.  The idea is that such a
tuple could never have been visible to any other transaction, so we don't
need to keep it around to satisfy MVCC snapshots.  However, there was
already an exception for tuples that are part of an update chain, and this
exception created a problem: we might remove TOAST tuples (which are never
part of an update chain) while their parent tuple stayed around (if it was
part of an update chain).  This didn't pose a problem for most things,
since the parent tuple is indeed dead: no snapshot will ever consider it
visible.  But MVCC-safe CLUSTER had a problem, since it will try to copy
RECENTLY_DEAD tuples to the new table.  It then has to copy their TOAST
data too, and would fail if VACUUM had already removed the toast tuples.

Easiest fix is to get rid of the special case for xmin == xmax.  This may
delay reclaiming dead space for a little bit in some cases, but it's by far
the most reliable way to fix the issue.

Per bug #5998 from Mark Reid.  Back-patch to 8.3, which is the oldest
version with MVCC-safe CLUSTER.

13 years agoRewrite pg_size_pretty() to avoid compiler bug.
Tom Lane [Fri, 29 Apr 2011 05:44:50 +0000 (01:44 -0400)]
Rewrite pg_size_pretty() to avoid compiler bug.

Convert it to use successive shifts right instead of increasing a divisor.
This is probably a tad more efficient than the original coding, and it's
nicer-looking than the previous patch because we don't need a special case
to avoid overflow in the last branch.  But the real reason to do it is to
avoid a Solaris compiler bug, as per results from buildfarm member moa.

13 years agoUse non-literal format for possibly non-standard strftime formats.
Andrew Dunstan [Thu, 28 Apr 2011 23:58:49 +0000 (19:58 -0400)]
Use non-literal format for possibly non-standard strftime formats.

Per recent -hackers discussion. The formats in question are %G and %V,
and cause warnings on MinGW at least. We assume the ecpg application
knows what it's doing if it passes these formats to the library.

13 years agoAdd some casts to try to silence most of the remaining format warnings on MinGW-W64.
Andrew Dunstan [Thu, 28 Apr 2011 19:05:58 +0000 (15:05 -0400)]
Add some casts to try to silence most of the remaining format warnings on MinGW-W64.

13 years agoUse a macro variable PG_PRINTF_ATTRIBUTE for the style used for checking printf type...
Andrew Dunstan [Thu, 28 Apr 2011 14:56:14 +0000 (10:56 -0400)]
Use a macro variable PG_PRINTF_ATTRIBUTE for the style used for checking printf type functions.

The style is set to "printf" for backwards compatibility everywhere except
on Windows, where it is set to "gnu_printf", which eliminates hundreds of
false error messages from modern versions of gcc arising from  %m and %ll{d,u}
formats.

13 years agoThe arguments to pg_ctl kill are not optional - remove brackets in the docs.
Heikki Linnakangas [Thu, 28 Apr 2011 09:51:02 +0000 (12:51 +0300)]
The arguments to pg_ctl kill are not optional - remove brackets in the docs.

Fujii Masao

13 years agoTag 9.1beta1. REL9_1_BETA1
Tom Lane [Wed, 27 Apr 2011 21:17:22 +0000 (17:17 -0400)]
Tag 9.1beta1.

13 years agoMake a quick copy-editing pass over the 9.1 release notes.
Tom Lane [Wed, 27 Apr 2011 20:51:46 +0000 (16:51 -0400)]
Make a quick copy-editing pass over the 9.1 release notes.

Also remove the material about this being an alpha release.

The notes still need a lot of work, but they're more or less presentable
as a beta version now.

13 years agoFix binary upgrade of altered typed tables
Peter Eisentraut [Wed, 27 Apr 2011 19:08:22 +0000 (22:08 +0300)]
Fix binary upgrade of altered typed tables

Instead of dumping them as CREATE TABLE ... OF, dump them as normal
tables with the usual special processing for dropped columns, and then
attach them to the type afterward, using ALTER TABLE ... OF.  This is
analogous to the existing handling of inherited tables.

13 years agoRevert "Force use of "%I64d" format for 64 bit ints on MinGW."
Andrew Dunstan [Wed, 27 Apr 2011 18:55:18 +0000 (14:55 -0400)]
Revert "Force use of "%I64d" format for 64 bit ints on MinGW."

This reverts commit 52d01c2f52c462d29ae0fdfa44c3cae129148a6d.

the UINT64_FORMAT bit broke the b uildfarm, so I'm reverting the whole thing pending further investigation.

13 years agotimeline is not needed in BaseBackup()
Magnus Hagander [Wed, 27 Apr 2011 18:39:20 +0000 (20:39 +0200)]
timeline is not needed in BaseBackup()

This code was accidentally part of the patch, it's only
needed for the code that's for 9.2. Not needing the timeline
also removes the need to call IDENTIFY_SYSTEM.

Noted by Peter E.

13 years agoAdd comments about the need to avoid uninitialized bits in datatype values.
Tom Lane [Wed, 27 Apr 2011 18:05:58 +0000 (14:05 -0400)]
Add comments about the need to avoid uninitialized bits in datatype values.

There was already one recommendation in the documentation about writing
C functions to ensure padding bytes are zeroes, but make it stronger.

Also fix an example that was still using direct assignment to a varlena
length word, which no longer works since the varvarlena changes.

13 years agoFix array- and path-creating functions to ensure padding bytes are zeroes.
Tom Lane [Wed, 27 Apr 2011 17:58:36 +0000 (13:58 -0400)]
Fix array- and path-creating functions to ensure padding bytes are zeroes.

Per recent discussion, it's important for all computed datums (not only the
results of input functions) to not contain any ill-defined (uninitialized)
bits.  Failing to ensure that can result in equal() reporting that
semantically indistinguishable Consts are not equal, which in turn leads to
bizarre and undesirable planner behavior, such as in a recent example from
David Johnston.  We might eventually try to fix this in a general manner by
allowing datatypes to define identity-testing functions, but for now the
path of least resistance is to expect datatypes to force all unused bits
into consistent states.

Per some testing by Noah Misch, array and path functions seem to be the
only ones presenting risks at the moment, so I looked through all the
functions in adt/array*.c and geo_ops.c and fixed them as necessary.  In
the array functions, the easiest/safest fix is to allocate result arrays
with palloc0 instead of palloc.  Possibly in future someone will want to
look into whether we can just zero the padding bytes, but that looks too
complex for a back-patchable fix.  In the path functions, we already had a
precedent in path_in for just zeroing the one known pad field, so duplicate
that code as needed.

Back-patch to all supported branches.

13 years agoRevert "Remove hard coded formats for INT64 and use configured settings instead."
Andrew Dunstan [Wed, 27 Apr 2011 15:28:14 +0000 (11:28 -0400)]
Revert "Remove hard coded formats for INT64 and use configured settings instead."

This reverts commit 9b1508af8971c1627cda5bb65f5e9eddb9a1a55e.

As requested by Tom.

13 years agoRemove hard coded formats for INT64 and use configured settings instead.
Andrew Dunstan [Wed, 27 Apr 2011 15:07:52 +0000 (11:07 -0400)]
Remove hard coded formats for INT64 and use configured settings instead.

13 years agoForce use of "%I64d" format for 64 bit ints on MinGW.
Andrew Dunstan [Wed, 27 Apr 2011 14:09:23 +0000 (10:09 -0400)]
Force use of "%I64d" format for 64 bit ints on MinGW.

Both this and "%lld" work, but the compiler's format checking doesn't
like "%lld", so we get all sorts of spurious warnings.

13 years agoUse an explicit format string to keep the compiler happy.
Andrew Dunstan [Wed, 27 Apr 2011 14:02:21 +0000 (10:02 -0400)]
Use an explicit format string to keep the compiler happy.

13 years agoDoc wording improvement for NUMERIC limit paragraph.
Bruce Momjian [Wed, 27 Apr 2011 04:06:37 +0000 (00:06 -0400)]
Doc wording improvement for NUMERIC limit paragraph.