]> granicus.if.org Git - taglib/log
taglib
19 years agoSVN_SILENT a couple of missing docs
Scott Wheeler [Tue, 18 Oct 2005 12:33:48 +0000 (12:33 +0000)]
SVN_SILENT a couple of missing docs

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@471683 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoSilly second declaration of the variable here that triggers an infinite
Scott Wheeler [Tue, 27 Sep 2005 14:34:32 +0000 (14:34 +0000)]
Silly second declaration of the variable here that triggers an infinite
loop in some cases (I'm surprised that it doesn't happen in more...this
code has been around for a while.).

BUG:113437

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@464483 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoA couple of things pointed out by a colleage -- fix ByteVector::size()
Scott Wheeler [Mon, 12 Sep 2005 16:52:07 +0000 (16:52 +0000)]
A couple of things pointed out by a colleage -- fix ByteVector::size()
and make the return type semantics consistant for methods that modify
the object (specifically, return a reference instead of void).

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@460002 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoJust a couple of docs updates.
Scott Wheeler [Tue, 6 Sep 2005 11:39:26 +0000 (11:39 +0000)]
Just a couple of docs updates.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@457702 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoFix the documentation for this method.
Scott Wheeler [Sun, 4 Sep 2005 20:06:27 +0000 (20:06 +0000)]
Fix the documentation for this method.

CCMAIL:Umesh Shankar <ushankar@cs.berkeley.edu>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@457127 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoLeave the year field blank if it's set to zero (i.e. cleared).
Scott Wheeler [Wed, 10 Aug 2005 08:33:28 +0000 (08:33 +0000)]
Leave the year field blank if it's set to zero (i.e. cleared).

BUG:109920

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@444448 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoForgot that this doesn't work for those not using
Scott Wheeler [Wed, 27 Jul 2005 07:29:41 +0000 (07:29 +0000)]
Forgot that this doesn't work for those not using
my hacked up build environment for TagLib.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@439118 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoLast docs updates and a small function signature change. I'm pretty sure that's...
Scott Wheeler [Wed, 27 Jul 2005 00:25:40 +0000 (00:25 +0000)]
Last docs updates and a small function signature change.  I'm pretty sure that's it for 1.4.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@439059 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agonote other bindings
Scott Wheeler [Tue, 26 Jul 2005 00:37:39 +0000 (00:37 +0000)]
note other bindings

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438757 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoBug in UTF-8 rendering. Small change, but well, without the "break;" it was doing
Scott Wheeler [Mon, 25 Jul 2005 21:34:18 +0000 (21:34 +0000)]
Bug in UTF-8 rendering.  Small change, but well, without the "break;" it was doing
the UTF-8 rendering and the UTF16-LE rendering to the same string, which was, well,
ungood.

(Sorry Dan, that's bad news for those files -- but this bug was only introduced 4
days ago, so it just hadn't been caught yet.)

BUG:109604

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438731 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoDon't actually install the tdebug.h header.
Scott Wheeler [Mon, 25 Jul 2005 19:51:52 +0000 (19:51 +0000)]
Don't actually install the tdebug.h header.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438704 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoDon't include tdebug.h in any installed header. I'll remove it from installation
Scott Wheeler [Mon, 25 Jul 2005 19:26:00 +0000 (19:26 +0000)]
Don't include tdebug.h in any installed header.  I'll remove it from installation
shortly.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438692 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoAdd a list of the default file extensions that TagLib knows about, as requested
Scott Wheeler [Sun, 24 Jul 2005 16:25:33 +0000 (16:25 +0000)]
Add a list of the default file extensions that TagLib knows about, as requested
by Stefan.  Also did a few additional updates on the API docs.

CCMAIL:Stefan Gehn <mETz81@web.de>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438212 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoSVN_SILENT another place to update the version
Scott Wheeler [Sun, 24 Jul 2005 08:03:37 +0000 (08:03 +0000)]
SVN_SILENT another place to update the version

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438078 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoMake sure that buffer allocations for file reads aren't completely bogus.
Scott Wheeler [Sat, 23 Jul 2005 23:49:29 +0000 (23:49 +0000)]
Make sure that buffer allocations for file reads aren't completely bogus.
Specifically make sure that we don't actually allocate a buffer for a read that
extends beyond the end of the file.

BUG:101401

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438035 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoFinally took Tommi's suggestion here and introduced a version of the ByteVectorList...
Scott Wheeler [Sat, 23 Jul 2005 23:11:20 +0000 (23:11 +0000)]
Finally took Tommi's suggestion here and introduced a version of the ByteVectorList::split()
that takes a maximum number of values.  This should probably be used more widely in
places where the max is known ahead of time for this to be a more useful fix than nailing
just this special case.  Anyway, fixes the bug.

BUG:103622

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438030 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoThis is a better way of doing this too... Now I have to remember to
Scott Wheeler [Sat, 23 Jul 2005 21:46:39 +0000 (21:46 +0000)]
This is a better way of doing this too...  Now I have to remember to
update the configure.in.in in the root...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438007 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoAdd pkg-config file.
Scott Wheeler [Sat, 23 Jul 2005 21:43:09 +0000 (21:43 +0000)]
Add pkg-config file.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438006 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoBump to 1.4
Scott Wheeler [Sat, 23 Jul 2005 20:58:43 +0000 (20:58 +0000)]
Bump to 1.4

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438002 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoSVN_SILENT missing docs
Scott Wheeler [Fri, 22 Jul 2005 09:03:15 +0000 (09:03 +0000)]
SVN_SILENT missing docs

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437534 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoGo ahead and increment the libtool version in preparation for 1.4.
Scott Wheeler [Fri, 22 Jul 2005 08:33:45 +0000 (08:33 +0000)]
Go ahead and increment the libtool version in preparation for 1.4.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437529 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoAdd UTF16LE support. Patch mostly by Umesh Shankar.
Scott Wheeler [Thu, 21 Jul 2005 18:45:12 +0000 (18:45 +0000)]
Add UTF16LE support.  Patch mostly by Umesh Shankar.

BUG:106815

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437399 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoHmm, that last one wasn't really quite ready. Now we actually check our list
Scott Wheeler [Thu, 21 Jul 2005 18:10:10 +0000 (18:10 +0000)]
Hmm, that last one wasn't really quite ready.  Now we actually check our list
of FileTypeResolvers.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437391 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoAdd a mechanism for extending the file type resolution in JuK using FileRefs.
Scott Wheeler [Thu, 21 Jul 2005 17:45:23 +0000 (17:45 +0000)]
Add a mechanism for extending the file type resolution in JuK using FileRefs.

This is generally much better thought out than the current method of creating
FileRefs using the native mime system and also allows for extension to additional
file formats.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437382 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoContinuing going through my pile-o-patches:
Scott Wheeler [Thu, 21 Jul 2005 17:33:36 +0000 (17:33 +0000)]
Continuing going through my pile-o-patches:

Make it possible to save files using the save() with a tag mask
without stripping the tags that do not fit the mask.  I still need
to do a little testing on this to make sure that the offsets are
still computed correctly.

BUG:96460

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437380 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoIf there is no value set for DESCRIPTION, also check COMMENT.
Scott Wheeler [Thu, 21 Jul 2005 17:30:03 +0000 (17:30 +0000)]
If there is no value set for DESCRIPTION, also check COMMENT.

BUG:98714

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437379 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoAdd accessors for the image description.
Scott Wheeler [Thu, 21 Jul 2005 17:27:37 +0000 (17:27 +0000)]
Add accessors for the image description.

BUG:94258

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437378 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoFix up the RVA2 handling. I'm still not thrilled with the API, but this
Scott Wheeler [Thu, 21 Jul 2005 00:10:57 +0000 (00:10 +0000)]
Fix up the RVA2 handling.  I'm still not thrilled with the API, but this
should be functional enough to hold over to the next binary
incompatible change and has a minimum of differences to the previous
API.

I did a slightly nasty hack so that the API docs will see just methods
with an optional argument, but those are actually two separate methods
(for BC).

Brian, please feel free to take a look at this prior to 1.4 going out.

BUG:107025

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437115 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoFix from Felix Berger to get RVA2 frames a little closer
Scott Wheeler [Wed, 20 Jul 2005 22:23:34 +0000 (22:23 +0000)]
Fix from Felix Berger to get RVA2 frames a little closer
to working.  The more complicated fix for #107025 will
follow shortly.

BUG:95545

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437091 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoAdding and updating svn:ignore
Thiago Macieira [Sat, 16 Jul 2005 14:39:38 +0000 (14:39 +0000)]
Adding and updating svn:ignore

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@435313 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoMisspelling.
Scott Wheeler [Wed, 13 Jul 2005 12:22:34 +0000 (12:22 +0000)]
Misspelling.

BUG:107847

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@434245 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoInstead of returning 0 on finding a deprecated frame type, create an
Scott Wheeler [Tue, 17 May 2005 23:57:23 +0000 (23:57 +0000)]
Instead of returning 0 on finding a deprecated frame type, create an
UnknownFrame and set the flag to discard it on write.

As a special bonus this meant implementing the discard-on-tag-alter
flag.

BUG:100515

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415248 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoPatch from Umesh Shankar to make sure that the frameID is current.
Scott Wheeler [Tue, 17 May 2005 22:38:01 +0000 (22:38 +0000)]
Patch from Umesh Shankar to make sure that the frameID is current.

CCMAIL:Umesh Shankar <ushankar@cs.berkeley.edu>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415233 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoCheck to make sure that there's content before trying to return it.
Scott Wheeler [Tue, 17 May 2005 21:27:51 +0000 (21:27 +0000)]
Check to make sure that there's content before trying to return it.

Almost the same as a patch from Clemens Fuchslocher

CCMAIL:clemens@allesdurcheinander.de

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415211 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoDo a bounds check before trying to find the mid.
Scott Wheeler [Tue, 17 May 2005 20:45:05 +0000 (20:45 +0000)]
Do a bounds check before trying to find the mid.

CCMAIL:Felix Hupfeld <hupfeld@zib.de>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415196 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoDouble-deleting won't make it much better
Allan Sandfeld Jensen [Sun, 3 Apr 2005 16:41:17 +0000 (16:41 +0000)]
Double-deleting won't make it much better

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402896 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years ago...or this
Scott Wheeler [Sun, 3 Apr 2005 16:37:56 +0000 (16:37 +0000)]
...or this

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402894 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoDidn't mean to check this in.
Scott Wheeler [Sun, 3 Apr 2005 16:36:17 +0000 (16:36 +0000)]
Didn't mean to check this in.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402892 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agofix memory leaks
Scott Wheeler [Sun, 3 Apr 2005 16:35:55 +0000 (16:35 +0000)]
fix memory leaks

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402891 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoDecode samplerate correctly.
Allan Sandfeld Jensen [Sat, 2 Apr 2005 20:53:11 +0000 (20:53 +0000)]
Decode samplerate correctly.
BUG: 99829

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402712 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoSorry, that was actually wrong.
Allan Sandfeld Jensen [Fri, 18 Mar 2005 00:10:21 +0000 (00:10 +0000)]
Sorry, that was actually wrong.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@398578 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

19 years agoSupport the new OggFLAC 1.0 standard from FLAC 1.1.2
Allan Sandfeld Jensen [Fri, 18 Mar 2005 00:02:27 +0000 (00:02 +0000)]
Support the new OggFLAC 1.0 standard from FLAC 1.1.2

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@398574 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoNice catch from Gunnar Roth -- the iterator was invalid here.
Scott Wheeler [Wed, 2 Feb 2005 19:04:54 +0000 (19:04 +0000)]
Nice catch from Gunnar Roth -- the iterator was invalid here.

BUG:94662

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@385470 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoDon't dereference the iterator before checking to make sure that we're not
Scott Wheeler [Fri, 14 Jan 2005 13:04:36 +0000 (13:04 +0000)]
Don't dereference the iterator before checking to make sure that we're not
at the end of the list.  Thanks to Gunnar Roth for catching this one.

BUG:96926

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@378404 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agostartsWith() should be used to avoid bugs like: s.mid(0, 4) == "Foo".
Benjamin Meyer [Sun, 19 Dec 2004 05:45:33 +0000 (05:45 +0000)]
startsWith() should be used to avoid bugs like: s.mid(0, 4) == "Foo".

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@371832 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoMake the private class a friend so that it can access the protected Header
Scott Wheeler [Wed, 8 Dec 2004 16:50:10 +0000 (16:50 +0000)]
Make the private class a friend so that it can access the protected Header
class.
BUG:93869

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@369269 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoconvert "" comparison to use built in empty() function
Benjamin Meyer [Mon, 22 Nov 2004 20:08:11 +0000 (20:08 +0000)]
convert "" comparison to use built in empty() function

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@365215 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years ago1.3.1
Scott Wheeler [Sun, 7 Nov 2004 16:10:40 +0000 (16:10 +0000)]
1.3.1

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@361202 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years ago...and now implement the missing contructor.
Scott Wheeler [Sat, 6 Nov 2004 14:43:24 +0000 (14:43 +0000)]
...and now implement the missing contructor.

BUG:92803

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360973 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoClean up includes and actually install apeitem.h. Prior to this the APE
Scott Wheeler [Sat, 6 Nov 2004 14:31:55 +0000 (14:31 +0000)]
Clean up includes and actually install apeitem.h.  Prior to this the APE
API wasn't usable.  Fortunately I'm planning on releasing a 1.3.1 tomorrow.

CCMAIL:Allan Sandfeld Jensen <kde@carewolf.com>
CCBUG:92803

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360971 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoSince these headers weren't even usable when installed, might as well go
Scott Wheeler [Sat, 6 Nov 2004 14:24:40 +0000 (14:24 +0000)]
Since these headers weren't even usable when installed, might as well go
ahead and remove the deprecated crap...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360969 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoDo bounds checking before assuming that just because we've been told that
Scott Wheeler [Sun, 31 Oct 2004 20:30:47 +0000 (20:30 +0000)]
Do bounds checking before assuming that just because we've been told that
there are actually more items that there actually are.

BUG:92028

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359382 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoAdd some text explaining the APE format since it's non-obvious trying to
Scott Wheeler [Sun, 31 Oct 2004 19:27:24 +0000 (19:27 +0000)]
Add some text explaining the APE format since it's non-obvious trying to
find it online and it's poorly written once found.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359360 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoCVS_SILENT back in here again -- checking in formatting before content...
Scott Wheeler [Sat, 30 Oct 2004 16:14:35 +0000 (16:14 +0000)]
CVS_SILENT back in here again -- checking in formatting before content...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359015 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoDon't write a track number if the track is larger than 255.
Scott Wheeler [Fri, 29 Oct 2004 13:48:55 +0000 (13:48 +0000)]
Don't write a track number if the track is larger than 255.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358768 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoMake sure that the type conversion happens so that this number ends up being
Scott Wheeler [Thu, 28 Oct 2004 23:27:29 +0000 (23:27 +0000)]
Make sure that the type conversion happens so that this number ends up being
the appropriate seek location.  I'm pretty sure that this is what was causing
Ogg length information to not work on x86_64.  Can you confirm Hamish?

BUG:86806

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358653 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoCVS_SILENT this comment belongs here now
Scott Wheeler [Thu, 28 Oct 2004 22:20:00 +0000 (22:20 +0000)]
CVS_SILENT this comment belongs here now

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358639 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoMake sure that there's (a) data in a bytevector that we're trying to convert
Scott Wheeler [Thu, 28 Oct 2004 22:11:41 +0000 (22:11 +0000)]
Make sure that there's (a) data in a bytevector that we're trying to convert
to an integer before trying to convert it and (b) make sure that there's data
in an APE::Item before trying to parse it.

BUG:92028

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358637 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoMore cleanups and some API docs additions.
Scott Wheeler [Thu, 28 Oct 2004 22:05:43 +0000 (22:05 +0000)]
More cleanups and some API docs additions.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358636 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoSemantic and style cleanups. render() should be const. Use for() loops to
Scott Wheeler [Thu, 28 Oct 2004 21:22:33 +0000 (21:22 +0000)]
Semantic and style cleanups.  render() should be const.  Use for() loops to
loop through lists rather than while, fix bracket style.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358627 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoThis line is redundant.
Scott Wheeler [Wed, 20 Oct 2004 23:34:55 +0000 (23:34 +0000)]
This line is redundant.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@356359 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoAdd some more docs on how to use the ID3v1::StringHandler in the ID3v1::Tag
Scott Wheeler [Wed, 20 Oct 2004 23:15:08 +0000 (23:15 +0000)]
Add some more docs on how to use the ID3v1::StringHandler in the ID3v1::Tag
documentation.

BUG:90634

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@356354 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoMove the sanity check before the unknown frame stuff. As the code currently
Scott Wheeler [Mon, 18 Oct 2004 15:31:12 +0000 (15:31 +0000)]
Move the sanity check before the unknown frame stuff.  As the code currently
is if a bogus frame is hit it may try to parse it as an UnknownFrame rather
than just discarding it.

CCMAIL:Espen Tveit <espen.tveit@gmail.com>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@355686 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoForgot this. Time to redo the tarballs.
Scott Wheeler [Fri, 10 Sep 2004 02:23:31 +0000 (02:23 +0000)]
Forgot this.  Time to redo the tarballs.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345358 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoCVS_SILENT missing doc for the namespace
Scott Wheeler [Fri, 10 Sep 2004 02:13:40 +0000 (02:13 +0000)]
CVS_SILENT missing doc for the namespace

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345357 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years ago1.3 -- bump the libtool version
Scott Wheeler [Fri, 10 Sep 2004 01:54:20 +0000 (01:54 +0000)]
1.3 -- bump the libtool version

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345355 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agomisplace conditional
Scott Wheeler [Fri, 10 Sep 2004 01:42:56 +0000 (01:42 +0000)]
misplace conditional

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345352 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoPatch from Allan to add support for compressed frames.
Scott Wheeler [Fri, 10 Sep 2004 01:29:49 +0000 (01:29 +0000)]
Patch from Allan to add support for compressed frames.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345351 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoRemove some annoying debuging code.
Allan Sandfeld Jensen [Thu, 9 Sep 2004 23:49:49 +0000 (23:49 +0000)]
Remove some annoying debuging code.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345343 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoScott's silly nitpicks...
Scott Wheeler [Thu, 9 Sep 2004 00:28:57 +0000 (00:28 +0000)]
Scott's silly nitpicks...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345141 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoSome API overview updates.
Scott Wheeler [Wed, 8 Sep 2004 22:38:00 +0000 (22:38 +0000)]
Some API overview updates.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345123 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoMention the return type.
Scott Wheeler [Sun, 5 Sep 2004 17:55:47 +0000 (17:55 +0000)]
Mention the return type.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@344197 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoDon't try to do stuff to files that aren't valid.
Scott Wheeler [Sun, 5 Sep 2004 17:54:00 +0000 (17:54 +0000)]
Don't try to do stuff to files that aren't valid.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@344196 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoCleaning up. Better documentation and remove dead code.
Allan Sandfeld Jensen [Thu, 2 Sep 2004 19:32:19 +0000 (19:32 +0000)]
Cleaning up. Better documentation and remove dead code.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@343588 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoFix typo.
Allan Sandfeld Jensen [Thu, 2 Sep 2004 18:50:26 +0000 (18:50 +0000)]
Fix typo.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@343576 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoSet APELocation to the beginning of the APE-tag
Allan Sandfeld Jensen [Wed, 25 Aug 2004 15:37:53 +0000 (15:37 +0000)]
Set APELocation to the beginning of the APE-tag

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340956 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoSome extra documentation.
Allan Sandfeld Jensen [Mon, 23 Aug 2004 21:57:07 +0000 (21:57 +0000)]
Some extra documentation.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340248 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoFind the starting position.
Allan Sandfeld Jensen [Mon, 23 Aug 2004 20:39:32 +0000 (20:39 +0000)]
Find the starting position.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340210 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoUpdate interface. Just needs more documentation now.
Allan Sandfeld Jensen [Mon, 23 Aug 2004 20:38:47 +0000 (20:38 +0000)]
Update interface. Just needs more documentation now.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340209 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoConvert from ByteVectorList to StringList
Allan Sandfeld Jensen [Mon, 23 Aug 2004 15:26:23 +0000 (15:26 +0000)]
Convert from ByteVectorList to StringList

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340107 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoAPE-tags for mp3s.
Allan Sandfeld Jensen [Sun, 15 Aug 2004 21:14:12 +0000 (21:14 +0000)]
APE-tags for mp3s.
Currently they are for special purposes only, and thus not used as a part
of the union tag.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@338184 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoadd api docs
Scott Wheeler [Sun, 8 Aug 2004 06:04:42 +0000 (06:04 +0000)]
add api docs

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336790 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoMake sure that we're not setting the string size to -1.
Scott Wheeler [Sat, 7 Aug 2004 20:23:10 +0000 (20:23 +0000)]
Make sure that we're not setting the string size to -1.

CCMAIL:ismail donmez <kde@myrealbox.com>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336760 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoCVS_SILENT forgot a short description
Scott Wheeler [Sat, 7 Aug 2004 01:39:26 +0000 (01:39 +0000)]
CVS_SILENT forgot a short description

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336647 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoAdding support for the Unique File Identifier ID3v2 frame type (UFID).
Scott Wheeler [Sat, 7 Aug 2004 00:59:16 +0000 (00:59 +0000)]
Adding support for the Unique File Identifier ID3v2 frame type (UFID).

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336640 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoAdd support for custom ID3v2 text frames (TXXX).
Scott Wheeler [Fri, 6 Aug 2004 23:41:56 +0000 (23:41 +0000)]
Add support for custom ID3v2 text frames (TXXX).

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336629 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoAdd overloads here so that the return type is in fact StringList.
Scott Wheeler [Fri, 6 Aug 2004 21:51:32 +0000 (21:51 +0000)]
Add overloads here so that the return type is in fact StringList.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336601 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoReturn a reference to the current list from append().
Scott Wheeler [Fri, 6 Aug 2004 21:07:46 +0000 (21:07 +0000)]
Return a reference to the current list from append().

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336591 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoHere's an oops -- this *really* should have been virtual. I'm not sure how
Scott Wheeler [Fri, 6 Aug 2004 01:54:28 +0000 (01:54 +0000)]
Here's an oops -- this *really* should have been virtual.  I'm not sure how
I missed that.  I'll come up with something -- probably a functor or similar
to work around this at some point.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336480 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoIgnore compressed and encrypted ID3v2 frames rather than just blindly giving
Scott Wheeler [Mon, 2 Aug 2004 19:35:47 +0000 (19:35 +0000)]
Ignore compressed and encrypted ID3v2 frames rather than just blindly giving
back the compressed/encrypted data as a string.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@335256 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoAlways explicitly check for divide by zero conditions.
Scott Wheeler [Mon, 2 Aug 2004 12:51:14 +0000 (12:51 +0000)]
Always explicitly check for divide by zero conditions.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@335132 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoCreate a correct footer
Allan Sandfeld Jensen [Sun, 1 Aug 2004 23:30:06 +0000 (23:30 +0000)]
Create a correct footer

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@334982 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoA few changes to make the interface more flexible. It can now remove
Allan Sandfeld Jensen [Sun, 1 Aug 2004 23:29:42 +0000 (23:29 +0000)]
A few changes to make the interface more flexible. It can now remove
tags including ID3v2.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@334981 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoStandard stuff -- make it fit with the coding style of the rest of TagLib
Scott Wheeler [Tue, 27 Jul 2004 02:35:47 +0000 (02:35 +0000)]
Standard stuff -- make it fit with the coding style of the rest of TagLib
and make it build.  There are still some missing API docs and I'm not sure
how I feel about non-opaque types (Item in this case) since they're not used
elsewhere in the API, but this will do for now.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@333117 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoThis is wrong -- this would indicate a BIC library release. Please see
Scott Wheeler [Tue, 27 Jul 2004 02:00:01 +0000 (02:00 +0000)]
This is wrong -- this would indicate a BIC library release.  Please see
"info:/libtool/Updating version info" when changing the libtool version
string.

CCMAIL:Allan Sandfeld Jensen <kde@carewolf.com>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@333116 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoMake mpc use the new APETag-structure
Allan Sandfeld Jensen [Mon, 26 Jul 2004 19:04:40 +0000 (19:04 +0000)]
Make mpc use the new APETag-structure

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@333012 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoRefactoring.
Allan Sandfeld Jensen [Mon, 26 Jul 2004 19:03:28 +0000 (19:03 +0000)]
Refactoring.
APE-tags are not native to musepack, so I am moving it out.
Seperated footer-decoding the same way header-decoding is seperated in
ID3v2.
Fixed a bug with the version in the footer. Should be 2000 (read 2.000) not 2.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@333011 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agomissing const
Scott Wheeler [Mon, 26 Jul 2004 13:44:59 +0000 (13:44 +0000)]
missing const

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332913 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoLarge update:
Allan Sandfeld Jensen [Mon, 26 Jul 2004 12:58:59 +0000 (12:58 +0000)]
Large update:
* Give access to APEv2 features like lists and read-only fields (not enforced by TagLib).
* Support one common mistake: ID3v1 tags placed after an APE-tag. In this case both tags are now read and maintained. APE-tags after an ID3v1 tag is not supported.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332903 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoMark HEAD as TagLib 1.3
Scott Wheeler [Mon, 26 Jul 2004 03:39:34 +0000 (03:39 +0000)]
Mark HEAD as TagLib 1.3

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332793 283d02a7-25f6-0310-bc7c-ecb5cbfe19da