Bruce Momjian [Thu, 15 Jun 2006 02:23:13 +0000 (02:23 +0000)]
Done, removed:
<
< * Consider padding the spinlock structure to have spinlock registers
< on different CPU cache line
<
< http://archives.postgresql.org/pgsql-hackers/2005-10/msg00498.php
Tom Lane [Thu, 15 Jun 2006 02:08:09 +0000 (02:08 +0000)]
Remove the limit on the number of entries allowed in catcaches, and
remove the infrastructure needed to enforce the limit, ie, the global
LRU list of cache entries. On small-to-middling databases this wins
because maintaining the LRU list is a waste of time. On large databases
this wins because it's better to keep more cache entries (we assume
such users can afford to use some more per-backend memory than was
contemplated in the Berkeley-era catcache design). This provides a
noticeable improvement in the speed of psql \d on a 10000-table
database, though it doesn't make it instantaneous.
While at it, use per-catcache settings for the number of hash buckets
per catcache, rather than the former one-size-fits-all value. It's a
bit silly to be using the same number of hash buckets for, eg, pg_am
and pg_attribute. The specific values I used might need some tuning,
but they seem to be in the right ballpark based on CATCACHE_STATS
results from the standard regression tests.
Bruce Momjian [Wed, 14 Jun 2006 21:47:06 +0000 (21:47 +0000)]
Add:
>
> * Consider padding the spinlock structure to have spinlock registers
> on different CPU cache line
>
> http://archives.postgresql.org/pgsql-hackers/2005-10/msg00498.php
Bruce Momjian [Wed, 14 Jun 2006 21:40:00 +0000 (21:40 +0000)]
Add item, not fixed:
>
> * Fix ILIKE and regular expressions to handle case insensitivity
> properly in multibyte encodings
>
> http://archives.postgresql.org/pgsql-bugs/2005-10/msg00001.php
Bruce Momjian [Wed, 14 Jun 2006 21:38:21 +0000 (21:38 +0000)]
Remove, already in back branches:
<
< o Add new version of PQescapeString() that doesn't double backslashes
< that are part of a client-only multibyte sequence
<
< Single-quote is not a valid byte in any supported client-only
< encoding. This requires using mblen() to determine if the
< backslash is inside or outside a multi-byte sequence.
<
< o Add new version of PQescapeString() that doesn't double
< backslashes when standard_conforming_strings is true and
< non-E strings are used
Bruce Momjian [Wed, 14 Jun 2006 21:10:50 +0000 (21:10 +0000)]
Add information schema item:
> * Improve the information schema to be more standards-compliant:
>
> http://archives.postgresql.org/pgsql-bugs/2005-10/msg00028.php
> * Add URL to more complete multi-byte regression tests
>
> http://archives.postgresql.org/pgsql-hackers/2005-07/msg00272.php
< * Add URL to more complete multi-byte regression tests
<
< http://archives.postgresql.org/pgsql-hackers/2005-07/msg00272.php
Bruce Momjian [Wed, 14 Jun 2006 19:01:42 +0000 (19:01 +0000)]
Add URL, remove TODO.detail:
< o %Allow pg_dump to use multiple -t and -n switches [pg_dump]
> o %Allow pg_dump to use multiple -t and -n switches
>
> http://archives.postgresql.org/pgsql-patches/2006-01/msg00190.php
>
Bruce Momjian [Wed, 14 Jun 2006 18:47:53 +0000 (18:47 +0000)]
Add locale/encoding references:
< Right now only one encoding is allowed per database.
> Right now only one encoding is allowed per database. [locale]
> * Add CREATE COLLATE? [locale]
Bruce Momjian [Wed, 14 Jun 2006 18:36:57 +0000 (18:36 +0000)]
Add:
> o Fix problem when cascading referential triggers make changes on
> cascaded tables, seeing the tables in an intermediate state
>
> http://archives.postgresql.org/pgsql-hackers/2005-09/msg00174.php
> http://archives.postgresql.org/pgsql-hackers/2005-09/msg00174.php
Tom Lane [Wed, 14 Jun 2006 17:49:25 +0000 (17:49 +0000)]
Further thoughts about lo_export/lo_import error handling: if one of
the lower-level large object functions fails, it will have already set
a suitable error message --- probably something from the backend ---
and it is not useful to overwrite that with a generic 'error while
reading large object' message. So remove redundant messages.
Tom Lane [Wed, 14 Jun 2006 16:49:03 +0000 (16:49 +0000)]
Clean up psql's control-C handling to avoid longjmp'ing out of random
places --- that risks corrupting data structures, losing sync with the
backend, etc. We now longjmp only from calls to readline, fgets, and
fread, which we assume are coded to protect themselves against interrupts
at undesirable times. This requires adding explicit tests for
cancel_pressed in long-running loops, but on the whole it's far cleaner.
Martijn van Oosterhout and Tom Lane.
Tom Lane [Wed, 14 Jun 2006 01:24:14 +0000 (01:24 +0000)]
Do a CHECK_FOR_INTERRUPTS immediately before terminating a fastpath
function call. Previously, there may have been no CHECK_FOR_INTERRUPTS
at all in the fastpath code path, making it impossible to cancel an
operation such as \lo_import externally. This addition doesn't ensure
you can cancel, since your SIGINT may arrive while the backend is idle
waiting for the client, but it gives the largest window we can easily
provide. Noted while experimenting with new control-C code for psql.
Bruce Momjian [Mon, 12 Jun 2006 16:09:11 +0000 (16:09 +0000)]
Win32 can't catch the exception thrown by INT_MIN / -1 or INT_MIN * -1,
so on that platform we test for those before the computation and throw
an "out of range" error.
Tom Lane [Sun, 11 Jun 2006 15:49:28 +0000 (15:49 +0000)]
Fix Assert failure when a fastpath function call is attempted inside an
already-aborted transaction block. GetSnapshotData throws an Assert if
not in a valid transaction; hence we mustn't attempt to set a snapshot
for the function until after checking for aborted transaction. This is
harmless AFAICT if Asserts aren't enabled (GetSnapshotData will compute
a bogus snapshot, but it doesn't matter since HandleFunctionRequest will
throw an error shortly anywy). Hence, not a major bug.
Along the way, add some ability to log fastpath calls when statement
logging is turned on. This could probably stand to be improved further,
but not logging anything is clearly undesirable.
Backpatched as far as 8.0; bug doesn't exist before that.
Bruce Momjian [Sat, 10 Jun 2006 23:33:27 +0000 (23:33 +0000)]
Remove pg_dump wording:
< pg_get_tabledef(), pg_get_domaindef(), pg_get_functiondef(), and
< make use of them in pg_dump
> pg_get_tabledef(), pg_get_domaindef(), pg_get_functiondef()
Bruce Momjian [Sat, 10 Jun 2006 23:17:21 +0000 (23:17 +0000)]
Add:
< pg_get_tabledef(), pg_get_domaindef(), pg_get_functiondef()
> pg_get_tabledef(), pg_get_domaindef(), pg_get_functiondef(), and
> make use of them in pg_dump
Tom Lane [Fri, 9 Jun 2006 19:46:09 +0000 (19:46 +0000)]
Repair remarkably-inefficient query for dumping large object comments: it
was invoking obj_description() for each large object chunk, instead of once
per large object. This code is new as of 8.1, which may explain why the
problem hadn't been noticed already.
Tom Lane [Fri, 9 Jun 2006 19:30:56 +0000 (19:30 +0000)]
Revert sampling patch for EXPLAIN ANALYZE; it turns out to be too unreliable
because node timing is much less predictable than the patch expects. I kept
the API change for InstrStopNode, however.
Bruce Momjian [Fri, 9 Jun 2006 18:41:57 +0000 (18:41 +0000)]
Cleanups:
< * Allow a database in tablespace t1 with tables created in
> o Allow a database in tablespace t1 with tables created in 125c125
< * Allow reporting of which objects are in which tablespaces
> o Allow reporting of which objects are in which tablespaces 593c593
< * Allow GRANT/REVOKE permissions to be inherited by objects based on
> o Allow GRANT/REVOKE permissions to be inherited by objects based on 596c596
< * Allow SERIAL sequences to inherit permissions from the base table?
> o Allow SERIAL sequences to inherit permissions from the base table?
Teodor Sigaev [Fri, 9 Jun 2006 13:25:59 +0000 (13:25 +0000)]
Now ispell dictionary can eat dictionaries in MySpell format,
used by OpenOffice. Dictionaries are placed at
http://lingucomponent.openoffice.org/spell_dic.html
Dictionary automatically recognizes format of files.
Warning. MySpell's format has limitation with compound
word support: it's impossible to mark affix as
compound-only affix. So for norwegian, german etc
languages it's recommended to use original ispell format.
For that reason I don't want to remove my2ispell
scripts, it's has workaround at least for norwegian language.
Tom Lane [Thu, 8 Jun 2006 23:55:48 +0000 (23:55 +0000)]
Fix bootstrap.c so that database startup process and bgwriter properly release
LWLocks during a panic exit. This avoids the possible self-deadlock pointed
out by Qingqing Zhou. Also, I noted that an error during LoadFreeSpaceMap()
or BuildFlatFiles() would result in exit(0) which would leave the postmaster
thinking all is well. Added a critical section to ensure such errors don't
allow startup to proceed.
Backpatched to 8.1. The 8.0 code is a bit different and I'm not sure if the
problem exists there; given we've not seen this reported from the field, I'm
going to be conservative about backpatching any further.
Bruce Momjian [Thu, 8 Jun 2006 16:07:23 +0000 (16:07 +0000)]
Use simple URL's rather than text and a URL:
< recovery. See http://archives.postgresql.org/pgsql-patches/2005-04/msg00121.php.
> recovery.
> http://archives.postgresql.org/pgsql-patches/2005-04/msg00121.php
< Right now only one encoding is allowed per database. For a partial
< patch, see http://archives.postgresql.org/pgsql-hackers/2005-03/msg00932.php.
> Right now only one encoding is allowed per database.
> http://archives.postgresql.org/pgsql-hackers/2005-03/msg00932.php 459c460
< notify the protocol when a RESET CONNECTION command is used. See
> notify the protocol when a RESET CONNECTION command is used. 461d461
< for a partial implementation. 515c515
< See http://archives.postgresql.org/pgsql-patches/2006-02/msg00168.php.
> http://archives.postgresql.org/pgsql-patches/2006-02/msg00168.php 535c535
< See http://archives.postgresql.org/pgsql-hackers/2006-05/msg00988.php.
> http://archives.postgresql.org/pgsql-hackers/2006-05/msg00988.php 821c821
< See http://archives.postgresql.org/pgsql-patches/2005-07/msg00107.php.
> http://archives.postgresql.org/pgsql-patches/2005-07/msg00107.php 877c877
< Details at http://archives.postgresql.org/pgsql-hackers/2004-04/msg00818.php.
> http://archives.postgresql.org/pgsql-hackers/2004-04/msg00818.php
< See partially completed patch and additional work required at
< http://archives.postgresql.org/pgsql-patches/2006-06/msg00025.php.
> http://archives.postgresql.org/pgsql-patches/2006-06/msg00025.php 1297c1296
< See http://archives.postgresql.org/pgsql-patches/2006-05/msg00040.php.
> http://archives.postgresql.org/pgsql-patches/2006-05/msg00040.php 1311c1310,1311
< o Improve signal handling,
> o Improve signal handling
> 1312a1313
>
Bruce Momjian [Thu, 8 Jun 2006 15:41:22 +0000 (15:41 +0000)]
Add URL.
< * Support triggers on columns (Greg Sabino Mullane)
> * Support triggers on columns
>
> See http://archives.postgresql.org/pgsql-patches/2005-07/msg00107.php.
>
Tom Lane [Thu, 8 Jun 2006 14:58:33 +0000 (14:58 +0000)]
Remove obsolete comment about VACUUM FULL: it takes buffer content locks
now, and must do so to ensure bgwriter doesn't write a page that is in
process of being compacted.
Bruce Momjian [Thu, 8 Jun 2006 14:32:11 +0000 (14:32 +0000)]
/contrib/adminpack: More clearly identify renaming of existing backend
functions. I also found that pg_file_length was incorrectly documented
in the README as pg_file_size.
Bruce Momjian [Thu, 8 Jun 2006 02:42:44 +0000 (02:42 +0000)]
Add URL:
< Right now only one encoding is allowed per database.
> Right now only one encoding is allowed per database. For a partial
> patch, see http://archives.postgresql.org/pgsql-hackers/2005-03/msg00932.php.
Bruce Momjian [Thu, 8 Jun 2006 01:02:53 +0000 (01:02 +0000)]
Add entry:
> * Consider allowing control of upper/lower case folding of unquoted
> identifiers
>
> Details at http://archives.postgresql.org/pgsql-hackers/2004-04/msg00818.php.
Bruce Momjian [Wed, 7 Jun 2006 22:24:46 +0000 (22:24 +0000)]
Prepare code to be built by MSVC:
o remove many WIN32_CLIENT_ONLY defines
o add WIN32_ONLY_COMPILER define
o add 3rd argument to open() for portability
o add include/port/win32_msvc directory for
system includes
Tom Lane [Wed, 7 Jun 2006 18:49:03 +0000 (18:49 +0000)]
Per previous analysis, the most correct notion of SampleOverhead is that
it is just the total time to do INSTR_TIME_SET_CURRENT(), and not any of
the other code involved in InstrStartNode/InstrStopNode. Even though I
fear we may end up reverting this patch altogether, we may as well have
the most correct version in our CVS archive.
Tom Lane [Wed, 7 Jun 2006 17:08:07 +0000 (17:08 +0000)]
Remove "fuzzy comparison" logic in qsort comparison function for
choose_bitmap_and(). It was way too fuzzy --- per comment, it was meant to be
1% relative difference, but was actually coded as 0.01 absolute difference,
thus causing selectivities of say 0.001 and 0.000000000001 to be treated as
equal. I believe this thinko explains Maxim Boguk's recent complaint. While
we could change it to a relative test coded like compare_fuzzy_path_costs(),
there's a bigger problem here, which is that any fuzziness at all renders the
comparison function non-transitive, which could confuse qsort() to the point
of delivering completely wrong results. So forget the whole thing and just
do an exact comparison.
Tom Lane [Tue, 6 Jun 2006 17:59:58 +0000 (17:59 +0000)]
Make the planner estimate costs for nestloop inner indexscans on the basis
that the Mackert-Lohmann formula applies across all the repetitions of the
nestloop, not just each scan independently. We use the M-L formula to
estimate the number of pages fetched from the index as well as from the table;
that isn't what it was designed for, but it seems reasonably applicable
anyway. This makes large numbers of repetitions look much cheaper than
before, which accords with many reports we've received of overestimation
of the cost of a nestloop. Also, change the index access cost model to
charge random_page_cost per index leaf page touched, while explicitly
not counting anything for access to metapage or upper tree pages. This
may all need tweaking after we get some field experience, but in simple
tests it seems to be giving saner results than before. The main thing
is to get the infrastructure in place to let cost_index() and amcostestimate
functions take repeated scans into account at all. Per my recent proposal.
Note: this patch changes pg_proc.h, but I did not force initdb because
the changes are basically cosmetic --- the system does not look into
pg_proc to decide how to call an index amcostestimate function, and
there's no way to call such a function from SQL at all.
Bruce Momjian [Tue, 6 Jun 2006 16:27:23 +0000 (16:27 +0000)]
Add URL to RESET CONNECTION:
< notify the protocol when a RESET CONNECTION command is used.
> notify the protocol when a RESET CONNECTION command is used. See
> http://archives.postgresql.org/pgsql-patches/2006-04/msg00192.php
> for a partial implementation.
Teodor Sigaev [Tue, 6 Jun 2006 16:25:55 +0000 (16:25 +0000)]
Allow do not lexize words in substitution.
Docs will be submitted some later, now it's at
http://www.sai.msu.su/~megera/oddmuse/index.cgi/Thesaurus_dictionary
Tom Lane [Mon, 5 Jun 2006 20:56:33 +0000 (20:56 +0000)]
While making the seq_page_cost changes, I was struck by the fact that
cost_nonsequential_access() is really totally inappropriate for its only
remaining use, namely estimating I/O costs in cost_sort(). The routine
was designed on the assumption that disk caching might eliminate the need
for some re-reads on a random basis, but there's nothing very random in
that sense about sort's access pattern --- it'll always be picking up the
oldest outputs. If we had a good fix on the effective cache size we
might consider charging zero for I/O unless the sort temp file size
exceeds it, but that's probably putting much too much faith in the
parameter. Instead just drop the logic in favor of a fixed compromise
between seq_page_cost and random_page_cost per page of sort I/O.
Tom Lane [Mon, 5 Jun 2006 03:03:42 +0000 (03:03 +0000)]
Increase the default value of cpu_index_tuple_cost from 0.001 to 0.005.
This shouldn't affect simple indexscans much, while for bitmap scans that
are touching a lot of index rows, this seems to bring the estimates more
in line with reality. Per recent discussion.
Tom Lane [Mon, 5 Jun 2006 02:49:58 +0000 (02:49 +0000)]
Add a GUC parameter seq_page_cost, and use that everywhere we formerly
assumed that a sequential page fetch has cost 1.0. This patch doesn't
in itself change the system's behavior at all, but it opens the door to
people adopting other units of measurement for EXPLAIN costs. Also, if
we ever decide it's worth inventing per-tablespace access cost settings,
this change provides a workable intellectual framework for that.
Bruce Momjian [Sun, 4 Jun 2006 01:33:39 +0000 (01:33 +0000)]
Update:
< o Allow COPY to output from views
> o Allow COPY to output from SELECT 570c570
< Another idea would be to allow actual SELECT statements in a COPY.
> COPY should also be able to output views.
Tom Lane [Sat, 3 Jun 2006 17:36:10 +0000 (17:36 +0000)]
Don't choke during startup if the environment offers an invalid value
for LC_MESSAGES; instead, just press forward, leaving the effective setting
at 'C'. There is not any very good reason to complain when we are going
to replace the value soon with whatever postgresql.conf says. This change
should solve the occasionally-reported problem of initdb failing with
'failed to initialize lc_messages'; the current theory is that that is
a reflection of either wrong LANG/LC_MESSAGES or completely broken locale
support.
Bruce Momjian [Sat, 3 Jun 2006 04:00:01 +0000 (04:00 +0000)]
Record location of partial patch :
> * Allow WAL information to recover corrupted pg_controldata
>
> See partially completed patch and additional work required at
> http://archives.postgresql.org/pgsql-patches/2006-06/msg00025.php.
>