]>
granicus.if.org Git - neomutt/log
Kevin McCarthy [Thu, 24 Jan 2019 23:19:36 +0000 (15:19 -0800)]
Simplify nested smime handling in the attachment menu
Since changeset
2fd6f99b allows nested encryption handling, there is
no need to deal with the nesting directly. Instead, just recursive as
with other nested handling.
Co-authored-by: Richard Russon <rich@flatcap.org>
Kevin McCarthy [Thu, 24 Jan 2019 22:15:33 +0000 (14:15 -0800)]
Improve attachment menu for s/mime parts
Don't prompt for passphrase or getkeys, or set the ENCRYPT flag, for
OPAQUE types.
Don't recurse on "text" output from decrypt_mime(). There is no
reason to recurse on a text type. Additionally, the
mutt_read_mime_header() will return an empty text type even if the
decode doesn't generate mime output. In those cases, we want to show
the original attachment.
Co-authored-by: Richard Russon <rich@flatcap.org>
Kevin McCarthy [Tue, 22 Jan 2019 03:43:08 +0000 (19:43 -0800)]
Fix tunnels to also retry and write full buffer
Change the tunnel_socket_read() and tunnel_socket_write() as the raw
sockets were adjusted in the previous commit. Retry on EINTR, and
complete a full write so all the implementations have the same behavior.
Co-authored-by: Richard Russon <rich@flatcap.org>
Kevin McCarthy [Mon, 21 Jan 2019 19:56:04 +0000 (11:56 -0800)]
Fix gnutls tls_socket_write() to properly retry
Retry on GNUTLS_E_AGAIN and GNUTLS_E_INTERRUPTED. This prevents an
aborted send due to a SIGWINCH, for instance.
Change tls_socket_read() to follow the same flow. Don't bother
checking gnutls_error_is_fatal() because return codes besides AGAIN
and INTERRUPTED end up closing the connection regardless. (We don't
handle handshakes and negotations during send/receive).
Co-authored-by: Richard Russon <rich@flatcap.org>
Kevin McCarthy [Sat, 19 Jan 2019 23:23:32 +0000 (15:23 -0800)]
Change $pgp_use_gpg_agent to default set
GnuPG 2.1.0, released in 2014-11-06, automatically spawns an agent.
After 4+ years, it has reached wide enough usage to merit changing the
default.
Co-authored-by: Richard Russon <rich@flatcap.org>
Kevin McCarthy [Thu, 10 Jan 2019 17:56:41 +0000 (09:56 -0800)]
Wrap ssl init calls for LibreSSL too
It looks like LibreSSL does not perform automatic initialization of
the library and error strings.
Since LibreSSL defines OPENSSL_VERSION_NUMBER as a "version 2",
add a check if LIBRESSL_VERSION_NUMBER is defined and call the
initialization functions for that case.
Co-authored-by: Richard Russon <rich@flatcap.org>
Muh Muhten [Tue, 15 Jan 2019 06:17:02 +0000 (01:17 -0500)]
Add attributes support on color declarations
color now accepts zero or more attributes words before the foreground.
Also more or less resolves the issue that setting the color of an object
which defaults to underline/reverse is irreversible.
Co-authored-by: Richard Russon <rich@flatcap.org>
Stefan Strogin [Tue, 8 Jan 2019 19:18:38 +0000 (21:18 +0200)]
Fix compilation with LibreSSL <2.7.0
Co-authored-by: Richard Russon <rich@flatcap.org>
Richard Russon [Mon, 18 Feb 2019 17:13:47 +0000 (17:13 +0000)]
clang-format
Frederick Eaton [Fri, 8 Feb 2019 06:34:24 +0000 (22:34 -0800)]
Reword "postpone" message to avoid confusion
Replace "Postpone this message?" with "Save (postpone) draft message?"
Issue #1312
Update neomuttrc manual page (via init.h documentation) so that the
actual text of the $postpone quadoption prompt appears in the blurb, so
users can grep for it.
Victor Fernandes [Wed, 23 Jan 2019 16:58:45 +0000 (17:58 +0100)]
added: :bind, :macro interactive commands
Display all the active bindings/macros.
Issue #162
Austin Ray [Thu, 24 Jan 2019 00:45:01 +0000 (19:45 -0500)]
notmuch: delegate msg_open_new to maildir backend
Notmuch delegates several functions to the maildir backend since they
are connected. This commit delegates the notmuch msg_open_new() to the
maildir backend's implementation.
The primary benefit is being able to delete attachments from emails.
Previously, if an attachment was marked for deletion then it was
impossible to exit a virtual mailbox since a write operation could not
complete. This bug has been in Neomutt for a while.
Fixes #673
Richard Russon [Sat, 16 Feb 2019 19:56:00 +0000 (19:56 +0000)]
Replace integer parameters with booleans
Several methods used integer parameters to represent boolean values;
replacement with a boolean improves readability.
Affects function/macro(s):
- mutt_emails_set_flag()
- mutt_thread_set_flag()
- mutt_set_flag()
Richard Russon [Tue, 19 Feb 2019 00:48:12 +0000 (00:48 +0000)]
merge: refactor/tidy mutt_enter_string_full()
* boolify variables
* use NUL rather than zero
* reduce scope of variables
* tidy mutt_enter_string_full()
Richard Russon [Sun, 17 Feb 2019 17:09:19 +0000 (17:09 +0000)]
tidy mutt_enter_string_full()
Richard Russon [Sun, 17 Feb 2019 16:53:46 +0000 (16:53 +0000)]
reduce scope of variables
Richard Russon [Sun, 17 Feb 2019 16:17:52 +0000 (16:17 +0000)]
use NUL rather than zero
Richard Russon [Sun, 17 Feb 2019 16:16:00 +0000 (16:16 +0000)]
boolify variables
Richard Russon [Tue, 19 Feb 2019 00:46:58 +0000 (00:46 +0000)]
merge: refactor/tidy mutt_compose_menu()
* reduce scope of variables
* boolify variables
* fix scoping
* merge non-overlapping buffer use
* use NUL rather than zero
* var scope
* tidy mutt_compose_menu()
Richard Russon [Sun, 17 Feb 2019 14:25:54 +0000 (14:25 +0000)]
tidy mutt_compose_menu()
Richard Russon [Sun, 17 Feb 2019 14:25:30 +0000 (14:25 +0000)]
var scope
Richard Russon [Sun, 17 Feb 2019 13:30:06 +0000 (13:30 +0000)]
use NUL rather than zero
Richard Russon [Sun, 17 Feb 2019 13:27:10 +0000 (13:27 +0000)]
merge non-overlapping buffer use
`buf` and `fname` were never used at the same time, so just use one
temporary buffer.
Richard Russon [Sun, 17 Feb 2019 13:13:12 +0000 (13:13 +0000)]
fix scoping
- move some }s
- return early, where possible
Richard Russon [Sun, 17 Feb 2019 13:07:20 +0000 (13:07 +0000)]
boolify variables
Richard Russon [Sun, 17 Feb 2019 12:58:17 +0000 (12:58 +0000)]
reduce scope of variables
Richard Russon [Tue, 19 Feb 2019 00:45:50 +0000 (00:45 +0000)]
merge: refactor/tidy mutt_select_file()
* use NUL rather than zero
* boolify variables
* separate op
* reduce scope of variables
* tidy mutt_select_file()
Richard Russon [Sun, 17 Feb 2019 16:00:51 +0000 (16:00 +0000)]
tidy mutt_select_file()
Richard Russon [Sun, 17 Feb 2019 15:34:30 +0000 (15:34 +0000)]
reduce scope of variables
Richard Russon [Sun, 17 Feb 2019 15:47:59 +0000 (15:47 +0000)]
separate op
Richard Russon [Sun, 17 Feb 2019 15:34:22 +0000 (15:34 +0000)]
boolify variables
Richard Russon [Sun, 17 Feb 2019 15:33:42 +0000 (15:33 +0000)]
use NUL rather than zero
Richard Russon [Tue, 19 Feb 2019 00:44:27 +0000 (00:44 +0000)]
merge: refactor/tidy mutt_pager()
* reduce scope of loop variables
* reduce scope of variables
* tidy mutt_pager()
Richard Russon [Sat, 16 Feb 2019 16:35:29 +0000 (16:35 +0000)]
tidy mutt_pager()
Richard Russon [Sat, 16 Feb 2019 16:34:51 +0000 (16:34 +0000)]
reduce scope of variables
Richard Russon [Sat, 16 Feb 2019 16:11:56 +0000 (16:11 +0000)]
reduce scope of loop variables
Richard Russon [Tue, 19 Feb 2019 00:43:19 +0000 (00:43 +0000)]
merge: refactor/tidy mutt_index_menu()
* refactor index's check macros
* reduce scope of loop variables
* reduce scope of variables
* tidy mutt_index_menu()
Richard Russon [Sat, 16 Feb 2019 16:50:03 +0000 (16:50 +0000)]
tidy mutt_index_menu()
Richard Russon [Thu, 14 Feb 2019 02:20:46 +0000 (02:20 +0000)]
reduce scope of variables
Richard Russon [Thu, 14 Feb 2019 02:12:33 +0000 (02:12 +0000)]
reduce scope of loop variables
Richard Russon [Tue, 12 Feb 2019 22:31:40 +0000 (22:31 +0000)]
refactor index's check macros
Richard Russon [Tue, 12 Feb 2019 21:36:41 +0000 (21:36 +0000)]
update list of translatable files
[ci skip]
Richard Russon [Sat, 16 Feb 2019 15:50:10 +0000 (15:50 +0000)]
merge: trivial code fixes
* boolify Score->exact
* boolify is_reply()
* boolify do_locales
* boolify exact
* boolify imap_set_flags()
* doxy: fix typo
* comp_mbox_close: swap if clauses
* fix sprintf specifiers
* fix lgtm alerts
Richard Russon [Sat, 16 Feb 2019 00:35:04 +0000 (00:35 +0000)]
fix lgtm alerts
Each of the removed tests was redundant.
Richard Russon [Fri, 15 Feb 2019 23:23:35 +0000 (23:23 +0000)]
fix sprintf specifiers
Richard Russon [Fri, 15 Feb 2019 23:14:48 +0000 (23:14 +0000)]
comp_mbox_close: swap if clauses
Richard Russon [Fri, 15 Feb 2019 23:07:24 +0000 (23:07 +0000)]
doxy: fix typo
Richard Russon [Fri, 15 Feb 2019 23:09:08 +0000 (23:09 +0000)]
boolify imap_set_flags()
Richard Russon [Sat, 16 Feb 2019 12:45:22 +0000 (12:45 +0000)]
boolify exact
Richard Russon [Sat, 16 Feb 2019 12:44:13 +0000 (12:44 +0000)]
boolify do_locales
Richard Russon [Fri, 15 Feb 2019 23:07:02 +0000 (23:07 +0000)]
boolify is_reply()
Richard Russon [Fri, 15 Feb 2019 23:04:32 +0000 (23:04 +0000)]
boolify Score->exact
Richard Russon [Sat, 16 Feb 2019 13:38:11 +0000 (13:38 +0000)]
lgtm: add config
Richard Russon [Wed, 13 Feb 2019 13:51:18 +0000 (13:51 +0000)]
fix mailbox size
When re-opening a mailbox, the size wasn't being reset.
Richard Russon [Fri, 8 Feb 2019 20:25:16 +0000 (20:25 +0000)]
merge: trivial code fixes
* fix spelling
* compare integers against 0
* standardise naming in B64Context
* standardise naming in ComposeRedrawData
* standardise naming in FgetConv
* standardise naming in Group
* standardise naming in ImapHeader
* standardise naming in MailboxNode
* standardise naming in Pattern
* standardise naming in SslSockData
* standardise naming in Pager
* simplify bitfields in Mailbox
* simplify bitfields in ImapAccountData
* simplify bitfields in smtp
* drop bitfields
* doxy: mark all out-params
* tidy mutt_folder_hook
* index.c move data
* tidy reopen_mailbox
* doxy: add comment blocks
* iwyu
* boolify variables
* doxy: fix typo
* fix param names
* rename pop_adata_get
* eliminate asymmetric quotes
* reduce variable scope
Richard Russon [Fri, 8 Feb 2019 19:55:42 +0000 (19:55 +0000)]
reduce variable scope
Richard Russon [Fri, 8 Feb 2019 19:46:05 +0000 (19:46 +0000)]
eliminate asymmetric quotes
Richard Russon [Fri, 8 Feb 2019 19:25:29 +0000 (19:25 +0000)]
rename pop_adata_get
Richard Russon [Fri, 8 Feb 2019 19:17:27 +0000 (19:17 +0000)]
fix param names
Richard Russon [Fri, 8 Feb 2019 19:15:05 +0000 (19:15 +0000)]
doxy: fix typo
Richard Russon [Fri, 8 Feb 2019 19:15:00 +0000 (19:15 +0000)]
boolify variables
Richard Russon [Wed, 9 Jan 2019 23:18:47 +0000 (23:18 +0000)]
iwyu
Richard Russon [Tue, 5 Feb 2019 20:28:40 +0000 (20:28 +0000)]
doxy: add comment blocks
Richard Russon [Fri, 18 Jan 2019 02:39:58 +0000 (02:39 +0000)]
tidy reopen_mailbox
Richard Russon [Fri, 18 Jan 2019 02:32:41 +0000 (02:32 +0000)]
index.c move data
Richard Russon [Fri, 18 Jan 2019 02:30:43 +0000 (02:30 +0000)]
tidy mutt_folder_hook
Richard Russon [Mon, 4 Feb 2019 02:31:47 +0000 (02:31 +0000)]
doxy: mark all out-params
Richard Russon [Mon, 21 Jan 2019 23:34:47 +0000 (23:34 +0000)]
drop bitfields
Richard Russon [Mon, 21 Jan 2019 23:31:59 +0000 (23:31 +0000)]
simplify bitfields in smtp
Richard Russon [Mon, 21 Jan 2019 23:21:10 +0000 (23:21 +0000)]
simplify bitfields in ImapAccountData
Richard Russon [Mon, 21 Jan 2019 22:52:26 +0000 (22:52 +0000)]
simplify bitfields in Mailbox
Richard Russon [Fri, 18 Jan 2019 02:14:15 +0000 (02:14 +0000)]
standardise naming in Pager
Richard Russon [Fri, 18 Jan 2019 02:12:13 +0000 (02:12 +0000)]
standardise naming in SslSockData
Richard Russon [Fri, 18 Jan 2019 02:09:51 +0000 (02:09 +0000)]
standardise naming in Pattern
Richard Russon [Fri, 18 Jan 2019 02:07:17 +0000 (02:07 +0000)]
standardise naming in MailboxNode
Richard Russon [Fri, 18 Jan 2019 02:01:21 +0000 (02:01 +0000)]
standardise naming in ImapHeader
Richard Russon [Fri, 18 Jan 2019 01:52:15 +0000 (01:52 +0000)]
standardise naming in Group
Richard Russon [Fri, 18 Jan 2019 01:47:49 +0000 (01:47 +0000)]
standardise naming in FgetConv
Richard Russon [Fri, 18 Jan 2019 01:44:47 +0000 (01:44 +0000)]
standardise naming in ComposeRedrawData
Richard Russon [Fri, 18 Jan 2019 01:43:16 +0000 (01:43 +0000)]
standardise naming in B64Context
Richard Russon [Thu, 17 Jan 2019 19:58:57 +0000 (19:58 +0000)]
compare integers against 0
Richard Russon [Tue, 5 Feb 2019 17:55:56 +0000 (17:55 +0000)]
fix spelling
Richard Russon [Fri, 8 Feb 2019 16:35:52 +0000 (16:35 +0000)]
merge: more Context elimination
* add EmailList for tagged Emails
* refactor edit_or_view_one_message
* mutt_ev_message: factor out Context
* bounce_message: factor out Context
* mutt_check_traditional_pgp: factor out Context
* crypt_extract_keys_from_messages: factor out Context
* mutt_link_threads: factor out Context
* mutt_label_message: factor out Context
* pipe_msg: add Mailbox param
* pipe_message: factor out Context
* mutt_save_message: factor out Context
* mutt_change_flag: factor out Context
* ci_send_message: factor Context out of mutt_make_string()
* ci_send_message: factor out Context
* ci_send_message: factor Context out of dependents
* mutt_mailbox_check: factor out Context
* mx_mbox_sync
* add mx_path_resolve()
* mx_mbox_open: drop path param
* factor out PostContext
* tidy code
* tidy Email variables
* move parse_mailboxes()
Richard Russon [Sun, 20 Jan 2019 16:46:19 +0000 (16:46 +0000)]
move parse_mailboxes()
This function has dependencies on Context and inotify().
Richard Russon [Sat, 19 Jan 2019 16:53:56 +0000 (16:53 +0000)]
tidy Email variables
Richard Russon [Sat, 19 Jan 2019 15:52:39 +0000 (15:52 +0000)]
tidy code
Non-functional changes
Richard Russon [Sat, 19 Jan 2019 16:19:08 +0000 (16:19 +0000)]
factor out PostContext
Richard Russon [Sat, 5 Jan 2019 12:50:27 +0000 (12:50 +0000)]
mx_mbox_open: drop path param
Richard Russon [Fri, 28 Dec 2018 14:51:34 +0000 (14:51 +0000)]
add mx_path_resolve()
Richard Russon [Sun, 13 Jan 2019 15:39:26 +0000 (15:39 +0000)]
mx_mbox_sync
Richard Russon [Sun, 13 Jan 2019 15:05:15 +0000 (15:05 +0000)]
mutt_mailbox_check: factor out Context
Richard Russon [Sat, 12 Jan 2019 00:34:23 +0000 (00:34 +0000)]
ci_send_message: factor Context out of dependents
Richard Russon [Fri, 11 Jan 2019 21:51:53 +0000 (21:51 +0000)]
ci_send_message: factor out Context
Richard Russon [Fri, 11 Jan 2019 14:30:09 +0000 (14:30 +0000)]
ci_send_message: factor Context out of mutt_make_string()
Richard Russon [Fri, 11 Jan 2019 11:58:51 +0000 (11:58 +0000)]
mutt_change_flag: factor out Context
Richard Russon [Fri, 11 Jan 2019 10:51:12 +0000 (10:51 +0000)]
mutt_save_message: factor out Context
Richard Russon [Fri, 11 Jan 2019 01:56:56 +0000 (01:56 +0000)]
pipe_message: factor out Context
Richard Russon [Thu, 10 Jan 2019 20:48:30 +0000 (20:48 +0000)]
pipe_msg: add Mailbox param
Richard Russon [Thu, 10 Jan 2019 15:49:22 +0000 (15:49 +0000)]
mutt_label_message: factor out Context
Richard Russon [Thu, 10 Jan 2019 15:27:30 +0000 (15:27 +0000)]
mutt_link_threads: factor out Context