]> granicus.if.org Git - transmission/log
transmission
9 years agoRemove unused session tag
Mike Gelfand [Sun, 18 Oct 2015 18:39:14 +0000 (18:39 +0000)]
Remove unused session tag

9 years agoDisplay notifications via tray icon if dbus is not available
Mike Gelfand [Sun, 18 Oct 2015 11:48:10 +0000 (11:48 +0000)]
Display notifications via tray icon if dbus is not available

9 years ago#5889: Sync with libutp before its API changed
Mike Gelfand [Fri, 16 Oct 2015 20:27:52 +0000 (20:27 +0000)]
#5889: Sync with libutp before its API changed

9 years ago#5992: Remove now obsolete check for 13th Baktun (already happened)
Mike Gelfand [Fri, 16 Oct 2015 19:49:07 +0000 (19:49 +0000)]
#5992: Remove now obsolete check for 13th Baktun (already happened)

9 years ago#6006: Don't use newlocale/uselocale with uClibc below 0.9.34
Mike Gelfand [Thu, 15 Oct 2015 20:19:27 +0000 (20:19 +0000)]
#6006: Don't use newlocale/uselocale with uClibc below 0.9.34

Incomplete locale internals initialization in uClibc leads to crash upon
`newlocale` call.

See also: http://git.uclibc.org/uClibc/commit/?id=3902d0c472

9 years ago#6005: Style fix for previous commit (no functional changes)
Mike Gelfand [Wed, 14 Oct 2015 08:22:17 +0000 (08:22 +0000)]
#6005: Style fix for previous commit (no functional changes)

9 years ago#6005: Bump minimum OpenSSL version to 0.9.7, fix build for versions less than 0...
Mike Gelfand [Tue, 13 Oct 2015 21:24:31 +0000 (21:24 +0000)]
#6005: Bump minimum OpenSSL version to 0.9.7, fix build for versions less than 0.9.8b

9 years agoInitialise networking in daemon before making libevent calls
Mike Gelfand [Sun, 11 Oct 2015 16:35:51 +0000 (16:35 +0000)]
Initialise networking in daemon before making libevent calls

9 years agoImprove error handling when formatting error messages on Windows
Mike Gelfand [Sun, 11 Oct 2015 16:15:19 +0000 (16:15 +0000)]
Improve error handling when formatting error messages on Windows

9 years agoFix parameters order in `tr_web_done_func` declaration
Mike Gelfand [Thu, 8 Oct 2015 19:47:59 +0000 (19:47 +0000)]
Fix parameters order in `tr_web_done_func` declaration

9 years ago#5867: Fix miniupnpc strings script re. r14269 (patch by demosdemon)
Mike Gelfand [Thu, 8 Oct 2015 19:12:03 +0000 (19:12 +0000)]
#5867: Fix miniupnpc strings script re. r14269 (patch by demosdemon)

9 years ago#4518: Mark appropriate fields in prefs as html5 number fields (patch by e-moe)
Mike Gelfand [Thu, 8 Oct 2015 18:54:43 +0000 (18:54 +0000)]
#4518: Mark appropriate fields in prefs as html5 number fields (patch by e-moe)

9 years ago#5732: Change length argument type to uint32_t for LTEP messages
Mike Gelfand [Mon, 5 Oct 2015 23:10:52 +0000 (23:10 +0000)]
#5732: Change length argument type to uint32_t for LTEP messages

9 years ago#5732: Fix possible overflow in messageLengthIsCorrect (partial patch by cfpp2p)
Mike Gelfand [Mon, 5 Oct 2015 01:21:47 +0000 (01:21 +0000)]
#5732: Fix possible overflow in messageLengthIsCorrect (partial patch by cfpp2p)

9 years agoSupport compiling Mac client with Xcode 7
Mike Gelfand [Mon, 5 Oct 2015 00:25:13 +0000 (00:25 +0000)]
Support compiling Mac client with Xcode 7

Latest Mac OS X SDK (10.11) doesn't include OpenSSL headers, but still
provides the libraries. Bundle our own copy of OpenSSL headers for now
(taken from running 10.10 system).

9 years ago#5993: Improve magnets handling in main window
Mike Gelfand [Sun, 4 Oct 2015 06:16:59 +0000 (06:16 +0000)]
#5993: Improve magnets handling in main window

Disable "Open Folder" and "Verify Local Data" actions for magnets in
Torrent menu. If more than one torrent is selected, "Verify Local Data"
is enabled but only non-magnets are verified if activated.
Add a few sanity checks when opening folder, just in case.

9 years ago#6003: Update to miniupnpc api 14 (slightly modified patch by infirit)
Mike Gelfand [Sun, 4 Oct 2015 04:53:18 +0000 (04:53 +0000)]
#6003: Update to miniupnpc api 14 (slightly modified patch by infirit)

9 years ago#6001: Calculate header item size properly
Mike Gelfand [Sun, 27 Sep 2015 20:23:03 +0000 (20:23 +0000)]
#6001: Calculate header item size properly

9 years agoSync main context menu with "Torrent" menu; hide menu icons on Mac
Mike Gelfand [Tue, 1 Sep 2015 23:19:01 +0000 (23:19 +0000)]
Sync main context menu with "Torrent" menu; hide menu icons on Mac

9 years agoFix session dialog not showing up after first close
Mike Gelfand [Tue, 1 Sep 2015 20:39:34 +0000 (20:39 +0000)]
Fix session dialog not showing up after first close

9 years agoRemove context help button from dialogs on Windows
Mike Gelfand [Tue, 1 Sep 2015 20:19:26 +0000 (20:19 +0000)]
Remove context help button from dialogs on Windows

We don't currently (if ever) provide context help, so the button is
useless. Moreover, on Windows 10 it's even larger than before and
sometimes title text doesn't fit because of it.

9 years ago#5982: Simplify filter bar connections by using needed slot directly
Mike Gelfand [Mon, 17 Aug 2015 08:14:45 +0000 (08:14 +0000)]
#5982: Simplify filter bar connections by using needed slot directly

9 years agoSimplify and speed up actions connected to file tree popup menu
Mike Gelfand [Sun, 16 Aug 2015 22:07:09 +0000 (22:07 +0000)]
Simplify and speed up actions connected to file tree popup menu

9 years agoSync translations with Transifex
Mike Gelfand [Mon, 10 Aug 2015 20:43:26 +0000 (20:43 +0000)]
Sync translations with Transifex

Add German and Indonesian (translated 95%+).

9 years ago#5608: Enter file renaming mode with keyboard only, not on mouse double-click (Qt...
Mike Gelfand [Mon, 10 Aug 2015 19:40:58 +0000 (19:40 +0000)]
#5608: Enter file renaming mode with keyboard only, not on mouse double-click (Qt client)

Since double-click is usually used to open things, don't use it to enter
edit mode, use platform-specific keyboard shortcut instead (Return, F2,
etc).
Add context menu duplicating available actions, resembling that of Mac
client. This includes new "only check selected" action.
Speed up DND/priority change for large numbers of files at once. Make
DND/priority toggling more natural: if both parent and its child are
selected, only act on parent (with all its children following).

9 years agoRefactor action groups initialization/handling and trackers merging a bit
Mike Gelfand [Thu, 6 Aug 2015 20:28:44 +0000 (20:28 +0000)]
Refactor action groups initialization/handling and trackers merging a bit

9 years agoUse CMake-provided C/C++ standard selection capabilities; fix build (qtr.pro)
Mike Gelfand [Sat, 1 Aug 2015 16:05:02 +0000 (16:05 +0000)]
Use CMake-provided C/C++ standard selection capabilities; fix build (qtr.pro)

9 years agoRemove some unused includes/macros; fix build (re. QPointer)
Mike Gelfand [Thu, 30 Jul 2015 06:55:28 +0000 (06:55 +0000)]
Remove some unused includes/macros; fix build (re. QPointer)

9 years agoCreate dialogs on demand, don't keep them ready all the time
Mike Gelfand [Thu, 30 Jul 2015 06:18:02 +0000 (06:18 +0000)]
Create dialogs on demand, don't keep them ready all the time

9 years agoImprove RPC performance for local sessions
Mike Gelfand [Mon, 13 Jul 2015 00:32:48 +0000 (00:32 +0000)]
Improve RPC performance for local sessions

Don't unnecessarily de-/serialize JSON data if local session is used.

9 years agoImprove file tree population/update performance
Mike Gelfand [Sun, 12 Jul 2015 20:48:54 +0000 (20:48 +0000)]
Improve file tree population/update performance

Use simple tokenization instead of splitting the file path into
QStringList for each item. Don't expand each added item separetely
during population/update. Don't expand all the items but just up to the
point where parent has more than one expandable child.

Also, fix items order by sorting items after population/update. Fix
sorting by size on systems where uint64_t != quint64.

9 years ago#5912: Prevent completed pieces modification by webseeds (patch by cfpp2p)
Mike Gelfand [Sun, 5 Jul 2015 07:54:46 +0000 (07:54 +0000)]
#5912: Prevent completed pieces modification by webseeds (patch by cfpp2p)

This avoids blocks corruption in case webseed provides bad data.

As explained by cfpp2p, "The requirements to reproduce are at least one
webseed that sends corrupt block(s), and at least one other peer (webseed
or regular peer) that sends correct data for the same block. Then a peer
with correct block sends the block and transmission accepts and verifies
that block as good. But then the webseed thread comes around and the same
block is downloaded from the webseed that sends a bad block which is then
written even though the piece was previously deemed complete."

9 years agoFix `tr_net_strerror` on Windows (oops)
Mike Gelfand [Wed, 1 Jul 2015 00:58:00 +0000 (00:58 +0000)]
Fix `tr_net_strerror` on Windows (oops)

9 years agoUse `sockerrno` and `tr_net_strerror` for most of network-related errors
Mike Gelfand [Wed, 1 Jul 2015 00:54:41 +0000 (00:54 +0000)]
Use `sockerrno` and `tr_net_strerror` for most of network-related errors

This ensures proper network errors formatting on Windows.

Also, disable IP_TOS socket option modification attempts on Windows
since it's not supported there and is considered deprecated: "Do not
use. Type of Service (TOS) settings should only be set using the
Quality of Service API" (c) MSDN. Using QoS API is a subject for
separate commit(s).

9 years agoSome look-and-feel improvements for Mac and GTK+ styles (Qt client)
Mike Gelfand [Sun, 28 Jun 2015 14:18:06 +0000 (14:18 +0000)]
Some look-and-feel improvements for Mac and GTK+ styles (Qt client)

9 years agoAvoid assert on passing negative values to `isprint` (due to type promotion)
Mike Gelfand [Fri, 26 Jun 2015 21:22:27 +0000 (21:22 +0000)]
Avoid assert on passing negative values to `isprint` (due to type promotion)

9 years ago#5964: Another follow-up commit for #5456 (encrypted communication with libevent...
Mike Gelfand [Wed, 24 Jun 2015 21:24:41 +0000 (21:24 +0000)]
#5964: Another follow-up commit for #5456 (encrypted communication with libevent 2.1.x)

Decrypt only what is asked for, not more. This fixes previous commit
which changed semantics by processing the buffer to the very end,
starting with correct offset though.

Refactor encryption/decryption to a single function which callback.

9 years ago#5964: Follow-up fix for #5456 (encrypted communication with libevent 2.1.x)
Mike Gelfand [Wed, 24 Jun 2015 20:38:41 +0000 (20:38 +0000)]
#5964: Follow-up fix for #5456 (encrypted communication with libevent 2.1.x)

I've misread libevent documentation and the check introduced was not
entirely correct. Changed `evbuffer_peek` call now to only request the
data which would fit into provided iovec.

9 years agoAvoid possible `_XOPEN_SOURCE` redefinition warning
Mike Gelfand [Tue, 23 Jun 2015 21:16:33 +0000 (21:16 +0000)]
Avoid possible `_XOPEN_SOURCE` redefinition warning

9 years ago#5456: Fix encrypted communication with libevent 2.1.x
Mike Gelfand [Wed, 17 Jun 2015 20:32:33 +0000 (20:32 +0000)]
#5456: Fix encrypted communication with libevent 2.1.x

Recent versions of libevent changed the semantics of `evbuffer_ptr_set`
function in a way that it succeeds if pointer is set right after the end
of the buffer. This caused `tr_cryptoEncrypt` and `tr_cryptoDecrypt` to
be called twice for last buffer chunk since no checks for `evbuffer_peek`
return value were made while it was returning 0 on last loop cycle,
leaving iovec unchanged.

9 years agoTorrent properties dialog improvements
Mike Gelfand [Mon, 15 Jun 2015 21:07:46 +0000 (21:07 +0000)]
Torrent properties dialog improvements

Simplify DND checkboxes drawing, this also fixes incorrect drawing on
Mac when file tree widget is inactive.
Do better job calculating column widths for file tree to avoid ellipsis.
Fix file tree sorting order for size and priority columns.
Change key to toggle priorities to Shift+Space instead of Enter/Return
to avoid conflicts with name editing and default button handling.
Fix selected tracker item background drawing in certain cases.

9 years agoInstead of standard C headers include their C++ counterparts
Mike Gelfand [Fri, 12 Jun 2015 22:41:36 +0000 (22:41 +0000)]
Instead of standard C headers include their C++ counterparts

9 years agoUnify/prettify Qt client headers style
Mike Gelfand [Fri, 12 Jun 2015 22:12:12 +0000 (22:12 +0000)]
Unify/prettify Qt client headers style

9 years agoSync Qt client translations, add Polish language
Mike Gelfand [Wed, 10 Jun 2015 22:51:53 +0000 (22:51 +0000)]
Sync Qt client translations, add Polish language

9 years agoUse PascalCase for Qt client filenames
Mike Gelfand [Wed, 10 Jun 2015 21:27:11 +0000 (21:27 +0000)]
Use PascalCase for Qt client filenames

Split FileTree.{h,cc} and FilterBar.{h,cc} files so that each class
is in its own file.

This breaks translations (some classes got renamed => context changed),
to be fixed by next commit (along with Tx sync).

9 years agoBump DHT version used in CMake scripts (includes latest Win32 fixes)
Mike Gelfand [Mon, 8 Jun 2015 19:54:51 +0000 (19:54 +0000)]
Bump DHT version used in CMake scripts (includes latest Win32 fixes)

9 years agoDon't print trailing space char on each line when saving JSON
Mike Gelfand [Mon, 1 Jun 2015 20:50:25 +0000 (20:50 +0000)]
Don't print trailing space char on each line when saving JSON

9 years ago#5851: Don't use _configthreadlocale if not provided by CRT (even if declaration...
Mike Gelfand [Mon, 1 Jun 2015 18:52:14 +0000 (18:52 +0000)]
#5851: Don't use _configthreadlocale if not provided by CRT (even if declaration is present)

9 years ago#5851: Use per-thread locale setup if possible
Mike Gelfand [Mon, 1 Jun 2015 05:25:14 +0000 (05:25 +0000)]
#5851: Use per-thread locale setup if possible

This prevents crashes on concurrent tr_variantFromBuf, tr_variantToBuf
and tr_variantGetReal use.

9 years agoAdd more booleans to the picture
Mike Gelfand [Sun, 31 May 2015 22:13:31 +0000 (22:13 +0000)]
Add more booleans to the picture

9 years agoRemove useless ws2tcpip.h include in net.h
Mike Gelfand [Sat, 30 May 2015 15:44:17 +0000 (15:44 +0000)]
Remove useless ws2tcpip.h include in net.h

It's already included above, and QT_DLL condition is meaningless
since net.h is only being used inside libtransmission which doesn't
use Qt.

9 years agoUse CreateProcess instead of _spawnvpe to execute scripts on Windows
Mike Gelfand [Sat, 30 May 2015 11:15:57 +0000 (11:15 +0000)]
Use CreateProcess instead of _spawnvpe to execute scripts on Windows

9 years ago#4882: \u-encode all non-printable (as opposed to non-ascii) characters
Mike Gelfand [Sat, 16 May 2015 17:33:01 +0000 (17:33 +0000)]
#4882: \u-encode all non-printable (as opposed to non-ascii) characters

9 years agoFix some issues revealed by coverity
Mike Gelfand [Sat, 9 May 2015 14:10:55 +0000 (14:10 +0000)]
Fix some issues revealed by coverity

9 years agoFix some issues revealed by coverity
Mike Gelfand [Sat, 9 May 2015 14:09:05 +0000 (14:09 +0000)]
Fix some issues revealed by coverity

9 years agoFix some issues revealed by coverity
Mike Gelfand [Sat, 9 May 2015 11:56:35 +0000 (11:56 +0000)]
Fix some issues revealed by coverity

9 years agoFix some issues revealed by coverity
Mike Gelfand [Sat, 9 May 2015 08:37:55 +0000 (08:37 +0000)]
Fix some issues revealed by coverity

9 years ago#5946: Save "prefetch-enabled" setting as boolean (spotted by cfpp2p)
Mike Gelfand [Thu, 7 May 2015 06:45:35 +0000 (06:45 +0000)]
#5946: Save "prefetch-enabled" setting as boolean (spotted by cfpp2p)

9 years ago#5944: Unify indentation style and strip trailing whitespaces across JS code, no...
Mike Gelfand [Tue, 5 May 2015 19:12:48 +0000 (19:12 +0000)]
#5944: Unify indentation style and strip trailing whitespaces across JS code, no functional changes (patch by xzcvczx + a lot more)

9 years agoCut internal macro names to have equal number of underscores on each side (take two)
Mike Gelfand [Mon, 4 May 2015 20:06:05 +0000 (20:06 +0000)]
Cut internal macro names to have equal number of underscores on each side (take two)

9 years agoCut internal macro names to have equal number of underscores on each side
Mike Gelfand [Mon, 4 May 2015 19:58:34 +0000 (19:58 +0000)]
Cut internal macro names to have equal number of underscores on each side

9 years agoRemove `-Wdeclaration-after-statement` flag (we use C99)
Mike Gelfand [Sun, 3 May 2015 11:44:18 +0000 (11:44 +0000)]
Remove `-Wdeclaration-after-statement` flag (we use C99)

9 years ago#5930: Fix style of Gtk+3.16 overshoot and undershoot (patch by nagisa)
Mike Gelfand [Sun, 3 May 2015 10:30:35 +0000 (10:30 +0000)]
#5930: Fix style of Gtk+3.16 overshoot and undershoot (patch by nagisa)

9 years ago#4866: Replace existing menus with jQueryUI menu
Mike Gelfand [Thu, 30 Apr 2015 05:20:48 +0000 (05:20 +0000)]
#4866: Replace existing menus with jQueryUI menu

9 years ago#5937: Don't send TR_RPC_TORRENT_ADDED notification if torrent wasn't actually added...
Mike Gelfand [Wed, 29 Apr 2015 19:42:05 +0000 (19:42 +0000)]
#5937: Don't send TR_RPC_TORRENT_ADDED notification if torrent wasn't actually added (patch by xzcvczx)

9 years agoUse jQuery UI's `ui-helper-hidden` CSS class instead of our own
Mike Gelfand [Sun, 26 Apr 2015 03:35:44 +0000 (03:35 +0000)]
Use jQuery UI's `ui-helper-hidden` CSS class instead of our own

9 years ago#5934: Generate REVISION file and use it in case of missing reliable source
Mike Gelfand [Fri, 24 Apr 2015 19:14:56 +0000 (19:14 +0000)]
#5934: Generate REVISION file and use it in case of missing reliable source

9 years agoBump natpmp revision to include latest Win32 fixes
Mike Gelfand [Thu, 23 Apr 2015 22:03:29 +0000 (22:03 +0000)]
Bump natpmp revision to include latest Win32 fixes

9 years agoDefine WIN32_LEAN_AND_MEAN and NOMINMAX for our own code only
Mike Gelfand [Thu, 23 Apr 2015 21:32:00 +0000 (21:32 +0000)]
Define WIN32_LEAN_AND_MEAN and NOMINMAX for our own code only

9 years agoEmit warning from uTP config in a more friendly way
Mike Gelfand [Thu, 23 Apr 2015 20:20:21 +0000 (20:20 +0000)]
Emit warning from uTP config in a more friendly way

9 years ago#5894: Get rid of eval() in JS code (patch by Ancient; 2nd part)
Mike Gelfand [Thu, 23 Apr 2015 19:30:40 +0000 (19:30 +0000)]
#5894: Get rid of eval() in JS code (patch by Ancient; 2nd part)

9 years ago#5894: Get rid of inline styles in HTML (patch by Ancient; 1st part, slightly modifie...
Mike Gelfand [Thu, 23 Apr 2015 19:02:38 +0000 (19:02 +0000)]
#5894: Get rid of inline styles in HTML (patch by Ancient; 1st part, slightly modified per IRC discussion)

9 years agoEven better (and unified) torrent origin logic for GTK+, Qt and web clients
Mike Gelfand [Wed, 22 Apr 2015 21:04:49 +0000 (21:04 +0000)]
Even better (and unified) torrent origin logic for GTK+, Qt and web clients

9 years agoFix JS error on undefined creator during inspector update
Mike Gelfand [Wed, 22 Apr 2015 20:36:28 +0000 (20:36 +0000)]
Fix JS error on undefined creator during inspector update

Since torrents' info is fetched asynchronously, it may not yet be
available when inspector updates. Account for possibly undefined
creator.

Refine logic used to construct torrent origin phrase to prevent
results such as "Created by  on <date>" or "Created by <creator>
on ".

9 years ago#5894: Fix autotools build ("trailing backslash on last line")
Mike Gelfand [Tue, 21 Apr 2015 21:23:15 +0000 (21:23 +0000)]
#5894: Fix autotools build ("trailing backslash on last line")

9 years ago#5894: Update jQuery to 1.11.2 (with Migrate plugin 1.2.1), jQuery UI to 1.11.4
Mike Gelfand [Tue, 21 Apr 2015 21:17:45 +0000 (21:17 +0000)]
#5894: Update jQuery to 1.11.2 (with Migrate plugin 1.2.1), jQuery UI to 1.11.4

9 years agoBump miniupnpc revision to fix `MINIUPNP_STATICLIB` macro definition
Mike Gelfand [Tue, 21 Apr 2015 13:56:17 +0000 (13:56 +0000)]
Bump miniupnpc revision to fix `MINIUPNP_STATICLIB` macro definition

9 years agoAvoid GCC `'static' is not at beginning of declaration` warning
Mike Gelfand [Tue, 21 Apr 2015 11:40:15 +0000 (11:40 +0000)]
Avoid GCC `'static' is not at beginning of declaration` warning

9 years agoUse UTF-8 for console I/O on Windows
Mike Gelfand [Tue, 21 Apr 2015 10:07:57 +0000 (10:07 +0000)]
Use UTF-8 for console I/O on Windows

9 years agoIfdef the code which does manual relayout on compact view toggle to Qt < 5.4 (QTBUG...
Mike Gelfand [Mon, 20 Apr 2015 09:28:26 +0000 (09:28 +0000)]
Ifdef the code which does manual relayout on compact view toggle to Qt < 5.4 (QTBUG-33537)

9 years agoSend dummy events each second to prevent excessive memory use (inspired by xnyhps)
Mike Gelfand [Sat, 18 Apr 2015 21:45:37 +0000 (21:45 +0000)]
Send dummy events each second to prevent excessive memory use (inspired by xnyhps)

I'm not that good in Mac programming it seems as I can't figure out why
doesn't the memory being allocated by frequent NSNewBitmapBackingStore
(system internal) calls being freed even if I wrap the code into
@autoreleasepool explicitly. Disabling animations does slow it down but
not stop. This commit is certainly a dirty fix but it seems to work in
my case and I hope it helps a few other people while we wait for a
proper solution.

9 years agoFix Qt 4 build: `QGridLayout::getItemPosition ()` is not constant :(
Mike Gelfand [Sat, 18 Apr 2015 14:48:23 +0000 (14:48 +0000)]
Fix Qt 4 build: `QGridLayout::getItemPosition ()` is not constant :(

9 years agoUse C++11 range-based `for` loops (Qt client)
Mike Gelfand [Sat, 18 Apr 2015 14:41:06 +0000 (14:41 +0000)]
Use C++11 range-based `for` loops (Qt client)

9 years ago#5927: Add Chinese (zh_CN) translation to Qt client (provided by liaodahao)
Mike Gelfand [Wed, 15 Apr 2015 20:26:38 +0000 (20:26 +0000)]
#5927: Add Chinese (zh_CN) translation to Qt client (provided by liaodahao)

9 years agoUse native separators for path button and free space label tooltips. Improve path...
Mike Gelfand [Wed, 15 Apr 2015 00:08:24 +0000 (00:08 +0000)]
Use native separators for path button and free space label tooltips. Improve path button dialog initial directory/file selection.

9 years agoAdd version info to executables (on Windows). Group projects into folders (CMake).
Mike Gelfand [Tue, 14 Apr 2015 22:46:40 +0000 (22:46 +0000)]
Add version info to executables (on Windows). Group projects into folders (CMake).

9 years agoAllow files (and their parent directories) to be renamed even when in use (on Windows).
Mike Gelfand [Mon, 13 Apr 2015 18:31:32 +0000 (18:31 +0000)]
Allow files (and their parent directories) to be renamed even when in use (on Windows).

9 years ago#5925 no CFBundleVersion in Jenkins builds
Eric Petit [Sun, 12 Apr 2015 05:08:46 +0000 (05:08 +0000)]
#5925 no CFBundleVersion in Jenkins builds
Work around version mismatch between java's and command-line's svns

9 years agoForward-declare `tr_error` structure in headers
Mike Gelfand [Sat, 11 Apr 2015 14:54:01 +0000 (14:54 +0000)]
Forward-declare `tr_error` structure in headers

9 years agoAdd ERROR_DIRECTORY_NOT_SUPPORTED define missing in MinGW
Mike Gelfand [Sat, 11 Apr 2015 10:58:08 +0000 (10:58 +0000)]
Add ERROR_DIRECTORY_NOT_SUPPORTED define missing in MinGW

9 years ago#5908: Check for `tr_loadFile` return value instead of `errno` in `tr_variantFromFile`
Mike Gelfand [Sat, 11 Apr 2015 10:51:59 +0000 (10:51 +0000)]
#5908: Check for `tr_loadFile` return value instead of `errno` in `tr_variantFromFile`

Seems like there could be a defect in uClibc making errno not
thread-local. Don't rely on errno value but check function return value
instead which is a better failure indicator.

Return errors from `tr_loadFile` and `tr_variantFromFile` via tr_error.
Fix `tr_sessionLoadSettings` to not fail on Windows if settings.json
does not exist.

9 years agoTune directory paths on Windows
Mike Gelfand [Fri, 10 Apr 2015 22:15:41 +0000 (22:15 +0000)]
Tune directory paths on Windows

Use %USERPROFILE% instead of %USERPROFILE%\Documents as home directory.
Don't roam configuration directory (I don't think we want that).
Use known Downloads folder (instead of %HOME%\Downloads) if set.
When searching for web interface files, let local user application data
directory override roaming one, and roaming one override common one.
Use Vista+ API (SHGetKnownFolderPath) to get known folder paths.

9 years ago#5878: Fix typo in transmission-remote -P argument desription (reported by jolan)
Mike Gelfand [Sun, 5 Apr 2015 16:29:09 +0000 (16:29 +0000)]
#5878: Fix typo in transmission-remote -P argument desription (reported by jolan)

9 years ago#5920: Fix memory leak and access to freed memory in tr_getDefaultConfigDir (patch...
Mike Gelfand [Sun, 5 Apr 2015 06:39:06 +0000 (06:39 +0000)]
#5920: Fix memory leak and access to freed memory in tr_getDefaultConfigDir (patch by jyelloz)

9 years ago#5910: Fix autotools build (#2) and workaround MSVC bug
Mike Gelfand [Sat, 4 Apr 2015 18:28:13 +0000 (18:28 +0000)]
#5910: Fix autotools build (#2) and workaround MSVC bug

9 years ago#5910: Fix autotools and Xcode build
Mike Gelfand [Sat, 4 Apr 2015 18:21:34 +0000 (18:21 +0000)]
#5910: Fix autotools and Xcode build

9 years ago#5910: Run daemon as a service on Windows
Mike Gelfand [Sat, 4 Apr 2015 17:43:56 +0000 (17:43 +0000)]
#5910: Run daemon as a service on Windows

Factor out demonization implementation to platform-specific files.
Implement daemonization on Windows using service API. Improve *NIX
implementation by handling signals asynchronously to prevent potential
issues of running complex code inside the handler.

9 years agoAdd patch from #5002 (r13646) to fix crash in libutp for CMake-based builds
Mike Gelfand [Sun, 29 Mar 2015 20:48:06 +0000 (20:48 +0000)]
Add patch from #5002 (r13646) to fix crash in libutp for CMake-based builds

9 years ago#5407: Fix crash on Mac when pausing torrents (patch by x190)
Mike Gelfand [Thu, 26 Mar 2015 18:32:33 +0000 (18:32 +0000)]
#5407: Fix crash on Mac when pausing torrents (patch by x190)

9 years agoDo not return `-EINVAL` as socket value (obviously not a good idea).
Mike Gelfand [Thu, 26 Mar 2015 18:29:11 +0000 (18:29 +0000)]
Do not return `-EINVAL` as socket value (obviously not a good idea).

Also, fix socket descriptor leak in `tr_netBindTCPImpl` if `IPV6_V6ONLY` is defined.