Kevin McCarthy [Fri, 21 Dec 2018 18:13:17 +0000 (10:13 -0800)]
Handle improperly encoded pgp/mime octetstream part
Some clients (or even mail servers) improperly encode the octetstream
part.
Thanks to Riccardo Schirone for the original merge request patch.
This commit also handles the attachment menu, and makes the decoding
conditional so it's not done if it isn't necessary.
Kevin McCarthy [Fri, 21 Dec 2018 17:42:26 +0000 (09:42 -0800)]
Display mail sent message after Fcc finishes
For the case of IMAP, the uploading message would otherwise stay on
the screen. In any case, it's best to show that message as the last
thing before returning to the index.
Kevin McCarthy [Thu, 20 Dec 2018 01:43:26 +0000 (17:43 -0800)]
When postponing, encode descriptions before encrypting
This matches the behavior of the normal send process. I don't think
there is actually an issue here since nothing is sent, but it makes
sense to be consistent.
Austin Ray [Fri, 4 Jan 2019 02:20:21 +0000 (21:20 -0500)]
folder-hook: try matching on description
Use the description, in addition to the path, when determining to
execute a `folder-hook`. Since `named-mailboxes` and `virtual-mailboxes`
use descriptions to hide ugliness of raw paths, the description may
differ from the path and/or contain information not included in the
path.
The inclusion of description checking makes `folder-hook`s improves its
ergonomics. `notmuch` users were particularly affect by poor
`folder-hook` ergonomics since `virtual-mailboxes` paths often had large
overlap, making it hard to craft a good regex. A workaround was to add a
unique dummy key.
These are needed for the new summary tables feature
(and inspired by the Command lookup table in init.c)
added: ICommand wrapper / lookup table allowing easy addition of new
informational commands that will not be parsed in .muttrc files and
override any existing rc-line commands when executed in mutt.
added: hook in mutt_enter_command in command.c to integrate new
ICommands facility
Karel Zak [Thu, 3 Jan 2019 10:51:49 +0000 (11:51 +0100)]
notmuch: make sure nm_db_longrun_done() release DB
Since commit 1cdfc0da08e09b1756a7b4d422996e907c4390d0 the function
nm_db_release() does not release DB if long-run state is enabled.
This change make code more readable and shorter.
Unfortunately, nm_db_release() is called from nm_db_longrun_done(), so
after the change the function nm_db_longrun_done() is no-op and long
transaction never finish. It means:
- changes are not committed the database
- after mutt restart old state (tags) is read from DB
- mismatch between notmuch tags and maildir filenames
This commit disables long-run state in nm_db_longrun_done() before
nm_db_release() is called.
Austin Ray [Tue, 1 Jan 2019 20:59:48 +0000 (15:59 -0500)]
Index: try description when changing mailboxes
Mailbox: find mailbox by description
Introduce `mutt_find_mailbox_desc()`, which takes a pointer to a
description, and tries to find a mailbox that corresponds to it.
With the introduction of `named-mailboxes` and removal of
`virtual-mailboxes` special cases, users may prefer to operate with
descriptions instead of (potentially) ugly paths. We can no longer
assume that a buffer is a path and require a method to find by
description.
This is not included as an `mxapi` function since `desc` is common to
all mailboxes so the backends do not need implement their own function.
Index: try description when changing mailboxes
Since mailbox descriptions are more prevalent with `named-mailboxes` and
`virtual-mailbox` special cases being removed, some users will try to
change folders with a description instead of a path.
This commit modifies `main_change_folder()` to look for a mailbox with a
given description if path probing fails.
Richard Russon [Wed, 2 Jan 2019 13:23:22 +0000 (13:23 +0000)]
demote 'last message' errors to messages
These error messages were annoying:
- You are on the last message
- You are on the first message
- Top of message is shown
- Bottom of message is shown
color: call use_default_colors() in a single location
we call use_default_colors() when parsing colors in rc files only, and
unconditionally when defining the color of the tree element, because the
foreground color of the tree element may be combined dynamically with
the default background color of another element, not explicitely defined
in an rc file. This patch fixes a bug visible with some versions of the
ncurses library: use_default_colors() was used too late, and generated
color leakage effects. (#689)
-> colors look fine on Fedora 28 with ncurses backend. The comment about slang
was in there since the first submission to git in early 2017.
valgrind backtrace of the issue without the patch:
==223072== Use of uninitialised value of size 8
==223072== at 0x593E823: tolower (in /usr/lib64/libc-2.27.so)
==223072== by 0x4C32BC5: strcasecmp (vg_replace_strmem.c:693)
==223072== by 0x43FFEB: mutt_parse_unmailboxes (mailbox.c:500)
==223072== by 0x43B134: mutt_parse_rc_line.part.18 (init.c:3145)
==223072== by 0x43B42B: mutt_parse_rc_line (init.c:3120)
==223072== by 0x43B42B: source_rc (init.c:823)
==223072== by 0x43B93A: parse_source (init.c:1845)
==223072== by 0x43B134: mutt_parse_rc_line.part.18 (init.c:3145)
==223072== by 0x43B42B: mutt_parse_rc_line (init.c:3120)
==223072== by 0x43B42B: source_rc (init.c:823)
==223072== by 0x43C1B2: mutt_init (init.c:3045)
==223072== by 0x406EB0: main (main.c:688)
The same problem is also present in the official neomutt 2018-07-16,
I've forward-ported and tested the fix for git HEAD.
The code was slightly refactored to be more readable.
Mark Stenglein [Tue, 1 Jan 2019 00:57:37 +0000 (19:57 -0500)]
imap: command: Adds unique sequence IDs
This patch adds support for unique sequence IDs to be logged. Each
new imap account is assigned an ID letter (seqid) which increments
to the next letter (and wraps at 'z') each time a new imap account
is created.
Richard Russon [Wed, 12 Dec 2018 15:22:27 +0000 (15:22 +0000)]
merge: refactor GroupContext to GroupList
* Convert GroupContext to use STAILQ
* Rename Group-related structures
* Move group.[ch] to mutt/
* Sort functions prototypes
* Get rid of global variable
* Explicitly allocate/free Groups memory
* Simplify the API when we cannot fail
* Tidy API: s/group_context/grouplist/
Richard Russon [Wed, 12 Dec 2018 12:52:48 +0000 (12:52 +0000)]
merge: imap refactoring
* imap_expunge_mailbox use m instead of adata->mailbox
* move some functions Mailbox
* imap_fix/cache_path don't need ImapAccountData
* use Mailbox in imap_sync_message_for_copy()
* Change more functions with Mailbox