]> granicus.if.org Git - php/log
php
8 years agoadd missing NEWS entries for 5.6.27
Ferenc Kovacs [Fri, 14 Oct 2016 06:05:17 +0000 (08:05 +0200)]
add missing NEWS entries for 5.6.27

8 years agoFix #73280: Stack Buffer Overflow in GD dynamicGetbuf
Christoph M. Becker [Thu, 13 Oct 2016 09:10:02 +0000 (11:10 +0200)]
Fix #73280: Stack Buffer Overflow in GD dynamicGetbuf

We make sure to never pass a negative `rlen` as size to memcpy().

Cf. <https://github.com/libgd/libgd/commit/53110871>.

8 years agoClear FG(user_stream_current_filename) when bailing out
Sara Golemon [Wed, 12 Oct 2016 04:14:25 +0000 (21:14 -0700)]
Clear FG(user_stream_current_filename) when bailing out

If a userwrapper opener E_ERRORs then FG(user_stream_current_filename)
would remain set until the next request and would not be pointing
at unallocated memory.

Catch the bailout, clear the variable, then continue bailing.

Closes https://bugs.php.net/bug.php?id=73188

8 years agoMerge branch 'PHP-5.6.27' into PHP-5.6
Stanislav Malyshev [Tue, 11 Oct 2016 23:26:35 +0000 (16:26 -0700)]
Merge branch 'PHP-5.6.27' into PHP-5.6

* PHP-5.6.27:
  Fix tests
  fix tsrm
  Fix bug #73284 - heap overflow in php_ereg_replace function
  Fix bug #73276 - crash in openssl_random_pseudo_bytes function
  Fix bug #73293 - NULL pointer dereference in SimpleXMLElement::asXML()
  fix bug #73275 - crash in openssl_encrypt function
  Fix for #73240 - Write out of bounds at number_format
  Bug #73218: add mitigation for ICU int overflow
  Add more locale length checks, due to ICU bugs.
  Fix bug #73208 - another missing length check
  Fix bug #73190: memcpy negative parameter _bc_new_num_ex
  Fix bug #73189 - Memcpy negative size parameter php_resolve_path
  Fixed bug #73174 - heap overflow in php_pcre_replace_impl
  Fix bug #73150: missing NULL check in dom_document_save_html
  Fix bug #73147: Use After Free in PHP7 unserialize()
  Fix bug #73082
  Fix bug #73073 - CachingIterator null dereference when convert to string

8 years agoFix tests
Stanislav Malyshev [Tue, 11 Oct 2016 23:16:20 +0000 (16:16 -0700)]
Fix tests

8 years agofix tsrm
Stanislav Malyshev [Tue, 11 Oct 2016 21:39:16 +0000 (14:39 -0700)]
fix tsrm

8 years agoFix bug #73284 - heap overflow in php_ereg_replace function
Stanislav Malyshev [Tue, 11 Oct 2016 21:14:43 +0000 (14:14 -0700)]
Fix bug #73284 - heap overflow in php_ereg_replace function

8 years agoFix bug #73276 - crash in openssl_random_pseudo_bytes function
Stanislav Malyshev [Tue, 11 Oct 2016 20:37:47 +0000 (13:37 -0700)]
Fix bug #73276 - crash in openssl_random_pseudo_bytes function

8 years agoFix bug #73293 - NULL pointer dereference in SimpleXMLElement::asXML()
Stanislav Malyshev [Tue, 11 Oct 2016 20:30:52 +0000 (13:30 -0700)]
Fix bug #73293 - NULL pointer dereference in SimpleXMLElement::asXML()

8 years agofix bug #73275 - crash in openssl_encrypt function
Stanislav Malyshev [Tue, 11 Oct 2016 20:19:20 +0000 (13:19 -0700)]
fix bug #73275 - crash in openssl_encrypt function

8 years agoFix for #73240 - Write out of bounds at number_format
Stanislav Malyshev [Tue, 11 Oct 2016 06:42:50 +0000 (23:42 -0700)]
Fix for #73240 - Write out of bounds at number_format

8 years agoupdate NEWS
Anatol Belski [Mon, 10 Oct 2016 18:55:44 +0000 (20:55 +0200)]
update NEWS

8 years agoadd test for bug #73037
Anatol Belski [Mon, 10 Oct 2016 13:59:52 +0000 (15:59 +0200)]
add test for bug #73037

8 years agoFix #73279: Integer overflow in gdImageScaleBilinearPalette()
Christoph M. Becker [Mon, 10 Oct 2016 09:40:16 +0000 (11:40 +0200)]
Fix #73279: Integer overflow in gdImageScaleBilinearPalette()

The color components are supposed to be in range 0..255, so we must not
cast them to `signed char`, what can be the default for `char`.

Port of <https://github.com/libgd/libgd/commit/77c8d359>.

8 years agoFix #73272: imagescale() affects imagesetinterpolation()
Christoph M. Becker [Sun, 9 Oct 2016 12:59:37 +0000 (14:59 +0200)]
Fix #73272: imagescale() affects imagesetinterpolation()

We must not permanently change the interpolation method, but rather
have to restore the old method after we're done with scaling the image.

8 years agofix leak
Anatol Belski [Sat, 8 Oct 2016 17:07:35 +0000 (19:07 +0200)]
fix leak

8 years agoFix bug #73192
Nikita Popov [Fri, 7 Oct 2016 23:04:22 +0000 (01:04 +0200)]
Fix bug #73192

8 years agoRevert "Fixed test"
Nikita Popov [Fri, 7 Oct 2016 22:43:36 +0000 (00:43 +0200)]
Revert "Fixed test"

This reverts commit a10d03ac166daba646b6023e0f12e9ee8040c909.

8 years agoRevert "Added validation to parse_url() to prohibit restricted characters inside...
Nikita Popov [Fri, 7 Oct 2016 22:43:17 +0000 (00:43 +0200)]
Revert "Added validation to parse_url() to prohibit restricted characters inside login/pass components based on RFC3986"

This reverts commit 085dfca02b64588317a233eb191d07a75511fff2.

8 years agoFix bug #73037, second round
Anatol Belski [Wed, 5 Oct 2016 12:54:06 +0000 (14:54 +0200)]
Fix bug #73037, second round

8 years agoBug #73218: add mitigation for ICU int overflow
Stanislav Malyshev [Wed, 5 Oct 2016 05:40:09 +0000 (22:40 -0700)]
Bug #73218: add mitigation for ICU int overflow

8 years agoAdd more locale length checks, due to ICU bugs.
Stanislav Malyshev [Wed, 5 Oct 2016 04:28:40 +0000 (21:28 -0700)]
Add more locale length checks, due to ICU bugs.

8 years agoFixed test
Ilia Alshanetsky [Wed, 28 Oct 2015 22:38:54 +0000 (18:38 -0400)]
Fixed test

8 years agoAdded validation to parse_url() to prohibit restricted characters inside login/pass...
Ilia Alshanetsky [Tue, 27 Oct 2015 16:40:53 +0000 (12:40 -0400)]
Added validation to parse_url() to prohibit restricted characters inside login/pass components based on RFC3986

8 years agoApparently negative wordwrap is a thing and should work as length = 0.
Stanislav Malyshev [Tue, 4 Oct 2016 02:17:42 +0000 (19:17 -0700)]
Apparently negative wordwrap is a thing and should work as length = 0.

I'll leave it as is for now.

8 years agoReally fix bug #73017
Stanislav Malyshev [Tue, 4 Oct 2016 01:06:59 +0000 (18:06 -0700)]
Really fix bug #73017

8 years agoFix bug #73208 - another missing length check
Stanislav Malyshev [Mon, 3 Oct 2016 07:12:14 +0000 (00:12 -0700)]
Fix bug #73208 - another missing length check

8 years agoFix bug #73190: memcpy negative parameter _bc_new_num_ex
Stanislav Malyshev [Mon, 3 Oct 2016 07:09:02 +0000 (00:09 -0700)]
Fix bug #73190: memcpy negative parameter _bc_new_num_ex

8 years agoFix leak in zend_exception_error
Nikita Popov [Sat, 1 Oct 2016 17:03:54 +0000 (19:03 +0200)]
Fix leak in zend_exception_error

Only occurs if a non-fatal severity level is used, e.g. when using
interactive mode.

8 years agoFix #73213: Integer overflow in imageline() with antialiasing
Christoph M. Becker [Fri, 30 Sep 2016 21:25:23 +0000 (23:25 +0200)]
Fix #73213: Integer overflow in imageline() with antialiasing

We port the respective fixes <https://github.com/libgd/libgd/commit/eca37d620>
and <https://github.com/libgd/libgd/commit/837b7327> to our bundled libgd.

8 years agoFixed tests due to changes in underlaying data
Derick Rethans [Fri, 30 Sep 2016 19:49:44 +0000 (20:49 +0100)]
Fixed tests due to changes in underlaying data

8 years agoFixed parsing of AM/PM without all the expected dots in place
Derick Rethans [Fri, 30 Sep 2016 19:21:48 +0000 (20:21 +0100)]
Fixed parsing of AM/PM without all the expected dots in place

8 years agoFix #73203: passing additional_parameters causes mail to fail
Christoph M. Becker [Fri, 30 Sep 2016 09:05:53 +0000 (11:05 +0200)]
Fix #73203: passing additional_parameters causes mail to fail

We make sure that there's no unsigned underflow, which happened for `y==0`.

8 years agoFix bug #73189 - Memcpy negative size parameter php_resolve_path
Stanislav Malyshev [Thu, 29 Sep 2016 06:30:48 +0000 (23:30 -0700)]
Fix bug #73189 - Memcpy negative size parameter php_resolve_path

8 years agoFixed bug #73174 - heap overflow in php_pcre_replace_impl
Stanislav Malyshev [Thu, 29 Sep 2016 05:29:25 +0000 (22:29 -0700)]
Fixed bug #73174 - heap overflow in php_pcre_replace_impl

8 years ago5.6.28 is next
Ferenc Kovacs [Wed, 28 Sep 2016 22:55:36 +0000 (00:55 +0200)]
5.6.28 is next

8 years agoUpdated to version 2016.7 (2016g)
Derick Rethans [Wed, 28 Sep 2016 22:30:26 +0000 (23:30 +0100)]
Updated to version 2016.7 (2016g)

8 years agoHandle resource keys in constexpr arrays
Nikita Popov [Wed, 28 Sep 2016 21:11:02 +0000 (23:11 +0200)]
Handle resource keys in constexpr arrays

8 years agoFix the constant array case as well
Nikita Popov [Wed, 28 Sep 2016 21:05:21 +0000 (23:05 +0200)]
Fix the constant array case as well

8 years agoCheck next_index_insert failure in ADD_ARRAY_ELEMENT
Nikita Popov [Wed, 28 Sep 2016 20:33:40 +0000 (22:33 +0200)]
Check next_index_insert failure in ADD_ARRAY_ELEMENT

8 years agoFix #53745: cgi.discard_path option is missing from php.ini
Christoph M. Becker [Mon, 26 Sep 2016 16:16:50 +0000 (18:16 +0200)]
Fix #53745: cgi.discard_path option is missing from php.ini

Also cgi.check_shebang_line has been missing.

8 years agoupdate libs_versions.txt
Anatol Belski [Mon, 26 Sep 2016 13:39:01 +0000 (15:39 +0200)]
update libs_versions.txt

8 years agoFix bug #73150: missing NULL check in dom_document_save_html
Stanislav Malyshev [Mon, 26 Sep 2016 04:25:01 +0000 (21:25 -0700)]
Fix bug #73150: missing NULL check in dom_document_save_html

8 years agoFix bug #73147: Use After Free in PHP7 unserialize()
Stanislav Malyshev [Mon, 26 Sep 2016 02:53:59 +0000 (19:53 -0700)]
Fix bug #73147: Use After Free in PHP7 unserialize()

8 years agoFix bug #73082
Stanislav Malyshev [Sun, 25 Sep 2016 23:07:14 +0000 (16:07 -0700)]
Fix bug #73082

8 years agoFix test_image_equals_file() wrt. palette images
Christoph M. Becker [Sun, 25 Sep 2016 08:30:48 +0000 (10:30 +0200)]
Fix test_image_equals_file() wrt. palette images

The recently introduced test_image_equals_file() doesn't properly work for
palette images, because in this case only the palette indexes are compared,
what can lead to false positives and negatives as shown in the added test.

To fix that we convert palette images to truecolor, what is supposed to be
faster than calling imagecolorsforindex() for each pixel.

We furthermore rely on PHP's refcounting to free unused images; after all,
this is not C.

8 years agoMerge branch 'pull-request/2120' into PHP-5.6
Christoph M. Becker [Sat, 24 Sep 2016 15:52:15 +0000 (17:52 +0200)]
Merge branch 'pull-request/2120' into PHP-5.6

8 years agoFix #73161: imagecreatefromgd2() may leak memory
Christoph M. Becker [Sat, 24 Sep 2016 10:36:54 +0000 (12:36 +0200)]
Fix #73161: imagecreatefromgd2() may leak memory

8 years agoFix #73159: imagegd2(): unrecognized formats may result in corrupted files
Christoph M. Becker [Sat, 24 Sep 2016 09:28:20 +0000 (11:28 +0200)]
Fix #73159: imagegd2(): unrecognized formats may result in corrupted files

We must not apply the format correction twice for truecolor images.

8 years agoFix #73155: imagegd2() writes wrong chunk sizes on boundaries
Christoph M. Becker [Fri, 23 Sep 2016 22:46:35 +0000 (00:46 +0200)]
Fix #73155: imagegd2() writes wrong chunk sizes on boundaries

8 years agoFix #73157 (again): imagegd2() ignores 3rd param if 4 are given
Christoph M. Becker [Fri, 23 Sep 2016 22:35:24 +0000 (00:35 +0200)]
Fix #73157 (again): imagegd2() ignores 3rd param if 4 are given

Obviously, there was a bad merge.

8 years agoRevert "Fixed bug #73037 SoapServer reports Bad Request when gzipped"
Anatol Belski [Fri, 23 Sep 2016 16:45:03 +0000 (18:45 +0200)]
Revert "Fixed bug #73037 SoapServer reports Bad Request when gzipped"

This reverts commit f9a699f6c3aa7acea922242a0f14731f6b829742.

8 years agoskip this test for now as it seems to have issues running dev server
Anatol Belski [Fri, 23 Sep 2016 16:07:08 +0000 (18:07 +0200)]
skip this test for now as it seems to have issues running dev server

8 years agoFixed bug #73037 SoapServer reports Bad Request when gzipped
Anatol Belski [Fri, 23 Sep 2016 14:02:50 +0000 (16:02 +0200)]
Fixed bug #73037 SoapServer reports Bad Request when gzipped

(cherry picked from commit 410c68788ae4826807e8ced3f4a02e676142b22a)

8 years agoUpdate NEWS
Christoph M. Becker [Fri, 23 Sep 2016 14:23:58 +0000 (16:23 +0200)]
Update NEWS

8 years agoFormatting. Fix possible memory corruption in FPM SHM management
Julien Pauli [Fri, 23 Sep 2016 11:24:31 +0000 (13:24 +0200)]
Formatting. Fix possible memory corruption in FPM SHM management

8 years agofix every work call mmap
tom916 [Fri, 16 Sep 2016 14:37:09 +0000 (22:37 +0800)]
fix every work call mmap

fix fpm_scoreboard_free

8 years agoRework FreeType related tests
Christoph M. Becker [Thu, 22 Sep 2016 09:52:10 +0000 (11:52 +0200)]
Rework FreeType related tests

Firstly, there is no fundamental difference between running the tests on
freetype before and after 2.4.10, so we re-join the respective test cases.

Secondly, there are some minor differences in the results depending on
architecture, freetype versions and config options, so we cater to that
by allowing small deviations from the expectations.

8 years agoupdate libs versions
Anatol Belski [Thu, 22 Sep 2016 15:01:02 +0000 (17:01 +0200)]
update libs versions

8 years agofix bug related to #865
Márcio Almada [Mon, 19 Sep 2016 16:42:07 +0000 (12:42 -0400)]
fix bug related to #865

In case USE_KEY flag is active, RegexIterator->accept() should keep it's
old behavior which is to accept keys mapping arrays.

This broke after PHP 5.5 but was not noticed due to lack of tests for USE_KEY.

8 years agoFix bug #73073 - CachingIterator null dereference when convert to string
Stanislav Malyshev [Wed, 21 Sep 2016 05:59:12 +0000 (22:59 -0700)]
Fix bug #73073 - CachingIterator null dereference when convert to string

8 years agoFixed inconsistent meaning of zend_startup_module_ex() return value used in zend_hash...
Dmitry Stogov [Tue, 20 Sep 2016 09:29:57 +0000 (12:29 +0300)]
Fixed inconsistent meaning of zend_startup_module_ex() return value used in zend_hash_apply()

8 years agoMerge branch 'pull-request/1845' into PHP-5.6
Christoph M. Becker [Mon, 19 Sep 2016 23:05:57 +0000 (01:05 +0200)]
Merge branch 'pull-request/1845' into PHP-5.6

8 years agoFix wrong year in previous commit.
George Wang [Mon, 19 Sep 2016 14:46:46 +0000 (10:46 -0400)]
Fix wrong year in previous commit.

8 years agoDo not wrap user exception in case of custom JSON serialization
Julien Pauli [Mon, 19 Sep 2016 14:06:12 +0000 (16:06 +0200)]
Do not wrap user exception in case of custom JSON serialization

8 years agoFix #73100: session_destroy null dereference in ps_files_path_create
Christoph M. Becker [Fri, 16 Sep 2016 21:41:10 +0000 (23:41 +0200)]
Fix #73100: session_destroy null dereference in ps_files_path_create

8 years agoUpdte NEWS
Xinchen Hui [Fri, 16 Sep 2016 12:55:37 +0000 (20:55 +0800)]
Updte NEWS

8 years agoFixed bug #72505 (readfile() mangles files larger than 2G)
Xinchen Hui [Tue, 28 Jun 2016 03:11:25 +0000 (11:11 +0800)]
Fixed bug #72505 (readfile() mangles files larger than 2G)

8 years agoFix #73003: Integer Overflow in gdImageWebpCtx of gd_webp.c
Christoph M. Becker [Fri, 16 Sep 2016 09:31:21 +0000 (11:31 +0200)]
Fix #73003: Integer Overflow in gdImageWebpCtx of gd_webp.c

We add the missing integer overflow check to avoid potential buffer overflows.

8 years agofix test (32bits)
Remi Collet [Thu, 15 Sep 2016 13:32:39 +0000 (15:32 +0200)]
fix test (32bits)

8 years agofix ZTS build
Remi Collet [Thu, 15 Sep 2016 11:27:20 +0000 (13:27 +0200)]
fix ZTS build

8 years agoupdate NEWS
Ferenc Kovacs [Thu, 15 Sep 2016 09:35:46 +0000 (11:35 +0200)]
update NEWS

8 years agoFix and reactivate regression test for bug #50194
Christoph M. Becker [Wed, 14 Sep 2016 22:34:55 +0000 (00:34 +0200)]
Fix and reactivate regression test for bug #50194

Apparently, different FreeType versions render the string differently, so
we have to cater to these slight differences. Unfortunately, the testing
framework doesn't yet offer a clean API for this, so we work around the
limitations by parsing and checking the output of test_image_equals_file().

8 years agoSkip ext/gd/tests/bug50194.phpt for now
Christoph M. Becker [Wed, 14 Sep 2016 18:00:30 +0000 (20:00 +0200)]
Skip ext/gd/tests/bug50194.phpt for now

There are apparently issues with the font rendering with different freetype
version; I'll have a look at this issue ASAP.

8 years agoFix #50194: imagettftext broken on transparent background w/o alphablending
Christoph M. Becker [Wed, 14 Sep 2016 12:59:17 +0000 (14:59 +0200)]
Fix #50194: imagettftext broken on transparent background w/o alphablending

We must not draw the background pixels of the character glyphs, what has
already been fixed in GD 2.0.26.

8 years agoFix bug #73072 (Invalid path SNI_server_certs causes segfault)
Jakub Zelenka [Tue, 13 Sep 2016 17:15:34 +0000 (18:15 +0100)]
Fix bug #73072 (Invalid path SNI_server_certs causes segfault)

8 years agoMerge branch 'pull-request/2126' into PHP-5.6
Christoph M. Becker [Tue, 13 Sep 2016 13:57:39 +0000 (15:57 +0200)]
Merge branch 'pull-request/2126' into PHP-5.6

8 years agoadd test for bug #73068
Anatol Belski [Tue, 13 Sep 2016 13:28:28 +0000 (15:28 +0200)]
add test for bug #73068

8 years agofix test portability
Anatol Belski [Tue, 13 Sep 2016 10:00:29 +0000 (12:00 +0200)]
fix test portability

8 years agomissed semicolon
Anatol Belski [Tue, 13 Sep 2016 08:50:44 +0000 (10:50 +0200)]
missed semicolon

8 years agofix C89 conformity
Anatol Belski [Tue, 13 Sep 2016 08:43:51 +0000 (10:43 +0200)]
fix C89 conformity

8 years agoFix bug #72293 - Heap overflow in mysqlnd related to BIT fields
Stanislav Malyshev [Tue, 13 Sep 2016 03:25:08 +0000 (20:25 -0700)]
Fix bug #72293 - Heap overflow in mysqlnd related to BIT fields

8 years agoFix test
Stanislav Malyshev [Tue, 13 Sep 2016 03:12:41 +0000 (20:12 -0700)]
Fix test

8 years agoFix bug #73065: Out-Of-Bounds Read in php_wddx_push_element of wddx.c
Stanislav Malyshev [Mon, 12 Sep 2016 07:35:01 +0000 (00:35 -0700)]
Fix bug #73065: Out-Of-Bounds Read in php_wddx_push_element of wddx.c

8 years agoFix bug #73035 (Out of bound when verify signature of tar phar in phar_parse_tarfile)
Stanislav Malyshev [Mon, 12 Sep 2016 04:37:44 +0000 (21:37 -0700)]
Fix bug #73035 (Out of bound when verify signature of tar phar in phar_parse_tarfile)

8 years agoFix bug #73052 - Memory Corruption in During Deserialized-object Destruction
Stanislav Malyshev [Mon, 12 Sep 2016 04:19:29 +0000 (21:19 -0700)]
Fix bug #73052 - Memory Corruption in During Deserialized-object Destruction

8 years agoAdd check in fgetcsv in case sizeof(unit) != sizeof(size_t)
Stanislav Malyshev [Mon, 12 Sep 2016 03:58:55 +0000 (20:58 -0700)]
Add check in fgetcsv in case sizeof(unit) != sizeof(size_t)

8 years agoFix bug #73029 - Missing type check when unserializing SplArray
Stanislav Malyshev [Mon, 12 Sep 2016 03:24:13 +0000 (20:24 -0700)]
Fix bug #73029 - Missing type check when unserializing SplArray

8 years agoFix bug #72860: wddx_deserialize use-after-free
Stanislav Malyshev [Tue, 6 Sep 2016 06:42:31 +0000 (23:42 -0700)]
Fix bug #72860: wddx_deserialize use-after-free

8 years agoAlso fix overflow in wordwrap
Stanislav Malyshev [Tue, 6 Sep 2016 01:10:51 +0000 (18:10 -0700)]
Also fix overflow in wordwrap

8 years agoFix bug #73007: add locale length check
Stanislav Malyshev [Tue, 6 Sep 2016 01:01:35 +0000 (18:01 -0700)]
Fix bug #73007: add locale length check

8 years agoAdd more checks for int overflow
Stanislav Malyshev [Mon, 5 Sep 2016 05:18:19 +0000 (22:18 -0700)]
Add more checks for int overflow

8 years agoFix bug #72928 - Out of bound when verify signature of zip phar in phar_parse_zipfile
Stanislav Malyshev [Mon, 5 Sep 2016 05:07:35 +0000 (22:07 -0700)]
Fix bug #72928 - Out of bound when verify signature of zip phar in phar_parse_zipfile

8 years agoFix various int size overflows.
Stanislav Malyshev [Fri, 2 Sep 2016 06:15:34 +0000 (23:15 -0700)]
Fix various int size overflows.

Add function for detection of string zvals with length that does not fit
INT_MAX.

8 years agoAdd myself as pdo_dblib maintainer
Adam Baratz [Fri, 9 Sep 2016 21:00:50 +0000 (17:00 -0400)]
Add myself as pdo_dblib maintainer

8 years agoSkip regression test for issue that has not yet been released in libgd
Christoph M. Becker [Mon, 12 Sep 2016 11:21:34 +0000 (13:21 +0200)]
Skip regression test for issue that has not yet been released in libgd

<https://github.com/libgd/libgd/issues/177> has been assessed as enhancement,
so most likely it will be released with GD 2.3.

8 years agoSkip test for external GD because of not yet published bugfix
Christoph M. Becker [Mon, 12 Sep 2016 10:34:11 +0000 (12:34 +0200)]
Skip test for external GD because of not yet published bugfix

8 years agoSkip tests for unpatched external libgd regarding libvpx
Christoph M. Becker [Sun, 11 Sep 2016 21:49:09 +0000 (23:49 +0200)]
Skip tests for unpatched external libgd regarding libvpx

Some issues have never been fixed in the external libgd's libvpx binding,
so we skip the respective tests.

8 years agoSplit test for bundled vs. external libgd
Christoph M. Becker [Sun, 11 Sep 2016 17:30:55 +0000 (19:30 +0200)]
Split test for bundled vs. external libgd

The behavior of imagecropauto($im, IMG_CROP_DEFAULT) is rather different
for the bundled and an external libgd, see
<https://github.com/libgd/libgd/issues/298>.
Therefore we split the test for now.

8 years agoMake test case more resilient
Christoph M. Becker [Sun, 11 Sep 2016 16:29:27 +0000 (18:29 +0200)]
Make test case more resilient

This test case fails with external libgd, because libgd < 2.2.4 converts
palette images to truecolor (<https://github.com/libgd/libgd/issues/297>).

However, even if there happens no truecolor conversion, it is not guaranteed
that the palette indexes of the original and the cropped image are identical
(this is, for instance, not the case with current libgd master where the bug
has been fixed). Therefore we check for the expected RGBA value instead of
the palette index.