]> granicus.if.org Git - sudo/log
sudo
13 years agoNeed to do checks for krb5_verify_user, krb5_init_secure_context
Todd C. Miller [Mon, 18 Apr 2011 13:22:26 +0000 (09:22 -0400)]
Need to do checks for krb5_verify_user, krb5_init_secure_context
and krb5_get_init_creds_opt_alloc regardless of whether or not
krb5-config is present.

13 years agoWork around weird AIX saved uid semantics on setuid() and setreuid().
Todd C. Miller [Fri, 15 Apr 2011 16:30:08 +0000 (12:30 -0400)]
Work around weird AIX saved uid semantics on setuid() and setreuid().
On AIX, setuid() will only set the saved uid if the euid is already 0.

13 years agoupdate copyright year
Todd C. Miller [Thu, 14 Apr 2011 20:41:38 +0000 (16:41 -0400)]
update copyright year

13 years agoTreat a missing includedir like an empty one and do not return an error.
Todd C. Miller [Thu, 14 Apr 2011 18:27:11 +0000 (14:27 -0400)]
Treat a missing includedir like an empty one and do not return an error.

13 years agoFix ARCH setting in cross-compile Solaris packages.
Todd C. Miller [Tue, 12 Apr 2011 15:52:41 +0000 (11:52 -0400)]
Fix ARCH setting in cross-compile Solaris packages.

13 years agoFix aix version setting.
Todd C. Miller [Tue, 12 Apr 2011 15:50:20 +0000 (11:50 -0400)]
Fix aix version setting.

13 years agoRemove extraneous parens in LDAP filter when sudoers_search_filter
Todd C. Miller [Tue, 12 Apr 2011 15:48:04 +0000 (11:48 -0400)]
Remove extraneous parens in LDAP filter when sudoers_search_filter
is enabled that causes a search error.  From Matthew Thomas.

13 years agoCorrect sizeof() to fix test failure.
Todd C. Miller [Mon, 11 Apr 2011 15:41:38 +0000 (11:41 -0400)]
Correct sizeof() to fix test failure.

13 years ago"install" target should depend on "install-dirs".
Todd C. Miller [Mon, 11 Apr 2011 12:27:59 +0000 (08:27 -0400)]
"install" target should depend on "install-dirs".
Fixes "make -j" problem and closes bz #487.  From Chris Coleman.

13 years agoAdd HAVE_RFC1938_SKEYCHALLENGE
Todd C. Miller [Thu, 7 Apr 2011 11:04:26 +0000 (07:04 -0400)]
Add HAVE_RFC1938_SKEYCHALLENGE

13 years agoMention plugin loading and libgcc changes
Todd C. Miller [Wed, 6 Apr 2011 21:57:10 +0000 (17:57 -0400)]
Mention plugin loading and libgcc changes

13 years agoLoad plugins after parsing arguments and potentially printing the
Todd C. Miller [Wed, 6 Apr 2011 21:51:36 +0000 (17:51 -0400)]
Load plugins after parsing arguments and potentially printing the
version.  That way, an error loading or initializing a plugin doesn't
break "sudo -h" or "sudo -V".

13 years agoWhen using a sub-shell to invoke the sub-make, exec make instead of
Todd C. Miller [Wed, 6 Apr 2011 19:32:04 +0000 (15:32 -0400)]
When using a sub-shell to invoke the sub-make, exec make instead of
running it inside the shell to avoid an extra process.

13 years agoStop testing unspecified behavior in fnmatch
Todd C. Miller [Wed, 6 Apr 2011 19:13:23 +0000 (15:13 -0400)]
Stop testing unspecified behavior in fnmatch
Make glob test more portable

13 years agoNo need to add current dir to include path and having it breaks the
Todd C. Miller [Wed, 6 Apr 2011 19:12:34 +0000 (15:12 -0400)]
No need to add current dir to include path and having it breaks the
test programs that expect to get the system glob.h and fnmatch.h

13 years agoFix and document --with-plugindir; partially from Diego Elio Petteno
Todd C. Miller [Wed, 6 Apr 2011 16:02:49 +0000 (12:02 -0400)]
Fix and document --with-plugindir; partially from Diego Elio Petteno

13 years agoFix fnmatch and glob tests to not use hard-coded flag values in the
Todd C. Miller [Wed, 6 Apr 2011 14:57:39 +0000 (10:57 -0400)]
Fix fnmatch and glob tests to not use hard-coded flag values in the
input file.  Link test programs with libreplace so we get our
replacement verions as needed.

13 years agoIf make in a subdir fails, fail the target in the upper level Makefile too.
Todd C. Miller [Wed, 6 Apr 2011 14:15:54 +0000 (10:15 -0400)]
If make in a subdir fails, fail the target in the upper level Makefile too.
Adapted from a patch from Diego Elio Petteno

13 years agoAdd check for NetBSD-style 4-argument skeychallenge() as Gentoo also
Todd C. Miller [Wed, 6 Apr 2011 14:08:57 +0000 (10:08 -0400)]
Add check for NetBSD-style 4-argument skeychallenge() as Gentoo also
has this.  Adapted from a patch from Diego Elio Petteno

13 years agoMake SUDOERS_LDFLAGS reference $(LDFLAGS) instead of using @LDFLAGS@
Todd C. Miller [Wed, 6 Apr 2011 14:06:51 +0000 (10:06 -0400)]
Make SUDOERS_LDFLAGS reference $(LDFLAGS) instead of using @LDFLAGS@
directly.

13 years agoFix warnings when -without-skey, --without-opie, --without-kerb4,
Todd C. Miller [Wed, 6 Apr 2011 13:33:07 +0000 (09:33 -0400)]
Fix warnings when -without-skey, --without-opie, --without-kerb4,
--without-kerb5 or --without-SecurID were specified.

13 years agoAdd plugins/sudoers/sudoers_version.h
Todd C. Miller [Wed, 6 Apr 2011 12:34:39 +0000 (08:34 -0400)]
Add plugins/sudoers/sudoers_version.h

13 years agoBack out the --with-libpath addition to SUDOERS_LDFLAGS since that
Todd C. Miller [Wed, 6 Apr 2011 11:01:17 +0000 (07:01 -0400)]
Back out the --with-libpath addition to SUDOERS_LDFLAGS since that
now include LDFLAGS in the sudoers Makefile.in.
Add missing settng of @LDFLAGS@ in plugin Makefile.in files.

13 years agoMention %#gid support in User_List and Runas_List
Todd C. Miller [Tue, 5 Apr 2011 22:15:05 +0000 (18:15 -0400)]
Mention %#gid support in User_List and Runas_List

13 years agoKeep track of sudoers grammar version and report it in the -V output.
Todd C. Miller [Tue, 5 Apr 2011 15:47:31 +0000 (11:47 -0400)]
Keep track of sudoers grammar version and report it in the -V output.

13 years agoAdd multiple inclusion guard
Todd C. Miller [Tue, 5 Apr 2011 15:42:53 +0000 (11:42 -0400)]
Add multiple inclusion guard

13 years agoThe --with-libpath option now adds to SUDOERS_LDFLAGS as well as LDFLAGS.
Todd C. Miller [Tue, 5 Apr 2011 13:42:59 +0000 (09:42 -0400)]
The --with-libpath option now adds to SUDOERS_LDFLAGS as well as LDFLAGS.
Remove old -static hack for HP-UX < 9.
Add LTLDFLAGS and set it to -Wc,-static-libgcc if not using GNU ld so we
    don't have a dependency on the shared libgcc in sudoers.so.

13 years agoFix typo; from Petr Uzel
Todd C. Miller [Tue, 5 Apr 2011 13:13:18 +0000 (09:13 -0400)]
Fix typo; from Petr Uzel

13 years agoIn dump-only mode, use "root" as the default username instead of
Todd C. Miller [Fri, 1 Apr 2011 17:54:30 +0000 (13:54 -0400)]
In dump-only mode, use "root" as the default username instead of
"nobody" as the latter may not be available on all systems.

13 years agoRemove NewArgv/NewArgc, they are no longer needed.
Todd C. Miller [Thu, 31 Mar 2011 18:06:11 +0000 (14:06 -0400)]
Remove NewArgv/NewArgc, they are no longer needed.

13 years agoFix setting of user_args
Todd C. Miller [Thu, 31 Mar 2011 17:57:05 +0000 (13:57 -0400)]
Fix setting of user_args

13 years agoAdd '!' token to lex tracing
Todd C. Miller [Thu, 31 Mar 2011 17:42:05 +0000 (13:42 -0400)]
Add '!' token to lex tracing

13 years agoUse group bin in test, not wheel as most systems have the bin group
Todd C. Miller [Thu, 31 Mar 2011 16:54:17 +0000 (12:54 -0400)]
Use group bin in test, not wheel as most systems have the bin group
but the same is no longer true of wheel.

13 years agoAvoid using pre or post increment in a parameter to a ctype(3)
Todd C. Miller [Thu, 31 Mar 2011 16:48:01 +0000 (12:48 -0400)]
Avoid using pre or post increment in a parameter to a ctype(3)
function as it might be a macro that causes the increment to happen
more than once.

13 years agoStrip off the beta or release candidate version when building AIX
Todd C. Miller [Wed, 30 Mar 2011 16:25:41 +0000 (12:25 -0400)]
Strip off the beta or release candidate version when building AIX
packages.

13 years agoWe need to include OSDEFS in CFLAGS when doing the utmp/utmpx
Todd C. Miller [Wed, 30 Mar 2011 14:14:25 +0000 (10:14 -0400)]
We need to include OSDEFS in CFLAGS when doing the utmp/utmpx
structure checks for glibc which only has __e_termination visible
when _GNU_SOURCE is *not* defined.

13 years agogetuserattr(user, ...) will fall back to the "default" entry
Todd C. Miller [Wed, 30 Mar 2011 12:54:38 +0000 (08:54 -0400)]
getuserattr(user, ...) will fall back to the "default" entry
automatically, there's no need to check "default" manually.

13 years agoDocument parser changes.
Todd C. Miller [Tue, 29 Mar 2011 21:57:46 +0000 (17:57 -0400)]
Document parser changes.

13 years agoIf there is an existing sudoers file, only install if it passes a
Todd C. Miller [Tue, 29 Mar 2011 19:20:32 +0000 (15:20 -0400)]
If there is an existing sudoers file, only install if it passes a
syntax check.

13 years agoAdd runasgroup support to testsudoers
Todd C. Miller [Tue, 29 Mar 2011 18:40:07 +0000 (14:40 -0400)]
Add runasgroup support to testsudoers

13 years agoFor "make check", keep going even if a test fails.
Todd C. Miller [Tue, 29 Mar 2011 18:39:02 +0000 (14:39 -0400)]
For "make check", keep going even if a test fails.

13 years agoMore useful exit codes:
Todd C. Miller [Tue, 29 Mar 2011 17:09:58 +0000 (13:09 -0400)]
More useful exit codes:
 * 0 - parsed OK and command matched.
 * 1 - parse error
 * 2 - command not matched
 * 3 - command denied

13 years agoDocument %#gid, and %:#nonunix_gid syntax.
Todd C. Miller [Tue, 29 Mar 2011 16:53:37 +0000 (12:53 -0400)]
Document %#gid, and %:#nonunix_gid syntax.

13 years agoAdd support to user_in_group() for treating group names that begin with
Todd C. Miller [Tue, 29 Mar 2011 15:29:43 +0000 (11:29 -0400)]
Add support to user_in_group() for treating group names that begin with
a '#' as gids.

13 years agoAdd explicit check for struct utmpx.ut_exit.e_termination
Todd C. Miller [Tue, 29 Mar 2011 13:10:40 +0000 (09:10 -0400)]
Add explicit check for struct utmpx.ut_exit.e_termination
and struct utmpx.ut_exit.__e_termination.  HP-UX uses the latter.
Only update ut_exit if we detect one or the other.

13 years agoAdd back missing #include of config.h
Todd C. Miller [Mon, 28 Mar 2011 18:50:55 +0000 (14:50 -0400)]
Add back missing #include of config.h

13 years agoAvoid a NULL deref on unrecognized escapes.
Todd C. Miller [Mon, 28 Mar 2011 16:54:41 +0000 (12:54 -0400)]
Avoid a NULL deref on unrecognized escapes.
Collapse %% -> % like strftime() does.

13 years agoQuote first argument to AC_DEFUN(); from Elan Ruusamae
Todd C. Miller [Mon, 28 Mar 2011 13:36:01 +0000 (09:36 -0400)]
Quote first argument to AC_DEFUN(); from Elan Ruusamae

13 years agoadd new sudoers tests
Todd C. Miller [Sun, 27 Mar 2011 22:29:55 +0000 (18:29 -0400)]
add new sudoers tests

13 years agoAdd test for a newline in the middle of a string when no line continuation
Todd C. Miller [Sun, 27 Mar 2011 21:22:02 +0000 (17:22 -0400)]
Add test for a newline in the middle of a string when no line continuation
character is used.

13 years agoUse bitwise AND instead of modulus to check for length being odd.
Todd C. Miller [Sun, 27 Mar 2011 21:12:45 +0000 (17:12 -0400)]
Use bitwise AND instead of modulus to check for length being odd.
A newline in the middle of a string is an error unless a line
continuation character is used.

13 years agoMove lexer globals initialization into init_lexer.
Todd C. Miller [Sun, 27 Mar 2011 13:45:42 +0000 (09:45 -0400)]
Move lexer globals initialization into init_lexer.

13 years agoFix a potential crash when a non-regular file is present in an
Todd C. Miller [Sun, 27 Mar 2011 13:27:43 +0000 (09:27 -0400)]
Fix a potential crash when a non-regular file is present in an
includedir.  Fixes bz #452

13 years agoOn some Linux systems, "uname -p" contains detailed processor info
Todd C. Miller [Sun, 27 Mar 2011 13:24:52 +0000 (09:24 -0400)]
On some Linux systems, "uname -p" contains detailed processor info
so check "uname -m" first and then "uname -p" if needed.
Recognize PLD Linux.

13 years agoDon't need all sudoers.h here.
Todd C. Miller [Fri, 25 Mar 2011 14:22:19 +0000 (10:22 -0400)]
Don't need all sudoers.h here.

13 years agoPrint sudo version early, in case policy plugin init fails.
Todd C. Miller [Fri, 25 Mar 2011 13:58:08 +0000 (09:58 -0400)]
Print sudo version early, in case policy plugin init fails.

13 years agoUpdate to match change in input.
Todd C. Miller [Thu, 24 Mar 2011 15:15:11 +0000 (11:15 -0400)]
Update to match change in input.

13 years agoMake an empty group or netgroup a syntax error.
Todd C. Miller [Thu, 24 Mar 2011 15:00:30 +0000 (11:00 -0400)]
Make an empty group or netgroup a syntax error.

13 years agoAn empty group or netgroup should be a syntax error.
Todd C. Miller [Thu, 24 Mar 2011 15:00:05 +0000 (11:00 -0400)]
An empty group or netgroup should be a syntax error.

13 years agoCheck that uids work in per-user and per-runas Defaults
Todd C. Miller [Thu, 24 Mar 2011 14:40:03 +0000 (10:40 -0400)]
Check that uids work in per-user and per-runas Defaults
Check that uids and gids work in a Command_Spec

13 years agoTest empty string in User_Alias and Command_Spec
Todd C. Miller [Thu, 24 Mar 2011 14:39:25 +0000 (10:39 -0400)]
Test empty string in User_Alias and Command_Spec

13 years agoAllow a group ID in the User_Spec.
Todd C. Miller [Thu, 24 Mar 2011 14:37:34 +0000 (10:37 -0400)]
Allow a group ID in the User_Spec.

13 years agoReturn an error for the empty string when a word is expected.
Todd C. Miller [Wed, 23 Mar 2011 22:51:57 +0000 (18:51 -0400)]
Return an error for the empty string when a word is expected.
Allow an ID for per-user or per-runas Defaults.

13 years agoFix printing "User_Alias FOO = ALL"
Todd C. Miller [Wed, 23 Mar 2011 20:00:30 +0000 (16:00 -0400)]
Fix printing "User_Alias FOO = ALL"

13 years agoBetter error message about invalid -C argument
Todd C. Miller [Tue, 22 Mar 2011 14:19:32 +0000 (10:19 -0400)]
Better error message about invalid -C argument

13 years agofix typo
Todd C. Miller [Tue, 22 Mar 2011 14:03:10 +0000 (10:03 -0400)]
fix typo

13 years agoFix placement of equal size ('=') in user specification summary.
Todd C. Miller [Tue, 22 Mar 2011 13:40:24 +0000 (09:40 -0400)]
Fix placement of equal size ('=') in user specification summary.

13 years agoupdate to match sudoers regress
Todd C. Miller [Mon, 21 Mar 2011 22:52:03 +0000 (18:52 -0400)]
update to match sudoers regress

13 years agoRestore ability to define TRACELEXER and have trace output go to stderr.
Todd C. Miller [Mon, 21 Mar 2011 21:57:38 +0000 (17:57 -0400)]
Restore ability to define TRACELEXER and have trace output go to stderr.

13 years agoRestore old behavior of setting sawspace = TRUE for command line
Todd C. Miller [Mon, 21 Mar 2011 21:46:50 +0000 (17:46 -0400)]
Restore old behavior of setting sawspace = TRUE for command line
args when a line continuation character is hit to avoid causing
problems for existing sudoers files.

13 years agoAdd test for line continuation and aliases
Todd C. Miller [Mon, 21 Mar 2011 19:21:51 +0000 (15:21 -0400)]
Add test for line continuation and aliases

13 years agoMake test output line up nicely for parse vs. toke
Todd C. Miller [Mon, 21 Mar 2011 19:09:47 +0000 (15:09 -0400)]
Make test output line up nicely for parse vs. toke

13 years agoMove parser tests to sudoers directory and test the tokenizer output too.
Todd C. Miller [Mon, 21 Mar 2011 19:08:49 +0000 (15:08 -0400)]
Move parser tests to sudoers directory and test the tokenizer output too.

13 years agoIf we match a rule anchored to the beginning of a line after parsing
Todd C. Miller [Mon, 21 Mar 2011 16:48:33 +0000 (12:48 -0400)]
If we match a rule anchored to the beginning of a line after parsing
a line continuation character, return an ERROR token.  It would be
nicer to use REJECT instead but that substantially slows down the
lexer.

13 years agoMove LEXTRACE macro to toke.h so we can use it in yyerror().
Todd C. Miller [Mon, 21 Mar 2011 16:39:06 +0000 (12:39 -0400)]
Move LEXTRACE macro to toke.h so we can use it in yyerror().

13 years agoMake lex tracing settable at run-time in testsudoers via the -t
Todd C. Miller [Mon, 21 Mar 2011 01:25:57 +0000 (21:25 -0400)]
Make lex tracing settable at run-time in testsudoers via the -t
flag.  Trace output goes to stderr.  Will be used by regress tests
to check lexer.

13 years agoAllow whitespace after the modifier in a Defaults entry.
Todd C. Miller [Sun, 20 Mar 2011 16:24:36 +0000 (12:24 -0400)]
Allow whitespace after the modifier in a Defaults entry.
E.g. "Defaults: username set_home"

13 years agoDon't set CC when cross-compiling.
Todd C. Miller [Fri, 18 Mar 2011 21:40:24 +0000 (17:40 -0400)]
Don't set CC when cross-compiling.

13 years agoCredit Matthew Thomas for the sudoers_search_filter changes.
Todd C. Miller [Fri, 18 Mar 2011 17:05:47 +0000 (13:05 -0400)]
Credit Matthew Thomas for the sudoers_search_filter changes.

13 years agoAdd the .sym files to the MANIFEST
Todd C. Miller [Fri, 18 Mar 2011 14:41:46 +0000 (10:41 -0400)]
Add the .sym files to the MANIFEST

13 years agoUpdate for sudo 1.8.1 beta
Todd C. Miller [Fri, 18 Mar 2011 14:24:40 +0000 (10:24 -0400)]
Update for sudo 1.8.1 beta

13 years agouser_shell -> run_shell to avoid confusion with the user's SHELL variable.
Todd C. Miller [Fri, 18 Mar 2011 14:23:35 +0000 (10:23 -0400)]
user_shell -> run_shell to avoid confusion with the user's SHELL variable.

13 years agoSave the controlling tty process group before suspending in pty
Todd C. Miller [Fri, 18 Mar 2011 14:04:50 +0000 (10:04 -0400)]
Save the controlling tty process group before suspending in pty
mode.  Previously, we assumed that the child pgrp == child pid
(which is usually, but not always, the case).

13 years agoAdd support for sudoers_search_filter setting in ldap.conf. This
Todd C. Miller [Fri, 18 Mar 2011 13:38:42 +0000 (09:38 -0400)]
Add support for sudoers_search_filter setting in ldap.conf.  This
can be used to restrict the set of records returned by the LDAP
query.

13 years agoRemove the hack to disable -g in CFLAGS unless --with-devel
Todd C. Miller [Thu, 17 Mar 2011 22:43:46 +0000 (18:43 -0400)]
Remove the hack to disable -g in CFLAGS unless --with-devel

13 years agoThe '@' character does not normally need to be quoted.
Todd C. Miller [Thu, 17 Mar 2011 20:45:09 +0000 (16:45 -0400)]
The '@' character does not normally need to be quoted.

13 years agoWe normaly transition from GOTDEFS to STARTDEFS on whitespace, but
Todd C. Miller [Thu, 17 Mar 2011 20:36:13 +0000 (16:36 -0400)]
We normaly transition from GOTDEFS to STARTDEFS on whitespace, but
if that whitespace is followed by a comma, we want to treat it as
part of a list and not transition.

13 years agoAdd check for whitespace when a User_List is used for a per-user
Todd C. Miller [Thu, 17 Mar 2011 20:33:11 +0000 (16:33 -0400)]
Add check for whitespace when a User_List is used for a per-user
Defaults entry.

13 years agoExpand quoted name checks to cover recent fixes.
Todd C. Miller [Thu, 17 Mar 2011 19:48:00 +0000 (15:48 -0400)]
Expand quoted name checks to cover recent fixes.

13 years agoFix parsing of double-quoted names in Defaultd and Aliases which was
Todd C. Miller [Thu, 17 Mar 2011 19:06:55 +0000 (15:06 -0400)]
Fix parsing of double-quoted names in Defaultd and Aliases which was
broken in 601d97ea8792.

13 years agotoke_util.c lives in $(srcdir) not $(devdir)
Todd C. Miller [Thu, 17 Mar 2011 18:33:25 +0000 (14:33 -0400)]
toke_util.c lives in $(srcdir) not $(devdir)

13 years agoChange trunk version to 1.8.x to distinguish from real 1.8.0.
Todd C. Miller [Wed, 16 Mar 2011 20:07:33 +0000 (16:07 -0400)]
Change trunk version to 1.8.x to distinguish from real 1.8.0.

13 years agoDocument major changes in 1.8.1 and add upgrade notes.
Todd C. Miller [Wed, 16 Mar 2011 20:06:16 +0000 (16:06 -0400)]
Document major changes in 1.8.1 and add upgrade notes.

13 years agoBe careful not to deref user_stat if it is NULL. This cannot currently
Todd C. Miller [Wed, 16 Mar 2011 19:59:44 +0000 (15:59 -0400)]
Be careful not to deref user_stat if it is NULL.  This cannot currently
happen in sudo but might in other programs using the parser.

13 years agoconfigure will not add -O2 to CFLAGS if it is already defined to
Todd C. Miller [Wed, 16 Mar 2011 17:38:58 +0000 (13:38 -0400)]
configure will not add -O2 to CFLAGS if it is already defined to
add -O2 to the CFLAGS we pass in when PIE is being used.

13 years agoWarn about the dangers of log_input and mention iolog_file and iolog_dir
Todd C. Miller [Wed, 16 Mar 2011 17:26:27 +0000 (13:26 -0400)]
Warn about the dangers of log_input and mention iolog_file and iolog_dir
in the log_input and log_output descriptions.

13 years agosync with git version
Todd C. Miller [Wed, 16 Mar 2011 17:06:39 +0000 (13:06 -0400)]
sync with git version

13 years agoIt seems that h comes after i
Todd C. Miller [Wed, 16 Mar 2011 16:07:03 +0000 (12:07 -0400)]
It seems that h comes after i

13 years agoMove log_input and log_output to their proper, sorted, location.
Todd C. Miller [Wed, 16 Mar 2011 16:05:32 +0000 (12:05 -0400)]
Move log_input and log_output to their proper, sorted, location.
Document set_utmp and utmp_runas.

13 years agoSave the controlling tty process group before suspending so we can
Todd C. Miller [Wed, 16 Mar 2011 16:02:04 +0000 (12:02 -0400)]
Save the controlling tty process group before suspending so we can
restore it when we resume.  Fixes job control problems on Linux
caused by the previous attemp to fix resuming a shell when I/O
logging not enabled.