Marc G. Fournier [Thu, 23 Jan 1997 16:04:25 +0000 (16:04 +0000)]
Fix from Andrew for compiling libpgtcl...basically, switch off -Werror,
which probably isn't needed, since we are going to take off -Werror
anyway, right?
Vadim B. Mikheev [Wed, 22 Jan 1997 06:25:42 +0000 (06:25 +0000)]
1. INDEXSCAN_PATCH changes: (op Param Var) should work too
2. IndexScanableOperand now uses match_indexkey_operand
instead of equal_indexkey_var (if we have some index on attribute X
then we shouldn't use it for 'where some_func(X) OP CONST').
Vadim B. Mikheev [Wed, 22 Jan 1997 05:26:50 +0000 (05:26 +0000)]
Fixing bug in INDEXSCAN_PATCH:
ExecInitIndexScan now works with operands of Param type and
(!!!) postquel_execute() now substitutes param values
before calling postquel_start().
Marc G. Fournier [Wed, 22 Jan 1997 04:41:45 +0000 (04:41 +0000)]
Taking a chance here. Under both Solaris and FreeBSD, there is a
/usr/include/limits.h (which quiets the costsize.c warnings)...under
FreeBSD, /usr/include/limits.h *includes* machine/limits.h, while under
Solaris, there is no such things as /usr/include/machine...
Vadim B. Mikheev [Mon, 20 Jan 1997 04:36:48 +0000 (04:36 +0000)]
Fixing possible losing data changes:
1. New flag - BM_JUST_DIRTIED - added for BufferDesc;
2. All data "dirtiers" (WriteBuffer and WriteNoReleaseBuffer)
set this flag (and BM_DIRTY too);
3. All data "flushers" (FlushBuffer, BufferSync and BufferReplace)
turn this flag off just before calling smgr[blind]write/smgrflush
and check this flag after flushing buffer: if it turned ON then
BM_DIRTY will stay ON.
Vadim B. Mikheev [Mon, 20 Jan 1997 04:01:50 +0000 (04:01 +0000)]
1. Setting rdesc->rd_tmpunlinked to FALSE in heap_creatr () just after
smgrcreate ().
2. Checking rdesc->rd_tmpunlinked in heap_destroy () & heap_destroyr ()
before calling smgrunlink ().
Vadim B. Mikheev [Thu, 16 Jan 1997 08:11:41 +0000 (08:11 +0000)]
No more LateWrite, but there is WriteMode;
SetBufferWriteMode () added;
FlushBuffer () fixed: now directly calls smgrflush () and
releases buffer only if required by caller.
Bruce Momjian [Tue, 14 Jan 1997 01:56:44 +0000 (01:56 +0000)]
There are two prototypes for inet_aton, one in include/inet_aton.h, and
another one in Solaris' port-protos.h.
The following patch will bring inet_aton's prototype into scope for
Ultrix to silence a compilation warning.
If the intention is to have inet_aton's prototype in its own header
filer, the declaration in Solaris' port-protos.h should be removed.
If the declaration in port-protos.h is deemed to be the correct
place, a declaration should be added in Ultrix' port-protos.h
Bruce Momjian [Tue, 14 Jan 1997 01:53:11 +0000 (01:53 +0000)]
Another compilation error has surfaced on Ultrix. In spin.c, sem.h must be
included after storage/ipc.h like other similar cases that were changed
recently.
Bruce Momjian [Fri, 10 Jan 1997 20:52:32 +0000 (20:52 +0000)]
I've noticed that \i filename in 6.0beta prints the input file double-spaced.
Here is a trivial patch to get back the 1.09 behavior; it just removes trailing
newlines before printing the line out with a newline rather than after...
Bruce Momjian [Fri, 10 Jan 1997 17:40:07 +0000 (17:40 +0000)]
I found the following bugs in the version 6.0 (dated 961229).
At least the first two should be fixed before the final release of 6.0.
1) There is a mismatch between the type declared in the catalog for
the input/output attributes of pg_type and the actual type of
values stored in the table. The type of typinput, typoutput,
typsend and typreceive are declared oid (26) while the values are
regproc (24). The error was there also in previous versions but
nobody noticed it until an Assert has been added in ExecEvalVar.
The effect is that it is now impossible to replace the typoutput
of existing data types with new procs.
2) The identd hba fails after the first time because the data read
from the identd socket is not zero-terminated and strlen reports
an incorrect length if the stack contains garbage, which usually
happens after the first connection has been made.
3) The new initdb wants to create itself the data directory. This
implies that the parent directory must be writable by postgres and
this may not always be desirable. A better solution would be to
allow the directory to be created by root and then filled by initdb.
It would also nice to have some reasonable default for PGLIB and
PGDATA like the previous version did. This applies also to the
postmaster executable.
counting the empty dummy queries in libpq isn't everything.
If the backend sends an error, the I returns from the dummies
still come. So we must eat them up in any case, not just
returning on the occurence of an E reply.