]> granicus.if.org Git - shadow/log
shadow
16 years agoFix typo.
nekral-guest [Sun, 3 Feb 2008 21:42:08 +0000 (21:42 +0000)]
Fix typo.

16 years agoNo need to check audit_fd, audit_logger() will take care of this.
nekral-guest [Sun, 3 Feb 2008 21:40:01 +0000 (21:40 +0000)]
No need to check audit_fd, audit_logger() will take care of this.

16 years agoReally log the expiration date change as human readable strings instead of
nekral-guest [Sun, 3 Feb 2008 21:37:45 +0000 (21:37 +0000)]
Really log the expiration date change as human readable strings instead of
integers.

16 years agoUse a function to convert the dates from /etc/shadow to human readable dates.
nekral-guest [Sun, 3 Feb 2008 21:30:47 +0000 (21:30 +0000)]
Use a function to convert the dates from /etc/shadow to human readable dates.

16 years agoTODO cleanup
nekral-guest [Sun, 3 Feb 2008 18:51:11 +0000 (18:51 +0000)]
TODO cleanup
- newusers: i = 100; not a nice initial value, use login.defs
This is done. newusers now uses (UID|GID)_(MIN|MAX)
- remove the entries regarding outdated translation of documentation.
The manpages translation should use the PO.
- the manpages should mention when the options were added.
This should help user to choose option for portable scripts

16 years agoAdd ideas for new tests in the testsuite.
nekral-guest [Sun, 3 Feb 2008 17:58:16 +0000 (17:58 +0000)]
Add ideas for new tests in the testsuite.

16 years agoDo not translate the fromhost variable. It is always used for syslog messages.
nekral-guest [Sun, 3 Feb 2008 17:57:43 +0000 (17:57 +0000)]
Do not translate the fromhost variable. It is always used for syslog messages.

16 years agoSwitch to the C locale before sending messages to syslog. The messages
nekral-guest [Sun, 3 Feb 2008 17:53:21 +0000 (17:53 +0000)]
Switch to the C locale before sending messages to syslog. The messages
sent by shadow were not translated, but error messages from PAM returned
by pam_strerror() were translated in the users's locale.

16 years ago * NEWS: newusers will behave more like useradd.
nekral-guest [Sun, 3 Feb 2008 17:45:58 +0000 (17:45 +0000)]
* NEWS: newusers will behave more like useradd.
* src/newusers.c: The user's ID must be found before the group ID
to mimic useradd's behavior choices of UID and GID.
* src/newusers.c: Reuse the generic find_new_uid() and
find_new_gid() functions. This permits to respect the
UID_MIN/UID_MAX and GID_MIN/GID_MAX variables, should
* src/newusers.c: Check if the user or group exist using the
external databases (with the libc getpwnam/getgrnam functions).
Refuse to update an user which exist in an external database but
does not exist in the local database.
* src/newusers.c: Check the usernames and groupnames with
check_user_name() and check_group_name()
* src/newusers.c: Use isdigit() for readability.
* src/newusers.c: Check if numerical IDs are valid (no remaining
chars).

* NEWS, src/newusers.c: Fix the support for the NONE crypt method.

* src/newusers.c: Fix shadow group support (the list of admins was
not defined; it is now set to an empty list).

16 years agoDo not seed the random number generator each time, and use the time in
nekral-guest [Sun, 3 Feb 2008 17:23:58 +0000 (17:23 +0000)]
Do not seed the random number generator each time, and use the time in
microseconds to avoid having the same salt for different passwords
generated in the same second.  This permits to avoid using the same salt
for different passwords in newusers.

16 years agoAdd libmisc/find_new_ids.c to the sources of the libmisc library.
nekral-guest [Sun, 3 Feb 2008 16:57:21 +0000 (16:57 +0000)]
Add libmisc/find_new_ids.c to the sources of the libmisc library.

16 years agoUse the find_new_uid() and find_new_gid() from the library instead of the
nekral-guest [Sun, 3 Feb 2008 16:56:23 +0000 (16:56 +0000)]
Use the find_new_uid() and find_new_gid() from the library instead of the
local functions.

16 years agoAdd libmisc/find_new_ids.c to the sources of the libmisc library.
nekral-guest [Sun, 3 Feb 2008 16:55:37 +0000 (16:55 +0000)]
Add libmisc/find_new_ids.c to the sources of the libmisc library.

16 years agoThe new libmisc/find_new_ids.c file contains translatable strings.
nekral-guest [Sun, 3 Feb 2008 16:53:53 +0000 (16:53 +0000)]
The new libmisc/find_new_ids.c file contains translatable strings.

16 years agoAdd new generic functions to find the next user or group ID available:
nekral-guest [Sun, 3 Feb 2008 16:53:07 +0000 (16:53 +0000)]
Add new generic functions to find the next user or group ID available:
find_new_uid() and find_new_gid(). They work the same way as the functions
with the same name of useradd or groupadd, except that they check in the
local database to make sure an ID was not reserved in an uncommitted
change (this is needed to be used in newusers), they report a status
instead of calling exit(), and they can receive a preferred ID. They
should later support system IDs. This should be a little bit slower, but
not too much (if the database is not open the checks against the local
database will exit immediately, and if it is already open, all the checks
will be done regarding the data in memory).

16 years agoNew function to find a group by its GID on the local database.
nekral-guest [Sun, 3 Feb 2008 16:51:08 +0000 (16:51 +0000)]
New function to find a group by its GID on the local database.

16 years agoNew function to find an user by its UID on the local database.
nekral-guest [Sun, 3 Feb 2008 16:50:14 +0000 (16:50 +0000)]
New function to find an user by its UID on the local database.

16 years ago * libmisc/age.c, libmisc/yesno.c, src/lastlog.c, src/grpck.c,
nekral-guest [Sun, 3 Feb 2008 16:28:03 +0000 (16:28 +0000)]
 * libmisc/age.c, libmisc/yesno.c, src/lastlog.c, src/grpck.c,
   src/chfn.c, src/passwd.c, src/chage.c, src/login.c, src/sulogin.c,
   src/chsh.c: Fix call to puts (remove end of line, or use fputs).
 * po/*.po: Unfuzzy PO files according to above change.

16 years agoFrench translation update (obvious things only)
bubulle [Sun, 3 Feb 2008 06:20:06 +0000 (06:20 +0000)]
French translation update (obvious things only)

16 years agoUpdated PO files.
nekral-guest [Sat, 2 Feb 2008 17:20:42 +0000 (17:20 +0000)]
Updated PO files.

16 years agoFix comment. find_new_fid is no more called is the user specified a group
nekral-guest [Sun, 27 Jan 2008 14:31:23 +0000 (14:31 +0000)]
Fix comment. find_new_fid is no more called is the user specified a group
ID.

16 years agoFix build failures with --disable-shadowgrp. Thanks to Jürgen
nekral-guest [Sat, 26 Jan 2008 17:41:20 +0000 (17:41 +0000)]
Fix build failures with --disable-shadowgrp. Thanks to Jürgen
Daubert for the patch.
* libmisc/salt.c: Include <stdio.h>, needed for stderr and printf
  functions.
* lib/encrypt.c: Include <stdio.h>, needed for perror, stderr and
  printf functions
* src/usermod.c: sgr_locked exists only if SHADOWGRP is defined.
* src/chgpasswd.c: Only check is the gshadow file exists if
  SHADOWGRP is defined.

16 years agoReplace printf by puts for fixed strings. This would avoid issues caused
nekral-guest [Thu, 24 Jan 2008 21:07:14 +0000 (21:07 +0000)]
Replace printf by puts for fixed strings. This would avoid issues caused
by formats introduced in translated strings.

16 years agoRe-indent.
nekral-guest [Thu, 24 Jan 2008 20:54:42 +0000 (20:54 +0000)]
Re-indent.

16 years agoReplace printf by puts for fixed strings. This would avoid issues caused
nekral-guest [Thu, 24 Jan 2008 20:42:12 +0000 (20:42 +0000)]
Replace printf by puts for fixed strings. This would avoid issues caused
by formats introduced in translated strings.

16 years agoRe-indent.
nekral-guest [Thu, 24 Jan 2008 19:50:09 +0000 (19:50 +0000)]
Re-indent.

16 years agoReplace printf by puts for fixed strings. This would avoid issues caused
nekral-guest [Thu, 24 Jan 2008 19:38:06 +0000 (19:38 +0000)]
Replace printf by puts for fixed strings. This would avoid issues caused
by formats introduced in translated strings.

16 years agoRe-indent.
nekral-guest [Thu, 24 Jan 2008 19:24:03 +0000 (19:24 +0000)]
Re-indent.

16 years agoReplace printf by puts for fixed strings. This would avoid issues caused
nekral-guest [Thu, 24 Jan 2008 18:39:05 +0000 (18:39 +0000)]
Replace printf by puts for fixed strings. This would avoid issues caused
by formats introduced in translated strings.

16 years agoadduser was a typo. Move the adduser entries to the useradd section.
nekral-guest [Wed, 23 Jan 2008 23:48:39 +0000 (23:48 +0000)]
adduser was a typo. Move the adduser entries to the useradd section.

16 years agoApply Christian's recommendation:
nekral-guest [Wed, 23 Jan 2008 22:31:38 +0000 (22:31 +0000)]
Apply Christian's recommendation:
s/can't get unique/no more available/

16 years agoCheck that the new fields set with -u, -s, -l, -g, -f, -e, -d, and -c
nekral-guest [Wed, 23 Jan 2008 21:50:27 +0000 (21:50 +0000)]
Check that the new fields set with -u, -s, -l, -g, -f, -e, -d, and -c
differ from the old ones. If a requested new value is equal to the old
one, no changes will be performed for that field. If no fields are
changed, usermod will exist successfully with a warning. This avoids
logging changes to syslog when there are actually no changes.

16 years agoAlways define user_newcomment, user_newshell, user_newexpire, and
nekral-guest [Wed, 23 Jan 2008 21:19:08 +0000 (21:19 +0000)]
Always define user_newcomment, user_newshell, user_newexpire, and
user_newinactive. It is more simple to always have user_<x> as the old
field, and user_new<x> as the new field (even if the field did not change)
instead of changing the algorithm depending on WITH_AUDIT.

16 years agouser_newname can only be used in WITH_AUDIT code or when lflg is set. This
nekral-guest [Wed, 23 Jan 2008 20:08:16 +0000 (20:08 +0000)]
user_newname can only be used in WITH_AUDIT code or when lflg is set. This
issue was introduced in the code refactoring of usermod.

16 years agoFix typo in comment: s/find_new_uid/find_new_gid/
nekral-guest [Tue, 22 Jan 2008 22:59:06 +0000 (22:59 +0000)]
Fix typo in comment: s/find_new_uid/find_new_gid/

16 years ago * s/gid/GID/ in message string.
nekral-guest [Tue, 22 Jan 2008 22:57:55 +0000 (22:57 +0000)]
 * s/gid/GID/ in message string.
 * Set this string for translation.

16 years ago* man/grpck.8.xml: Conditionally include the parts mentioning the
nekral-guest [Tue, 22 Jan 2008 21:42:48 +0000 (21:42 +0000)]
* man/grpck.8.xml: Conditionally include the parts mentioning the
  gshadow file (based on SHADOWGRP).
* man/grpck.8.xml: Add reference to the gshadow(5) manpage
 (conditionally included).

16 years agoFix typo. Remove "the" from "All entries in the <filename></filename> are
nekral-guest [Tue, 22 Jan 2008 21:15:58 +0000 (21:15 +0000)]
Fix typo. Remove "the" from "All entries in the <filename></filename> are
checked [...]"

16 years agoIndicate that the shadow parameter is optional (i.e. a passwd file can be
nekral-guest [Tue, 22 Jan 2008 21:13:43 +0000 (21:13 +0000)]
Indicate that the shadow parameter is optional (i.e. a passwd file can be
specified without a shadow file, and the group file can be specified
without the gshadow file).

16 years agoDocument the options with a list of options, as in the pwck(8) manpage.
nekral-guest [Tue, 22 Jan 2008 20:56:13 +0000 (20:56 +0000)]
Document the options with a list of options, as in the pwck(8) manpage.

16 years ago* NEWS, src/newgrp.c: Fix segfault when an user returns to an
nekral-guest [Mon, 21 Jan 2008 23:33:43 +0000 (23:33 +0000)]
* NEWS, src/newgrp.c: Fix segfault when an user returns to an
  unknown GID (either the user was deleted during the user's newgrp
  session or the user's passwd entry referenced an invalid group).
  Add a syslog warning in that case.
* src/newgrp.c: Add an end of line when reporting an invalid
  password.

16 years ago* NEWS, src/useradd.c: Fix the handling of the --defaults option
nekral-guest [Sat, 12 Jan 2008 21:09:46 +0000 (21:09 +0000)]
* NEWS, src/useradd.c: Fix the handling of the --defaults option
  (it required an argument, but should behave as -D)
* NEWS, man/useradd.8.xml: Document the --defaults option, which
  was already described in the useradd's Usage information.

16 years agoAvoid setting the password to a const empty string, but set the first char to \0...
nekral-guest [Sun, 6 Jan 2008 19:26:58 +0000 (19:26 +0000)]
Avoid setting the password to a const empty string, but set the first char to \0. This avoids a warning.

16 years ago* libmisc/salt.c: Add prototype for l64a(), gensalt(),
nekral-guest [Sun, 6 Jan 2008 14:50:26 +0000 (14:50 +0000)]
* libmisc/salt.c: Add prototype for l64a(), gensalt(),
  SHA_salt_size(), and SHA_salt_rounds().
* libmisc/salt.c: l64a() and gensalt() are static.
* libmisc/salt.c: The `meth' parameter of crypt_make_salt() is a
  const. (ditto for the method variable).
* libmisc/salt.c: SHA_salt_rounds returns a const string.
* libmisc/salt.c: Avoid warnings with cast of random() to double.
* libmisc/salt.c: Replace rand() by random().

16 years ago* lib/Makefile.am: Do not link libshadow.la with the intl, crypt,
nekral-guest [Sun, 6 Jan 2008 14:19:32 +0000 (14:19 +0000)]
* lib/Makefile.am: Do not link libshadow.la with the intl, crypt,
  skey and md libraries...
* src/Makefile.am: ...Specify for each binary which library is
  required. skey and md are required for the binaries with
  authentication of the user (chfn, chsh, login, passwd, su). intl
  is required for all. mcrypt is required for user (chfn, chsh,
  login, passwd, su, sulogin) and group (newgrp, gpasswd)
  authentication and for the creation of passwords (chpasswd,
  chgpasswd, gpasswd, newusers, passwd).

16 years ago* lib/nscd.c, lib/nscd.h: Set the service parameter of
nekral-guest [Sun, 6 Jan 2008 13:57:17 +0000 (13:57 +0000)]
* lib/nscd.c, lib/nscd.h: Set the service parameter of
  nscd_flush_cache() to const. This avoids a lot of warnings.
* lib/nscd.c: Include "nscd.h" to avoid inconsistent prototypes.

16 years agoRemove prototypes for __gr_dup() and __gr_set_changed().
nekral-guest [Sun, 6 Jan 2008 13:52:21 +0000 (13:52 +0000)]
Remove prototypes for __gr_dup() and __gr_set_changed().

16 years agoSet the method string as a constant string.
nekral-guest [Sun, 6 Jan 2008 13:49:00 +0000 (13:49 +0000)]
Set the method string as a constant string.

16 years agoAssume <errno.h> declares errno.
nekral-guest [Sun, 6 Jan 2008 13:42:47 +0000 (13:42 +0000)]
Assume <errno.h> declares errno.

16 years ago* Remove prototype for sgetgrent().
nekral-guest [Sun, 6 Jan 2008 13:38:16 +0000 (13:38 +0000)]
* Remove prototype for sgetgrent().
* Add the name of the parameters for merge_group_entries() and split_groups().

16 years agoFix typo: s/rend compte indiqué/rend le compte indiqué/
nekral-guest [Sun, 6 Jan 2008 13:32:25 +0000 (13:32 +0000)]
Fix typo: s/rend compte indiqué/rend le compte indiqué/

16 years ago* Remove prototype of check_su_auth(). It is redundant with prototypes.h.
nekral-guest [Sun, 6 Jan 2008 13:30:18 +0000 (13:30 +0000)]
* Remove prototype of check_su_auth(). It is redundant with prototypes.h.
* isgrp() is static.

16 years ago* libmisc/obscure.c: Tag the `old' parameter of palindrome(),
nekral-guest [Sun, 6 Jan 2008 13:20:25 +0000 (13:20 +0000)]
* libmisc/obscure.c: Tag the `old' parameter of palindrome(),
  similar(), and simple() as unused.
* libmisc/loginprompt.c: Tag the `sig' parameter of login_exit()
  as unused.
* src/expiry.c: Tag the `sig' parameter of catch_signals() as
  unused.
* src/su.c: Tag the `sig' parameter of catch_signals() as unused.
* src/su.c: Add int parameter to the prototype of oldsig().
* src/login.c: Tag the `sig' parameter of alarm_handler() as
  unused.
* src/sulogin.c: Tag the `sig' parameter of catch_signals() as
  unused.
* libmisc/getdate.y: Tag the `string' parameter of yyerror() as
  unused.
* libmisc/getdate.y: The string provided to yyerror() is const.
* libmisc/getdate.y: Fix the prototypes of yylex() and yyerror().

16 years ago* Remove teh macro definition of SETXXENT_TYPE,
nekral-guest [Sun, 6 Jan 2008 13:12:09 +0000 (13:12 +0000)]
* Remove teh macro definition of SETXXENT_TYPE,
  SETXXENT_RET, and SETXXENT_TEST. They were used by the now
  removed pwent.c and grent.c.
* Remove the definition of PASSWD_PAG_FILE,
  GROUP_PAG_FILE, SHADOW_PAG_FILE, and SGROUP_PAG_FILE. They are
  never used.
* Don't include "snprintf.h". The file does not
  exist in shadow.
* Add new macro unused to tag unused parameters.

16 years agoRemove prototypes for __pw_del_entry(), __pw_get_head(), __spw_del_entry(), and __spw...
nekral-guest [Sun, 6 Jan 2008 13:00:17 +0000 (13:00 +0000)]
Remove prototypes for __pw_del_entry(), __pw_get_head(), __spw_del_entry(), and __spw_get_head().

16 years agoAssume optarg and optind are declared in <getopt.h>.
nekral-guest [Sun, 6 Jan 2008 12:52:23 +0000 (12:52 +0000)]
Assume optarg and optind are declared in <getopt.h>.

16 years agoRemove the pw_name argument of new_pw_passwd. Use the user_newname global
nekral-guest [Sun, 6 Jan 2008 12:50:22 +0000 (12:50 +0000)]
Remove the pw_name argument of new_pw_passwd. Use the user_newname global
variable instead. This avoid using a parameter with the same name as a function.

16 years ago* Removed unused gid parameter of syslog_sg().
nekral-guest [Sun, 6 Jan 2008 12:31:06 +0000 (12:31 +0000)]
* Removed unused gid parameter of syslog_sg().
* The loginname and tty buffers are never changed. Add the const qualifier.

16 years agoThe crypt_method string always points to a constant string. Add the const qualifier.
nekral-guest [Sun, 6 Jan 2008 12:26:20 +0000 (12:26 +0000)]
The crypt_method string always points to a constant string. Add the const qualifier.

16 years agoRemove prototype of l64a() (not used in pwunconv).
nekral-guest [Sun, 6 Jan 2008 12:12:30 +0000 (12:12 +0000)]
Remove prototype of l64a() (not used in pwunconv).

16 years agoRemove prototypes for __gr_del_entry(), __gr_get_head(),
nekral-guest [Sun, 6 Jan 2008 12:09:38 +0000 (12:09 +0000)]
Remove prototypes for __gr_del_entry(), __gr_get_head(),
__sgr_del_entry(), and __sgr_get_head().

16 years ago* src/login_nopam.c: Use an ANSI prototype for resolve_hostname()
nekral-guest [Sun, 6 Jan 2008 12:07:42 +0000 (12:07 +0000)]
* src/login_nopam.c: Use an ANSI prototype for resolve_hostname()
  instead of K&R prototype.
* src/login_nopam.c: Fix the prototypes of list_match(),
  user_match(), from_match(), string_match(). There were no
  parameters in the prototypes.
* src/login_nopam.c: Fix the prototypes of the function parameter
  match_fn of list_match().

16 years agoRemove the src parameter of copy_special().
nekral-guest [Sun, 6 Jan 2008 12:02:24 +0000 (12:02 +0000)]
Remove the src parameter of copy_special().
The entry's information are taken from the stat structure.

16 years ago* libmisc/console.c, libmisc/ulimit.c, lib/sgetgrent.c,
nekral-guest [Sun, 6 Jan 2008 11:59:01 +0000 (11:59 +0000)]
* libmisc/console.c, libmisc/ulimit.c, lib/sgetgrent.c,
  lib/sgetpwent.c: Include "prototypes.h" to make
  sure the exported prototypes are the ones used for the definition
  of functions.
* lib/prototypes.h: Added prototypes for __gr_del_entry(),
  __gr_get_db(), __gr_get_head(), __gr_set_changed(), __gr_dup(),
  __pw_del_entry(), __pw_get_db(), __pw_get_head(), __pw_dup(),
  sgetgrent(), sgetpwent(), __sgr_del_entry(), __sgr_dup(),
  __sgr_get_head(), __sgr_set_changed(), __spw_get_head(),
  __spw_del_entry(), __spw_dup().
* lib/prototypes.h: Removed prototype for is_listed().
* lib/prototypes.h: Added name of the check_su_auth()'s parameters.
* lib/groupio.h: Removed prototypes for __gr_dup() and
  __gr_set_changed().
* lib/sgroupio.c: Removed prototypes for putsgent(), sgetsgent(),
  and __gr_get_db().
* lib/sgroupio.h: Removed prototypes for __sgr_dup() and
  __sgr_set_changed().
* lib/shadowio.c: Removed prototype for __pw_get_db().
* lib/pwio.c: Removed prototype for sgetpwent() and putpwent().
* lib/shadowio.h: Removed prototypes for __spw_dup() and
  __spw_set_changed().
* lib/pwio.h: Removed prototypes for __pw_dup() and
  __pw_set_changed().
* lib/commonio.h: Add protection against multiple inclusions.
* lib/prototypes.h: Include commonio.h (needed for the
  __xx_del_entry() functions).

16 years agoAdd documentation for the new --password options.
nekral-guest [Sat, 5 Jan 2008 17:25:00 +0000 (17:25 +0000)]
Add documentation for the new --password options.

16 years agoFix find_new_gid() prototype. Add a void parameter.
nekral-guest [Sat, 5 Jan 2008 17:23:46 +0000 (17:23 +0000)]
Fix find_new_gid() prototype. Add a void parameter.

16 years agoRemove old comments in the header.
nekral-guest [Sat, 5 Jan 2008 17:22:38 +0000 (17:22 +0000)]
Remove old comments in the header.

16 years agoInclude <lastlog.h> for the declaration of struct lastlog.
nekral-guest [Sat, 5 Jan 2008 17:20:45 +0000 (17:20 +0000)]
Include <lastlog.h> for the declaration of struct lastlog.

16 years agoFix typos.
nekral-guest [Sat, 5 Jan 2008 16:44:51 +0000 (16:44 +0000)]
Fix typos.

16 years ago* lib/prototypes.h: Add the dolastlog() prototype.
nekral-guest [Sat, 5 Jan 2008 16:44:28 +0000 (16:44 +0000)]
* lib/prototypes.h: Add the dolastlog() prototype.
* lib/prototypes.h: Typo: login.c -> loginprompt.c
* src/login.c: Remove declaration of dolastlog().
* libmisc/log.c: dolastlog() should not have been changed to static.
  Include prototypes.h instead.

16 years ago* libmisc/pwdcheck.c: Do not include <pwd.h>. Include <shadow.h>
nekral-guest [Sat, 5 Jan 2008 16:33:43 +0000 (16:33 +0000)]
* libmisc/pwdcheck.c: Do not include <pwd.h>. Include <shadow.h>
  and "pwauth.h" only when compiled without PAM support.
* src/chfn.c, src/chsh.c: Do not include <shadow.h>
* lib/commonio.c: Do not include <shadow.h>. Do not include
  <pwd.h>. Include "nscd.h" instead of <nscd.h>.
* configure.in: Do not check if shadow.h exist, but make sure it
  exists.
* libmisc/pwdcheck.c, src/chfn.c, src/chsh.c, lib/defines.h,
  lib/shadowmem.c, lib/shadowio.c, lib/commonio.c:
  HAVE_SHADOW_H is no more needed (shadow.h should always exist).

16 years agoFix the do_pam_passwd() prototype (it returns void).
nekral-guest [Sat, 5 Jan 2008 15:43:33 +0000 (15:43 +0000)]
Fix the do_pam_passwd() prototype (it returns void).

16 years agodo_pam_passwd should not have been defined static, prototypes.h needed
nekral-guest [Sat, 5 Jan 2008 15:41:58 +0000 (15:41 +0000)]
do_pam_passwd should not have been defined static, prototypes.h needed
to be included instead.

16 years agoRemove prototype of putgrent(), add parameter's name of sgetgrent().
nekral-guest [Sat, 5 Jan 2008 14:35:13 +0000 (14:35 +0000)]
Remove prototype of putgrent(), add parameter's name of sgetgrent().

16 years agoAdd option --password to groupadd and groupmod (similar to useradd and usermod).
nekral-guest [Sat, 5 Jan 2008 14:17:43 +0000 (14:17 +0000)]
Add option --password to groupadd and groupmod (similar to useradd and usermod).

16 years agoRemove the declaration of getutent(), getutline(), setutent(), and
nekral-guest [Sat, 5 Jan 2008 14:09:56 +0000 (14:09 +0000)]
Remove the declaration of getutent(), getutline(), setutent(), and
endutent() which are declared in <utmp.h>

16 years agostat shadows another stat variable. Remove this
nekral-guest [Sat, 5 Jan 2008 14:01:34 +0000 (14:01 +0000)]
stat shadows another stat variable. Remove this
variable, and directly check the result of getfscreatecon().

16 years agoChangelog entry forgotten in previous src/gshadow.c commit:
nekral-guest [Sat, 5 Jan 2008 13:58:56 +0000 (13:58 +0000)]
Changelog entry forgotten in previous src/gshadow.c commit:
 * list() is an external function. DO not shadow it
   with a static function. The internal list() was renamed
   build_list().

16 years agoThe prototypes of fgetsx() and fputsx() are already defined in
nekral-guest [Sat, 5 Jan 2008 13:56:21 +0000 (13:56 +0000)]
The prototypes of fgetsx() and fputsx() are already defined in
prototypes.h. Remove the declaration of these functions.

16 years agologinsh is a global variable, use newshell for the update_shell()'s parameter.
nekral-guest [Sat, 5 Jan 2008 13:54:39 +0000 (13:54 +0000)]
loginsh is a global variable, use newshell for the update_shell()'s parameter.

16 years agologin_prompt is the name of a function, use loginprompt for the internal variable.
nekral-guest [Sat, 5 Jan 2008 13:53:14 +0000 (13:53 +0000)]
login_prompt is the name of a function, use loginprompt for the internal variable.

16 years agoMake a proper prototype for the main() function declaration. (add void)
nekral-guest [Sat, 5 Jan 2008 13:51:43 +0000 (13:51 +0000)]
Make a proper prototype for the main() function declaration. (add void)

16 years agoAdd changelog entry for previous commit.
nekral-guest [Sat, 5 Jan 2008 13:49:32 +0000 (13:49 +0000)]
Add changelog entry for previous commit.

16 years agoAdd missing include "shadowio.h". (This was OK as long as prototypes.h included this...
nekral-guest [Sat, 5 Jan 2008 13:40:49 +0000 (13:40 +0000)]
Add missing include "shadowio.h". (This was OK as long as prototypes.h included this file.)

16 years ago* libmisc/pam_pass.c: Define do_pam_passwd() as static and add its prototype.
nekral-guest [Sat, 5 Jan 2008 13:37:32 +0000 (13:37 +0000)]
* libmisc/pam_pass.c: Define do_pam_passwd() as static and add its prototype.
* libmisc/log.c: Define dolastlog() as static and add its prototype.
* src/chage.c: Define isnum() as static and add its prototype.

16 years agoInclude config.h as a system include, as recommended by the autoconf documentation.
nekral-guest [Sat, 5 Jan 2008 13:32:32 +0000 (13:32 +0000)]
Include config.h as a system include, as recommended by the autoconf documentation.

16 years agoDefine is_listed() as static and add its prototype.
nekral-guest [Sat, 5 Jan 2008 13:29:24 +0000 (13:29 +0000)]
Define is_listed() as static and add its prototype.

16 years agoInclude "prototypes.h" to make sure the exported prototypes are
nekral-guest [Sat, 5 Jan 2008 13:23:22 +0000 (13:23 +0000)]
Include "prototypes.h" to make sure the exported prototypes are
the ones used for the definition of functions.

16 years ago"shadowio.h" was included for the definition of the spwd structure.
nekral-guest [Sat, 5 Jan 2008 13:07:54 +0000 (13:07 +0000)]
"shadowio.h" was included for the definition of the spwd structure.
Replace this include by <shadow.h>

16 years agogrent.c does not exist anymore. Remove the putgrent prototype.
nekral-guest [Sat, 5 Jan 2008 13:05:21 +0000 (13:05 +0000)]
grent.c does not exist anymore. Remove the putgrent prototype.

16 years agoAdd the syslog_sg prototype.
nekral-guest [Tue, 1 Jan 2008 23:56:03 +0000 (23:56 +0000)]
Add the syslog_sg prototype.

16 years agoAlso split syslog_sg() out of main().
nekral-guest [Tue, 1 Jan 2008 23:54:51 +0000 (23:54 +0000)]
Also split syslog_sg() out of main().

16 years agoRemove duplicate logging to syslog.
nekral-guest [Tue, 1 Jan 2008 23:45:44 +0000 (23:45 +0000)]
Remove duplicate logging to syslog.

16 years agoSplit check_perms() out of main().
nekral-guest [Tue, 1 Jan 2008 23:35:55 +0000 (23:35 +0000)]
Split check_perms() out of main().

16 years agoAvoid assignments in conditionals.
nekral-guest [Tue, 1 Jan 2008 23:07:55 +0000 (23:07 +0000)]
Avoid assignments in conditionals.

16 years agoAvoid assignments in conditionals.
nekral-guest [Tue, 1 Jan 2008 22:21:55 +0000 (22:21 +0000)]
Avoid assignments in conditionals.

16 years ago(split_groups): Test the pointer returned by malloc.
nekral-guest [Tue, 1 Jan 2008 20:47:31 +0000 (20:47 +0000)]
(split_groups): Test the pointer returned by malloc.

16 years agoDocument add_one_entry_nis(), write_all(), commonio_remove(),
nekral-guest [Tue, 1 Jan 2008 20:34:47 +0000 (20:34 +0000)]
Document add_one_entry_nis(), write_all(), commonio_remove(),
commonio_locate(), and commonio_rewind().

16 years agoFix typo s/groupadd/chpasswd/
nekral-guest [Tue, 1 Jan 2008 19:56:29 +0000 (19:56 +0000)]
Fix typo s/groupadd/chpasswd/

16 years agoNew TODO item:
nekral-guest [Tue, 1 Jan 2008 19:54:37 +0000 (19:54 +0000)]
New TODO item:
 - newusers: add logging to SYSLOG & AUDIT