]> granicus.if.org Git - clang/log
clang
10 years ago[clang/asan] call __asan_poison_cxx_array_cookie after operator new[]
Kostya Serebryany [Tue, 26 Aug 2014 02:29:59 +0000 (02:29 +0000)]
[clang/asan] call __asan_poison_cxx_array_cookie after operator new[]

Summary:
PR19838
When operator new[] is called and an array cookie is created
we want asan to detect buffer overflow bugs that touch the cookie.
For that we need to
  a) poison the shadow for the array cookie (call __asan_poison_cxx_array_cookie).
  b) ignore the legal accesses to the cookie generated by clang (add 'nosanitize' metadata)

Reviewers: timurrrr, samsonov, rsmith

Reviewed By: rsmith

Subscribers: cfe-commits

Differential Revision: http://reviews.llvm.org/D4774

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216434 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix typo.
Richard Smith [Mon, 25 Aug 2014 23:33:46 +0000 (23:33 +0000)]
Fix typo.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216417 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoPass actual CXXConstructExpr instead of argument iterators
Alexey Samsonov [Mon, 25 Aug 2014 21:58:56 +0000 (21:58 +0000)]
Pass actual CXXConstructExpr instead of argument iterators
into EmitSynthesizedCXXCopyCtorCall. No functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216410 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoObjective-C. Allow [super initialize] in an +initialize
Fariborz Jahanian [Mon, 25 Aug 2014 21:27:38 +0000 (21:27 +0000)]
Objective-C. Allow [super initialize] in an +initialize
implementation but not anywhere else.
rdar://16628028

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216408 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoObjective-C modernization. Convert -initWithUTF8String messaging
Fariborz Jahanian [Mon, 25 Aug 2014 20:22:25 +0000 (20:22 +0000)]
Objective-C modernization. Convert -initWithUTF8String messaging
with auto-boxing syntax for literals. rdar://18080352

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216405 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoPass actual CallExpr instead of CallExpr-specific iterators
Alexey Samsonov [Mon, 25 Aug 2014 20:17:35 +0000 (20:17 +0000)]
Pass actual CallExpr instead of CallExpr-specific iterators
into EmitCXXMemberOrOperatorCall methods. In the end we want
to make declaration visible in EmitCallArgs() method, that
would allow us to alter CodeGen depending on function/parameter
attributes.

No functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216404 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUpdate for llvm api change.
Rafael Espindola [Mon, 25 Aug 2014 18:17:04 +0000 (18:17 +0000)]
Update for llvm api change.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216397 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoASTVector: Fix return value of various insert() methods.
Will Dietz [Mon, 25 Aug 2014 16:09:51 +0000 (16:09 +0000)]
ASTVector: Fix return value of various insert() methods.

Error caught using -fsanitize=pointer-overflow.

Expand ASTVectorTest to verify basic behavior,
test fails without functionality in this patch.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216385 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFollow-up to r216380: update test expectations
Timur Iskhodzhanov [Mon, 25 Aug 2014 12:19:12 +0000 (12:19 +0000)]
Follow-up to r216380: update test expectations

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216381 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[ASan] Rename the ASan dynamic RT
Timur Iskhodzhanov [Mon, 25 Aug 2014 11:44:06 +0000 (11:44 +0000)]
[ASan] Rename the ASan dynamic RT

Reviewed at http://reviews.llvm.org/D5026

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216380 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAdd hasAttr matcher for declarations.
Manuel Klimek [Mon, 25 Aug 2014 11:23:50 +0000 (11:23 +0000)]
Add hasAttr matcher for declarations.

Delete special-case CUDA attribute matchers.

Patch by Jacques Pienaar.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216379 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoclang-format: Understand sequenced casts.
Daniel Jasper [Mon, 25 Aug 2014 09:36:07 +0000 (09:36 +0000)]
clang-format: Understand sequenced casts.

This fixed llvm.org/PR20712.

Before:
  int i = (int)(int) -2;

After:
  int i = (int)(int)-2;

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216378 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoclang-format: Improve formatting of nested builder-type calls.
Daniel Jasper [Mon, 25 Aug 2014 08:48:17 +0000 (08:48 +0000)]
clang-format: Improve formatting of nested builder-type calls.

Before:
  f(FirstToken->WhitespaceRange.getBegin().getLocWithOffset(
      First->LastNewlineOffset));

After:
  f(FirstToken->WhitespaceRange.getBegin()
        .getLocWithOffset(First->LastNewlineOffset));

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216377 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUse range based for loops to avoid needing to re-mention SmallPtrSet size.
Craig Topper [Mon, 25 Aug 2014 04:15:02 +0000 (04:15 +0000)]
Use range based for loops to avoid needing to re-mention SmallPtrSet size.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216370 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[modules] Fix false report of an ODR violation when merging friend
Richard Smith [Mon, 25 Aug 2014 02:10:01 +0000 (02:10 +0000)]
[modules] Fix false report of an ODR violation when merging friend
declarations. We can't expect to find them in the canonical definition
of the class, because that's not where they live.

This means we no longer reject real ODR violations with friend declarations,
but we weren't consistently doing so anyway.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216369 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoPR20716 - Crash when recovering from type in known dependent base.
Nikola Smiljanic [Sun, 24 Aug 2014 23:28:47 +0000 (23:28 +0000)]
PR20716 - Crash when recovering from type in known dependent base.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216352 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFrontend: unique_ptr-ify
Dylan Noblesmith [Sun, 24 Aug 2014 18:59:52 +0000 (18:59 +0000)]
Frontend: unique_ptr-ify

NFC.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216347 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoMove __vector long deprecation checking into DeclSpec::Finish
Hal Finkel [Sun, 24 Aug 2014 04:50:19 +0000 (04:50 +0000)]
Move __vector long deprecation checking into DeclSpec::Finish

__vector long is deprecated, but __vector long long is not. As a result, we
cannot check for __vector long (to issue the deprecation warning) as we parse
the type because we need to know how many 'long's we have first.
DeclSpec::Finish seems like a more-appropriate place to perform the check
(which places it with several other similar Altivec vector checks).

Fixes PR20720.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216342 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoImplement __builtin_signbitl for PowerPC
Hal Finkel [Sun, 24 Aug 2014 03:47:06 +0000 (03:47 +0000)]
Implement __builtin_signbitl for PowerPC

PowerPC uses the special PPC_FP128 type for long double on Linux, which is
composed of two 64-bit doubles. The higher-order double (which contains the
overall sign) comes first, and so the __builtin_signbitl implementation
requires special handling to extract the sign bit.

Fixes PR20691.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216341 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDon't assert on different DLL attributes in template and explicit instantiation ...
Hans Wennborg [Sun, 24 Aug 2014 00:12:36 +0000 (00:12 +0000)]
Don't assert on different DLL attributes in template and explicit instantiation (PR20137)

We would previously assert (a decl cannot have two DLL attributes) on this code:

  template <typename T> struct __declspec(dllimport) S { T f() { return T(); } };
  template struct __declspec(dllexport) S<int>;

The problem was that when instantiating, we would take the attribute from the
template even if the instantiation itself already had an attribute.

Also, don't inherit DLL attributes from the template to its members before
instantiation, as the attribute may change.

I couldn't figure out what MinGW does here, so I'm leaving that open. At least
we're not asserting anymore.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216340 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAdd another test for DLL attribute inheritance to partial specializations
Hans Wennborg [Sat, 23 Aug 2014 23:00:29 +0000 (23:00 +0000)]
Add another test for DLL attribute inheritance to partial specializations

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216337 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix CodeGenCXX/dllexport.cpp test. Somehow this slipped out of my previous commit.
Hans Wennborg [Sat, 23 Aug 2014 22:46:24 +0000 (22:46 +0000)]
Fix CodeGenCXX/dllexport.cpp test. Somehow this slipped out of my previous commit.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216334 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoMS ABI: Inherit DLL attributes to partial class template specializations
Hans Wennborg [Sat, 23 Aug 2014 22:34:43 +0000 (22:34 +0000)]
MS ABI: Inherit DLL attributes to partial class template specializations

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216333 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agocheckDLLAttribute: remove a redundant dyn_cast
Hans Wennborg [Sat, 23 Aug 2014 21:10:39 +0000 (21:10 +0000)]
checkDLLAttribute: remove a redundant dyn_cast

The same dyn_cast was done earlier in the function. No functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216326 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoCodeGen: Skip unnamed bitfields when handling designated initializers
David Majnemer [Sat, 23 Aug 2014 01:48:50 +0000 (01:48 +0000)]
CodeGen: Skip unnamed bitfields when handling designated initializers

We would accidently initialize unnamed bitfields instead of the
following field.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216313 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[modules] When merging a tag declaration that has a typedef name for linkage
Richard Smith [Sat, 23 Aug 2014 01:45:27 +0000 (01:45 +0000)]
[modules] When merging a tag declaration that has a typedef name for linkage
purposes, look for other typedefs with that same name and merge into their
named tag declaration if there is one.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216312 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[modules] Put class template declarations into the scope in which they're
Richard Smith [Sat, 23 Aug 2014 00:49:01 +0000 (00:49 +0000)]
[modules] Put class template declarations into the scope in which they're
declared, rather than putting them into the template parameter scope. We
previously had *no record* in the scope for class template declarations, once
those declarations completed and their template parameter scopes were popped.
This in turn caused us to be unable to merge class template declarations that
were declared in the global scope (where we use scope lookup rather than
DeclContext lookup for merging), when loading a module.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216311 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix a bad location in -Wparentheses fix-it hint
Richard Trieu [Sat, 23 Aug 2014 00:30:57 +0000 (00:30 +0000)]
Fix a bad location in -Wparentheses fix-it hint

The code used getLocStart() instead of getLocEnd().  This works for single
token expressions, but breaks if the expression is longer.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216306 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoObjective-C. Warn when @encode'ing provides an incomplete
Fariborz Jahanian [Fri, 22 Aug 2014 23:17:52 +0000 (23:17 +0000)]
Objective-C. Warn when @encode'ing provides an incomplete
type encoding because in certain cases, such as for vector
types, because we still haven't designed encoding for them.
rdar://9255564

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216301 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: Test that the loop backedge in a range-for is attribute to the loop header.
David Blaikie [Fri, 22 Aug 2014 22:29:50 +0000 (22:29 +0000)]
DebugInfo: Test that the loop backedge in a range-for is attribute to the loop header.

This already works, but somewhat by accident (due to the order of
emission in clang, the location is set to the loop header (during the
emission of the iteratior increment) before the loop backedge is
emitted), so let's just add a test for symmetry and future-proofing.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216298 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: for loop backedge should be attributed to the start of the for statement.
David Blaikie [Fri, 22 Aug 2014 22:25:37 +0000 (22:25 +0000)]
DebugInfo: for loop backedge should be attributed to the start of the for statement.

Similar to r215768 (which fixed the same case for while loops). To quote
r215768's commit message:

"A little test case simplification - this could be simplified further,
though there are certainly interesting connections to the if/else
construct so I'm hesitant to remove that entirely though it does appear
somewhat unrelated.

(similar fix to r215766, related to PR19864)"

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216297 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoClear the clang release notes to make room for 3.6.
Rafael Espindola [Fri, 22 Aug 2014 21:59:11 +0000 (21:59 +0000)]
Clear the clang release notes to make room for 3.6.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216293 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: Provide scopes for C++11 range-for loop variables similar to r216288 ...
David Blaikie [Fri, 22 Aug 2014 21:54:29 +0000 (21:54 +0000)]
DebugInfo: Provide scopes for C++11 range-for loop variables similar to r216288 (which was for plain-for loop condition variables).

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216291 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: Scope for condition variables more narrowly than the loop variable.
David Blaikie [Fri, 22 Aug 2014 21:37:04 +0000 (21:37 +0000)]
DebugInfo: Scope for condition variables more narrowly than the loop variable.

for loops introduce two scopes - one for the outer loop variable and its
initialization, and another for the body of the loop, including any
variable declared inside the loop condition.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216288 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoIgnore -Wunsupported-dll-base-class-template by default
Hans Wennborg [Fri, 22 Aug 2014 20:33:18 +0000 (20:33 +0000)]
Ignore -Wunsupported-dll-base-class-template by default

The situation it is warning about (see PR20725) is not very likely
to be a real problem, and it is unclear what action the user should take
if the warning does fire.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216283 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoObjective-C. Update my previous patch to not warn if
Fariborz Jahanian [Fri, 22 Aug 2014 19:52:49 +0000 (19:52 +0000)]
Objective-C. Update my previous patch to not warn if
+initialize is called on 'super' in its implementation.
rdar://16628028

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216282 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix PR17239 by changing the semantics of the RemainingArgsClass Option kind
Reid Kleckner [Fri, 22 Aug 2014 19:29:30 +0000 (19:29 +0000)]
Fix PR17239 by changing the semantics of the RemainingArgsClass Option kind

This patch aims at fixing PR17239.

This bug happens because the /link (clang-cl.exe argument) is marked as
"consume all remaining arguments". However, when inside a response file,
/link should only consume all remaining arguments inside the response
file where it is located, not the entire command line after expansion.
The LLVM side of the patch will change the semantics of the
RemainingArgsClass kind to always consume only until the end of the
response file when the option originally came from a response file.
There are only two options in this class: dash dash (--) and /link.

This is the Clang side of the patch in http://reviews.llvm.org/D4899

Reviewered By: rafael, rnk

Differential Revision: http://reviews.llvm.org/D4900

Patch by Rafael Auler!

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216281 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[test/CodeGen/ARM] Adpat test to match new codegen after r216274.
Quentin Colombet [Fri, 22 Aug 2014 18:08:37 +0000 (18:08 +0000)]
[test/CodeGen/ARM] Adpat test to match new codegen after r216274.
Moreover, rework some patterns to actually check the emitted instructions
instead of matching unrelated string!

E.g.,
some of the "// CHECK: vmov" were matching stuff like ".globl
funcname_with_vmov" instead of actual instructions.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216275 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[analyzer] Remove check covered by -Wobjc-missing-super-calls.
Jordan Rose [Fri, 22 Aug 2014 16:57:33 +0000 (16:57 +0000)]
[analyzer] Remove check covered by -Wobjc-missing-super-calls.

The ObjCDealloc checker is currently disabled because it was too aggressive, but this
is a good first step in getting it back to a useful state.

Patch by David Kilzer!

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216272 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoObjective-C. Warn if user has made explicit call
Fariborz Jahanian [Fri, 22 Aug 2014 16:57:26 +0000 (16:57 +0000)]
Objective-C. Warn if user has made explicit call
to +initilize as this results in an extra call
to this method. rdar://16628028

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216271 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago-fms-extensions: Alias _intNN to __intNN
Reid Kleckner [Fri, 22 Aug 2014 16:52:57 +0000 (16:52 +0000)]
-fms-extensions: Alias _intNN to __intNN

Fixes build for SPEC 2000 CPU. MSVC disables these aliases under /Za,
which enables stricter standards compliance. We don't currently have any
way to disable them.

Patch by Kevin Smith!

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216270 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFixing MSVC warning: "warning C4373: 'blah': virtual function overrides 'blah', previ...
Aaron Ballman [Fri, 22 Aug 2014 13:26:37 +0000 (13:26 +0000)]
Fixing MSVC warning: "warning C4373: 'blah': virtual function overrides 'blah', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers."

This warning is basically useless because the "previous versions" being referred to is MSVC 2005 and earlier, and we obviously do not care about them. However, this warning isn't particularly chatty (I don't recall ever seeing it previously), and it has the opportunity to point out cases where the cv-qualifiers differ unintentionally (like this case), so I am leaving it enabled for now.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216267 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[AArch64, inline-asm] Improve diagnostic that is printed when the size of a
Akira Hatanaka [Fri, 22 Aug 2014 06:05:21 +0000 (06:05 +0000)]
[AArch64, inline-asm] Improve diagnostic that is printed when the size of a
variable that has regiser constraint "r" is not 64-bit.

General register operands are output using 64-bit "x" register names, regardless
of the size of the variable, unless the asm operand is prefixed with the "%w"
modifier. This surprises and confuses many users who aren't familiar with
aarch64 inline assembly rules.

With this commit, a note and fixit hint are printed which tell the users that
they need modifier "%w" in order to output a "w" register instead of an "x"
register.

<rdar://problem/12764785>

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216260 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoMS ABI: Don't use the Itanium scheme for numbering lambdas
David Majnemer [Fri, 22 Aug 2014 04:22:50 +0000 (04:22 +0000)]
MS ABI: Don't use the Itanium scheme for numbering lambdas

The Itanium ABI will give out the same mangling number for two different
lambdas if their call operators have different types.  The MS ABI cannot
do the same because it does not mangle the return type into it's
lambdas.

This fixes PR20719.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216259 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix PR20705, crash on invalid.
Richard Trieu [Fri, 22 Aug 2014 01:16:44 +0000 (01:16 +0000)]
Fix PR20705, crash on invalid.

dyn_cast -> dyn_cast_or_null to handle a null pointer.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216254 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoCGCall: Factor out the logic mapping call arguments to LLVM IR arguments.
Alexey Samsonov [Fri, 22 Aug 2014 01:06:06 +0000 (01:06 +0000)]
CGCall: Factor out the logic mapping call arguments to LLVM IR arguments.

Summary:
This refactoring introduces ClangToLLVMArgMapping class, which
encapsulates the information about the order in which function arguments listed
in CGFunctionInfo should be passed to actual LLVM IR function, such as:
1) positions of sret, if there is any
2) position of inalloca argument, if there is any
3) position of helper padding argument for each call argument
4) positions of regular argument (there can be many if it's expanded).
Simplify several related methods (ConstructAttributeList, EmitFunctionProlog
and EmitCall): now they don't have to maintain iterators over the list
of LLVM IR function arguments, dealing with all the sret/inalloca/this complexities,
and just use expected positions of LLVM IR arguments stored in ClangToLLVMArgMapping.

This may increase the running time of EmitFunctionProlog, as we have to traverse
expandable arguments twice, but in further refactoring we will be able
to speed up EmitCall by passing already calculated CallArgsToIRArgsMapping to
ConstructAttributeList, thus avoiding traversing expandable argument there.

No functionality change.

Test Plan: regression test suite

Reviewers: majnemer, rnk

Reviewed By: rnk

Subscribers: cfe-commits, rjmccall, timurrrr

Differential Revision: http://reviews.llvm.org/D4938

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216251 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[test/CodeGen/ARM] Adpat test to match new codegen after r216236.
Quentin Colombet [Fri, 22 Aug 2014 00:27:52 +0000 (00:27 +0000)]
[test/CodeGen/ARM] Adpat test to match new codegen after r216236.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216249 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUpdate for LLVM API change to remove discriminator tracking from DILexicalBlock ...
David Blaikie [Thu, 21 Aug 2014 22:46:45 +0000 (22:46 +0000)]
Update for LLVM API change to remove discriminator tracking from DILexicalBlock (in favor of DILexicalBlockFile - where a default arg is used to avoid the need for API churn of those callers)

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216240 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUpdate Clang for LLVM API change to use unique_ptr in SourceManager::AddNewSourceBuffer
David Blaikie [Thu, 21 Aug 2014 21:01:00 +0000 (21:01 +0000)]
Update Clang for LLVM API change to use unique_ptr in SourceManager::AddNewSourceBuffer

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216226 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoReturn statements are initialization; don't forget to revert the initializer to
Richard Smith [Thu, 21 Aug 2014 20:51:13 +0000 (20:51 +0000)]
Return statements are initialization; don't forget to revert the initializer to
its syntactic form before re-analyzing it during template instantiation.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216224 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoSimplify this logic now that -W can't be applied to remarks. No functionality change.
Richard Smith [Thu, 21 Aug 2014 20:44:44 +0000 (20:44 +0000)]
Simplify this logic now that -W can't be applied to remarks. No functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216222 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix grammatical error in diagnostic.
Richard Smith [Thu, 21 Aug 2014 20:43:52 +0000 (20:43 +0000)]
Fix grammatical error in diagnostic.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216221 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoPass expressions instead of argument ranges to EmitCall/EmitCXXConstructorCall.
Alexey Samsonov [Thu, 21 Aug 2014 20:26:47 +0000 (20:26 +0000)]
Pass expressions instead of argument ranges to EmitCall/EmitCXXConstructorCall.

Summary:
This is a first small step towards passing generic "Expr" instead of
ArgBeg/ArgEnd pair into EmitCallArgs() family of methods. Having "Expr" will
allow us to get the corresponding FunctionDecl and its ParmVarDecls,
thus allowing us to alter CodeGen depending on the function/parameter
attributes.

No functionality change.

Test Plan: regression test suite

Reviewers: rnk

Reviewed By: rnk

Subscribers: aemerson, cfe-commits

Differential Revision: http://reviews.llvm.org/D4915

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216214 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoCoverage Mapping: store function's hash in coverage function records.
Alex Lorenz [Thu, 21 Aug 2014 19:25:27 +0000 (19:25 +0000)]
Coverage Mapping: store function's hash in coverage function records.

The profile data format was recently updated and the new indexing api
requires the code coverage tool to know the function's hash as well
as the function's name to get the execution counts for a function.

Differential Revision: http://reviews.llvm.org/D4995

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216208 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRefactor TLI creation. NFC.
Rafael Espindola [Thu, 21 Aug 2014 17:58:42 +0000 (17:58 +0000)]
Refactor TLI creation. NFC.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216198 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoObjective-C. Recover from missing interface decl.
Fariborz Jahanian [Thu, 21 Aug 2014 17:06:57 +0000 (17:06 +0000)]
Objective-C. Recover from missing interface decl.
and checking on availability of method declaration
instead of crashing. // rdar://18059669

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216191 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRange'ify some for loops over RecordDecl::fields()
Hans Wennborg [Thu, 21 Aug 2014 16:06:57 +0000 (16:06 +0000)]
Range'ify some for loops over RecordDecl::fields()

No functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216183 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoR600: Implement getPointerWidthV()
Tom Stellard [Thu, 21 Aug 2014 13:58:40 +0000 (13:58 +0000)]
R600: Implement getPointerWidthV()

This fixes a crash in the OCL_ImgProc/Canny OpenCV test.

NOTE: This is a candidate for the 3.5 branch.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216181 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoR600: Add processor type for hainan
Tom Stellard [Thu, 21 Aug 2014 13:58:38 +0000 (13:58 +0000)]
R600: Add processor type for hainan

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216180 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDriver: Implement -cl-denorms-are-zero
Tom Stellard [Thu, 21 Aug 2014 13:58:36 +0000 (13:58 +0000)]
Driver: Implement -cl-denorms-are-zero

This is currently a no-op, which is allowed by the OpenCL specification.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216179 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[analyzer] Don't warn on virtual calls in ctors to final methods.
Benjamin Kramer [Thu, 21 Aug 2014 10:25:03 +0000 (10:25 +0000)]
[analyzer] Don't warn on virtual calls in ctors to final methods.

The call will never go to a more derived class, but that's intentional in those
cases.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216167 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix invalid test generation by utils/ABITest/ABITestGen.py when the same enum is...
Daniel Sanders [Thu, 21 Aug 2014 10:13:49 +0000 (10:13 +0000)]
Fix invalid test generation by utils/ABITest/ABITestGen.py when the same enum is generated more than once.

When generating records/unions, the same enum type may be generated more
than once (with different names). In these cases, the name of the enum
values are not sufficiently unique to prevent multiple declarations. E.g:
  typedef enum T3 { enum0val0 } T3;
  typedef T3 T2[3];
  typedef enum T4 { enum0val0 } T4;
  typedef union T1 { T2 field0; T4 field1; char field2; } T1;

Added a unique suffix to enum values so that multiple identical enum types do
not use the same enum value names.

One example of this bug is produced by:
  ABITestGen.py --no-unsigned --no-vector --no-complex --no-bool \
                --max-args 0 --max-record-depth 1 -o inputs/test.9921.a.c \
                -T inputs/test.9921.b.c -D inputs/test.9921.driver.c \
                --min=9921 --count=1

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216166 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoMS ABI: Don't always instantiate all members of dllexported class templates (PR20163)
Hans Wennborg [Thu, 21 Aug 2014 01:14:01 +0000 (01:14 +0000)]
MS ABI: Don't always instantiate all members of dllexported class templates (PR20163)

Normally we mark all members of exported classes referenced to get them emitted.

However, MSVC doesn't do this for class templates that are implicitly specialized or
just have an explicit instantiation declaration. For such specializations, the members
are emitted when referenced.

The exception is the case when the dllexport attribute is propagated from a base class
to a base class template that doesn't have an explicit attribute: in this case all
methods of the base class template do get instantiated.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216145 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agotest/CodeGenCXX/dllexport.cpp: don't instantiate templates in USEMEMFUNC macro
Hans Wennborg [Thu, 21 Aug 2014 00:10:34 +0000 (00:10 +0000)]
test/CodeGenCXX/dllexport.cpp: don't instantiate templates in USEMEMFUNC macro

Use the derived class in the macro instead, to make it unambigous where
the template is being instantiated.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216142 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[test] Turn off warnings for test/Analysis/identical-expressions.cpp.
Jordan Rose [Wed, 20 Aug 2014 22:40:57 +0000 (22:40 +0000)]
[test] Turn off warnings for test/Analysis/identical-expressions.cpp.

Also, make it slightly clearer what's being tested by only differentiating integer
literals based on their suffix, rather than using a very large constant.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216133 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoTest: CoverageMapping: use "RUN: FileCheck" command instead of "RUN: cat | Filecheck".
Alex Lorenz [Wed, 20 Aug 2014 17:29:47 +0000 (17:29 +0000)]
Test: CoverageMapping: use "RUN: FileCheck" command instead of "RUN: cat | Filecheck".

Change the lit RUN commands for 3 tests to use the following pattern
"FileCheck -input-file ..." instead of "cat ... | FileCheck ..." as
suggested by Justin Bogner.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216085 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoCoverage mapping: fix mapping for objective-c for statement
Alex Lorenz [Wed, 20 Aug 2014 17:11:53 +0000 (17:11 +0000)]
Coverage mapping: fix mapping for objective-c for statement

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216082 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoCoverage mapping: fix mapping for objective-c message expression
Alex Lorenz [Wed, 20 Aug 2014 17:10:56 +0000 (17:10 +0000)]
Coverage mapping: fix mapping for objective-c message expression

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216081 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[analyzer] UnixAPI: Check that the third argument to open(2) (if present) is an integer.
Jordan Rose [Wed, 20 Aug 2014 16:58:09 +0000 (16:58 +0000)]
[analyzer] UnixAPI: Check that the third argument to open(2) (if present) is an integer.

Patch by Daniel Fahlgren.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216079 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[analyzer] UnixAPI: Check when open(2) is called with more than three arguments.
Jordan Rose [Wed, 20 Aug 2014 16:58:03 +0000 (16:58 +0000)]
[analyzer] UnixAPI: Check when open(2) is called with more than three arguments.

Patch by Daniel Fahlgren.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216078 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[analyzer] IdenticalExpr: don't try to compare integer literals with different widths.
Jordan Rose [Wed, 20 Aug 2014 16:51:26 +0000 (16:51 +0000)]
[analyzer] IdenticalExpr: don't try to compare integer literals with different widths.

PR20659. Patch by Anders Rönnholm.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216076 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[analyzer] IdenticalExpr: use getBytes rather than getString to compare string literals.
Jordan Rose [Wed, 20 Aug 2014 16:51:18 +0000 (16:51 +0000)]
[analyzer] IdenticalExpr: use getBytes rather than getString to compare string literals.

PR20693. Patch by Anders Rönnholm.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216075 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoObjective-C [qoi]. Provide fix-it hint when sending
Fariborz Jahanian [Tue, 19 Aug 2014 23:39:17 +0000 (23:39 +0000)]
Objective-C [qoi]. Provide fix-it hint when sending
class method to an object receiver. rdar://16263395

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216038 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoHandle SPARC float command line parameters for SPARCv9.
Brad Smith [Tue, 19 Aug 2014 21:50:15 +0000 (21:50 +0000)]
Handle SPARC float command line parameters for SPARCv9.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216029 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoTest: Coverage Mapping: add missing RUN commands
Alex Lorenz [Tue, 19 Aug 2014 20:51:54 +0000 (20:51 +0000)]
Test: Coverage Mapping: add missing RUN commands

Add the llvm-lit RUN commands for the two coverage mapping tests
that filecheck a temporary file.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216020 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAdd tests for coverage mapping generation.
Alex Lorenz [Tue, 19 Aug 2014 17:32:30 +0000 (17:32 +0000)]
Add tests for coverage mapping generation.

This patch adds the tests for the coverage mapping generation.
Most of the tests check the mapping regions produced by
the generator, and one checks the llvm IR.

Differential Revision: http://reviews.llvm.org/D4847

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215995 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoext_vector IRGen. Patch to allow indexing into
Fariborz Jahanian [Tue, 19 Aug 2014 17:17:40 +0000 (17:17 +0000)]
ext_vector IRGen. Patch to allow indexing into
ext_vector_type's 'hi/lo' components when
used as lvalue. rdar://18031917 pr20697

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215991 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoC++1y is now C++14!
Aaron Ballman [Tue, 19 Aug 2014 15:55:55 +0000 (15:55 +0000)]
C++1y is now C++14!

Changes diagnostic options, language standard options, diagnostic identifiers, diagnostic wording to use c++14 instead of c++1y. It also modifies related test cases to use the updated diagnostic wording.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215982 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoMove the body out of line to try to fix a buildbot.
Rafael Espindola [Tue, 19 Aug 2014 14:36:35 +0000 (14:36 +0000)]
Move the body out of line to try to fix a buildbot.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215980 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoGo back to having a takeModule instead of a getModule.
Rafael Espindola [Tue, 19 Aug 2014 14:32:16 +0000 (14:32 +0000)]
Go back to having a takeModule instead of a getModule.

Returning a std::unique_ptr is more constrained. Thanks to David Blaikie for the
suggestion.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215979 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[OPENMP] Extract common superclass from all the loop directives. No functional change...
Alexander Musman [Tue, 19 Aug 2014 11:27:13 +0000 (11:27 +0000)]
[OPENMP] Extract common superclass from all the loop directives. No functional changes (having common superclass is convenient for future loop directives CodeGen implementation)

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215975 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoMS ABI: Update alias template mangling for VC "14" CTP 3
David Majnemer [Tue, 19 Aug 2014 07:29:03 +0000 (07:29 +0000)]
MS ABI: Update alias template mangling for VC "14" CTP 3

MSVC "14" CTP 3 has fixed it's mangling for alias templates when used as
template-template arguments; update clang to be compatible with this
mangling.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215972 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUpdate for llvm api change.
Rafael Espindola [Tue, 19 Aug 2014 04:04:30 +0000 (04:04 +0000)]
Update for llvm api change.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215968 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAdd a warning flag for an existing diagnostic.
Nico Weber [Mon, 18 Aug 2014 23:02:03 +0000 (23:02 +0000)]
Add a warning flag for an existing diagnostic.

One more, and the number of flags without a dedicated flag fits in two decimal
digits :-)

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215946 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUpdate link strategy for sanitizer runtime libraries on Linux:
Alexey Samsonov [Mon, 18 Aug 2014 22:10:42 +0000 (22:10 +0000)]
Update link strategy for sanitizer runtime libraries on Linux:

1. Always put static sanitizer runtimes to the front of the linker
invocation line. This was already done for all sanitizers except UBSan:
in case user provides static libstdc++ we need to make sure that new/delete
operator definitions are picked from sanitizer runtimes instead of libstdc++.
We have to put UBSan runtime first for similar reasons: it depends on some
libstdc++ parts (e.g. __dynamic_cast function), and has to go first in
link line to ensure these functions will be picked up from libstdc++.

2. Put sanitizer libraries system dependencies (-ldl, -lpthread etc.) right
after sanitizer runtimes. This will ensure these libraries participate in
the link even if user provided -Wl,-as-needed flag. This should fix PR15823.

3. In case we link in several sanitizer runtimes (e.g. "ubsan", "ubsan_cxx"
and "san"), add system dependencies (-ldl, -lpthread, ...) only once.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215940 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix the rececl chain for redeclarations of predefined decls
Ben Langmuir [Mon, 18 Aug 2014 19:32:45 +0000 (19:32 +0000)]
Fix the rececl chain for redeclarations of predefined decls

Predefined decls like 'Protocol' in objc are not loaded from AST files,
so we cannot rely on loading the canonical decl to complete the redecl
chain for redeclarations of these decls.  The broken redecl chain was
non-circular, so looping over redecls() would hang.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215929 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoStore std::unique_ptr in InMemoryBuffers. NFC.
Rafael Espindola [Mon, 18 Aug 2014 19:16:31 +0000 (19:16 +0000)]
Store std::unique_ptr in InMemoryBuffers. NFC.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215928 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoreturn a std::unique_ptr from getMainBufferWithPrecompiledPreamble. NFC.
Rafael Espindola [Mon, 18 Aug 2014 18:47:08 +0000 (18:47 +0000)]
return a std::unique_ptr from getMainBufferWithPrecompiledPreamble. NFC.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215927 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUse std::unique_ptr to simplify this code a bit.
Rafael Espindola [Mon, 18 Aug 2014 18:33:41 +0000 (18:33 +0000)]
Use std::unique_ptr to simplify this code a bit.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215926 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoInline function into only use.
Rafael Espindola [Mon, 18 Aug 2014 18:17:32 +0000 (18:17 +0000)]
Inline function into only use.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215925 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoSimplify ASTUnit::Parse a bit by passing a std::unique_ptr to it.
Rafael Espindola [Mon, 18 Aug 2014 16:23:45 +0000 (16:23 +0000)]
Simplify ASTUnit::Parse a bit by passing a std::unique_ptr to it.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215900 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[x32] Handle -m64/-m32 switches by Driver in x32 mode
Pavel Chupin [Mon, 18 Aug 2014 15:38:38 +0000 (15:38 +0000)]
[x32] Handle -m64/-m32 switches by Driver in x32 mode

Summary:
Adding remaining 2 cases handling:
* from x32 to 32 via -m32
* from x32 to 64 via -m64

Test Plan: linux-ld test updated

Reviewers: chandlerc, atanasyan

Subscribers: cfe-commits, zinovy.nis

Differential Revision: http://reviews.llvm.org/D4930

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215899 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix a memory leak in one of the test unit. Silent coverity warning CID 1095912
Sylvestre Ledru [Mon, 18 Aug 2014 15:18:56 +0000 (15:18 +0000)]
Fix a memory leak in one of the test unit. Silent coverity warning CID 1095912

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215898 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAdd the break in the switch case (even if there is llvm_unreachable. It will silent...
Sylvestre Ledru [Mon, 18 Aug 2014 15:13:44 +0000 (15:13 +0000)]
Add the break in the switch case (even if there is llvm_unreachable. It will silent coverity warning CID 1231654

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215897 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUpdate the call to llvm::sys::fs::UniqueID to match the definition: UniqueID(uint64_t...
Sylvestre Ledru [Mon, 18 Aug 2014 15:00:11 +0000 (15:00 +0000)]
Update the call to llvm::sys::fs::UniqueID to match the definition: UniqueID(uint64_t Device, uint64_t File)
Fixes CID 1095247

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215896 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRepace SmallPtrSet with SmallPtrSetImpl in function arguments to avoid needing to...
Craig Topper [Sun, 17 Aug 2014 23:49:53 +0000 (23:49 +0000)]
Repace SmallPtrSet with SmallPtrSetImpl in function arguments to avoid needing to mention the size.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215869 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUse the pointer-like API of ErrorOr.
Rafael Espindola [Sun, 17 Aug 2014 23:31:27 +0000 (23:31 +0000)]
Use the pointer-like API of ErrorOr.

Thanks to David Blaikie for the suggestion.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215866 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoCreate a std::unique_ptr earlier.
Rafael Espindola [Sun, 17 Aug 2014 23:27:13 +0000 (23:27 +0000)]
Create a std::unique_ptr earlier.

Thanks to David Blaikie for the suggestion.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215865 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUse std::unique_ptr in a few methods that take ownership.
Rafael Espindola [Sun, 17 Aug 2014 23:12:27 +0000 (23:12 +0000)]
Use std::unique_ptr in a few methods that take ownership.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215864 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUpdate for llvm api changes.
Rafael Espindola [Sun, 17 Aug 2014 22:20:41 +0000 (22:20 +0000)]
Update for llvm api changes.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215856 91177308-0d34-0410-b5e6-96231b3b80d8