]>
granicus.if.org Git - php/log
Stanislav Malyshev [Mon, 3 Oct 2016 07:12:14 +0000 (00:12 -0700)]
Fix bug #73208 - another missing length check
Stanislav Malyshev [Mon, 3 Oct 2016 07:09:02 +0000 (00:09 -0700)]
Fix bug #73190: memcpy negative parameter _bc_new_num_ex
Stanislav Malyshev [Thu, 29 Sep 2016 06:30:48 +0000 (23:30 -0700)]
Fix bug #73189 - Memcpy negative size parameter php_resolve_path
Stanislav Malyshev [Thu, 29 Sep 2016 05:29:25 +0000 (22:29 -0700)]
Fixed bug #73174 - heap overflow in php_pcre_replace_impl
Stanislav Malyshev [Mon, 26 Sep 2016 04:25:01 +0000 (21:25 -0700)]
Fix bug #73150: missing NULL check in dom_document_save_html
Stanislav Malyshev [Mon, 26 Sep 2016 02:53:59 +0000 (19:53 -0700)]
Fix bug #73147: Use After Free in PHP7 unserialize()
Stanislav Malyshev [Sun, 25 Sep 2016 23:07:14 +0000 (16:07 -0700)]
Fix bug #73082
Stanislav Malyshev [Wed, 21 Sep 2016 05:59:12 +0000 (22:59 -0700)]
Fix bug #73073 - CachingIterator null dereference when convert to string
Dmitry Stogov [Tue, 20 Sep 2016 09:29:57 +0000 (12:29 +0300)]
Fixed inconsistent meaning of zend_startup_module_ex() return value used in zend_hash_apply()
Christoph M. Becker [Mon, 19 Sep 2016 23:05:57 +0000 (01:05 +0200)]
Merge branch 'pull-request/1845' into PHP-5.6
George Wang [Mon, 19 Sep 2016 14:46:46 +0000 (10:46 -0400)]
Fix wrong year in previous commit.
Julien Pauli [Mon, 19 Sep 2016 14:06:12 +0000 (16:06 +0200)]
Do not wrap user exception in case of custom JSON serialization
Christoph M. Becker [Fri, 16 Sep 2016 21:41:10 +0000 (23:41 +0200)]
Fix #73100: session_destroy null dereference in ps_files_path_create
Xinchen Hui [Fri, 16 Sep 2016 12:55:37 +0000 (20:55 +0800)]
Updte NEWS
Xinchen Hui [Tue, 28 Jun 2016 03:11:25 +0000 (11:11 +0800)]
Fixed bug #72505 (readfile() mangles files larger than 2G)
Christoph M. Becker [Fri, 16 Sep 2016 09:31:21 +0000 (11:31 +0200)]
Fix #73003: Integer Overflow in gdImageWebpCtx of gd_webp.c
We add the missing integer overflow check to avoid potential buffer overflows.
Remi Collet [Thu, 15 Sep 2016 13:32:39 +0000 (15:32 +0200)]
fix test (32bits)
Remi Collet [Thu, 15 Sep 2016 11:27:20 +0000 (13:27 +0200)]
fix ZTS build
Ferenc Kovacs [Thu, 15 Sep 2016 09:35:46 +0000 (11:35 +0200)]
update NEWS
Christoph M. Becker [Wed, 14 Sep 2016 22:34:55 +0000 (00:34 +0200)]
Fix and reactivate regression test for bug #50194
Apparently, different FreeType versions render the string differently, so
we have to cater to these slight differences. Unfortunately, the testing
framework doesn't yet offer a clean API for this, so we work around the
limitations by parsing and checking the output of test_image_equals_file().
Christoph M. Becker [Wed, 14 Sep 2016 18:00:30 +0000 (20:00 +0200)]
Skip ext/gd/tests/bug50194.phpt for now
There are apparently issues with the font rendering with different freetype
version; I'll have a look at this issue ASAP.
Christoph M. Becker [Wed, 14 Sep 2016 12:59:17 +0000 (14:59 +0200)]
Fix #50194: imagettftext broken on transparent background w/o alphablending
We must not draw the background pixels of the character glyphs, what has
already been fixed in GD 2.0.26.
Jakub Zelenka [Tue, 13 Sep 2016 17:15:34 +0000 (18:15 +0100)]
Fix bug #73072 (Invalid path SNI_server_certs causes segfault)
Christoph M. Becker [Tue, 13 Sep 2016 13:57:39 +0000 (15:57 +0200)]
Merge branch 'pull-request/2126' into PHP-5.6
Anatol Belski [Tue, 13 Sep 2016 13:28:28 +0000 (15:28 +0200)]
add test for bug #73068
Anatol Belski [Tue, 13 Sep 2016 10:00:29 +0000 (12:00 +0200)]
fix test portability
Anatol Belski [Tue, 13 Sep 2016 08:50:44 +0000 (10:50 +0200)]
missed semicolon
Anatol Belski [Tue, 13 Sep 2016 08:43:51 +0000 (10:43 +0200)]
fix C89 conformity
Stanislav Malyshev [Tue, 13 Sep 2016 03:25:08 +0000 (20:25 -0700)]
Fix bug #72293 - Heap overflow in mysqlnd related to BIT fields
Stanislav Malyshev [Tue, 13 Sep 2016 03:12:41 +0000 (20:12 -0700)]
Fix test
Stanislav Malyshev [Mon, 12 Sep 2016 07:35:01 +0000 (00:35 -0700)]
Fix bug #73065: Out-Of-Bounds Read in php_wddx_push_element of wddx.c
Stanislav Malyshev [Mon, 12 Sep 2016 04:37:44 +0000 (21:37 -0700)]
Fix bug #73035 (Out of bound when verify signature of tar phar in phar_parse_tarfile)
Stanislav Malyshev [Mon, 12 Sep 2016 04:19:29 +0000 (21:19 -0700)]
Fix bug #73052 - Memory Corruption in During Deserialized-object Destruction
Stanislav Malyshev [Mon, 12 Sep 2016 03:58:55 +0000 (20:58 -0700)]
Add check in fgetcsv in case sizeof(unit) != sizeof(size_t)
Stanislav Malyshev [Mon, 12 Sep 2016 03:24:13 +0000 (20:24 -0700)]
Fix bug #73029 - Missing type check when unserializing SplArray
Stanislav Malyshev [Tue, 6 Sep 2016 06:42:31 +0000 (23:42 -0700)]
Fix bug #72860: wddx_deserialize use-after-free
Stanislav Malyshev [Tue, 6 Sep 2016 01:10:51 +0000 (18:10 -0700)]
Also fix overflow in wordwrap
Stanislav Malyshev [Tue, 6 Sep 2016 01:01:35 +0000 (18:01 -0700)]
Fix bug #73007: add locale length check
Stanislav Malyshev [Mon, 5 Sep 2016 05:18:19 +0000 (22:18 -0700)]
Add more checks for int overflow
Stanislav Malyshev [Mon, 5 Sep 2016 05:07:35 +0000 (22:07 -0700)]
Fix bug #72928 - Out of bound when verify signature of zip phar in phar_parse_zipfile
Stanislav Malyshev [Fri, 2 Sep 2016 06:15:34 +0000 (23:15 -0700)]
Fix various int size overflows.
Add function for detection of string zvals with length that does not fit
INT_MAX.
Adam Baratz [Fri, 9 Sep 2016 21:00:50 +0000 (17:00 -0400)]
Add myself as pdo_dblib maintainer
Christoph M. Becker [Mon, 12 Sep 2016 11:21:34 +0000 (13:21 +0200)]
Skip regression test for issue that has not yet been released in libgd
<https://github.com/libgd/libgd/issues/177> has been assessed as enhancement,
so most likely it will be released with GD 2.3.
Christoph M. Becker [Mon, 12 Sep 2016 10:34:11 +0000 (12:34 +0200)]
Skip test for external GD because of not yet published bugfix
Christoph M. Becker [Sun, 11 Sep 2016 21:49:09 +0000 (23:49 +0200)]
Skip tests for unpatched external libgd regarding libvpx
Some issues have never been fixed in the external libgd's libvpx binding,
so we skip the respective tests.
Christoph M. Becker [Sun, 11 Sep 2016 17:30:55 +0000 (19:30 +0200)]
Split test for bundled vs. external libgd
The behavior of imagecropauto($im, IMG_CROP_DEFAULT) is rather different
for the bundled and an external libgd, see
<https://github.com/libgd/libgd/issues/298>.
Therefore we split the test for now.
Christoph M. Becker [Sun, 11 Sep 2016 16:29:27 +0000 (18:29 +0200)]
Make test case more resilient
This test case fails with external libgd, because libgd < 2.2.4 converts
palette images to truecolor (<https://github.com/libgd/libgd/issues/297>).
However, even if there happens no truecolor conversion, it is not guaranteed
that the palette indexes of the original and the cropped image are identical
(this is, for instance, not the case with current libgd master where the bug
has been fixed). Therefore we check for the expected RGBA value instead of
the palette index.
Christoph M. Becker [Sun, 19 Jun 2016 12:29:27 +0000 (14:29 +0200)]
A picture is worth a thousand message digests
The bundled GD test suites makes heavy use of md5() to verify the result
of drawing operations. This leads to fragile tests (even a slight change
in a PNG header would cause failure, and of course there is the
possibility of collisions), and even worse, eventual test failures are
rather unrevealing.
Therefore we replace all md5() verification with a simplistic
test_image_equals_file(), which is basically a simplified port of libgd's
gdTestImageCompareToFile(), adapted to the needs of PHPTs.
In the long run better tests helpers should be introduced (see also
<http://news.php.net/php.internals/94081>), but for now this solution
is preferable over the former.
(cherry picked from commit
24f9e96792518ec2a75f26b1eb2471dd7694f2b7 )
Christoph M. Becker [Sat, 10 Sep 2016 22:06:45 +0000 (00:06 +0200)]
Add regression test for bug #73053
The test succeeds with libxml < 2.9.4, and is supposed to succeed with
libxml > 2.9.4. Unfortunately, we can't conditionally mark a test case
as XFAIL, so we're simply skipping the test for libxml 2.9.4 instead.
Anatol Belski [Sat, 10 Sep 2016 09:02:17 +0000 (11:02 +0200)]
update NEWS
Anatol Belski [Sat, 10 Sep 2016 00:39:28 +0000 (02:39 +0200)]
Bug #73058 crypt broken when salt is 'too' long
Christoph M. Becker [Fri, 9 Sep 2016 14:27:50 +0000 (16:27 +0200)]
Remove ignored --FAIL-- section from test case
This is just confusing.
Christoph M. Becker [Fri, 9 Sep 2016 12:30:24 +0000 (14:30 +0200)]
Fix #73054: default option ignored when object passed to int filter
If an object that can't be converted to string is validated, we must not
bail out early, but rather check for a requested default value.
Levi Morrison [Thu, 3 Sep 2015 00:23:26 +0000 (18:23 -0600)]
Partially fix bug #67167 - Wrong return value...
...from FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE
The remainer of the fix would require the filter functions to only
convert to string when it makes sense for that particular filter.
(cherry picked from commit
432dc527adcbc3bf4809f6315350300d42c16c52 )
Yasuo Ohgaki [Fri, 9 Sep 2016 02:30:33 +0000 (11:30 +0900)]
Fixed Bug #68015 Session does not report invalid uid for files save handler
Anatol Belski [Thu, 8 Sep 2016 15:46:53 +0000 (17:46 +0200)]
Yasuo Ohgaki [Thu, 8 Sep 2016 05:07:57 +0000 (14:07 +0900)]
Fix bug26639.phpt
Yasuo Ohgaki [Thu, 8 Sep 2016 04:35:30 +0000 (13:35 +0900)]
Update NEWS
Yasuo Ohgaki [Thu, 8 Sep 2016 04:16:50 +0000 (13:16 +0900)]
Fix Bug #72992 mbstring.internal_encoding doesn't inherit default_charset
Christoph M. Becker [Tue, 6 Sep 2016 10:05:22 +0000 (12:05 +0200)]
Fix #73025: Heap Buffer Overflow in virtual_popen of zend_virtual_cwd.c
`command_length` is retrieved via strlen() and later passed to emalloc()
and memcpy(), so the appropriate type is `size_t`.
We don't add a regression test, because that would need to allocate a string
of at least 2 GiB.
Yasuo Ohgaki [Tue, 6 Sep 2016 09:29:20 +0000 (18:29 +0900)]
Update NEWS
Yasuo Ohgaki [Tue, 6 Sep 2016 07:05:34 +0000 (16:05 +0900)]
Fixed Bug #66964 mb_convert_variables() cannot detect recursion
Christoph M. Becker [Mon, 5 Sep 2016 22:28:28 +0000 (00:28 +0200)]
Fix #70752: Depacking with wrong password leaves 0 length files
We should not open the output stream before we have tried to open the
archive entry, as failing the latter could leave an empty file behind.
Julien Pauli [Mon, 5 Sep 2016 15:03:29 +0000 (17:03 +0200)]
Updated NEWS
Keyur [Wed, 13 Jul 2016 02:47:46 +0000 (02:47 +0000)]
Fixes #72590: Opcache restart with kill_all_lockers does not work
ACCEL_LOG_ERROR is special and causes a zend_bailout() and the code
never gets to call kill() in the next line after the logging. Change
the log level to WARNING.
Nikita Popov [Mon, 5 Sep 2016 12:21:43 +0000 (14:21 +0200)]
Limit editorconfig to C code
PHPT files do not follow this.
[ci skip]
Julien Pauli [Mon, 5 Sep 2016 08:17:56 +0000 (10:17 +0200)]
Updated NEWS
Julien Pauli [Thu, 1 Sep 2016 08:36:58 +0000 (10:36 +0200)]
Fix #72972, Bad filter for the flags FILTER_FLAG_NO_RES_RANGE and FILTER_FLAG_NO_PRIV_RANGE
Richard Fussenegger [Sun, 26 Jun 2016 15:51:44 +0000 (17:51 +0200)]
Added editorconfig file
Christoph M. Becker [Thu, 21 Jul 2016 13:36:42 +0000 (15:36 +0200)]
Implement #47456: Missing PCRE option 'J'
While it is possible to force the same behavior by setting the internal
option (?J), having a dedicated modifier appears to be useful. After all,
J is even listed on the "Pattern Modifiers" man page[1], but the description
referrs to (?J).
[1] <http://php.net/manual/en/reference.pcre.pattern.modifiers.php>
Stanislav Malyshev [Mon, 5 Sep 2016 07:29:11 +0000 (00:29 -0700)]
Merge branch 'pull-request/2061' into PHP-5.6
* pull-request/2061:
Recognize TDS versions 7.3 and 7.4
Adam Baratz [Wed, 24 Aug 2016 22:44:55 +0000 (18:44 -0400)]
Use integer placeholders, since values can vary with the TDS version
Stanislav Malyshev [Mon, 5 Sep 2016 03:49:34 +0000 (20:49 -0700)]
Same issue as #72926 in another place.
Stanislav Malyshev [Mon, 5 Sep 2016 02:13:22 +0000 (19:13 -0700)]
Sync fix for bug #72910 with current upstream
Christoph M. Becker [Sun, 4 Sep 2016 14:37:06 +0000 (16:37 +0200)]
Fix #72994: mbc_to_code() out of bounds read
We're backporting commit
999a3553 to the still supported PHP 5.6.
Christoph M. Becker [Sat, 3 Sep 2016 17:46:38 +0000 (19:46 +0200)]
Fix #67325: imagetruecolortopalette: white is duplicated in palette
gdImageTrueColorToPalette() is sometimes wasteful by putting multiple white
color entries into the palette. This is caused by an obvious typo, where
to avoid a division by zero when `total` is zero, `count` is checked instead
of `total`.
We fix this issue to improve the quality of the color quantization.
Cf. <https://github.com/libgd/libgd/commit/
24b4550f >
Anatol Belski [Sat, 3 Sep 2016 14:59:17 +0000 (16:59 +0200)]
fix leak and error check order
Christoph M. Becker [Sat, 3 Sep 2016 11:31:13 +0000 (13:31 +0200)]
Fix proto comment
While we're at it, we also change a related comment to use American English
consistently.
Christoph M. Becker [Fri, 2 Sep 2016 22:18:19 +0000 (00:18 +0200)]
Make test case more resilient
When ran from a root directory the test case failed, because the open_basedir
restriction for "../[…]" won't kick in. Therefore we change the current
working directory to the test case's directory, as discussed on internals,
see <http://news.php.net/php.internals/95585>.
Anatol Belski [Fri, 2 Sep 2016 22:01:04 +0000 (00:01 +0200)]
fix double free
Stanislav Malyshev [Fri, 2 Sep 2016 06:27:06 +0000 (23:27 -0700)]
Fix bug #72910
Merge upstream patch from https://github.com/kkos/oniguruma/commit/
65bdf2a0d160d06556415e5f396a75f6b11bad5c
Ferenc Kovacs [Thu, 1 Sep 2016 18:27:19 +0000 (20:27 +0200)]
5.6.27 will be next
Christoph M. Becker [Wed, 31 Aug 2016 14:33:14 +0000 (16:33 +0200)]
Fix #71882 amendment 2: Negative ftruncate() on php://memory exhausts memory
Christoph M. Becker [Wed, 31 Aug 2016 12:51:37 +0000 (14:51 +0200)]
Fix #71882 amendment: Negative ftruncate() on php://memory exhausts memory
To avoid BC breaks, we do not raise a warning for now.
Yasuo Ohgaki [Wed, 31 Aug 2016 12:06:19 +0000 (21:06 +0900)]
Update NEWS
Christoph M. Becker [Tue, 30 Aug 2016 12:48:24 +0000 (14:48 +0200)]
Fix #66797: mb_substr only takes 32-bit signed integer
`from` and `len` are `long`, but get passed to mbfl_substr() which expects
`int`s. Therefore we clamp the values to avoid the undefined conversion
behavior.
Ville Hukkamäki [Fri, 19 Aug 2016 22:05:04 +0000 (22:05 +0000)]
Test case for bug #72771
Christoph M. Becker [Mon, 29 Aug 2016 23:53:27 +0000 (01:53 +0200)]
Fix #71882: Negative ftruncate() on php://memory exhausts memory
We must not pass negative sizes to a size_t parameter.
Anatol Belski [Mon, 29 Aug 2016 19:45:39 +0000 (21:45 +0200)]
fix HANDLE leak
Anatol Belski [Mon, 29 Aug 2016 19:20:36 +0000 (21:20 +0200)]
update NEWS
Anatol Belski [Mon, 29 Aug 2016 19:03:03 +0000 (21:03 +0200)]
ensure null termination
Anatol Belski [Mon, 29 Aug 2016 18:25:34 +0000 (20:25 +0200)]
Fixed bug #72703 Out of bounds global memory read in BF_crypt triggered by password_verify
Anatol Belski [Mon, 29 Aug 2016 17:27:47 +0000 (19:27 +0200)]
fix double free
Anatol Belski [Mon, 29 Aug 2016 16:01:21 +0000 (18:01 +0200)]
fix leak
George Wang [Mon, 29 Aug 2016 01:49:30 +0000 (21:49 -0400)]
Added .user.ini support.
Added LSPHPRC support.
update LiteSpeed SAPI version to 6.10 .
Christoph M. Becker [Fri, 26 Aug 2016 23:02:58 +0000 (01:02 +0200)]
Fix #65550: get_browser() incorrectly parsers entries with "+" sign
+ signs in the browscap patterns are meant to be literal characters, so we
have to escape them for the regex matching.
Christoph M. Becker [Thu, 25 Aug 2016 16:10:38 +0000 (18:10 +0200)]
Fix #70825: Cannot fetch multiple values with group in ini file
If we have the position already from the last fetch, we also have to preset
the current group, because it won't be read again.
Christoph M. Becker [Thu, 25 Aug 2016 14:20:30 +0000 (16:20 +0200)]
Fix #71514: Bad dba_replace condition because of wrong API usage
We're backporting commit
9e309a2d to PHP-5.6, because it is a bugfix.
Anatol Belski [Thu, 25 Aug 2016 10:46:28 +0000 (12:46 +0200)]
backport relevant part from bug #72858 patch in 7.0
Christoph M. Becker [Sun, 21 Aug 2016 17:39:58 +0000 (19:39 +0200)]
Fix #68716: possible resource leaks in _php_image_convert()
We properly clean up after ourselves wrt. to closing opened file pointers
and created images.