]> granicus.if.org Git - libvpx/log
libvpx
8 years agoMerge "vp9 postproc: Bug fix and code clean."
Jacky Chen [Thu, 30 Jun 2016 21:59:43 +0000 (21:59 +0000)]
Merge "vp9 postproc: Bug fix and code clean."

8 years agoMerge "libyuv: update to 2f101fdb"
James Bankoski [Thu, 30 Jun 2016 19:11:30 +0000 (19:11 +0000)]
Merge "libyuv: update to 2f101fdb"

8 years agoMerge "vp9: remove x86inc.asm distinction"
Johann Koenig [Thu, 30 Jun 2016 17:42:17 +0000 (17:42 +0000)]
Merge "vp9: remove x86inc.asm distinction"

8 years agoMerge "Require x86inc.asm"
Johann Koenig [Thu, 30 Jun 2016 17:41:33 +0000 (17:41 +0000)]
Merge "Require x86inc.asm"

8 years agoMerge "Fix error in get_ul_intra_threshold() for 10/12 bit."
Paul Wilkins [Thu, 30 Jun 2016 16:26:14 +0000 (16:26 +0000)]
Merge "Fix error in get_ul_intra_threshold() for 10/12 bit."

8 years agoMerge "Fix error in get_smooth_intra_threshold() for 10/12 bit."
Paul Wilkins [Thu, 30 Jun 2016 16:25:54 +0000 (16:25 +0000)]
Merge "Fix error in get_smooth_intra_threshold() for 10/12 bit."

8 years agolibyuv: update to 2f101fdb
Jim Bankoski [Wed, 29 Jun 2016 23:18:01 +0000 (16:18 -0700)]
libyuv: update to 2f101fdb

Fixes color issue when scaling without breaking mingw.

BUG=https://bugs.chromium.org/p/libyuv/issues/detail?id=605
BUG=https://bugs.chromium.org/p/webm/issues/detail?id=1252

Change-Id: Ifba747feb0c6a08f2b353b820a24c6c145d440ad

8 years agoFix error in get_ul_intra_threshold() for 10/12 bit.
paulwilkins [Thu, 30 Jun 2016 12:38:57 +0000 (13:38 +0100)]
Fix error in get_ul_intra_threshold() for 10/12 bit.

The scaling of the threshold for 10 and 12 bit here appears
to be in the wrong direction. For 10 and 12 bit we expect sse
values to be higher and hence the threshold used should be
scaled up not down.

Change-Id: I2678116652b539aef48100e0f22873edd4f5a786

8 years agoFix error in get_smooth_intra_threshold() for 10/12 bit.
paulwilkins [Thu, 30 Jun 2016 12:31:39 +0000 (13:31 +0100)]
Fix error in get_smooth_intra_threshold() for 10/12 bit.

This function seems to scale the threshold for testing an
SSE value in the wrong direction for 10 and 12 bit inputs.

Also for a true SSE the scalings should probably be << 4 and 8

Change-Id: Iba8047b3f70d04aa46d9688a824f3d49c1c58e90

8 years agoMerge "vp9: Change the scheme for modeling rd for 32x32 on newmv_last mode."
Jacky Chen [Thu, 30 Jun 2016 05:59:46 +0000 (05:59 +0000)]
Merge "vp9: Change the scheme for modeling rd for 32x32 on newmv_last mode."

8 years agovp9: remove x86inc.asm distinction
Johann [Thu, 30 Jun 2016 01:07:17 +0000 (18:07 -0700)]
vp9: remove x86inc.asm distinction

BUG=b:29583530

Change-Id: I952da3fc0d4716dec897be0d2e9806af6612722b

8 years agoRequire x86inc.asm
Johann [Thu, 30 Jun 2016 01:03:27 +0000 (18:03 -0700)]
Require x86inc.asm

Force enable x86inc.asm when building for x86. Previously there were
compatibility issues so a flag was added to simplify disabling this
code.

The known issues have been resolved and x86inc.asm is the preferred
abstraction layer (over x86_abi_support.asm).

BUG=b:29583530

Change-Id: Ib935e97b37ffb22d7af72ba0f04564ae6280f1fd

8 years agoconfigure: restore vs_version variable
James Zern [Wed, 29 Jun 2016 23:57:28 +0000 (16:57 -0700)]
configure: restore vs_version variable

inadvertently lost in the final patchset of:
078dff7 configure: remove old visual studio support (<2010)

this prevents an empty CONFIG_VS_VERSION and avoids make failure

Change-Id: I529d52eca59329e2715309efd63d80f0e1fed462

8 years agovp9: Change the scheme for modeling rd for 32x32 on newmv_last mode.
JackyChen [Wed, 29 Jun 2016 23:22:12 +0000 (16:22 -0700)]
vp9: Change the scheme for modeling rd for 32x32 on newmv_last mode.

For real time CBR mode, use model_rd_for_sb_y for 32x32 if the mode is
newmv last, which is less aggressive in skipping transform and
quantization, to avoid quality regression in some conditions.

Change-Id: Ifa30be587f2a8a4a7f182a172de6ce277c0f8556

8 years agoMerge "Revert "libyuv: update to b8ddb5a2""
James Bankoski [Wed, 29 Jun 2016 23:20:25 +0000 (23:20 +0000)]
Merge "Revert "libyuv: update to b8ddb5a2""

8 years agoRevert "libyuv: update to b8ddb5a2"
James Bankoski [Wed, 29 Jun 2016 23:05:51 +0000 (23:05 +0000)]
Revert "libyuv: update to b8ddb5a2"

This reverts commit b8f83282f8506ad3d839440341bbe683df7d2cf6.

Update was to wrong version and still has:

BUG=webm:1252

Change-Id: I80f3a7c0581ab5e2dd1a84f7840e51d7c362afac

8 years agoMerge changes I9433d858,Iafd05637,If08ce6ca
James Zern [Wed, 29 Jun 2016 23:07:15 +0000 (23:07 +0000)]
Merge changes I9433d858,Iafd05637,If08ce6ca

* changes:
  tests: remove redundant round() definition
  remove visual studio < 2010 workarounds
  configure: remove old visual studio support (<2010)

8 years agoMerge "Remove effectless initialization"
Yaowu Xu [Wed, 29 Jun 2016 22:51:14 +0000 (22:51 +0000)]
Merge "Remove effectless initialization"

8 years agotests: remove redundant round() definition
James Zern [Tue, 28 Jun 2016 03:43:04 +0000 (20:43 -0700)]
tests: remove redundant round() definition

use vpx_ports/msvc.h for compatibility

BUG=b/29583530

Change-Id: I9433d8586cd0b790e7f4d697304298feafe801f1

8 years agoMerge "Prevent negative variance"
Yaowu Xu [Wed, 29 Jun 2016 20:53:36 +0000 (20:53 +0000)]
Merge "Prevent negative variance"

8 years agoPrevent negative variance
Yaowu Xu [Wed, 29 Jun 2016 18:08:17 +0000 (11:08 -0700)]
Prevent negative variance

Due to rounding, hbd variance may become negative. This commit put in
check and clamp of negative values to 0.

Change-Id: I610d9c8aa2d4eebe7bc5f2c5624a9e3cadad4c94

8 years agoMerge "libyuv: update to b8ddb5a2"
James Bankoski [Wed, 29 Jun 2016 17:58:39 +0000 (17:58 +0000)]
Merge "libyuv: update to b8ddb5a2"

8 years agolibyuv: update to b8ddb5a2
Jim Bankoski [Tue, 28 Jun 2016 14:26:07 +0000 (07:26 -0700)]
libyuv: update to b8ddb5a2

Fixes color issue when scaling without breaking mingw.

BUG=https://bugs.chromium.org/p/libyuv/issues/detail?id=605
BUG=https://bugs.chromium.org/p/webm/issues/detail?id=1252

Change-Id: I3920c5664def7ae7a23f60fb160d26d23bc86a27

8 years agoMerge "VP9: handle_inter_mode()... Use interp_filter"
Scott LaVarnway [Wed, 29 Jun 2016 11:41:51 +0000 (11:41 +0000)]
Merge "VP9: handle_inter_mode()... Use interp_filter"

8 years agoremove visual studio < 2010 workarounds
James Zern [Tue, 28 Jun 2016 03:29:01 +0000 (20:29 -0700)]
remove visual studio < 2010 workarounds

BUG=b/29583530

Change-Id: Iafd05637eb65f4da54a9c857e79204a77646858a

8 years agoconfigure: remove old visual studio support (<2010)
James Zern [Tue, 28 Jun 2016 03:08:12 +0000 (20:08 -0700)]
configure: remove old visual studio support (<2010)

BUG=b/29583530

Change-Id: If08ce6ca352f377ac4db6b9b1909b507bba6d872

8 years agovp9 postproc: Bug fix and code clean.
jackychen [Tue, 28 Jun 2016 22:38:18 +0000 (15:38 -0700)]
vp9 postproc: Bug fix and code clean.

Bug fix: The crash is caused by not allocating buffer for prev_mip in
postproc_state and prev_mip in postproc_state is only used for MFQE,
ohter postproc modules, deblocking and etc., should not use it.

BUG=webm:1251

Change-Id: I3120d2f50603b4a2d400e92d583960a513953a28

8 years agoVP9: handle_inter_mode()... Use interp_filter
Scott LaVarnway [Tue, 28 Jun 2016 21:09:59 +0000 (14:09 -0700)]
VP9: handle_inter_mode()... Use interp_filter

only if above/left is inter.

Change-Id: I0cc1f926425c021c84536df8271e9ee5f3f87caf

8 years agoMerge "vp9: Increase thr_var for 32x32 blocks in var-based partitioning."
Jacky Chen [Tue, 28 Jun 2016 20:54:06 +0000 (20:54 +0000)]
Merge "vp9: Increase thr_var for 32x32 blocks in var-based partitioning."

8 years agoMerge "vp9: Move chroma sensitivity check out from choose_partitioning."
Jacky Chen [Tue, 28 Jun 2016 20:53:23 +0000 (20:53 +0000)]
Merge "vp9: Move chroma sensitivity check out from choose_partitioning."

8 years agoRemove effectless initialization
Yaowu Xu [Tue, 28 Jun 2016 19:28:45 +0000 (12:28 -0700)]
Remove effectless initialization

Change-Id: Iec117841a7ecf6f99d2b718057d8646e221c5c64

8 years agoMerge "*.asm: normalize label format"
James Zern [Tue, 28 Jun 2016 19:22:10 +0000 (19:22 +0000)]
Merge "*.asm: normalize label format"

8 years agovp9: Move chroma sensitivity check out from choose_partitioning.
jackychen [Mon, 27 Jun 2016 21:08:34 +0000 (14:08 -0700)]
vp9: Move chroma sensitivity check out from choose_partitioning.

Change-Id: Ie78185a30cac4d1841be3708bd23e6505d3733b6

8 years agoMerge "psnr.c: use int64_t for sum of differences"
Yaowu Xu [Tue, 28 Jun 2016 16:55:44 +0000 (16:55 +0000)]
Merge "psnr.c: use int64_t for sum of differences"

8 years agopsnr.c: use int64_t for sum of differences
Yaowu Xu [Tue, 28 Jun 2016 16:53:11 +0000 (09:53 -0700)]
psnr.c: use int64_t for sum of differences

Since the values can be negative.

Change-Id: Idda69e9fb47bb34696aeb20170341a0191c5d85e

8 years agoMerge "mips added p6600 cpu support"
Parag Salasakar [Tue, 28 Jun 2016 08:45:01 +0000 (08:45 +0000)]
Merge "mips added p6600 cpu support"

8 years ago*.asm: normalize label format
James Zern [Wed, 22 Jun 2016 19:18:49 +0000 (12:18 -0700)]
*.asm: normalize label format

add a trailing ':', though it's optional with the tools we support, it's
more common to use it to mark a label. this also quiets the
orphan-labels warning with nasm/yasm.

BUG=b/29583530

Change-Id: I46e95255e12026dd542d9838e2dd3fbddf7b56e2

8 years agoMerge "Revert "libyuv: update to 1b3e4aee47""
James Bankoski [Mon, 27 Jun 2016 22:59:11 +0000 (22:59 +0000)]
Merge "Revert "libyuv: update to 1b3e4aee47""

8 years agoRevert "libyuv: update to 1b3e4aee47"
James Bankoski [Mon, 27 Jun 2016 22:25:24 +0000 (22:25 +0000)]
Revert "libyuv: update to 1b3e4aee47"

This reverts commit 0c6caf187c59e5d6bdabd8596c1910c6866da7aa.

BUG=https://bugs.chromium.org/p/webm/issues/detail?id=1252

Fails mingw_64 builds.

Change-Id: I83e7204bf1be48b499dc32b2597693b95ec49d06

8 years agovp9: Increase thr_var for 32x32 blocks in var-based partitioning.
jackychen [Thu, 23 Jun 2016 16:40:49 +0000 (09:40 -0700)]
vp9: Increase thr_var for 32x32 blocks in var-based partitioning.

For real-time mode, increase variance threshold for 32x32 blocks in
var-based partitioning for resolution >= 720p, so that it is more
likely to stay at 32x32 for high resolution which accelerates the
encoding speed with little/no PSNR drop.

PSNR effect on different speed settings:
speed 8 rtc: 0.02 overall PSNR drop, 0.285% SSIM drop
speed 7 rtc: 0.196% overall PSNR increase, 0.066% SSIM increase
speed 5 rtc_derf: no effect.

Speed up:
gips_motion_WHD, 1mbps: 2.5% faster on speed 7, 2.6% faster on speed8
gips_stat_WHD, 1mbps: 4.6% faster on speed 7, 5.6% faster on speed8

Change-Id: Ie7c33c4d2dd7d09294917e031357fc5476c3a4bb

8 years agoMerge "libyuv: update to 1b3e4aee47"
James Bankoski [Mon, 27 Jun 2016 19:32:50 +0000 (19:32 +0000)]
Merge "libyuv: update to 1b3e4aee47"

8 years agoMerge "Port metric computation changes from nextgenv2"
Yaowu Xu [Mon, 27 Jun 2016 19:18:00 +0000 (19:18 +0000)]
Merge "Port metric computation changes from nextgenv2"

8 years agomips added p6600 cpu support
Parag Salasakar [Mon, 27 Jun 2016 07:32:55 +0000 (13:02 +0530)]
mips added p6600 cpu support

Removed -funroll-loops

Change-Id: I6684bcac62902c10f945a6dcc4ed803203fcd829

8 years agoFix ubsan warnings: vp9/encoder/vp9_pickmode.c
Yaowu Xu [Mon, 20 Jun 2016 17:42:56 +0000 (10:42 -0700)]
Fix ubsan warnings: vp9/encoder/vp9_pickmode.c

This commit fixes a number of integer out of range issue in HBD build.

BUG=webm:1219

Change-Id: Ib4192dc74a500e1b86c37a399114c7f6d4ed5185

8 years agoMerge "s/UINT32_MAX/UINT_MAX/"
James Zern [Sat, 25 Jun 2016 21:09:55 +0000 (21:09 +0000)]
Merge "s/UINT32_MAX/UINT_MAX/"

8 years agos/UINT32_MAX/UINT_MAX/
James Zern [Sat, 25 Jun 2016 17:58:38 +0000 (10:58 -0700)]
s/UINT32_MAX/UINT_MAX/

provides better toolchain compatibility

Change-Id: I8561a6de668a68ff54fe3886a4ee6300f0ae9c04

8 years agovp9_pickmode: revert rd modeling change for hbd
James Zern [Sat, 25 Jun 2016 18:13:02 +0000 (11:13 -0700)]
vp9_pickmode: revert rd modeling change for hbd

Avoids a segfault in high-bitdepth builds.
This restores the condition to its state prior to:
7991241 vp9: Change the scheme for modeling rd for bsize 32x32.

BUG=webm:1250

Change-Id: I6183d5b34cb89dfbf27b7bb589812148a72cd7de

8 years agoRevert "Update vpx subpixel 1d filter ssse3 asm"
James Zern [Sat, 25 Jun 2016 18:26:27 +0000 (11:26 -0700)]
Revert "Update vpx subpixel 1d filter ssse3 asm"

This reverts commit 1517fb74fd40eaab67246e8fb81d5c321bb33b06.

Fixes a segfault in windows x64 builds.

Change-Id: I6a6959cd7e64a28376849a9f2b11fc852a7c1fbe

8 years agoMerge "vp9: Change the scheme for modeling rd for bsize 32x32."
Jacky Chen [Sat, 25 Jun 2016 00:43:40 +0000 (00:43 +0000)]
Merge "vp9: Change the scheme for modeling rd for bsize 32x32."

8 years agoMerge "datarate_test,DatarateTestLarge: normalize bits type"
James Zern [Sat, 25 Jun 2016 00:36:05 +0000 (00:36 +0000)]
Merge "datarate_test,DatarateTestLarge: normalize bits type"

8 years agoMerge "vp9: Code clean, move low temp var logic out of choose_partitioning."
Jacky Chen [Fri, 24 Jun 2016 22:00:49 +0000 (22:00 +0000)]
Merge "vp9: Code clean, move low temp var logic out of choose_partitioning."

8 years agolibyuv: update to 1b3e4aee47
Jim Bankoski [Fri, 24 Jun 2016 21:37:13 +0000 (14:37 -0700)]
libyuv: update to 1b3e4aee47

Color issue when scaling.   https://codereview.chromium.org/2084533006/

Change-Id: I84d74346f754c02a5b770b87b6e0b6885d03bb20

8 years agoMerge "cosmetics: Beautify whitespaces and line wrapping"
James Zern [Fri, 24 Jun 2016 21:51:01 +0000 (21:51 +0000)]
Merge "cosmetics: Beautify whitespaces and line wrapping"

8 years agoMerge "cosmetics: Change few types to their posix version"
James Zern [Fri, 24 Jun 2016 21:50:45 +0000 (21:50 +0000)]
Merge "cosmetics: Change few types to their posix version"

8 years agoMerge "cosmetics: Make few conditions clearer"
James Zern [Fri, 24 Jun 2016 21:50:32 +0000 (21:50 +0000)]
Merge "cosmetics: Make few conditions clearer"

8 years agoPort metric computation changes from nextgenv2
Yaowu Xu [Fri, 24 Jun 2016 19:44:23 +0000 (12:44 -0700)]
Port metric computation changes from nextgenv2

Change-Id: I4aceffcdf7af59ffeb51984f0345c3a4c7e76a9f

8 years agovp9: Code clean, move low temp var logic out of choose_partitioning.
jackychen [Fri, 24 Jun 2016 17:42:00 +0000 (10:42 -0700)]
vp9: Code clean, move low temp var logic out of choose_partitioning.

Change-Id: I7093e74131e0964471c9993c1e972b4617c4731d

8 years agovp9: Change the scheme for modeling rd for bsize 32x32.
jackychen [Fri, 24 Jun 2016 16:39:27 +0000 (09:39 -0700)]
vp9: Change the scheme for modeling rd for bsize 32x32.

For real-time CBR mode, use model_rd_for_sb_y_large instead of
model_rd_for_sb_y for 32x32 block. In the former model, transform
might be skipped more aggressively in some condtions, which speeds
up encoding time with only a little PSNR/SSIM drop on rtc test set.
No obvious visual quality regression.

PSNR effect on different speed settings:
speed 8 rtc:  0.129% overall PSNR drop, 0.137% SSIM drop
speed 7 rtc:  0.135% overall PSNR drop, 0.062% SSIM drop
speed 5 rtc_derf: 0.105% overall PSNR drop, 0.095% SSIM drop

Speed up:
gips_motion_WHD, 1mbps: 3.29% faster on speed 7, 2.56% faster on speed8
gips_stat_WHD, 1mbps: 2.17% faster on speed 7, 1.62% faster on speed8

BUG=webm:1250

Change-Id: I818babce5b8549b4b1a7c3978df8591bffde7173

8 years agovp9-svc: Remove some unneeded code/comment.
Marco [Fri, 24 Jun 2016 18:42:04 +0000 (11:42 -0700)]
vp9-svc: Remove some unneeded code/comment.

Change-Id: I710707296042d8586109760544ef68e40ae486c3

8 years agocosmetics: Beautify whitespaces and line wrapping
Yury Gitman [Wed, 22 Jun 2016 19:20:06 +0000 (12:20 -0700)]
cosmetics: Beautify whitespaces and line wrapping

Change-Id: I9afa02cae671bd3527cf344695e53d0cc767f549

8 years agocosmetics: Change few types to their posix version
Yury Gitman [Wed, 22 Jun 2016 19:15:23 +0000 (12:15 -0700)]
cosmetics: Change few types to their posix version

Change-Id: I6d7bc9ed7396e7b0d63ee97bfa473fdea002f9ee

8 years agocosmetics: Make few conditions clearer
Yury Gitman [Fri, 24 Jun 2016 17:17:51 +0000 (10:17 -0700)]
cosmetics: Make few conditions clearer

Change-Id: Ib024b3e42efc7ce1af56824a4644fdefcd45b215

8 years agoMerge "Revert "vp9: Change the scheme for modeling rd for bsize 32x32.""
Yaowu Xu [Fri, 24 Jun 2016 16:05:54 +0000 (16:05 +0000)]
Merge "Revert "vp9: Change the scheme for modeling rd for bsize 32x32.""

8 years agoMerge "Rationalize type to avoid integer out of range"
Yaowu Xu [Fri, 24 Jun 2016 13:58:36 +0000 (13:58 +0000)]
Merge "Rationalize type to avoid integer out of range"

8 years agoRationalize type to avoid integer out of range
Yaowu Xu [Fri, 24 Jun 2016 00:24:35 +0000 (17:24 -0700)]
Rationalize type to avoid integer out of range

BUG=webm:1250

Change-Id: Id5bb2762ca1bf996ba4f9a60eec977a7994c1d94

8 years agodatarate_test,DatarateTestLarge: normalize bits type
James Zern [Fri, 24 Jun 2016 06:29:26 +0000 (23:29 -0700)]
datarate_test,DatarateTestLarge: normalize bits type

quiets a msvc warning:
conversion from 'const int64_t' to 'size_t', possible loss of data

Change-Id: I90a2ac6b040454dac7434fc9b63b98c42ea127b1

8 years agoRevert "vp9: Change the scheme for modeling rd for bsize 32x32."
James Zern [Thu, 23 Jun 2016 22:57:54 +0000 (15:57 -0700)]
Revert "vp9: Change the scheme for modeling rd for bsize 32x32."

This reverts commit 5c29ee726e622baf6f950dfe980df0d4c116c1a8.

Causes segfaults in VP9/EndToEndTestLarge.EndtoEndPSNRTest.

BUG=webm:1250

Change-Id: I8a30e97be30589abdb76820b5c3c37c46cd6cafb

8 years agoMerge "configure: clean up var style and set_all usage"
Johann Koenig [Thu, 23 Jun 2016 22:59:21 +0000 (22:59 +0000)]
Merge "configure: clean up var style and set_all usage"

8 years agoconfigure: clean up var style and set_all usage
Johann [Thu, 23 Jun 2016 19:29:04 +0000 (12:29 -0700)]
configure: clean up var style and set_all usage

Use quotes whenever possible and {} always for variables.

Replace multiple set_all calls with *able_feature().

Change-Id: If579d3f718bd4133cf1592b4554a8ed00cf9f2d3

8 years agoMerge "vp9: Fix potential SEGV in decoder_peek_si_internal"
Vignesh Venkatasubramanian [Thu, 23 Jun 2016 21:33:12 +0000 (21:33 +0000)]
Merge "vp9: Fix potential SEGV in decoder_peek_si_internal"

8 years agoMerge "Update vpx subpixel 1d filter ssse3 asm"
Linfeng Zhang [Thu, 23 Jun 2016 19:08:03 +0000 (19:08 +0000)]
Merge "Update vpx subpixel 1d filter ssse3 asm"

8 years agoMerge "Fail early when android target does not include --sdk-path"
Johann Koenig [Thu, 23 Jun 2016 19:04:51 +0000 (19:04 +0000)]
Merge "Fail early when android target does not include --sdk-path"

8 years agoMerge "set interp_filter to SWITCHABLE_FILTER for intra block"
Angie Chiang [Thu, 23 Jun 2016 18:56:26 +0000 (18:56 +0000)]
Merge "set interp_filter to SWITCHABLE_FILTER for intra block"

8 years agoMerge changes Ifddff89d,I827dfe59,Idca7ef45
Johann Koenig [Thu, 23 Jun 2016 17:55:34 +0000 (17:55 +0000)]
Merge changes Ifddff89d,I827dfe59,Idca7ef45

* changes:
  vp8 machine setup: mark unused variable
  vp8 realtime encoder: mark unused variable
  vp8 error concealment: remove unused variables

8 years agovp9: Fix potential SEGV in decoder_peek_si_internal
Vignesh Venkatasubramanian [Wed, 22 Jun 2016 17:24:27 +0000 (10:24 -0700)]
vp9: Fix potential SEGV in decoder_peek_si_internal

decoder_peek_si_internal could potentially read more bytes than
what actually exists in the input buffer. We check for the buffer
size to be at least 8, but we try to read up to 10 bytes in the
worst case. A well crafted file could thus cause a segfault.
Likely change that introduced this bug was:
https://chromium-review.googlesource.com/#/c/70439 (git hash:
7c43fb6)

BUG=chromium:621095

Change-Id: Id74880cfdded44caaa45bbdbaac859c09d3db752

8 years agoMerge "vpx_lpf_horizontal_4_sse2: Remove dead load."
Alex Converse [Thu, 23 Jun 2016 16:20:35 +0000 (16:20 +0000)]
Merge "vpx_lpf_horizontal_4_sse2: Remove dead load."

8 years agoFail early when android target does not include --sdk-path
Johann [Wed, 22 Jun 2016 23:31:12 +0000 (16:31 -0700)]
Fail early when android target does not include --sdk-path

Change-Id: I07e7e63476a2e32e3aae123abdee8b7bbbdc6a8c

8 years agoMerge "Add default flags for arm64/armv8 builds"
Johann Koenig [Thu, 23 Jun 2016 13:47:28 +0000 (13:47 +0000)]
Merge "Add default flags for arm64/armv8 builds"

8 years agovp8 machine setup: mark unused variable
Johann [Thu, 23 Jun 2016 00:41:25 +0000 (17:41 -0700)]
vp8 machine setup: mark unused variable

When building without multithreading and for a non-arm, non-x86 system,
ctx is unused.

Cleans up -Wextra warning:
unused parameter ‘ctx’ [-Werror=unused-parameter]

Change-Id: Ifddff89d2ebd45f7d71e3d415a8f2415dd818957

8 years agovp8 realtime encoder: mark unused variable
Johann [Thu, 23 Jun 2016 00:37:44 +0000 (17:37 -0700)]
vp8 realtime encoder: mark unused variable

'duration' is not used in realtime-only mode:

Cleans up -Wextra warning:
unused parameter 'duration' [-Wunused-parameter]

Change-Id: I827dfe59ebcdc72c5a93fdf7e5aca063433914b1

8 years agovp8 error concealment: remove unused variables
Johann [Thu, 23 Jun 2016 00:33:45 +0000 (17:33 -0700)]
vp8 error concealment: remove unused variables

vp8_conceal_corrupt_mb is an empty function. Remove it entirely.

Cleans up -Wextra warnings:
unused parameter 'mi_stride' [-Wunused-parameter]
unused parameter 'xd' [-Wunused-parameter]

Change-Id: Idca7ef4508fae2b4b76a40d44507522a72ccc2c8

8 years agovpx_lpf_horizontal_4_sse2: Remove dead load.
Alex Converse [Thu, 23 Jun 2016 01:17:41 +0000 (18:17 -0700)]
vpx_lpf_horizontal_4_sse2: Remove dead load.

Change-Id: I51026c52baa1f0881fcd5b68e1fdf08a2dc0916e

8 years agoset interp_filter to SWITCHABLE_FILTER for intra block
Angie Chiang [Tue, 21 Jun 2016 19:16:03 +0000 (12:16 -0700)]
set interp_filter to SWITCHABLE_FILTER for intra block

In vp9_pick_inter_mode(), instead of using
vp9_get_pred_context_switchable_interp(xd) to assign filter_ref,
we use a less strict condition on assigning filter_ref.
This is to reduce the probabily of entering the flow of not
assigning filter_ref and then skipping filter search.

Overall PSNR gain 0.074% for rtc dataset

Details:
Low    Mid     High
0.185% -0.008% -0.082%

Change-Id: Id5c5ab38d3766c213d5681e17b4d1afd1529e676

8 years agoMerge "Repack vp9_token_state."
Alex Converse [Thu, 23 Jun 2016 00:17:23 +0000 (00:17 +0000)]
Merge "Repack vp9_token_state."

8 years agoMerge "vp9: Change the scheme for modeling rd for bsize 32x32."
Jacky Chen [Wed, 22 Jun 2016 23:50:46 +0000 (23:50 +0000)]
Merge "vp9: Change the scheme for modeling rd for bsize 32x32."

8 years agoAdd default flags for arm64/armv8 builds
Johann [Wed, 22 Jun 2016 23:08:10 +0000 (16:08 -0700)]
Add default flags for arm64/armv8 builds

Allows building simple targets with sane default flags.

For example, using the Android arm64 toolchain from the NDK:
https://developer.android.com/ndk/guides/standalone_toolchain.html
./build/tools/make-standalone-toolchain.sh --arch=arm64 \
  --platform=android-24 --install-dir=/tmp/arm64
CROSS=/tmp/arm64/bin/aarch64-linux-android- \
  ~/libvpx/configure --target=arm64-linux-gcc --disable-multithread

BUG=webm:1143

Change-Id: I06f5a7564f5382cf1a4bad41aef4308566c53adf

8 years agoMerge "remove vp10"
James Zern [Wed, 22 Jun 2016 22:35:57 +0000 (22:35 +0000)]
Merge "remove vp10"

8 years agoUpdate vpx subpixel 1d filter ssse3 asm
Linfeng Zhang [Thu, 9 Jun 2016 20:46:09 +0000 (13:46 -0700)]
Update vpx subpixel 1d filter ssse3 asm

Speed test shows the new vertical filters have degradation on Celeron
Chromebook. Added "X86_SUBPIX_VFILTER_PREFER_SLOW_CELERON" to control
the vertical filters activated code. Now just simply active the code
without degradation on Celeron. Later there should be 2 set of vertical
filters ssse3 functions, and let jump table to choose based on CPU type.

Change-Id: I37e3e9c5694737d9134a6bce6698d3e43f8fc962

8 years agoMerge "win: Include <intrin.h> instead of manually declaring intrinsics."
Nico Weber [Wed, 22 Jun 2016 19:06:47 +0000 (19:06 +0000)]
Merge "win: Include <intrin.h> instead of manually declaring intrinsics."

8 years agowin: Include <intrin.h> instead of manually declaring intrinsics.
Nico Weber [Wed, 22 Jun 2016 18:44:47 +0000 (14:44 -0400)]
win: Include <intrin.h> instead of manually declaring intrinsics.

This helps clang-cl.

BUG=chromium:592745

Change-Id: I49f9b6928c91b2b43567f4336520ba4f1010d3ad

8 years agovp9: Change the scheme for modeling rd for bsize 32x32.
jackychen [Tue, 21 Jun 2016 00:24:26 +0000 (17:24 -0700)]
vp9: Change the scheme for modeling rd for bsize 32x32.

For real-time CBR mode, use model_rd_for_sb_y_large instead of
model_rd_for_sb_y for 32x32 block. In the former model, transform
might be skipped more aggressively in some condtions, which speeds
up encoding time with only a little PSNR/SSIM drop on rtc test set.
No obvious visual quality regression.

PSNR effect on different speed setting:
speed 8 rtc:  0.129% overall PSNR drop, 0.137% SSIM drop
speed 7 rtc:  0.135% overall PSNR drop, 0.062% SSIM drop
speed 5 rtc_derf: 0.105% overall PSNR drop, 0.095% SSIM drop

Speed up:
gips_motion_WHD, 1mbps: 3.29% faster on speed 7, 2.56% faster on speed8
gips_stat_WHD, 1mbps: 2.17% faster on speed 7, 1.62% faster on speed8

Change-Id: I902f62def225ea01c145d7e5a93497398b8f5edf

8 years agoPrevent negative variance
Yaowu Xu [Wed, 22 Jun 2016 17:41:52 +0000 (10:41 -0700)]
Prevent negative variance

Due to rounding used computation, HDB variance computation may produce
slightly negative values. This commit adds clamping to make sure
output variance values for 10 and 12 to be non-negative.

Change-Id: Id679aa55a4c201958c4c7d28cd8733b9246a71c8

8 years agoMerge "Fix ubsan warnings: vp9/encoder/vp9_mcomp.c"
Yaowu Xu [Wed, 22 Jun 2016 00:12:58 +0000 (00:12 +0000)]
Merge "Fix ubsan warnings: vp9/encoder/vp9_mcomp.c"

8 years agoFix ubsan warnings: vp9/encoder/vp9_mcomp.c
Yaowu Xu [Mon, 20 Jun 2016 17:13:30 +0000 (10:13 -0700)]
Fix ubsan warnings: vp9/encoder/vp9_mcomp.c

This commit fixes a number of ubsan warnings in HBD build.

BUG=webm:1219

Change-Id: I05f0fd0ef50e93db4ba34205005c54af1ed32acc

8 years agoMerge "Add a hardware compatibility feature"
Hui Su [Tue, 21 Jun 2016 21:33:26 +0000 (21:33 +0000)]
Merge "Add a hardware compatibility feature"

8 years agoMerge "Disable neon for Xcode versions < v6.3."
Tom Finegan [Tue, 21 Jun 2016 17:53:54 +0000 (17:53 +0000)]
Merge "Disable neon for Xcode versions < v6.3."

8 years agoAdd a hardware compatibility feature
hui su [Wed, 15 Jun 2016 18:39:41 +0000 (11:39 -0700)]
Add a hardware compatibility feature

This commit adds an encoder workaround to support better
compatibility with a non-compliant hardware vp9 profile 2 decoder.

The known issue with this decoder is:
The decoder assumes a wrong value, 127 instead of the correct
value of 511 and 2047, for any assumed top-left corner pixel in
UV planes for 10 and 12 bit, respectively. Such assumed
top-left corner pixel is used for INTRA prediction when a real
decoded/reconstructed pixel is not avalable, e.g. when it is
located inside the row above the top row or inside the column
left to the leftest column of a video image.

Change-Id: Ic15a938a3107e1b85e96cb7903a5c4220986b99d

8 years agoMerge "Make type conversion explicit"
Yaowu Xu [Mon, 20 Jun 2016 21:34:40 +0000 (21:34 +0000)]
Merge "Make type conversion explicit"

8 years agoRepack vp9_token_state.
Alex Converse [Fri, 17 Jun 2016 23:47:15 +0000 (16:47 -0700)]
Repack vp9_token_state.

Reduces size from 32 bytes to 24 bytes on x86_64.

Change-Id: I8a22552343a1fc916117f35267fe6a295250f742

8 years agoMerge "Fix ubsan warning: vp9/encoder/vp9_encodeframe.c"
Yaowu Xu [Mon, 20 Jun 2016 19:33:33 +0000 (19:33 +0000)]
Merge "Fix ubsan warning: vp9/encoder/vp9_encodeframe.c"