]> granicus.if.org Git - python/log
python
12 years agoMerge heads
Martin v. Löwis [Fri, 22 Jun 2012 20:19:51 +0000 (22:19 +0200)]
Merge heads

12 years agoIssue #15143: Define _DEBUG when compiling resources.
Martin v. Löwis [Fri, 22 Jun 2012 20:16:42 +0000 (22:16 +0200)]
Issue #15143: Define _DEBUG when compiling resources.

12 years agoMerge
Antoine Pitrou [Fri, 22 Jun 2012 20:07:24 +0000 (22:07 +0200)]
Merge

12 years agomerge
Alexander Belopolsky [Fri, 22 Jun 2012 20:09:42 +0000 (16:09 -0400)]
merge

12 years agoAdd a docstring at the top of Tools/ssl/make_ssl_data.py
Antoine Pitrou [Fri, 22 Jun 2012 20:07:01 +0000 (22:07 +0200)]
Add a docstring at the top of Tools/ssl/make_ssl_data.py

12 years agoIssue #9527: tm_gmtoff has 'correct' sign.
Alexander Belopolsky [Fri, 22 Jun 2012 20:04:19 +0000 (16:04 -0400)]
Issue #9527: tm_gmtoff has 'correct' sign.

12 years agoIssue #14769: Incorporated mildly pedantic feedback from python-dev.
Larry Hastings [Fri, 22 Jun 2012 19:58:36 +0000 (12:58 -0700)]
Issue #14769: Incorporated mildly pedantic feedback from python-dev.
Mostly documentation changes; the code changes are clarifications,
not semantic changes.

12 years agoMerge
Antoine Pitrou [Fri, 22 Jun 2012 19:13:34 +0000 (21:13 +0200)]
Merge

12 years agoAdd forgotten files for #14837.
Antoine Pitrou [Fri, 22 Jun 2012 19:12:59 +0000 (21:12 +0200)]
Add forgotten files for #14837.

12 years agoIssue #14837: SSL errors now have `library` and `reason` attributes describing precis...
Antoine Pitrou [Fri, 22 Jun 2012 19:11:52 +0000 (21:11 +0200)]
Issue #14837: SSL errors now have `library` and `reason` attributes describing precisely what happened and in which OpenSSL submodule.
The str() of a SSLError is also enhanced accordingly.

NOTE: this commit creates a reference leak.  The leak seems tied to the
use of PyType_FromSpec() to create the SSLError type.  The leak is on the
type object when it is instantiated:

>>> e = ssl.SSLError()
>>> sys.getrefcount(ssl.SSLError)
35
>>> e = ssl.SSLError()
>>> sys.getrefcount(ssl.SSLError)
36
>>> e = ssl.SSLError()
>>> sys.getrefcount(ssl.SSLError)
37

12 years agoIssue #14785: Add sys._debugmallocstats() to help debug low-level memory allocation...
David Malcolm [Fri, 22 Jun 2012 18:55:41 +0000 (14:55 -0400)]
Issue #14785: Add sys._debugmallocstats() to help debug low-level memory allocation issues

12 years agoIssue #15124: Optimize _thread.LockType deletion and acquisition when
Kristjan Valur Jonsson [Fri, 22 Jun 2012 18:40:02 +0000 (18:40 +0000)]
Issue #15124: Optimize _thread.LockType deletion and acquisition when
not contested, similar to what _thread.RLock already has.

12 years agoFixed compiler warnings in datetime_astimezone()
Alexander Belopolsky [Fri, 22 Jun 2012 18:11:58 +0000 (14:11 -0400)]
Fixed compiler warnings in datetime_astimezone()

12 years agoIssue #9527: Fixes for platforms without tm_zone
Alexander Belopolsky [Fri, 22 Jun 2012 17:23:21 +0000 (13:23 -0400)]
Issue #9527: Fixes for platforms without tm_zone

12 years agomerge
Alexander Belopolsky [Fri, 22 Jun 2012 16:48:08 +0000 (12:48 -0400)]
merge

12 years agoIssue #7582: Use ISO timestamp in diff.py
Alexander Belopolsky [Fri, 22 Jun 2012 16:46:19 +0000 (12:46 -0400)]
Issue #7582: Use ISO timestamp in diff.py

12 years agoCloses #10142: Support for SEEK_HOLE/SEEK_DATA
Jesus Cea [Fri, 22 Jun 2012 16:32:07 +0000 (18:32 +0200)]
Closes #10142: Support for SEEK_HOLE/SEEK_DATA

12 years agoIssue #9527: datetime.astimezone() method will now supply a class
Alexander Belopolsky [Fri, 22 Jun 2012 16:25:57 +0000 (12:25 -0400)]
Issue #9527: datetime.astimezone() method will now supply a class
timezone instance corresponding to the system local timezone when
called with no arguments.

12 years agoIssue #9527: datetime.astimezone() method will now supply a class
Alexander Belopolsky [Fri, 22 Jun 2012 16:23:23 +0000 (12:23 -0400)]
Issue #9527: datetime.astimezone() method will now supply a class
timezone instance corresponding to the system local timezone when
called with no arguments.

12 years agoIssue #14769: test_capi now has SkipitemTest, which cleverly checks
Larry Hastings [Fri, 22 Jun 2012 10:56:29 +0000 (03:56 -0700)]
Issue #14769: test_capi now has SkipitemTest, which cleverly checks
for "parity" between PyArg_ParseTuple() and the Python/getargs.c static
function skipitem() for all possible "format units".

12 years agoWhitespace normalization
Martin v. Löwis [Fri, 22 Jun 2012 10:49:59 +0000 (12:49 +0200)]
Whitespace normalization

12 years agoAdd Stable ABI documentation.
Martin v. Löwis [Fri, 22 Jun 2012 10:49:08 +0000 (12:49 +0200)]
Add Stable ABI documentation.

12 years agoIssue #15042: Add PyState_AddModule and PyState_RemoveModule.
Martin v. Löwis [Fri, 22 Jun 2012 10:20:55 +0000 (12:20 +0200)]
Issue #15042: Add PyState_AddModule and PyState_RemoveModule.
Add version  guard for Py_LIMITED_API additions.
Issue #15081: Document PyState_FindModule.
Patch by Robin Schreiber.

12 years agoSimplify code in fileio_init
Hynek Schlawack [Fri, 22 Jun 2012 07:32:22 +0000 (09:32 +0200)]
Simplify code in fileio_init

If an identical code line is in both at the end of if and else, it can as well
stand after the block. :) The code is from 464cf523485e, I didn't see it before
checking the commits in the web interface of course.

12 years agoIssue #14653: email.utils.mktime_tz() no longer relies on system
Alexander Belopolsky [Fri, 22 Jun 2012 00:48:23 +0000 (20:48 -0400)]
Issue #14653: email.utils.mktime_tz() no longer relies on system
mktime() when timezone offest is supplied.

12 years agoIssue #14653: email.utils.mktime_tz() no longer relies on system
Alexander Belopolsky [Fri, 22 Jun 2012 00:34:09 +0000 (20:34 -0400)]
Issue #14653: email.utils.mktime_tz() no longer relies on system
mktime() when timezone offest is supplied.

12 years agoDocument the rest of zlib.compressobj()'s arguments.
Nadeem Vawda [Thu, 21 Jun 2012 23:40:49 +0000 (01:40 +0200)]
Document the rest of zlib.compressobj()'s arguments.

Original patch by Jim Jewett; see issue 14684.

12 years agoTidy up comments from dd4f7d5c51c7 (zlib compression dictionary support).
Nadeem Vawda [Thu, 21 Jun 2012 22:35:57 +0000 (00:35 +0200)]
Tidy up comments from dd4f7d5c51c7 (zlib compression dictionary support).

12 years agoMake lzma.{encode,decode}_filter_properties private.
Nadeem Vawda [Thu, 21 Jun 2012 21:36:48 +0000 (23:36 +0200)]
Make lzma.{encode,decode}_filter_properties private.

These functions were originally added to support LZMA compression in the zipfile
module, and are not of interest for the majority of users.

They can be made public in 3.4 if there is user interest, but in the meanwhile,
I've opted to present a smaller, simpler API for the module's initial release.

12 years agoMerge /features/pep397 changes
Brian Curtin [Thu, 21 Jun 2012 22:11:45 +0000 (17:11 -0500)]
Merge /features/pep397 changes

12 years agobranch merge
Brian Curtin [Thu, 21 Jun 2012 21:36:05 +0000 (16:36 -0500)]
branch merge

12 years agoRemove associator project - it's not needed
Brian Curtin [Thu, 21 Jun 2012 21:35:12 +0000 (16:35 -0500)]
Remove associator project - it's not needed

12 years ago#10053: Don't close FDs when FileIO.__init__ fails
Hynek Schlawack [Thu, 21 Jun 2012 18:58:31 +0000 (20:58 +0200)]
#10053: Don't close FDs when FileIO.__init__ fails

Loosely based on the work by Hirokazu Yamamoto.

12 years ago#10053: Don't close FDs when FileIO.__init__ fails
Hynek Schlawack [Thu, 21 Jun 2012 18:20:25 +0000 (20:20 +0200)]
#10053: Don't close FDs when FileIO.__init__ fails

Loosely based on the work by Hirokazu Yamamoto.

12 years agoRemove the original license, as this was contributed under Vinay Sajip's agreement.
Martin v. Löwis [Thu, 21 Jun 2012 17:29:37 +0000 (19:29 +0200)]
Remove the original license, as this was contributed under Vinay Sajip's agreement.

12 years agoBuild and bundle the 32-bit launcher in all configurations.
Martin v. Löwis [Thu, 21 Jun 2012 16:24:32 +0000 (18:24 +0200)]
Build and bundle the 32-bit launcher in all configurations.

12 years agoFix UNICODE glitch.
Martin v. Löwis [Thu, 21 Jun 2012 16:15:54 +0000 (18:15 +0200)]
Fix UNICODE glitch.

12 years agoFix off-by-one error.
Martin v. Löwis [Thu, 21 Jun 2012 15:36:15 +0000 (17:36 +0200)]
Fix off-by-one error.

12 years agoPackage the launcher.
Martin v. Löwis [Thu, 21 Jun 2012 15:36:05 +0000 (17:36 +0200)]
Package the launcher.

12 years agoMake private function static (from `make smelly`)
Antoine Pitrou [Thu, 21 Jun 2012 15:26:28 +0000 (17:26 +0200)]
Make private function static (from `make smelly`)

12 years agomd5_{init,process,done}: make static
doko@ubuntu.com [Thu, 21 Jun 2012 15:26:06 +0000 (17:26 +0200)]
md5_{init,process,done}: make static

12 years agosha1_{init,process,done}: make static
doko@ubuntu.com [Thu, 21 Jun 2012 15:05:50 +0000 (17:05 +0200)]
sha1_{init,process,done}: make static

12 years agoUse GetEnvironmentVariableW instead of _wgetenv to silence VC warnings.
Martin v. Löwis [Thu, 21 Jun 2012 14:33:09 +0000 (16:33 +0200)]
Use GetEnvironmentVariableW instead of _wgetenv to silence VC warnings.

12 years agoAdd version resource.
Martin v. Löwis [Thu, 21 Jun 2012 14:27:58 +0000 (16:27 +0200)]
Add version resource.

12 years ago... and fix the name of the sha1 file name.
doko@ubuntu.com [Thu, 21 Jun 2012 14:22:15 +0000 (16:22 +0200)]
... and fix the name of the sha1 file name.

12 years agoFix name of the sha1 extension.
doko@ubuntu.com [Thu, 21 Jun 2012 14:00:52 +0000 (16:00 +0200)]
Fix name of the sha1 extension.

12 years agoRemove references to removed md5.h and md5.c files.
doko@ubuntu.com [Thu, 21 Jun 2012 10:13:35 +0000 (12:13 +0200)]
Remove references to removed md5.h and md5.c files.

12 years agoformat_obj: make it static
doko@ubuntu.com [Thu, 21 Jun 2012 10:12:20 +0000 (12:12 +0200)]
format_obj: make it static

12 years agoIssue #14225: Fix Unicode support for curses (#12567) on OS X:
Ned Deily [Thu, 21 Jun 2012 06:47:14 +0000 (23:47 -0700)]
Issue #14225: Fix Unicode support for curses (#12567) on OS X:
    1. on OS X, there is no separate /usr/lib/libcursesw nor libpanelw
    2. _XOPEN_SOURCE_EXTENDED must be enabled for _curses build

12 years agoAdd associator
Brian Curtin [Thu, 21 Jun 2012 03:48:54 +0000 (22:48 -0500)]
Add associator

12 years agoIssue #14684: Add support for predefined compression dictionaries to the zlib module.
Nadeem Vawda [Thu, 21 Jun 2012 00:13:12 +0000 (02:13 +0200)]
Issue #14684: Add support for predefined compression dictionaries to the zlib module.

Original patch by Sam Rushing.

12 years agoFix comment.
Stefan Krah [Wed, 20 Jun 2012 21:38:51 +0000 (23:38 +0200)]
Fix comment.

12 years agoMany cleanups of redundant code in mpd_qrem_near():
Stefan Krah [Wed, 20 Jun 2012 21:34:58 +0000 (23:34 +0200)]
Many cleanups of redundant code in mpd_qrem_near():

  1) _mpd_qdivmod() uses the context precision only in two places, and
     the new code should be exactly equivalent to the previous code.

  2) Remove misleading comment.

  3) The quotient *is* an integer with exponent 0, so calling mpd_qtrunc()
     is pointless.

  4) Replace two instances of identical code by a single one.

  5) Use _mpd_cmp_abs() instead of mpd_cmp_total_mag(): the operands
     are not special.

  6) Don't clear MPD_Rounded in the status (with the current code it should
     not be set within the function).

12 years agoAdd pywlauncher project
Brian Curtin [Wed, 20 Jun 2012 21:11:39 +0000 (16:11 -0500)]
Add pywlauncher project

12 years agoAdd the pyw launcher
Brian Curtin [Wed, 20 Jun 2012 21:11:08 +0000 (16:11 -0500)]
Add the pyw launcher

12 years agoGet 64-bit building
Brian Curtin [Wed, 20 Jun 2012 20:55:04 +0000 (15:55 -0500)]
Get 64-bit building

12 years agoSupport 32-bit release building:
Brian Curtin [Wed, 20 Jun 2012 20:45:12 +0000 (15:45 -0500)]
Support 32-bit release building:

12 years agoInitial changes to get the py launcher building
Brian Curtin [Wed, 20 Jun 2012 20:37:24 +0000 (15:37 -0500)]
Initial changes to get the py launcher building

12 years agoAdd launcher source and resources
Brian Curtin [Wed, 20 Jun 2012 20:36:14 +0000 (15:36 -0500)]
Add launcher source and resources

12 years agoPrefer assertEqual to simply assert per recommendation in issue6727.
Jason R. Coombs [Wed, 20 Jun 2012 14:24:24 +0000 (10:24 -0400)]
Prefer assertEqual to simply assert per recommendation in issue6727.
Clarified comment on disabled code to reference issue15093.

12 years agoDo not italicize punctuation in python(1) manual page (Matt Kraai).
doko@ubuntu.com [Wed, 20 Jun 2012 11:16:31 +0000 (13:16 +0200)]
Do not italicize punctuation in python(1) manual page (Matt Kraai).

12 years agoFix small overeager edit from 8e47e9af826e.
Georg Brandl [Wed, 20 Jun 2012 09:26:03 +0000 (11:26 +0200)]
Fix small overeager edit from 8e47e9af826e.

12 years agoIssue #15096: Drop support for the ur string prefix
Christian Heimes [Wed, 20 Jun 2012 09:17:58 +0000 (11:17 +0200)]
Issue #15096: Drop support for the ur string prefix

12 years agoFix GzipFile's handling of filenames given as bytes objects.
Nadeem Vawda [Tue, 19 Jun 2012 23:48:50 +0000 (01:48 +0200)]
Fix GzipFile's handling of filenames given as bytes objects.

Add relevant tests for GzipFile, and also for BZ2File and LZMAFile.

12 years agoFix GzipFile's handling of filenames given as bytes objects.
Nadeem Vawda [Tue, 19 Jun 2012 23:35:22 +0000 (01:35 +0200)]
Fix GzipFile's handling of filenames given as bytes objects.

12 years agoIssue #14928: Fix importlib bootstrap issues by using a custom executable (Modules...
Antoine Pitrou [Tue, 19 Jun 2012 20:29:35 +0000 (22:29 +0200)]
Issue #14928: Fix importlib bootstrap issues by using a custom executable (Modules/_freeze_importlib) to build Python/importlib.h.

12 years agoIssue #15038: Document caveats with the emulated condition variables.
Kristjan Valur Jonsson [Tue, 19 Jun 2012 16:30:28 +0000 (16:30 +0000)]
Issue #15038: Document caveats with the emulated condition variables.

12 years agoAdd versionchanged tags for #14772 changes
Brian Curtin [Tue, 19 Jun 2012 15:03:05 +0000 (10:03 -0500)]
Add versionchanged tags for #14772 changes

12 years agoIssue #15103: remove the NUL character (serving as a Mercurial binary marker) from...
Antoine Pitrou [Tue, 19 Jun 2012 14:33:39 +0000 (16:33 +0200)]
Issue #15103: remove the NUL character (serving as a Mercurial binary marker) from Python/importlib.h.
Instead the email notification hook uses a configuration option to omit importlib.h diffs.

12 years agoIssue #15038:
Kristjan Valur Jonsson [Tue, 19 Jun 2012 10:10:09 +0000 (10:10 +0000)]
Issue #15038:
Fix incorrect test of the condition variable state, spotted by
Richard Oudkerk.  This could cause the internal condition variable
to grow without bounds.

12 years agoFix #14772: Return the destination from some shutil functions.
Brian Curtin [Mon, 18 Jun 2012 23:41:07 +0000 (18:41 -0500)]
Fix #14772: Return the destination from some shutil functions.

12 years agoIssue #15038: Optimize python Locks on Windows
Kristján Valur Jónsson [Mon, 18 Jun 2012 20:30:44 +0000 (20:30 +0000)]
Issue #15038: Optimize python Locks on Windows
Extract cross-platform condition variable support into a separate file and
provide user-mode non-recursive locks for Windows.

12 years agoIssue #15064: Use with-blocks for some examples in docs.
Richard Oudkerk [Mon, 18 Jun 2012 20:29:36 +0000 (21:29 +0100)]
Issue #15064: Use with-blocks for some examples in docs.

12 years agoIssue #15064: Make BaseManager.__enter__() start server if necessary.
Richard Oudkerk [Mon, 18 Jun 2012 20:29:30 +0000 (21:29 +0100)]
Issue #15064: Make BaseManager.__enter__() start server if necessary.

12 years agoAdd comments to the power functions, in particular to _mpd_qpow_real().
Stefan Krah [Mon, 18 Jun 2012 17:57:23 +0000 (19:57 +0200)]
Add comments to the power functions, in particular to _mpd_qpow_real().

12 years agoIssue #15064: Implement context manager protocol for multiprocessing types
Richard Oudkerk [Mon, 18 Jun 2012 16:47:52 +0000 (17:47 +0100)]
Issue #15064: Implement context manager protocol for multiprocessing types

12 years agoIssue #15101: Make pool finalizer avoid joining current thread.
Richard Oudkerk [Mon, 18 Jun 2012 15:02:49 +0000 (16:02 +0100)]
Issue #15101: Make pool finalizer avoid joining current thread.

12 years agoIssue #15101: Make pool finalizer avoid joining current thread.
Richard Oudkerk [Mon, 18 Jun 2012 14:54:57 +0000 (15:54 +0100)]
Issue #15101: Make pool finalizer avoid joining current thread.

12 years agoFiddle with timeouts in barrier tests
Richard Oudkerk [Mon, 18 Jun 2012 13:11:10 +0000 (14:11 +0100)]
Fiddle with timeouts in barrier tests

12 years agoFix NEWS entry for #15036
Petri Lehtinen [Mon, 18 Jun 2012 07:45:56 +0000 (10:45 +0300)]
Fix NEWS entry for #15036

12 years agoFix NEWS entry for #15036
Petri Lehtinen [Mon, 18 Jun 2012 07:43:53 +0000 (10:43 +0300)]
Fix NEWS entry for #15036

12 years agoPrevent test_inspect from keeping alive a ton of frames and local variables by way...
Antoine Pitrou [Sun, 17 Jun 2012 21:18:07 +0000 (23:18 +0200)]
Prevent test_inspect from keeping alive a ton of frames and local variables by way of a global variable keeping a reference to a traceback.
Should fix some buildbot failures.

12 years agoIssue #14657: The frozen instance of importlib used for bootstrap is now also the...
Antoine Pitrou [Sun, 17 Jun 2012 20:33:38 +0000 (22:33 +0200)]
Issue #14657: The frozen instance of importlib used for bootstrap is now also the module imported as importlib._bootstrap.

12 years agoMerge: Update out of date docstring.
R David Murray [Sun, 17 Jun 2012 19:27:21 +0000 (15:27 -0400)]
Merge: Update out of date docstring.

12 years agoUpdate out of date docstring.
R David Murray [Sun, 17 Jun 2012 19:26:35 +0000 (15:26 -0400)]
Update out of date docstring.

12 years ago#14840: merge with 3.2.
Ezio Melotti [Sun, 17 Jun 2012 12:12:42 +0000 (14:12 +0200)]
#14840: merge with 3.2.

12 years ago#14840: Add a bit on the difference between tuples and lists. Initial patch by Zacha...
Ezio Melotti [Sun, 17 Jun 2012 12:10:59 +0000 (14:10 +0200)]
#14840: Add a bit on the difference between tuples and lists.  Initial patch by Zachary Ware.

12 years agoMerge from 3.2 (Ignore X-Antivirus headers in test_nntplib)
Nick Coghlan [Sun, 17 Jun 2012 11:30:35 +0000 (21:30 +1000)]
Merge from 3.2 (Ignore X-Antivirus headers in test_nntplib)

12 years agoIgnore X-Antivirus headers in test_nntplib
Nick Coghlan [Sun, 17 Jun 2012 11:27:18 +0000 (21:27 +1000)]
Ignore X-Antivirus headers in test_nntplib

12 years agoMerge from 3.2 (Issue #15095: Use better assertions in test_imaplib)
Nick Coghlan [Sun, 17 Jun 2012 11:15:45 +0000 (21:15 +1000)]
Merge from 3.2 (Issue #15095: Use better assertions in test_imaplib)

12 years agoIssue #15095: Use better assertions in test_imaplib
Nick Coghlan [Sun, 17 Jun 2012 11:10:21 +0000 (21:10 +1000)]
Issue #15095: Use better assertions in test_imaplib

12 years agoMerge from 3.2 (Issue #15043: skip test_gdb if the custom hooks can't be loaded)
Nick Coghlan [Sun, 17 Jun 2012 09:16:02 +0000 (19:16 +1000)]
Merge from 3.2 (Issue #15043: skip test_gdb if the custom hooks can't be loaded)

12 years agoDisable test on Unix. Causes buildbots to fail. See Issue #15091
Jason R. Coombs [Sun, 17 Jun 2012 09:06:16 +0000 (05:06 -0400)]
Disable test on Unix. Causes buildbots to fail. See Issue #15091

12 years agoIssue #15043: skip test_gdb if the custom hooks can't be loaded
Nick Coghlan [Sun, 17 Jun 2012 08:57:20 +0000 (18:57 +1000)]
Issue #15043: skip test_gdb if the custom hooks can't be loaded

12 years agoWhite space normalization.
Martin v. Löwis [Sun, 17 Jun 2012 08:42:02 +0000 (10:42 +0200)]
White space normalization.

12 years agoIssue #14055: Add __sizeof__ support to _elementtree.
Martin v. Löwis [Sun, 17 Jun 2012 08:41:22 +0000 (10:41 +0200)]
Issue #14055: Add __sizeof__ support to _elementtree.

12 years agoElaborate that sizeof only accounts for the object itself.
Martin v. Löwis [Sun, 17 Jun 2012 08:40:16 +0000 (10:40 +0200)]
Elaborate that sizeof only accounts for the object itself.

12 years agoMerge from 3.2. (Issue #15044: Handle Fedora 17's approach to ndbm compatibility)
Nick Coghlan [Sun, 17 Jun 2012 08:27:54 +0000 (18:27 +1000)]
Merge from 3.2. (Issue #15044: Handle Fedora 17's approach to ndbm compatibility)

12 years agoIssue #15044: Handle Fedora 17's approach to ndbm compatibility
Nick Coghlan [Sun, 17 Jun 2012 08:27:11 +0000 (18:27 +1000)]
Issue #15044: Handle Fedora 17's approach to ndbm compatibility

12 years agoAdding test from issue6727 demonstrating that symlink import issue does not occur...
Jason R. Coombs [Sun, 17 Jun 2012 07:53:47 +0000 (03:53 -0400)]
Adding test from issue6727 demonstrating that symlink import issue does not occur here in 3.3