Richard Russon [Sun, 3 Jul 2016 14:41:03 +0000 (15:41 +0100)]
merge: bugs-common
* Set COLUMNS to MuttIndexWindow->cols in mutt_create_filter_fd. (closes #3837)
* Fix infinite loop when help is bound to a named key combination.
* Add real prototype for re_match_2_internal in regex.c
* Clarify oppenc option documention. (closes #3846)
* Include ncurses tinfo library if found.
* Fix cppflags and muttlibs duplication with --with-gss.
* Check $pgp_autoinline and $pgp_replyinline if oppenc is set. (closes #3846)
Kevin McCarthy [Fri, 1 Jul 2016 20:33:20 +0000 (13:33 -0700)]
Check $pgp_autoinline and $pgp_replyinline if oppenc is set. (closes #3846)
The first oppenc call takes place after the initial checks of
$pgp_autoline and $pgp_replyinline, and doesn't go through the pgp
menu.
Therefore, check for $pgp_autoline and $pgp_replyinline if oppenc is
set too, to avoid oppenc enabling encryption without INLINE being set
in those cases.
a6a4d6ed0f19 previously cleaned things up so that it is safe
to set INLINE even if encryption isn't enabled.
Kevin McCarthy [Thu, 30 Jun 2016 01:58:53 +0000 (18:58 -0700)]
Fix cppflags and muttlibs duplication with --with-gss.
When krb5-config was found, MUTT_AM_PATH_GSSAPI included CFLAGS in
GSSAPI_CFLAGS and MUTTLIBS in GSSAPI_LIBS. However, configure.ac
afterwards sets:
CPPFLAGS="$CPPFLAGS $GSSAPI_CFLAGS"
MUTTLIBS="$MUTTLIBS $GSSAPI_LIBS"
This caused the flags and libs to be duplicated.
Kevin McCarthy [Thu, 30 Jun 2016 01:58:48 +0000 (18:58 -0700)]
Include ncurses tinfo library if found.
Thanks to Fabian Groffen for reporting this issue and providing a
couple possible patches. From Fabian's report:
For some time now, ncurses can be built in a mode where the low level
terminfo functionality lives in a separate lib called libtinfo.
Because some people do, this means Mutt needs to include this
library in that case to avoid linking errors [...]
Kevin McCarthy [Tue, 24 May 2016 19:08:46 +0000 (12:08 -0700)]
Fix infinite loop when help is bound to a named key combination.
Commit a07e8215a0ef introduced a bug in km_error_key, which is called
when an unbound key is pressed.
If help is bound to a sequence containing named keys (e.g. <esc>), the
raw (untokenized) string would be pushed back into the unget buffer.
This could lead to an infinite loop of unbound key presses triggering
more unbound keys being put into the unget buffer.
Change km_error_key to tokenize the string before putting it in the unget buffer.
Much thanks to Jiri Bohac for his bug report, analysis, and initial patch!
Kevin McCarthy [Tue, 10 May 2016 16:42:27 +0000 (09:42 -0700)]
Set COLUMNS to MuttIndexWindow->cols in mutt_create_filter_fd. (closes #3837)
This allows filters to automatically (or via a command line argument)
adjust to the width of the pager/index. This is even more important
with the sidebar, since the width of the pager is smaller than the
terminal width.
Thanks to Vincent Lefèvre for his helpful information and suggestions,
and to Richard Russon for the initial patches.
Richard Russon [Thu, 23 Jun 2016 14:57:32 +0000 (15:57 +0100)]
fix sidebar/mail_check painting problem
The bug was triggered when $mail_check was set to 0.
When drawing the status line, the Sidebar lied about its size to
workaround a bug in mutt_FormatString(). Whilst in that function the
Sidebar was redrawn.
The Sidebar got confused over whether it should be visible or not and
promptly vanished.
Darshit Shah [Wed, 22 Jun 2016 05:23:05 +0000 (07:23 +0200)]
Fix compiler warnings due to always true condition
BUFFY declares path as a char array. Hence, p->path will always resolve
to a valid array location making the check redundant. It causes a
compiler warning. Hence, remove the redundant check to silence the
warning.
Richard Russon [Thu, 16 Jun 2016 14:44:45 +0000 (15:44 +0100)]
merge: notmuch
* Fix IDNA functions for systems without iconv.
* Fix mutt_protect() when INLINE is set. (closes #3828)
* Create a wrapper sys_socket.h to work around Solaris namespace issues. (closes #3833)
* automatic post-release commit for mutt-1.6.1
* reduce the frequency of mailbox checks
Richard Russon [Thu, 16 Jun 2016 14:42:34 +0000 (15:42 +0100)]
merge: sidebar
* fix cursor position after sidebar redraw
* Add sidebar_format flag '%n' to display 'N' on new mail.
* Fix the case of messages in OPS.MIX and OPS.SIDEBAR
Kevin McCarthy [Wed, 27 Apr 2016 20:08:52 +0000 (13:08 -0700)]
Create a wrapper sys_socket.h to work around Solaris namespace issues. (closes #3833)
Solaris includes "sys/stream.h" inside their "sys/socket.h". This
include file adds many non-reserved macros to Mutt's namespace, two of
which conflict with existing Mutt macros.
The simplest fix would be to rename those macros in Mutt, however this
will cause difficulty with out-of-tree patches. This fix creates a
wrapper include file that preserves those existing macros and prevents
the Solaris values from entering Mutt's namespace.
Kevin McCarthy [Sun, 10 Apr 2016 23:02:06 +0000 (16:02 -0700)]
Fix mutt_protect() when INLINE is set. (closes #3828)
The oppenc changes allow security bits to be set even when not
encrypting or signing (for instance, OPPENCRYPT and INLINE).
mutt_protect() assumed that if INLINE is set, then either ENCRYPT or
SIGN must also be set. Specifically, it would end up inline-signing
the message even though neither was set.
Ensure mutt_protect() is a noop if neither SIGN or ENCRYPT are set.
In ci_send_message(), check for sign or encrypt before calling the
crypt_get_keys() / mutt_protect() block, and also in the fcc section
(since clear_content would be NULL if not).
The second change to the fcc part is somewhat redundant, but better to
be explicit and avoid the case where the subtype is somehow
"encrypted" or "signed" even though msg->security wasn't set thus.
Kevin McCarthy [Tue, 5 Apr 2016 21:31:36 +0000 (14:31 -0700)]
Fix IDNA functions for systems without iconv.
The IDNA changes for SMTPUTF8 support introduced a bug for systems
without iconv. For those systems, the local<->intl functions would
return an error due to the charset conversion failing.
Change mutt_idna.c back to being conditionally compiled, but this time
based on HAVE_ICONV. If there is no iconv, stub out the functions in
mutt_idna.h.
Richard Russon [Wed, 15 Jun 2016 15:47:22 +0000 (16:47 +0100)]
fix index_format truncation problem
mutt_wstr_trunc() didn't take index coloring into account when measuring a
string's length. When combined with a soft-fill '%* ' in the index_format it
lead to formatting problems.
Richard Russon [Sat, 11 Jun 2016 15:30:09 +0000 (16:30 +0100)]
merge: sidebar
* sync whitespace to mutt/default
* rename sidebar functions sb_* -> mutt_sb_*
* bug-fixes from mutt/default
* Setting $sidebar_width to more than 128 would cause bad things to happen.
* fix reflow properly
* temporarily disable $sidebar_refresh_time
* Fix alignment in the compose menu.
* Fix sidebar buffy stats updating on mailbox close.
Kevin McCarthy [Mon, 6 Jun 2016 01:05:41 +0000 (18:05 -0700)]
Fix sidebar buffy stats updating on mailbox close.
Move the mutt_sb_set_buffystats() call from mx_fastclose_mailbox() to
the bottom of mx_close_mailbox(). Append-only mailboxes don't have
msgcount set, so fastclose was the wrong place to be doing these
updates.
Richard Russon [Thu, 9 Jun 2016 19:06:10 +0000 (12:06 -0700)]
Fix alignment in the compose menu.
Several of the compose-panel labels didn't use the TITLE_FMT to align
themselves. This causes formatting problems when the width is changed,
e.g. by the NNTP patch.
Richard Russon [Thu, 9 Jun 2016 13:01:42 +0000 (14:01 +0100)]
temporarily disable $sidebar_refresh_time
Limiting the refresh frequency of sidebar updates was interfering with
other Mutt behaviour. Upstream, Mutt is changing how refresh is
handled. I'll adopt those changes when they're finished.
Mike Frysinger [Tue, 31 May 2016 20:17:41 +0000 (21:17 +0100)]
separate key bindings for <return> and <enter>
Split up <enter> (ctrl+j) and <return> (ctrl+m) into different bindings so
people can map them differently. The default behavior is unchanged as we
map them both to the same function.
Richard Russon [Sun, 22 May 2016 22:29:18 +0000 (23:29 +0100)]
merge: keywords
* Add reentrant hash_walk() function for iterating down a hash table.
* Adds capability to edit x-labels inside mutt, and to sort by label.
* Adds label completion.
* Unify label/keyword handling.
* Permit tab completion of pattern expressions with ~y (labels).
* add docs
* add ident to PATCHES
* doc: check for installed patches
* fix build warning
Richard Russon [Sun, 22 May 2016 15:26:11 +0000 (16:26 +0100)]
merge: sidebar
* bump dependency to 1.6.1
* Set COLUMNS to MuttIndexWindow->cols in mutt_create_filter_fd. (closes #3837)
* fix format=flowed text when the sidebar is enabled
* doc: css for sidebar intro
* doc: check for installed patches