]> granicus.if.org Git - php/log
php
7 years agoMerge branch 'PHP-7.1'
Anatol Belski [Mon, 24 Apr 2017 20:14:30 +0000 (22:14 +0200)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  don't backup older deps after upgrades
  update SDK version for AppVeyor

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Anatol Belski [Mon, 24 Apr 2017 20:12:26 +0000 (22:12 +0200)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  don't backup older deps after upgrades
  update SDK version for AppVeyor

7 years agodon't backup older deps after upgrades
Anatol Belski [Mon, 24 Apr 2017 20:10:32 +0000 (22:10 +0200)]
don't backup older deps after upgrades

7 years agoupdate SDK version for AppVeyor
Anatol Belski [Mon, 24 Apr 2017 20:08:45 +0000 (22:08 +0200)]
update SDK version for AppVeyor

7 years agoprefer OpenSSL 1.1 with 7.2 as that's what is default
Anatol Belski [Mon, 24 Apr 2017 16:39:04 +0000 (18:39 +0200)]
prefer OpenSSL 1.1 with 7.2 as that's what is default

7 years ago[ci skip] more upgrading notes
Anatol Belski [Mon, 24 Apr 2017 16:14:10 +0000 (18:14 +0200)]
[ci skip] more upgrading notes

7 years ago[ci skip] move item to right section
Anatol Belski [Mon, 24 Apr 2017 16:01:56 +0000 (18:01 +0200)]
[ci skip] move item to right section

7 years agoMerge branch 'PHP-7.1'
Jakub Zelenka [Mon, 24 Apr 2017 16:14:22 +0000 (17:14 +0100)]
Merge branch 'PHP-7.1'

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Jakub Zelenka [Mon, 24 Apr 2017 16:12:55 +0000 (17:12 +0100)]
Merge branch 'PHP-7.0' into PHP-7.1

7 years agoFix bug #73833 (null character not allowed in openssl_pkey_get_private)
Jakub Zelenka [Mon, 24 Apr 2017 16:11:36 +0000 (17:11 +0100)]
Fix bug #73833 (null character not allowed in openssl_pkey_get_private)

7 years agoRemove --enable-one-shot as it's dead already for long
Anatol Belski [Mon, 24 Apr 2017 15:54:50 +0000 (17:54 +0200)]
Remove --enable-one-shot as it's dead already for long

The usable option is --with-mp, the implementation is available since 7.0.

7 years agoMerge branch 'PHP-7.1'
Anatol Belski [Mon, 24 Apr 2017 14:22:57 +0000 (16:22 +0200)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  Support also no,shared configure arg vals by default

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Anatol Belski [Mon, 24 Apr 2017 14:22:16 +0000 (16:22 +0200)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  Support also no,shared configure arg vals by default

7 years agoSupport also no,shared configure arg vals by default
Anatol Belski [Mon, 24 Apr 2017 13:46:22 +0000 (15:46 +0200)]
Support also no,shared configure arg vals by default

This indirectly fixes bug #74398 where --with-extname is expected to be
configured shared with our default dependency package. With a non
default deps, it still can be enforced --with-extname=static

7 years agoMerge branch 'PHP-7.1'
Jakub Zelenka [Sun, 23 Apr 2017 20:07:31 +0000 (21:07 +0100)]
Merge branch 'PHP-7.1'

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Jakub Zelenka [Sun, 23 Apr 2017 20:06:45 +0000 (21:06 +0100)]
Merge branch 'PHP-7.0' into PHP-7.1

7 years agoAdd missing NEWS entries for 7.0.19
Jakub Zelenka [Sun, 23 Apr 2017 20:03:35 +0000 (21:03 +0100)]
Add missing NEWS entries for 7.0.19

7 years agoMerge branch 'PHP-7.1'
Anatol Belski [Sun, 23 Apr 2017 19:35:52 +0000 (21:35 +0200)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  extend zlib export required for the recent libpng

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Anatol Belski [Sun, 23 Apr 2017 19:34:31 +0000 (21:34 +0200)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  extend zlib export required for the recent libpng

7 years agoMerge branch 'PHP-7.1'
Jakub Zelenka [Sun, 23 Apr 2017 19:33:48 +0000 (20:33 +0100)]
Merge branch 'PHP-7.1'

7 years agoextend zlib export required for the recent libpng
Anatol Belski [Sun, 23 Apr 2017 19:27:34 +0000 (21:27 +0200)]
extend zlib export required for the recent libpng

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Jakub Zelenka [Sun, 23 Apr 2017 19:31:24 +0000 (20:31 +0100)]
Merge branch 'PHP-7.0' into PHP-7.1

7 years agoFix bug #73711 (Segfault in openssl_pkey_new when generating DSA or DH key)
Jakub Zelenka [Sun, 23 Apr 2017 19:30:14 +0000 (20:30 +0100)]
Fix bug #73711 (Segfault in openssl_pkey_new when generating DSA or DH key)

7 years agoyet one more export required from newer zlib
Anatol Belski [Sun, 23 Apr 2017 19:29:40 +0000 (21:29 +0200)]
yet one more export required from newer zlib

7 years agoMerge branch 'PHP-7.1'
Anatol Belski [Sun, 23 Apr 2017 19:29:04 +0000 (21:29 +0200)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  extend zlib export required for the recent libpng

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Anatol Belski [Sun, 23 Apr 2017 19:28:26 +0000 (21:28 +0200)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  extend zlib export required for the recent libpng

7 years agoextend zlib export required for the recent libpng
Anatol Belski [Sun, 23 Apr 2017 19:27:34 +0000 (21:27 +0200)]
extend zlib export required for the recent libpng

7 years agoAdd some 'New RM' instructions
Sara Golemon [Sun, 23 Apr 2017 19:20:41 +0000 (12:20 -0700)]
Add some 'New RM' instructions

7 years agoFix reflection tests in mysqli extension
Nikita Popov [Sat, 22 Apr 2017 21:57:00 +0000 (23:57 +0200)]
Fix reflection tests in mysqli extension

7 years agoMerge branch 'PHP-7.1'
Anatol Belski [Sat, 22 Apr 2017 20:42:05 +0000 (22:42 +0200)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  [ci skip] update NEWS
  [ci skip] update NEWS

7 years ago[ci skip] update NEWS
Anatol Belski [Sat, 22 Apr 2017 20:41:15 +0000 (22:41 +0200)]
[ci skip] update NEWS

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Anatol Belski [Sat, 22 Apr 2017 20:40:48 +0000 (22:40 +0200)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  [ci skip] update NEWS

7 years ago[ci skip] update NEWS
Anatol Belski [Sat, 22 Apr 2017 20:39:59 +0000 (22:39 +0200)]
[ci skip] update NEWS

7 years agoMerge branch 'PHP-7.1'
Anatol Belski [Sat, 22 Apr 2017 19:59:07 +0000 (21:59 +0200)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  #74337 pointer returned by php_stream_fopen_tmpfile not validated in memory.c

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Anatol Belski [Sat, 22 Apr 2017 19:58:10 +0000 (21:58 +0200)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  #74337 pointer returned by php_stream_fopen_tmpfile not validated in memory.c

7 years ago#74337 pointer returned by php_stream_fopen_tmpfile not validated in memory.c
Anton Serbulov [Fri, 14 Apr 2017 08:26:13 +0000 (15:26 +0700)]
#74337 pointer returned by php_stream_fopen_tmpfile not validated in memory.c

7 years agoMerge branch 'PHP-7.1'
Anatol Belski [Sat, 22 Apr 2017 16:35:10 +0000 (18:35 +0200)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  Fixed bug #74489 readline() immediately returns false in interactive console mode

7 years agoFixed bug #74489 readline() immediately returns false in interactive console mode
Anatol Belski [Sat, 22 Apr 2017 16:33:53 +0000 (18:33 +0200)]
Fixed bug #74489 readline() immediately returns false in interactive console mode

7 years agoDon't leak internal flags in reflection
Nikita Popov [Sat, 22 Apr 2017 14:44:20 +0000 (16:44 +0200)]
Don't leak internal flags in reflection

If someone complains, we may re-expose specific flags while also
adding corresponding class constants for them.

7 years agoFix reflection test after flag removal
Nikita Popov [Sat, 22 Apr 2017 14:31:28 +0000 (16:31 +0200)]
Fix reflection test after flag removal

Reflection is leaking internal flags...

7 years agoRemove the ZEND_ACC_CLONE flag
Nikita Popov [Sat, 22 Apr 2017 13:44:24 +0000 (15:44 +0200)]
Remove the ZEND_ACC_CLONE flag

This one is completely unused

7 years agoDocument which function flags are still free
Nikita Popov [Sat, 22 Apr 2017 13:42:57 +0000 (15:42 +0200)]
Document which function flags are still free

Also clearly separate method and class flags.

7 years agoMerge branch 'PHP-7.1'
Joe Watkins [Thu, 20 Apr 2017 05:42:55 +0000 (06:42 +0100)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  Avoid exact floating point comparison

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Joe Watkins [Thu, 20 Apr 2017 05:42:44 +0000 (06:42 +0100)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  Avoid exact floating point comparison

7 years agoAvoid exact floating point comparison
Steve Walk [Tue, 18 Apr 2017 15:43:03 +0000 (08:43 -0700)]
Avoid exact floating point comparison

7 years agoMerge branch 'PHP-7.1'
Joe Watkins [Thu, 20 Apr 2017 05:39:37 +0000 (06:39 +0100)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  Update php_network.h

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Joe Watkins [Thu, 20 Apr 2017 05:39:26 +0000 (06:39 +0100)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  Update php_network.h

7 years agoUpdate php_network.h
Alexander Ilyin [Tue, 18 Apr 2017 09:44:34 +0000 (02:44 -0700)]
Update php_network.h

```
In file included from /usr/local/include/php/main/php_network.h:124:0,
                 from /var/www/html/php-ext-handlersocketi-0.0.1/hs_response.c:3:
/usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp]
 #warning redirecting incorrect #include <sys/poll.h> to <poll.h>
  ^
```

7 years agoMerge branch 'master' of git.php.net:/php-src
Xinchen Hui [Wed, 19 Apr 2017 09:18:19 +0000 (17:18 +0800)]
Merge branch 'master' of git.php.net:/php-src

* 'master' of git.php.net:/php-src:
  Enable more control over travis/compile.sh

7 years agoFixed hash val calculating
Xinchen Hui [Wed, 19 Apr 2017 09:15:34 +0000 (17:15 +0800)]
Fixed hash val calculating

7 years agoEnable more control over travis/compile.sh
Sara Golemon [Tue, 18 Apr 2017 18:27:19 +0000 (11:27 -0700)]
Enable more control over travis/compile.sh

This is also used by RM process to test the same things.
Allow generating build output (to a log file) and specifying
number of parallel jobs (rather than hard-code zero).

Leave all defaults as-is for Travis builds.

7 years agoFixed test
Xinchen Hui [Tue, 18 Apr 2017 04:50:14 +0000 (12:50 +0800)]
Fixed test

7 years agoImprove fix for #74456
Xinchen Hui [Tue, 18 Apr 2017 04:47:53 +0000 (12:47 +0800)]
Improve fix for #74456

7 years agoMerge branch 'PHP-7.1' of git.php.net:/php-src into PHP-7.1
Xinchen Hui [Mon, 17 Apr 2017 12:27:07 +0000 (20:27 +0800)]
Merge branch 'PHP-7.1' of git.php.net:/php-src into PHP-7.1

* 'PHP-7.1' of git.php.net:/php-src:
  Fix loop identification

7 years agoMerge branch 'PHP-7.1'
Xinchen Hui [Mon, 17 Apr 2017 12:26:57 +0000 (20:26 +0800)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  Fixed bug #74456 (Segmentation error while running a script in CLI mode)

7 years agoFixed bug #74456 (Segmentation error while running a script in CLI mode)
Xinchen Hui [Mon, 17 Apr 2017 12:24:39 +0000 (20:24 +0800)]
Fixed bug #74456 (Segmentation error while running a script in CLI mode)

Instead of make update_op1_by_const supports FETCH_LIST(CASE), I think
disable it is more safe for 7.1

7 years agoDrop dead zend_optimizer_lookup_cv() function
Nikita Popov [Mon, 17 Apr 2017 10:20:25 +0000 (12:20 +0200)]
Drop dead zend_optimizer_lookup_cv() function

7 years agoMerge branch 'PHP-7.1'
Nikita Popov [Mon, 17 Apr 2017 10:19:46 +0000 (12:19 +0200)]
Merge branch 'PHP-7.1'

7 years agoFix loop identification
Nikita Popov [Mon, 17 Apr 2017 10:17:32 +0000 (12:17 +0200)]
Fix loop identification

When assigning loop headers, we should treat already detected
loops as collapsed to their loop header, instead of ignoring them.

This fixes the loop header of BB2 in mandel2 if live-range CFG
splitting is enabled.

7 years agoMerge branch 'PHP-7.1'
Joe Watkins [Mon, 17 Apr 2017 07:12:12 +0000 (08:12 +0100)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  ext/gettext: respect passed in library directory for all checks

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Joe Watkins [Mon, 17 Apr 2017 07:12:02 +0000 (08:12 +0100)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  ext/gettext: respect passed in library directory for all checks

7 years agoext/gettext: respect passed in library directory for all checks
Michael Heimpold [Thu, 13 Apr 2017 20:43:26 +0000 (22:43 +0200)]
ext/gettext: respect passed in library directory for all checks

A directory given to configure by --with-gettext=dir is only
used within the very first AC_CHECK_LIB. This is because the
temporary modified LDFLAGS variable is reset too early.

This results in functions not detected properly.

The original issue and patch was reported for OpenWrt/LEDE
distribution by @Dimazhan at:
https://github.com/openwrt/packages/issues/4250

Signed-off-by: Michael Heimpold <mhei@heimpold.de>
7 years agoMerge branch 'PHP-7.1'
Joe Watkins [Mon, 17 Apr 2017 07:09:36 +0000 (08:09 +0100)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  Fixed bug #74080 Add datetime constant for RFC7231

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Joe Watkins [Mon, 17 Apr 2017 07:09:05 +0000 (08:09 +0100)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  Fixed bug #74080 Add datetime constant for RFC7231

7 years agoFixed bug #74080 Add datetime constant for RFC7231
Craig Duncan [Sat, 1 Apr 2017 16:56:31 +0000 (17:56 +0100)]
Fixed bug #74080 Add datetime constant for RFC7231

7 years agoMerge branch 'PHP-7.1'
Joe Watkins [Mon, 17 Apr 2017 06:58:34 +0000 (07:58 +0100)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  Fixed bug #74439 Wrong reflection on the Locale methods

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Joe Watkins [Mon, 17 Apr 2017 06:57:07 +0000 (07:57 +0100)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  Fixed bug #74439 Wrong reflection on the Locale methods

7 years agoFixed bug #74439 Wrong reflection on the Locale methods
Fabien Villepinte [Fri, 14 Apr 2017 12:08:26 +0000 (14:08 +0200)]
Fixed bug #74439 Wrong reflection on the Locale methods

7 years agoUpdate to SQLite 3.18.0
Christoph M. Becker [Sun, 16 Apr 2017 14:17:09 +0000 (16:17 +0200)]
Update to SQLite 3.18.0

7 years agoMerge branch 'PHP-7.1'
Anatol Belski [Sun, 16 Apr 2017 12:56:51 +0000 (14:56 +0200)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  [ci skip] update NEWS
  [ci skip] update NEWS

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Anatol Belski [Sun, 16 Apr 2017 12:55:51 +0000 (14:55 +0200)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  [ci skip] update NEWS

7 years ago[ci skip] update NEWS
Anatol Belski [Sun, 16 Apr 2017 12:55:31 +0000 (14:55 +0200)]
[ci skip] update NEWS

7 years ago[ci skip] update NEWS
Anatol Belski [Sun, 16 Apr 2017 12:54:19 +0000 (14:54 +0200)]
[ci skip] update NEWS

7 years agoMerge branch 'PHP-7.1'
Anatol Belski [Sat, 15 Apr 2017 17:37:12 +0000 (19:37 +0200)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  improve/fix error handling

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Anatol Belski [Sat, 15 Apr 2017 17:35:13 +0000 (19:35 +0200)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  improve/fix error handling

7 years agoimprove/fix error handling
Anatol Belski [Sat, 15 Apr 2017 17:30:30 +0000 (19:30 +0200)]
improve/fix error handling

GetLastError() should not be called, if the function didn't fail.

7 years agoMerge branch 'PHP-7.1'
Anatol Belski [Sat, 15 Apr 2017 16:29:37 +0000 (18:29 +0200)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  fix error handling

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Anatol Belski [Sat, 15 Apr 2017 16:25:31 +0000 (18:25 +0200)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  fix error handling

7 years agofix error handling
Anatol Belski [Sat, 15 Apr 2017 16:14:25 +0000 (18:14 +0200)]
fix error handling

7 years agoMerge branch 'PHP-7.1'
Nikita Popov [Sat, 15 Apr 2017 16:15:45 +0000 (18:15 +0200)]
Merge branch 'PHP-7.1'

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Nikita Popov [Sat, 15 Apr 2017 16:15:33 +0000 (18:15 +0200)]
Merge branch 'PHP-7.0' into PHP-7.1

7 years agoImprove accuracy of opline lineno information
Nikita Popov [Sat, 15 Apr 2017 16:06:42 +0000 (18:06 +0200)]
Improve accuracy of opline lineno information

If compile_var() was used instead of compile_expr() we did not
update the current lineno.

7 years agoexport the main thread info
Anatol Belski [Sat, 15 Apr 2017 12:28:58 +0000 (14:28 +0200)]
export the main thread info

7 years agoMerge branch 'PHP-7.1'
Anatol Belski [Sat, 15 Apr 2017 15:30:43 +0000 (17:30 +0200)]
Merge branch 'PHP-7.1'

* PHP-7.1:
  extend error map

7 years agoextend error map
Anatol Belski [Sat, 15 Apr 2017 15:27:45 +0000 (17:27 +0200)]
extend error map

7 years agoMerge branch 'PHP-7.1'
Nikita Popov [Sat, 15 Apr 2017 10:36:02 +0000 (12:36 +0200)]
Merge branch 'PHP-7.1'

7 years agoMerge branch 'PHP-7.0' into PHP-7.1
Nikita Popov [Sat, 15 Apr 2017 10:35:53 +0000 (12:35 +0200)]
Merge branch 'PHP-7.0' into PHP-7.1

7 years agoFix compact_literals of INIT_METHOD_CALL with CONST op1
Nikita Popov [Sat, 15 Apr 2017 10:35:09 +0000 (12:35 +0200)]
Fix compact_literals of INIT_METHOD_CALL with CONST op1

7 years agoRemove leftover code for generator stack page handling
Nikita Popov [Sat, 15 Apr 2017 10:08:09 +0000 (12:08 +0200)]
Remove leftover code for generator stack page handling

7 years agoInitialize retval in INCLUDE_OR_EVAL
Nikita Popov [Sat, 15 Apr 2017 10:04:56 +0000 (12:04 +0200)]
Initialize retval in INCLUDE_OR_EVAL

In case the eval'd code throws.

7 years agoUpdate step about uploading packages to downloads.php.net
Sara Golemon [Fri, 14 Apr 2017 23:43:01 +0000 (16:43 -0700)]
Update step about uploading packages to downloads.php.net

At some point this changed from a per-user specific mapping
to a standard ~$USER mapping.

7 years agoMerge branch 'PHP-7.1'
Nikita Popov [Fri, 14 Apr 2017 23:40:59 +0000 (01:40 +0200)]
Merge branch 'PHP-7.1'

7 years agoImprove fix for bug #74442
Nikita Popov [Fri, 14 Apr 2017 23:39:33 +0000 (01:39 +0200)]
Improve fix for bug #74442

Make the check less conservative to be consistent with the other
cases.

7 years agoFixed bug #74444: multiple catch freezes in some cases
David Matejka [Fri, 14 Apr 2017 22:20:06 +0000 (00:20 +0200)]
Fixed bug #74444: multiple catch freezes in some cases

zend_emit_jump() may reallocate, so reload the opline.

7 years agoCredit goes to Eric Norris for this one
Rasmus Lerdorf [Fri, 14 Apr 2017 22:48:24 +0000 (15:48 -0700)]
Credit goes to Eric Norris for this one

7 years agoCredit goes to Eric Norris for this one
Rasmus Lerdorf [Fri, 14 Apr 2017 22:48:24 +0000 (15:48 -0700)]
Credit goes to Eric Norris for this one

7 years agoMerge branch 'PHP-7.1'
Nikita Popov [Fri, 14 Apr 2017 20:20:48 +0000 (22:20 +0200)]
Merge branch 'PHP-7.1'

7 years agoFixed bug #74442
Nikita Popov [Fri, 14 Apr 2017 20:20:32 +0000 (22:20 +0200)]
Fixed bug #74442

7 years agoMerge branch 'PHP-7.1'
Nikita Popov [Fri, 14 Apr 2017 20:04:07 +0000 (22:04 +0200)]
Merge branch 'PHP-7.1'

7 years agoFixed bug #74431
Nikita Popov [Fri, 14 Apr 2017 19:58:35 +0000 (21:58 +0200)]
Fixed bug #74431

If the last instruction in a block is a NOP, then `new_opline`
here won't be a copy of `opline`, it will be a copy of the last
non-NOP opline. Avoid performing a spurious update by explicitly
checking for NOP.