]>
granicus.if.org Git - php/log
Xinchen Hui [Sat, 9 May 2020 04:28:49 +0000 (12:28 +0800)]
drop use of extract_epi16
Xinchen Hui [Fri, 8 May 2020 08:24:07 +0000 (16:24 +0800)]
Use SSE2 instructions do url_encode
Dmitry Stogov [Fri, 8 May 2020 07:07:55 +0000 (10:07 +0300)]
cleanup
Dmitry Stogov [Thu, 7 May 2020 22:24:02 +0000 (01:24 +0300)]
Change parameter meaning.
Dmitry Stogov [Thu, 7 May 2020 21:56:03 +0000 (00:56 +0300)]
Use proper "cost"
Dmitry Stogov [Thu, 7 May 2020 21:48:17 +0000 (00:48 +0300)]
Avoid loop throgh side_exit from the first trace instruction.
Dmitry Stogov [Thu, 7 May 2020 20:41:48 +0000 (23:41 +0300)]
Fixed tracing JIT for CALL VM without global register variables
Nikita Popov [Thu, 7 May 2020 16:50:42 +0000 (18:50 +0200)]
Ensure ctype_string is NULL for C locale
We already document that this is the case, but currently it's only
true if setlocale() has not been called. Make sure ctype_string is
always NULL, even with an explicit "C" locale call, so we can
more efficiently check whether we are in the "C" locale.
Closes GH-5542.
Nikita Popov [Thu, 7 May 2020 19:18:00 +0000 (21:18 +0200)]
Fix test file encoding
The mb_http_input_pass.phpt was intended to use the same encoding
as mb_http_input.phpt, not UTF-8.
Dmitry Stogov [Thu, 7 May 2020 19:01:59 +0000 (22:01 +0300)]
More accurate tracing JIT for RETURN with unknown return address
Nikita Popov [Thu, 7 May 2020 16:45:03 +0000 (18:45 +0200)]
Rename locale_string to ctype_string
To make it more obvious that this only refers to the LC_CTYPE
locale.
Nikita Popov [Thu, 7 May 2020 16:36:48 +0000 (18:36 +0200)]
Remove redundant htmlentities() tests
Test 04 and 15 are the same as 02 and 03, just for different
encodings. They don't add value, but their execution depends
on available locales, so they're easy to miss...
Xinchen Hui [Thu, 7 May 2020 15:03:25 +0000 (23:03 +0800)]
Folder marks
Nikita Popov [Thu, 7 May 2020 14:51:05 +0000 (16:51 +0200)]
Really fix test case
Christoph M. Becker [Thu, 7 May 2020 14:47:38 +0000 (16:47 +0200)]
Fix test case
Tyson Andre [Thu, 7 May 2020 13:14:15 +0000 (09:14 -0400)]
Evaluate str_starts_with and str_ends_with on constants
When both arguments are strings,
this is guaranteed not to emit notices.
Closes GH-5539
Nikita Popov [Thu, 7 May 2020 13:18:52 +0000 (15:18 +0200)]
Don't respect mbstring.internal_encoding in htmlentities()
htmlentities() has nothing to do with mbstring and should not
depend on its ini settings. It should only respect the global
default_charset and internal_encoding settings. This is exactly
why they were introduced...
Nikita Popov [Thu, 7 May 2020 13:46:08 +0000 (15:46 +0200)]
Add quiet parameter to internal HTML entities API
In some places, we need to make sure that no warnings are thrown
due to unknown encoding. The error reporting code tried to avoid
this by determining a "safe charset", but this introduces subtle
discrepancies in which charset is picked (normally
internal_encoding takes precedence). Avoid this by suppressing
the warning in the first place.
While here, use the fallback logic to print error messages with
substitution characters more consistently, to avoid skipping
parts of the error message entirely.
Nikita Popov [Thu, 7 May 2020 12:58:24 +0000 (14:58 +0200)]
Clean up determine_charset() implementation
And drop code related to locale-based charset guessing,
which is no longer in use.
Nikita Popov [Thu, 7 May 2020 12:43:36 +0000 (14:43 +0200)]
Throw warning if invalid internal_encoding ini is specified
Dmitry Stogov [Thu, 7 May 2020 09:49:01 +0000 (12:49 +0300)]
Prevent taking side traces for exceptional cases. Always exit to VM interpreter.
Nikita Popov [Thu, 7 May 2020 09:36:57 +0000 (11:36 +0200)]
Remove no_language from mbfl_string
This is not actually used for anything and just causes confusion.
Nikita Popov [Thu, 7 May 2020 08:45:49 +0000 (10:45 +0200)]
Only allow "pass" as input/output encoding
"pass" is not a real encoding, it just means "don't perform any
conversion". Using it as an internal encoding or passing it to
any of the mbstring() function will not work (and on master commonly
assert).
Máté Kocsis [Thu, 7 May 2020 08:21:44 +0000 (10:21 +0200)]
Rename the recently introduced Sysvsem class to SysvSemaphore
Nikita Popov [Thu, 7 May 2020 08:15:57 +0000 (10:15 +0200)]
Return false from failed mb_convert_variables()
If we fail to detect the encoding return false, just like
mb_convert_encoding() does, and the implementation here clearly
intended. Previously the "pass" pseudo-incoding was returned.
Christoph M. Becker [Thu, 7 May 2020 07:19:34 +0000 (09:19 +0200)]
Enable test on Windows
Xinchen Hui [Thu, 7 May 2020 06:16:02 +0000 (14:16 +0800)]
Fixed false alarm about tmp_name maybe unitialized
Dmitry Stogov [Thu, 7 May 2020 06:05:33 +0000 (09:05 +0300)]
Fixed comment
Nikita Popov [Wed, 6 May 2020 20:55:03 +0000 (22:55 +0200)]
Fix assertion failure when failing to detect encoding
Looks like prior to 7.3 this just passed the original string
through. Since 7.3 it returns false. Let's stick with that
behavior.
Dmitry Stogov [Wed, 6 May 2020 20:16:45 +0000 (23:16 +0300)]
Avoid Program Counter guard in side trace started from Fake Init Fcall guard.
George Peter Banyard [Sat, 2 May 2020 22:35:13 +0000 (00:35 +0200)]
Use int|string Fast ZPP macro in Reflection
Moreover, throw a more appropriate ValueError in case the integer
position provided is less than 0.
Closes GH-5513
Dmitry Stogov [Wed, 6 May 2020 19:27:38 +0000 (22:27 +0300)]
Initial support for IS_INDIRECT. Avoid type guards for IS_INDIRECT.
Máté Kocsis [Wed, 6 May 2020 07:26:48 +0000 (09:26 +0200)]
Promote warning to exception in ZipArchive::extractTo()
Closes GH-5516
Máté Kocsis [Sun, 3 May 2020 11:19:44 +0000 (13:19 +0200)]
Fix UNKNOWN default values in ext/spl
Máté Kocsis [Sun, 3 May 2020 11:00:30 +0000 (13:00 +0200)]
Fix UNKNOWN default values in ext/sqlite3
Máté Kocsis [Sun, 3 May 2020 10:58:02 +0000 (12:58 +0200)]
Fix UNKNOWN default values in ext/xml
Máté Kocsis [Sun, 3 May 2020 10:18:55 +0000 (12:18 +0200)]
Fix UNKNOWN default values in ext/xsl
Máté Kocsis [Sun, 3 May 2020 09:49:31 +0000 (11:49 +0200)]
Fix UNKNOWN default values in ext/zip
Máté Kocsis [Sun, 3 May 2020 09:41:32 +0000 (11:41 +0200)]
Fix ZPP order in ext/zip
George Peter Banyard [Tue, 5 May 2020 22:45:42 +0000 (00:45 +0200)]
Drop BF_ASM constant as it's always 0
Closes GH-5531
Christoph M. Becker [Wed, 6 May 2020 15:25:02 +0000 (17:25 +0200)]
Remove out-dated comments
Máté Kocsis [Fri, 1 May 2020 12:00:19 +0000 (14:00 +0200)]
Convert resource to object in ext/sysvsem
Closes GH-5508
Dmitry Stogov [Wed, 6 May 2020 13:26:36 +0000 (16:26 +0300)]
Careful cleanup
Remi Collet [Wed, 6 May 2020 11:18:35 +0000 (13:18 +0200)]
add myself as enchant maintainer
Christoph M. Becker [Wed, 6 May 2020 11:16:50 +0000 (13:16 +0200)]
Fix enchant stub
Remi Collet [Wed, 6 May 2020 11:13:19 +0000 (13:13 +0200)]
enchant: bump license version
Nikita Popov [Wed, 6 May 2020 09:27:20 +0000 (11:27 +0200)]
Add zend_array_release() function
To complement zend_string_release() and zend_object_release().
Nikita Popov [Wed, 6 May 2020 07:42:58 +0000 (09:42 +0200)]
Revert "Move declaration at top of the block"
This reverts commit
b56f20385089703de7a3c9d89a9de4f9d14f56a3 .
We use C99 now, this is not needed anymore.
Xinchen Hui [Wed, 6 May 2020 06:01:56 +0000 (14:01 +0800)]
Move declaration at top of the block
George Peter Banyard [Tue, 5 May 2020 20:12:31 +0000 (22:12 +0200)]
Use correct variable
This seems to stem from a copy paste, however there is no object variable in this function
Máté Kocsis [Sat, 2 May 2020 13:25:25 +0000 (15:25 +0200)]
Fix UNKNOWN default values in various extensions
Closes GH-5514
Nikita Popov [Wed, 1 Apr 2020 08:25:22 +0000 (10:25 +0200)]
Make numeric operations on resources, arrays and objects type errors
RFC: https://wiki.php.net/rfc/arithmetic_operator_type_checks
Closes GH-5331.
William Hudgins [Tue, 5 May 2020 13:57:39 +0000 (15:57 +0200)]
Add str_starts_with() and str_ends_with()
RFC: https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions
Closes GH-5300.
Christoph M. Becker [Tue, 5 May 2020 09:41:31 +0000 (11:41 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix #79566: Private SHM is not private on Windows
Christoph M. Becker [Tue, 5 May 2020 09:39:38 +0000 (11:39 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix #79566: Private SHM is not private on Windows
Christoph M. Becker [Tue, 5 May 2020 07:31:17 +0000 (09:31 +0200)]
Fix #79566: Private SHM is not private on Windows
We map the POSIX semantics of `IPC_PRIVATE` by creating unnamed file
mapping objects on Windows. While that is not particularly useful for
ext/shmop, which is the only bundled extension which uses `shmget()`,
it may be useful for external extensions.
Nikita Popov [Mon, 4 May 2020 21:41:39 +0000 (23:41 +0200)]
Fix mbfl default allocators
Forgot to remove the persistent allocators from here.
Nikita Popov [Mon, 4 May 2020 21:17:54 +0000 (23:17 +0200)]
Spec mbfl allocators as infallible
And remove all NULL checks.
Nikita Popov [Mon, 4 May 2020 21:10:17 +0000 (23:10 +0200)]
Remove persistent allocators from libmbfl
These functions are not used, and I don't think we have any plans
to ever use them.
Christoph M. Becker [Mon, 4 May 2020 21:02:00 +0000 (23:02 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix #79561: dns_get_record() fails with DNS_ALL
Christoph M. Becker [Mon, 4 May 2020 21:00:27 +0000 (23:00 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix #79561: dns_get_record() fails with DNS_ALL
Christoph M. Becker [Mon, 4 May 2020 14:51:51 +0000 (16:51 +0200)]
Fix #79561: dns_get_record() fails with DNS_ALL
Since Windows has its own definitions of the `PHP_DNS_*` macros, we
have to use these when registering the PHP constants.
AllenJB [Mon, 4 May 2020 18:24:06 +0000 (20:24 +0200)]
Change the default PDO error mode to exceptions
According to <https://www.php.net/manual/en/pdo.error-handling.php>.
Nikita Popov [Mon, 4 May 2020 17:14:12 +0000 (19:14 +0200)]
Perform isupper check using sse2 as well
Rather than just vectorizing the lowering, also vectorize the
check for uppercase characters, using the same method.
Nikita Popov [Mon, 4 May 2020 14:30:34 +0000 (16:30 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fixed bug #79548
Nikita Popov [Mon, 4 May 2020 14:27:45 +0000 (16:27 +0200)]
Fixed bug #79548
When duplicating user functions with static variables, make sure
that we init a new map ptr slot for the static variables.
Nikita Popov [Mon, 4 May 2020 13:24:23 +0000 (15:24 +0200)]
Extract one more function from proc_open() implementation
Alex Dowad [Fri, 1 May 2020 11:03:16 +0000 (13:03 +0200)]
Clean up proc_open() implementation
Closes GH-5507.
Nikita Popov [Mon, 4 May 2020 12:59:35 +0000 (14:59 +0200)]
Remove unused is_persistent flag
I dropped the assignment to it before, but did not drop the
struct member.
Nikita Popov [Mon, 4 May 2020 12:52:42 +0000 (14:52 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fixed bug #79535
Nikita Popov [Mon, 4 May 2020 12:52:18 +0000 (14:52 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fixed bug #79535
Nikita Popov [Mon, 4 May 2020 12:50:31 +0000 (14:50 +0200)]
Fixed bug #79535
We did not allocate a cache slot for FETCH_CLASS. This is already
fixed on newer PHP versions.
Nikita Popov [Mon, 4 May 2020 12:35:33 +0000 (14:35 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix i386 build on Azure
Nikita Popov [Mon, 4 May 2020 10:16:45 +0000 (12:16 +0200)]
Fix i386 build on Azure
Disabling postgresql entirely for now, because I can't figure out
how to fix it. Something broke big time with i386 packages on
Azure pipelines.
George Peter Banyard [Sun, 3 May 2020 12:09:37 +0000 (14:09 +0200)]
Use ZPP int|string and add ValueError for Windows codepages
Closes GH-5517
Christoph M. Becker [Mon, 4 May 2020 09:52:01 +0000 (11:52 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Add basic sapi_windows_cp_conv() test
Christoph M. Becker [Mon, 4 May 2020 09:50:50 +0000 (11:50 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Add basic sapi_windows_cp_conv() test
Christoph M. Becker [Mon, 4 May 2020 09:46:54 +0000 (11:46 +0200)]
Add basic sapi_windows_cp_conv() test
This function is lacking any tests so far.
Christoph M. Becker [Mon, 4 May 2020 09:25:28 +0000 (11:25 +0200)]
Use libenchant2 if available on Windows
This is basically the same as commit
3427545 [1], but for Windows.
[1] <http://git.php.net/?p=php-src.git;a=commitdiff;h=
342754575237da912874f781a24eefe76434ce5a >
Remi Collet [Mon, 4 May 2020 06:27:31 +0000 (08:27 +0200)]
Use libenchant-2 when available
Christoph M. Becker [Sat, 2 May 2020 14:57:24 +0000 (16:57 +0200)]
Fix #79467: data:// wrappers are writable
Despite the docs claiming that data: wrappers would not be writable[1],
they are implemented as writing to a memory stream. That does not seem
to be particularly sensible, so we disallow writing altogether.
[1] <https://www.php.net/manual/en/wrappers.data.php#refsect1-wrappers.data-options>
George Peter Banyard [Mon, 27 Apr 2020 18:30:07 +0000 (20:30 +0200)]
Use ZPP check for string|int|null arguments in array_column()
George Peter Banyard [Fri, 24 Apr 2020 13:35:03 +0000 (15:35 +0200)]
Add Fast ZPP string|int type check
Christoph M. Becker [Sat, 2 May 2020 14:28:18 +0000 (16:28 +0200)]
Don't raise bogus warning if writing completely failed
Nikita Popov [Sat, 2 May 2020 13:33:29 +0000 (15:33 +0200)]
Remove is_persistent flag from proc_open implementation
We don't support persistent proc_open handles and have no plan
to suppor them. The mixture of persistent and non-persistent
allocations functions in this code is somewhat confusing to read.
Máté Kocsis [Fri, 1 May 2020 19:45:30 +0000 (21:45 +0200)]
Convert UNKNOWN default values to null in ext/date
Closes GH-5509
Máté Kocsis [Fri, 1 May 2020 18:49:55 +0000 (20:49 +0200)]
Convert UNKNOWN default values to null in ext/calendar
Máté Kocsis [Fri, 1 May 2020 18:49:47 +0000 (20:49 +0200)]
Convert UNKNOWN default values to null in ext/bcmath
Tyson Andre [Mon, 18 Feb 2019 16:14:22 +0000 (11:14 -0500)]
Fix miscellaneous typos in code comments/var names
Closes GH-5501
Máté Kocsis [Fri, 1 May 2020 11:14:54 +0000 (13:14 +0200)]
Remove the deprecated is_real() function
Closes GH-5506
Christoph M. Becker [Fri, 1 May 2020 10:42:09 +0000 (12:42 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix #79528: Different object of the same xml between 7.4.5 and 7.4.4
Christoph M. Becker [Fri, 1 May 2020 10:38:03 +0000 (12:38 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix #79528: Different object of the same xml between 7.4.5 and 7.4.4
Christoph M. Becker [Fri, 1 May 2020 10:19:32 +0000 (12:19 +0200)]
Fix #79528: Different object of the same xml between 7.4.5 and 7.4.4
Revert "Fix #61597: SXE properties may lack attributes and content"
This reverts commit
7c081db885756d7b176a55b90b8746f664d1e042 .
Alex Dowad [Wed, 22 Apr 2020 18:52:16 +0000 (20:52 +0200)]
Avoid spurious failures of MySQL INSERT packet overflow test
This test creates a MySQL table called 'test'. In several cases, I have seen a spurious
test failure (in CI) with an error message saying: "table 'test' already exists".
It may be that another test had used a table with the same name and not cleaned it out
correctly. Or maybe we have multiple tests running in parallel in some CI environments,
or the same test DB being used for multiple runs of the test suite.
In any case, change the table name so it is exclusive to this test case only. Also, if
the test table exists at the beginning of the test, drop it.
Closes GH-5479
Alex Dowad [Wed, 22 Apr 2020 18:45:25 +0000 (20:45 +0200)]
Try to make regression test for Bug #69900 consistent
It has been observed that in rare cases, this regression test has spurious failures in CI.
Try increasing the threshold for failure a bit and see if this makes it pass consistently.
Tyson Andre [Thu, 30 Apr 2020 23:36:21 +0000 (19:36 -0400)]
Fix other typos in param name/code comments
Closes GH-5502
Tyson Andre [Thu, 30 Apr 2020 23:40:54 +0000 (19:40 -0400)]
[skip ci] Fix a typo in UPGRADING
Confirmed that php_zip.c checks for `"enc_password"`
Closes GH-5503
Dmitry Stogov [Thu, 30 Apr 2020 14:07:35 +0000 (17:07 +0300)]
Better handling of IS_UNDEF variables
Dmitry Stogov [Thu, 30 Apr 2020 12:32:01 +0000 (15:32 +0300)]
Replace ZEND_ASSERT() by conditional compilation abort.
Prevent endless loop through ESCAPE code.
Xinchen Hui [Tue, 28 Apr 2020 03:33:02 +0000 (11:33 +0800)]
Use ascii lowercase if locale is default C