]> granicus.if.org Git - postgresql/log
postgresql
17 years agoRemove last line of patch license, per Zeugswetter Andreas:
Bruce Momjian [Mon, 19 Mar 2007 16:53:03 +0000 (16:53 +0000)]
Remove last line of patch license, per Zeugswetter Andreas:

"If the patch is not BSD-licensed, it will be rejected."

17 years agoFurther buildfarm experience shows that actually we can't run the plancache
Tom Lane [Mon, 19 Mar 2007 16:44:41 +0000 (16:44 +0000)]
Further buildfarm experience shows that actually we can't run the plancache
test in parallel with the rules test at all, because the former wants to
create a couple of temp views, which can sometimes show up in the latter's
output.  Let's try it in the next parallel group instead.

17 years agoFix 8.2 breakage of domains over array types, and add a regression test case
Tom Lane [Mon, 19 Mar 2007 16:30:32 +0000 (16:30 +0000)]
Fix 8.2 breakage of domains over array types, and add a regression test case
to cover it.  Per report from Anton Pikhteryev.

17 years agoAdd URL for:
Bruce Momjian [Mon, 19 Mar 2007 15:50:48 +0000 (15:50 +0000)]
Add URL for:

* Simplify ability to create partitioned tables
>   http://archives.postgresql.org/pgsql-hackers/2007-03/msg00375.php

17 years agoAdd URL for:
Bruce Momjian [Mon, 19 Mar 2007 15:24:17 +0000 (15:24 +0000)]
Add URL for:

* Allow sequential scans to take advantage of other concurrent
  sequential scans, also called "Synchronised Scanning"

  http://archives.postgresql.org/pgsql-hackers/2007-03/msg00415.php

17 years agoecpglib requires libpgport, per Andrew Dunstan
Magnus Hagander [Mon, 19 Mar 2007 09:34:09 +0000 (09:34 +0000)]
ecpglib requires libpgport, per Andrew Dunstan

17 years agoFix ecpg/preproc makefile for parallel builds: parser.o must depend
Tom Lane [Sun, 18 Mar 2007 17:57:34 +0000 (17:57 +0000)]
Fix ecpg/preproc makefile for parallel builds: parser.o must depend
on preproc.h, else make may try to build it before preproc.h is ready.
Per failures seen here and in buildfarm.

17 years agoCode cleanup: mark some variables with the "const" modifier, when they
Neil Conway [Sun, 18 Mar 2007 16:50:44 +0000 (16:50 +0000)]
Code cleanup: mark some variables with the "const" modifier, when they
are initialized with a string literal. Patch from Stefan Huehner.

17 years agoCode cleanup for function prototypes: change two K&R-style prototypes
Neil Conway [Sun, 18 Mar 2007 05:36:50 +0000 (05:36 +0000)]
Code cleanup for function prototypes: change two K&R-style prototypes
to ANSI-style, and change "()" -> "(void)". Patch from Stefan Huehner.

17 years agoSimplified sortby rule
Michael Meskes [Sat, 17 Mar 2007 19:27:12 +0000 (19:27 +0000)]
Simplified sortby rule

17 years ago- Changed some whitespacing in connect statement.
Michael Meskes [Sat, 17 Mar 2007 19:25:24 +0000 (19:25 +0000)]
- Changed some whitespacing in connect statement.
- Made some chars const as proposed by Stefan Huehner <stefan@huehner.org>.
- Synced parser and keyword lists.
- Copied two token parsing from backend parser to ecpg parser.
- Also added a test case for this.

17 years agomsvc build actually needs Bison 2.2 or later, not 2.1. Or 1.875 as before.
Magnus Hagander [Sat, 17 Mar 2007 17:11:41 +0000 (17:11 +0000)]
msvc build actually needs Bison 2.2 or later, not 2.1. Or 1.875 as before.

17 years agoAdd note that diff is required for regression tests.
Magnus Hagander [Sat, 17 Mar 2007 14:30:00 +0000 (14:30 +0000)]
Add note that diff is required for regression tests.

17 years agoAdd cvs tags to msvc build files, along with a (very short) comment about
Magnus Hagander [Sat, 17 Mar 2007 14:01:01 +0000 (14:01 +0000)]
Add cvs tags to msvc build files, along with a (very short) comment about
what each script does.

17 years agoOops, forgot to remove the old genbki script.
Magnus Hagander [Sat, 17 Mar 2007 13:54:34 +0000 (13:54 +0000)]
Oops, forgot to remove the old genbki script.

17 years agoTurn most vc build scripts into modules instead of scripts, and just have
Magnus Hagander [Sat, 17 Mar 2007 13:50:42 +0000 (13:50 +0000)]
Turn most vc build scripts into modules instead of scripts, and just have
skeleton scripts calling them. To make it easier for the buildfarm
(or other "outside callers") to use these modules directly.

Per suggestion from Andrew Dunstan.

17 years agoSPI_cursor_open failed to enforce that only read-only queries could be
Tom Lane [Sat, 17 Mar 2007 03:15:38 +0000 (03:15 +0000)]
SPI_cursor_open failed to enforce that only read-only queries could be
executed in read_only mode.  This could lead to various relatively-subtle
failures, such as an allegedly stable function returning non-stable results.
Bug goes all the way back to the introduction of read-only mode in 8.0.
Per report from Gaetano Mendola.

17 years agoOoops, got only one of the two ArrayExpr variants correct in first
Tom Lane [Sat, 17 Mar 2007 01:15:55 +0000 (01:15 +0000)]
Ooops, got only one of the two ArrayExpr variants correct in first
cut at exprTypmod support.  Also, experimentation shows that we need
to label the type of Const nodes that are numeric with a specific
typmod.

17 years agoFix up the remaining places where the expression node structure would lose
Tom Lane [Sat, 17 Mar 2007 00:11:05 +0000 (00:11 +0000)]
Fix up the remaining places where the expression node structure would lose
available information about the typmod of an expression; namely, Const,
ArrayRef, ArrayExpr, and EXPR and ARRAY SubLinks.  In the ArrayExpr and
SubLink cases it wasn't really the data structure's fault, but exprTypmod()
being lazy.  This seems like a good idea in view of the expected increase in
typmod usage from Teodor's work to allow user-defined types to have typmods.
In particular this responds to the concerns we had about eliminating the
special-purpose hack that exprTypmod() used to have for BPCHAR Consts.
We can now tell whether or not such a Const has been cast to a specific
length, and report or display properly if so.

initdb forced due to changes in stored rules.

17 years agoAdd new columns for tuple statistics on a database level to
Magnus Hagander [Fri, 16 Mar 2007 17:57:36 +0000 (17:57 +0000)]
Add new columns for tuple statistics on a database level to
pg_stat_database.

17 years agoFix race condition in parallel regression tests. The new plancache test
Tom Lane [Fri, 16 Mar 2007 16:11:49 +0000 (16:11 +0000)]
Fix race condition in parallel regression tests.  The new plancache test
was expecting there to be no regular table named 'foo', but it turns out
the rules test transiently creates one, so that plancache would sometimes
fail.  I couldn't reproduce that in quite a few tries here, but several
buildfarm machines have shown the failure.  Fix by renaming plancache's
temp table to something nonconflicting.

17 years agoFix uninitialized value in pgstatindex leading to invalid values being
Alvaro Herrera [Fri, 16 Mar 2007 15:06:43 +0000 (15:06 +0000)]
Fix uninitialized value in pgstatindex leading to invalid values being
reported in some cases.  Report and patch from Tatsuhito Kasahara.

Also fix a couple of other bugs I noticed in skimming the surrounding code.

17 years agoRemove undocumented support for copy syntax from before 7.3. Update comments to
Andrew Dunstan [Fri, 16 Mar 2007 13:41:21 +0000 (13:41 +0000)]
Remove undocumented support for copy syntax from before 7.3. Update comments to
reflect syntax actually supported, e.g. by including CSV params.

17 years agoShow aggregate return types in psql \da output.
Magnus Hagander [Fri, 16 Mar 2007 08:28:01 +0000 (08:28 +0000)]
Show aggregate return types in psql \da output.

Greg Sabino Mullane

17 years agoMake use of plancache module for SPI plans. In particular, since plpgsql
Tom Lane [Thu, 15 Mar 2007 23:12:07 +0000 (23:12 +0000)]
Make use of plancache module for SPI plans.  In particular, since plpgsql
uses SPI plans, this finally fixes the ancient gotcha that you can't
drop and recreate a temp table used by a plpgsql function.

Along the way, clean up SPI's API a little bit by declaring SPI plan
pointers as "SPIPlanPtr" instead of "void *".  This is cosmetic but
helps to forestall simple programming mistakes.  (I have changed some
but not all of the callers to match; there are still some "void *"'s
in contrib and the PL's.  This is intentional so that we can see if
anyone's compiler complains about it.)

17 years agoFix a longstanding bug in VACUUM FULL's handling of update chains. The code
Tom Lane [Wed, 14 Mar 2007 18:48:55 +0000 (18:48 +0000)]
Fix a longstanding bug in VACUUM FULL's handling of update chains.  The code
did not expect that a DEAD tuple could follow a RECENTLY_DEAD tuple in an
update chain, but because the OldestXmin rule for determining deadness is a
simplification of reality, it is possible for this situation to occur
(implying that the RECENTLY_DEAD tuple is in fact dead to all observers,
but this patch does not attempt to exploit that).  The code would follow a
chain forward all the way, but then stop before a DEAD tuple when backing
up, meaning that not all of the chain got moved.  This could lead to copying
the chain multiple times (resulting in duplicate copies of the live tuple at
its end), or leaving dangling index entries behind (which, aside from
generating warnings from later vacuums, creates a risk of wrong query
results or bogus duplicate-key errors once the heap slot the index entry
points to is repopulated).

The fix is to recheck HeapTupleSatisfiesVacuum while following a chain
forward, and to stop if a DEAD tuple is reached.  Each contiguous group
of RECENTLY_DEAD tuples will therefore be copied as a separate chain.
The patch also adds a couple of extra sanity checks to verify correct
behavior.

Per report and test case from Pavan Deolasee.

17 years agoArrange to install a "posixrules" entry in our timezone database, so that
Tom Lane [Wed, 14 Mar 2007 17:38:06 +0000 (17:38 +0000)]
Arrange to install a "posixrules" entry in our timezone database, so that
POSIX-style timezone specs that don't exactly match any database entry will
be treated as having correct USA DST rules.  Also, document that this can
be changed if you want to use some other DST rules with a POSIX zone spec.

We could consider changing localtime.c's TZDEFRULESTRING, but since that
facility can only deal with one DST transition rule, it seems fairly useless
now; might as well just plan to override it using a "posixrules" entry.

Backpatch as far as 8.0.  There isn't much we can do in 7.x ... either your
libc gets it right, or it doesn't.

17 years agoAdd GIN support for pg_trgm. From Guillaume Smet <guillaume.smet@gmail.com>
Teodor Sigaev [Wed, 14 Mar 2007 14:21:53 +0000 (14:21 +0000)]
Add GIN support for pg_trgm. From Guillaume Smet <guillaume.smet@gmail.com>
with minor editorization by me.

Hstore improvements
* add operation hstore ? text - excat equivalent of exist()
* remove undocumented behaviour of contains operation with NULL value
* now 'key'::text=>NULL returns '"key"=>NULL' instead of NULL
* Add GIN support for contains and exist operations
* Add GiST support for exist operatiion
* improve regression tests

17 years agoAdd GIN support for pg_trgm. From Guillaume Smet <guillaume.smet@gmail.com>
Teodor Sigaev [Wed, 14 Mar 2007 14:15:40 +0000 (14:15 +0000)]
Add GIN support for pg_trgm. From Guillaume Smet <guillaume.smet@gmail.com>
with minor editorization by me.

17 years agoRemove extra single-quotes copied from Unix build. Win32 doesn't strip
Magnus Hagander [Wed, 14 Mar 2007 09:55:03 +0000 (09:55 +0000)]
Remove extra single-quotes copied from Unix build. Win32 doesn't strip
single quotes...

17 years agoFix broken markup, strange tab width.
Tom Lane [Wed, 14 Mar 2007 00:15:26 +0000 (00:15 +0000)]
Fix broken markup, strange tab width.

17 years agoRegression makefile now needs to make separate lists of what to clean
Tom Lane [Tue, 13 Mar 2007 22:56:48 +0000 (22:56 +0000)]
Regression makefile now needs to make separate lists of what to clean
for input/ and output/ directories, because with the addition of
largeobject_1.source, they're not the same list.  Apparently the current
buildfarm process does not exercise whether 'make distclean' leaves a
clean tree behind, else the farm would have been failing for awhile.

17 years agoRewrite win32 install documentation (it's not client only anymore, and it's
Magnus Hagander [Tue, 13 Mar 2007 16:03:36 +0000 (16:03 +0000)]
Rewrite win32 install documentation (it's not client only anymore, and it's
now complete). Update for the MSVC6/Borland support now being only libpq.
Move most of the information about full MSVC build from README file into
documentation.

17 years agoReverted waiting for further fixes:
Peter Eisentraut [Tue, 13 Mar 2007 14:32:25 +0000 (14:32 +0000)]
Reverted waiting for further fixes:

Make configuration parameters fall back to their default values when they
are removed from the configuration file.

Joachim Wieland

17 years agoFilter out warnings coming from the stylesheets, so that actual warnings show up...
Magnus Hagander [Tue, 13 Mar 2007 14:28:30 +0000 (14:28 +0000)]
Filter out warnings coming from the stylesheets, so that actual warnings show up properly.
Show some minor progress messages.

17 years agoSet root of docbook stuff from buildenv.bat and not from builddoc.bat.
Magnus Hagander [Tue, 13 Mar 2007 09:45:32 +0000 (09:45 +0000)]
Set root of docbook stuff from buildenv.bat and not from builddoc.bat.
Fix calling for file renaming when cd:ed into a different directory.

17 years agoProperly use pg_strcasecmp() instead of strcasecmp().
Magnus Hagander [Tue, 13 Mar 2007 09:11:05 +0000 (09:11 +0000)]
Properly use pg_strcasecmp() instead of strcasecmp().
Un-breaks win32 build.

17 years agoSet stderr to unbuffered for pgbench on win32.
Magnus Hagander [Tue, 13 Mar 2007 09:06:35 +0000 (09:06 +0000)]
Set stderr to unbuffered for pgbench on win32.
ITAGAKI Takahiro

17 years agoFirst phase of plan-invalidation project: create a plan cache management
Tom Lane [Tue, 13 Mar 2007 00:33:44 +0000 (00:33 +0000)]
First phase of plan-invalidation project: create a plan cache management
module and teach PREPARE and protocol-level prepared statements to use it.
In service of this, rearrange utility-statement processing so that parse
analysis does not assume table schemas can't change before execution for
utility statements (necessary because we don't attempt to re-acquire locks
for utility statements when reusing a stored plan).  This requires some
refactoring of the ProcessUtility API, but it ends up cleaner anyway,
for instance we can get rid of the QueryContext global.

Still to do: fix up SPI and related code to use the plan cache; I'm tempted to
try to make SQL functions use it too.  Also, there are at least some aspects
of system state that we want to ensure remain the same during a replan as in
the original processing; search_path certainly ought to behave that way for
instance, and perhaps there are others.

17 years agoMake configuration parameters fall back to their default values when they
Peter Eisentraut [Mon, 12 Mar 2007 22:09:28 +0000 (22:09 +0000)]
Make configuration parameters fall back to their default values when they
are removed from the configuration file.

Joachim Wieland

17 years agoMake a run with perltidy to format the code. Per request from Andrew Dunstan.
Magnus Hagander [Mon, 12 Mar 2007 19:10:50 +0000 (19:10 +0000)]
Make a run with perltidy to format the code. Per request from Andrew Dunstan.

17 years agoFix a race condition that caused pg_database_size() and pg_tablespace_size()
Alvaro Herrera [Sun, 11 Mar 2007 05:22:00 +0000 (05:22 +0000)]
Fix a race condition that caused pg_database_size() and pg_tablespace_size()
to fail if an object was removed between calls to ReadDir() and stat().
Per discussion in pgsql-hackers.

http://archives.postgresql.org/pgsql-hackers/2007-03/msg00671.php

Bug report and patch by Michael Fuhr.

17 years agoAdd alternate result file for large object tests to handle Windows line ends.
Andrew Dunstan [Sat, 10 Mar 2007 03:42:19 +0000 (03:42 +0000)]
Add alternate result file for large object tests to handle Windows line ends.

17 years agoRemove unsafe calling of WSAStartup and WSACleanup from DllMain. Move the
Magnus Hagander [Thu, 8 Mar 2007 19:27:28 +0000 (19:27 +0000)]
Remove unsafe calling of WSAStartup and WSACleanup from DllMain. Move the
inline cleanup call around so it will be called in the right order, and
be called on errors.

Per report from Tokuharu Yuzawa.

17 years agoFix vac_update_relstats to ensure it always sends a relcache inval message,
Tom Lane [Thu, 8 Mar 2007 17:03:31 +0000 (17:03 +0000)]
Fix vac_update_relstats to ensure it always sends a relcache inval message,
even if none of the fields in the pg_class row change.  This behavior is
necessary to ensure other backends flush rd_targblock values that might
point to truncated-away pages.  We got this right pre-8.2 but it was broken
by overoptimistic change to not write out the pg_class row if unchanged.
Per report from Pavan Deolasee.

17 years agoAthough cube is a varlena type, nowhere was a detoasting of cube's value, so
Teodor Sigaev [Wed, 7 Mar 2007 21:21:12 +0000 (21:21 +0000)]
Athough cube is a varlena type, nowhere was a detoasting of cube's value, so
fix it.  Add macroses DatumGetNDBOX, PG_GETARG_NDBOX and PG_RETURN_NDBOX.
Backpatch for 8.2 too.

Previous versions use version 0 calling conventions. And fmgr code detoast
values for user-defined functions.

17 years agoCleanup the bootstrap code a little, and rename "dummy procs" in the code
Alvaro Herrera [Wed, 7 Mar 2007 13:35:03 +0000 (13:35 +0000)]
Cleanup the bootstrap code a little, and rename "dummy procs" in the code
comments and variables to "auxiliary proc", per Heikki's request.

17 years agoFix oversight in original coding of inline_function(): since
Tom Lane [Tue, 6 Mar 2007 22:45:16 +0000 (22:45 +0000)]
Fix oversight in original coding of inline_function(): since
check_sql_fn_retval allows binary-compatibility cases, the expression
extracted from an inline-able SQL function might have a type that is only
binary-compatible with the declared function result type.  To avoid possibly
changing the semantics of the expression, we should insert a RelabelType node
in such cases.  This has only been shown to have bad consequences in recent
8.1 and up releases, but I suspect there may be failure cases in the older
branches too, so patch it all the way back.  Per bug #3116 from Greg Mullane.

Along the way, fix an omission in eval_const_expressions_mutator: it failed
to copy the relabelformat field when processing a RelabelType.  No known
observable failures from this, but it definitely isn't intended behavior.

17 years agoAdd script to build documentation on win32 without mingw
Magnus Hagander [Tue, 6 Mar 2007 14:16:55 +0000 (14:16 +0000)]
Add script to build documentation on win32 without mingw

17 years agoMinor edits
Peter Eisentraut [Tue, 6 Mar 2007 09:59:22 +0000 (09:59 +0000)]
Minor edits

17 years agoAdd more information about avoiding Linux OOM killer.
Peter Eisentraut [Tue, 6 Mar 2007 09:54:23 +0000 (09:54 +0000)]
Add more information about avoiding Linux OOM killer.

by Toru SHIMOGAKI

17 years agoRevert temp_tablespaces because of coding problems, per Tom.
Bruce Momjian [Tue, 6 Mar 2007 02:06:15 +0000 (02:06 +0000)]
Revert temp_tablespaces because of coding problems, per Tom.

17 years agoRemove copied comments from geo_ops.c source file and replace with new
Bruce Momjian [Mon, 5 Mar 2007 23:29:14 +0000 (23:29 +0000)]
Remove copied comments from geo_ops.c source file and replace with new
comments, and cleanup functions.  Remove copyright that is no longer
relevant.

17 years agoRemove timeline for 8.3 release, now on web site.
Bruce Momjian [Mon, 5 Mar 2007 18:04:03 +0000 (18:04 +0000)]
Remove timeline for 8.3 release, now on web site.

17 years agoRemove old-style win32 client-only visual c++ build infrastructure for everything...
Magnus Hagander [Mon, 5 Mar 2007 14:18:38 +0000 (14:18 +0000)]
Remove old-style win32 client-only visual c++ build infrastructure for everything except
libpq. We need to keep libpq to build static libraries and to use PQtrace
with clients using older versions of MSVC.

17 years agoFix a typo in a comment. Heikki Linnakangas.
Neil Conway [Mon, 5 Mar 2007 14:13:12 +0000 (14:13 +0000)]
Fix a typo in a comment. Heikki Linnakangas.

17 years agoMake the newly-added regression tests for lo_truncate() consistent
Neil Conway [Sat, 3 Mar 2007 22:57:04 +0000 (22:57 +0000)]
Make the newly-added regression tests for lo_truncate() consistent
with the recent largeobject cosmetic fixes. Jeremy Drake.

17 years agoCosmetic patch to large object regression test.
Bruce Momjian [Sat, 3 Mar 2007 20:17:25 +0000 (20:17 +0000)]
Cosmetic patch to large object regression test.

Jeremy Drake

17 years agoSplit _bt_insertonpg to two functions.
Bruce Momjian [Sat, 3 Mar 2007 20:13:06 +0000 (20:13 +0000)]
Split _bt_insertonpg to two functions.

Heikki Linnakangas

17 years agoFix for COPY-after-truncate feature.
Bruce Momjian [Sat, 3 Mar 2007 20:08:41 +0000 (20:08 +0000)]
Fix for COPY-after-truncate feature.

Simon Riggs

17 years agoRemove undo information from pg_controldata --- never used.
Bruce Momjian [Sat, 3 Mar 2007 20:02:27 +0000 (20:02 +0000)]
Remove undo information from pg_controldata --- never used.

Florian G. Pflug

17 years agoAdd lo_truncate() to backend and libpq for large object truncation.
Bruce Momjian [Sat, 3 Mar 2007 19:52:47 +0000 (19:52 +0000)]
Add lo_truncate() to backend and libpq for large object truncation.

Kris Jurka

17 years agoAdd resetStringInfo(), which clears the content of a StringInfo, and
Neil Conway [Sat, 3 Mar 2007 19:32:55 +0000 (19:32 +0000)]
Add resetStringInfo(), which clears the content of a StringInfo, and
fixup various places in the tree that were clearing a StringInfo by hand.
Making this function a part of the API simplifies client code slightly,
and avoids needlessly peeking inside the StringInfo interface.

17 years agoAdd logging to /contrib/pg_standby if -k couldn't clean up the log file.
Bruce Momjian [Sat, 3 Mar 2007 18:50:45 +0000 (18:50 +0000)]
Add logging to /contrib/pg_standby if -k couldn't clean up the log file.

Darcy Buskermolen

17 years agoAdd GUC log_lock_waits to log long wait times.
Bruce Momjian [Sat, 3 Mar 2007 18:46:40 +0000 (18:46 +0000)]
Add GUC log_lock_waits to log long wait times.

Simon Riggs

17 years agoDone:
Bruce Momjian [Sat, 3 Mar 2007 17:24:04 +0000 (17:24 +0000)]
Done:

>  o -Allow psql \pset boolean variables to set to fixed values, rather

17 years agoAllow \pset and \x, \t to use boolean constants on/off, rather than just
Bruce Momjian [Sat, 3 Mar 2007 17:19:11 +0000 (17:19 +0000)]
Allow \pset and \x, \t to use boolean constants on/off, rather than just
toggle.

Chad Wagner

17 years agoUpdate license wording in FAQ_DEV.
Bruce Momjian [Sat, 3 Mar 2007 16:12:37 +0000 (16:12 +0000)]
Update license wording in FAQ_DEV.

17 years agoAdd URLs for:
Bruce Momjian [Sat, 3 Mar 2007 03:08:46 +0000 (03:08 +0000)]
Add URLs for:

* Add REPLACE or UPSERT command that does UPDATE, or on failure, INSERT
  [merge]

17 years agoMake log_min_error_statement put LOG level at the same priority as
Tom Lane [Fri, 2 Mar 2007 23:37:23 +0000 (23:37 +0000)]
Make log_min_error_statement put LOG level at the same priority as
log_min_messages does; and arrange to suppress the duplicative output
that would otherwise result from log_statement and log_duration messages.
Bruce Momjian and Tom Lane.

17 years agoHTML markup fix.
Bruce Momjian [Fri, 2 Mar 2007 21:03:55 +0000 (21:03 +0000)]
HTML markup fix.

17 years agoFix HTML markup.
Bruce Momjian [Fri, 2 Mar 2007 21:03:11 +0000 (21:03 +0000)]
Fix HTML markup.

17 years agoin FAQ_DEV, mention we don't want non-BSD-compatible licensed patches.
Bruce Momjian [Fri, 2 Mar 2007 17:51:56 +0000 (17:51 +0000)]
in FAQ_DEV, mention we don't want non-BSD-compatible licensed patches.

17 years agoFix broken markup, improve wording.
Tom Lane [Fri, 2 Mar 2007 06:01:01 +0000 (06:01 +0000)]
Fix broken markup, improve wording.

17 years agoSuppress useless searches for unused line pointers in PageAddItem. To do
Tom Lane [Fri, 2 Mar 2007 00:48:44 +0000 (00:48 +0000)]
Suppress useless searches for unused line pointers in PageAddItem.  To do
this, add a 16-bit "flags" field to page headers by stealing some bits from
pd_tli.  We use one flag bit as a hint to indicate whether there are any
unused line pointers; the remaining 15 are available for future use.

This is a cut-down form of an idea proposed by Hiroki Kataoka in July 2005.
At the time it was rejected because the original patch increased the size of
page headers and it wasn't clear that the benefit outweighed the distributed
cost.  The flag-bit approach gets most of the benefit without requiring an
increase in the page header size.

Heikki Linnakangas and Tom Lane

17 years agoFix miscalculation of stats collector's write delay, introduced in revision 1.117.
Tom Lane [Thu, 1 Mar 2007 20:06:56 +0000 (20:06 +0000)]
Fix miscalculation of stats collector's write delay, introduced in revision 1.117.

17 years agoFix markQueryForLocking() to work correctly in the presence of nested views.
Tom Lane [Thu, 1 Mar 2007 18:50:28 +0000 (18:50 +0000)]
Fix markQueryForLocking() to work correctly in the presence of nested views.
It has been wrong for this case since it was first written for 7.1 :-(
Per report from Pavel HanĂ¡k.

17 years agoFix date/time formats for XML Schema output.
Peter Eisentraut [Thu, 1 Mar 2007 14:52:04 +0000 (14:52 +0000)]
Fix date/time formats for XML Schema output.

Pavel Stehule

17 years agoFix up several contrib modules that were using varlena datatypes in not-so-obvious
Tom Lane [Wed, 28 Feb 2007 22:44:38 +0000 (22:44 +0000)]
Fix up several contrib modules that were using varlena datatypes in not-so-obvious
ways.  I'm not totally sure that I caught everything, but at least now they pass
their regression tests with VARSIZE/SET_VARSIZE defined to reverse byte order.

17 years agoAdd language about rights given by posting a patch:
Bruce Momjian [Wed, 28 Feb 2007 17:28:09 +0000 (17:28 +0000)]
Add language about rights given by posting a patch:

    <li>PostgreSQL is licensed under a BSD license.  By posting a patch
    to the public PostgreSQL mailling lists, you are giving the PostgreSQL
    Global Development Group the non-revokable right to distribute your
    patch under the BSD license.  If you use code that is available under
    some other license that is BSD compatible (eg. public domain), please
    note that in your email submission.</li>

17 years agoRemove temporary Windows-specific debugging code.
Magnus Hagander [Wed, 28 Feb 2007 15:59:30 +0000 (15:59 +0000)]
Remove temporary Windows-specific debugging code.

17 years agoReplace direct assignments to VARATT_SIZEP(x) with SET_VARSIZE(x, len).
Tom Lane [Tue, 27 Feb 2007 23:48:10 +0000 (23:48 +0000)]
Replace direct assignments to VARATT_SIZEP(x) with SET_VARSIZE(x, len).
Get rid of VARATT_SIZE and VARATT_DATA, which were simply redundant with
VARSIZE and VARDATA, and as a consequence almost no code was using the
longer names.  Rename the length fields of struct varlena and various
derived structures to catch anyplace that was accessing them directly;
and clean up various places so caught.  In itself this patch doesn't
change any behavior at all, but it is necessary infrastructure if we hope
to play any games with the representation of varlena headers.
Greg Stark and Tom Lane

17 years agoUpdate release timeline to use unnumber lists HTML.
Bruce Momjian [Tue, 27 Feb 2007 23:12:51 +0000 (23:12 +0000)]
Update release timeline to use unnumber lists HTML.

17 years agoUpdate DEV FAQ for CVS/SVN issue.
Bruce Momjian [Tue, 27 Feb 2007 21:07:20 +0000 (21:07 +0000)]
Update DEV FAQ for CVS/SVN issue.

Robert Treat

17 years agoRemove Kerberos mention in Solaris FAQ.
Bruce Momjian [Tue, 27 Feb 2007 19:10:19 +0000 (19:10 +0000)]
Remove Kerberos mention in Solaris FAQ.

17 years agoAllow information schema definitions to work without requiring implicit
Peter Eisentraut [Tue, 27 Feb 2007 18:49:43 +0000 (18:49 +0000)]
Allow information schema definitions to work without requiring implicit
casts to text.

17 years agoMake build.bat return a proper errorcode if the build fails.
Magnus Hagander [Tue, 27 Feb 2007 15:21:48 +0000 (15:21 +0000)]
Make build.bat return a proper errorcode if the build fails.

17 years agoGet rid of the separate EState for subplans, and just let them share the
Tom Lane [Tue, 27 Feb 2007 01:11:26 +0000 (01:11 +0000)]
Get rid of the separate EState for subplans, and just let them share the
parent query's EState.  Now that there's a single flat rangetable for both
the main plan and subplans, there's no need anymore for a separate EState,
and removing it allows cleaning up some crufty code in nodeSubplan.c and
nodeSubqueryscan.c.  Should be a tad faster too, although any difference
will probably be hard to measure.  This is the last bit of subsidiary
mop-up work from changing to a flat rangetable.

17 years agoPut back copyObject() call I removed in a fit of brain fade. This one
Tom Lane [Sun, 25 Feb 2007 17:44:01 +0000 (17:44 +0000)]
Put back copyObject() call I removed in a fit of brain fade.  This one
is still needed despite cleanups in setrefs.c, because the point is to
let the inserted Result node compute a different tlist than its input
node does.  Per example from Jeremy Drake.

17 years agoUpdate Solaris FAQ.
Bruce Momjian [Fri, 23 Feb 2007 23:22:33 +0000 (23:22 +0000)]
Update Solaris FAQ.

17 years agoNow that plans have flat rangetable lists, it's a lot easier to get EXPLAIN to
Tom Lane [Fri, 23 Feb 2007 21:59:45 +0000 (21:59 +0000)]
Now that plans have flat rangetable lists, it's a lot easier to get EXPLAIN to
drill down into subplan targetlists to print the referent expression for an
OUTER or INNER var in an upper plan node.  Hence, make it do that always, and
banish the old hack of showing "?columnN?" when things got too complicated.

Along the way, fix an EXPLAIN bug I introduced by suppressing subqueries from
execution-time range tables: get_name_for_var_field() assumed it could look at
rte->subquery to find out the real type of a RECORD var.  That doesn't work
anymore, but instead we can look at the input plan of the SubqueryScan plan
node.

17 years agoMove BLCKSZ < 1024 check to guc.c.
Bruce Momjian [Fri, 23 Feb 2007 21:36:19 +0000 (21:36 +0000)]
Move BLCKSZ < 1024 check to guc.c.

17 years agoSpelling fix.
Bruce Momjian [Fri, 23 Feb 2007 20:37:59 +0000 (20:37 +0000)]
Spelling fix.

17 years agoUpdate Solaris FAQ wording, per Peter.
Bruce Momjian [Fri, 23 Feb 2007 20:30:08 +0000 (20:30 +0000)]
Update Solaris FAQ wording, per Peter.

17 years agoUpdate upgrade FAQ info.
Bruce Momjian [Fri, 23 Feb 2007 19:06:22 +0000 (19:06 +0000)]
Update upgrade FAQ info.

17 years agoUpdate Solaris FAQ.
Bruce Momjian [Fri, 23 Feb 2007 18:38:19 +0000 (18:38 +0000)]
Update Solaris FAQ.

Zdenek Kotala

17 years agoAdd psql \prompt capability.
Bruce Momjian [Fri, 23 Feb 2007 18:20:59 +0000 (18:20 +0000)]
Add psql \prompt capability.

Chad Wagner

17 years agoChange Agg and Group nodes so that Vars contained in their targetlists
Tom Lane [Thu, 22 Feb 2007 23:44:25 +0000 (23:44 +0000)]
Change Agg and Group nodes so that Vars contained in their targetlists
and quals have varno OUTER, rather than zero, to indicate a reference to
an output of their lefttree subplan.  This is consistent with the way
that every other upper-level node type does it, and allows some simplifications
in setrefs.c and EXPLAIN.

17 years agoFix bug I introduced in recent patch to make hash joins discard null tuples
Tom Lane [Thu, 22 Feb 2007 22:49:27 +0000 (22:49 +0000)]
Fix bug I introduced in recent patch to make hash joins discard null tuples
immediately: ExecHashGetHashValue failed to restore the caller's memory
context before taking the failure exit.

17 years agoTurn the rangetable used by the executor into a flat list, and avoid storing
Tom Lane [Thu, 22 Feb 2007 22:00:26 +0000 (22:00 +0000)]
Turn the rangetable used by the executor into a flat list, and avoid storing
useless substructure for its RangeTblEntry nodes.  (I chose to keep using the
same struct node type and just zero out the link fields for unneeded info,
rather than making a separate ExecRangeTblEntry type --- it seemed too
fragile to have two different rangetable representations.)

Along the way, put subplans into a list in the toplevel PlannedStmt node,
and have SubPlan nodes refer to them by list index instead of direct pointers.
Vadim wanted to do that years ago, but I never understood what he was on about
until now.  It makes things a *whole* lot more robust, because we can stop
worrying about duplicate processing of subplans during expression tree
traversals.  That's been a constant source of bugs, and it's finally gone.

There are some consequent simplifications yet to be made, like not using
a separate EState for subplans in the executor, but I'll tackle that later.