]> granicus.if.org Git - postgresql/log
postgresql
15 years agoMessage fixes
Peter Eisentraut [Sun, 21 Jun 2009 20:15:32 +0000 (20:15 +0000)]
Message fixes

15 years agoFix things so that array_agg_finalfn does not modify or free its input
Tom Lane [Sat, 20 Jun 2009 18:45:28 +0000 (18:45 +0000)]
Fix things so that array_agg_finalfn does not modify or free its input
ArrayBuildState, per trouble report from Merlin Moncure.  By adopting
this fix, we are essentially deciding that aggregate final-functions
should not modify their inputs ever.  Adjust documentation and comments
to match that conclusion.

15 years agoExtend man page installation hackery so that the man page section is also
Peter Eisentraut [Fri, 19 Jun 2009 19:15:13 +0000 (19:15 +0000)]
Extend man page installation hackery so that the man page section is also
fixed up in the .so links.

15 years agoDon't convert the man page names to lower case, so that the .so links work.
Peter Eisentraut [Fri, 19 Jun 2009 19:14:25 +0000 (19:14 +0000)]
Don't convert the man page names to lower case, so that the .so links work.
This is pretty much a workaround for incomplete tools, but having the man
page names in upper case looks more natural anyway.

15 years agoAdd manvolnum, so that man pages are generated.
Peter Eisentraut [Fri, 19 Jun 2009 15:28:25 +0000 (15:28 +0000)]
Add manvolnum, so that man pages are generated.

15 years agoDon't attempt to "rm" directories on uninstall.
Peter Eisentraut [Thu, 18 Jun 2009 15:10:35 +0000 (15:10 +0000)]
Don't attempt to "rm" directories on uninstall.

15 years agoRecursive Joins -> Recursive Queries
Peter Eisentraut [Thu, 18 Jun 2009 14:42:08 +0000 (14:42 +0000)]
Recursive Joins -> Recursive Queries

per Erik Rijkers

15 years agoAdd some more documentation and cross-links on using dblink with SQL/MED.
Peter Eisentraut [Thu, 18 Jun 2009 14:34:36 +0000 (14:34 +0000)]
Add some more documentation and cross-links on using dblink with SQL/MED.

15 years agoRefine the use of terminology around bound and unbound cursors and cursor
Peter Eisentraut [Thu, 18 Jun 2009 10:22:09 +0000 (10:22 +0000)]
Refine the use of terminology around bound and unbound cursors and cursor
variables. Remove the confusing term "reference cursor".

15 years agoFix a few errors in comments. Patch by Fujii Masao, plus the one in
Heikki Linnakangas [Thu, 18 Jun 2009 10:08:08 +0000 (10:08 +0000)]
Fix a few errors in comments. Patch by Fujii Masao, plus the one in
visibilitymap.c by me.

15 years agoFix the just-reported problem that you can't specify all four trigger event
Tom Lane [Thu, 18 Jun 2009 01:27:02 +0000 (01:27 +0000)]
Fix the just-reported problem that you can't specify all four trigger event
types in CREATE TRIGGER.  While at it, clean up the amazingly tedious and
inextensible way that the trigger event type list was handled.  Per report
from Greg Sabino Mullane.

15 years agoProofreading for Bruce's recent round of documentation proofreading.
Tom Lane [Wed, 17 Jun 2009 21:58:49 +0000 (21:58 +0000)]
Proofreading for Bruce's recent round of documentation proofreading.
Most of those changes were good, but some not so good ...

15 years agoExecAgg() failed to finish running out set-returning functions in the last
Tom Lane [Wed, 17 Jun 2009 16:05:34 +0000 (16:05 +0000)]
ExecAgg() failed to finish running out set-returning functions in the last
aggregated tuple of a run.  Per report from Laurenz Albe.  This is a new
bug in 8.4, but only because prior versions rejected SRFs in an Agg plan
node altogether.

15 years agoAdd another link of a GUC variable to where it is explained.
Peter Eisentraut [Wed, 17 Jun 2009 13:59:28 +0000 (13:59 +0000)]
Add another link of a GUC variable to where it is explained.

15 years agoFix typo in error message: tgargv -> tg_argv
Peter Eisentraut [Wed, 17 Jun 2009 13:46:12 +0000 (13:46 +0000)]
Fix typo in error message: tgargv -> tg_argv

15 years agoChange test tables in copy2 regression test to be temporary tables.
Tom Lane [Sun, 14 Jun 2009 00:00:24 +0000 (00:00 +0000)]
Change test tables in copy2 regression test to be temporary tables.
This prevents autovacuum from reclaiming free space in them and causing
the test's output row order to change, which is causing intermittent
bogus failure reports in the buildfarm.

Backpatch to 8.3.  The issue exists further back, but since autovacuum was
not on by default before 8.3, it's not a problem for buildfarm testing.

15 years agoFix get_sort_group_operators() so that it doesn't think arrays can be grouped
Tom Lane [Sat, 13 Jun 2009 15:42:09 +0000 (15:42 +0000)]
Fix get_sort_group_operators() so that it doesn't think arrays can be grouped
via hashing.  Eventually we ought to make that possible, but it won't happen
for 8.4.  Per yesterday's report from Robert Haas.

15 years agoTweak the display of incoming foreign-key constraints in \d, per discussion
Peter Eisentraut [Sat, 13 Jun 2009 13:43:34 +0000 (13:43 +0000)]
Tweak the display of incoming foreign-key constraints in \d, per discussion
on hackers.  Also, take that string out of the translation roster, since
it's now entirely pseudo-SQL.

15 years agoImprove documentation about GiST opclass support functions.
Tom Lane [Fri, 12 Jun 2009 19:48:53 +0000 (19:48 +0000)]
Improve documentation about GiST opclass support functions.
Dimitri Fontaine

15 years agoFix several places where a function was declared static and then defined
Tom Lane [Fri, 12 Jun 2009 16:17:29 +0000 (16:17 +0000)]
Fix several places where a function was declared static and then defined
without static.  Per testing with a compiler that complains about this.

15 years agoAdd info about minimum recommended AIX fix levels, per Laurenz Albe.
Tom Lane [Fri, 12 Jun 2009 15:53:32 +0000 (15:53 +0000)]
Add info about minimum recommended AIX fix levels, per Laurenz Albe.

15 years agotime to tag rc1 ... REL8_4_RC1
Marc G. Fournier [Fri, 12 Jun 2009 05:19:22 +0000 (05:19 +0000)]
time to tag rc1 ...

15 years agoTighten typedef check for Linux.
Bruce Momjian [Fri, 12 Jun 2009 03:09:07 +0000 (03:09 +0000)]
Tighten typedef check for Linux.

15 years agoMention BSD/OS find_typedef behavior.
Bruce Momjian [Fri, 12 Jun 2009 03:04:48 +0000 (03:04 +0000)]
Mention BSD/OS find_typedef behavior.

15 years agoDocument struct/union problem with pgindent.
Bruce Momjian [Thu, 11 Jun 2009 22:21:44 +0000 (22:21 +0000)]
Document struct/union problem with pgindent.

15 years agoUpdate release notes to today.
Tom Lane [Thu, 11 Jun 2009 21:44:26 +0000 (21:44 +0000)]
Update release notes to today.

15 years agoRevisit AlterTableCreateToastTable's API once again, hoping to make it what
Tom Lane [Thu, 11 Jun 2009 20:46:11 +0000 (20:46 +0000)]
Revisit AlterTableCreateToastTable's API once again, hoping to make it what
pg_migrator actually needs and not just a partial solution.  We have to be
able to specify the OID that the new toast table should be created with.

15 years agoRemove our inadequate kluge that tried to get AIX's various broken versions
Tom Lane [Thu, 11 Jun 2009 19:00:15 +0000 (19:00 +0000)]
Remove our inadequate kluge that tried to get AIX's various broken versions
of getaddrinfo() to work.  Instead, recommend updating the OS to get a working
version of getaddrinfo.  Per recent discussions.

15 years agoMark contrib's GiST and GIN opclass support functions as STRICT, for safety.
Tom Lane [Thu, 11 Jun 2009 18:30:03 +0000 (18:30 +0000)]
Mark contrib's GiST and GIN opclass support functions as STRICT, for safety.
(Note: GiST penalty functions could possibly be non-strict, but none are at
present.)

15 years agoUpdate time zone data files to tzdata release 2009i: DST law changes in
Tom Lane [Thu, 11 Jun 2009 17:45:38 +0000 (17:45 +0000)]
Update time zone data files to tzdata release 2009i: DST law changes in
Bangladesh, Egypt, Jordan, Pakistan.

15 years agoFix things so that you can still do "select foo()" where foo is a SQL
Tom Lane [Thu, 11 Jun 2009 17:25:39 +0000 (17:25 +0000)]
Fix things so that you can still do "select foo()" where foo is a SQL
function returning setof record.  This used to work, more or less
accidentally, but I had broken it while extending the code to allow
materialize-mode functions to be called in select lists.  Add a regression
test case so it doesn't get broken again.  Per gripe from Greg Davidson.

15 years agoSomebody seems to have thought they could get away without checking for
Tom Lane [Thu, 11 Jun 2009 16:14:18 +0000 (16:14 +0000)]
Somebody seems to have thought they could get away without checking for
rsinfo->expectedDesc == NULL in deflist_to_tuplestore(), but that doesn't
look very safe to me.  Noted in passing while studying problem report
from Greg Davidson.

15 years ago8.4 pgindent run, with new combined Linux/FreeBSD/MinGW typedef list
Bruce Momjian [Thu, 11 Jun 2009 14:49:15 +0000 (14:49 +0000)]
8.4 pgindent run, with new combined Linux/FreeBSD/MinGW typedef list
provided by Andrew.

15 years agoAdd FreeBSD support for find_typedef, per request from Andrew.
Bruce Momjian [Thu, 11 Jun 2009 03:14:08 +0000 (03:14 +0000)]
Add FreeBSD support for find_typedef, per request from Andrew.

15 years agoTranslation updates
Peter Eisentraut [Wed, 10 Jun 2009 23:42:44 +0000 (23:42 +0000)]
Translation updates

15 years agoArrange that the string "syntax error" generated by bison is translated.
Peter Eisentraut [Wed, 10 Jun 2009 23:11:52 +0000 (23:11 +0000)]
Arrange that the string "syntax error" generated by bison is translated.

15 years agoFix ill-advised whitespace prettification, per buildfarm.
Tom Lane [Wed, 10 Jun 2009 23:03:32 +0000 (23:03 +0000)]
Fix ill-advised whitespace prettification, per buildfarm.

15 years agoClarify to the translator that plpgsql_yyerror() deals with the translation
Peter Eisentraut [Wed, 10 Jun 2009 22:34:11 +0000 (22:34 +0000)]
Clarify to the translator that plpgsql_yyerror() deals with the translation
of "syntax error", not the literal string.

This same change was made in the backend a while ago; but it applies to
plpgsql as well.

15 years agoProperly mark pg_freespace() function as strict. Also update
Tom Lane [Wed, 10 Jun 2009 22:12:28 +0000 (22:12 +0000)]
Properly mark pg_freespace() function as strict.  Also update
uninstall script to match reality.

15 years agoClarify error message
Peter Eisentraut [Wed, 10 Jun 2009 21:51:56 +0000 (21:51 +0000)]
Clarify error message

15 years agoSupport Kerberos on platforms where libcom_err depends on OpenSSL, as
Tom Lane [Wed, 10 Jun 2009 21:24:11 +0000 (21:24 +0000)]
Support Kerberos on platforms where libcom_err depends on OpenSSL, as
reportedly is true on OpenBSD.  Also support OpenBSD's spelling of
-Wl,--as-needed.  Per Simon Bertrang.

15 years agoAdd warning that xpath() doesn't work with non-UTF8 data.
Tom Lane [Wed, 10 Jun 2009 20:25:41 +0000 (20:25 +0000)]
Add warning that xpath() doesn't work with non-UTF8 data.

15 years agoImprove capitalization and punctuation in recently added GiST message.
Peter Eisentraut [Wed, 10 Jun 2009 20:02:15 +0000 (20:02 +0000)]
Improve capitalization and punctuation in recently added GiST message.

15 years agoAdd a warning about possible strange behavior of volatile functions
Tom Lane [Wed, 10 Jun 2009 19:21:37 +0000 (19:21 +0000)]
Add a warning about possible strange behavior of volatile functions
in cursors.  This has always been the case, but given the lack of user
complaints about it, I'm not going to bother back-patching this.

15 years agoKeep rs_startblock the same during heap_rescan, so that a rescan of a SeqScan
Tom Lane [Wed, 10 Jun 2009 18:54:16 +0000 (18:54 +0000)]
Keep rs_startblock the same during heap_rescan, so that a rescan of a SeqScan
node starts from the same place as the first scan did.  This avoids surprising
behavior of scrollable and WITH HOLD cursors, as seen in Mark Kirkwood's bug
report of yesterday.

It's not entirely clear whether a rescan should be forced to drop out of the
syncscan mode, but for the moment I left the code behaving the same on that
point.  Any change there would only be a performance and not a correctness
issue, anyway.

Back-patch to 8.3, since the unstable behavior was created by the syncscan
patch.

15 years agoFix cash_in() to behave properly in locales where frac_digits is zero,
Tom Lane [Wed, 10 Jun 2009 16:31:32 +0000 (16:31 +0000)]
Fix cash_in() to behave properly in locales where frac_digits is zero,
eg Japan.  Report and fix by Itagaki Takahiro.  Also fix CASHDEBUG printout
format for branches with 64-bit money type, and some minor comment cleanup.

Back-patch to 7.4, because it's broken all the way back.

15 years agoFix Linux typedef code.
Bruce Momjian [Wed, 10 Jun 2009 15:13:45 +0000 (15:13 +0000)]
Fix Linux typedef code.

15 years agoCorrect/improve the datetime_precision field in the information schema.
Peter Eisentraut [Wed, 10 Jun 2009 07:03:34 +0000 (07:03 +0000)]
Correct/improve the datetime_precision field in the information schema.
In particular, always show 0 for the date type instead of null, and show
6 (the default) for time, timestamp, and interval without a declared
precision.  This is now in fuller conformance with the SQL standard.

Also clarify the documentation about this.

discovered and analyzed by Konstantin Izmailov and Tom Lane

15 years agoMake handling of INTERVAL DAY TO MINUTE and INTERVAL DAY TO SECOND input
Tom Lane [Wed, 10 Jun 2009 05:05:03 +0000 (05:05 +0000)]
Make handling of INTERVAL DAY TO MINUTE and INTERVAL DAY TO SECOND input
more consistent with other cases, by having an unlabeled integer field
be treated as a number of minutes or seconds respectively.  These cases
are outside the spec (which insists on full "dd hh:mm" or "dd hh:mm:ss"
input respectively), so it's not much help to us in deciding what to do.
But with this change, it's uniformly the case that an unlabeled integer
will be considered as being a number of the interval's rightmost field.
The change also takes us back to the 8.3 behavior of throwing error
for certain ambiguous inputs such as INTERVAL '1 2' DAY TO MINUTE.
Per recent discussion.

15 years agoEnsure xmlFree(NULL) is a no-op instead of a core dump. Per report from
Tom Lane [Wed, 10 Jun 2009 03:44:35 +0000 (03:44 +0000)]
Ensure xmlFree(NULL) is a no-op instead of a core dump.  Per report from
Sergey Burladyan, there are at least some dank corners of libxml2 that
assume this behavior, even though their published documentation suggests
they shouldn't.

This is only really a live problem in 8.3, but the code is still there
for possible debugging use in HEAD, so patch both branches.

15 years agoFix BSD find_typedef logic.
Bruce Momjian [Wed, 10 Jun 2009 03:38:32 +0000 (03:38 +0000)]
Fix BSD find_typedef logic.

15 years agoUpdate pgindent instructions.
Bruce Momjian [Wed, 10 Jun 2009 01:51:44 +0000 (01:51 +0000)]
Update pgindent instructions.

15 years agoDocument new location for typedef list.
Bruce Momjian [Wed, 10 Jun 2009 01:47:59 +0000 (01:47 +0000)]
Document new location for typedef list.

15 years agoFix xmlattribute escaping XML special characters twice (bug #4822).
Peter Eisentraut [Tue, 9 Jun 2009 22:00:57 +0000 (22:00 +0000)]
Fix xmlattribute escaping XML special characters twice (bug #4822).

Author: Itagaki Takahiro <itagaki.takahiro@oss.ntt.co.jp>

15 years agoMark internal_in as not strict, so that the construct "null::internal"
Tom Lane [Tue, 9 Jun 2009 19:51:00 +0000 (19:51 +0000)]
Mark internal_in as not strict, so that the construct "null::internal"
will throw an error, rather than possibly allowing someone to synthesize
a manual call to an internal-accepting function.  As of CVS HEAD and existing
releases, all such functions are either STRICT or careful about null inputs,
so there is no current security issue here.  But it seems like a good idea
to lock this down to protect against future mistakes.

In passing, similarly lock down trigger_in, language_handler_in, opaque_in,
and shell_in.  These are not believed to present any security risk, but
there's still no good reason to allow nulls of these types to be created.
I left the polymorphic pseudotypes (anyelement etc) alone, since a null
of one of those types doesn't seem to be a problem --- the worst you can
say about it is that it doesn't have an underlying non-polymorphic type.

If we were to make this change during normal development, we'd just
automatically bump catversion for a pg_proc.h change.  But since this doesn't
create a compatibility risk and isn't believed to be fixing a live bug, it
seems better not to force a catversion bump in late beta.

15 years agoFix typo, per Tom
Alvaro Herrera [Tue, 9 Jun 2009 19:36:28 +0000 (19:36 +0000)]
Fix typo, per Tom

15 years agoSwitch order of tests to avoid possible Assert failure for
Tom Lane [Tue, 9 Jun 2009 18:15:04 +0000 (18:15 +0000)]
Switch order of tests to avoid possible Assert failure for
"array_agg_finalfn(null)".  We should modify pg_proc entries to prevent this
query from being accepted, but let's just make the function itself secure too.
Per my note of today.

15 years agoRestore dblink_current_query() to being a C-language function, so as to not
Tom Lane [Tue, 9 Jun 2009 17:41:02 +0000 (17:41 +0000)]
Restore dblink_current_query() to being a C-language function, so as to not
create an ABI break between 8.3 and 8.4.  It is still just a wrapper around
the built-in current_query() function, but at a different implementation
level.  Per my proposal.

Note: this change doesn't break 8.4beta installations, since their
SQL-language definition of the function still works fine.

15 years agoDynamically set a lower bound on autovacuum nap time so that we don't rebuild
Alvaro Herrera [Tue, 9 Jun 2009 16:41:02 +0000 (16:41 +0000)]
Dynamically set a lower bound on autovacuum nap time so that we don't rebuild
the database list too often.

Per bug report from Łukasz Jagiełło and ensuing discussion on
pgsql-performance.

15 years agoDefault client encoding to server encoding for dblink connections. Addresses
Joe Conway [Tue, 9 Jun 2009 16:35:36 +0000 (16:35 +0000)]
Default client encoding to server encoding for dblink connections. Addresses
issue raised by Ruzsinszky Attila and confirmed by others.

 ----------------------------------------------------------------------

15 years agoFix failure to double-quote function argument names when needed, in
Tom Lane [Tue, 9 Jun 2009 14:36:06 +0000 (14:36 +0000)]
Fix failure to double-quote function argument names when needed, in
pg_get_function_arguments() and related functions.  Per report from
Andreas Nolte.

15 years agoFix map_sql_table_to_xmlschema() with dropped attributes.
Peter Eisentraut [Mon, 8 Jun 2009 21:32:33 +0000 (21:32 +0000)]
Fix map_sql_table_to_xmlschema() with dropped attributes.

also backpatched to 8.3

15 years agoFix contrib/pageinspect to not create an ABI breakage between 8.3 and 8.4.
Tom Lane [Mon, 8 Jun 2009 16:22:44 +0000 (16:22 +0000)]
Fix contrib/pageinspect to not create an ABI breakage between 8.3 and 8.4.
The original implementation of the 3-argument form of get_raw_page() risked
core dumps if the 8.3 SQL function definition was mistakenly used with the
8.4 module, which is entirely likely after a dump-and-reload upgrade.  To
protect 8.4 beta testers against upgrade problems, add a check on PG_NARGS.

In passing, fix missed additions to the uninstall script, and polish the
docs a trifle.

15 years agoBe a bit more verbose about the effects of string literal processing
Tom Lane [Mon, 8 Jun 2009 14:57:21 +0000 (14:57 +0000)]
Be a bit more verbose about the effects of string literal processing
changes in plpgsql.  Per bug #4843.

15 years agoRevert my patch of 2009-04-04 that removed contrib/intarray's definitions of
Tom Lane [Sun, 7 Jun 2009 20:09:34 +0000 (20:09 +0000)]
Revert my patch of 2009-04-04 that removed contrib/intarray's definitions of
the <@ and @> operators.  These are not in fact equivalent to the built-in
anyarray operators of the same names, because they have different behavior for
empty arrays, namely they don't think empty arrays are contained in anything.
That is mathematically wrong, no doubt, but until we can persuade GIN indexes
to implement the mathematical definition we should probably not change this.
Another reason for not changing it now is that we can't yet ensure the
opclasses will be updated correctly in a dump-and-reload upgrade.  Per
recent discussions.

15 years agoImprove the IndexVacuumInfo/IndexBulkDeleteResult API to allow somewhat sane
Tom Lane [Sat, 6 Jun 2009 22:13:52 +0000 (22:13 +0000)]
Improve the IndexVacuumInfo/IndexBulkDeleteResult API to allow somewhat sane
behavior in cases where we don't know the heap tuple count accurately; in
particular partial vacuum, but this also makes the API a bit more useful
for ANALYZE.  This patch adds "estimated_count" flags to both structs so
that an approximate count can be flagged as such, and adjusts the logic
so that approximate counts are not used for updating pg_class.reltuples.

This fixes my previous complaint that VACUUM was putting ridiculous values
into pg_class.reltuples for indexes.  The actual impact of that bug is
limited, because the planner only pays attention to reltuples for an index
if the index is partial; which probably explains why beta testers hadn't
noticed a degradation in plan quality from it.  But it needs to be fixed.

The whole thing is a bit messy and should be redesigned in future, because
reltuples now has the potential to drift quite far away from reality when
a long period elapses with no non-partial vacuums.  But this is as good as
it's going to get for 8.4.

15 years agoAdd support for using SQL/MED compliant FOREIGN DATA WRAPPER, SERVER,
Joe Conway [Sat, 6 Jun 2009 21:27:56 +0000 (21:27 +0000)]
Add support for using SQL/MED compliant FOREIGN DATA WRAPPER, SERVER,
and USER MAPPING as method to supply dblink connect parameters. Per
mailing list and PGCon discussions.

15 years agoMove variable declaration to avoid 'unused variable' warning when the
Tom Lane [Sat, 6 Jun 2009 03:45:36 +0000 (03:45 +0000)]
Move variable declaration to avoid 'unused variable' warning when the
ifdef doesn't trigger.  Not worth back-patching.  Per buildfarm reports.

15 years agoFix a serious bug introduced into GIN in 8.4: now that MergeItemPointers()
Tom Lane [Sat, 6 Jun 2009 02:39:40 +0000 (02:39 +0000)]
Fix a serious bug introduced into GIN in 8.4: now that MergeItemPointers()
is supposed to remove duplicate heap TIDs, we have to be sure to reduce the
tuple size and posting-item count accordingly in addItemPointersToTuple().
Failing to do so resulted in the effective injection of garbage TIDs into the
index contents, ie, whatever happened to be in the memory palloc'd for the
new tuple.  I'm not sure that this fully explains the index corruption
reported by Tatsuo Ishii, but the test case I'm using no longer fails.

15 years agoAdjust recent PERL_SYS_INIT3 call to avoid platforms where it might fail, and to...
Andrew Dunstan [Fri, 5 Jun 2009 20:32:00 +0000 (20:32 +0000)]
Adjust recent PERL_SYS_INIT3 call to avoid platforms where it might fail, and to remove compilation warning. Backpatch the release 7.4

15 years agoGIN's ItemPointerIsMin, ItemPointerIsMax, and ItemPointerIsLossyPage macros
Tom Lane [Fri, 5 Jun 2009 18:50:47 +0000 (18:50 +0000)]
GIN's ItemPointerIsMin, ItemPointerIsMax, and ItemPointerIsLossyPage macros
should use GinItemPointerGetBlockNumber/GinItemPointerGetOffsetNumber,
not ItemPointerGetBlockNumber/ItemPointerGetOffsetNumber, because the latter
will Assert() on ip_posid == 0, ie a "Min" pointer.  (Thus, ItemPointerIsMin
has never worked at all, but it seems unused at present.)  I'm not certain
that the case can occur in normal functioning, but it's blowing up on me
while investigating Tatsuo-san's data corruption problem.  In any case it
seems like a problem waiting to bite someone.

Back-patch just in case this really is a problem for somebody in the field.

15 years agoSearch for versioned perl library instead of using hardcoded name on Windows. Backpat...
Andrew Dunstan [Fri, 5 Jun 2009 18:29:56 +0000 (18:29 +0000)]
Search for versioned perl library instead of using hardcoded name on Windows. Backpatch to release 8.3

15 years agoRemove sleep() from backup script example; not needed anymore.
Bruce Momjian [Fri, 5 Jun 2009 13:40:31 +0000 (13:40 +0000)]
Remove sleep() from backup script example;  not needed anymore.

Fujii Masao

15 years agoTrivial code style cleanup around a couple of ngettext calls.
Tom Lane [Thu, 4 Jun 2009 19:17:39 +0000 (19:17 +0000)]
Trivial code style cleanup around a couple of ngettext calls.

15 years agoRemove a couple of debugging messages that have been #ifdef'd out for ages.
Tom Lane [Thu, 4 Jun 2009 19:16:48 +0000 (19:16 +0000)]
Remove a couple of debugging messages that have been #ifdef'd out for ages.
Seems silly to ask translators to expend work on these, especially in
pluralized variants.

15 years agoImprove the recently-added support for properly pluralized error messages
Tom Lane [Thu, 4 Jun 2009 18:33:08 +0000 (18:33 +0000)]
Improve the recently-added support for properly pluralized error messages
by extending the ereport() API to cater for pluralization directly.  This
is better than the original method of calling ngettext outside the elog.c
code because (1) it avoids double translation, which wastes cycles and in
the worst case could give a wrong result; and (2) it avoids having to use
a different coding method in PL code than in the core backend.  The
client-side uses of ngettext are not touched since neither of these concerns
is very pressing in the client environment.  Per my proposal of yesterday.

15 years agoInitialise perl library as documented in perl API. Backpatch to release 7.4.
Andrew Dunstan [Thu, 4 Jun 2009 15:59:55 +0000 (15:59 +0000)]
Initialise perl library as documented in perl API. Backpatch to release 7.4.

15 years agoWording improvement for recent sesssion identifier SQL query.
Bruce Momjian [Wed, 3 Jun 2009 20:34:29 +0000 (20:34 +0000)]
Wording improvement for recent sesssion identifier SQL query.

15 years agoClean up ecpg's use of mmerror(): const-ify the format argument, add an
Tom Lane [Wed, 3 Jun 2009 20:24:51 +0000 (20:24 +0000)]
Clean up ecpg's use of mmerror(): const-ify the format argument, add an
__attribute__() marker so that gcc can validate the format string against
the actual arguments, get rid of overcomplicated and unsafe usage in
base_yyerror().

15 years agoFix tsquerysel() to not fail on an empty TSQuery. Per report from
Tom Lane [Wed, 3 Jun 2009 18:42:13 +0000 (18:42 +0000)]
Fix tsquerysel() to not fail on an empty TSQuery.  Per report from
Tatsuo Ishii.

15 years agoChange rather bizarre code ordering in get_id(). This isn't strictly
Tom Lane [Wed, 3 Jun 2009 16:17:49 +0000 (16:17 +0000)]
Change rather bizarre code ordering in get_id().  This isn't strictly
cosmetic --- I'm wondering if geteuid could have side effects on errno,
thus possibly resulting in a misleading error message after failure of
getpwuid.

15 years agoImprove comment about 'if (1)' hack in copy.c macros.
Tom Lane [Wed, 3 Jun 2009 15:06:48 +0000 (15:06 +0000)]
Improve comment about 'if (1)' hack in copy.c macros.

15 years agoAdd comment about why "((void) 0)" is used in copy macros.
Bruce Momjian [Wed, 3 Jun 2009 14:48:33 +0000 (14:48 +0000)]
Add comment about why "((void) 0)" is used in copy macros.

15 years agoAdd example of how to generate the session identifier from pg_stat_activity.
Bruce Momjian [Wed, 3 Jun 2009 00:38:34 +0000 (00:38 +0000)]
Add example of how to generate the session identifier from pg_stat_activity.

15 years agoRemove the old advice to keep from_collapse_limit less than geqo_threshold,
Tom Lane [Tue, 2 Jun 2009 17:37:55 +0000 (17:37 +0000)]
Remove the old advice to keep from_collapse_limit less than geqo_threshold,
instead just pointing out that a larger value may trigger use of GEQO.
Per Robert Haas.

In passing, do a bit of wordsmithing on the Genetic Query Optimizer section.

15 years agoOnly recycle normal files in pg_xlog as WAL segments. pg_standby creates
Heikki Linnakangas [Tue, 2 Jun 2009 06:18:06 +0000 (06:18 +0000)]
Only recycle normal files in pg_xlog as WAL segments. pg_standby creates
symbolic links with the -l option, and as Fujii Masao pointed out we ended up
overwriting files in the archive directory before this patch. Patch by
Aidan Van Dyk, Fujii Masao and me.

Backpatch to 8.3, where pg_standby was introduced.

15 years agoFix dblink_get_result() as reported by Oleksiy Shchukin. Refactor a bit
Joe Conway [Tue, 2 Jun 2009 03:21:56 +0000 (03:21 +0000)]
Fix dblink_get_result() as reported by Oleksiy Shchukin. Refactor a bit
while we're at it per request by Tom Lane. Specifically, don't try to
perform dblink_send_query() via dblink_record_internal() -- it was
inappropriate and ugly.

15 years agoChange AdjustIntervalForTypmod to not discard higher-order field values on the
Tom Lane [Mon, 1 Jun 2009 23:55:15 +0000 (23:55 +0000)]
Change AdjustIntervalForTypmod to not discard higher-order field values on the
grounds that they don't fit into the specified interval qualifier (typmod).
This behavior, while of long standing, is clearly wrong per spec --- for
example the value INTERVAL '999' SECOND means 999 seconds and should not be
reduced to less than 60 seconds.

In some cases there could be grounds to raise an error if higher-order field
values are not given as zero; for example '1 year 1 month'::INTERVAL MONTH
should arguably be taken as an error rather than equivalent to 13 months.
However our internal representation doesn't allow us to do that in a fashion
that would consistently reject all and only the cases that a strict reading
of the spec would suggest.  Also, seeing that for example INTERVAL '13' MONTH
will print out as '1 year 1 mon', we have to be careful not to create a
situation where valid data will fail to dump and reload.  The present patch
therefore takes the attitude of not throwing an error in any such case.
We might want to revisit that in future but it would take more redesign
than seems prudent in late beta.

Per a complaint from Sebastien Flaesch and subsequent discussion.  While
at other times we might have just postponed such an issue to the next
development cycle, 8.4 already has changed the parsing of interval literals
quite a bit in an effort to accept all spec-compliant cases correctly.
This seems like a change that should be part of that rather than coming
along later.

15 years agoFix DecodeInterval to report an error for multiple occurrences of DAY, WEEK,
Tom Lane [Mon, 1 Jun 2009 16:55:11 +0000 (16:55 +0000)]
Fix DecodeInterval to report an error for multiple occurrences of DAY, WEEK,
YEAR, DECADE, CENTURY, or MILLENIUM fields, just as it always has done for
other types of fields.  The previous behavior seems to have been a hack to
avoid defining bit-positions for all these field types in DTK_M() masks,
rather than something that was really considered to be desired behavior.
But there is room in the masks for these, and we really need to tighten up
at least the behavior of DAY and YEAR fields to avoid unexpected behavior
associated with the 8.4 changes to interpret ambiguous fields based on the
interval qualifier (typmod) value.  Per my example and proposed patch.

15 years agoUpdate obsolete comment in index_drop(). When the comment was written,
Tom Lane [Sun, 31 May 2009 20:55:37 +0000 (20:55 +0000)]
Update obsolete comment in index_drop().  When the comment was written,
queries frequently took no lock at all on individual indexes.  That's not
true any more, but we still need lock on the parent table to make it safe
to use cached lists of index OIDs.

15 years agoChange macros to make gcc quiet when parsing.
Michael Meskes [Fri, 29 May 2009 13:54:52 +0000 (13:54 +0000)]
Change macros to make gcc quiet when parsing.

15 years agoDocument that forking while having open libpq connections is not
Bruce Momjian [Thu, 28 May 2009 20:02:10 +0000 (20:02 +0000)]
Document that forking while having open libpq connections is not
advised.

15 years agoWhen archiving is enabled, rotate the last WAL segment at shutdown so that
Heikki Linnakangas [Thu, 28 May 2009 11:02:16 +0000 (11:02 +0000)]
When archiving is enabled, rotate the last WAL segment at shutdown so that
all transactions are archived.

Original patch by Guillaume Smet.

15 years agoImprove release note explanation of the change in libpq's handling of
Tom Lane [Wed, 27 May 2009 22:12:53 +0000 (22:12 +0000)]
Improve release note explanation of the change in libpq's handling of
default usernames versus Kerberos tickets.  Per confusion about what
bug #4824 was really about.

15 years agoProperly return the usermap result when doing gssapi authentication. Without
Magnus Hagander [Wed, 27 May 2009 21:08:22 +0000 (21:08 +0000)]
Properly return the usermap result when doing gssapi authentication. Without
this, the username was in practice never matched against the kerberos principal
used to log in.

15 years agoFix to use the same format specifiers in both branches of a ngettext().
Peter Eisentraut [Wed, 27 May 2009 20:47:55 +0000 (20:47 +0000)]
Fix to use the same format specifiers in both branches of a ngettext().

Zdenek Kotala

15 years agoIgnore RECHECK in CREATE OPERATOR CLASS, just throwing a NOTICE, instead of
Tom Lane [Wed, 27 May 2009 20:42:29 +0000 (20:42 +0000)]
Ignore RECHECK in CREATE OPERATOR CLASS, just throwing a NOTICE, instead of
throwing an error as 8.4 had been doing.  The error interfered with porting
old database definitions (particularly for pg_migrator) without really buying
any safety.  Per bug #4817 and subsequent discussion.

15 years agoFix compiler warnings on Sun Studio of the sort
Peter Eisentraut [Wed, 27 May 2009 19:41:58 +0000 (19:41 +0000)]
Fix compiler warnings on Sun Studio of the sort

"tsquery_op.c", line 193: warning: syntax error:  empty declaration

Zdenek Kotala

15 years agoReverting patch just in case a compiler treats this enum as signed.
Michael Meskes [Wed, 27 May 2009 14:16:51 +0000 (14:16 +0000)]
Reverting patch just in case a compiler treats this enum as signed.

15 years agoRemove tabs from SGML file.
Bruce Momjian [Wed, 27 May 2009 12:28:55 +0000 (12:28 +0000)]
Remove tabs from SGML file.