]> granicus.if.org Git - neomutt/log
neomutt
6 years agodoxy: document enums
Richard Russon [Sun, 2 Dec 2018 03:45:27 +0000 (03:45 +0000)]
doxy: document enums

6 years agodoxy: document enums
Richard Russon [Sun, 2 Dec 2018 03:24:37 +0000 (03:24 +0000)]
doxy: document enums

6 years agoenum: rename end markers to MAX
Richard Russon [Sun, 2 Dec 2018 00:58:33 +0000 (00:58 +0000)]
enum: rename end markers to MAX

6 years agoenum: rename IMAP capability consts
Richard Russon [Sun, 2 Dec 2018 00:46:16 +0000 (00:46 +0000)]
enum: rename IMAP capability consts

6 years agoenum: rename SMTP capability consts
Richard Russon [Sun, 2 Dec 2018 00:42:56 +0000 (00:42 +0000)]
enum: rename SMTP capability consts

6 years agoenum: rename AddressError consts
Richard Russon [Sun, 2 Dec 2018 00:23:59 +0000 (00:23 +0000)]
enum: rename AddressError consts

6 years agodoxy: document enums
Richard Russon [Sun, 2 Dec 2018 00:16:20 +0000 (00:16 +0000)]
doxy: document enums

6 years agorename FlagChars enums
Richard Russon [Tue, 27 Nov 2018 22:44:10 +0000 (22:44 +0000)]
rename FlagChars enums

6 years agomerge: nntp: refactoring
Richard Russon [Sat, 1 Dec 2018 23:25:51 +0000 (23:25 +0000)]
merge: nntp: refactoring

 * doc: newsrc expando examples
 * nntp: move browser code
 * nntp: tidy headers
 * nntp: move auto-complete code

6 years agonntp: move auto-complete code
Richard Russon [Sat, 1 Dec 2018 18:12:46 +0000 (18:12 +0000)]
nntp: move auto-complete code

6 years agonntp: tidy headers
Richard Russon [Sat, 1 Dec 2018 16:12:03 +0000 (16:12 +0000)]
nntp: tidy headers

6 years agonntp: move browser code
Richard Russon [Sat, 1 Dec 2018 15:47:41 +0000 (15:47 +0000)]
nntp: move browser code

6 years agodoc: newsrc expando examples
Richard Russon [Sat, 1 Dec 2018 13:22:44 +0000 (13:22 +0000)]
doc: newsrc expando examples

6 years agomore Context refactoring/protection
Richard Russon [Sat, 1 Dec 2018 21:14:33 +0000 (21:14 +0000)]
more Context refactoring/protection

6 years agotravis: move to xenial
Richard Russon [Fri, 30 Nov 2018 12:59:35 +0000 (12:59 +0000)]
travis: move to xenial

6 years agosync translations
Richard Russon [Fri, 30 Nov 2018 12:07:28 +0000 (12:07 +0000)]
sync translations

6 years agoimap: login on startup
Mehdi Abaakouk [Thu, 29 Nov 2018 14:09:55 +0000 (15:09 +0100)]
imap: login on startup

This ensure we always have a valid adata.

Closes #1438

6 years agoFix unsub from the selected mailbox by just hiding it
Pietro Cerutti [Thu, 29 Nov 2018 09:30:30 +0000 (09:30 +0000)]
Fix unsub from the selected mailbox by just hiding it

Fixes #1460

6 years agopostpone: fix Postcount when we are in current selected mailbox
Mehdi Abaakouk [Wed, 28 Nov 2018 13:57:31 +0000 (14:57 +0100)]
postpone: fix Postcount when we are in current selected mailbox

6 years agopostpone: Don't reopen Postponed context
Mehdi Abaakouk [Wed, 21 Nov 2018 11:32:24 +0000 (12:32 +0100)]
postpone: Don't reopen Postponed context

If the selected Mailbox is already the Postponed one, no need to open a
new context.

This change reuse the current context.

6 years agomerge: factor out mx_update_context()
Richard Russon [Thu, 29 Nov 2018 13:13:01 +0000 (13:13 +0000)]
merge: factor out mx_update_context()

 * mxapi: add Mailbox to mbox_open
 * reset message counts
 * maildir: factor out mx_update_context()
 * mbox: factor out mx_update_context()
 * pop: factor out mx_update_context()
 * nntp: factor out mx_update_context()
 * notmuch: factor out mx_update_context()
 * imap: factor out mx_update_context()

6 years agoimap: factor out mx_update_context() 1457/head
Richard Russon [Wed, 28 Nov 2018 12:09:41 +0000 (12:09 +0000)]
imap: factor out mx_update_context()

6 years agonotmuch: factor out mx_update_context()
Richard Russon [Tue, 20 Nov 2018 23:55:05 +0000 (23:55 +0000)]
notmuch: factor out mx_update_context()

6 years agonntp: factor out mx_update_context()
Richard Russon [Tue, 20 Nov 2018 23:08:36 +0000 (23:08 +0000)]
nntp: factor out mx_update_context()

6 years agopop: factor out mx_update_context()
Richard Russon [Tue, 20 Nov 2018 16:53:36 +0000 (16:53 +0000)]
pop: factor out mx_update_context()

6 years agombox: factor out mx_update_context()
Richard Russon [Tue, 20 Nov 2018 14:59:44 +0000 (14:59 +0000)]
mbox: factor out mx_update_context()

6 years agomaildir: factor out mx_update_context()
Richard Russon [Mon, 19 Nov 2018 23:04:17 +0000 (23:04 +0000)]
maildir: factor out mx_update_context()

6 years agoreset message counts
Richard Russon [Tue, 27 Nov 2018 16:10:54 +0000 (16:10 +0000)]
reset message counts

6 years agomxapi: add Mailbox to mbox_open
Richard Russon [Mon, 19 Nov 2018 17:10:08 +0000 (17:10 +0000)]
mxapi: add Mailbox to mbox_open

6 years agoimap: handle case where adata->mailbox is NULL
Mehdi Abaakouk [Wed, 28 Nov 2018 20:50:02 +0000 (21:50 +0100)]
imap: handle case where adata->mailbox is NULL

When selected mailbox in unsubscribed, adata->mailbox may be NULL.

make imap_cmd_finish() handles it.

Closes #1460

6 years agoReplace git_ver.h with a combination of git_ver.{c,o}
Marco Sirabella [Fri, 23 Nov 2018 17:41:40 +0000 (12:41 -0500)]
Replace git_ver.h with a combination of git_ver.{c,o}

6 years agofix crash in eat_date()
Mehdi Abaakouk [Wed, 28 Nov 2018 12:07:45 +0000 (13:07 +0100)]
fix crash in eat_date()

6 years agonotmuch: don't overwrite nm_default_uri
Austin Ray [Tue, 27 Nov 2018 03:07:38 +0000 (22:07 -0500)]
notmuch: don't overwrite nm_default_uri

In commit 1040935, I accidentally removed a check for using `Folder` as
the `db_filename` if `db_filename` is null. My change made it so that it
always overwrote the value.

6 years agomerge: upstream changes
Richard Russon [Mon, 26 Nov 2018 18:29:31 +0000 (18:29 +0000)]
merge: upstream changes

 * Add mutt_buffer_mktemp() transition function
 * Add mutt_buffer_adv_mktemp() transition function
 * Always print mutt_buffer_pool_free() size debug output
 * add Buffer fixup functions
 * Remove conversion of nbsp to space
 * Ensure a resized empty buffer is null-terminated
 * Fix memleaks of saslconn on error paths
 * Fix memory leak on error in eat_regexp() and eat_date()
 * Document send-hooks are not executed for resumed messages
 * Fix a few memory leaks for idna conversion
 * Allow relative date hour/min/sec offsets
 * Add some brief documentation on OAUTH support
 * Update $index_format cross-references in manual
 * Add L10N comments to several unclear messages
 * Switch color chunk matching to use bsearch

6 years agoSwitch color chunk matching to use bsearch
Kevin McCarthy [Mon, 19 Nov 2018 03:13:20 +0000 (19:13 -0800)]
Switch color chunk matching to use bsearch

Emails with extremely long lines, combined with a large number of
color matches, can cause a performance hit so severe that mutt appears
to have hung.

Switching out to using a binary search speeds things up noticably.

The for loops being replaced were a bit strange.  resolve_types()
ensures there are no overlaps, and that they are ordered.  A match is
defined by (first <= cnt < last).  I can't see any reason for the
strange comparison of (cnt > last) follow by (cnt != last).  Perhaps
at one time it made sense.

6 years agoAdd L10N comments to several unclear messages
TAKAHASHI Tamotsu [Sun, 18 Nov 2018 18:05:30 +0000 (10:05 -0800)]
Add L10N comments to several unclear messages

Updating Japanese translation, I found that some of the updated messages
were a little hard to understand without reading the code.

Add comments to some messages I nearly translated in a wrong way.

6 years agoUpdate $index_format cross-references in manual
Kevin McCarthy [Wed, 14 Nov 2018 22:13:47 +0000 (14:13 -0800)]
Update $index_format cross-references in manual

Add index-format-hook to the list of hooks.

Add the list of configuration variables that use the expandos.

Add a note to $post_index_string that it uses the expandos.

6 years agoAdd some brief documentation on OAUTH support
Kevin McCarthy [Wed, 7 Nov 2018 21:38:53 +0000 (13:38 -0800)]
Add some brief documentation on OAUTH support

These are just pulled from Brandon's commit message.

6 years agoAllow relative date hour/min/sec offsets
Kevin McCarthy [Tue, 6 Nov 2018 21:21:20 +0000 (13:21 -0800)]
Allow relative date hour/min/sec offsets

These might be useful for index-format-hook pattern matching for some
people.

6 years agoFix a few memory leaks for idna conversion
Kevin McCarthy [Tue, 6 Nov 2018 19:02:01 +0000 (11:02 -0800)]
Fix a few memory leaks for idna conversion

6 years agoDocument send-hooks are not executed for resumed messages
Kevin McCarthy [Tue, 6 Nov 2018 01:44:20 +0000 (17:44 -0800)]
Document send-hooks are not executed for resumed messages

6 years agoFix memory leak on error in eat_regexp() and eat_date()
Kevin McCarthy [Tue, 30 Oct 2018 15:55:52 +0000 (08:55 -0700)]
Fix memory leak on error in eat_regexp() and eat_date()

6 years agoFix memleaks of saslconn on error paths
Peter Wu [Tue, 23 Oct 2018 10:29:26 +0000 (12:29 +0200)]
Fix memleaks of saslconn on error paths

If mutt_sasl_client_new returns an error, the callers would ignore the
allocated saslconn resource from sasl_client_new. Be sure to release
these with sasl_dispose as documented in sasl.h. Likewise, let callers
(POP/IMAP) dispose the resource on their error paths. SMTP was already
taken care of. Found with LeakSanitizer in IMAP.

6 years agoEnsure a resized empty buffer is null-terminated
Kevin McCarthy [Wed, 17 Oct 2018 00:35:54 +0000 (17:35 -0700)]
Ensure a resized empty buffer is null-terminated

The new buffer code is using the pool, which ensures its buffers are
null-terminated.

However, if a "new" buffer from another part of the code were passed
to one of the temporary interfaces that resizes the buffer, it's
possible a non-terminated string might end up being passed through.

It's reasonable to expect mutt_b2s() for a "new" buffer should be the
same as after it is resized larger.  So ensure the resulting buf->data
is properly terminated to avoid surprises.

6 years agoRemove conversion of nbsp to space
Kevin McCarthy [Tue, 16 Oct 2018 23:04:57 +0000 (16:04 -0700)]
Remove conversion of nbsp to space

Keep the behavior of it not line-breaking, but don't change it to a
space character when displaying.  This is so copy-paste from the pager
will preserve the nbsp, which is semantically important in some
locales.

6 years agoadd Buffer fixup functions
Richard Russon [Mon, 26 Nov 2018 15:39:11 +0000 (15:39 +0000)]
add Buffer fixup functions

This is split out of another upstream commit

6 years agoAlways print mutt_buffer_pool_free() size debug output
Kevin McCarthy [Wed, 31 Oct 2018 19:19:56 +0000 (12:19 -0700)]
Always print mutt_buffer_pool_free() size debug output

So I can easily see the resulting size of the pool at the end of a
run.

6 years agoAdd mutt_buffer_adv_mktemp() transition function
Kevin McCarthy [Mon, 15 Oct 2018 02:02:47 +0000 (19:02 -0700)]
Add mutt_buffer_adv_mktemp() transition function

6 years agoAdd mutt_buffer_mktemp() transition function
Kevin McCarthy [Mon, 15 Oct 2018 01:36:08 +0000 (18:36 -0700)]
Add mutt_buffer_mktemp() transition function

This is self-contained and easy to translate, so instead just create
an alternate implementation using struct Buffer.

6 years agoclang-format
Richard Russon [Mon, 26 Nov 2018 11:00:28 +0000 (11:00 +0000)]
clang-format

6 years agoRename arguments of mutt_file_read_line for consistency
Ian Zimmerman [Sun, 25 Nov 2018 06:04:53 +0000 (22:04 -0800)]
Rename arguments of mutt_file_read_line for consistency

6 years agoAdd more convenient functions to map file lines
Ian Zimmerman [Thu, 22 Nov 2018 14:38:03 +0000 (06:38 -0800)]
Add more convenient functions to map file lines

6 years agocheck for Context
Richard Russon [Sun, 25 Nov 2018 22:28:55 +0000 (22:28 +0000)]
check for Context

6 years agomerge: doc: fixes
Richard Russon [Sun, 25 Nov 2018 21:22:00 +0000 (21:22 +0000)]
merge: doc: fixes

 * doc: correct pattern asterisk counts
 * doc: use non-breaking spaces before footnote asterisks
 * doc: add or remove missing or excess spacing respectively

6 years agodoc: add or remove missing or excess spacing respectively 1453/head
Joey Pabalinas [Sun, 25 Nov 2018 20:17:24 +0000 (10:17 -1000)]
doc: add or remove missing or excess spacing respectively

Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com>
6 years agodoc: use non-breaking spaces before footnote asterisks
Joey Pabalinas [Sun, 25 Nov 2018 20:05:55 +0000 (10:05 -1000)]
doc: use non-breaking spaces before footnote asterisks

Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com>
6 years agodoc: correct pattern asterisk counts
Joey Pabalinas [Sun, 25 Nov 2018 20:01:40 +0000 (10:01 -1000)]
doc: correct pattern asterisk counts

The patterns ~b, ~B, and ~h read each message in and should have 4
asterisks instead of 3 (3 refers to patterns with message number range
arguments). Add the missing asterisk to these patterns.

Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com>
6 years agodoc: change instances of GMail to Gmail for consistency
Joey Pabalinas [Sun, 25 Nov 2018 20:30:47 +0000 (10:30 -1000)]
doc: change instances of GMail to Gmail for consistency

Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com>
6 years agosplit up maildir/mh code
Richard Russon [Sat, 24 Nov 2018 01:51:14 +0000 (01:51 +0000)]
split up maildir/mh code

6 years agomove timespec functions to library
Richard Russon [Sun, 25 Nov 2018 15:32:48 +0000 (15:32 +0000)]
move timespec functions to library

6 years agoHow to run shell commands in global-hooks
Florian Wehner [Sat, 24 Nov 2018 13:52:42 +0000 (14:52 +0100)]
How to run shell commands in global-hooks

Addition is based on issue https://github.com/neomutt/neomutt/issues/1353

6 years agofactor out Context from maildir functions
Richard Russon [Fri, 23 Nov 2018 00:47:47 +0000 (00:47 +0000)]
factor out Context from maildir functions

6 years agomove backend-specific code
Austin Ray [Fri, 23 Nov 2018 12:41:55 +0000 (12:41 +0000)]
move backend-specific code

6 years agoimap: handle EXPUNGE and EXISTS during one pipeline 1449/head
Mehdi Abaakouk [Thu, 22 Nov 2018 08:13:23 +0000 (09:13 +0100)]
imap: handle EXPUNGE and EXISTS during one pipeline

Receiving EXPUNGE, VANISHED and EXISTS during the same imap pipelined
command is perfectly valid.

Currently when EXPUNGE/VANISHED is handled we ignore EXISTS, making
msn_index not updated. Then MUTT_REOPEN refreshes the mailbox where last
received messages are missing.

6 years agoDon't open the same mailbox twice
Mehdi Abaakouk [Wed, 21 Nov 2018 17:59:35 +0000 (18:59 +0100)]
Don't open the same mailbox twice

6 years agodoxygen: fix comments
Richard Russon [Thu, 22 Nov 2018 14:23:01 +0000 (14:23 +0000)]
doxygen: fix comments

[ci skip]

6 years agomerge: factor out Context
Richard Russon [Thu, 22 Nov 2018 13:46:30 +0000 (13:46 +0000)]
merge: factor out Context

 * notmuch: factor out Context
 * factor out Context from msg_padding_size()
 * factor out Context from tags_commit()
 * factor out Context from tags_edit()
 * factor out Context from mx_tags_is_supported()
 * light tidying
 * move Context flags to Mailbox
 * factor out Context from mx_msg_commit()
 * factor out Context from mutt_newsgroup_catchup()
 * factor out Context from mutt_newsgroup_uncatchup()
 * factor out Context from find_subject()
 * factor out Context from make_subj_hash()
 * factor out Context from check_subjects()
 * factor out Context from mbox_open_append()
 * factor out Context from mutt_messages_in_thread()
 * factor out Context from link_threads()
 * factor out Context from mx_toggle_write()
 * factor out Context from mutt_score_message()
 * factor out Context from maildir_update_flags()
 * factor out Context from mutt_check_rescore()
 * factor out Context from mutt_prepare_template()
 * factor out Context from append_message()
 * factor out Context from mutt_append_message()
 * factor out Context from mutt_set_flag_update()
 * factor out Context from mutt_copy_message_ctx()
 * factor out Context from mutt_save_message_ctx()
 * factor out Context from mutt_make_message_attach()
 * factor out Context from trash_append()
 * factor out Context from edit_or_view_one_message()

6 years agofactor out Context from edit_or_view_one_message()
Richard Russon [Thu, 22 Nov 2018 13:26:14 +0000 (13:26 +0000)]
factor out Context from edit_or_view_one_message()

6 years agofactor out Context from trash_append()
Richard Russon [Thu, 22 Nov 2018 13:24:40 +0000 (13:24 +0000)]
factor out Context from trash_append()

6 years agofactor out Context from mutt_make_message_attach()
Richard Russon [Thu, 22 Nov 2018 13:22:15 +0000 (13:22 +0000)]
factor out Context from mutt_make_message_attach()

6 years agofactor out Context from mutt_save_message_ctx()
Richard Russon [Thu, 22 Nov 2018 13:13:24 +0000 (13:13 +0000)]
factor out Context from mutt_save_message_ctx()

6 years agofactor out Context from mutt_copy_message_ctx()
Richard Russon [Thu, 22 Nov 2018 13:11:12 +0000 (13:11 +0000)]
factor out Context from mutt_copy_message_ctx()

6 years agofactor out Context from mutt_set_flag_update()
Richard Russon [Thu, 22 Nov 2018 13:07:17 +0000 (13:07 +0000)]
factor out Context from mutt_set_flag_update()

6 years agofactor out Context from mutt_append_message()
Richard Russon [Thu, 22 Nov 2018 13:01:49 +0000 (13:01 +0000)]
factor out Context from mutt_append_message()

6 years agofactor out Context from append_message()
Richard Russon [Thu, 22 Nov 2018 12:58:05 +0000 (12:58 +0000)]
factor out Context from append_message()

6 years agofactor out Context from mutt_prepare_template()
Richard Russon [Thu, 22 Nov 2018 12:49:34 +0000 (12:49 +0000)]
factor out Context from mutt_prepare_template()

6 years agofactor out Context from mutt_check_rescore()
Richard Russon [Thu, 22 Nov 2018 12:45:21 +0000 (12:45 +0000)]
factor out Context from mutt_check_rescore()

6 years agofactor out Context from maildir_update_flags()
Richard Russon [Thu, 22 Nov 2018 12:44:03 +0000 (12:44 +0000)]
factor out Context from maildir_update_flags()

6 years agofactor out Context from mutt_score_message()
Richard Russon [Thu, 22 Nov 2018 12:38:22 +0000 (12:38 +0000)]
factor out Context from mutt_score_message()

6 years agofactor out Context from mx_toggle_write()
Richard Russon [Thu, 22 Nov 2018 12:35:43 +0000 (12:35 +0000)]
factor out Context from mx_toggle_write()

6 years agofactor out Context from link_threads()
Richard Russon [Thu, 22 Nov 2018 12:28:22 +0000 (12:28 +0000)]
factor out Context from link_threads()

6 years agofactor out Context from mutt_messages_in_thread()
Richard Russon [Thu, 22 Nov 2018 12:27:40 +0000 (12:27 +0000)]
factor out Context from mutt_messages_in_thread()

6 years agofactor out Context from mbox_open_append()
Richard Russon [Thu, 22 Nov 2018 12:24:00 +0000 (12:24 +0000)]
factor out Context from mbox_open_append()

6 years agofactor out Context from check_subjects()
Richard Russon [Thu, 22 Nov 2018 12:17:30 +0000 (12:17 +0000)]
factor out Context from check_subjects()

6 years agofactor out Context from make_subj_hash()
Richard Russon [Thu, 22 Nov 2018 12:16:37 +0000 (12:16 +0000)]
factor out Context from make_subj_hash()

6 years agofactor out Context from find_subject()
Richard Russon [Thu, 22 Nov 2018 12:13:29 +0000 (12:13 +0000)]
factor out Context from find_subject()

6 years agofactor out Context from mutt_newsgroup_uncatchup()
Richard Russon [Thu, 22 Nov 2018 11:49:23 +0000 (11:49 +0000)]
factor out Context from mutt_newsgroup_uncatchup()

6 years agofactor out Context from mutt_newsgroup_catchup()
Richard Russon [Thu, 22 Nov 2018 11:48:29 +0000 (11:48 +0000)]
factor out Context from mutt_newsgroup_catchup()

6 years agofactor out Context from mx_msg_commit()
Richard Russon [Wed, 21 Nov 2018 15:18:16 +0000 (15:18 +0000)]
factor out Context from mx_msg_commit()

6 years agomove Context flags to Mailbox
Richard Russon [Wed, 21 Nov 2018 14:59:25 +0000 (14:59 +0000)]
move Context flags to Mailbox

6 years agolight tidying
Richard Russon [Wed, 21 Nov 2018 14:48:19 +0000 (14:48 +0000)]
light tidying

6 years agofactor out Context from mx_tags_is_supported()
Richard Russon [Wed, 21 Nov 2018 14:47:47 +0000 (14:47 +0000)]
factor out Context from mx_tags_is_supported()

6 years agofactor out Context from tags_edit()
Richard Russon [Wed, 21 Nov 2018 14:45:46 +0000 (14:45 +0000)]
factor out Context from tags_edit()

6 years agofactor out Context from tags_commit()
Richard Russon [Wed, 21 Nov 2018 14:26:00 +0000 (14:26 +0000)]
factor out Context from tags_commit()

6 years agofactor out Context from msg_padding_size()
Richard Russon [Wed, 21 Nov 2018 14:25:41 +0000 (14:25 +0000)]
factor out Context from msg_padding_size()

6 years agonotmuch: factor out Context
Richard Russon [Wed, 21 Nov 2018 14:18:48 +0000 (14:18 +0000)]
notmuch: factor out Context

6 years agoUse Mailbox instead of Context
Mehdi Abaakouk [Wed, 21 Nov 2018 08:51:04 +0000 (09:51 +0100)]
Use Mailbox instead of Context

This aims to remove Context from mutt_set_flag, to do so other function
signature have been changed too.

* mutt_set_flag_update
* mx_msg_open
* mx_msg_open_new
* mx_msg_close
* mutt_pattern_exec
* mutt_parse_mime_message
* mutt_set_header_color
* mutt_count_body_parts

6 years agomove ctx->tagged to mailbox->msg_tagged
Mehdi Abaakouk [Tue, 20 Nov 2018 22:58:03 +0000 (23:58 +0100)]
move ctx->tagged to mailbox->msg_tagged

6 years agoimap: remove unused define
Mehdi Abaakouk [Tue, 20 Nov 2018 17:20:17 +0000 (18:20 +0100)]
imap: remove unused define

6 years agoKeep adata on imap-logout-all
Pietro Cerutti [Tue, 20 Nov 2018 15:16:22 +0000 (15:16 +0000)]
Keep adata on imap-logout-all

The former call to `imap_adata_free((void **) adata);` caused an account to be around with no adata associated with it. This caused a crash when trying to access the account later on.