Daniel Stenberg [Fri, 9 Jan 2015 20:55:31 +0000 (21:55 +0100)]
NSS: fix compiler error when built http2-enabled
Steve Holme [Fri, 9 Jan 2015 20:29:26 +0000 (20:29 +0000)]
gssapi: Remove need for duplicated GSS_C_NT_HOSTBASED_SERVICE definitions
Better code reuse and consistency in calls to gss_import_name().
Daniel Stenberg [Thu, 8 Jan 2015 19:43:32 +0000 (20:43 +0100)]
FTP: if EPSV fails on IPV6 connections, bail out
... instead of trying PASV, since PASV can't work with IPv6.
Reported-by: Vojtěch Král
Daniel Stenberg [Thu, 8 Jan 2015 17:30:01 +0000 (18:30 +0100)]
FTP: fix IPv6 host using link-local address
... and make sure we can connect the data connection to a host name that
is longer than 48 bytes.
Also simplifies the code somewhat by re-using the original host name
more, as it is likely still in the DNS cache.
Original-Patch-by: Vojtěch Král
Bug: http://curl.haxx.se/bug/view.cgi?id=1468
Sam Schanken [Mon, 29 Dec 2014 18:57:21 +0000 (10:57 -0800)]
winbuild: Added option to build with c-ares
Added support for a WITH_CARES option to be used when invoking nmake
via Makefile.vc. This option enables linking against both the DLL and
static versions of the c-ares libraries, as well as the debug and
release varients, depending on the value of DEBUG. The USE_ARES
preprocessor symbol is also defined.
Guenter Knauf [Thu, 8 Jan 2015 20:40:35 +0000 (21:40 +0100)]
NetWare build: added TLS-SRP enabled build.
Steve Holme [Thu, 8 Jan 2015 19:23:53 +0000 (19:23 +0000)]
sasl_gssapi: Fixed build on NetBSD with built-in GSS-API
Bug: http://curl.haxx.se/bug/view.cgi?id=1469
Reported-by: Thomas Klausner
Daniel Stenberg [Thu, 8 Jan 2015 09:00:28 +0000 (10:00 +0100)]
bump: start working towards 7.40.1
Daniel Stenberg [Thu, 8 Jan 2015 08:57:19 +0000 (09:57 +0100)]
THANKS: 14 new contributors from the 7.40.0 release notes
Daniel Stenberg [Wed, 7 Jan 2015 22:08:53 +0000 (23:08 +0100)]
RELEASE-NOTES: version 7.40.0
Daniel Stenberg [Fri, 19 Dec 2014 07:50:00 +0000 (08:50 +0100)]
darwinssl: fix session ID keys to only reuse identical sessions
...to avoid a session ID getting cached without certificate checking and
then after a subsequent _enabling_ of the check libcurl could still
re-use the session done without cert checks.
Bug: http://curl.haxx.se/docs/adv_20150108A.html
Reported-by: Marc Hesse
Daniel Stenberg [Thu, 25 Dec 2014 22:51:43 +0000 (23:51 +0100)]
tests: make sure CRLFs can't be used in URLs passed to proxy
Bug: http://curl.haxx.se/docs/adv_20150108B.html
Daniel Stenberg [Thu, 25 Dec 2014 22:55:03 +0000 (23:55 +0100)]
url-parsing: reject CRLFs within URLs
Bug: http://curl.haxx.se/docs/adv_20150108B.html
Reported-by: Andrey Labunets
Steve Holme [Wed, 7 Jan 2015 19:45:24 +0000 (19:45 +0000)]
ldap: Convert attribute output to UTF-8 when Unicode
Steve Holme [Wed, 7 Jan 2015 19:19:20 +0000 (19:19 +0000)]
ldap: Convert DN output to UTF-8 when Unicode
Daniel Stenberg [Tue, 6 Jan 2015 22:01:43 +0000 (22:01 +0000)]
hostip: remove 'stale' argument from Curl_fetch_addr proto
Also, remove the log output of the resolved name is NOT in the cache in
the spirit of only telling when something is actually happening.
Steve Holme [Wed, 7 Jan 2015 13:50:56 +0000 (13:50 +0000)]
ldap/imap: Fixed spelling mistake in comments and variable names
Reported-by: Michael Osipov
Daniel Stenberg [Wed, 7 Jan 2015 11:41:02 +0000 (12:41 +0100)]
RELEASE-NOTES: updated with ./contributors.sh output
Dan Fandrich [Mon, 5 Jan 2015 09:08:08 +0000 (10:08 +0100)]
curl_multibyte.h: Eliminated some trailing whitespace
Steve Holme [Sun, 4 Jan 2015 22:58:19 +0000 (22:58 +0000)]
RELEASE-NOTES: Synced with
ea93252ef1
Steve Holme [Sat, 3 Jan 2015 21:54:11 +0000 (21:54 +0000)]
ldap: Fixed Unicode usage for all Win32 builds
Otherwise, the fixes in the previous commits would only be applicable
to IDN and SSPI based builds and not others such as OpenSSL with LDAP
enabled.
Steve Holme [Sun, 4 Jan 2015 20:33:58 +0000 (20:33 +0000)]
ldap: Fixed memory leak from commit
efb64fdf80
Steve Holme [Sun, 4 Jan 2015 20:06:04 +0000 (20:06 +0000)]
ldap: Fix memory leak from commit
3a805c5cc1
Steve Holme [Sat, 3 Jan 2015 21:19:11 +0000 (21:19 +0000)]
ldap: Fixed attribute variable warnings when Unicode is enabled
Use 'TCHAR *' for local attribute variable rather than 'char *'.
Steve Holme [Sat, 3 Jan 2015 21:12:56 +0000 (21:12 +0000)]
ldap: Fixed DN variable warnings when Unicode is enabled
Use 'TCHAR *' for local DN variable rather than 'char *'.
Steve Holme [Sat, 3 Jan 2015 21:04:13 +0000 (21:04 +0000)]
ldap: Remove the unescape_elements() function
Due to the recent modifications this function is no longer used.
Steve Holme [Sun, 4 Jan 2015 16:11:08 +0000 (16:11 +0000)]
ldap.c: Fixed compilation warning
ldap.c:98: warning: extra tokens at end of #endif directive
Steve Holme [Sat, 3 Jan 2015 20:58:29 +0000 (20:58 +0000)]
ldap: Fixed support for Unicode filter in Win32 search call
Steve Holme [Sun, 4 Jan 2015 15:16:04 +0000 (15:16 +0000)]
ldap.c: Fixed compilation warning
ldap.c:802: warning: comparison between signed and unsigned integer
expressions
Steve Holme [Sat, 3 Jan 2015 20:49:11 +0000 (20:49 +0000)]
ldap: Fixed support for Unicode attributes in Win32 search call
Steve Holme [Sun, 4 Jan 2015 14:11:02 +0000 (14:11 +0000)]
ldap: Fixed memory leak from commit
efb64fdf80
The unescapped DN was not freed after a successful character conversion.
Steve Holme [Sun, 4 Jan 2015 13:08:12 +0000 (13:08 +0000)]
ldap.c: Fixed compilation error
ldap.c:738: error: macro "LDAP_TRACE" passed 2 arguments, but takes
just 1
Steve Holme [Sun, 4 Jan 2015 13:04:06 +0000 (13:04 +0000)]
ldap.c: Fixed compilation warning
ldap.c:89: warning: extra tokens at end of #endif directive
Steve Holme [Sat, 3 Jan 2015 20:36:10 +0000 (20:36 +0000)]
ldap: Fixed support for Unicode DN in Win32 search call
Steve Holme [Sat, 3 Jan 2015 20:16:26 +0000 (20:16 +0000)]
ldap: Fixed Unicode user and password in Win32 bind calls
Steve Holme [Sat, 3 Jan 2015 19:59:12 +0000 (19:59 +0000)]
ldap: Fixed Unicode host name in Win32 initialisation calls
Steve Holme [Sat, 3 Jan 2015 19:45:30 +0000 (19:45 +0000)]
ldap: Use host.dispname for infof() connection failure messages
As host.name may be encoded use dispname for infof() failure messages.
Steve Holme [Sat, 3 Jan 2015 17:45:51 +0000 (17:45 +0000)]
ldap: Prefer 'CURLcode result' for curl result codes
Steve Holme [Sat, 3 Jan 2015 17:39:23 +0000 (17:39 +0000)]
ldap: Pass write length in all Curl_client_write() calls
As we get the length for the DN and attribute variables, and we know
the length for the line terminator, pass the length values rather than
zero as this will save Curl_client_write() from having to perform an
additional strlen() call.
Steve Holme [Sat, 3 Jan 2015 17:25:11 +0000 (17:25 +0000)]
ldap: Fixed attribute memory leaks on failed client write
Fixed memory leaks from commit
086ad79970 as was noted in the commit
comments.
Steve Holme [Sat, 3 Jan 2015 17:05:50 +0000 (17:05 +0000)]
ldap: Fixed DN memory leaks on failed client write
Fixed memory leaks from commit
086ad79970 as was noted in the commit
comments.
Steve Holme [Fri, 2 Jan 2015 21:09:24 +0000 (21:09 +0000)]
curl_ntlm_core.c: Fixed compilation warning from commit
1cb17b2a5d
curl_ntlm_core.c:146: warning: passing 'DES_cblock' (aka 'unsigned char
[8]') to parameter of type 'char *' converts
between pointers to integer types with different
sign
Steve Holme [Fri, 2 Jan 2015 19:59:41 +0000 (19:59 +0000)]
ntlm: Use extend_key_56_to_64() for all cryptography engines
Rather than duplicate the code in setup_des_key() for OpenSSL and in
extend_key_56_to_64() for non-OpenSSL based crypto engines, as it is
the same, use extend_key_56_to_64() for all engines.
Steve Holme [Fri, 2 Jan 2015 17:19:49 +0000 (17:19 +0000)]
RELEASE-NOTES: Synced with
34f0bd110f
Steve Holme [Fri, 2 Jan 2015 16:28:03 +0000 (16:28 +0000)]
curl_ntlm_core.c: Fixed compilation warning
curl_ntlm_core.c:458: warning: 'ascii_uppercase_to_unicode_le' defined
but not used
Steve Holme [Fri, 2 Jan 2015 15:53:42 +0000 (15:53 +0000)]
endian: Fixed bit-shift in 64-bit integer read functions
From commit
43792592ca and
4bb5a351b2.
Reported-by: Michael Osipov
Steve Holme [Thu, 1 Jan 2015 20:48:05 +0000 (20:48 +0000)]
smb: Use endian functions for reading NBT and message size values
Steve Holme [Thu, 1 Jan 2015 20:26:17 +0000 (20:26 +0000)]
endian: Added big endian read functions
Steve Holme [Thu, 1 Jan 2015 20:09:50 +0000 (20:09 +0000)]
endian: Added 64-bit integer read function
Steve Holme [Thu, 1 Jan 2015 05:04:14 +0000 (05:04 +0000)]
COPYING: Bumped copyright year to 2015
Steve Holme [Thu, 1 Jan 2015 05:02:38 +0000 (05:02 +0000)]
version: Bump copyright year to 2015
Steve Holme [Thu, 1 Jan 2015 04:56:16 +0000 (04:56 +0000)]
smb.c: Fixed compilation warnings
smb.c:780: warning: passing 'char *' to parameter of type 'unsigned
char *' converts between pointers to integer types with
different sign
smb.c:781: warning: passing 'char *' to parameter of type 'unsigned
char *' converts between pointers to integer types with
different sign
smb.c:804: warning: passing 'char *' to parameter of type 'unsigned
char *' converts between pointers to integer types with
different sign
Steve Holme [Wed, 31 Dec 2014 16:07:32 +0000 (16:07 +0000)]
smb: Use endian functions for reading length and offset values
Steve Holme [Wed, 31 Dec 2014 15:58:07 +0000 (15:58 +0000)]
endian: Added 16-bit integer write function
Steve Holme [Wed, 31 Dec 2014 14:02:25 +0000 (14:02 +0000)]
endian: Fixed Linux compilation issues
Having files named endian.[c|h] seemed to cause issues under Linux so
renamed them both to have the curl_ prefix in the filenames.
Julien Nabet [Wed, 31 Dec 2014 12:25:09 +0000 (13:25 +0100)]
lib1900.c: Fixed cppcheck error
lib1900.c:182: (style) Array index 'handlenum' is used before limits
check
Bug: https://github.com/bagder/curl/pull/133
Steve Holme [Wed, 31 Dec 2014 11:59:39 +0000 (11:59 +0000)]
endian: Added standard function descriptions
Steve Holme [Wed, 31 Dec 2014 11:56:08 +0000 (11:56 +0000)]
endian: Renamed functions for curl API naming convention
Steve Holme [Wed, 31 Dec 2014 11:47:54 +0000 (11:47 +0000)]
endian: Moved write functions to new module
Steve Holme [Wed, 31 Dec 2014 11:40:16 +0000 (11:40 +0000)]
endian: Moved read functions to new module
Steve Holme [Wed, 31 Dec 2014 11:31:31 +0000 (11:31 +0000)]
endian: Introduced endian module
To allow the little endian functions, currently used in two of the NTLM
source files, to be used by other modules such as the SMB module.
Steve Holme [Wed, 31 Dec 2014 11:11:34 +0000 (11:11 +0000)]
sepheaders.c: Applied curl oding standards
Julien Nabet [Wed, 31 Dec 2014 10:40:28 +0000 (11:40 +0100)]
sepheaders.c: Fixed resource leak on failure
Steve Holme [Tue, 30 Dec 2014 17:08:16 +0000 (17:08 +0000)]
vtls: Use '(void) arg' for unused parameters
Prefer void for unused parameters, rather than assigning an argument to
itself as a) unintelligent compilers won't optimize it out, b) it can't
be used for const parameters, c) it will cause compilation warnings for
clang with -Wself-assign and d) is inconsistent with other areas of the
curl source code.
Steve Holme [Tue, 30 Dec 2014 15:42:17 +0000 (15:42 +0000)]
smb.c: Fixed compilation warning
smb.c:586: warning: conversion to 'short unsigned int' from 'int' may
alter its value
Bill Nagel [Tue, 30 Dec 2014 13:09:31 +0000 (08:09 -0500)]
smb: Use the connection's upload buffer
Use the connection's upload buffer instead of allocating our own send
buffer.
Steve Holme [Tue, 30 Dec 2014 00:27:59 +0000 (00:27 +0000)]
RELEASE-NOTES: Synced with
1933f9d33c
Steve Holme [Tue, 30 Dec 2014 00:11:27 +0000 (00:11 +0000)]
schannel: Moved the ISC return flag definitions to the SSPI module
Moved our Initialize Security Context return attribute definitions to
the SSPI module, as a) these can be used by other SSPI based providers
and b) the ISC required attributes are defined there.
Bill Nagel [Mon, 29 Dec 2014 21:04:04 +0000 (16:04 -0500)]
smb: Close the connection after a failed client write
Steve Holme [Sun, 28 Dec 2014 21:29:26 +0000 (21:29 +0000)]
darwinssl: Fixed compilation warning
vtls.c:683:43: warning: unused parameter 'data'
Steve Holme [Sun, 28 Dec 2014 20:54:16 +0000 (20:54 +0000)]
sockfilt.c: Fixed compilation warnings
sockfilt.c:288: warning: conversion to 'DWORD' from 'size_t' may alter
its value
sockfilt.c:291: warning: conversion to 'DWORD' from 'size_t' may alter
its value
sockfilt.c:323: warning: conversion to 'DWORD' from 'size_t' may alter
its value
sockfilt.c:326: warning: conversion to 'DWORD' from 'size_t' may alter
its value
Steve Holme [Sun, 28 Dec 2014 20:43:16 +0000 (20:43 +0000)]
test1509: Fixed compilation warning
lib1509.c:93:18: warning: conversion to 'long int' from 'size_t' may
alter its value
Steve Holme [Sun, 28 Dec 2014 20:32:46 +0000 (20:32 +0000)]
test556: Fixed compilation warning
lib556.c:90: warning: conversion to 'unsigned int' from 'size_t' may
alter its value
Steve Holme [Sun, 28 Dec 2014 19:19:14 +0000 (19:19 +0000)]
sasl_gssapi: Fixed use of dummy username with real username
Steve Holme [Sun, 28 Dec 2014 17:21:02 +0000 (17:21 +0000)]
vtls: Fixed compilation warning and an ignored return code
curl_schannel.h:123: warning: right-hand operand of comma expression
has no effect
Some instances of the curlssl_close_all() function were declared with a
void return type whilst others as int. The schannel version returned
CURLE_NOT_BUILT_IN and others simply returned zero, but in all cases the
return code was ignored by the calling function Curl_ssl_close_all().
For the time being and to keep the internal API consistent, changed all
declarations to use a void return type.
To reduce code we might want to consider removing the unimplemented
versions and use a void #define like schannel does.
Daniel Stenberg [Sun, 28 Dec 2014 15:30:03 +0000 (16:30 +0100)]
TODO: 2.3 Better support for same name resolves
Steve Holme [Sun, 28 Dec 2014 13:01:11 +0000 (13:01 +0000)]
test1520: Fixed initial teething problems
* Missing initialisation of upload status caused a seg fault
* Missing data termination caused corrupt data to be uploaded
* Data verification should be performed in <upload> element
* Added missing recipient list cleanup
Steve Holme [Sun, 28 Dec 2014 12:46:17 +0000 (12:46 +0000)]
test1520: Fixed compilation errors
Steve Holme [Sun, 28 Dec 2014 12:12:09 +0000 (12:12 +0000)]
tests: Added test for bug #1456
Steve Holme [Sun, 28 Dec 2014 01:10:03 +0000 (01:10 +0000)]
checksrc.bat: Fixed a problem opening files with spaces in the filename
Steve Holme [Sat, 27 Dec 2014 21:22:45 +0000 (21:22 +0000)]
openldap: Prefer use of 'CURLcode result'
Steve Holme [Sat, 27 Dec 2014 21:07:53 +0000 (21:07 +0000)]
openldap: Use 'LDAPMessage *msg' for messages
This frees up the 'result' variable for CURLcode based result codes.
Steve Holme [Sat, 27 Dec 2014 20:57:33 +0000 (20:57 +0000)]
nss: Don't ignore Curl_extract_certinfo() OOM failure
Steve Holme [Sat, 27 Dec 2014 20:50:14 +0000 (20:50 +0000)]
nss: Don't ignore Curl_ssl_init_certinfo() OOM failure
Steve Holme [Sat, 27 Dec 2014 21:35:36 +0000 (21:35 +0000)]
nss: Use 'CURLcode result' for curl result codes
...and don't use CURLE_OK in failure/success comparisons.
Steve Holme [Sat, 27 Dec 2014 17:46:27 +0000 (17:46 +0000)]
getinfo: Code style policing
Steve Holme [Sat, 27 Dec 2014 17:42:21 +0000 (17:42 +0000)]
getinfo: Use 'CURLcode result' for curl result codes
Steve Holme [Sat, 27 Dec 2014 17:36:35 +0000 (17:36 +0000)]
darwinssl: Use 'CURLcode result' for curl result codes
Steve Holme [Sat, 27 Dec 2014 17:20:38 +0000 (17:20 +0000)]
polarssl: Use 'CURLcode result' for curl result codes
Steve Holme [Sat, 27 Dec 2014 11:36:13 +0000 (11:36 +0000)]
docs: Updated following the addition of SASL GSSAPI via GSS-API libraries
As this feature has been implemented for 7.40.0.
Steve Holme [Sat, 27 Dec 2014 11:31:43 +0000 (11:31 +0000)]
asiohiper.cpp: No need to initialise members of ConnInfo
...as calloc() automatically clears the area of memory with zeros.
Steve Holme [Sat, 27 Dec 2014 11:29:58 +0000 (11:29 +0000)]
asiohiper.cpp: Updated for curl coding standards
...with the exception of the start of block statement curly brackets.
Steve Holme [Sat, 27 Dec 2014 11:09:01 +0000 (11:09 +0000)]
code/docs: Use correct case for IPv4 and IPv6
For consistency, as we seem to have a bit of a mixed bag, changed all
instances of ipv4 and ipv6 in comments and documentations to use the
correct case.
Steve Holme [Sat, 27 Dec 2014 10:40:41 +0000 (10:40 +0000)]
runtests: Fixed detection of Unix Sockets feature
...following change in curl --version output.
Steve Holme [Fri, 26 Dec 2014 20:45:21 +0000 (20:45 +0000)]
code/docs: Use Unix rather than UNIX to avoid use of the trademark
Use Unix when generically writing about Unix based systems as UNIX is
the trademark and should only be used in a particular product's name.
Steve Holme [Fri, 26 Dec 2014 13:28:29 +0000 (13:28 +0000)]
ip2ip.c: Fixed compilation warning when IPv6 Scope ID not supported
if2ip.c:119: warning: unused parameter 'remote_scope_id'
...and some minor code style policing in the same function.
Steve Holme [Fri, 26 Dec 2014 11:58:17 +0000 (11:58 +0000)]
vtls: Don't set cert info count until memory allocation is successful
Otherwise Curl_ssl_init_certinfo() can fail and set the num_of_certs
member variable to the requested count, which could then be used
incorrectly as libcurl closes down.
Steve Holme [Fri, 26 Dec 2014 11:53:34 +0000 (11:53 +0000)]
vtls: Use CURLcode for Curl_ssl_init_certinfo() return type
The return type for this function was 0 on success and 1 on error. This
was then examined by the calling functions and, in most cases, used to
return CURLE_OUT_OF_MEMORY.
Instead use CURLcode for the return type and return the out of memory
error directly, propagating it up the call stack.
Steve Holme [Fri, 26 Dec 2014 11:38:30 +0000 (11:38 +0000)]
configure: Use camel case for UNIX sockets feature output
To match the curl --version output.
Marc Hoersken [Fri, 26 Dec 2014 09:41:40 +0000 (10:41 +0100)]
sockfilt.c: Reduce the number of individual memory allocations
Merge multiple internal arrays into one, even if some variables
will not not be used. They are all created with the number of
file descriptors as their size.
Also fix possible thread handle leak in CloseHandle-loop.