]> granicus.if.org Git - python/log
python
12 years ago#15199: Fix JavaScript's default MIME type to application/javascript
Petri Lehtinen [Mon, 20 Aug 2012 18:30:03 +0000 (21:30 +0300)]
#15199: Fix JavaScript's default MIME type to application/javascript

12 years ago#15199: Fix JavaScript's default MIME type to application/javascript
Petri Lehtinen [Mon, 20 Aug 2012 18:05:56 +0000 (21:05 +0300)]
#15199: Fix JavaScript's default MIME type to application/javascript

12 years agoMerge #15742: clarify sqlite parameter substitution example.
R David Murray [Mon, 20 Aug 2012 18:14:46 +0000 (14:14 -0400)]
Merge #15742: clarify sqlite parameter substitution example.

Suggestion and patch by Mike Hoy.

12 years ago#15742: clarify sqlite parameter substitution example.
R David Murray [Mon, 20 Aug 2012 18:14:18 +0000 (14:14 -0400)]
#15742: clarify sqlite parameter substitution example.

Suggestion and patch by Mike Hoy.

12 years agoIssue #15726: Fix incorrect bounds checking in PyState_FindModule.
Antoine Pitrou [Mon, 20 Aug 2012 17:31:52 +0000 (19:31 +0200)]
Issue #15726: Fix incorrect bounds checking in PyState_FindModule.
Patch by Robin Schreiber.

12 years agoIssue #15726: Fix incorrect bounds checking in PyState_FindModule.
Antoine Pitrou [Mon, 20 Aug 2012 17:30:46 +0000 (19:30 +0200)]
Issue #15726: Fix incorrect bounds checking in PyState_FindModule.
Patch by Robin Schreiber.

12 years agoMerge 3.2.
Stefan Krah [Mon, 20 Aug 2012 15:20:46 +0000 (17:20 +0200)]
Merge 3.2.

12 years agoIssue #15741: Fix potential NULL dereference. Found by Coverity.
Stefan Krah [Mon, 20 Aug 2012 15:19:50 +0000 (17:19 +0200)]
Issue #15741: Fix potential NULL dereference. Found by Coverity.

12 years agoCheck return value of asdl_seq_new(). Found by Coverity.
Stefan Krah [Mon, 20 Aug 2012 14:07:38 +0000 (16:07 +0200)]
Check return value of asdl_seq_new(). Found by Coverity.

12 years agoIssue #12643: Respect sys.excepthook in code.InteractiveConsole
Nick Coghlan [Mon, 20 Aug 2012 13:02:28 +0000 (23:02 +1000)]
Issue #12643: Respect sys.excepthook in code.InteractiveConsole

12 years agoMerge 3.2.
Stefan Krah [Mon, 20 Aug 2012 12:42:59 +0000 (14:42 +0200)]
Merge 3.2.

12 years agoIssue #15738: Fix a missing NULL check in subprocess_fork_exec().
Stefan Krah [Mon, 20 Aug 2012 12:36:47 +0000 (14:36 +0200)]
Issue #15738: Fix a missing NULL check in subprocess_fork_exec().

12 years agoCloses #15737: Fix potential NULL dereference in zipimport.c.
Stefan Krah [Mon, 20 Aug 2012 12:14:49 +0000 (14:14 +0200)]
Closes #15737: Fix potential NULL dereference in zipimport.c.

12 years agoMerge 3.2.
Stefan Krah [Mon, 20 Aug 2012 09:13:58 +0000 (11:13 +0200)]
Merge 3.2.

12 years agoIssue #15732: Fix (constructed) crash in _PySequence_BytesToCharpArray().
Stefan Krah [Mon, 20 Aug 2012 09:04:24 +0000 (11:04 +0200)]
Issue #15732: Fix (constructed) crash in _PySequence_BytesToCharpArray().
Found by Coverity.

12 years agoBreak up the 'someos' docs classification based on a more user-focused scheme, includ...
Nick Coghlan [Mon, 20 Aug 2012 08:05:46 +0000 (18:05 +1000)]
Break up the 'someos' docs classification based on a more user-focused scheme, including creation of a separate 'Concurrent Execution' section

12 years agoClose #4966: revamp the sequence docs in order to better explain the state of modern...
Nick Coghlan [Mon, 20 Aug 2012 07:14:07 +0000 (17:14 +1000)]
Close #4966: revamp the sequence docs in order to better explain the state of modern Python

12 years agos/path importer/path based finder/ (because the path based finder is not an importer...
Nick Coghlan [Mon, 20 Aug 2012 03:49:08 +0000 (13:49 +1000)]
s/path importer/path based finder/ (because the path based finder is not an importer and the simpler 'path finder' is too ambiguous)

12 years agoClose #14846: Handle a sys.path entry going away
Nick Coghlan [Mon, 20 Aug 2012 03:18:15 +0000 (13:18 +1000)]
Close #14846: Handle a sys.path entry going away

12 years agoClose #14814: Avoid depending on struct by using newer features. Also use enumerate...
Nick Coghlan [Mon, 20 Aug 2012 00:19:12 +0000 (10:19 +1000)]
Close #14814: Avoid depending on struct by using newer features. Also use enumerate where appropriate (patch by Serhiy Storchaka). Declaring PEP 3144 final at this point - any further changes to code or docs can go in new issues.

12 years agoIssue #14814: document the Interface APIs and fix various problems with the string...
Nick Coghlan [Mon, 20 Aug 2012 00:04:26 +0000 (10:04 +1000)]
Issue #14814: document the Interface APIs and fix various problems with the string representations (initial patch by Eli Bendersky).

12 years agoMerge #13579: teach string.Formatter about 'a'.
R David Murray [Sun, 19 Aug 2012 21:45:40 +0000 (17:45 -0400)]
Merge #13579: teach string.Formatter about 'a'.

Patch by Francisco Martín Brugué.

12 years ago#13579: teach string.Formatter about 'a'.
R David Murray [Sun, 19 Aug 2012 21:26:34 +0000 (17:26 -0400)]
#13579: teach string.Formatter about 'a'.

Patch by Francisco Martín Brugué.

12 years agoIssue #15728: Fix leak in PyUnicode_AsWideCharString(). Found by Coverity.
Stefan Krah [Sun, 19 Aug 2012 19:52:43 +0000 (21:52 +0200)]
Issue #15728: Fix leak in PyUnicode_AsWideCharString(). Found by Coverity.

12 years agoIssue #15595: Fix subprocess.Popen(universal_newlines=True)
Andrew Svetlov [Sun, 19 Aug 2012 19:20:03 +0000 (22:20 +0300)]
Issue #15595: Fix subprocess.Popen(universal_newlines=True)
for certain locales (utf-16 and utf-32 family).

Patch by Chris Jerdonek.

12 years agoIssue #15595: Fix subprocess.Popen(universal_newlines=True)
Andrew Svetlov [Sun, 19 Aug 2012 19:13:41 +0000 (22:13 +0300)]
Issue #15595: Fix subprocess.Popen(universal_newlines=True)
for certain locales (utf-16 and utf-32 family).

Patch by Chris Jerdonek.

12 years agoUse Thread.is_alive() instead of old-style Thread.isAlive() in subprocess.
Andrew Svetlov [Sun, 19 Aug 2012 17:49:39 +0000 (20:49 +0300)]
Use Thread.is_alive() instead of old-style Thread.isAlive() in subprocess.

12 years agoFixes #14668. Mention Windows Path manipulation option in the installer.
Brian Curtin [Sun, 19 Aug 2012 16:22:20 +0000 (11:22 -0500)]
Fixes #14668. Mention Windows Path manipulation option in the installer.

12 years agoBrush subprocess tests a bit.
Andrew Svetlov [Sun, 19 Aug 2012 13:25:37 +0000 (16:25 +0300)]
Brush subprocess tests a bit.

12 years agoThe latest NumPy revision no longer segfaults here.
Stefan Krah [Sun, 19 Aug 2012 10:54:50 +0000 (12:54 +0200)]
The latest NumPy revision no longer segfaults here.

12 years agoFix out-of-date comment in test_memoryview.
Stefan Krah [Sun, 19 Aug 2012 10:50:24 +0000 (12:50 +0200)]
Fix out-of-date comment in test_memoryview.

12 years agoMereg 3.2.
Stefan Krah [Sun, 19 Aug 2012 09:22:28 +0000 (11:22 +0200)]
Mereg 3.2.

12 years agoCheck for NULL return value in PyStructSequence_NewType(). Found by Coverity.
Stefan Krah [Sun, 19 Aug 2012 09:20:41 +0000 (11:20 +0200)]
Check for NULL return value in PyStructSequence_NewType(). Found by Coverity.

12 years agoAllow redemo.py to be used from the command line like other demos.
Ned Deily [Sat, 18 Aug 2012 19:24:56 +0000 (12:24 -0700)]
Allow redemo.py to be used from the command line like other demos.

12 years agoAllow redemo.py to be used from the command line like other demos.
Ned Deily [Sat, 18 Aug 2012 19:21:17 +0000 (12:21 -0700)]
Allow redemo.py to be used from the command line like other demos.

12 years agoIssue #15615: Add some tests for the json module's handling of invalid input data.
Antoine Pitrou [Sat, 18 Aug 2012 18:48:17 +0000 (20:48 +0200)]
Issue #15615: Add some tests for the json module's handling of invalid input data.
Patch by Kushal Das.

12 years agoIssue #15615: Add some tests for the json module's handling of invalid input data.
Antoine Pitrou [Sat, 18 Aug 2012 18:46:23 +0000 (20:46 +0200)]
Issue #15615: Add some tests for the json module's handling of invalid input data.
Patch by Kushal Das.

12 years agoIssue #15477: Merge fix from 3.2
Mark Dickinson [Sat, 18 Aug 2012 11:26:15 +0000 (12:26 +0100)]
Issue #15477: Merge fix from 3.2

12 years agoIssue #15477: Add workaround for log1p(-0.0) on platforms where it's broken.
Mark Dickinson [Sat, 18 Aug 2012 11:24:30 +0000 (12:24 +0100)]
Issue #15477: Add workaround for log1p(-0.0) on platforms where it's broken.

12 years agoMerge 3.2: tutorial typo fix
Eli Bendersky [Sat, 18 Aug 2012 06:50:32 +0000 (09:50 +0300)]
Merge 3.2: tutorial typo fix

12 years agotutorial typo fix
Eli Bendersky [Sat, 18 Aug 2012 06:50:09 +0000 (09:50 +0300)]
tutorial typo fix

12 years agoIssue #15586: fix prompts in some documentation examples
Eli Bendersky [Sat, 18 Aug 2012 02:42:22 +0000 (05:42 +0300)]
Issue #15586: fix prompts in some documentation examples

12 years agoMerge #15636: add versionadded for decodebytes
R David Murray [Sat, 18 Aug 2012 00:55:54 +0000 (20:55 -0400)]
Merge #15636: add versionadded for decodebytes

12 years ago#15636: add versionadded for decodebytes
R David Murray [Sat, 18 Aug 2012 00:55:21 +0000 (20:55 -0400)]
#15636: add versionadded for decodebytes

12 years agoMerge #15355: Mention already-executing Exception in generator docs.
R David Murray [Sat, 18 Aug 2012 00:49:24 +0000 (20:49 -0400)]
Merge #15355: Mention already-executing Exception in generator docs.

Patch by Chris Jerdonek.

12 years ago#15355: Mention already-executing Exception in generator docs.
R David Murray [Sat, 18 Aug 2012 00:48:59 +0000 (20:48 -0400)]
#15355: Mention already-executing Exception in generator docs.

Patch by Chris Jerdonek.

12 years agoMerge #15694: reflow paragraph.
R David Murray [Sat, 18 Aug 2012 00:40:03 +0000 (20:40 -0400)]
Merge #15694: reflow paragraph.

12 years ago#15694: reflow paragraph.
R David Murray [Sat, 18 Aug 2012 00:39:21 +0000 (20:39 -0400)]
#15694: reflow paragraph.

12 years agoMerge #15694: Link discussion of file objects to glossary entry.
R David Murray [Sat, 18 Aug 2012 00:38:19 +0000 (20:38 -0400)]
Merge #15694: Link discussion of file objects to glossary entry.

This is analogous to the link for `flie objects` in the description of
'open' that exists in the 2.7 docs, and adds a similar link to the
io docs.

Patch by Chris Jerdonek.

12 years ago#15694: Link discussion of file objects to glossary entry.
R David Murray [Sat, 18 Aug 2012 00:33:54 +0000 (20:33 -0400)]
#15694: Link discussion of file objects to glossary entry.

This is analogous to the link for `flie objects` in the description of
'open' that exists in the 2.7 docs, and adds a similar link to the
io docs.

Patch by Chris Jerdonek.

12 years agoCloses #15632: regrtest.py: fix spurious refleaks due to various caches
Stefan Krah [Fri, 17 Aug 2012 21:09:48 +0000 (23:09 +0200)]
Closes #15632: regrtest.py: fix spurious refleaks due to various caches
filling up with random data.

12 years agoIssue #15678: Fix menu customization for IDLE started from OS X
Ned Deily [Fri, 17 Aug 2012 20:22:30 +0000 (13:22 -0700)]
Issue #15678: Fix menu customization for IDLE started from OS X
command lines.  It was broken as a side effect of the changes to
pythonw.c in b79d276041a8 for #15307.  Since sys.executable no
longer includes 'Python.app' in the path name, test for a
framework build instead.  This should give the previous behavior
in nearly all cases.  Whether the previous behavior is sensible
is left as an issue for later releases.  IDLE.app behavior was
not affected as it does its own manipulation of sys.executable.

12 years agoMerge with 3.2 #15660
Terry Jan Reedy [Fri, 17 Aug 2012 19:42:12 +0000 (15:42 -0400)]
Merge with 3.2 #15660

12 years agoIssue 15660: Clarify 0 prefix for width field in str.format doc.
Terry Jan Reedy [Fri, 17 Aug 2012 19:40:46 +0000 (15:40 -0400)]
Issue 15660: Clarify 0 prefix for width field in str.format doc.

12 years agoIssue #15640: Document importlib.abc.Finder as deprecated.
Brett Cannon [Fri, 17 Aug 2012 18:08:24 +0000 (14:08 -0400)]
Issue #15640: Document importlib.abc.Finder as deprecated.

The code for the class itself isn't deprecated for
backwards-compatibility reasons, but the class shouldn't be directly
inherited by anyone anymore as the API is no longer as widely valid as
it used to be.

12 years agoIssue #15715: Ignore failed imports triggered by the use of fromlist.
Brett Cannon [Fri, 17 Aug 2012 17:21:16 +0000 (13:21 -0400)]
Issue #15715: Ignore failed imports triggered by the use of fromlist.

When the fromlist argument is specified for __import__() and the
attribute doesn't already exist, an import is attempted. If that fails
(e.g. module doesn't exist), the ImportError will now be silenced (for
backwards-compatibility). This *does not* affect
``from ... import ...`` statements.

Thanks to Eric Snow for the patch and Simon Feltman for reporting the
regression.

12 years agoMerge
Richard Oudkerk [Fri, 17 Aug 2012 14:05:09 +0000 (15:05 +0100)]
Merge

12 years agoIssue #15412: Remove erroneous note about weakrefs
Richard Oudkerk [Fri, 17 Aug 2012 14:02:47 +0000 (15:02 +0100)]
Issue #15412: Remove erroneous note about weakrefs

12 years agoMerge
Richard Oudkerk [Fri, 17 Aug 2012 13:42:43 +0000 (14:42 +0100)]
Merge

12 years agoIssue #14501: Clarify that authentication keys are byte strings
Richard Oudkerk [Fri, 17 Aug 2012 13:39:18 +0000 (14:39 +0100)]
Issue #14501: Clarify that authentication keys are byte strings

12 years agoUpdate the getpeercert() example with a real-world cert showing non-trivial issuer...
Antoine Pitrou [Thu, 16 Aug 2012 20:18:37 +0000 (22:18 +0200)]
Update the getpeercert() example with a real-world cert showing non-trivial issuer, subject and subjectAltName.

12 years agoUpdate the getpeercert() example with a real-world cert showing non-trivial issuer...
Antoine Pitrou [Thu, 16 Aug 2012 20:14:43 +0000 (22:14 +0200)]
Update the getpeercert() example with a real-world cert showing non-trivial issuer, subject and subjectAltName.

12 years agoFix subprocess test broken on Windows
Andrew Svetlov [Thu, 16 Aug 2012 17:17:47 +0000 (20:17 +0300)]
Fix subprocess test broken on Windows

12 years agoIssue #14669: Fix pickling of connections and sockets on MacOSX
Richard Oudkerk [Thu, 16 Aug 2012 15:48:55 +0000 (16:48 +0100)]
Issue #14669: Fix pickling of connections and sockets on MacOSX
by sending/receiving an acknowledgment after file descriptor transfer.
TestPicklingConnection has been reenabled for MacOSX.

12 years ago#11062: Fix universal newline support in Babyl._install_message()
Petri Lehtinen [Thu, 16 Aug 2012 04:27:47 +0000 (07:27 +0300)]
#11062: Fix universal newline support in Babyl._install_message()

12 years ago#11062: Fix universal newline support in Babyl._install_message()
Petri Lehtinen [Thu, 16 Aug 2012 04:22:15 +0000 (07:22 +0300)]
#11062: Fix universal newline support in Babyl._install_message()

When adding a message from a binary file, \r\n was translated to
\r\r\n in the message body.

12 years agoMerge str docstring fix from 3.2
Nick Coghlan [Thu, 16 Aug 2012 04:14:30 +0000 (14:14 +1000)]
Merge str docstring fix from 3.2

12 years agoFix str docstring
Nick Coghlan [Thu, 16 Aug 2012 04:13:07 +0000 (14:13 +1000)]
Fix str docstring

12 years agoIssue #15604: Update uses of PyObject_IsTrue() to check for and handle errors correctly.
Antoine Pitrou [Wed, 15 Aug 2012 21:20:39 +0000 (23:20 +0200)]
Issue #15604: Update uses of PyObject_IsTrue() to check for and handle errors correctly.
Patch by Serhiy Storchaka.

12 years agoIssue #15604: Update uses of PyObject_IsTrue() to check for and handle errors correctly.
Antoine Pitrou [Wed, 15 Aug 2012 21:18:25 +0000 (23:18 +0200)]
Issue #15604: Update uses of PyObject_IsTrue() to check for and handle errors correctly.
Patch by Serhiy Storchaka.

12 years agomerge heads
Andrew Svetlov [Wed, 15 Aug 2012 19:53:56 +0000 (22:53 +0300)]
merge heads

12 years agoAdd yet another test for subprocess.Popen.communicate
Andrew Svetlov [Wed, 15 Aug 2012 19:46:43 +0000 (22:46 +0300)]
Add yet another test for subprocess.Popen.communicate

12 years agomerge with 3.2
Sandro Tosi [Wed, 15 Aug 2012 19:37:56 +0000 (21:37 +0200)]
merge with 3.2

12 years agoclarify in/not in in case of infinite iterators; thanks to Sergey Skovorodkin from...
Sandro Tosi [Wed, 15 Aug 2012 19:37:35 +0000 (21:37 +0200)]
clarify in/not in in case of infinite iterators; thanks to Sergey Skovorodkin from docs@

12 years ago#15543: reflow paragraph.
R David Murray [Wed, 15 Aug 2012 15:13:31 +0000 (11:13 -0400)]
#15543: reflow paragraph.

12 years ago#15543: additional link in subprocess docs.
R David Murray [Wed, 15 Aug 2012 15:12:15 +0000 (11:12 -0400)]
#15543: additional link in subprocess docs.

Patch by Chris Jerdonek.

12 years agoMerge #15543: glossary entry for and 'universal newlines', and links to it.
R David Murray [Wed, 15 Aug 2012 15:11:27 +0000 (11:11 -0400)]
Merge #15543: glossary entry for and 'universal newlines', and links to it.

Patch by Chris Jerdonek.

12 years ago#15543: reflow paragraphs.
R David Murray [Wed, 15 Aug 2012 15:05:36 +0000 (11:05 -0400)]
#15543: reflow paragraphs.

12 years ago#15543: glossary entry for and 'universal newlines', and links to it.
R David Murray [Wed, 15 Aug 2012 14:43:58 +0000 (10:43 -0400)]
#15543: glossary entry for and 'universal newlines', and links to it.

Patch by Chris Jerdonek.

12 years agoCleanup universal_newlines usage for subprocess.Popen, remove unused param.
Andrew Svetlov [Wed, 15 Aug 2012 14:36:15 +0000 (17:36 +0300)]
Cleanup universal_newlines usage for subprocess.Popen, remove unused param.

12 years agomerge 3.2
Eli Bendersky [Wed, 15 Aug 2012 11:51:08 +0000 (14:51 +0300)]
merge 3.2

12 years agomerge heads in 3.2 branch
Eli Bendersky [Wed, 15 Aug 2012 11:50:52 +0000 (14:50 +0300)]
merge heads in 3.2 branch

12 years agoIssue #15656: fixing code sample in extending doc
Eli Bendersky [Wed, 15 Aug 2012 11:49:49 +0000 (14:49 +0300)]
Issue #15656: fixing code sample in extending doc

12 years ago#11062: Fix adding a message from file to Babyl mailbox
Petri Lehtinen [Wed, 15 Aug 2012 11:36:14 +0000 (14:36 +0300)]
#11062: Fix adding a message from file to Babyl mailbox

12 years agoIssue #15586: typo fix. This commit is accompanied by an apology for all Liechtenstei...
Eli Bendersky [Wed, 15 Aug 2012 11:26:30 +0000 (14:26 +0300)]
Issue #15586: typo fix. This commit is accompanied by an apology for all Liechtensteiners out there, and a thanks to Eric Araujo for noticing.

12 years ago#11062: Fix adding a message from file to Babyl mailbox
Petri Lehtinen [Wed, 15 Aug 2012 11:00:40 +0000 (14:00 +0300)]
#11062: Fix adding a message from file to Babyl mailbox

12 years agoMerge #15269: document dircmp.left and right, and add tests for them.
R David Murray [Wed, 15 Aug 2012 01:45:25 +0000 (21:45 -0400)]
Merge #15269: document dircmp.left and right, and add tests for them.

Patch by Chris Jerdonek.

12 years ago#15269: document dircmp.left and right, and add tests for them.
R David Murray [Wed, 15 Aug 2012 01:40:13 +0000 (21:40 -0400)]
#15269: document dircmp.left and right, and add tests for them.

Patch by Chris Jerdonek.

12 years agomerge with 3.2
Sandro Tosi [Tue, 14 Aug 2012 17:52:04 +0000 (19:52 +0200)]
merge with 3.2

12 years agofix typo
Sandro Tosi [Tue, 14 Aug 2012 17:51:43 +0000 (19:51 +0200)]
fix typo

12 years agoMerge heads
Andrew Svetlov [Tue, 14 Aug 2012 15:42:54 +0000 (18:42 +0300)]
Merge heads

12 years agoMerge 3.2 to default
Andrew Svetlov [Tue, 14 Aug 2012 15:42:10 +0000 (18:42 +0300)]
Merge 3.2 to default

12 years agoMerge 3.2
Andrew Svetlov [Tue, 14 Aug 2012 15:41:40 +0000 (18:41 +0300)]
Merge 3.2

12 years agoIssue #15592. Fix regression: subprocess.communicate() breaks on no input with univer...
Andrew Svetlov [Tue, 14 Aug 2012 15:40:21 +0000 (18:40 +0300)]
Issue #15592. Fix regression: subprocess.communicate() breaks on no input with universal newlines true.

Patch by Chris Jerdonek.

12 years agoAdd test to explicit check the absence regression in subprocess (issue #15592).
Andrew Svetlov [Tue, 14 Aug 2012 15:35:17 +0000 (18:35 +0300)]
Add test to explicit check the absence regression in subprocess (issue #15592).

Patch by Chris Jerdonek.

12 years agomerge 3.2
Matthias Klose [Tue, 14 Aug 2012 15:30:12 +0000 (17:30 +0200)]
merge 3.2

12 years agoModules/socketmodule.c: netdb_lock: define static.
Matthias Klose [Tue, 14 Aug 2012 15:29:04 +0000 (17:29 +0200)]
Modules/socketmodule.c: netdb_lock: define static.

12 years agoIssue #14167: Document return statement in finally blocks.
Andrew Svetlov [Tue, 14 Aug 2012 12:38:58 +0000 (15:38 +0300)]
Issue #14167: Document return statement in finally blocks.

Patch by Yury Selivanov.

12 years agoIssue #14167: Document return statement in finally blocks.
Andrew Svetlov [Tue, 14 Aug 2012 12:38:15 +0000 (15:38 +0300)]
Issue #14167: Document return statement in finally blocks.

Patch by Yury Selivanov.

12 years agoMerge 3.2
Richard Oudkerk [Tue, 14 Aug 2012 11:51:14 +0000 (12:51 +0100)]
Merge 3.2