]> granicus.if.org Git - pdns/log
pdns
9 years agoopendbx and ldabbackend fixes for DNSName
bert hubert [Mon, 28 Sep 2015 07:36:12 +0000 (09:36 +0200)]
opendbx and ldabbackend fixes for DNSName

9 years agofixups for geoip, mydns and remote.
bert hubert [Mon, 28 Sep 2015 05:48:47 +0000 (07:48 +0200)]
fixups for geoip, mydns and remote.

9 years agofixes for Lua backend DNSName
bert hubert [Sun, 27 Sep 2015 22:51:03 +0000 (00:51 +0200)]
fixes for Lua backend DNSName

9 years agofix up p11 plus binddnssec DNSName adjustments
bert hubert [Sun, 27 Sep 2015 22:06:35 +0000 (00:06 +0200)]
fix up p11 plus binddnssec DNSName adjustments

9 years agoall travis binaries now build, testrunner passes too (and found some real bugs! yay...
bert hubert [Sun, 27 Sep 2015 20:47:12 +0000 (22:47 +0200)]
all travis binaries now build, testrunner passes too (and found some real bugs! yay unit tests!)

9 years agofurther round of DNSName cleanup. Found more cases where we were round-tripping DNSNa...
bert hubert [Sun, 27 Sep 2015 18:58:29 +0000 (20:58 +0200)]
further round of DNSName cleanup. Found more cases where we were round-tripping DNSNames accidentally too.

9 years agoMerge branch 'ednssurg' of github.com:ahupowerdns/pdns into ednssurg
bert hubert [Sun, 27 Sep 2015 17:44:43 +0000 (19:44 +0200)]
Merge branch 'ednssurg' of github.com:ahupowerdns/pdns into ednssurg

Conflicts:
pdns/distributor.hh

9 years agoimprove logging for database lookup issues
bert hubert [Sun, 27 Sep 2015 17:42:07 +0000 (19:42 +0200)]
improve logging for database lookup issues

9 years agostart moving away from DNSResourceRecord in the recursor. Baby steps. Two places...
bert hubert [Sun, 27 Sep 2015 15:07:42 +0000 (17:07 +0200)]
start moving away from DNSResourceRecord in the recursor. Baby steps. Two places left.

9 years agowhen we DO convert between DNSRecord and DNSResourceRecord, also convert d_place
bert hubert [Sun, 27 Sep 2015 15:07:07 +0000 (17:07 +0200)]
when we DO convert between DNSRecord and DNSResourceRecord, also convert d_place

9 years agodon't automatically convert between the MOADNSParser and DNSResourceRecord worlds...
bert hubert [Sun, 27 Sep 2015 15:06:43 +0000 (17:06 +0200)]
don't automatically convert between the MOADNSParser and DNSResourceRecord worlds (wasn't happening)

9 years agosome const-correctness
bert hubert [Sun, 27 Sep 2015 15:06:30 +0000 (17:06 +0200)]
some const-correctness

9 years agosecond round of DNSName cleanups - more will be needed for other backends
bert hubert [Sun, 27 Sep 2015 14:41:27 +0000 (16:41 +0200)]
second round of DNSName cleanups - more will be needed for other backends

9 years agowith this commit, we remove the implicit DNSName string constructors, which hid many...
bert hubert [Sun, 27 Sep 2015 11:54:47 +0000 (13:54 +0200)]
with this commit, we remove the implicit DNSName string constructors, which hid many many issues, including passing all DNS query packets as DNS domain names and converting them back again (WOW). To slightly compensate, we added an ostream operator<< to make printing of DNSNames easier.
This commit will start a world of pain and it isn't even done yet. Specifically forwarding to another nameserver is broken now (was broken already, we tried to push a :port number into a DNSName and parse it again). The webserver API was lovingly DNSNamed but will also likely have changes in case sensitivity, . termination and other things.

9 years agoimprove logging a bit, complete move to dnsname
bert hubert [Sun, 27 Sep 2015 11:49:39 +0000 (13:49 +0200)]
improve logging a bit, complete move to dnsname

9 years agoMerge remote-tracking branch 'main/master' into ednssurg
bert hubert [Fri, 25 Sep 2015 13:04:40 +0000 (15:04 +0200)]
Merge remote-tracking branch 'main/master' into ednssurg

9 years agoimplement & document keeping track of authoritative latency distribution in the pdns_...
bert hubert [Fri, 25 Sep 2015 07:54:18 +0000 (09:54 +0200)]
implement & document keeping track of authoritative latency distribution in the pdns_recursor, inspired by Allan Eising. Update to metronome forthcoming.

9 years agoMerge remote-tracking branch 'main/master' into ednssurg
bert hubert [Thu, 24 Sep 2015 14:49:23 +0000 (16:49 +0200)]
Merge remote-tracking branch 'main/master' into ednssurg

Conflicts:
pdns/recursor_cache.cc
pdns/recursor_cache.hh
pdns/syncres.cc
pdns/syncres.hh

9 years agoimprove logging somewhat for #2758 and #2760.
bert hubert [Thu, 24 Sep 2015 08:31:24 +0000 (10:31 +0200)]
improve logging somewhat for #2758 and #2760.

9 years agoclarify qa-latency a bit
bert hubert [Mon, 21 Sep 2015 20:20:47 +0000 (22:20 +0200)]
clarify qa-latency a bit

9 years agoUpdate pdns.conf-dist to reflect 191f2e478b42a
Pieter Lexis [Mon, 21 Sep 2015 18:17:46 +0000 (20:17 +0200)]
Update pdns.conf-dist to reflect 191f2e478b42a

9 years agomake pdns_control and rec_control mention the 'help' command to query pdns for possib...
bert hubert [Thu, 17 Sep 2015 14:52:10 +0000 (16:52 +0200)]
make pdns_control and rec_control mention the 'help' command to query pdns for possible commands. Close #2686.

9 years agoimplement pid-file configuration switch, defaults to on & document it. Close #2671.
bert hubert [Thu, 17 Sep 2015 14:33:04 +0000 (16:33 +0200)]
implement pid-file configuration switch, defaults to on & document it. Close #2671.

9 years agoMerge pull request #2750 from cmouse/cid-1324500
Pieter Lexis [Wed, 16 Sep 2015 11:33:01 +0000 (13:33 +0200)]
Merge pull request #2750 from cmouse/cid-1324500

Initialize d_fnum, fixes cid#1324500

9 years agoMerge pull request #2752 from pieterlexis/run-geoip-tests
Pieter Lexis [Wed, 16 Sep 2015 11:32:20 +0000 (13:32 +0200)]
Merge pull request #2752 from pieterlexis/run-geoip-tests

Run geoip tests

9 years agoMerge remote-tracking branch 'origin/pr/2751' into run-geoip-tests
Pieter Lexis [Wed, 16 Sep 2015 09:20:36 +0000 (11:20 +0200)]
Merge remote-tracking branch 'origin/pr/2751' into run-geoip-tests

9 years agoFix geoip test suite
Aki Tuomi [Wed, 16 Sep 2015 09:16:30 +0000 (12:16 +0300)]
Fix geoip test suite

9 years agoInitialize d_fnum, fixes cid#1324500
Aki Tuomi [Wed, 16 Sep 2015 09:01:08 +0000 (12:01 +0300)]
Initialize d_fnum, fixes cid#1324500

9 years agoCompile the GeoIP backend in travis and run tests
Pieter Lexis [Mon, 14 Sep 2015 08:40:58 +0000 (10:40 +0200)]
Compile the GeoIP backend in travis and run tests

Install a newer boost (also needed for geosql later)

9 years agoMerge pull request #2646 from pieterlexis/SunOS
Pieter Lexis [Tue, 15 Sep 2015 09:40:53 +0000 (11:40 +0200)]
Merge pull request #2646 from pieterlexis/SunOS

SunOS additions and fixes

9 years agoMerge pull request #2736 from cmouse/geoip-direct-result
Pieter Lexis [Tue, 15 Sep 2015 07:23:47 +0000 (09:23 +0200)]
Merge pull request #2736 from cmouse/geoip-direct-result

Return result directly if available in GeoIPBackend

9 years agoMerge pull request #2742 from cmouse/gpgsql-truth
Peter van Dijk [Tue, 15 Sep 2015 06:34:26 +0000 (08:34 +0200)]
Merge pull request #2742 from cmouse/gpgsql-truth

Handle booleans correctly in gPGSql

9 years agoMerge pull request #2743 from cmouse/gsql-next-result-set
Peter van Dijk [Tue, 15 Sep 2015 06:33:44 +0000 (08:33 +0200)]
Merge pull request #2743 from cmouse/gsql-next-result-set

Support multiple results set in gMySQL and gPGSql

9 years agoMerge pull request #2679 from pieterlexis/issue-2432-check-zone-TLSA-wildcard-empty...
Pieter Lexis [Mon, 14 Sep 2015 12:12:28 +0000 (14:12 +0200)]
Merge pull request #2679 from pieterlexis/issue-2432-check-zone-TLSA-wildcard-empty-non-terminal

pdnssec: Check if addresses exist for TLSA hosts

9 years agoEscape portal identifier
Aki Tuomi [Mon, 14 Sep 2015 11:35:51 +0000 (14:35 +0300)]
Escape portal identifier

9 years agoSupport refcursor(s) in gPgSQL
Aki Tuomi [Sat, 12 Sep 2015 20:47:02 +0000 (23:47 +0300)]
Support refcursor(s) in gPgSQL

Allows stored procedures to use refcursor
or set of refcursors in order to return values.

9 years agoImplement multi result set support in gMySQL
Aki Tuomi [Sat, 12 Sep 2015 17:38:26 +0000 (20:38 +0300)]
Implement multi result set support in gMySQL

9 years agoMerge pull request #2744 from cmouse/goracle-improve-errors
Peter van Dijk [Mon, 14 Sep 2015 10:16:47 +0000 (12:16 +0200)]
Merge pull request #2744 from cmouse/goracle-improve-errors

Improve error logging in goracle

9 years agoMerge pull request #2738 from cmouse/geoip-rectify
Pieter Lexis [Mon, 14 Sep 2015 10:03:29 +0000 (12:03 +0200)]
Merge pull request #2738 from cmouse/geoip-rectify

Rectify records in GeoIPBackend

9 years agopdnssec: Check if records exist for TLSA hosts
Pieter Lexis [Thu, 28 May 2015 20:20:15 +0000 (22:20 +0200)]
pdnssec: Check if records exist for TLSA hosts

When a record _443._tcp.www.example.com.|TLSA exists and no record for
www.example.com., we emit a warning. Similarly, when
*.example.com. _does_ exist, we emit a warning, as
www.example.com. becomes an empty non-terminal at that point.

9 years agoUpdate test suite
Aki Tuomi [Mon, 14 Sep 2015 08:39:05 +0000 (11:39 +0300)]
Update test suite

Now tests direct and indirect response.

9 years agoSet scopemask for result during reply
Aki Tuomi [Mon, 14 Sep 2015 08:37:09 +0000 (11:37 +0300)]
Set scopemask for result during reply

9 years agoImprove error logging in goracle
Aki Tuomi [Sat, 12 Sep 2015 21:44:33 +0000 (00:44 +0300)]
Improve error logging in goracle

9 years agoHandle booleans correctly in gPGSql
Aki Tuomi [Sat, 12 Sep 2015 20:48:56 +0000 (23:48 +0300)]
Handle booleans correctly in gPGSql

9 years agoMerge pull request #2740 from pieterlexis/pkg-randombackend
Pieter Lexis [Fri, 11 Sep 2015 13:14:52 +0000 (15:14 +0200)]
Merge pull request #2740 from pieterlexis/pkg-randombackend

Package the random backend in the main server package

9 years agoMerge pull request #2739 from mind04/mbedtls210
Pieter Lexis [Fri, 11 Sep 2015 13:14:44 +0000 (15:14 +0200)]
Merge pull request #2739 from mind04/mbedtls210

Update included mbed TLS to version 2.1.0 (GPL)

9 years agoUpdate mbed TLS to version 2.1.0 (GPL)
Kees Monshouwer [Fri, 11 Sep 2015 10:01:02 +0000 (12:01 +0200)]
Update mbed TLS to version 2.1.0 (GPL)

9 years agoPackage the random backend in the main server package
Pieter Lexis [Fri, 11 Sep 2015 10:43:46 +0000 (12:43 +0200)]
Package the random backend in the main server package

9 years agoRectify records
Aki Tuomi [Fri, 11 Sep 2015 09:17:12 +0000 (12:17 +0300)]
Rectify records

9 years agoReturn result directly if available
Aki Tuomi [Fri, 11 Sep 2015 08:18:14 +0000 (11:18 +0300)]
Return result directly if available

9 years agoMerge pull request #2734 from pieterlexis/sdig-in-pkg
Pieter Lexis [Thu, 10 Sep 2015 13:46:25 +0000 (15:46 +0200)]
Merge pull request #2734 from pieterlexis/sdig-in-pkg

Add sdig to pdns-tools

9 years agosmall BOOST_FOREACH cleanup, mostly to test my new development setup.
bert hubert [Thu, 10 Sep 2015 11:24:47 +0000 (13:24 +0200)]
small BOOST_FOREACH cleanup, mostly to test my new development setup.

9 years agoAdd sdig to pdns-tools
Pieter Lexis [Wed, 9 Sep 2015 16:08:38 +0000 (18:08 +0200)]
Add sdig to pdns-tools

9 years agomake sure our case insensitive hash uses dns_tolower and not tolower which might...
bert hubert [Wed, 9 Sep 2015 09:29:39 +0000 (11:29 +0200)]
make sure our case insensitive hash uses dns_tolower and not tolower which might conceivably do all kinds of locale things which could be slow

9 years agomake our question hash for query distribution case insensitive. add tests that check...
bert hubert [Wed, 9 Sep 2015 09:17:45 +0000 (11:17 +0200)]
make our question hash for query distribution case insensitive. add tests that check this is the case. add rudimentary test that checks if our hash is reasonably flat.

9 years agoMerge pull request #2733 from pieterlexis/deb-pkg-cleanup
Pieter Lexis [Wed, 9 Sep 2015 08:41:03 +0000 (10:41 +0200)]
Merge pull request #2733 from pieterlexis/deb-pkg-cleanup

Fix the installation of the auth deb package

9 years agoMerge pull request #2678 from pieterlexis/dnsdist-uptime-start
Peter van Dijk [Tue, 8 Sep 2015 08:34:01 +0000 (10:34 +0200)]
Merge pull request #2678 from pieterlexis/dnsdist-uptime-start

dnsdist: initialize the uptime variable on startup

9 years agoMerge pull request #2684 from rubenk/recursor-docs-for-stats
Peter van Dijk [Tue, 8 Sep 2015 08:33:43 +0000 (10:33 +0200)]
Merge pull request #2684 from rubenk/recursor-docs-for-stats

recursor: some minor tweaks to stats.md

9 years agoAuth: Don't call `hostname` on Solaris/SunOS
Pieter Lexis [Tue, 21 Jul 2015 07:46:11 +0000 (09:46 +0200)]
Auth: Don't call `hostname` on Solaris/SunOS

9 years agoRecursor: Don't use `hostname -f` on Solaris/SunOS
Pieter Lexis [Mon, 20 Jul 2015 09:44:30 +0000 (11:44 +0200)]
Recursor: Don't use `hostname -f` on Solaris/SunOS

9 years agoAdd Sun service files
Pieter Lexis [Mon, 20 Jul 2015 09:11:27 +0000 (11:11 +0200)]
Add Sun service files

Thanks to Annatar for these.

9 years agoFix the installation of the auth deb package
Pieter Lexis [Mon, 7 Sep 2015 08:52:19 +0000 (10:52 +0200)]
Fix the installation of the auth deb package

The post-install script expects the main config to be in
/usr/share/pdns-server and fails if it isn't there.

9 years agoMerge pull request #2732 from ahupowerdns/iptrunc
bert hubert [Sun, 6 Sep 2015 08:05:44 +0000 (10:05 +0200)]
Merge pull request #2732 from ahupowerdns/iptrunc

Iptrunc

9 years agoimprove error message if attempting to bind to an address we can't bind to for outgoi...
bert hubert [Sat, 5 Sep 2015 17:40:24 +0000 (19:40 +0200)]
improve error message if attempting to bind to an address we can't bind to for outgoing queries

9 years agorecursor: some minor tweaks to stats.md
Ruben Kerkhof [Mon, 10 Aug 2015 18:56:23 +0000 (20:56 +0200)]
recursor: some minor tweaks to stats.md

9 years agoMerge pull request #2729 from pieterlexis/auth-zones-test
Pieter Lexis [Fri, 4 Sep 2015 15:01:21 +0000 (17:01 +0200)]
Merge pull request #2729 from pieterlexis/auth-zones-test

Recursor: add an extensive test for auth-zones

9 years agohook up TCAction() for use in addAction(). Add global MaxQPSLimit(), not just per...
bert hubert [Fri, 4 Sep 2015 13:45:57 +0000 (15:45 +0200)]
hook up TCAction() for use in addAction(). Add global MaxQPSLimit(), not just per IP(range). Document these and big up our https://repo.powerdns.com service

9 years agoAlways grab the debuginfo rpms
Pieter Lexis [Fri, 4 Sep 2015 13:33:20 +0000 (15:33 +0200)]
Always grab the debuginfo rpms

9 years agoMerge pull request #2711 from cmouse/gsql-check-return-columns
Peter van Dijk [Fri, 4 Sep 2015 12:19:14 +0000 (14:19 +0200)]
Merge pull request #2711 from cmouse/gsql-check-return-columns

Ensure queries result correct number of columns

9 years agohook up truncation for MaxQPSIPRule so we can group ipv6 by /64 etc
bert hubert [Fri, 4 Sep 2015 11:30:44 +0000 (13:30 +0200)]
hook up truncation for MaxQPSIPRule so we can group ipv6 by /64 etc

9 years agoclean up a bit, plus optimize /32 and /128 cases
bert hubert [Fri, 4 Sep 2015 11:29:14 +0000 (13:29 +0200)]
clean up a bit, plus optimize /32 and /128 cases

9 years agoimplement ComboAddress::truncate() - 24 leaves the first 3 octets for IPv4. 0 leaves...
bert hubert [Fri, 4 Sep 2015 09:45:20 +0000 (11:45 +0200)]
implement ComboAddress::truncate() - 24 leaves the first 3 octets for IPv4. 0 leaves nothing.

9 years agoRecursor: add an extensive test for auth-zones
Pieter Lexis [Fri, 4 Sep 2015 08:28:31 +0000 (10:28 +0200)]
Recursor: add an extensive test for auth-zones

9 years agomake the generated CentOS 7 config saner
Pieter Lexis [Thu, 3 Sep 2015 10:07:55 +0000 (12:07 +0200)]
make the generated CentOS 7 config saner

9 years agopdns_server is installed to sbin, not bin
Pieter Lexis [Thu, 3 Sep 2015 08:52:58 +0000 (10:52 +0200)]
pdns_server is installed to sbin, not bin

9 years agoMerge pull request #2722 from cmouse/use-distance-in-dnsname
bert hubert [Thu, 3 Sep 2015 06:34:15 +0000 (08:34 +0200)]
Merge pull request #2722 from cmouse/use-distance-in-dnsname

Use std::distance in dnsname, fix #2721

9 years agoAlso update our main security page on 2015-02
Pieter Lexis [Wed, 2 Sep 2015 14:42:56 +0000 (16:42 +0200)]
Also update our main security page on 2015-02

9 years agoCorrect the name of Ashish Shukla
Pieter Lexis [Wed, 2 Sep 2015 14:01:13 +0000 (16:01 +0200)]
Correct the name of Ashish Shukla

9 years agoMerge pull request #2725 from pieterlexis/3.4.6-sec-announce
bert hubert [Wed, 2 Sep 2015 13:18:31 +0000 (15:18 +0200)]
Merge pull request #2725 from pieterlexis/3.4.6-sec-announce

PowerDNS Security Advisory 2015-02

9 years agoadd a dropAction() creator for Lua
bert hubert [Wed, 2 Sep 2015 09:14:02 +0000 (11:14 +0200)]
add a dropAction() creator for Lua

9 years agoUpdate secpoll.zone for Advisory 2015-02
Pieter Lexis [Tue, 1 Sep 2015 09:15:05 +0000 (11:15 +0200)]
Update secpoll.zone for Advisory 2015-02

9 years agoAdd the security advisory for Auth 3.4.6
Pieter Lexis [Fri, 28 Aug 2015 14:02:26 +0000 (16:02 +0200)]
Add the security advisory for Auth 3.4.6

9 years agocleanup rule/action infrastructure to be generic in dnsdist
bert hubert [Tue, 1 Sep 2015 14:24:39 +0000 (16:24 +0200)]
cleanup rule/action infrastructure to be generic in dnsdist

9 years agoadd a TCP flag to addLocal so you can selectively disable TCP/IP (default is on)
bert hubert [Tue, 1 Sep 2015 13:36:30 +0000 (15:36 +0200)]
add a TCP flag to addLocal so you can selectively disable TCP/IP (default is on)

9 years agoMerge pull request #2723 from pieterlexis/issue-2690
Pieter Lexis [Tue, 1 Sep 2015 13:08:46 +0000 (15:08 +0200)]
Merge pull request #2723 from pieterlexis/issue-2690

Fix --loglevel set to > 32K, closes #2690

9 years agoFix --loglevel set to > 32K, closes #2690
Pieter Lexis [Tue, 1 Sep 2015 11:53:04 +0000 (13:53 +0200)]
Fix --loglevel set to > 32K, closes #2690

9 years agoMerge pull request #2715 from zeha/secpoll-debian
Pieter Lexis [Tue, 1 Sep 2015 09:14:10 +0000 (11:14 +0200)]
Merge pull request #2715 from zeha/secpoll-debian

secpoll: Add current and prospective Debian/Ubuntu 3.4.6 builds

9 years agoUse std::distance in dnsname, fix #2721
Aki Tuomi [Tue, 1 Sep 2015 08:47:30 +0000 (11:47 +0300)]
Use std::distance in dnsname, fix #2721

9 years agoMerge pull request #2718 from pieterlexis/issue-2717-doc-title
Pieter Lexis [Mon, 31 Aug 2015 11:33:35 +0000 (13:33 +0200)]
Merge pull request #2718 from pieterlexis/issue-2717-doc-title

Some documentation fixes

9 years agoUpdate .travis.yml so travis can build the docs
Pieter Lexis [Mon, 31 Aug 2015 07:24:39 +0000 (09:24 +0200)]
Update .travis.yml so travis can build the docs

9 years agoUpdate the docs on docs (yo!)
Pieter Lexis [Mon, 31 Aug 2015 07:20:31 +0000 (09:20 +0200)]
Update the docs on docs (yo!)

9 years agoUse the mkdocs 0.12+ pages layout in mkdocs.yml
Pieter Lexis [Mon, 31 Aug 2015 07:16:51 +0000 (09:16 +0200)]
Use the mkdocs 0.12+ pages layout in mkdocs.yml

9 years agoDon't title the docs 'None', closes #2717
Pieter Lexis [Mon, 31 Aug 2015 07:13:19 +0000 (09:13 +0200)]
Don't title the docs 'None', closes #2717

For some reason, mkdocs insists that the title of the homepage is
'None', even though we set it in the config.

9 years agosecpoll: Add current and prospective Debian/Ubuntu 3.4.6 builds
Christian Hofstaedtler [Sat, 29 Aug 2015 13:26:39 +0000 (15:26 +0200)]
secpoll: Add current and prospective Debian/Ubuntu 3.4.6 builds

9 years agoand update the SOA of secpoll zone
bert hubert [Sat, 29 Aug 2015 11:28:34 +0000 (13:28 +0200)]
and update the SOA of secpoll zone

9 years agoMerge branch 'master' of github.com:PowerDNS/pdns
bert hubert [Sat, 29 Aug 2015 11:26:33 +0000 (13:26 +0200)]
Merge branch 'master' of github.com:PowerDNS/pdns

9 years agoMerge pull request #2714 from pieterlexis/sec-notice-3.4.5
Pieter Lexis [Fri, 28 Aug 2015 16:27:34 +0000 (18:27 +0200)]
Merge pull request #2714 from pieterlexis/sec-notice-3.4.5

Small documentation fixes

9 years agofix a broken link
Pieter Lexis [Fri, 28 Aug 2015 16:17:06 +0000 (18:17 +0200)]
fix a broken link

9 years agoAdd a notification to advisory 2015-01 to the changelog
Pieter Lexis [Fri, 28 Aug 2015 16:16:52 +0000 (18:16 +0200)]
Add a notification to advisory 2015-01 to the changelog

9 years agoMerge pull request #2708 from pieterlexis/rel-notes-3.4.6
Pieter Lexis [Fri, 28 Aug 2015 14:22:54 +0000 (16:22 +0200)]
Merge pull request #2708 from pieterlexis/rel-notes-3.4.6

Add auth 3.4.6 changelog