As the ones of you who compile with new gcc's probably have noticed,
there's a lot of type-punning in Mutt. With help from Philipp
Thomas, I've fixed all I could find in CVS (please double-check, one
might have slipped through the cracks), I can make one for 1.4 CVS
branch as well if wanted.
Jon Miles [Wed, 10 Sep 2003 13:20:49 +0000 (13:20 +0000)]
In pop_auth.c:pop_auth_sasl(), if the main loop received anything
back from the server that didnt begin with '+ ', it was bailing out
and skipping the checks to see if there was a +OK response.
Dan Fandrich [Wed, 3 Sep 2003 17:22:09 +0000 (17:22 +0000)]
I've attached a patch for bug number 1036, as reported at
http://bugs.guug.de/db/pa/lmutt.html ("segfault when more than one
msg is postponed"). This is a patch against mutt 1.4.1.
As it was previously left, no one could reproduce it. The problem
occurs because sorting is disabled when opening the postponed
folder, but the Sort global variable still tells mutt to use
whatever sorting algorithm the $sort config option indicates.
Eventually, the code would get to mutt_messages_in_thread and try to
dereference a NULL thread object, causing the segfault.
The commands "read-thread" (^R) and "read-subthread" (Esc-R) do not
honor the resolve variable (don't advance cursor after marking the
thread/subthread as read), which, to me at least, is a nuisance.
Brendan Cully [Mon, 11 Aug 2003 14:06:08 +0000 (14:06 +0000)]
1595: My guess is this bug is caused by mlarson@verisign.com's patch
to check for UNSEEN rather than RECENT messages. This means that as
long as there are messages in a mailbox either new or old, mutt will
think it has new mail.
The attached patch reverts that change. Let me know if it solves the
problem.
It seems that Solaris has an incorrect implementation of mbrtowc: when
there is an encoding error and mbrtowc returns (size_t)(-1) no value
should be stored in *pwc (the first argument), as I understand it, but
here mbrtowc is storing 8 when presented with the bytes "\xc8\x4d".
However, relying on mbrtowc not to store anything in *pwc when there
is an error is a bit silly; it makes sense to look at the return
value. So, the following patch should be applied if Pawel can confirm
that it fixes the problem. I've tested it and it worked for me with
glibc's mbrtowc.
Vincent Lefevre [Thu, 24 Jul 2003 18:40:50 +0000 (18:40 +0000)]
Some functions/macros like isspace take an int and require the
argument to have the value of an unsigned char (or EOF). Under
Solaris, gcc complains when the argument is a char (as this is a
possible bug, on platforms where char is signed, like Solaris). The
attached patch fixes such problems (well, perhaps I've changed more
than necessary, but this doesn't hurt).
David Shaw [Tue, 22 Jul 2003 12:56:38 +0000 (12:56 +0000)]
When encrypting a message to a user that has more than one subkey,
at least one of which is revoked or expired, mutt treats the entire
key as unusable rather than just the subkey(s) in question.
I noticed that my mutt hung when I tried SASL DIGEST-MD5
authentication (I'm not sure when this started). I believe this
patch should solve that problem in a reliable way.
This patch also attempts to reuse connections even when
authentication fails, instead of just throwing away a perfectly good
socket.
This patch redoes yesterday's unbuffered input patch. Now it uses a
pseudo-option, which means less mess to carry down the call stack.
It also made it much easier to have the SSL certificate menu be
unbuffered, which it is now. So push commands won't annoy you when
entering passwords or accepting certificates.
The attached patch should keep all opened IMAP connections alive, no
matter what mailbox you are currently in. With the patch that got
committed yesterday, this should close bug 1523.
(There was a typo in that patch. This one supersedes it.)
On Sunday, 13 July 2003 at 18:09, Brendan Cully wrote:
> The attached patch should help when the connection to your postponed
> folder times out and you can't reconnect without restarting mutt. I'd
> like anyone who has that problem to try it and let me know how it
> works.
I dug a little deeper. The attached patch seems to work better. It
complains the first time you try to recall a message, but works the
second.
The attached patch prevents mutt from reading the push buffer when
asking for passwords. This is a proper fix for bug 1312. I think
it's uncontroversial.
Thomas Roessler [Fri, 4 Jul 2003 16:57:56 +0000 (16:57 +0000)]
Add a ':' flag to % expandos. This will make sure that any
dots are converted into underscores. (_ is already used for
lowercasing the result of an expando.)
view-attachments does not extract the message within a x-pkcs7-mime
if it's only signed, but not encrypted. Such a message results, for
example, from a decrypt-save if the message was previously encrypted
and signed.