Tom Lane [Fri, 30 Mar 2001 05:25:51 +0000 (05:25 +0000)]
Add appropriately ifdef'd hack to make ARM compiler allocate ItemPointerData
as six bytes not eight. This fixes a regression test failure but more
importantly avoids wasting four bytes of pad space in every tuple header.
Also add some commentary about what's going on.
Tom Lane [Tue, 27 Mar 2001 18:02:19 +0000 (18:02 +0000)]
Quick hack to fix Oliver Elphick's problem with subselects in an
inheritance query: make duplicate copies of subplans in adjust_inherited_attrs.
When we redesign querytrees we really gotta do something about this
issue of whether querytrees are read-only and can share substructure
or not.
Bruce Momjian [Tue, 27 Mar 2001 14:56:20 +0000 (14:56 +0000)]
The following patch updates the FAQ_AIX and makes C++ code work with
more recent versions of the IBM C++ compiler (now called VisualAge C++).
The C++ part was previously broken (g++ and xlC), thus this is zero risk.
Only AIX specific parts are touched (1 Makefile.shlib line (link with $(COMPILER
) instead
of $(CC) and one shell script line (parameter -C to nm to not demangle C++ symbo
ls for
.exp file)).
I thus ask you to please apply this patch before release.
With or without this patch RC1 on AIX 4.3.2 RS6000 passes "gmake check" for both
the native
compiler vac.C 5.0.1 and gcc 2.95.2 :-)
Tom Lane [Sun, 25 Mar 2001 18:14:31 +0000 (18:14 +0000)]
The regexp pattern characters ^ and $ should be explained as matching
at the beginning and end of the input string, not the beginning and end
of "a line", since Postgres does not allow them to match at newline
characters in the data.
Tom Lane [Sat, 24 Mar 2001 06:17:41 +0000 (06:17 +0000)]
Hadn't built on a PARISC 1.1 box in a long time ... but when I did,
it turned out that the libpq makefile chokes on '-L /lib/pa1.1'.
Need to remove the space so filter rule works.
Tom Lane [Fri, 23 Mar 2001 18:42:12 +0000 (18:42 +0000)]
When using 'long long int' for int64 type, check to see if the compiler
accepts nnnLL syntax for long long constants. If so, decorate the CRC64
constants with LL to avoid warnings and/or erroneous results from certain
non-standards-compliant compilers.
Tom Lane [Thu, 22 Mar 2001 17:41:47 +0000 (17:41 +0000)]
Fix Joubert's complaint that int8-sized numeric literals are mishandled
on Alpha (because parser mistakenly assumes that a nonoverflow result
from strtol means the value will fit into int4). A scan for other uses
of strtol and strtoul found a couple other places with the same mistake;
fix them too. The changes are all conditional on HAVE_LONG_INT_64 to
avoid complaints from compilers that think x != x is a silly test
(cf. pg_atoi).
Bruce Momjian [Thu, 22 Mar 2001 15:24:12 +0000 (15:24 +0000)]
Run pgindent on _int.c, for Tom Lane. I had skipped this file because
of a complex macro that pgindent complained about. Hand-adjusted macro
for pgindent run.
Marc G. Fournier [Thu, 22 Mar 2001 15:13:19 +0000 (15:13 +0000)]
geometry tests 'FAILED' from a precision standpoint, but differently then
what solaris-precision takes into account ... its possible that solaris-precision
is 'stale', but created a new one "just in case" ...
Vadim B. Mikheev [Wed, 21 Mar 2001 10:13:29 +0000 (10:13 +0000)]
Check bufHdr->cntxDirty and call StartBufferIO in BufferSync()
*before* acquiring shlock on buffer context. This way we should be
protected against conflicts with FlushRelationBuffers.
(Seems we never do excl lock and then StartBufferIO for the same
buffer, so there should be no deadlock here, - but we'd better
check this very soon).
Tom Lane [Tue, 20 Mar 2001 20:54:41 +0000 (20:54 +0000)]
Recommend CREATE TABLE AS in preference to SELECT INTO. Remove the
(inadequate anyway) mention of SELECT INTO from the main SELECT ref page.
Point out that SELECT INTO means something else in plpgsql and ecpg.
Tom Lane [Tue, 20 Mar 2001 03:08:12 +0000 (03:08 +0000)]
Repair intarray's problems with TOASTed input, avoid scribbling on
source data, improve split algorithm for intbig_ops. Oleg Bartunov
with some kibitzing from Tom Lane.
Tom Lane [Mon, 19 Mar 2001 22:29:39 +0000 (22:29 +0000)]
Tweak out-of-memory error messages to include the request size, so that
it's easier to tell whether a bug report is talking about progressive
memory exhaustion or a wacko requested chunk size.
Philip Warner [Mon, 19 Mar 2001 02:35:29 +0000 (02:35 +0000)]
- Added CVS headers to files
- Avoid forcing table name to lower case in FixupBlobXrefs
- Removed fmtId calls for all ArchiveEntry name fields. This fixes
quoting problems in trigger enable/disable code for mixed case
table names, and avoids commands like 'pg_restore -t '"TblA"'
Tom Lane [Sun, 18 Mar 2001 23:36:55 +0000 (23:36 +0000)]
Restore include-file updates, and fix some of the more glaring macro
sloppiness (insufficient parenthesization, etc).
It still fails regress test for me, however.
Tom Lane [Sun, 18 Mar 2001 20:18:59 +0000 (20:18 +0000)]
Remove NEXTXID xlog record type to avoid three-way deadlock risk.
NEXTXID isn't really necessary, per previous discussion in pghackers,
but I mulishy insisted we should put it in anyway. Mea culpa.
Tom Lane [Sat, 17 Mar 2001 20:54:13 +0000 (20:54 +0000)]
Rearrange XLogFileInit so that control-file spinlock is not held while filling
the new log file with zeroes, only while renaming it into place. This should
prevent problems with 'stuck spinlock' errors under heavy load.