granicus.if.org Git

Excessively large stack frames detected.
The 2.6.30 kernel build systems sets -Wframe-larger-than=2048 which causes
a warning to be generated when an individual stack frame exceeds 2048.
This caught the spa_history_log() and dmu_objset_snapshot() functions
which declared a data structure on the stack which contained a char
array of MAXPATHLEN.  This in defined to be 4096 in the linux kernel
and I imagine it is quite large under Solaris as well.  Regardless, the
offending data structures were moved to the heap to correctly keep the
stack depth to a minimum.  We might consider setting this value even
lower to catch additional offenders because we are expecting deep stacks.

commit | commitdiff | tree

Brian Behlendorf [Fri, 24 Jul 2009 16:15:53 +0000 (09:15 -0700)]

Merge branch 'fix-get-configs' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Fri, 24 Jul 2009 15:53:18 +0000 (08:53 -0700)]

Increase buffer size for nvlist for large configurations
It's still not clear to me why the default value here is large
enough Solaris. I hit this limit again when setting up 120 SATA
drives configured as 15 raidz2 groups each containing 8 drives.
We expect to go bigger so we may just want to spend a little
time and figure out how to make this all dynamic.

commit | commitdiff | tree

Brian Behlendorf [Tue, 7 Jul 2009 21:19:35 +0000 (14:19 -0700)]

Merge branch 'fix-acl' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Tue, 7 Jul 2009 21:18:47 +0000 (14:18 -0700)]

New topic branch for minor acl related fixes

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:14:18 +0000 (13:14 -0700)]

Merge commit 'refs/top-bases/fix-deadcode' into fix-deadcode

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:14:18 +0000 (13:14 -0700)]

Merge branch 'fix-deadcode' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:14:13 +0000 (13:14 -0700)]

Merge commit 'refs/top-bases/fix-strncat' into fix-strncat

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:14:13 +0000 (13:14 -0700)]

Merge branch 'fix-strncat' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:14:08 +0000 (13:14 -0700)]

Merge branch 'fix-list' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:14:05 +0000 (13:14 -0700)]

Merge commit 'refs/top-bases/fix-list' into fix-list

Conflicts:

module/zfs/zil.c

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:13:25 +0000 (13:13 -0700)]

Merge commit 'refs/top-bases/fix-taskq' into fix-taskq

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:13:25 +0000 (13:13 -0700)]

Merge branch 'fix-taskq' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:13:20 +0000 (13:13 -0700)]

Merge commit 'refs/top-bases/fix-stack' into fix-stack

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:13:20 +0000 (13:13 -0700)]

Merge branch 'fix-stack' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:13:15 +0000 (13:13 -0700)]

Merge branch 'fix-rwlocks' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:13:14 +0000 (13:13 -0700)]

Merge commit 'refs/top-bases/fix-rwlocks' into fix-rwlocks

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:13:05 +0000 (13:13 -0700)]

Merge commit 'refs/top-bases/fix-no-zmod' into fix-no-zmod

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:13:05 +0000 (13:13 -0700)]

Merge branch 'fix-no-zmod' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:12:59 +0000 (13:12 -0700)]

Merge commit 'refs/top-bases/fix-newlines' into fix-newlines

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:12:59 +0000 (13:12 -0700)]

Merge branch 'fix-newlines' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:12:54 +0000 (13:12 -0700)]

Merge commit 'refs/top-bases/fix-get-configs' into fix-get-configs

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:12:54 +0000 (13:12 -0700)]

Merge branch 'fix-get-configs' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:12:49 +0000 (13:12 -0700)]

Merge commit 'refs/top-bases/fix-evict-dbufs' into fix-evict-dbufs

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:12:49 +0000 (13:12 -0700)]

Merge branch 'fix-evict-dbufs' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:12:44 +0000 (13:12 -0700)]

Merge commit 'refs/top-bases/fix-dsl_pool_t' into fix-dsl_pool_t

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:12:44 +0000 (13:12 -0700)]

Merge branch 'fix-dsl_pool_t' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:12:39 +0000 (13:12 -0700)]

Merge commit 'refs/top-bases/fix-dnode-cons' into fix-dnode-cons

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:12:39 +0000 (13:12 -0700)]

Merge branch 'fix-dnode-cons' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:12:34 +0000 (13:12 -0700)]

Merge commit 'refs/top-bases/fix-dbuf_dirty_record_t' into fix-dbuf_dirty_record_t

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:12:34 +0000 (13:12 -0700)]

Merge branch 'fix-dbuf_dirty_record_t' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:12:23 +0000 (13:12 -0700)]

Merge branch 'fix-clock-wrap' into refs/top-bases/fix-branch

Conflicts:

module/zfs/zil.c

commit | commitdiff | tree

Brian Behlendorf [Mon, 6 Jul 2009 20:11:56 +0000 (13:11 -0700)]

Merge commit 'refs/top-bases/fix-clock-wrap' into fix-clock-wrap

commit | commitdiff | tree

Brian Behlendorf [Thu, 2 Jul 2009 22:44:48 +0000 (15:44 -0700)]

Rebase master to b117

commit | commitdiff | tree

Brian Behlendorf [Fri, 20 Mar 2009 02:49:53 +0000 (19:49 -0700)]

Merge branch 'fix-pthreads' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Fri, 20 Mar 2009 02:43:09 +0000 (19:43 -0700)]

Revert fix-pthreads moving to feature-pthreads branch

commit | commitdiff | tree

Brian Behlendorf [Thu, 19 Mar 2009 22:29:33 +0000 (15:29 -0700)]

Merge branch 'fix-dnode-cons' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Thu, 19 Mar 2009 22:22:48 +0000 (15:22 -0700)]

The patch resolves the extra call to dnode_cons() in dnode_create().

The extra call to the constructor was there to reinitialize the non-
trivial primatives in the dnode (lists, mutexs, condvars, avl tree, etc).
This was safe, although not exactly clean, on Solaris because none of
the primitives allocate memory. In the Linux port this is not true.
To keep stack usage to a minimum several of the primatives dynamically
allocate memory thus initializing them twice results in a memory leak.

This patch resolves this problem for Solaris and Linux by ensuring all
*_inits are called in the constructor, and all *_destroys are called
in the destructor. Additionally we ensure that all dnode objects are
properly deconstructed before being freed to the slab, and when the
objects are allocated from the slab all required data members are
explicity initialized to correct values.

commit | commitdiff | tree

Brian Behlendorf [Thu, 19 Mar 2009 22:07:16 +0000 (15:07 -0700)]

Merge branch 'fix-list' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Thu, 19 Mar 2009 22:02:05 +0000 (15:02 -0700)]

Resolve conflict with fix-dnode-cons

commit | commitdiff | tree

Brian Behlendorf [Mon, 16 Mar 2009 17:12:01 +0000 (10:12 -0700)]

Merge branch 'fix-deadcode' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Mon, 16 Mar 2009 17:02:06 +0000 (10:02 -0700)]

Remove two self referential functions.

Newer versions of gcc (4.3.0) detected the following unused
code segments.

commit | commitdiff | tree

Brian Behlendorf [Thu, 12 Mar 2009 22:21:30 +0000 (15:21 -0700)]

Merge branch 'fix-strncat' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Thu, 12 Mar 2009 22:20:26 +0000 (15:20 -0700)]

Add fix-strncat branch which corrects a buffer overrun.

commit | commitdiff | tree

Brian Behlendorf [Thu, 12 Mar 2009 16:24:29 +0000 (09:24 -0700)]

Merge branch 'fix-pthreads' into refs/top-bases/fix-branch

commit | commitdiff | tree

Brian Behlendorf [Thu, 12 Mar 2009 16:13:40 +0000 (09:13 -0700)]

ztest_resume should be ztest_resume_thread in pthread_create()

Fix an accidental bug introducted by the pthreads changes.  When creating
a resume thread the handler function was accidentally changed from
ztest_resume to ztest_resume_thread.  There's a decent chance this
may explain some/all of the crashes that have be observed running
ztest.  This issue was exposed and easily fixed once the -Wno-unused
check was removed from the build system.  Happily at least one real
bug fix resulted from that cleanup.

commit | commitdiff | tree

Brian Behlendorf [Wed, 18 Feb 2009 22:30:38 +0000 (14:30 -0800)]

Merge branch 'fix-list' into refs/top-bases/fix-branch

Conflicts:

module/zfs/arc.c

Unnamed repository; edit this file 'description' to name the repository.

RSS Atom