]>
granicus.if.org Git - neomutt/log
Richard Russon [Thu, 22 Nov 2018 12:35:43 +0000 (12:35 +0000)]
factor out Context from mx_toggle_write()
Richard Russon [Thu, 22 Nov 2018 12:28:22 +0000 (12:28 +0000)]
factor out Context from link_threads()
Richard Russon [Thu, 22 Nov 2018 12:27:40 +0000 (12:27 +0000)]
factor out Context from mutt_messages_in_thread()
Richard Russon [Thu, 22 Nov 2018 12:24:00 +0000 (12:24 +0000)]
factor out Context from mbox_open_append()
Richard Russon [Thu, 22 Nov 2018 12:17:30 +0000 (12:17 +0000)]
factor out Context from check_subjects()
Richard Russon [Thu, 22 Nov 2018 12:16:37 +0000 (12:16 +0000)]
factor out Context from make_subj_hash()
Richard Russon [Thu, 22 Nov 2018 12:13:29 +0000 (12:13 +0000)]
factor out Context from find_subject()
Richard Russon [Thu, 22 Nov 2018 11:49:23 +0000 (11:49 +0000)]
factor out Context from mutt_newsgroup_uncatchup()
Richard Russon [Thu, 22 Nov 2018 11:48:29 +0000 (11:48 +0000)]
factor out Context from mutt_newsgroup_catchup()
Richard Russon [Wed, 21 Nov 2018 15:18:16 +0000 (15:18 +0000)]
factor out Context from mx_msg_commit()
Richard Russon [Wed, 21 Nov 2018 14:59:25 +0000 (14:59 +0000)]
move Context flags to Mailbox
Richard Russon [Wed, 21 Nov 2018 14:48:19 +0000 (14:48 +0000)]
light tidying
Richard Russon [Wed, 21 Nov 2018 14:47:47 +0000 (14:47 +0000)]
factor out Context from mx_tags_is_supported()
Richard Russon [Wed, 21 Nov 2018 14:45:46 +0000 (14:45 +0000)]
factor out Context from tags_edit()
Richard Russon [Wed, 21 Nov 2018 14:26:00 +0000 (14:26 +0000)]
factor out Context from tags_commit()
Richard Russon [Wed, 21 Nov 2018 14:25:41 +0000 (14:25 +0000)]
factor out Context from msg_padding_size()
Richard Russon [Wed, 21 Nov 2018 14:18:48 +0000 (14:18 +0000)]
notmuch: factor out Context
Mehdi Abaakouk [Wed, 21 Nov 2018 08:51:04 +0000 (09:51 +0100)]
Use Mailbox instead of Context
This aims to remove Context from mutt_set_flag, to do so other function
signature have been changed too.
* mutt_set_flag_update
* mx_msg_open
* mx_msg_open_new
* mx_msg_close
* mutt_pattern_exec
* mutt_parse_mime_message
* mutt_set_header_color
* mutt_count_body_parts
Mehdi Abaakouk [Tue, 20 Nov 2018 22:58:03 +0000 (23:58 +0100)]
move ctx->tagged to mailbox->msg_tagged
Mehdi Abaakouk [Tue, 20 Nov 2018 17:20:17 +0000 (18:20 +0100)]
imap: remove unused define
Pietro Cerutti [Tue, 20 Nov 2018 15:16:22 +0000 (15:16 +0000)]
Keep adata on imap-logout-all
The former call to `imap_adata_free((void **) adata);` caused an account to be around with no adata associated with it. This caused a crash when trying to access the account later on.
Richard Russon [Tue, 20 Nov 2018 11:05:17 +0000 (11:05 +0000)]
merge: imap: refactor status functions
* imap: remove useless static int queued in imap_status()
* imap: remove MESSAGES count optimization
* imap: merge all STATUS function
Mehdi Abaakouk [Mon, 19 Nov 2018 13:38:49 +0000 (14:38 +0100)]
imap: merge all STATUS function
This change creates only one STATUS function.
Mehdi Abaakouk [Mon, 19 Nov 2018 12:38:32 +0000 (13:38 +0100)]
imap: remove MESSAGES count optimization
This optimization is buggy, it puts sometimes mdata->messages out of
sync with m->msg_count;
This optimization links in an not obvious way the cmd_parse_status and
mx_mailbox_check().
This change removes this useless optimization and just always asks for
MESSAGES during STATUS.
Mehdi Abaakouk [Mon, 19 Nov 2018 12:14:57 +0000 (13:14 +0100)]
imap: remove useless static int queued in imap_status()
Only imap_mbox_open() passes true to queue parameter of imap_status().
imap_mbox_open() takes care of flushing/droppping the imap pipeline
comamnds.
So we don't need this extra check about queued STATUS.
This change removes it.
Mehdi Abaakouk [Sun, 18 Nov 2018 19:39:36 +0000 (20:39 +0100)]
imap: move flags in ImapMboxData
Flags are a per mailbox thing.
So moves in ImapMboxData.
Mehdi Abaakouk [Mon, 19 Nov 2018 14:17:27 +0000 (15:17 +0100)]
imap: reduce complexity of imap_exec
imap_exec flag IMAP_CMD_FAIL_OK is the only one that configure the
function return instead of the function behavior.
Also returned value of the function depends on the flag make hard to
understand what happen after imap_exec() is run.
This change removes this flags, instead we always returns the detailed
returns code, the caller have to deal with it.
Return code are always IMAP_EXEC_SUCCESS/IMAP_EXEC_ERROR/IMAP_EXEC_FATAL and
depends on if the command succeed, failure or if the imap connection
fail.
Mehdi Abaakouk [Tue, 20 Nov 2018 07:39:18 +0000 (08:39 +0100)]
ssl: don't shutdown broken connection
Closes #1440
Edward Betts [Mon, 19 Nov 2018 17:40:13 +0000 (17:40 +0000)]
account.login is empty, use account.user instead
Mehdi Abaakouk [Mon, 19 Nov 2018 06:56:47 +0000 (07:56 +0100)]
imap: tidy doc
Richard Russon [Sun, 18 Nov 2018 17:41:31 +0000 (17:41 +0000)]
merge: trivial fixes
* pop: remove sleeps on error paths
* nntp: reorg cleanup
* fix coverity defects
* fix typos
* mailbox tidy
* boolify
* rename vars
* close attachments before closing logging
* mbox: refactor for clarity
Richard Russon [Sun, 18 Nov 2018 16:59:08 +0000 (16:59 +0000)]
mbox: refactor for clarity
Richard Russon [Sun, 18 Nov 2018 16:48:53 +0000 (16:48 +0000)]
close attachments before closing logging
Richard Russon [Fri, 9 Nov 2018 12:25:05 +0000 (12:25 +0000)]
rename vars
Richard Russon [Fri, 9 Nov 2018 12:00:54 +0000 (12:00 +0000)]
boolify
Richard Russon [Wed, 7 Nov 2018 19:15:16 +0000 (19:15 +0000)]
mailbox tidy
Richard Russon [Sat, 17 Nov 2018 14:44:40 +0000 (14:44 +0000)]
fix typos
Richard Russon [Fri, 16 Nov 2018 18:49:15 +0000 (18:49 +0000)]
fix coverity defects
Richard Russon [Mon, 5 Nov 2018 22:54:20 +0000 (22:54 +0000)]
nntp: reorg cleanup
Richard Russon [Fri, 9 Nov 2018 12:04:17 +0000 (12:04 +0000)]
pop: remove sleeps on error paths
Mehdi Abaakouk [Sun, 18 Nov 2018 13:30:40 +0000 (14:30 +0100)]
imap: remove ImapCommandType
ImapAccountData->cmdtype can only be IMAP_CT_LIST
cmddata can only be set to an ImapList.
This change removes cmdtype and rename void *cmddata to ImapList
*cmdresult.
Mehdi Abaakouk [Sat, 17 Nov 2018 17:39:32 +0000 (18:39 +0100)]
ImapStatus doesn't make sense since we have ImapMboxData.
Some attributes are duplicated a synced between strucuture.
This change moves all STATUS informations in ImapMboxData
and remove ImapStatus structure.
mboxcache is also removed because ImapMboxData stay in memory during the
whole Mailbox life, no more need to cache that.
Richard Russon [Sat, 17 Nov 2018 22:54:32 +0000 (22:54 +0000)]
nntp: remove unnec context reference
Mehdi Abaakouk [Fri, 16 Nov 2018 14:05:53 +0000 (15:05 +0100)]
imap: move some adata attributes to mdata
Richard Russon [Fri, 16 Nov 2018 15:39:00 +0000 (15:39 +0000)]
nntp: fix url usage
Richard Russon [Fri, 16 Nov 2018 14:49:36 +0000 (14:49 +0000)]
fix leak in imap_status()
Richard Russon [Fri, 16 Nov 2018 13:46:04 +0000 (13:46 +0000)]
fix leak in imap_ac_add()
Richard Russon [Fri, 16 Nov 2018 16:34:27 +0000 (16:34 +0000)]
imap: fix browser
Pietro Cerutti [Fri, 16 Nov 2018 15:55:16 +0000 (15:55 +0000)]
Avoid segfault when an IMAP connection cannot be opened (II)
Part II of 6a2e9f, which broke edit-msg. It turns out that mx_ac_add()
is not required to be successful, e.g., when opening a temporary file.
This means we must be extra cautious and check that m->account->adata is
valid before using it
Pietro Cerutti [Fri, 16 Nov 2018 13:11:17 +0000 (13:11 +0000)]
Make sure error buffer is properly initialized
Richard Russon [Fri, 16 Nov 2018 13:07:49 +0000 (13:07 +0000)]
merge: update translations
* Update zh_CN translation
* Update Czech translation
* More translations
* Update lt_LT translations
* Update Polish translation
* update German translation
* fix Polish format spec
* Update lt_LT translation
* Update Czech translation
* Update Slovak translation
* fixing typos in Polish translation
* update filenames
* sync translations
Richard Russon [Fri, 16 Nov 2018 13:06:36 +0000 (13:06 +0000)]
sync translations
Richard Russon [Fri, 16 Nov 2018 13:03:37 +0000 (13:03 +0000)]
update filenames
Marcin Rajner [Tue, 13 Nov 2018 09:23:33 +0000 (10:23 +0100)]
fixing typos in Polish translation
David Sterba [Fri, 1 Jun 2018 10:37:25 +0000 (12:37 +0200)]
Update Slovak translation
David Sterba [Thu, 1 Nov 2018 13:03:22 +0000 (14:03 +0100)]
Update Czech translation
Marius Gedminas [Wed, 31 Oct 2018 14:51:53 +0000 (16:51 +0200)]
Update lt_LT translation
(I accidentally re-translated lt.po in master, and when I tried to
cherry-pick my translation onto the translate branch I noticed that I'd
translated a couple of messages incorrectly.)
Richard Russon [Fri, 12 Oct 2018 16:26:29 +0000 (17:26 +0100)]
fix Polish format spec
ab [Fri, 12 Oct 2018 15:44:14 +0000 (17:44 +0200)]
update German translation
Marcin Rajner [Tue, 9 Oct 2018 15:40:55 +0000 (17:40 +0200)]
Update Polish translation
Marius Gedminas [Tue, 18 Sep 2018 10:19:50 +0000 (13:19 +0300)]
Update lt_LT translations
New messages, new fuzz, some old typos.
Winderickx Eli (p087068) [Thu, 13 Sep 2018 12:58:18 +0000 (14:58 +0200)]
More translations
David Sterba [Fri, 7 Sep 2018 09:54:19 +0000 (11:54 +0200)]
Update Czech translation
Zero King [Tue, 4 Sep 2018 03:41:35 +0000 (03:41 +0000)]
Update zh_CN translation
Richard Russon [Fri, 16 Nov 2018 12:55:11 +0000 (12:55 +0000)]
merge: trivial fixes
* doxygen: sort out Email descriptions
* boolify params/retvals
* imap: simplify some helper functions
* remove unused member
* imap: tiny refactor
* doxygen: unify docs for private data
* rename: _create to _new for simple allocs
Richard Russon [Fri, 16 Nov 2018 12:51:10 +0000 (12:51 +0000)]
rename: _create to _new for simple allocs
Richard Russon [Fri, 16 Nov 2018 12:23:03 +0000 (12:23 +0000)]
doxygen: unify docs for private data
Richard Russon [Fri, 16 Nov 2018 12:01:54 +0000 (12:01 +0000)]
imap: tiny refactor
Richard Russon [Fri, 16 Nov 2018 12:00:09 +0000 (12:00 +0000)]
remove unused member
Richard Russon [Fri, 16 Nov 2018 11:59:08 +0000 (11:59 +0000)]
imap: simplify some helper functions
Richard Russon [Fri, 16 Nov 2018 11:47:16 +0000 (11:47 +0000)]
boolify params/retvals
Richard Russon [Fri, 16 Nov 2018 11:42:31 +0000 (11:42 +0000)]
doxygen: sort out Email descriptions
Richard Russon [Fri, 16 Nov 2018 12:33:00 +0000 (12:33 +0000)]
clang-format
Richard Russon [Fri, 16 Nov 2018 11:14:44 +0000 (11:14 +0000)]
rename: curs_main.c to index.c
Richard Russon [Fri, 16 Nov 2018 11:26:21 +0000 (11:26 +0000)]
merge: Simplify URL APIs
* Simplify URL APIs
* Remove unused U_DECODE_PASSWD flag
* Add a basic unit test for URL
* Convert NotMuch to the new URL API
* Additional improvements to URL API and implementation
* Additional tests for URL
* Avoid flexible array members, improve URL test code
Pietro Cerutti [Fri, 16 Nov 2018 07:57:41 +0000 (07:57 +0000)]
Avoid flexible array members, improve URL test code
Pietro Cerutti [Thu, 15 Nov 2018 16:38:51 +0000 (16:38 +0000)]
Additional tests for URL
Pietro Cerutti [Thu, 15 Nov 2018 16:37:47 +0000 (16:37 +0000)]
Additional improvements to URL API and implementation
Pietro Cerutti [Thu, 15 Nov 2018 14:28:38 +0000 (14:28 +0000)]
Convert NotMuch to the new URL API
Pietro Cerutti [Thu, 15 Nov 2018 14:12:26 +0000 (14:12 +0000)]
Add a basic unit test for URL
Pietro Cerutti [Thu, 15 Nov 2018 13:33:17 +0000 (13:33 +0000)]
Remove unused U_DECODE_PASSWD flag
Pietro Cerutti [Thu, 15 Nov 2018 13:28:47 +0000 (13:28 +0000)]
Simplify URL APIs
Mehdi Abaakouk [Fri, 16 Nov 2018 09:00:23 +0000 (10:00 +0100)]
imap: ensure we can't delete the current selected mailbox
Closes #1417
Mehdi Abaakouk [Fri, 16 Nov 2018 05:51:25 +0000 (06:51 +0100)]
imap: add missing conn_account free
Pietro Cerutti [Fri, 16 Nov 2018 09:42:51 +0000 (09:42 +0000)]
Avoid segfault when an IMAP connection cannot be opened
This could be reproduced trying to open an IMAPS connection with a
NeoMutt built without SSL support.
Richard Russon [Thu, 15 Nov 2018 16:09:40 +0000 (16:09 +0000)]
merge: remove ImapMbox
* imap: make imap_mailbox_check aware of Mailbox
* imap: setup a mdata struct for each mailboxes
* imap: remove ImapMbox from imap_prepare_mailbox
* imap: remove ImapMbox from imap_adata_find signature
* imap: remove get_mailbox()
* imap: remove ImapMbox from imap_fast_trash()
* imap: remove ImapMbox from imap_ac_add()
* imap: remove ImapMbox from imap_mbox_open()
* imap: remove ImapMbox from imap_delete_mailbox()
* imap: remove ImapMbox from imap_adata_find()
* imap: remove ImapMbox from imap_append_message()
* imap: remove ImapMbox from imap_copy_messages()
* imap: remove ImapMbox from imap_hcache_open()
* imap: remove ImapMbox from imap_browse()
* imap: remove useless allocation in imap_mailbox_create()
* imap: create mdata in imap_prepare_mailbox()
* imap: remove ImapMbox from cmd_parse_status()
* imap: remove ImapMbox from add_folder()
* imap: remove ImapMbox from browse_add_list_result()
* imap: remove ImapMbox from imap_pretty_mailbox()
* imap: remove ImapMbox and imap_parse_path()
* imap: remove now useless param of imap_prepare_mailbox
* imap: remove imap_parse_path2() from imap_hcache_open()
* imap: remove imap_parse_path2() from imap_rename_mailbox()
* imap: remove imap_parse_path2() from imap_append_message()
* imap: always parse account in imap_parse_path2()
* imap: remove old PINE url format
* imap: handle all mailbox name with ImapMailboxData struct
* imap: ensure account flags are zero'ed
* imap: Check m->has_new to increase MailboxCount
* imap: rename imap_parse_path2() imap_parse_path()
* imap: rename imap_qualify_path2() to imap_qualify_path()
* imap: rename ImapMailboxData to ImapMboxData
Mehdi Abaakouk [Thu, 15 Nov 2018 13:50:17 +0000 (14:50 +0100)]
imap: rename ImapMailboxData to ImapMboxData
Mehdi Abaakouk [Thu, 15 Nov 2018 11:02:16 +0000 (12:02 +0100)]
imap: rename imap_qualify_path2() to imap_qualify_path()
Mehdi Abaakouk [Thu, 15 Nov 2018 10:57:41 +0000 (11:57 +0100)]
imap: rename imap_parse_path2() imap_parse_path()
Mehdi Abaakouk [Thu, 15 Nov 2018 09:26:41 +0000 (10:26 +0100)]
imap: Check m->has_new to increase MailboxCount
Mehdi Abaakouk [Thu, 15 Nov 2018 06:56:48 +0000 (07:56 +0100)]
imap: ensure account flags are zero'ed
Mehdi Abaakouk [Wed, 14 Nov 2018 13:13:42 +0000 (14:13 +0100)]
imap: handle all mailbox name with ImapMailboxData struct
Mehdi Abaakouk [Wed, 14 Nov 2018 09:22:06 +0000 (10:22 +0100)]
imap: remove old PINE url format
This format is broken since a while (when we started to use url_parse
to get the mailbox name).
This change removes it.
Mehdi Abaakouk [Wed, 14 Nov 2018 09:12:06 +0000 (10:12 +0100)]
imap: always parse account in imap_parse_path2()
Mehdi Abaakouk [Wed, 14 Nov 2018 09:14:04 +0000 (10:14 +0100)]
imap: remove imap_parse_path2() from imap_append_message()
Mehdi Abaakouk [Wed, 14 Nov 2018 09:10:06 +0000 (10:10 +0100)]
imap: remove imap_parse_path2() from imap_rename_mailbox()
Mehdi Abaakouk [Wed, 14 Nov 2018 09:07:37 +0000 (10:07 +0100)]
imap: remove imap_parse_path2() from imap_hcache_open()
Mehdi Abaakouk [Wed, 14 Nov 2018 08:56:09 +0000 (09:56 +0100)]
imap: remove now useless param of imap_prepare_mailbox
Mehdi Abaakouk [Wed, 14 Nov 2018 08:47:28 +0000 (09:47 +0100)]
imap: remove ImapMbox and imap_parse_path()
Mehdi Abaakouk [Wed, 14 Nov 2018 08:46:06 +0000 (09:46 +0100)]
imap: remove ImapMbox from imap_pretty_mailbox()