Jay Satiro [Thu, 9 May 2019 06:01:34 +0000 (02:01 -0400)]
Revert "multi: support verbose conncache closure handle"
This reverts commit
b0972bc.
- No longer show verbose output for the conncache closure handle.
The offending commit was added so that the conncache closure handle
would inherit verbose mode from the user's easy handle. (Note there is
no way for the user to set options for the closure handle which is why
that was necessary.) Other debug settings such as the debug function
were not also inherited since we determined that could lead to crashes
if the user's per-handle private data was used on an unexpected handle.
The reporter here says he has a debug function to capture the verbose
output, and does not expect or want any output to stderr; however
because the conncache closure handle does not inherit the debug function
the verbose output for that handle does go to stderr.
There are other plausible scenarios as well such as the user redirects
stderr on their handle, which is also not inherited since it could lead
to crashes when used on an unexpected handle.
Short of allowing the user to set options for the conncache closure
handle I don't think there's much we can safely do except no longer
inherit the verbose setting.
Bug: https://curl.haxx.se/mail/lib-2019-05/0021.html
Reported-by: Kristoffer Gleditsch
Ref: https://github.com/curl/curl/pull/3598
Ref: https://github.com/curl/curl/pull/3618
Closes https://github.com/curl/curl/pull/3856
Steve Holme [Thu, 9 May 2019 09:54:46 +0000 (10:54 +0100)]
ntlm: Fix misaligned function comments for Curl_auth_ntlm_cleanup()
From
6012fa5a.
Closes #3858
Daniel Stenberg [Thu, 9 May 2019 21:30:26 +0000 (23:30 +0200)]
BUG-BOUNTY: minor formatting fixes [ci skip]
Daniel Stenberg [Thu, 9 May 2019 13:26:14 +0000 (15:26 +0200)]
RELEASE-NOTES: synced
Daniel Stenberg [Sat, 4 May 2019 21:58:11 +0000 (23:58 +0200)]
BUG-BOUNTY.md: add the Dropbox "bonus" extra payout ability [ci skip]
Closes #3839
Kamil Dudka [Mon, 6 May 2019 12:32:00 +0000 (14:32 +0200)]
http_negotiate: do not treat failure of gss_init_sec_context() as fatal
Fixes #3726
Closes #3849
Kamil Dudka [Mon, 6 May 2019 12:16:35 +0000 (14:16 +0200)]
spnego_gssapi: fix return code on gss_init_sec_context() failure
Fixes #3726
Closes #3849
Steve Holme [Wed, 8 May 2019 09:44:41 +0000 (10:44 +0100)]
gen_resp_file.bat: Removed unnecessary @ from all but the first command
There is need to use @ on every command once echo has been turned off.
Closes #3854
Jay Satiro [Wed, 8 May 2019 07:39:53 +0000 (03:39 -0400)]
http: Ignore HTTP/2 prior knowledge setting for HTTP proxies
- Do not switch to HTTP/2 for an HTTP proxy that is not tunnelling to
the destination host.
We already do something similar for HTTPS proxies by not sending h2. [1]
Prior to this change setting CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE would
incorrectly use HTTP/2 to talk to the proxy, which is not something we
support (yet?). Also it's debatable whether or not that setting should
apply to HTTP/2 proxies.
[1]: https://github.com/curl/curl/commit/
17c5d05
Bug: https://github.com/curl/curl/issues/3570
Bug: https://github.com/curl/curl/issues/3832
Closes https://github.com/curl/curl/pull/3853
Marcel Raad [Sat, 4 May 2019 17:39:49 +0000 (19:39 +0200)]
travis: update mesalink build to xenial
Closes https://github.com/curl/curl/pull/3842
Ricky Leverence [Fri, 12 Apr 2019 18:53:12 +0000 (11:53 -0700)]
OpenSSL: Report -fips in version if OpenSSL is built with FIPS
Older versions of OpenSSL report FIPS availabilty via an OPENSSL_FIPS
define. It uses this define to determine whether to publish -fips at
the end of the version displayed. Applications that utilize the version
reported by OpenSSL will see a mismatch if they compare it to what curl
reports, as curl is not modifying the version in the same way. This
change simply adds a check to see if OPENSSL_FIPS is defined, and will
alter the reported version to match what OpenSSL itself provides. This
only appears to be applicable in versions of OpenSSL <1.1.1
Closes #3771
Frank Gevaerts [Fri, 26 Apr 2019 09:23:15 +0000 (11:23 +0200)]
nss: allow fifos and character devices for certificates.
Currently you can do things like --cert <(cat ./cert.crt) with (at least) the
openssl backend, but that doesn't work for nss because is_file rejects fifos.
I don't actually know if this is sufficient, nss might do things internally
(like seeking back) that make this not work, so actual testing is needed.
Closes #3807
Daniel Gustafsson [Mon, 6 May 2019 17:12:39 +0000 (20:12 +0300)]
test2100: Fix typos in test description
Daniel Stenberg [Sun, 5 May 2019 21:42:29 +0000 (23:42 +0200)]
ssh: define USE_SSH if SSH is enabled (any backend)
Closes #3846
Steve Holme [Sun, 5 May 2019 19:17:58 +0000 (20:17 +0100)]
winbuild: Add our standard copyright header to the winbuild batch files
Steve Holme [Sat, 4 May 2019 21:46:52 +0000 (22:46 +0100)]
makedebug: Fix ERRORLEVEL detection after running where.exe
Closes #3838
Daniel Stenberg [Fri, 3 May 2019 11:18:12 +0000 (13:18 +0200)]
urlapi: add CURLUPART_ZONEID to set and get
The zoneid can be used with IPv6 numerical addresses.
Updated test 1560 to verify.
Closes #3834
Taiyu Len [Sat, 4 May 2019 06:59:28 +0000 (23:59 -0700)]
WRITEFUNCTION: add missing set_in_callback around callback
Closes #3837
Daniel Stenberg [Sat, 4 May 2019 21:50:18 +0000 (23:50 +0200)]
RELEASE-NOTES: synced
Daniel Stenberg [Fri, 3 May 2019 13:44:49 +0000 (15:44 +0200)]
CURLMOPT_TIMERFUNCTION.3: warn about the recursive risk [ci skip]
Reported-by: Ricardo Gomes
Bug: #3537
Closes #3836
Daniel Stenberg [Fri, 3 May 2019 11:43:13 +0000 (13:43 +0200)]
CURLOPT_CHUNK_BGN_FUNCTION.3: document the struct and time value
The time field in the curl_fileinfo struct will always be zero. No code
was ever implemented to actually convert the date string to a time_t.
Fixes #3829
Closes #3835
Daniel Stenberg [Fri, 3 May 2019 21:18:58 +0000 (23:18 +0200)]
OS400/ccsidcurl.c: code style fixes
Daniel Stenberg [Fri, 3 May 2019 21:05:32 +0000 (23:05 +0200)]
OS400/ccsidcurl: replace use of Curl_vsetopt
(and make the code style comply)
Fixes #3833
Daniel Stenberg [Tue, 30 Apr 2019 14:59:08 +0000 (16:59 +0200)]
urlapi: strip off scope id from numerical IPv6 addresses
... to make the host name "usable". Store the scope id and put it back
when extracting a URL out of it.
Also makes curl_url_set() syntax check CURLUPART_HOST.
Fixes #3817
Closes #3822
Daniel Stenberg [Thu, 2 May 2019 09:13:57 +0000 (11:13 +0200)]
RELEASE-NOTES: synced
Daniel Stenberg [Wed, 1 May 2019 20:56:14 +0000 (22:56 +0200)]
multiif.h: remove unused protos
... for functions related to pipelining. Those functions were removed in
2f44e94efb3df.
Closes #3828
Yiming Jing [Wed, 1 May 2019 01:23:37 +0000 (18:23 -0700)]
travis: mesalink: temporarily disable test 3001
... due to SHA-1 signatures in test certs
Yiming Jing [Tue, 30 Apr 2019 22:46:46 +0000 (15:46 -0700)]
travis: upgrade the MesaLink TLS backend to v1.0.0
Closes #3823
Closes #3776
Daniel Stenberg [Tue, 30 Apr 2019 09:16:53 +0000 (11:16 +0200)]
ConnectionExists: improve non-multiplexing use case
- better log output
- make sure multiplex is enabled for it to be used
Daniel Stenberg [Tue, 30 Apr 2019 09:14:38 +0000 (11:14 +0200)]
multi: provide Curl_multiuse_state to update information
As soon as a TLS backend gets ALPN conformation about the specific HTTP
version it can now set the multiplex situation for the "bundle" and
trigger moving potentially queued up transfers to the CONNECT state.
Daniel Stenberg [Tue, 30 Apr 2019 09:12:12 +0000 (11:12 +0200)]
process_pending_handles: mark queued transfers as previously pending
With transfers being queued up, we only move one at a a time back to the
CONNECT state but now we mark moved transfers so that when a moved
transfer is confirmed "successful" (it connected) it will trigger the
move of another pending transfer. Previously, it would otherwise wait
until the transfer was done before doing this. This makes queued up
pending transfers get processed (much) faster.
Daniel Stenberg [Tue, 30 Apr 2019 09:09:10 +0000 (11:09 +0200)]
http: mark bundle as not for multiuse on < HTTP/2 response
Fixes #3813
Closes #3815
Daniel Gustafsson [Wed, 1 May 2019 11:14:15 +0000 (13:14 +0200)]
cookie: Guard against possible NULL ptr deref
In case the name pointer isn't set (due to memory pressure most likely)
we need to skip the prefix matching and reject with a badcookie to avoid
a possible NULL pointer dereference.
Closes #3820 #3821
Reported-by: Jonathan Moerman
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
Patrick Monnerat [Tue, 30 Apr 2019 12:29:16 +0000 (14:29 +0200)]
os400: Add CURLOPT_MAXAGE_CONN to ILE/RPG bindings
Kamil Dudka [Fri, 26 Apr 2019 10:20:21 +0000 (12:20 +0200)]
nss: provide more specific error messages on failed init
Closes #3808
Reed Loden [Sun, 28 Apr 2019 21:14:23 +0000 (14:14 -0700)]
docs: minor polish to the bug bounty / security docs
Closes #3811
Daniel Stenberg [Mon, 29 Apr 2019 06:00:49 +0000 (08:00 +0200)]
CURL_MAX_INPUT_LENGTH: largest acceptable string input size
This limits all accepted input strings passed to libcurl to be less than
CURL_MAX_INPUT_LENGTH (
8000000) bytes, for these API calls:
curl_easy_setopt() and curl_url_set().
The
8000000 number is arbitrary picked and is meant to detect mistakes
or abuse, not to limit actual practical use cases. By limiting the
acceptable string lengths we also reduce the risk of integer overflows
all over.
NOTE: This does not apply to `CURLOPT_POSTFIELDS`.
Test 1559 verifies.
Closes #3805
Tseng Jun [Sun, 28 Apr 2019 07:25:15 +0000 (15:25 +0800)]
curlver.h: use parenthesis in CURL_VERSION_BITS macro
Closes #3809
Simon Warta [Fri, 12 Apr 2019 12:44:59 +0000 (14:44 +0200)]
cmake: rename CMAKE_USE_DARWINSSL to CMAKE_USE_SECTRANSP
Closes https://github.com/curl/curl/pull/3769
Steve Holme [Tue, 23 Apr 2019 19:26:02 +0000 (20:26 +0100)]
ntlm: Missed pre-processor || (or) during rebase for
cd15acd0
Steve Holme [Sat, 13 Apr 2019 20:47:56 +0000 (21:47 +0100)]
ntlm: Support the NT response in the type-3 when OpenSSL doesn't include MD4
Just like we do for mbed TLS, use our local implementation of MD4 when
OpenSSL doesn't support it. This allows a type-3 message to include the
NT response.
Daniel Gustafsson [Tue, 23 Apr 2019 10:38:31 +0000 (12:38 +0200)]
INTERNALS: fix misindentation of ToC item
Kerberos was incorrectly indented as a subsection under FTP, which is
incorrect as they are both top level sections. A fix for this was first
attempted in commit
fef38a0898322f285401c5ff2f5e7c90dbf3be63 but that
was a few paddles short of being complete.
Aron Bergman [Tue, 23 Apr 2019 09:36:22 +0000 (11:36 +0200)]
INTERNALS: Add structs to ToC
Add the subsections under "Structs in libcurl" to the table of contents.
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Aron Bergman [Tue, 23 Apr 2019 09:29:47 +0000 (11:29 +0200)]
INTERNALS: Add code highlighting
Make all struct members under the Curl_handler section
print in monospace font.
Closes #3801
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Daniel Stenberg [Sat, 20 Apr 2019 10:19:47 +0000 (12:19 +0200)]
docs/BUG-BOUNTY: bug bounty time [skip ci]
Introducing the curl bug bounty program on hackerone. We now recommend
filing security issues directly in the hackerone ticket system which
only is readable to curl security team members.
Assisted-by: Daniel Gustafsson
Closes #3488
Steve Holme [Thu, 18 Apr 2019 20:54:35 +0000 (21:54 +0100)]
sasl: Don't send authcid as authzid for the PLAIN mechanism as per RFC 4616
RFC 4616 specifies the authzid is optional in the client authentication
message and that the server will derive the authorisation identity
(authzid) from the authentication identity (authcid) when not specified
by the client.
Gisle Vanem [Mon, 22 Apr 2019 07:04:26 +0000 (03:04 -0400)]
memdebug: fix variable name
Follow-up to
76b6348 which renamed logfile as curl_dbg_logfile.
Ref: https://github.com/curl/curl/commit/
76b6348#r33259088
Steve Holme [Wed, 17 Apr 2019 22:06:05 +0000 (23:06 +0100)]
vauth/cleartext: Don't send the authzid if it is empty
Follow up to
762a292f.
Daniel Stenberg [Sat, 20 Apr 2019 10:59:05 +0000 (12:59 +0200)]
test 196,197,198: add 'retry' keyword [skip ci]
Daniel Stenberg [Sun, 21 Apr 2019 21:24:55 +0000 (23:24 +0200)]
RELEASE-NOTES: synced
Daniel Stenberg [Sun, 14 Apr 2019 21:20:01 +0000 (23:20 +0200)]
CURLOPT_MAXAGE_CONN: set the maximum allowed age for conn reuse
... and disconnect too old ones instead of trying to reuse.
Default max age is set to 118 seconds.
Ref: #3722
Closes #3782
Po-Chuan Hsieh [Sat, 30 Mar 2019 19:11:57 +0000 (19:11 +0000)]
altsvc: Fix building with cookies disables
ALTSVC requires Curl_get_line which is defined in lib/cookie.c inside a #if
check of HTTP and COOKIES. That makes Curl_get_line undefined if COOKIES is
disabled. Fix by splitting out the function into a separate file which can
be included where needed.
Closes #3717
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Marcel Raad <Marcel.Raad@teamviewer.com>
Daniel Stenberg [Fri, 19 Apr 2019 16:25:18 +0000 (18:25 +0200)]
test1002: correct the name [skip ci]
Daniel Stenberg [Fri, 19 Apr 2019 21:33:02 +0000 (23:33 +0200)]
test660: verify CONNECT_ONLY with IMAP
which basically just makes sure LOGOUT is *not* issued on disconnect
Daniel Stenberg [Fri, 19 Apr 2019 14:58:27 +0000 (16:58 +0200)]
Curl_disconnect: treat all CONNECT_ONLY connections as "dead"
Since the connection has been used by the "outside" we don't know the
state of it anymore and curl should not use it anymore.
Bug: https://curl.haxx.se/mail/lib-2019-04/0052.html
Closes #3795
Daniel Stenberg [Fri, 19 Apr 2019 14:56:32 +0000 (16:56 +0200)]
multi: fix the statenames (follow-up fix from
2f44e94efb3df8e)
The list of names must be in sync with the defined states in the header
file!
Steve Holme [Tue, 16 Apr 2019 19:56:30 +0000 (20:56 +0100)]
openvms: Remove pre-processors for Windows as VMS cannot support them
Steve Holme [Mon, 15 Apr 2019 22:12:00 +0000 (23:12 +0100)]
openvms: Remove pre-processor for SecureTransport as VMS cannot support it
Fixes #3768
Closes #3785
Jay Satiro [Tue, 16 Apr 2019 19:45:41 +0000 (15:45 -0400)]
TODO: Add issue link to an existing entry
Daniel Stenberg [Tue, 16 Apr 2019 07:34:48 +0000 (09:34 +0200)]
RELEASE-NOTES: synced
Jay Satiro [Sat, 13 Apr 2019 05:12:18 +0000 (01:12 -0400)]
tool_help: Warn if curl and libcurl versions do not match
.. because functionality may be affected if the versions differ.
This commit implements TODO 18.7 "warning if curl version is not in sync
with libcurl version".
Ref: https://github.com/curl/curl/blob/curl-7_64_1/docs/TODO#L1028-L1033
Closes https://github.com/curl/curl/pull/3774
Steve Holme [Mon, 15 Apr 2019 23:08:42 +0000 (00:08 +0100)]
md5: Update the function signature following
d84da52d
Steve Holme [Mon, 15 Apr 2019 21:40:43 +0000 (22:40 +0100)]
md5: Forgot to update the code alignment in
d84da52d
Steve Holme [Mon, 15 Apr 2019 21:38:20 +0000 (22:38 +0100)]
md5: Return CURLcode from the internally accessible functions
Following
28f826b3 to return CURLE_OK instead of numeric 0.
Daniel Gustafsson [Mon, 15 Apr 2019 13:23:58 +0000 (15:23 +0200)]
tests: Run global cleanup at end of tests
Make sure to run curl_global_cleanup() when shutting down the test
suite to release any resources allocated in the SSL setup. This is
clearly visible when running tests with PolarSSL where the thread
lock calloc() memory which isn't released when not running cleanup.
Below is an excerpt from the autobuild logs:
==12368== 96 bytes in 1 blocks are possibly lost in loss record 1 of 2
==12368== at 0x4837B65: calloc (vg_replace_malloc.c:752)
==12368== by 0x11A76E: curl_dbg_calloc (memdebug.c:205)
==12368== by 0x145CDF: Curl_polarsslthreadlock_thread_setup
(polarssl_threadlock.c:54)
==12368== by 0x145B37: Curl_polarssl_init (polarssl.c:865)
==12368== by 0x14129D: Curl_ssl_init (vtls.c:171)
==12368== by 0x118B4C: global_init (easy.c:158)
==12368== by 0x118BF5: curl_global_init (easy.c:221)
==12368== by 0x118D0B: curl_easy_init (easy.c:299)
==12368== by 0x114E96: test (lib1906.c:32)
==12368== by 0x115495: main (first.c:174)
Closes #3783
Reviewed-by: Marcel Raad <Marcel.Raad@teamviewer.com>
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
Marcel Raad [Sun, 14 Apr 2019 12:48:37 +0000 (14:48 +0200)]
travis: use mbedtls from Xenial
No need to build it from source anymore.
Closes https://github.com/curl/curl/pull/3779
Marcel Raad [Sun, 14 Apr 2019 12:42:23 +0000 (14:42 +0200)]
travis: use libpsl from Xenial
This makes building libpsl and libidn2 from source unnecessary and
removes the need for the autopoint and libunistring-dev packages.
Closes https://github.com/curl/curl/pull/3779
Daniel Stenberg [Mon, 15 Apr 2019 06:14:46 +0000 (08:14 +0200)]
runtests: start socksd like other servers
... without a $srcdir prefix. Triggered by the failures in several
autobuilds.
Closes #3781
Daniel Gustafsson [Sun, 14 Apr 2019 20:06:40 +0000 (22:06 +0200)]
socksd: Fix typos
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
Daniel Gustafsson [Sun, 14 Apr 2019 20:06:09 +0000 (22:06 +0200)]
socksd: Properly decorate static variables
Mark global variables static to avoid compiler warning in Clang when
using -Wmissing-variable-declarations.
Closes #3778
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
Steve Holme [Sun, 14 Apr 2019 13:08:15 +0000 (14:08 +0100)]
md(4|5): Fixed indentation oddities with the importation of replacement code
The indentation from
211d5329 and
57d6d253 was a little strange as
parts didn't align correctly, uses 4 spaces rather than 2. Checked
the indentation of the original source so it aligns, albeit, using
curl style.
Steve Holme [Sun, 14 Apr 2019 07:42:36 +0000 (08:42 +0100)]
md5: Code style to return CURLE_OK rather than numeric 0
Steve Holme [Sun, 14 Apr 2019 07:36:56 +0000 (08:36 +0100)]
md5: Corrected code style for some pointer arguments
Marcel Raad [Fri, 8 Mar 2019 19:26:10 +0000 (20:26 +0100)]
travis: update some builds to xenial
Xenial comes with more up-to-date software versions and more available
packages, some of which we currently build from source. Unfortunately,
some builds would fail with Xenial because of assertion failures in
Valgrind when using OpenSSL, so leave these at Trusty.
Closes https://github.com/curl/curl/pull/3777
Daniel Stenberg [Mon, 8 Apr 2019 17:43:48 +0000 (19:43 +0200)]
test: make tests and test scripts use socksd for SOCKS
Make all SOCKS tests use socksd instead of ssh.
Daniel Stenberg [Mon, 8 Apr 2019 13:27:56 +0000 (15:27 +0200)]
socksd: new SOCKS 4+5 server for tests
Closes #3752
Daniel Stenberg [Thu, 11 Apr 2019 06:43:33 +0000 (08:43 +0200)]
singleipconnect: show port in the verbose "Trying ..." message
To aid debugging better.
tmilburn [Thu, 7 Mar 2019 20:23:54 +0000 (20:23 +0000)]
CURLOPT_ADDRESS_SCOPE: fix range check and more
Commit
9081014 fixed most of the confusing issues between scope id and
scope however
844896d added bad limits checking assuming that the scope
is being set and not the scope id.
I have fixed the documentation so it all refers to scope ids.
In addition Curl_if2ip refered to the scope id as remote_scope_id which
is incorrect, so I renamed it to local_scope_id.
Adjusted-by: Daniel Stenberg
Closes #3655
Closes #3765
Fixes #3713
Daniel Stenberg [Thu, 11 Apr 2019 11:20:15 +0000 (13:20 +0200)]
urlapi: stricter CURLUPART_PORT parsing
Only allow well formed decimal numbers in the input.
Document that the number MUST be between 1 and 65535.
Add tests to test 1560 to verify the above.
Ref: https://github.com/curl/curl/issues/3753
Closes #3762
Jan-E [Fri, 12 Apr 2019 21:41:13 +0000 (23:41 +0200)]
winbuild: Support MultiSSL builds
- Remove the lines in winbuild/Makefile.vc that generate an error with
multiple SSL backends.
- Add /DCURL_WITH_MULTI_SSL in winbuild/MakefileBuild.vc if multiple SSL
backends are set.
Closes https://github.com/curl/curl/pull/3772
Daniel Stenberg [Fri, 12 Apr 2019 08:07:45 +0000 (10:07 +0200)]
travis: remove mesalink builds (temporarily?)
Since the mesalink build started to fail on travis, even though we build
a fixed release version, we disable it to prevent it from blocking
progress.
Closes #3767
Daniel Stenberg [Thu, 11 Apr 2019 15:22:52 +0000 (17:22 +0200)]
openssl: mark connection for close on TLS close_notify
Without this, detecting and avoid reusing a closed TLS connection
(without a previous GOAWAY) when doing HTTP/2 is tricky.
Reported-by: Tom van der Woerdt
Fixes #3750
Closes #3763
Daniel Stenberg [Fri, 12 Apr 2019 08:55:50 +0000 (10:55 +0200)]
RELEASE-NOTES: synced
Steve Holme [Wed, 10 Apr 2019 21:17:02 +0000 (22:17 +0100)]
vauth/cleartext: Update the PLAIN login function signature to match RFC 4616
Functionally this doesn't change anything as we still use the username
for both the authorisation identity and the authentication identity.
Closes #3757
Daniel Stenberg [Thu, 11 Apr 2019 09:28:11 +0000 (11:28 +0200)]
test1906: verify CURLOPT_CURLU + CURLOPT_PORT usage
Based-on-code-by: Poul T Lomholt
Daniel Stenberg [Thu, 11 Apr 2019 10:49:20 +0000 (12:49 +0200)]
url: always clone the CUROPT_CURLU handle
Since a few code paths actually update that data.
Fixes #3753
Closes #3761
Reported-by: Poul T Lomholt
Daniel Stenberg [Thu, 7 Mar 2019 14:39:43 +0000 (15:39 +0100)]
CURLOPT_DNS_USE_GLOBAL_CACHE: remove
Remove the code too. The functionality has been disabled in code since
7.62.0. Setting this option will from now on simply be ignored and have
no function.
Closes #3654
Marcel Raad [Tue, 2 Apr 2019 13:06:47 +0000 (15:06 +0200)]
travis: install libgnutls28-dev only for --with-gnutls build
Reduces the time needed for the other jobs a little.
Closes https://github.com/curl/curl/pull/3721
Marcel Raad [Tue, 2 Apr 2019 12:58:33 +0000 (14:58 +0200)]
travis: install libnss3-dev only for --with-nss build
Reduces the time needed for the other jobs a little.
Closes https://github.com/curl/curl/pull/3721
Marcel Raad [Tue, 2 Apr 2019 12:56:18 +0000 (14:56 +0200)]
travis: install libssh2-dev only for --with-libssh2 build
Reduces the time needed for the other jobs a little.
Closes https://github.com/curl/curl/pull/3721
Marcel Raad [Tue, 2 Apr 2019 12:51:21 +0000 (14:51 +0200)]
travis: install libssh-dev only for --with-libssh build
Reduces the time needed for the other jobs a little.
Closes https://github.com/curl/curl/pull/3721
Marcel Raad [Tue, 2 Apr 2019 12:46:23 +0000 (14:46 +0200)]
travis: install krb5-user only for --with-gssapi build
Reduces the time needed for the other jobs a little.
Closes https://github.com/curl/curl/pull/3721
Marcel Raad [Tue, 2 Apr 2019 12:35:19 +0000 (14:35 +0200)]
travis: install lcov only for the coverage job
Reduces the time needed for the other jobs a little.
Closes https://github.com/curl/curl/pull/3721
Marcel Raad [Tue, 2 Apr 2019 12:31:06 +0000 (14:31 +0200)]
travis: install clang only when needed
This reduces the GCC job runtimes a little and it's needed to
selectively update clang builds to xenial.
Closes https://github.com/curl/curl/pull/3721
Marcel Raad [Sun, 24 Feb 2019 18:05:28 +0000 (19:05 +0100)]
AppVeyor: enable testing for WinSSL build
Closes https://github.com/curl/curl/pull/3725
Marcel Raad [Fri, 5 Apr 2019 17:57:29 +0000 (19:57 +0200)]
build: fix Codacy/CppCheck warnings
- remove unused variables
- declare conditionally used variables conditionally
- suppress unused variable warnings in the CMake tests
- remove dead variable stores
- consistently use WIN32 macro to detect Windows
Closes https://github.com/curl/curl/pull/3739
Marcel Raad [Fri, 5 Apr 2019 17:46:05 +0000 (19:46 +0200)]
polarssl_threadlock: remove conditionally unused code
Make functions no-ops if neither both USE_THREADS_POSIX and
HAVE_PTHREAD_H nor both USE_THREADS_WIN32 and HAVE_PROCESS_H are
defined. Previously, if only one of them was defined, there was either
code compiled that did nothing useful or the wrong header included for
the functions used.
Also, move POLARSSL_MUTEX_T define to implementation file as it's not
used externally.
Closes https://github.com/curl/curl/pull/3739
Marcel Raad [Fri, 5 Apr 2019 09:18:12 +0000 (11:18 +0200)]
lib557: initialize variables
These variables are only conditionally initialized.
Closes https://github.com/curl/curl/pull/3739
Marcel Raad [Fri, 5 Apr 2019 09:12:25 +0000 (11:12 +0200)]
lib509: add missing include for strdup
Closes https://github.com/curl/curl/pull/3739
Marcel Raad [Fri, 5 Apr 2019 07:56:57 +0000 (09:56 +0200)]
README.md: fix no-consecutive-blank-lines Codacy warning
Consistently use one blank line between blocks.
Closes https://github.com/curl/curl/pull/3739