]>
granicus.if.org Git - php/log
George Peter Banyard [Mon, 20 Jul 2020 23:52:50 +0000 (00:52 +0100)]
Use ZPP callable check in readline extension
George Peter Banyard [Mon, 20 Jul 2020 23:19:32 +0000 (00:19 +0100)]
Use ZPP callable for PDO Sqlite
Dmitry Stogov [Mon, 20 Jul 2020 22:49:01 +0000 (01:49 +0300)]
Fixed tracing JIT exception handling
Máté Kocsis [Mon, 6 Jul 2020 09:28:10 +0000 (11:28 +0200)]
Explode _php_image_output_ctx() into multiple functions
Closes GH-5844
Dmitry Stogov [Mon, 20 Jul 2020 20:14:23 +0000 (23:14 +0300)]
Fixed VM interrupt handling
Dmitry Stogov [Mon, 20 Jul 2020 18:04:14 +0000 (21:04 +0300)]
Keep CPU regesters used by deoptimizer
Dmitry Stogov [Mon, 20 Jul 2020 17:57:12 +0000 (20:57 +0300)]
Fixed tracing JIT for VM without global register variables
Nikita Popov [Mon, 20 Jul 2020 14:56:20 +0000 (16:56 +0200)]
Preserve original ce_flags when registering class
Bug that regularly sneaks in: ZEND_ACC_FINAL is set before calling
zend_register_internal_class() and promptly gets ignored. Remove
this footgun by preserving flags from the original CE.
Nikita Popov [Mon, 20 Jul 2020 14:26:28 +0000 (16:26 +0200)]
Fetch pdo stmt after zpp
Nikita Popov [Mon, 20 Jul 2020 14:15:21 +0000 (16:15 +0200)]
Update method signature in test
Nikita Popov [Fri, 17 Jul 2020 15:18:03 +0000 (17:18 +0200)]
Use zpp for PDO fetch mode
Also changing the function signatures to accept variadic args
for the fetch params. If we're already breaking Doctrine anyway,
we may as well do it properly.
Nikita Popov [Mon, 20 Jul 2020 13:29:47 +0000 (15:29 +0200)]
Fix bug #79857: Add upgrading note for exit dtor change
[ci skip]
Nikita Popov [Mon, 20 Jul 2020 13:15:23 +0000 (15:15 +0200)]
Fix bug #79868
This simply restores the code from PHP 7.4 which I incorrectly
"simplified" in master.
Nikita Popov [Mon, 20 Jul 2020 12:56:48 +0000 (14:56 +0200)]
Add common code for magic method assignment
This was repeated three times.
Christoph M. Becker [Mon, 20 Jul 2020 12:45:42 +0000 (14:45 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix #63527: DCOM does not work with Username, Password parameter
Christoph M. Becker [Mon, 20 Jul 2020 12:43:59 +0000 (14:43 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix #63527: DCOM does not work with Username, Password parameter
Christoph M. Becker [Fri, 10 Jul 2020 13:43:32 +0000 (15:43 +0200)]
Fix #63527: DCOM does not work with Username, Password parameter
We must not mix multibyte and wide character strings in the
`COAUTHIDENTITY` structure. Using wide character strings throughout
would have the advantage that the remote connection can be established
regardless of the code page of the server, but that would more likely
break BC, so we just drop the wide character string conversion of the
username.
Dmitry Stogov [Mon, 20 Jul 2020 10:49:46 +0000 (13:49 +0300)]
Fixed incorrect deoptimization info
Nikita Popov [Mon, 20 Jul 2020 09:22:47 +0000 (11:22 +0200)]
Directly assign magic methods
Instead of going through intermediary variables.
Nikita Popov [Mon, 20 Jul 2020 09:15:58 +0000 (11:15 +0200)]
Remove unused lc_class_name variable
This is probably a leftover from "old style constructor" support.
Nikita Popov [Mon, 20 Jul 2020 09:11:21 +0000 (11:11 +0200)]
Report magic method names as written
Report the name the way the user has written it, the same way we
always do.
Nikita Popov [Mon, 20 Jul 2020 09:05:33 +0000 (11:05 +0200)]
Unify magic method visibility check
This was missing entirely for the internal function case.
Dmitry Stogov [Mon, 20 Jul 2020 08:57:19 +0000 (11:57 +0300)]
Remove old code (BP_VAR_RW warning)
Nikita Popov [Mon, 20 Jul 2020 08:54:59 +0000 (10:54 +0200)]
Fix tests I missed before
Nikita Popov [Mon, 20 Jul 2020 08:51:48 +0000 (10:51 +0200)]
Unify magic method return type checks
Nikita Popov [Mon, 20 Jul 2020 08:39:43 +0000 (10:39 +0200)]
Unify static/non-static check for magic methods
And promote it to be fatal.
Nikita Popov [Mon, 20 Jul 2020 08:20:29 +0000 (10:20 +0200)]
Add missing arg num check for __set_state
Nikita Popov [Mon, 20 Jul 2020 08:11:52 +0000 (10:11 +0200)]
Clean up zend_check_magic_method_implementation
Let everything go through a common function, which fixes some
consistency issues.
Christopher Jones [Mon, 20 Jul 2020 08:09:09 +0000 (18:09 +1000)]
Merge branch 'oci8-3.0'
* oci8-3.0:
Rename OCI8 classes to use standard names so arg stub parsing works
Bump OCI8 version to 3.0 so a PHP 8 PECL release can be made
Christopher Jones [Mon, 20 Jul 2020 07:32:00 +0000 (17:32 +1000)]
Rename OCI8 classes to use standard names so arg stub parsing works
Christopher Jones [Wed, 15 Jul 2020 04:35:14 +0000 (14:35 +1000)]
Bump OCI8 version to 3.0 so a PHP 8 PECL release can be made
Nikita Popov [Mon, 20 Jul 2020 07:44:02 +0000 (09:44 +0200)]
Revert "Switch to tracing JIT by default"
This reverts commit
10b09578a89a444d9df45e75d5ce8c0826bb2efe .
This seems to cause many test failures:
Test === operator : different types [tests/lang/operators/operator_identical_basic.phpt]
Test <=> operator : different types [tests/lang/operators/operator_spaceship_basic.phpt]
comparing different variables for equality [Zend/tests/compare_001_64bit.phpt]
comparing different variables for identity [Zend/tests/compare_002_64bit.phpt]
Rebinding of ::getClosure()s [Zend/tests/closure_061.phpt]
comparing different variables (greater than) [Zend/tests/compare_003_64bit.phpt]
comparing different variables (less than) [Zend/tests/compare_004_64bit.phpt]
comparing different variables (greater or equal than) [Zend/tests/compare_005_64bit.phpt]
comparing different variables (smaller or equal than) [Zend/tests/compare_006_64bit.phpt]
Invalid numeric string E_WARNINGs and E_NOTICEs, combined assignment operations [Zend/tests/numeric_string_errors_assign.phpt]
Bug #51819 (Case discrepancy in timezone names cause Uncaught exception and fatal error) [ext/date/tests/bug51819.phpt]
Test all filters returned by filter_list() [ext/filter/tests/033.phpt]
filter_var() and FILTER_VALIDATE_MAC [ext/filter/tests/055.phpt]
Test strrpos() function : usage variations - unexpected inputs for 'needle' argument [ext/standard/tests/strings/strrpos_variation10.phpt]
Test strtr() function : usage variations - empty string & null for 'str' argument [ext/standard/tests/strings/strtr_variation4.phpt]
Test strtr() function : usage variations - unexpected inputs for 'from' argument [ext/standard/tests/strings/strtr_variation6.phpt]
Test strstr() function [ext/standard/tests/strings/strstr.phpt]
Dmitry Stogov [Mon, 20 Jul 2020 06:17:04 +0000 (09:17 +0300)]
Switch to tracing JIT by default
Tyson Andre [Sun, 19 Jul 2020 01:22:57 +0000 (21:22 -0400)]
Skip upload_2G.phpt if disk_free_space() <= 2GB
This test failed when the free disk space is close to 2.15GB.
I see the file size in the .out file as 0.
PHP has to save the full file contents to disk (the path is in `$_FILES`)
Related to GH-5283
Closes GH-5873
Nikita Popov [Fri, 17 Jul 2020 14:54:15 +0000 (16:54 +0200)]
Use proper methods for php_user_filter implementation
These are dummy methods, but should at least check zpp for
arginfo consistency.
Nikita Popov [Fri, 17 Jul 2020 14:50:09 +0000 (16:50 +0200)]
Move SessionHandler sanity checks after zpp
Nikita Popov [Fri, 17 Jul 2020 14:42:21 +0000 (16:42 +0200)]
Only set DIT type on successful initialization
Nikita Popov [Fri, 17 Jul 2020 14:11:30 +0000 (16:11 +0200)]
Remove spurious return true from DOMXPath::registerPhpFunctions()
Only one of three identical cases returned true, and the function
is documented to return void. Remove the outlier.
Nikita Popov [Fri, 17 Jul 2020 14:10:49 +0000 (16:10 +0200)]
Use string|array type in DOMXPath::registerPhpFunctions()
Nikita Popov [Fri, 17 Jul 2020 14:04:55 +0000 (16:04 +0200)]
Add missing zpp_none call in Exception::__wakeup
Nikita Popov [Fri, 17 Jul 2020 14:03:08 +0000 (16:03 +0200)]
Convert SPL fatal error to Error exception
George Peter Banyard [Thu, 16 Jul 2020 19:07:01 +0000 (21:07 +0200)]
Drop useless zend_accel_script_persistable() function
George Peter Banyard [Thu, 16 Jul 2020 19:00:28 +0000 (21:00 +0200)]
Drop unused param in zend_parse_arg_class_name_or_obj()
Benjamin Eberlei [Fri, 17 Jul 2020 13:51:09 +0000 (15:51 +0200)]
Add error notification callbacks to UPGRADING.INTERNALS
Nikita Popov [Fri, 17 Jul 2020 13:42:56 +0000 (15:42 +0200)]
Parse parameters in zend_test_void_return()
Nikita Popov [Fri, 17 Jul 2020 13:41:50 +0000 (15:41 +0200)]
Fix some pgsql arginfos
And make sure too few/many arguments throws, to satisfy the
function signature.
Nikita Popov [Fri, 17 Jul 2020 13:31:22 +0000 (15:31 +0200)]
Some zpp cleanup in pgsql
Nikita Popov [Fri, 17 Jul 2020 13:24:24 +0000 (15:24 +0200)]
Remove some zpp quiet uses in pgsql
These functions don't do anything special, just use normal zpp.
Nikita Popov [Fri, 17 Jul 2020 13:13:00 +0000 (15:13 +0200)]
Add missing image_type_to_extension() argument
Nikita Popov [Fri, 17 Jul 2020 13:09:29 +0000 (15:09 +0200)]
Fixed bug #79867
In line with usual rules, give untyped properties a null default
value. Otherwise constructor promotion would give you a property
declaration that cannot be achieved through any other means.
Benjamin Eberlei [Mon, 27 Apr 2020 06:20:56 +0000 (08:20 +0200)]
Introduce error notification callbacks that are run independant of zend_error_cb
Nikita Popov [Fri, 17 Jul 2020 12:51:16 +0000 (14:51 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fixed bug #79839
Nikita Popov [Fri, 17 Jul 2020 12:50:22 +0000 (14:50 +0200)]
Fixed bug #79839
Add reference type sources in array_walk.
Nikita Popov [Fri, 17 Jul 2020 10:40:05 +0000 (12:40 +0200)]
Fix IntlGregorianCalendar constructor signature
Give these conversative UNKNOWN defaults and no types, as the
overload is something of a mess.
Dmitry Stogov [Fri, 17 Jul 2020 10:03:35 +0000 (13:03 +0300)]
Side exit on overflow
Nikita Popov [Fri, 17 Jul 2020 08:34:49 +0000 (10:34 +0200)]
Throw correct exception from ArrayObject sort methods
Let normal zpp throw ArgumentCountErrors.
Nikita Popov [Fri, 17 Jul 2020 08:28:48 +0000 (10:28 +0200)]
Add missing param to DatePeriod::__construct()
The signature is very overloaded, but takes at most four params,
not three.
Dmitry Stogov [Fri, 17 Jul 2020 08:07:22 +0000 (11:07 +0300)]
JMP optimization
Dmitry Stogov [Fri, 17 Jul 2020 07:13:23 +0000 (10:13 +0300)]
Eliminate useless exception checks
Dmitry Stogov [Thu, 16 Jul 2020 21:40:10 +0000 (00:40 +0300)]
Eliminate some reference-counting
Nikita Popov [Thu, 16 Jul 2020 20:41:28 +0000 (22:41 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Revert "Drop freetype from i386"
Nikita Popov [Thu, 16 Jul 2020 19:17:21 +0000 (21:17 +0200)]
Revert "Drop freetype from i386"
This reverts commit
8641d76f62273f3a73449fd720c93c63992f3b5a .
This appears to work again now...
Nikita Popov [Thu, 16 Jul 2020 19:16:30 +0000 (21:16 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix azure i386 build
Nikita Popov [Thu, 16 Jul 2020 14:09:41 +0000 (16:09 +0200)]
Fix azure i386 build
Purge libsqlite3-0 to make sure we get the i386 library lateron.
Nikita Popov [Thu, 16 Jul 2020 18:46:45 +0000 (20:46 +0200)]
Fix WeakReference::create() stub
Dmitry Stogov [Thu, 16 Jul 2020 17:07:51 +0000 (20:07 +0300)]
cleanup
Christoph M. Becker [Thu, 16 Jul 2020 07:09:12 +0000 (09:09 +0200)]
Fix #79805: sapi_windows_vt100_support throws TypeError
It does not make sense to throw a `TypeError` when the stream can't be
analyzed. If `sapi_windows_vt100_support()` is used as getter, we just
return `false` in that case; if the function is used as setter, we
additionally trigger a warning.
We also fix the test cases for this function, which have been broken
before. Note that these tests are still whitespace sensitive.
Christoph M. Becker [Wed, 15 Jul 2020 16:45:55 +0000 (18:45 +0200)]
Fix #79846:
8c67c166996 broke simple regexp
We backport the respective upstream fix[1].
[1] <https://vcs.pcre.org/pcre2?view=revision&revision=1267>
Dmitry Stogov [Thu, 16 Jul 2020 14:09:14 +0000 (17:09 +0300)]
cleanup
Christoph M. Becker [Thu, 16 Jul 2020 14:08:07 +0000 (16:08 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Enable further tests on Windows
Christoph M. Becker [Thu, 16 Jul 2020 11:09:50 +0000 (13:09 +0200)]
Enable further tests on Windows
Dmitry Stogov [Thu, 16 Jul 2020 12:14:11 +0000 (15:14 +0300)]
Check type guard on result of FETCH_OBJ_R/IS instructions
Remi Collet [Thu, 16 Jul 2020 10:05:58 +0000 (12:05 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
#79657 was cherry-picked in 7.4.7
Remi Collet [Thu, 16 Jul 2020 10:05:45 +0000 (12:05 +0200)]
#79657 was cherry-picked in 7.4.7
Christoph M. Becker [Thu, 16 Jul 2020 07:18:45 +0000 (09:18 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix readlink related memory leak
Christoph M. Becker [Wed, 15 Jul 2020 15:28:24 +0000 (17:28 +0200)]
Fix readlink related memory leak
Dmitry Stogov [Wed, 15 Jul 2020 21:19:00 +0000 (00:19 +0300)]
Fixed tracing JIT for ASSIGN to typed reference
Pedro Magalhães [Thu, 16 Apr 2020 17:53:13 +0000 (18:53 +0100)]
Ignore inheritance rules on private methods
Closes GH-5401
Christoph M. Becker [Wed, 15 Jul 2020 14:39:54 +0000 (16:39 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix tests regarding negative fileinode()
Christoph M. Becker [Wed, 15 Jul 2020 11:19:27 +0000 (13:19 +0200)]
Fix tests regarding negative fileinode()
The results of `fileinode()` may be negative due to wrap-around
behavior (at least on Windows as of PHP 7.4.0).
Dmitry Stogov [Wed, 15 Jul 2020 14:28:46 +0000 (17:28 +0300)]
Check type guard on result of FETCH_DIM_R/IS instructions
Nikita Popov [Wed, 15 Jul 2020 13:10:50 +0000 (15:10 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix bug #78008: dns_check_record() always return true on Alpine
Nikita Popov [Wed, 15 Jul 2020 13:10:28 +0000 (15:10 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix bug #78008: dns_check_record() always return true on Alpine
Andy Postnikov [Tue, 14 Jul 2020 01:14:05 +0000 (04:14 +0300)]
Fix bug #78008: dns_check_record() always return true on Alpine
- free handle before return result
- cleaned up remaining usage of MAXPACKET
- update dns_get_mx() to use the same approach
Closes GH-5854.
Nikita Popov [Wed, 15 Jul 2020 13:00:45 +0000 (15:00 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fixed bug #79862
Nikita Popov [Wed, 15 Jul 2020 12:59:55 +0000 (14:59 +0200)]
Fixed bug #79862
While normally a private property in the active scope would take
priority, we should not use this if it has the wrong "staticness".
Nikita Popov [Wed, 15 Jul 2020 08:59:32 +0000 (10:59 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fixed bug #79820
Christopher Broadbent [Wed, 15 Jul 2020 04:47:21 +0000 (14:47 +1000)]
Fixed bug #79820
Similar to what is done for ReflectionType itself, copy the
type name stored inside ReflectionProperty. Also make sure the
type field is always initialized for dynamic properties.
This is a non-issue in PHP 8, because we store a pointer to the
property_info there, rather than a copy.
Nikita Popov [Wed, 15 Jul 2020 07:51:14 +0000 (09:51 +0200)]
Remove type argument from zend_get_zval_ptr
As pointed out by Levi, this is unused, and we already changed
the signature of this function for PHP 8.
Christopher Jones [Wed, 15 Jul 2020 03:43:04 +0000 (13:43 +1000)]
Retrofit description of recent PR changes
Nikita Popov [Tue, 14 Jul 2020 14:10:04 +0000 (16:10 +0200)]
Reduce scope of preload compiler_options
Only set preloading compiler_options while executing the preload
file, not when performing linking afterwards. Otherwise options
like IGNORE_INTERNAL_CLASSES will hide classes from inheritance
verification.
Nikita Popov [Tue, 14 Jul 2020 13:24:58 +0000 (15:24 +0200)]
Fix preloading of union typed property inherited from internal class
Tricky edge case: We inherit a property from an internal class,
in which case no property duplication takes place. We should not
try to persist the property info in that case. This didn't really
matter previously, but now that the property has some non-interned
owned data (the type), we need to make sure we don't try to free
that.
Nikita Popov [Tue, 14 Jul 2020 12:44:35 +0000 (14:44 +0200)]
Check for name vs ce in a few more places
The type lists may contain CEs, we should not assume they only
contain names.
Dmitry Stogov [Tue, 14 Jul 2020 12:15:08 +0000 (15:15 +0300)]
Tracing JIT for SWITCH instructions
Dmitry Stogov [Tue, 14 Jul 2020 12:14:21 +0000 (15:14 +0300)]
Better support for 64-bit .aword constants
Nikita Popov [Tue, 14 Jul 2020 10:59:04 +0000 (12:59 +0200)]
Fix preloading property type resolution
This was causing many failures under --preload...
Nikita Popov [Tue, 14 Jul 2020 10:44:06 +0000 (12:44 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Nikita Popov [Tue, 14 Jul 2020 10:43:58 +0000 (12:43 +0200)]
Merge remote-tracking branch 'upstream/PHP-7.4' into PHP-7.4
* upstream/PHP-7.4:
Fix test for x86 Windows
Nikita Popov [Tue, 14 Jul 2020 10:43:03 +0000 (12:43 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fixed bug #79849
Nikita Popov [Tue, 14 Jul 2020 10:42:46 +0000 (12:42 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fixed bug #79849