taglib
15 years agoBump version numbers
Lukáš Lalinský [Sat, 31 Oct 2009 09:23:58 +0000 (09:23 +0000)]
Bump version numbers

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1042955 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoA little more complex checking for broken files
Lukáš Lalinský [Sat, 31 Oct 2009 08:59:40 +0000 (08:59 +0000)]
A little more complex checking for broken files

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1042948 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoMake sure we are not trying to read a file where MP4 atom header != 8 bytes
Lukáš Lalinský [Sat, 31 Oct 2009 08:36:26 +0000 (08:36 +0000)]
Make sure we are not trying to read a file where MP4 atom header != 8 bytes

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1042945 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoFixed ID3v1-style genre to string conversion in MP4 files
Lukáš Lalinský [Thu, 29 Oct 2009 15:53:20 +0000 (15:53 +0000)]
Fixed ID3v1-style genre to string conversion in MP4 files

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1042312 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoSupport for MP4 cover art
Lukáš Lalinský [Sat, 24 Oct 2009 16:55:54 +0000 (16:55 +0000)]
Support for MP4 cover art

CCMAIL:martin.trashbox@gmail.com

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1039809 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoReturn NULL/false rather than crash when accessing file attributes in FileRef
Lukáš Lalinský [Sat, 24 Oct 2009 12:45:58 +0000 (12:45 +0000)]
Return NULL/false rather than crash when accessing file attributes in FileRef

BUG:209417

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1039724 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoChangelog for 1.6.1
Lukáš Lalinský [Sat, 24 Oct 2009 12:22:10 +0000 (12:22 +0000)]
Changelog for 1.6.1

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1039711 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoProper .oga file handling in FileRef
Lukáš Lalinský [Sat, 24 Oct 2009 12:17:08 +0000 (12:17 +0000)]
Proper .oga file handling in FileRef

This fixes a problem introduced in r983337. OGA files are mostly likely going
to be Ogg::FLAC, if applications are following the Xiph recommendation. But
they can be using any Ogg codec, so we must check multiple formats (Sound Juicer
on Ubuntu used to produce .oga files for Ogg Vorbis, I believe it doesn't do that
anymore).

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1039708 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoDon't wrote the Vorbis framing bit to OggFLAC files
Lukáš Lalinský [Sat, 24 Oct 2009 12:01:40 +0000 (12:01 +0000)]
Don't wrote the Vorbis framing bit to OggFLAC files

https://bugs.launchpad.net/maxosx/+bug/445970
http://www.hydrogenaudio.org/forums/index.php?showtopic=75263

CCMAIL:me@sbooth.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1039704 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoSet visibility("default") for GCC on exported symbols
Lukáš Lalinský [Sat, 24 Oct 2009 11:07:41 +0000 (11:07 +0000)]
Set visibility("default") for GCC on exported symbols

This does nothing with the current configuration, but it's useful if you compile the library with -fvisibility=hidden

Patch by Modestas Vainius

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1039693 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoAdd missing exports for a few public ID3v1 functions
Lukáš Lalinský [Tue, 20 Oct 2009 16:45:10 +0000 (16:45 +0000)]
Add missing exports for a few public ID3v1 functions

Patch by Modestas Vainius

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1038114 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoFix typo in taglib_c.pc
Lukáš Lalinský [Tue, 20 Oct 2009 16:41:59 +0000 (16:41 +0000)]
Fix typo in taglib_c.pc

Patch by Modestas Vainius to fix a bug reported in Debian - http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=524696

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1038111 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoFix copy+paste typos
Jeff Mitchell [Wed, 14 Oct 2009 14:44:15 +0000 (14:44 +0000)]
Fix copy+paste typos

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1035209 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoAlways use #include "XXX" in TagLib's code
Lukáš Lalinský [Fri, 9 Oct 2009 21:03:59 +0000 (21:03 +0000)]
Always use #include "XXX" in TagLib's code

Patch by Stephen F. Booth, thanks!

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1033289 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoThis value should be bool, not int
Lukáš Lalinský [Mon, 14 Sep 2009 10:25:34 +0000 (10:25 +0000)]
This value should be bool, not int

Since bool and int have the same size on x86 architectures, this worked for
me, but since they have a different size on ppc64, it caused the test to
fail. See http://marc.info/?l=taglib-devel&m=125291701231305&w=2 for details.

We should store the type in MP4::Item and do some type checking to avoid
mistakes like this...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1023246 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoRemove extra commas from configure.in.in v1.6
Lukáš Lalinský [Sun, 13 Sep 2009 11:30:19 +0000 (11:30 +0000)]
Remove extra commas from configure.in.in

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1022859 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoUpdate libtool version-info
Lukáš Lalinský [Sun, 13 Sep 2009 11:17:49 +0000 (11:17 +0000)]
Update libtool version-info

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1022852 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoChangelog
Lukáš Lalinský [Sun, 13 Sep 2009 11:15:54 +0000 (11:15 +0000)]
Changelog

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1022849 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoRemove a non-existing dir.
Christophe Giboudeaux [Sun, 13 Sep 2009 10:19:34 +0000 (10:19 +0000)]
Remove a non-existing dir.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1022837 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoUpgrade obsolete gnre MP4 atoms to ©gen
Lukáš Lalinský [Wed, 9 Sep 2009 20:11:29 +0000 (20:11 +0000)]
Upgrade obsolete gnre MP4 atoms to ©gen

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1021692 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoFix building of examples with ENABLE_STATIC
Lukáš Lalinský [Wed, 9 Sep 2009 18:16:38 +0000 (18:16 +0000)]
Fix building of examples with ENABLE_STATIC

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1021651 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoAdd option for building a static version of taglib
Lukáš Lalinský [Tue, 8 Sep 2009 08:52:57 +0000 (08:52 +0000)]
Add option for building a static version of taglib

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1021124 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoUse the internal config names
Lukáš Lalinský [Tue, 8 Sep 2009 07:26:12 +0000 (07:26 +0000)]
Use the internal config names

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1021106 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoAdd support for a global, installable config header
Lukáš Lalinský [Fri, 4 Sep 2009 09:29:59 +0000 (09:29 +0000)]
Add support for a global, installable config header

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1019671 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoDefine MAKE_TAGLIB_LIB from the automake build system
Lukáš Lalinský [Fri, 4 Sep 2009 09:07:27 +0000 (09:07 +0000)]
Define MAKE_TAGLIB_LIB from the automake build system

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1019659 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoFix compilation warnings
Lukáš Lalinský [Fri, 4 Sep 2009 08:50:24 +0000 (08:50 +0000)]
Fix compilation warnings

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1019655 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoAutoconf options for enabling MP4 and ASF support v1.6rc1
Lukáš Lalinský [Thu, 3 Sep 2009 19:14:12 +0000 (19:14 +0000)]
Autoconf options for enabling MP4 and ASF support

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1019514 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoFix version in configure.in.in
Lukáš Lalinský [Thu, 3 Sep 2009 18:32:16 +0000 (18:32 +0000)]
Fix version in configure.in.in

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1019491 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoUpdate docs and version numbers
Lukáš Lalinský [Thu, 3 Sep 2009 18:05:58 +0000 (18:05 +0000)]
Update docs and version numbers

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1019481 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoSplit Ogg packets larger than 64kb into multiple pages
Lukáš Lalinský [Thu, 3 Sep 2009 17:20:29 +0000 (17:20 +0000)]
Split Ogg packets larger than 64kb into multiple pages

The implementation is not very efficient, but the current Ogg
code makes it hard to write it properly. :(

Patch by Marc Halbruegge
BUG:171957

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1019459 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agosvn is weird, I have deleted this external in 1010855 already
David Faure [Tue, 18 Aug 2009 10:06:44 +0000 (10:06 +0000)]
svn is weird, I have deleted this external in 1010855 already

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1012887 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoanother tool which is not necessary in this copy
David Faure [Thu, 13 Aug 2009 14:48:07 +0000 (14:48 +0000)]
another tool which is not necessary in this copy

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1010859 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoreplace external with a copy of the admin dir, as suggested by Jeff Mitchell
David Faure [Thu, 13 Aug 2009 14:46:52 +0000 (14:46 +0000)]
replace external with a copy of the admin dir, as suggested by Jeff Mitchell

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1010858 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoreplace external with a copy of the admin dir, as suggested by Jeff Mitchell
David Faure [Thu, 13 Aug 2009 14:44:55 +0000 (14:44 +0000)]
replace external with a copy of the admin dir, as suggested by Jeff Mitchell

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1010855 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoAdd a check to not crash on corrupted files
Lukáš Lalinský [Sun, 2 Aug 2009 15:17:36 +0000 (15:17 +0000)]
Add a check to not crash on corrupted files

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1005918 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoAdd missing tests to Makefile.am
Lukáš Lalinský [Tue, 28 Jul 2009 19:08:40 +0000 (19:08 +0000)]
Add missing tests to Makefile.am

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1003760 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoAdd a changelog
Lukáš Lalinský [Tue, 28 Jul 2009 18:57:49 +0000 (18:57 +0000)]
Add a changelog

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1003757 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoHandle RIFF chunk padding and ignore trailing garbage
Lukáš Lalinský [Tue, 28 Jul 2009 18:29:39 +0000 (18:29 +0000)]
Handle RIFF chunk padding and ignore trailing garbage

This is based on patches by Marc Halbruegge, but those only deal with
read-only cases. The code now also correctly adds padding to RIFF
chunks, and calculates offsets in chunkData taking the padding into
account.

BUG:171957
BUG:175781

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1003745 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoPartial support for 64-bit atoms
Lukáš Lalinský [Fri, 24 Jul 2009 13:08:51 +0000 (13:08 +0000)]
Partial support for 64-bit atoms

We still can't handle actual 64-bit atoms, but we can handle 32-bit sizes
stored in 64 bits.

CCBUG:198730

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1001897 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoUse flac padding.
Scott Wheeler [Sun, 12 Jul 2009 21:53:18 +0000 (21:53 +0000)]
Use flac padding.

Updated patch from Toby Dickenson

BUG:107659

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@995518 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoMake docs consistant with behavior.
Scott Wheeler [Sun, 12 Jul 2009 19:54:46 +0000 (19:54 +0000)]
Make docs consistant with behavior.

BUG:178174

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@995471 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoDon't save ID3v2.2 frames.
Lukáš Lalinský [Sat, 11 Jul 2009 14:43:58 +0000 (14:43 +0000)]
Don't save ID3v2.2 frames.

Patch by Marc Halbruegge
BUG:176373

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994842 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoSupport for ID3v2.2 PIC frames
Lukáš Lalinský [Sat, 11 Jul 2009 14:27:17 +0000 (14:27 +0000)]
Support for ID3v2.2 PIC frames

Patch by Marc Halbruegge
BUG:167786

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994836 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoFix off-by-one error in ByteVectorList::split
Lukáš Lalinský [Sat, 11 Jul 2009 13:24:21 +0000 (13:24 +0000)]
Fix off-by-one error in ByteVectorList::split

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994815 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoTry to read track also from TRACKNUM and year from YEAR.
Lukáš Lalinský [Sat, 11 Jul 2009 13:17:06 +0000 (13:17 +0000)]
Try to read track also from TRACKNUM and year from YEAR.

Patch by David Bishop
BUG:144396

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994811 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoTCON parsing fixes
Lukáš Lalinský [Sat, 11 Jul 2009 12:55:36 +0000 (12:55 +0000)]
TCON parsing fixes

 * Don't join multiple 2.4 TCON fields together
 * Don't add duplicate fields for 2.3 genres where the refinement matches the ID3v1 genre

Patch by Michael Smith
BUG:188578

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994805 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoOne more check for invalid frame in AttachedPictureFrame::parseFields
Lukáš Lalinský [Fri, 10 Jul 2009 14:43:15 +0000 (14:43 +0000)]
One more check for invalid frame in AttachedPictureFrame::parseFields

Patch by Mook
BUG:168382

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994361 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoUse floting point length to calculate bitrate from the Xing header information
Lukáš Lalinský [Fri, 10 Jul 2009 14:34:04 +0000 (14:34 +0000)]
Use floting point length to calculate bitrate from the Xing header information

Patch by Mook
BUG:172556

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994337 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoMove external to anonsvn (http://svn.kde.org -> svn://anonsvn.kde.org)
Tom Albers [Sat, 4 Jul 2009 15:41:38 +0000 (15:41 +0000)]
Move external to anonsvn (http://svn.kde.org -> svn://anonsvn.kde.org)
BUG:195492

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@991290 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoBuild on Haiku
Scott Wheeler [Thu, 2 Jul 2009 20:54:32 +0000 (20:54 +0000)]
Build on Haiku

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@990628 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years ago.oga files were not processed. Fix this. The problem was that even if the extension...
Médéric Boquien [Thu, 18 Jun 2009 02:15:19 +0000 (02:15 +0000)]
.oga files were not processed. Fix this. The problem was that even if the extension was defined in defaultFileExtensions(), it was not defined in create() so the file was never processed. As a
nice side effect, it also fixes the Amarok bug that caused .oga files not to be picked up by the collection scanner.

BUG:178602

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@983337 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoFix typo
Jeff Mitchell [Mon, 15 Jun 2009 19:40:33 +0000 (19:40 +0000)]
Fix typo

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@982404 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agonot generate it on win32
Laurent Montel [Thu, 11 Jun 2009 11:13:48 +0000 (11:13 +0000)]
not generate it on win32

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@980173 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoCompilation fix for Visual C++ .NET 2003 (msvc71)
Tanguy Krotoff [Sun, 7 Jun 2009 23:07:32 +0000 (23:07 +0000)]
Compilation fix for Visual C++ .NET 2003 (msvc71)

Explanations:
/Zc:wchar_t is recognized by msvc71, /Zc:wchar_t- is not (the - is important and was introduced only with msvc >= msvc80)
Thus /Zc:wchar_t- is recognized as /Zc:wchar_t and this is not what we want :)
Default behavior of msvc71 is already /Zc:wchar_t-

Solution:
Test the msvc version and add the compiler flag only if compiler >= msvc80 (e.g MSVC_VERSION >= 1400)
Same for /D_CRT_SECURE_NO_DEPRECATE and /D_CRT_NONSTDC_NO_DEPRECATE, there were introduced with msvc >= msvc80

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@978720 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

15 years agoFix a stupid crash inside mp4file.cpp (variable not initialized)
Tanguy Krotoff [Sun, 7 Jun 2009 23:05:11 +0000 (23:05 +0000)]
Fix a stupid crash inside mp4file.cpp (variable not initialized)

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@978719 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoSimplify extension checking in FileRef
Lukáš Lalinský [Wed, 29 Apr 2009 16:00:39 +0000 (16:00 +0000)]
Simplify extension checking in FileRef

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@961189 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoAdd String:rfind
Lukáš Lalinský [Wed, 29 Apr 2009 15:57:05 +0000 (15:57 +0000)]
Add String:rfind

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@961188 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoMake FileRef handle the .mp4 extension, too
Lukáš Lalinský [Wed, 29 Apr 2009 15:46:23 +0000 (15:46 +0000)]
Make FileRef handle the .mp4 extension, too

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@961181 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoFix off-by-one error in MP4::Tag when looking for free padding to use
Lukáš Lalinský [Wed, 29 Apr 2009 15:12:19 +0000 (15:12 +0000)]
Fix off-by-one error in MP4::Tag when looking for free padding to use

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@961160 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoStyle and safety fixes backported from taglib-extras
Jeff Mitchell [Wed, 29 Apr 2009 12:55:33 +0000 (12:55 +0000)]
Style and safety fixes backported from taglib-extras

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@961000 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoThis commit adds support for building taglib-extras against taglib during kdesupport...
Jeff Mitchell [Sat, 11 Apr 2009 17:13:24 +0000 (17:13 +0000)]
This commit adds support for building taglib-extras against taglib during kdesupport build time.  If kdesupport is not what is being built, the normal system taglib is used.

This adds forward includes to taglib; these may be very useful to other projects as well, since taglib's includes are rather spread out.  The README file in the include folder has instructions for regenerating them.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@952369 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoDon't build ASF/MP4 FileRef tests if WITH_ASF/WITH_MP4 are undefined
Lukáš Lalinský [Fri, 27 Mar 2009 10:45:00 +0000 (10:45 +0000)]
Don't build ASF/MP4 FileRef tests if WITH_ASF/WITH_MP4 are undefined

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@945359 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoDetach before appending a character
Lukáš Lalinský [Wed, 25 Mar 2009 17:52:23 +0000 (17:52 +0000)]
Detach before appending a character

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@944552 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agothis modified version has the advantage that it compiles
Andreas Hartmetz [Sun, 22 Mar 2009 20:48:27 +0000 (20:48 +0000)]
this modified version has the advantage that it compiles

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@942892 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoLess of The Big Ugly in the middle of the classes.
Scott Wheeler [Sun, 22 Mar 2009 19:27:38 +0000 (19:27 +0000)]
Less of The Big Ugly in the middle of the classes.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@942880 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoAdded GCC pragma to suppress non-virtual dtor warning which is being preserved
Andrew Coles [Sun, 22 Mar 2009 19:06:05 +0000 (19:06 +0000)]
Added GCC pragma to suppress non-virtual dtor warning which is being preserved
to maintain BIC.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@942876 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoFinish making .asf readable, thanks Lukas
Jeff Mitchell [Tue, 10 Mar 2009 22:33:13 +0000 (22:33 +0000)]
Finish making .asf readable, thanks Lukas

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@937985 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoSeveral of us have seen .asf WMA files in the wild.
Jeff Mitchell [Tue, 10 Mar 2009 22:02:20 +0000 (22:02 +0000)]
Several of us have seen .asf WMA files in the wild.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@937972 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoGenerate config.h in builddir again, and fix compilation when compiling taglib alone
David Faure [Tue, 10 Mar 2009 20:27:59 +0000 (20:27 +0000)]
Generate config.h in builddir again, and fix compilation when compiling taglib alone

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@937935 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoRe-add building things depending on config.h by having it generate in the source...
Jeff Mitchell [Mon, 9 Mar 2009 22:20:50 +0000 (22:20 +0000)]
Re-add building things depending on config.h by having it generate in the source tree instead of the build tree, so that when cmake uses a non-source build dir (as it's supposed to) it can actually find the file.  I think this is messy, as AFAIK cmake shouldn't be modifying the contents of the source tree...any cmake gurus out there, feel free to let me know if there's a better way.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@937552 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoThis is surely an oversight; fix documentation
Jeff Mitchell [Mon, 9 Mar 2009 21:53:46 +0000 (21:53 +0000)]
This is surely an oversight; fix documentation

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@937541 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoPatch from Josef Radinger fixing typo in debug message.
Scott Wheeler [Fri, 16 Jan 2009 05:16:48 +0000 (05:16 +0000)]
Patch from Josef Radinger fixing typo in debug message.

BUG:30212
CCMAIL:taglib-devel@kde.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@911772 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agorevert last
Scott Wheeler [Sat, 10 Jan 2009 23:15:33 +0000 (23:15 +0000)]
revert last

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@909079 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoAlso counts as being empty.
Scott Wheeler [Sat, 10 Jan 2009 22:21:45 +0000 (22:21 +0000)]
Also counts as being empty.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@909060 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoremove debug line from mac os framework build file
Scott Wheeler [Wed, 7 Jan 2009 14:14:14 +0000 (14:14 +0000)]
remove debug line from mac os framework build file

CCMAIL:taglib-devel@kde.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@907136 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoFix build by copying strigis FindCppUnit.cmake to taglib. Build failed because CPPUNI...
Michael Jansen [Sun, 21 Dec 2008 21:46:41 +0000 (21:46 +0000)]
Fix build by copying strigis FindCppUnit.cmake to taglib. Build failed because CPPUNIT_LIBRARIES didn't
contain cppunits dependencies reported by cppunit-config.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@899928 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoSuppress warning about this check missing. if someone has a lower cmake version pleas...
Michael Jansen [Sun, 21 Dec 2008 21:46:37 +0000 (21:46 +0000)]
Suppress warning about this check missing. if someone has a lower cmake version please check
and decrease the required version if successfull.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@899927 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoShould fix the build.
Scott Wheeler [Fri, 5 Dec 2008 16:43:38 +0000 (16:43 +0000)]
Should fix the build.

CCMAIL:tbscope@gmail.com

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@892977 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agowarnings--
Scott Wheeler [Fri, 5 Dec 2008 00:37:39 +0000 (00:37 +0000)]
warnings--

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@892694 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agofix warnings
Scott Wheeler [Thu, 4 Dec 2008 12:37:36 +0000 (12:37 +0000)]
fix warnings

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@892447 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years ago-INSTALL_DIR_NAME doesn't have to be set in the toplevel CMakeLists.txt, since it...
Alexander Neundorf [Tue, 2 Dec 2008 12:06:49 +0000 (12:06 +0000)]
-INSTALL_DIR_NAME doesn't have to be set in the toplevel CMakeLists.txt, since it is already set as target property
-remove some unnecessary code
-use BIN_INSTALL_DIR for the RUNTIME destination

Alex

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@891512 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoconfig.h doesn't exist, at least in my checkout, so explicitly defining HAVE_CONFIG_H...
Jeff Mitchell [Thu, 13 Nov 2008 19:23:56 +0000 (19:23 +0000)]
config.h doesn't exist, at least in my checkout, so explicitly defining HAVE_CONFIG_H was breaking build.  I'm guessing this was a mistake, and should either be taken out, or
something needs to be fixed.

CCMAIL: lalinsky@gmail.com

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@883891 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoAdd default case switch to fix compiler warnings when ASF or MP4 are not defined.
Jeff Mitchell [Thu, 13 Nov 2008 19:19:39 +0000 (19:19 +0000)]
Add default case switch to fix compiler warnings when ASF or MP4 are not defined.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@883884 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoAdd my old WMA and MP4 code. It is disabled by default, must be explicitly enabled...
Lukáš Lalinský [Wed, 12 Nov 2008 08:17:11 +0000 (08:17 +0000)]
Add my old WMA and MP4 code. It is disabled by default, must be explicitly enabled to be compiled.

Scott: If you think this is really a bad idea, please revert.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@883108 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agotypo
Scott Wheeler [Fri, 29 Aug 2008 19:59:26 +0000 (19:59 +0000)]
typo

BUG:170036

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@854564 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoDon't try to access the string list if the item type is a locator.
Scott Wheeler [Tue, 26 Aug 2008 12:19:47 +0000 (12:19 +0000)]
Don't try to access the string list if the item type is a locator.

Allan, does this look correct?  (It at least fixes the crash...)

BUG:169810
CCMAIL:kde@carewolf.com

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@852712 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agodetach when using non-const operator[]
Scott Wheeler [Thu, 21 Aug 2008 22:56:44 +0000 (22:56 +0000)]
detach when using non-const operator[]

BUG:169389

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@850657 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoremove exec bit
Scott Wheeler [Thu, 26 Jun 2008 22:11:11 +0000 (22:11 +0000)]
remove exec bit

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@824940 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoAdd support for private frames.
Scott Wheeler [Thu, 26 Jun 2008 15:06:20 +0000 (15:06 +0000)]
Add support for private frames.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@824701 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoIf the genre string is empty don't treat it as a number.
Scott Wheeler [Tue, 24 Jun 2008 14:08:03 +0000 (14:08 +0000)]
If the genre string is empty don't treat it as a number.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@823961 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoSVN_SILENT: fix typo
Andy Goossens [Thu, 19 Jun 2008 20:44:39 +0000 (20:44 +0000)]
SVN_SILENT: fix typo

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@822327 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoadd files here
Scott Wheeler [Thu, 19 Jun 2008 14:19:31 +0000 (14:19 +0000)]
add files here

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@822217 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoProvisional .wav support. Tag writing will probably be disabled by default...
Scott Wheeler [Thu, 19 Jun 2008 11:15:39 +0000 (11:15 +0000)]
Provisional .wav support.  Tag writing will probably be disabled by default...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@822160 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agowrong copyright
Scott Wheeler [Wed, 18 Jun 2008 13:21:35 +0000 (13:21 +0000)]
wrong copyright

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@821783 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoAdd a warning here so that it's clear that this constructor is not to be used for...
Scott Wheeler [Mon, 16 Jun 2008 14:21:03 +0000 (14:21 +0000)]
Add a warning here so that it's clear that this constructor is not to be used for setting the
object's data.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@821128 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoFix reading of POPM rating -- it's unsigned char, not just char
Lukáš Lalinský [Thu, 22 May 2008 20:40:14 +0000 (20:40 +0000)]
Fix reading of POPM rating -- it's unsigned char, not just char

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@811387 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoSupport for POPM ID3 frame
Lukáš Lalinský [Thu, 22 May 2008 12:06:45 +0000 (12:06 +0000)]
Support for POPM ID3 frame

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@811137 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agofix install_name RPATH stuff on OSX
Benjamin Reed [Tue, 20 May 2008 15:17:15 +0000 (15:17 +0000)]
fix install_name RPATH stuff on OSX

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@810378 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoPrevious was me being stupid and too-quick on the commit button. Need unistd as well...
Adriaan de Groot [Tue, 20 May 2008 09:29:09 +0000 (09:29 +0000)]
Previous was me being stupid and too-quick on the commit button. Need unistd as well for read, write.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@810229 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

16 years agoNeed plain <fcntl.h> for open and its flags, not necessarily sys/fcntl.h
Adriaan de Groot [Tue, 20 May 2008 09:20:19 +0000 (09:20 +0000)]
Need plain <fcntl.h> for open and its flags, not necessarily sys/fcntl.h

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@810223 283d02a7-25f6-0310-bc7c-ecb5cbfe19da