granicus.if.org Git - imagemagick/log

revise dcm rescale and window handling

The DICOM reader was multiplying pixel values by `rescale_slope`, which
it represented as `ssize_t`. Many DICOM files use double values for
`rescale_slope`, so for `rescale_slope` < 1, the reader was multiplying by
zero and producing blank images.

This patch changes `rescale_slope` and `rescale_intercept` to be double,
so dcm read now works with fractional values of rescale. A new option,
`dcm:rescale` turns rescale processing on. It is off by default for
compatibility with older versions.

The `window_center` and `window_width` fields must also be held as doubles.
These fields are now only interpreted if rescale processing is enabled,
since according to the spec, they should operate upon the rescaled
values.

A second new option, `dcm:window`, lets users overrride the
`window_center` and `window_width` fields from the file with their own
settings. This is a standard feature in other DICOM software.

Forum thread:

https://www.imagemagick.org/discourse-server/viewtopic.php?f=3&t=31887&p=145852

Related PRs:

https://github.com/ImageMagick/ImageMagick/pull/477
https://github.com/ImageMagick/ImageMagick/pull/483
https://github.com/ImageMagick/Website/pull/1

DICOM spec:

https://www.dabsoft.ch/dicom/3/C.11.2.1.2/

commit | commitdiff | tree

Cristy [Tue, 9 May 2017 11:11:02 +0000 (07:11 -0400)]

https://www.imagemagick.org/discourse-server/viewtopic.php?f=3&t=31855

commit | commitdiff | tree

Cristy [Tue, 9 May 2017 00:02:18 +0000 (20:02 -0400)]

https://www.imagemagick.org/discourse-server/viewtopic.php?f=3&t=31879

commit | commitdiff | tree

Cristy [Mon, 8 May 2017 23:44:23 +0000 (19:44 -0400)]

https://www.imagemagick.org/discourse-server/viewtopic.php?f=3&t=31862

commit | commitdiff | tree

Cristy [Mon, 8 May 2017 23:43:27 +0000 (19:43 -0400)]

https://www.imagemagick.org/discourse-server/viewtopic.php?f=3&t=31862

commit | commitdiff | tree

Dirk Lemstra [Sun, 7 May 2017 20:43:29 +0000 (22:43 +0200)]

Fixed incorrect page offset reported in #463 and #479.

commit | commitdiff | tree

Cristy [Sun, 7 May 2017 18:26:08 +0000 (14:26 -0400)]

https://github.com/ImageMagick/ImageMagick/issues/463

commit | commitdiff | tree

Dirk Lemstra [Sun, 7 May 2017 14:21:19 +0000 (16:21 +0200)]

Line length fix.

commit | commitdiff | tree

Kevin Gregull [Sun, 7 May 2017 13:54:13 +0000 (15:54 +0200)]

Fixed missing absolute value

Fixed bogus code that didn't allow for DrawSetTextInterlineSpacing,DrawSetTextKerning & DrawSetInterwordSpacing to be changed, because of a missing absolute value.

commit | commitdiff | tree

Dirk Lemstra [Sun, 7 May 2017 10:17:31 +0000 (12:17 +0200)]

Fixed memory leak reported in #476.

commit | commitdiff | tree

Dirk Lemstra [Sun, 7 May 2017 10:12:24 +0000 (12:12 +0200)]

Fixed various memory leaks reported in #475.

commit | commitdiff | tree

Dirk Lemstra [Sun, 7 May 2017 09:54:08 +0000 (11:54 +0200)]

Code cleanup.

commit | commitdiff | tree

Dirk Lemstra [Sun, 7 May 2017 09:13:07 +0000 (11:13 +0200)]

Replace image in list to fix issue reported in #467.