Craig Topper [Mon, 19 Aug 2019 18:15:50 +0000 (18:15 +0000)]
[X86] Teach lowerV4I32Shuffle to only use broadcasts if the mask has more than one undef element. Prioritize shifts over broadcast in lowerV8I16Shuffle.
The motivating case are the changes in vector-reduce-add.ll where
we were doing extra work in the scalar domain instead of shuffling.
There may be some one use check that needs to be looked into there,
but this patch sidesteps the issue by avoiding broadcasts that
aren't really broadcasting.
Differential Revision: https://reviews.llvm.org/D66071
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369287
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 19 Aug 2019 18:02:24 +0000 (18:02 +0000)]
[CGP] Remove ModifiedDT from the makeBitReverse loop
I don't think anything in this loop modifies the control flow and we don't restart any iteration after setting the flag.
This code was added in http://reviews.llvm.org/D16893 but looking at the test case added there the code that caused the dominator tree to change was merging blocks with their predecessor not the bitreverse optimization.
Differential Revision: https://reviews.llvm.org/D66366
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369283
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrea Di Biagio [Mon, 19 Aug 2019 17:07:26 +0000 (17:07 +0000)]
[X86] Added extensive scheduling model tests for all the CMPXCHG variants. NFC
Addresses a review comment in D66424
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369279
91177308-0d34-0410-b5e6-
96231b3b80d8
Stefan Stipanovic [Mon, 19 Aug 2019 16:39:32 +0000 (16:39 +0000)]
[Attributor] -attributor-verify has false positives. Temporarily remove
it, until resolved.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369277
91177308-0d34-0410-b5e6-
96231b3b80d8
Pavel Labath [Mon, 19 Aug 2019 15:40:49 +0000 (15:40 +0000)]
Filesystem/Windows: fix inconsistency in readNativeFileSlice API
Summary:
The windows version implementation of readNativeFileSlice, was trying to
match the POSIX behavior of not treating EOF as an error, but it was
only handling the case of reading from a pipe. Attempting to read past
the end of a regular file returns a slightly different error code, which
needs to be handled too. This patch adds ERROR_HANDLE_EOF to the list of
error codes to be treated as an end of file, and adds some unit tests
for the API.
This issue was found while attempting to land D66224, which caused a bunch of
lldb tests to start failing on windows.
Reviewers: rnk, aganea
Subscribers: kristina, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66344
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369269
91177308-0d34-0410-b5e6-
96231b3b80d8
Roman Lebedev [Mon, 19 Aug 2019 15:01:42 +0000 (15:01 +0000)]
[TargetLowering] x s% C == 0 fold: vector divisor with INT_MIN handling
Summary:
The general fold is only valid for positive divisors.
Which effectively means, it is invalid for `INT_MIN` divisors,
and we currently bailout if we see them.
But that is too strict, we can just fix-up the results.
For that, let's do a second computation 'in parallel':
```
Name: srem -> and
Pre: isPowerOf2(C)
%o = srem i8 %X, C
%r = icmp eq %o, 0
=>
%n = and i8 %X, C-1
%r = icmp eq %n, 0
```
https://rise4fun.com/Alive/Sup
And then just blend results: if the divisor was `INT_MIN`,
pick the value we got via bit-test,
else pick the value from general fold.
There's interesting observation - `ISD::ROTR` is set to
`LegalizeAction::Expand` before AVX512, so we should not
treat `INT_MIN` divisor as even; and as it can be seen
while `@test_srem_odd_even_one` improves on all run-lines,
`@test_srem_odd_even_INT_MIN` only improves for AVX512.
Reviewers: RKSimon, craig.topper, spatel
Reviewed By: RKSimon
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66300
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369268
91177308-0d34-0410-b5e6-
96231b3b80d8
Serge Guelton [Mon, 19 Aug 2019 14:40:33 +0000 (14:40 +0000)]
[nfc] Silent gcc warning
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369266
91177308-0d34-0410-b5e6-
96231b3b80d8
George Rimar [Mon, 19 Aug 2019 14:35:08 +0000 (14:35 +0000)]
[llvm-objdump] - Restore lost comment.
It was removed by mistake in r369263 (D66417).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369265
91177308-0d34-0410-b5e6-
96231b3b80d8
Amaury Sechet [Mon, 19 Aug 2019 14:34:08 +0000 (14:34 +0000)]
Automatically generate AVX512 test cases. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369264
91177308-0d34-0410-b5e6-
96231b3b80d8
George Rimar [Mon, 19 Aug 2019 14:32:23 +0000 (14:32 +0000)]
[Object/COFF.h] - Stop returning std::error_code in a few methods. NFCI.
There are 4 methods that return std::error_code now,
though they do not have to because they are always succeed.
I refactored them.
This allows to simplify the code in tools a bit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369263
91177308-0d34-0410-b5e6-
96231b3b80d8
Jinsong Ji [Mon, 19 Aug 2019 14:19:04 +0000 (14:19 +0000)]
[PeepholeOptimizer] Don't assume bitcast def always has input
Summary:
If we have a MI marked with bitcast bits, but without input operands,
PeepholeOptimizer might crash with assert.
eg:
If we apply the changes in PPCInstrVSX.td as in this patch:
[(set v4i32:$XT, (bitconvert (v16i8 immAllOnesV)))]>;
We will get assert in PeepholeOptimizer.
```
llvm-lit llvm-project/llvm/test/CodeGen/PowerPC/build-vector-tests.ll -v
llvm-project/llvm/include/llvm/CodeGen/MachineInstr.h:417: const
llvm::MachineOperand &llvm::MachineInstr::getOperand(unsigned int)
const: Assertion `i < getNumOperands() && "getOperand() out of range!"'
failed.
```
The fix is to abort if we found out of bound access.
Reviewers: qcolombet, MatzeB, hfinkel, arsenm
Reviewed By: qcolombet
Subscribers: wdng, arsenm, steven.zhang, wuzish, nemanjai, hiraditya, kbarton, MaskRay, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65542
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369261
91177308-0d34-0410-b5e6-
96231b3b80d8
Alex Bradbury [Mon, 19 Aug 2019 13:23:02 +0000 (13:23 +0000)]
[RISCV] Don't force absolute FK_Data_X fixups to relocs
The current behavior of shouldForceRelocation forces relocations for the
majority of fixups when relaxation is enabled. This makes sense for
fixups which incorporate symbols but is unnecessary for simple data
fixups where the fixup target is already resolved to an absolute value.
Differential Revision: https://reviews.llvm.org/D63404
Patch by Edward Jones.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369257
91177308-0d34-0410-b5e6-
96231b3b80d8
David Stenberg [Mon, 19 Aug 2019 12:41:22 +0000 (12:41 +0000)]
[DebugInfo] Allow bundled calls in the MIR's call site info
Summary:
Extend the MIR parser and writer so that the call site information can
refer to calls that are bundled.
Reviewers: aprantl, asowda, NikolaPrica, djtodoro, ivanbaev, vsk
Reviewed By: aprantl
Subscribers: arsenm, hiraditya, llvm-commits
Tags: #debug-info, #llvm
Differential Revision: https://reviews.llvm.org/D66145
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369256
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Mon, 19 Aug 2019 12:41:09 +0000 (12:41 +0000)]
[SLP] add test that requires shuffle of scalars; NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369255
91177308-0d34-0410-b5e6-
96231b3b80d8
Fangrui Song [Mon, 19 Aug 2019 12:18:18 +0000 (12:18 +0000)]
[llvm-readobj] unwrapOrError: remove unnecessary llvm_unreachable after r369194
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369254
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Mon, 19 Aug 2019 11:39:56 +0000 (11:39 +0000)]
[SLP] reduce duplicated code; NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369250
91177308-0d34-0410-b5e6-
96231b3b80d8
Fangrui Song [Mon, 19 Aug 2019 10:05:59 +0000 (10:05 +0000)]
[MC] Simplify ELFObjectWriter::recordRelocation. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369248
91177308-0d34-0410-b5e6-
96231b3b80d8
Jeremy Morse [Mon, 19 Aug 2019 09:53:07 +0000 (09:53 +0000)]
[DebugInfo] Make postra sinking of DBG_VALUEs subregister-safe
Currently the machine instruction sinker identifies DBG_VALUE insts that
also need to sink by comparing register numbers. Unfortunately this isn't
safe, because (after register allocation) a DBG_VALUE may read a register
that aliases what's being sunk. To fix this, identify the DBG_VALUEs that
need to sink by recording & examining their register units. Register units
gives us the following guarantee:
"Two registers overlap if and only if they have a common register unit"
[MCRegisterInfo.h]
Thus we can always identify aliasing DBG_VALUEs if the set of register
units read by the DBG_VALUE, and the register units of the instruction
being sunk, intersect. (MachineSink already uses classes like
"LiveRegUnits" for determining sinking validity anyway).
The test added checks for super and subregister DBG_VALUE reads of a sunk
copy being sunk as well.
Differential Revision: https://reviews.llvm.org/D58191
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369247
91177308-0d34-0410-b5e6-
96231b3b80d8
Sam Tebbs [Mon, 19 Aug 2019 09:38:28 +0000 (09:38 +0000)]
[ARM] Add support for MVE vaddv
This patch adds vecreduce_add and the relevant instruction selection for
vaddv.
Differential revision: https://reviews.llvm.org/D66085
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369245
91177308-0d34-0410-b5e6-
96231b3b80d8
David Green [Mon, 19 Aug 2019 09:13:22 +0000 (09:13 +0000)]
[ARM] MVE sext costs
This adds some sext costs for MVE, taken from the length of assembly sequences
that we currently generate.
Differential Revision: https://reviews.llvm.org/D66010
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369244
91177308-0d34-0410-b5e6-
96231b3b80d8
Jeremy Morse [Mon, 19 Aug 2019 09:02:18 +0000 (09:02 +0000)]
[DebugInfo] Test for variable range un-coalescing
LiveDebugVariables can coalesce ranges of variable locations across
multiple basic blocks. However when it recreates DBG_VALUE instructions,
it has to recreate one DBG_VALUE per block, otherwise it doesn't
represent the pre-regalloc layout and variable assignments can go missing.
This feature works -- however while mucking around with LiveDebugVariables,
I commented the relevant code it out and no tests failed. Thus, here's a
test that checks LiveDebugVariables preserves DBG_VALUEs across block
boundaries.
Differential Revision: https://reviews.llvm.org/D66347
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369243
91177308-0d34-0410-b5e6-
96231b3b80d8
David L. Jones [Mon, 19 Aug 2019 08:00:08 +0000 (08:00 +0000)]
Revert [Attributor] Fix: Make sure we set the changed flag
This reverts r369159 (git commit
cbaf1fdea2de891bdbc49cdec89ae2077e6b9ed0)
r369160 caused a test to fail under UBSAN. See thread on llvm-commits.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369241
91177308-0d34-0410-b5e6-
96231b3b80d8
Fangrui Song [Mon, 19 Aug 2019 07:59:35 +0000 (07:59 +0000)]
[MC] Delete unnecessary diagnostic: "No relocation available to represent this relative expression"
Replace
- error: No relocation available to represent this relative expression
with
+ error: symbol 'undef' can not be undefined in a subtraction expression
or
+ error: Cannot represent a difference across sections
Keep !IsPcRel as an assertion after the two diagnostic checks are done.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369239
91177308-0d34-0410-b5e6-
96231b3b80d8
David L. Jones [Mon, 19 Aug 2019 07:16:24 +0000 (07:16 +0000)]
Revert [Attributor] Fix: Do not partially resolve returned calls.
This reverts r369160 (git commit
f72d9b1c97b41fff48ad1eecbba59a29c171bff4)
r369160 caused some tests to fail under UBSAN. See thread on llvm-commits.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369236
91177308-0d34-0410-b5e6-
96231b3b80d8
Seiya Nuta [Mon, 19 Aug 2019 06:45:48 +0000 (06:45 +0000)]
Revert r369230 and r369231
Looks these commits break CI builds:
- http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-gn/builds/4159
This commit reverts r369230 and r369231 (git coommit:
4a198a7 and
dee9546).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369234
91177308-0d34-0410-b5e6-
96231b3b80d8
Fangrui Song [Mon, 19 Aug 2019 06:17:30 +0000 (06:17 +0000)]
[MC] Don't emit .symver redirected symbols to the symbol table
GNU as keeps the original symbol in the symbol table for defined @ and
@@, but suppresses it in other cases (@@@ or undefined). The original
symbol is usually undesired:
In a shared object, the original symbol can be localized with a version
script, but it is hard to remove/localize in an archive:
1) a post-processing step removes the undesired original symbol
2) consumers (executable) of the archive are built with the
version script
Moreover, it can cause linker issues like binutils PR/18703 if the
original symbol name and the base name of the versioned symbol is the
same (both ld.bfd and gold have some code to work around defined @ and
@@). In lld, if it sees f and f@v1:
--version-script =(printf 'v1 {};') => f and f@v1
--version-script =(printf 'v1 { f; };') => f@v1 and f@@v1
It can be argued that @@@ added on 2000-11-13 corrected the @ and @@ mistake.
This patch catches some more multiple version errors (defined @ and @@),
and consistently suppress the original symbol. This addresses all the
problems listed above.
If the user wants other aliases to the versioned symbol, they can copy
the original symbol to other symbol names with .set directive, e.g.
.symver f, f@v1 # emit f@v1 but not f into .symtab
.set f_impl, f # emit f_impl into .symtab
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369233
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 19 Aug 2019 05:45:39 +0000 (05:45 +0000)]
[X86] Teach lower1BitShuffle to match right shifts with upper zero elements on types that don't natively support KSHIFT.
We can support these by widening to a supported type,
then shifting all the way to the left and then
back to the right to ensure that we shift in zeroes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369232
91177308-0d34-0410-b5e6-
96231b3b80d8
Seiya Nuta [Mon, 19 Aug 2019 05:41:33 +0000 (05:41 +0000)]
[llvm-objcopy][MachO] Implement a layout algorithm for executables
Summary: The layout algorithm for relocatable objects and for executable are somewhat different. This patch implements the latter one based on the algorithm in LLD (MachOFileLayout).
Reviewers: alexshap, rupprecht, jhenderson
Reviewed By: alexshap
Subscribers: jakehehrlich, abrachet, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65539
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369231
91177308-0d34-0410-b5e6-
96231b3b80d8
Seiya Nuta [Mon, 19 Aug 2019 05:37:38 +0000 (05:37 +0000)]
[llvm-objcopy][MachO] Support load commands used in executables/shared libraries
Summary:
This patch implements copying some load commands that appear in executables/shared libraries such as the indirect symbol table.
I don't add tests intentionally because this patch is incomplete: we need a layout algorithm for executables/shared libraries. I'll submit it as a separate patch with tests.
Reviewers: alexshap, rupprecht, jhenderson, compnerd
Reviewed By: alexshap
Subscribers: abrachet, mgorny, mgrang, MaskRay, mtrent, jakehehrlich, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D63395
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369230
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 19 Aug 2019 04:08:44 +0000 (04:08 +0000)]
[X86] Fix the lower1BitShuffle code added in r369215 to correctly pass the widened vector to the KSHIFT node.
Not sure how to test this as we have tests that exercise this code,
but nothing failed for the types not matching. Since all the k-registers
use equivalent register classes everything just ends up working.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369228
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 19 Aug 2019 04:08:40 +0000 (04:08 +0000)]
[X86] Teach lower1BitShuffle to match KSHIFTR that doesn't use Zeroable and only relies on undef.
This allows us to widen the type when the KSHIFTR instruction
doesn't exist for the type. If we need to shift in zeroes into
the upper elements we would need more work to guarantee zeroes
when widening.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369227
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 19 Aug 2019 00:39:22 +0000 (00:39 +0000)]
[X86] Teach lower1BitShuffle to recognize padding a subvector with zeros with V2 as the source and V1 as the zero vector.
Shuffle canonicalization can swap the sources so the zero vector
might be V1 and the subvector that's being padded can be V2.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369226
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 19 Aug 2019 00:39:18 +0000 (00:39 +0000)]
[X86] Add test case for missed opportunity to recognize a vXi1 shuffle as an insert into a zero vector.
We are currently missing this because shuffle canonicalization
puts the zero vector as V1 and the subvector as V2. Our current
code doesn't recognize this case.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369225
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 18 Aug 2019 23:30:11 +0000 (23:30 +0000)]
[X86] Add a special case to LowerCONCAT_VECTORSvXi1 to handle concatenating zero vectors followed by one non-zero vector followed by undef vectors.
For such a case we should only need a KSHIFTL, but we were
previously generating a KSHIFTL followed by a KSHIFTR because
we mistakenly believed we need to zero the undef elements.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369224
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 18 Aug 2019 23:30:07 +0000 (23:30 +0000)]
[X86] Add test cases for suboptimal insertion of a vXi1 vector into a larger vector with zeros in the lower elements and undef upper elements.
Currently we generate kshifts to clear both the upper and lower
elements, but we only need one kshift.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369223
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 18 Aug 2019 23:30:03 +0000 (23:30 +0000)]
[X86] Replace uses of getZeroVector for vXi1 vectors with DAG.getConstant.
vXi1 vectors don't need special handling.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369222
91177308-0d34-0410-b5e6-
96231b3b80d8
Hubert Tong [Sun, 18 Aug 2019 22:02:24 +0000 (22:02 +0000)]
[cmake] Move blocks out of redundant else( MSVC ); NFC
Address post-commit comment on D66256 regarding the `else( MSVC )` block
containing only blocks guarded with `LLVM_COMPILER_IS_GCC_COMPATIBLE`,
which would imply `NOT MSVC`.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369221
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Sun, 18 Aug 2019 21:29:57 +0000 (21:29 +0000)]
[ORC] Make sure we linker-mangle symbol names in the SpeculationLayer.
If mangling is not performed then speculative lookups will fail.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369219
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Sun, 18 Aug 2019 21:22:14 +0000 (21:22 +0000)]
[ORC] Remove some dead code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369218
91177308-0d34-0410-b5e6-
96231b3b80d8
DeForest Richards [Sun, 18 Aug 2019 19:07:10 +0000 (19:07 +0000)]
[Docs] Test commit
Fixes typo - Removes extra space between last word of sentence and period.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369216
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 18 Aug 2019 18:52:46 +0000 (18:52 +0000)]
[X86] Improve lower1BitShuffle handling for KSHIFTL on narrow vectors.
We can insert the value into a larger legal type and shift that
by the desired amount.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369215
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Sun, 18 Aug 2019 17:26:30 +0000 (17:26 +0000)]
Fix signed/unsigned comparison warning. NFCI.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369213
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Sun, 18 Aug 2019 17:15:26 +0000 (17:15 +0000)]
[X86] isTargetShuffleEquivalent - add BUILD_VECTOR matching
Add similar functionality to isShuffleEquivalent - if the mask elements don't match, try matching the BUILD_VECTOR scalars instead.
As target shuffles need to handle SM_Sentinel values, this can get a bit tricky, so commit just adds actual mask element index handling - full SM_SentinelZero support will be added when the need arises.
Also, enables support in matchVectorShuffleWithPACK
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369212
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Sun, 18 Aug 2019 16:37:58 +0000 (16:37 +0000)]
[X86] isTargetShuffleEquivalent - early out on illegal shuffle masks. NFCI.
Simplifies shuffle mask comparisons by just bailing out if the shuffle mask has any out of range values - will make an upcoming patch much simpler.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369211
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Sun, 18 Aug 2019 15:39:04 +0000 (15:39 +0000)]
[X86][SSE] Improve PACKSS shuffle tests to better match codegen from D61129
D61129 creates 'concat + trunc' style patterns (at the 128-bit subvector level)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369209
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Sun, 18 Aug 2019 13:29:12 +0000 (13:29 +0000)]
[MC] MCFixup - Fix cppcheck + MSVC analyzer uninitialized member variable warnings. NFCI.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369208
91177308-0d34-0410-b5e6-
96231b3b80d8
Roman Lebedev [Sun, 18 Aug 2019 12:26:33 +0000 (12:26 +0000)]
[InstCombine] Cherry-pick NFC cleanups of foldShiftIntoShiftInAnotherHandOfAndInICmp() from D66383
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369207
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 18 Aug 2019 06:28:06 +0000 (06:28 +0000)]
[TargetLowering] Teach computeRegisterProperties to only widen v3i16/v3f16 vectors to the next power of 2 type if that's legal.
These were recently made simple types. This restores their
behavior back to something like their EVT legalization.
We might be able to fix the code in type legalization where the
assert was failing, but I didn't investigate too much as I had
already looked at the computeRegisterProperties code during the
review for v3i16/v3f16.
Most of the test changes restore the X86 codegen back to what
it looked like before the recent change. The test case in
vec_setcc.ll and is a reduced version of the reproducer from
the fuzzer.
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=16490
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369205
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 18 Aug 2019 06:28:00 +0000 (06:28 +0000)]
[SelectionDAG] Add a node creation debug message to getMachineNode.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369204
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Sun, 18 Aug 2019 00:20:44 +0000 (00:20 +0000)]
AMDGPU: Fix iterator error when lowering SI_END_CF
If the instruction is the last in the block, there is no next
instruction but the iteration still needs to look at the new block.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369203
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Sun, 18 Aug 2019 00:20:43 +0000 (00:20 +0000)]
AMDGPU: Disambiguate v3f16 format in load/store tables
Currently the searchable tables report the number of dwords. These
round to the same number for 3 and 4 component d16
instructions. Change this to report the number of elements so this
isn't ambiguous.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369202
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Sun, 18 Aug 2019 00:20:42 +0000 (00:20 +0000)]
TableGen: Revert changes from r369038
These aren't needed for a specific use yet, and I meant to not commit
these.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369201
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sat, 17 Aug 2019 22:46:15 +0000 (22:46 +0000)]
[X86] Add a one use check to the combineStore code that handles v16i16->v16i8 truncate+store by extending to v16i32 and then emitting a v16i32->v16i8 truncstore.
This prevent us from emitting a separate truncate and a truncating
store instruction.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369200
91177308-0d34-0410-b5e6-
96231b3b80d8
Yonghong Song [Sat, 17 Aug 2019 22:12:00 +0000 (22:12 +0000)]
[BPF] Fix bpf llvm-objdump issues.
Commit https://reviews.llvm.org/D57939 ("[DWARF] Refactor
RelocVisitor and fix computation of SHT_RELA-typed relocation entries)
made a change for relocation resolution when operating
on an object file.
The change unfortunately broke BPF as given SymbolValue (S) and
Addent (A), previously relocation is resolved to
S + A
and after the change, it is resolved to
S
This patch fixed the issue by resolving relocation correctly.
It looks not all relocation resolution reaches here and I did not
trace down exactly when. But I do find if the object file includes
codes in two different ELF sections than default ".text",
the above bug will be triggered.
This patch included a trivial two function source code to
demonstrate this issue. The relocation for .debug_loc is resolved
incorrectly due to this and llvm-objdump cannot display source
annotated assembly.
Differential Revision: https://reviews.llvm.org/D66372
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369199
91177308-0d34-0410-b5e6-
96231b3b80d8
Roman Lebedev [Sat, 17 Aug 2019 21:35:33 +0000 (21:35 +0000)]
[NFC][InstCombine] Some tests for 'shift amount reassoc in bit test - trunc-of-lshr' (PR42399)
Finally, the fold i was looking forward to :)
The legality check is muddy, i doubt i've groked the full generalization,
but it handles all the cases i care about, and can come up with:
https://rise4fun.com/Alive/26j
https://bugs.llvm.org/show_bug.cgi?id=42399
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369197
91177308-0d34-0410-b5e6-
96231b3b80d8
George Rimar [Sat, 17 Aug 2019 16:07:18 +0000 (16:07 +0000)]
Recommit r369190 "[llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API."
Fix: Add a `consumeError` call removed by mistake to 'printStackSize',
this should fix the "Expected<T> must be checked before access or destruction." reported by following bot:
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/9743/steps/stage%201%20check/logs/stdio
Original commit message:
Currently we have the following functions for error reporting:
LLVM_ATTRIBUTE_NORETURN void reportError(Twine Msg);
void reportError(Error Err, StringRef Input);
void reportWarning(Twine Msg);
void reportWarning(StringRef Input, Error Err);
void warn(llvm::Error Err);
void error(std::error_code EC);
Problems are: naming is inconsistent, arguments order is inconsistent,
some of the functions looks excessive.
After applying this patch we have:
void reportError(Error Err, StringRef Input);
void reportError(std::error_code EC, StringRef Input);
void reportWarning(Error Err, StringRef Input);
I'd be happy to remove reportError(std::error_code EC, StringRef Input) too, but it
is used by COFF heavily.
Test cases were updated, they show an improvement introduced.
Differential revision: https://reviews.llvm.org/D66286
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369194
91177308-0d34-0410-b5e6-
96231b3b80d8
George Rimar [Sat, 17 Aug 2019 15:36:06 +0000 (15:36 +0000)]
Revert r369190, r369192 ([llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API.)
It caused multiple BB failtures:
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/9743/steps/stage%201%20check/logs/stdio
http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/26042/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Astack-sizes.test
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369193
91177308-0d34-0410-b5e6-
96231b3b80d8
George Rimar [Sat, 17 Aug 2019 15:24:16 +0000 (15:24 +0000)]
[llvm-readobj] - An attemp to fix BB after r369191.
Few BB failed with the following error:
Command Output (stderr):
--
/home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/test/tools/llvm-readobj/stack-sizes.test:263:19: error: BADSECTION-OUT: expected string not found in input
# BADSECTION-OUT: 8 ?
^
<stdin>:4:1: note: scanning from here
^
It doesn't reproduce on ubuntu/windows I have. Also, seems many of the bots
are happy too.
This slightly reorders the code to make fouts().flush() call earlier,
like it was before the r369191.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369192
91177308-0d34-0410-b5e6-
96231b3b80d8
Kang Zhang [Sat, 17 Aug 2019 14:37:05 +0000 (14:37 +0000)]
[CodeGen] Do the Simple Early Return in block-placement pass to optimize the blocks
Summary:
Fix a bug of preducessors.
In `block-placement` pass, it will create some patterns for unconditional we can do the simple early retrun.
But the `early-ret` pass is before `block-placement`, we don't want to run it again.
This patch is to do the simple early return to optimize the blocks at the last of `block-placement`.
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D63972
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369191
91177308-0d34-0410-b5e6-
96231b3b80d8
George Rimar [Sat, 17 Aug 2019 14:36:40 +0000 (14:36 +0000)]
[llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API.
urrently we have the following functions for error reporting:
--
LLVM_ATTRIBUTE_NORETURN void reportError(Twine Msg);
void reportError(Error Err, StringRef Input);
void reportWarning(Twine Msg);
void reportWarning(StringRef Input, Error Err);
void warn(llvm::Error Err);
void error(std::error_code EC);
---
Problems are: naming is inconsistent, arguments order is inconsistent,
some of the functions looks excessive.
After applying this patch we have:
---
LLVM_ATTRIBUTE_NORETURN void reportError(Error Err, StringRef Input);
LLVM_ATTRIBUTE_NORETURN void reportError(std::error_code EC, StringRef Input);
void reportWarning(Error Err, StringRef Input);
---
I'd be happy to remove reportError(std::error_code EC, StringRef Input) too, but it
is used by COFF heavily.
Test cases were updated, they show an improvement introduced.
Differential revision: https://reviews.llvm.org/D66286
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369190
91177308-0d34-0410-b5e6-
96231b3b80d8
George Rimar [Sat, 17 Aug 2019 14:23:30 +0000 (14:23 +0000)]
[test] - Remove precomiled openbsd-phdrs.elf-x86-64 objects.
There are 2 similar openbsd-phdrs.elf-x86-64 objects committed and
used in test/Object and test/tools/llvm-objdump test cases.
There is no reason to have them, we can use YAML instead. Patch does that.
Differential revision: https://reviews.llvm.org/D66342
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369189
91177308-0d34-0410-b5e6-
96231b3b80d8
Troy A. Johnson [Sat, 17 Aug 2019 14:20:41 +0000 (14:20 +0000)]
[circular_raw_ostream] Delegate is_displayed to contained stream
raw_ostream has an is_displayed() member function that determines if the stream
is connected to a console for display or is connected to a file/pipe. By
default, is_displayed() returns false, and derived classes like raw_fd_ostream
override it. Because circular_raw_ostream wraps another stream, its result for
is_displayed() should be the same as that stream.
Differential Revision: https://reviews.llvm.org/D66026
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369188
91177308-0d34-0410-b5e6-
96231b3b80d8
Paul Walker [Sat, 17 Aug 2019 09:22:36 +0000 (09:22 +0000)]
Revert Revert [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta instructions.
This reverts r369132 (git commit
19301d75f086caae1a495d267f5d0264b225942d)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369186
91177308-0d34-0410-b5e6-
96231b3b80d8
Paul Walker [Sat, 17 Aug 2019 09:22:28 +0000 (09:22 +0000)]
Revert [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta instructions.
This reverts r369133 (git commit
2632c677f85cba1ac2aef5d68aaf8af0f5b3c944)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369185
91177308-0d34-0410-b5e6-
96231b3b80d8
Alina Sbirlea [Sat, 17 Aug 2019 01:02:12 +0000 (01:02 +0000)]
[MemorySSA] Loop passes should mark MSSA preserved when available.
This patch applies only to the new pass manager.
Currently, when MSSA Analysis is available, and pass to each loop pass, it will be preserved by that loop pass.
Hence, mark the analysis preserved based on that condition, vs the current `EnableMSSALoopDependency`. This leaves the global flag to affect only the entry point in the loop pass manager (in FunctionToLoopPassAdaptor).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369181
91177308-0d34-0410-b5e6-
96231b3b80d8
Petr Hosek [Sat, 17 Aug 2019 00:07:26 +0000 (00:07 +0000)]
[llvm-readobj] Unwrap the value first to avoid the error
This addresses the issue introduced in r369169, we need to unwrap
the value first before we can check whether it's empty. This also
swaps the two branches to put the common path first which should
be NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369177
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Fri, 16 Aug 2019 23:47:57 +0000 (23:47 +0000)]
Add LLDB dataformatters for llvm::StringRef and lldb_private::ConstString
These data formatters make the string value appear in Xcode's
variables view (and on the command line) without having to expand the
data structure.
Differential Revision: https://reviews.llvm.org/D66354
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369175
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Fri, 16 Aug 2019 23:36:28 +0000 (23:36 +0000)]
Revert r367891 - "[InstCombine] combine mul+shl separated by zext"
This reverts commit
5dbb90bfe14ace30224239cac7c61a1422fa5144.
As noted in the post-commit thread for r367891, this can create
a multiply that is lowered to a libcall that may not exist.
We need to improve the backend decomposition for integer multiply
before trying to re-land this (if it's still worthwhile after
doing the backend work).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369174
91177308-0d34-0410-b5e6-
96231b3b80d8
Jian Cai [Fri, 16 Aug 2019 23:30:16 +0000 (23:30 +0000)]
Reland "[ARM] push LR before __gnu_mcount_nc"
This relands r369147 with fixes to unit tests.
https://reviews.llvm.org/D65019
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369173
91177308-0d34-0410-b5e6-
96231b3b80d8
Amara Emerson [Fri, 16 Aug 2019 23:23:40 +0000 (23:23 +0000)]
[AArch64][GlobalISel] Fix an assertion during G_UNMERGE selection for s128 types.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369172
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Fri, 16 Aug 2019 23:20:54 +0000 (23:20 +0000)]
[ORC] Re-introduce self-dependence accidentally dropped from a unit test.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369171
91177308-0d34-0410-b5e6-
96231b3b80d8
Petr Hosek [Fri, 16 Aug 2019 23:15:40 +0000 (23:15 +0000)]
[llvm-readobj] Fallback to PT_NOTE if file doesn't have sections
This is useful when trying to read notes from stripped files and matches
the behavior of GNU readelf and eu-readelf.
Differential Revision: https://reviews.llvm.org/D66358
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369169
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Fri, 16 Aug 2019 23:10:34 +0000 (23:10 +0000)]
[CodeGenPrepare] Fix use-after-free
If OptimizeExtractBits() encountered a shift instruction with no operands at all,
it would erase the instruction, but still return false.
This previously didn’t matter because its caller would always return after
processing the instruction, but https://reviews.llvm.org/D63233 changed the
function’s caller to fall through if it returned false, which would then cause
a use-after-free detectable by ASAN.
This change makes OptimizeExtractBits return true if it removes a shift
instruction with no users, terminating processing of the instruction.
Patch by: @brentdax (Brent Royal-Gordon)
Differential Revision: https://reviews.llvm.org/D66330
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369168
91177308-0d34-0410-b5e6-
96231b3b80d8
Jordan Rupprecht [Fri, 16 Aug 2019 23:08:56 +0000 (23:08 +0000)]
Revert [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle using DemandedElts mask (reapplied)
This reverts r368662 (git commit
1a8d790cf5f89c1df718844f13e934e39bef6ef5)
The compile-time regression repro is in https://bugs.llvm.org/show_bug.cgi?id=43024
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369167
91177308-0d34-0410-b5e6-
96231b3b80d8
Roman Lebedev [Fri, 16 Aug 2019 23:06:37 +0000 (23:06 +0000)]
[InstCombine][NFC] reuse-constant-from-select-in-icmp.ll - check branch_weights too
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369166
91177308-0d34-0410-b5e6-
96231b3b80d8
Roman Lebedev [Fri, 16 Aug 2019 22:40:06 +0000 (22:40 +0000)]
[InstCombine][NFC] Revisit tests in reuse-constant-from-select-in-icmp.ll
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369163
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Friedman [Fri, 16 Aug 2019 22:20:14 +0000 (22:20 +0000)]
[ARM] Preserve liveness in ARMConstantIslands.
We currently don't use liveness information after this point, but it can
be useful to catch bugs using -verify-machineinstrs, and optimizations
could potentially use this information in the future.
Differential Revision: https://reviews.llvm.org/D66319
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369162
91177308-0d34-0410-b5e6-
96231b3b80d8
Johannes Doerfert [Fri, 16 Aug 2019 21:59:52 +0000 (21:59 +0000)]
[Attributor] Fix: Do not partially resolve returned calls.
By partially resolving returned calls we did not record that they were
not fully resolved which caused odd behavior down the line. We could
also end up with some, but not all, returned values of the callee in the
returned values map of the caller, another odd behavior we want to
avoid.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369160
91177308-0d34-0410-b5e6-
96231b3b80d8
Johannes Doerfert [Fri, 16 Aug 2019 21:55:01 +0000 (21:55 +0000)]
[Attributor] Fix: Make sure we set the changed flag
The flag was updated *before* we actually run the visitor callback so we
might miss updates.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369159
91177308-0d34-0410-b5e6-
96231b3b80d8
Johannes Doerfert [Fri, 16 Aug 2019 21:53:49 +0000 (21:53 +0000)]
[CaptureTracking] Allow null to be in either icmp operand
Summary:
Before we required the comparison against null to be "canonical", hence
null to be operand #1. This patch allows null to be in either operand,
similar to the handling of loaded globals that follows.
Reviewers: sanjoy, hfinkel, aykevl, sstefan1, uenoku
Subscribers: hiraditya, bollu, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66321
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369158
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Fri, 16 Aug 2019 21:37:49 +0000 (21:37 +0000)]
[CodeGenPrepare] fix RUN line settings
I'm not sure if this was running as expected with a broken triple.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369156
91177308-0d34-0410-b5e6-
96231b3b80d8
Johannes Doerfert [Fri, 16 Aug 2019 21:31:11 +0000 (21:31 +0000)]
[Attributor] Add all missing attribute definitions/symbols
As a preparation to "on-demand" abstract attribute generation we need
implementations for all attributes (as they can be queried and then
created on-demand where we now fail to find one).
Reviewers: uenoku, sstefan1
Subscribers: hiraditya, bollu, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66129
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369155
91177308-0d34-0410-b5e6-
96231b3b80d8
Jonas Devlieghere [Fri, 16 Aug 2019 21:25:40 +0000 (21:25 +0000)]
[RWMutex] Simplify availability check
Check for the actual version number for the scenarios where the macOS
version isn't available (__MAC_10_12).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369154
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Fri, 16 Aug 2019 20:50:23 +0000 (20:50 +0000)]
[X86] Use Register/MCRegister in more places in X86
This was a quick pass through some obvious places. I haven't tried the clang-tidy check.
I also replaced the zeroes in getX86SubSuperRegister with X86::NoRegister which is the real sentinel name.
Differential Revision: https://reviews.llvm.org/D66363
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369151
91177308-0d34-0410-b5e6-
96231b3b80d8
Jian Cai [Fri, 16 Aug 2019 20:40:21 +0000 (20:40 +0000)]
Revert "[ARM] push LR before __gnu_mcount_nc"
This reverts commit
f4cf3b959333f62b7a7b2d7771f7010c9d8da388.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369149
91177308-0d34-0410-b5e6-
96231b3b80d8
Jian Cai [Fri, 16 Aug 2019 20:21:08 +0000 (20:21 +0000)]
[ARM] push LR before __gnu_mcount_nc
Push LR register before calling __gnu_mcount_nc as it expects the value of LR register to be the top value of
the stack on ARM32.
Differential Revision: https://reviews.llvm.org/D65019
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369147
91177308-0d34-0410-b5e6-
96231b3b80d8
Johannes Doerfert [Fri, 16 Aug 2019 19:51:23 +0000 (19:51 +0000)]
[Attributor] Towards a more structured deduction pattern
Summary:
This is the first commit aiming to structure the attribute deduction.
The base idea is that we have default propagation patterns as listed
below on top of which we can add specific, e.g., context sensitive,
logic.
Deduction patterns used in this patch:
- argument states are determined from call site argument states,
see AAAlignArgument and AAArgumentFromCallSiteArguments.
- call site argument states are determined as if they were floating
values, see AAAlignCallSiteArgument and AAAlignFloating.
- floating value states are determined by traversing the def-use chain
and combining the states determined for the leaves, see
AAAlignFloating and genericValueTraversal.
- call site return states are determined from function return states,
see AAAlignCallSiteReturned and AACallSiteReturnedFromReturned.
- function return states are determined from returned value states,
see AAAlignReturned and AAReturnedFromReturnedValues.
Through this strategy all logic for alignment is concentrated in the
AAAlignFloating::updateImpl method.
Note: This commit works on its own but is part of a larger change that
involves "on-demand" creation of abstract attributes that will
participate in the fixpoint iteration. Without this part, we sometimes
do not have an AAAlign abstract attribute to query, loosing information
we determined before. All tests have appropriate FIXMEs and the
information will be recovered once we added all parts.
Reviewers: sstefan1, uenoku
Subscribers: hiraditya, bollu, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66126
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369144
91177308-0d34-0410-b5e6-
96231b3b80d8
Johannes Doerfert [Fri, 16 Aug 2019 19:49:00 +0000 (19:49 +0000)]
[Attributor][NFC] Introduce aliases for call site attributes
Until we have call site specific liveness and/or value information there
is no need to do call site specific deduction. Though, we need the
symbols in follow up patches that make Attributor::getAAFor return a
reference.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369143
91177308-0d34-0410-b5e6-
96231b3b80d8
Johannes Doerfert [Fri, 16 Aug 2019 19:36:17 +0000 (19:36 +0000)]
[Attributor] Introduce initialize calls and move code to keep attributes concise
Summary:
This patch should not change the behavior except that the added
initialize methods might indicate an optimistic fixpoint earlier. The
code movement is done to keep the attribute definitions in a single
block where it makes sense. No functional changes intended there.
Reviewers: uenoku, sstefan1
Subscribers: hiraditya, bollu, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66258
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369142
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Fri, 16 Aug 2019 19:33:37 +0000 (19:33 +0000)]
[ORC] Remove some stray debugging output accidentally left in r368707
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369141
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Fri, 16 Aug 2019 18:51:30 +0000 (18:51 +0000)]
[InstCombine] canonicalize a scalar-select-of-vectors to vector select
This pattern may arise more frequently with an enhancement to SLP vectorization suggested in PR42755:
https://bugs.llvm.org/show_bug.cgi?id=42755
...but we should handle this pattern to make things easier for the backend either way.
For all in-tree targets that I looked at, codegen for typical vector sizes looks better when we change
to a vector select, so this is safe to do without a cost model (in other words, as a target-independent
canonicalization).
For example, if the condition of the select is a scalar, we end up with something like this on x86:
vpcmpgtd %xmm0, %xmm1, %xmm0
vpextrb $12, %xmm0, %eax
testb $1, %al
jne LBB0_2
## %bb.1:
vmovaps %xmm3, %xmm2
LBB0_2:
vmovaps %xmm2, %xmm0
Rather than the splat-condition variant:
vpcmpgtd %xmm0, %xmm1, %xmm0
vpshufd $255, %xmm0, %xmm0 ## xmm0 = xmm0[3,3,3,3]
vblendvps %xmm0, %xmm2, %xmm3, %xmm0
Differential Revision: https://reviews.llvm.org/D66095
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369140
91177308-0d34-0410-b5e6-
96231b3b80d8
Evgeniy Stepanov [Fri, 16 Aug 2019 18:23:54 +0000 (18:23 +0000)]
Escape % in printf format string.
Fixes branch-relax-block-size.mir on the ASan builder.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369138
91177308-0d34-0410-b5e6-
96231b3b80d8
Guanzhong Chen [Fri, 16 Aug 2019 18:21:08 +0000 (18:21 +0000)]
[WebAssembly] Forbid use of EM_ASM with setjmp/longjmp
Summary:
We tried to support EM_ASM with setjmp/longjmp in binaryen. But with dynamic
linking thrown into the mix, the code is no longer understandable and cannot
be maintained. We also discovered more bugs in the EM_ASM handling code.
To ensure maintainability and correctness of the binaryen code, EM_ASM will
no longer be supported with setjmp/longjmp. This is probably fine since the
support was added recently and haven't be published.
Reviewers: tlively, sbc100, jgravelle-google, kripken
Reviewed By: tlively, kripken
Subscribers: dschuff, hiraditya, aheejin, sunfish, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66356
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369137
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Fri, 16 Aug 2019 18:13:22 +0000 (18:13 +0000)]
[X86] resolveTargetShuffleInputs - add DemandedElts variant. NFCI.
Nothing calls this yet, everything still goes through the non (all) DemandedElts wrapper.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369136
91177308-0d34-0410-b5e6-
96231b3b80d8
Amara Emerson [Fri, 16 Aug 2019 18:06:53 +0000 (18:06 +0000)]
[AArch64][GlobalISel] Lower G_SHUFFLE_VECTOR with 1 elt src and 1 elt mask.
Again, it's weird that these are allowed. Since lowering support was added in
r368709 we started crashing on compiling the neon intrinsics test in the test
suite. This fixes the lowering to fold the 1 elt src/mask case into copies.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369135
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Fri, 16 Aug 2019 17:35:08 +0000 (17:35 +0000)]
[X86] combineExtractWithShuffle - handle extract(truncate(x), 0)
Eventually we need to generalize combineExtractWithShuffle to handle all faux shuffles and handle truncate (and X86ISD::VTRUNC etc.) there, but we're not ready yet (still creates nodes on the fly, incomplete DemandedElts support, bad use of recursive Depth limit).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369134
91177308-0d34-0410-b5e6-
96231b3b80d8
Paul Walker [Fri, 16 Aug 2019 17:29:53 +0000 (17:29 +0000)]
[AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta instructions.
Recommit with fixes for mac builders.
Summary:
AArch64InstrInfo::getInstSizeInBytes is incorrectly treating meta
instructions (e.g. CFI_INSTRUCTION) as normal instructions and
giving them a size of 4.
This results in branch relaxation calculating block sizes wrong.
Branch relaxation also considers alignment and thus a single
mistake can result in later blocks being incorrectly sized even
when they themselves do not contain meta instructions.
The net result is we might not relax a branch whose destination is
not within range.
Reviewers: nickdesaulniers, peter.smith
Reviewed By: peter.smith
Subscribers: javed.absar, kristof.beyls, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66337
llvm-svn: 369111
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369133
91177308-0d34-0410-b5e6-
96231b3b80d8
Paul Walker [Fri, 16 Aug 2019 17:29:42 +0000 (17:29 +0000)]
Revert [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta instructions.
This reverts r369111 (git commit
3ccee5f7c4087ed119dbeba537f3df1b048a4dff)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369132
91177308-0d34-0410-b5e6-
96231b3b80d8
Vasileios Porpodas [Fri, 16 Aug 2019 17:21:18 +0000 (17:21 +0000)]
[SLPVectorizer] Make the scheduler aware of the TreeEntry operands.
Summary:
The scheduler's dependence graph gets the use-def dependencies by accessing the operands of the instructions in a bundle. However, buildTree_rec() may change the order of the operands in TreeEntry, and the scheduler is currently not aware of this. This is not causing any functional issues currently, because reordering is restricted to the operands of a single instruction. Once we support operand reordering across multiple TreeEntries, as shown here: http://www.llvm.org/devmtg/2019-04/slides/Poster-Porpodas-Supernode_SLP.pdf , the scheduler will need to get the correct operands from TreeEntry and not from the individual instructions.
In short, this patch:
- Connects the scheduler's bundle with the corresponding TreeEntry. It introduces new TE and Lane fields in ScheduleData.
- Moves the location where the operands of the TreeEntry are initialized. This used to take place in newTreeEntry() setting one operand at a time, but is now moved pre-order just before the recursion of buildTree_rec(). This is required because the scheduler needs to access both operands of the TreeEntry in tryScheduleBundle().
- Updates the scheduler to access the instruction operands through the TreeEntry operands instead of accessing the instruction operands directly.
Reviewers: ABataev, RKSimon, dtemirbulatov, Ayal, dorit, hfinkel
Reviewed By: ABataev
Subscribers: hiraditya, llvm-commits, lebedev.ri, rcorcs
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D62432
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369131
91177308-0d34-0410-b5e6-
96231b3b80d8
Jonas Devlieghere [Fri, 16 Aug 2019 17:19:57 +0000 (17:19 +0000)]
[ADT] Remove llvm::make_unique utility.
All uses of llvm::make_unique should have been replaced with
std::make_unique. This patch represents the last part of the migration
and removes the utility from LLVM.
Differential revision: https://reviews.llvm.org/D66259
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369130
91177308-0d34-0410-b5e6-
96231b3b80d8