]>
granicus.if.org Git - neomutt/log
Mehdi Abaakouk [Mon, 16 Oct 2017 13:19:06 +0000 (15:19 +0200)]
imap/notmuch tags: Add some documentation
Pietro Cerutti [Tue, 17 Oct 2017 08:24:29 +0000 (09:24 +0100)]
Let autosetup define PWD, do not unnecessarily try to create hcache dir (#847)
Issue #845
Mehdi Abaakouk [Mon, 16 Oct 2017 13:32:27 +0000 (15:32 +0200)]
tags: Show fake header for all backends
Closes #864
Pietro Cerutti [Mon, 16 Oct 2017 11:23:05 +0000 (11:23 +0000)]
Generate neomuttrc even if configured with --disable-doc
Issue #862
Kevin McCarthy [Sun, 15 Oct 2017 07:13:18 +0000 (15:13 +0800)]
Add polling for the IDLE command. (closes #3957)
Add $imap_poll_timeout poll for IDLE, since this is also a command
that will freeze after waking if $imap_idle is set.
Pietro Cerutti [Sat, 14 Oct 2017 13:08:23 +0000 (13:08 +0000)]
Allow to specify --docdir at configure time
Issue #857
Pietro Cerutti [Sat, 14 Oct 2017 12:16:54 +0000 (12:16 +0000)]
Fix neomutt.pot location, remove from git
Issue #853
Pietro Cerutti [Fri, 13 Oct 2017 14:08:08 +0000 (14:08 +0000)]
Fix update-po
Issue #853
Anton Rieger [Fri, 13 Oct 2017 11:41:16 +0000 (13:41 +0200)]
Bool: change functions in mx.h
* maildir_parse_message()
* maildir_parse_stream()
* mx_tags_is_supported()
* mx_update_tables()
Caller affected
* append_message()
* append_message()
* maildir_update_tables()
* mx_sync_mailbox()
* mx_update_tables()
Anton Rieger [Fri, 13 Oct 2017 11:07:47 +0000 (13:07 +0200)]
Refactor: Remove unused return type
* mutt_tunnel_socket_setup()
Richard Russon [Mon, 9 Oct 2017 12:39:26 +0000 (13:39 +0100)]
fix: prevent timezone overflow
On 32-bit arches it's easy to over-/under-flow the date.
We replace these with the max/min values allowed in a time_t.
When we encounter one of these dates, pretend it's UTC to prevent
another overflow.
Fixes #819
Fixes #820
Richard Russon [Sat, 7 Oct 2017 10:24:25 +0000 (11:24 +0100)]
split up 'if' statements that assign and test (2)
Split 'if' statements that combine an assignment with a test.
e.g. from:
if (!(adr = mutt_parse_adrlist(adr, buf)))
To:
adr = mutt_parse_adrlist(adr, buf);
if (!adr)
This makes the statements a little easier to read and debug.
Richard Russon [Sat, 7 Oct 2017 10:24:25 +0000 (11:24 +0100)]
split up 'if' statements that assign and test
Split 'if' statements that combine an assignment with a test.
e.g. from:
if ((pc = imap_get_flags(&(idata->flags), pc)) == NULL)
To
pc = imap_get_flags(&(idata->flags), pc);
if (!pc)
This makes the statements a little easier to read and debug.
Richard Russon [Sat, 14 Oct 2017 14:32:06 +0000 (15:32 +0100)]
merge: minor code cleanups
* move functions to library
* lib: move MIN/MAX macros
* simplify null checks
* kill preproc expansion laziness
* fix: variable type when using fread
* reduce scope of variables
Richard Russon [Wed, 4 Oct 2017 12:14:08 +0000 (13:14 +0100)]
reduce scope of variables
C99 allows a 'for' loop to define its variable.
This reduces the variable's scope making its use clearer.
Richard Russon [Tue, 10 Oct 2017 13:47:39 +0000 (14:47 +0100)]
fix: variable type when using fread
Richard Russon [Sat, 7 Oct 2017 01:19:56 +0000 (02:19 +0100)]
kill preproc expansion laziness
Replace macros which were shortcuts for code, e.g.
```
#define CUR_ENV Context->hdrs[i]->env
function(CUR_ENV);
CUR_ENV->from = "user";
#undef CUR_ENV
```
Richard Russon [Sat, 7 Oct 2017 20:37:34 +0000 (21:37 +0100)]
simplify null checks
Simplify checks:
* `if (x == NULL)` -> `if (!x)`
* `if (x != NULL)` -> `if (x)`
Richard Russon [Wed, 4 Oct 2017 18:35:07 +0000 (19:35 +0100)]
lib: move MIN/MAX macros
Remove a duplicate definition of the MIN/MAX macros.
Richard Russon [Thu, 5 Oct 2017 01:11:50 +0000 (02:11 +0100)]
move functions to library
These functions have no NeoMutt dependencies:
* imap_make_date()
* imap_parse_date()
* imap_wordcasecmp()
* rstrnstr()
Moving the functions to the library will make it easier to test them and
find common behaviour.
Richard Russon [Fri, 13 Oct 2017 12:57:26 +0000 (13:57 +0100)]
NeoMutt 2017-10-13
Richard Russon [Fri, 13 Oct 2017 12:43:00 +0000 (13:43 +0100)]
update translations
Richard Russon [Fri, 13 Oct 2017 12:29:47 +0000 (13:29 +0100)]
clang-format
Richard Russon [Fri, 13 Oct 2017 12:29:29 +0000 (13:29 +0100)]
update mailmap
Richard Russon [Fri, 13 Oct 2017 12:22:37 +0000 (13:22 +0100)]
docs: update credits
Richard Russon [Fri, 13 Oct 2017 12:21:07 +0000 (13:21 +0100)]
update changelog
Richard Russon [Fri, 13 Oct 2017 10:25:12 +0000 (11:25 +0100)]
version: 2017-10-13
Anton Rieger [Thu, 12 Oct 2017 20:04:48 +0000 (22:04 +0200)]
Deprecation: changed called function in mutt_sasl.c
* mutt_sasl_done()
Anton Rieger [Wed, 11 Oct 2017 00:01:51 +0000 (02:01 +0200)]
bool: convert struct member in mutt_regex.h
* struct Regex
* restore_default()
Pietro Cerutti [Wed, 11 Oct 2017 13:11:42 +0000 (14:11 +0100)]
Allow enabling of fmemopen (#842)
Issue #839
Mehdi Abaakouk [Tue, 10 Oct 2017 11:19:04 +0000 (13:19 +0200)]
keyword: remove doc menu entry
We remove keyword dead code in
5c600997cd0e028a237fe6847ddffa1f2c340ea6 .
This change removes the memu entry in the doc.
Closes #836
Pietro Cerutti [Tue, 10 Oct 2017 12:32:45 +0000 (12:32 +0000)]
Use mutt_sleep(0)
Issue #777
Pietro Cerutti [Tue, 10 Oct 2017 07:57:25 +0000 (07:57 +0000)]
Prefer a helpful error message over a BEEP
Issue #777
Pietro Ceruti [Tue, 10 Oct 2017 06:30:19 +0000 (06:30 +0000)]
Do not fail if deflate is not in libz
Issue #828
Nicolas Bock [Mon, 9 Oct 2017 15:22:04 +0000 (09:22 -0600)]
Rebrand `.muttdebug` to `.neomutt`
The debug files should be called `.neomuttdegub` for consistency.
Richard Russon [Tue, 10 Oct 2017 09:27:08 +0000 (10:27 +0100)]
fix: crash using uncolor (#833)
Using 'uncolor' on the last 'color' added would cause a crash.
Pietro Cerutti [Tue, 10 Oct 2017 09:26:12 +0000 (10:26 +0100)]
Sort the folders list when browsing an IMAP server (#831)
Issue #803
Pietro Cerutti [Mon, 9 Oct 2017 18:37:52 +0000 (19:37 +0100)]
If set, use -D_FILE_OFFSET_BITS=64 when checking for GPGMe (#829)
* If set, use -D_FILE_OFFSET_BITS=64 when checking for GPGMe
Issue #826
* Let OFF_T_FMT be "%" PRId64 whenever LFS is there
Issue #826
Pietro Cerutti [Mon, 9 Oct 2017 12:33:54 +0000 (12:33 +0000)]
Support EXTRA_CFLAGS and EXTRA_LDFLAGS, kill unused variable
EXTRA_CFLAGS and EXTRA_LDFLAGS can now be passed to make on the command
line. These are meant to be used for those flags that would otherwise
create problems at configure stage, like address sanitizers flags.
While at it, remove the setting of MUTT_VERSION, which is now unused.
Richard Russon [Fri, 6 Oct 2017 21:19:01 +0000 (22:19 +0100)]
docs: fix case of Notmuch
Richard Russon [Fri, 6 Oct 2017 20:44:37 +0000 (21:44 +0100)]
docs: sync to website
Nicolas Bock [Fri, 6 Oct 2017 17:35:12 +0000 (11:35 -0600)]
Install doc into `neomutt`
The documentation is installed into the `mutt` subdirectory by default.
This directory should be renamed to `neomutt`.
Richard Russon [Fri, 6 Oct 2017 14:32:20 +0000 (15:32 +0100)]
NeoMutt 2017-10-06
Richard Russon [Fri, 6 Oct 2017 14:30:52 +0000 (15:30 +0100)]
update translations
Richard Russon [Fri, 6 Oct 2017 14:13:41 +0000 (15:13 +0100)]
clang-format
Richard Russon [Fri, 6 Oct 2017 14:10:58 +0000 (15:10 +0100)]
update mailmap
Richard Russon [Fri, 6 Oct 2017 13:39:32 +0000 (14:39 +0100)]
docs: update credits
Richard Russon [Fri, 6 Oct 2017 13:35:29 +0000 (14:35 +0100)]
update changelog
Richard Russon [Fri, 6 Oct 2017 11:34:51 +0000 (12:34 +0100)]
version: 2017-10-06
Pietro Cerutti [Tue, 3 Oct 2017 08:18:26 +0000 (08:18 +0000)]
TAILQify struct Connection
Pietro Cerutti [Mon, 2 Oct 2017 11:46:28 +0000 (11:46 +0000)]
STAILQify struct ColorLine
Richard Russon [Sun, 1 Oct 2017 12:33:32 +0000 (13:33 +0100)]
fix: add more range-checking on dates/times
Richard Russon [Wed, 27 Sep 2017 18:04:39 +0000 (19:04 +0100)]
fix: overflow in mutt_mktime()
mutt_mktime() can overflow when used on 32-bit arches.
This was due to a bogus comparision.
Now, extreme future dates will be interpreted as 2038-01-19.
Fixes #794
Mehdi Abaakouk [Wed, 27 Sep 2017 05:32:52 +0000 (07:32 +0200)]
keywords: Remove dead code/doc of keywords patch
Keywords patch support have been removed by
92e6dc1d89f7187eeea1412e51598600925e23f5 .
This change removes associated config and docs.
Closes #769
Richard Russon [Tue, 3 Oct 2017 15:12:42 +0000 (16:12 +0100)]
travis: restore config
Pietro Cerutti [Fri, 11 Aug 2017 15:45:45 +0000 (15:45 +0000)]
Autosetup-based configuration
Pull #745
Richard Russon [Tue, 3 Oct 2017 12:47:51 +0000 (13:47 +0100)]
merge: keywords
* Make the notmuch tags generic
* tags: Add index_format %J
* Add IMAP keywords support
* Share label editing between imap/notmuch
* Tidying the code
* tags: always pass correct buffer length
* imap: fix memory leak
* notmuch: remove unused methods declaration
* tags: remove needs of HEADER_TAGS macro
* tags: make private method private
* tags: rename HeaderTag to TagList
* tags: remove useless ifdef
* tags: store transformed tags only if needed
* imap: Don't use keywords terminology, but flags
* tags: rename OP_MAIN_MODIFY_LABEL/TAGS
* tags: rename modify-labels/modify-tags
* tags: rename hdr_tags to driver_tags
* tags: move tags_editor and tags_commit to mx
* tags: don't depends on header.c
* tags: Don't duplicate tags allocation
* tags: fix notmuch editor return code
* tags: rename DRIVER_LABEL to DRIVER_TAGS
* always pass char to mutt_str_append_item
Mehdi Abaakouk [Thu, 21 Sep 2017 17:29:50 +0000 (19:29 +0200)]
always pass char to mutt_str_append_item
Mehdi Abaakouk [Thu, 21 Sep 2017 06:10:33 +0000 (08:10 +0200)]
tags: rename DRIVER_LABEL to DRIVER_TAGS
Mehdi Abaakouk [Thu, 21 Sep 2017 06:04:42 +0000 (08:04 +0200)]
tags: fix notmuch editor return code
Mehdi Abaakouk [Wed, 20 Sep 2017 09:05:35 +0000 (11:05 +0200)]
tags: Don't duplicate tags allocation
The HeaderTags and TagList structure can be replaced
by a simple linked list.
Mehdi Abaakouk [Wed, 20 Sep 2017 12:54:06 +0000 (14:54 +0200)]
tags: don't depends on header.c
Mehdi Abaakouk [Wed, 20 Sep 2017 12:43:48 +0000 (14:43 +0200)]
tags: move tags_editor and tags_commit to mx
This methods handles the run of dedicated methods on the mailbox, and
not the tags list manipulation.
It makes more sense to have it in mx.c like other methods with the same
purpose.
Mehdi Abaakouk [Wed, 20 Sep 2017 12:29:22 +0000 (14:29 +0200)]
tags: rename hdr_tags to driver_tags
To avoid confusion about hdr_tags and tags in X-Label headers.
This renames all hdr_tags_* in drvier_tags_*.
Mehdi Abaakouk [Tue, 19 Sep 2017 19:02:54 +0000 (21:02 +0200)]
tags: rename modify-labels/modify-tags
Mehdi Abaakouk [Tue, 19 Sep 2017 18:55:53 +0000 (20:55 +0200)]
tags: rename OP_MAIN_MODIFY_LABEL/TAGS
Mehdi Abaakouk [Tue, 19 Sep 2017 16:48:58 +0000 (18:48 +0200)]
imap: Don't use keywords terminology, but flags
Mehdi Abaakouk [Tue, 19 Sep 2017 14:54:13 +0000 (16:54 +0200)]
tags: store transformed tags only if needed
Mehdi Abaakouk [Tue, 19 Sep 2017 12:05:09 +0000 (14:05 +0200)]
tags: remove useless ifdef
OP_MAIN_MODIFY_LABELS and OP_MAIN_MODIFY_LABELS_THEN_HIDE no more
an notmuch thing. So make them always compiled.
Mehdi Abaakouk [Mon, 18 Sep 2017 22:04:44 +0000 (00:04 +0200)]
tags: rename HeaderTag to TagList
Mehdi Abaakouk [Mon, 18 Sep 2017 21:20:23 +0000 (23:20 +0200)]
tags: make private method private
Mehdi Abaakouk [Mon, 18 Sep 2017 21:19:37 +0000 (23:19 +0200)]
tags: remove needs of HEADER_TAGS macro
Mehdi Abaakouk [Mon, 18 Sep 2017 17:06:19 +0000 (19:06 +0200)]
notmuch: remove unused methods declaration
Mehdi Abaakouk [Fri, 15 Sep 2017 17:44:26 +0000 (19:44 +0200)]
imap: fix memory leak
In imap_commit_message_tags() cmd is not freed in case of error.
Mehdi Abaakouk [Fri, 15 Sep 2017 20:18:43 +0000 (22:18 +0200)]
tags: always pass correct buffer length
In notmuch editor we was passing sizeof(buf) with buf a char* with an
unknown allocated size.
In imap, we have assumed/hardcoded LONGSTRING. That's true, but we
should not do that.
edit_msg_tags() now takes the buflen as parameter so the root caller
can pass the size of the buffer.
Mehdi Abaakouk [Fri, 21 Jul 2017 21:34:18 +0000 (23:34 +0200)]
Tidying the code
Mehdi Abaakouk [Tue, 21 Feb 2017 09:50:35 +0000 (10:50 +0100)]
Share label editing between imap/notmuch
Mehdi Abaakouk [Mon, 20 Feb 2017 19:49:23 +0000 (20:49 +0100)]
Add IMAP keywords support
This change introduces IMAP keyword support.
* index_format gets %g, %G, %J and %Gx to display them
* pattern gets g to search/match imap keywords
* colors.c gets index_tag/index_tags to color them
* OPS gets modify-labels to edit them
* tag-transforms/tag-formats/hidden_tags can be display them in more sexy manner
Most of the code is shared with the notmuch backend.
Upstream: https://dev.mutt.org/trac/ticket/3210
Closes neomutt/neomutt#225
Mehdi Abaakouk [Mon, 20 Feb 2017 20:20:50 +0000 (21:20 +0100)]
tags: Add index_format %J
This change adds %J to index_format, to be able to show message tags
only when they are different from the previous one in a thread.
Mehdi Abaakouk [Tue, 14 Feb 2017 09:45:45 +0000 (10:45 +0100)]
Make the notmuch tags generic
This change make the notmuch tags generic.
This is in preparation of reusing it for imap keywords feature.
Richard Russon [Mon, 2 Oct 2017 12:01:56 +0000 (13:01 +0100)]
merge: upstream fixes (mutt/default)
* Fix uses of context->changed as a counter.
* Make cmd_parse_fetch() more precise about setting reopen/check flags.
* Enable $reply_self for group-reply, even with $metoo unset.
Roger Pau Monne [Thu, 28 Sep 2017 18:57:56 +0000 (11:57 -0700)]
Enable $reply_self for group-reply, even with $metoo unset.
For a (r)eply, the $metoo variable does not have any effect because
there is a single recipient.
However with (g)roup reply, the To was initially set to the sender,
but subsequently removed my $nometoo. The empty To line is then
replaced with the Cc line, resulting in a (logically correct but)
surprising outcome.
Change the behavior such that $nometoo will not strip a single To
recipient when $reply_self is set.
Kevin McCarthy [Wed, 27 Sep 2017 20:45:36 +0000 (13:45 -0700)]
Make cmd_parse_fetch() more precise about setting reopen/check flags.
Previously any FETCH with FLAGS would result in either
idata->reopen |= IMAP_EXPUNGE_PENDING;
-or-
idata->check_status = IMAP_FLAGS_PENDING;
being set.
This is unnecessary in the case of responses to FLAGS.SILENT updates
sent by mutt (which seem to commonly happen now-a-days).
Change imap_set_flags() to compare the old server flags against the
new ones, and report when _those_ updates would/did result in a local
header flag change. Only set one of the reopen/check_status flags in
the event of an actual change (or potential change if a local change
has been made to the header.)
Kevin McCarthy [Wed, 27 Sep 2017 02:44:11 +0000 (19:44 -0700)]
Fix uses of context->changed as a counter.
The first was in mx_update_tables(), but only when "not committing".
This is used by mh/maildir during an "occult" update, and in imap when
expunging the mailbox. It meant to simply turn on changed when a
single changed header is seen.
The second use was in imap_sync_message_for_copy(). Previously this
was used for a server side copy/save, but is now also used for
fast-trash copying. Remove the code that was trying to decrement the
counter: this function is not capable of properly setting a status
bit.
Jelle van der Waa [Thu, 21 Sep 2017 19:41:11 +0000 (21:41 +0200)]
pgpewrap: free opts on exit
opts is allocated with malloc, but never free'd in both exit scenario's
leading to a memory leak of opts.
Jelle van der Waa [Thu, 21 Sep 2017 19:36:49 +0000 (21:36 +0200)]
pgpewrap: remove duplicate if statement
The condition argc <= 1 is equal to argc < 2, remove the duplicate argc
<2 statement.
Jelle van der Waa [Sun, 1 Oct 2017 16:48:34 +0000 (18:48 +0200)]
imap: Fix mx.mbox leak in imap_get_parent_path
valgrind reports a memory leak in imap_get_parent_path due to no
free'ing mx.mbox. As described in imap_parse_path, the callee should
free mx.mbox.
Richard Russon [Sat, 30 Sep 2017 21:41:05 +0000 (22:41 +0100)]
fix: crash using notmuch expando with imap
The NotMuch code didn't check for a NotMuch mailbox when dereferencing
Header->data.
Thanks to @xunam.
Fixes #805
Anton Rieger [Sat, 30 Sep 2017 20:19:19 +0000 (22:19 +0200)]
bool: include missing stdbool.h header
Anton Rieger [Sat, 30 Sep 2017 13:04:49 +0000 (15:04 +0200)]
bool: convert function parameters in mutt_notmuch.h
* nm_longrun_init()
Affected static functions in mutt_notmuch.c
* append_message()
* append_replies()
* append_thread()
* do_database_open()
* get_db()
* get_query()
* get_query_string()
* is_longrun()
* read_mesgs_query()
* read_threads_query()
Anton Rieger [Tue, 26 Sep 2017 23:59:20 +0000 (01:59 +0200)]
Padded and sorted prototypes in init.h
Anton Rieger [Tue, 26 Sep 2017 22:12:50 +0000 (00:12 +0200)]
spacing: Align function prototypes in init.h
Richard Russon [Fri, 29 Sep 2017 18:30:18 +0000 (19:30 +0100)]
fix: digest_collapse was broken (#801)
A recent upstream change stopped $digest_collapse from working.
The outer mime container wasn't being checked for type 'multipart/digest'.
A digest nested within another mime container should also be collapsed.
Fixes #789
Richard Russon [Fri, 29 Sep 2017 18:29:49 +0000 (19:29 +0100)]
Fix some problems with autoconf (#793)
* build: restore tabs in configure.ac
No functional changes
* build: fix out-of-tree build
* Built items in /doc weren't being installed.
* Force install to /usr/lib, not /usr/lib64
* build: stop yes/no include dirs
A bug in the curses detection often lead to things like:
* -Ino/include -Lno/lib
* -Iyes/include -Lyes/lib
Richard Russon [Fri, 29 Sep 2017 13:10:52 +0000 (14:10 +0100)]
clang-format
Pietro Cerutti [Fri, 29 Sep 2017 10:22:38 +0000 (10:22 +0000)]
STAILQify struct CryptModules
Anton Rieger [Thu, 28 Sep 2017 21:43:12 +0000 (23:43 +0200)]
bool: convert function parameters in mutt.h
* mutt_matches_ignore()
Anton Rieger [Thu, 28 Sep 2017 19:32:10 +0000 (21:32 +0200)]
bool: convert extern variable in mbyte.h
* Charset_is_utf8
* mutt_hcache_restore()
* mutt_set_charset()
Charset_is_utf8 affects `convert` in mutt_set_charset() and mutt_hcache_restore()
-> affects several static functions in hcache/hcache.c
* dump_address()
* dump_body()
* dump_buffer()
* dump_char()
* dump_char_size()
* dump_envelope()
* dump_parameter()
* dump_stailq()
* restore_address()
* restore_body()
* restore_buffer()
* restore_char()
* restore_envelope()
* restore_parameter()
* restore_stailq()
Richard Russon [Tue, 26 Sep 2017 23:17:56 +0000 (00:17 +0100)]
merge: rename mutt to neomutt
* rename man pages
* move helper programs to lib dir
* move mime.types to doc dir
* contrib: change mutt references to neomutt
* build: don't install .dist files
Richard Russon [Tue, 26 Sep 2017 22:36:05 +0000 (23:36 +0100)]
build: don't install .dist files